Re: libgo patch committed: Add riscv and js/wasm

2018-06-11 Thread Ian Lance Taylor
On Mon, Jun 11, 2018 at 12:22 PM, Palmer Dabbelt wrote: > On Mon, 11 Jun 2018 12:16:39 PDT (-0700), i...@golang.org wrote: >> >> This libgo patch add riscv and js/wasm as known targets. This >> incorporates cut down versions of https://golang.org/cl/102835 and >> https://golang.org/cl/106256 from

Re: fix libcc1 dependencies in toplevel Makefile

2018-06-11 Thread Alexandre Oliva
On Jun 3, 2018, Alexandre Oliva wrote: > On Jun 27, 2017, Alexandre Oliva wrote: >> configuration, because the current Makefile would only do that with >> all-host, after bootstrap is complete. > I have extensively studied the dependencies, and I still don't see how > all-libcc1, that is only

Re: [PATCH] ltmain.sh: Sort input file list

2018-06-11 Thread Eric Gallager
On 6/11/18, Jeff Law wrote: > On 06/11/2018 11:06 AM, Joseph Myers wrote: >> If we're not doing a general update from upstream libtool, I think we >> should use the upstream ltmain.sh fix (libtool commit >> 74c8993c178a1386ea5e2363a01d919738402f30, it looks like), or follow it as >> >> close as po

Re: [PATCH] PR target/85358, v3: Make PowerPC not convert __ibm128 to __float128 if long double is IEEE 128-bit

2018-06-11 Thread Michael Meissner
On Mon, Jun 11, 2018 at 07:31:44PM -0400, Michael Meissner wrote: > This patch is a complete rework of the previous patch. Previously I used new > target hooks to provide IFmode (__ibm128) from being widened by default to > TFmode (long double) on power9 systems when long double is IEEE 128-bit. >

Re: [PATCH] PR target/85358, v3: Make PowerPC not convert __ibm128 to __float128 if long double is IEEE 128-bit

2018-06-11 Thread Michael Meissner
This patch is a complete rework of the previous patch. Previously I used new target hooks to provide IFmode (__ibm128) from being widened by default to TFmode (long double) on power9 systems when long double is IEEE 128-bit. This patch reorganizes the 3 128-bit floating point types, so that IFmod

Re: Tighten LRA test for reloading the inner reg of a paradoxical subreg

2018-06-11 Thread Jeff Law
On 05/30/2018 06:31 AM, Richard Sandiford wrote: > Kyrill Tkachov writes: >> Hi Richard, >> >> On 29/05/18 15:26, Richard Sandiford wrote: >>> Kyrill Tkachov writes: Hi all, The recent changes to aarch64_expand_vector_init cause an ICE in the attached testcase. The register

Re: [ping] Use response files from the driver in more cases

2018-06-11 Thread Jeff Law
On 06/04/2018 01:27 AM, Eric Botcazou wrote: > https://gcc.gnu.org/ml/gcc-patches/2018-04/msg01172.html OK. jeff

Re: [RFC] Add gcc.dg-selftests/dg-final.exp

2018-06-11 Thread Jeff Law
On 05/30/2018 04:41 AM, Tom de Vries wrote: > Hi, > > this patch tests the error behaviour of dg-final directives when called with > an > incorrect number of arguments. > > The test is lazy, in that it doesn't bother to pass correct arguments, > assuming > that the number of arguments check is

Re: Use poly_int rtx accessors instead of hwi accessors

2018-06-11 Thread Jeff Law
On 05/30/2018 12:39 AM, Richard Sandiford wrote: > [ Update of: https://gcc.gnu.org/ml/gcc-patches/2018-01/msg00661.html ] > > This patch generalises various places that used hwi rtx accessors so > that they can handle poly_ints instead. In many cases these changes > are by inspection rather than

Re: [PATCH] relax -Wsizeof-pointer-memaccess for strncpy with size of source (PR 85931)

2018-06-11 Thread Jeff Law
On 05/29/2018 08:57 PM, Martin Sebor wrote: > Warning for a strncpy call whose bound is the same as the size > of the source and suggesting to use the size of the source is > less than helpful when both sizes are the same, as in: > >   char a[4], b[4]; >   strncpy (a, b, sizeof b); > > The attach

C++ PATCH for c++/85792, -Wctor-dtor-privacy and inherited ctor

2018-06-11 Thread Jason Merrill
-Wctor-dtor-privacy thinks it can see all the constructors in a class template, but inheriting constructors still look like a USING_DECL there, so we need to look for that. Tested x86_64-pc-linux-gnu, applying to trunk and 8. commit 4b974abbaaaeb214f52824d990d0966b3b80fc36 Author: Jason Merrill D

C++ PATCH for c++/85963, -Wunused-but-set-variable with ?: in template

2018-06-11 Thread Jason Merrill
In this testcase we were pulling out the constant value of the variable without ever calling mark_rvalue_use, which is needed for proper handling of lambda captures. This lack also lead to this false positive warning. Tested x86_64-pc-linux-gnu, applying to trunk and 8. commit e3359de1378a74fd049

Re: [PATCH] Fix lower-subreg ICE (PR target/85945)

2018-06-11 Thread Jeff Law
On 05/29/2018 02:41 AM, Jakub Jelinek wrote: > Hi! > > We ICE on the following testcase, because lower-subreg sees only > SFmode subregs of a multi-word pseudo (V4SFmode) and decides to decompose > it. Decomposition is done through replacing the multi-word pseudo with > a concat of word-sized int

Re: [PATCH] vx-common.h: add #define USE_TM_CLONE_REGISTRY 0

2018-06-11 Thread Jeff Law
On 05/25/2018 04:49 PM, Rasmus Villemoes wrote: > 2018-05-26 Rasmus Villemoes > > gcc/ > * config/vx-common.h (USE_TM_CLONE_REGISTRY): #define to 0. Thanks. Installed on the trunk. jeff

Re: [PATCH] Fix PR c++/85400

2018-06-11 Thread Eric Botcazou
> Eric, do you plan to backport this to release branches? I don't think so, it isn't a regression and the workaround is trivial. -- Eric Botcazou

Re: [PATCH] restore -Wstringop-overflow for checked strcpy/strcat (PR 85259)

2018-06-11 Thread Jeff Law
On 05/14/2018 04:41 PM, Martin Sebor wrote: > r256683 committed to GCC 8 to avoiding duplicate instances of > -Wstringop-overflow warnings on some targets has the unintended > side-effect of suppressing even singleton instances of the warning > in cases such as 'strcat (strcpy (buf, "hello "), "wor

Re: [PATCH] spellcheck: support transpositions aka Damerau-Levenshtein (PR other/69968)

2018-06-11 Thread Jeff Law
On 04/30/2018 06:37 PM, David Malcolm wrote: > This patch updates the edit-distance algorithm in spellcheck.c to > support transpositions as well as additions/deletions/substitutions, > so that a transposition error counts as a distance of 1 rather than 2. > > This leads to saner suggestions for s

Re: [PATCH] libbacktrace: Support FreeBSD/DragonFlyBSD/NetBSD without /proc

2018-06-11 Thread Jeff Law
On 03/01/2018 03:07 PM, Bryan Drewery wrote: > From: Bryan Drewery > > FreeBSD has had this patch against Rust's bundled libbacktrace for a > while which allows not having /proc mounted to get the process name. > I am open to refactoring this if there's a better place to handle > some of this, su

Re: [PATCH] update Zero-length array documentation

2018-06-11 Thread Martin Sebor
On 06/11/2018 02:03 PM, Richard Sandiford wrote: Martin Sebor writes: On 06/11/2018 12:08 PM, Richard Sandiford wrote: Martin Sebor writes: @@ -1553,12 +1553,28 @@ struct line *thisline = (struct line *) thisline->length = this_length; @end smallexample -In ISO C90, you would have to give

C++ PATCH for comparison of pointers to union members

2018-06-11 Thread Jason Merrill
At the C++ meeting last week it came up that pointers to different members of the same union are specified to compare as equal, which we were getting wrong. Tested x86_64-pc-linux-gnu, applying to trunk. commit bdaca661a7dd74d703f089af7b4484e098884510 Author: Jason Merrill Date: Tue Jun 5 15:57

Re: [PATCH] add missing @opindex to Warning Options

2018-06-11 Thread Martin Sebor
On 06/11/2018 01:20 PM, Jeff Law wrote: On 06/07/2018 09:21 PM, Eric Gallager wrote: On 6/7/18, Martin Sebor wrote: A bunch of warning options are missing an @opindex entry, usually for the negative form. I went through them all and added them where it made sense. Unless there are objections

Re: [PATCH] update Zero-length array documentation

2018-06-11 Thread Richard Sandiford
Martin Sebor writes: > On 06/11/2018 12:08 PM, Richard Sandiford wrote: >> Martin Sebor writes: >>> @@ -1553,12 +1553,28 @@ struct line *thisline = (struct line *) >>> thisline->length = this_length; >>> @end smallexample >>> >>> -In ISO C90, you would have to give @code{contents} a length of 1

Re: [PATCH] update Zero-length array documentation

2018-06-11 Thread Martin Sebor
On 06/11/2018 12:08 PM, Richard Sandiford wrote: Martin Sebor writes: @@ -1553,12 +1553,28 @@ struct line *thisline = (struct line *) thisline->length = this_length; @end smallexample -In ISO C90, you would have to give @code{contents} a length of 1, which -means either you waste space or co

Re: [C++ Patch] Fix grok_op_properties locations

2018-06-11 Thread Jason Merrill
OK. On Mon, Jun 11, 2018 at 3:29 PM, Paolo Carlini wrote: > Hi, > > this consistently fixes all the locations and at the same time removes the > special casing of POSTINCREMENT_EXPR and POSTDECREMENT_EXPR as agreed a few > days ago. Tested x86_64-linux. > > Thanks, Paolo. > >

Re: [PATCH] Come up with Deprecated option flag.

2018-06-11 Thread Paul Koning
> On Jun 8, 2018, at 7:09 AM, Martin Liška wrote: > > Hi. > > First follow-up MPX removal patch comes up with Deprecated option flag. > That prints warning for options that have no effect: Should this be mentioned in the internals manual (section 8.2)? paul

[C++ Patch] Fix grok_op_properties locations

2018-06-11 Thread Paolo Carlini
Hi, this consistently fixes all the locations and at the same time removes the special casing of POSTINCREMENT_EXPR and POSTDECREMENT_EXPR as agreed a few days ago. Tested x86_64-linux. Thanks, Paolo. // /cp 2018-06-11 Paolo Carlini * decl.c (grok_op_properti

New can_[in,de]crement_range debug checks

2018-06-11 Thread François Dumont
Hi     If not told otherwise I plan to commit attached patch tomorrow evening.     It is adding new Debug checks to find out if an output iterator will always be reachable while looping on an input range. Note that this check was already done previously by checking if the iterator was [in,de]

Re: [PATCH] Document usage of line number 0 in dg-{warning,error,message,bogus} directives

2018-06-11 Thread Jeff Law
On 06/06/2018 11:32 AM, Jozef Lawrynowicz wrote: > For the dg-{warning,error,message,bogus} directives, a value of 0 for the line > > argument can be passed to specify that the message is not associated with any > > line. This patch documents that in the Directives section of the > documentation.

Re: libgo patch committed: Add riscv and js/wasm

2018-06-11 Thread Palmer Dabbelt
On Mon, 11 Jun 2018 12:16:39 PDT (-0700), i...@golang.org wrote: This libgo patch add riscv and js/wasm as known targets. This incorporates cut down versions of https://golang.org/cl/102835 and https://golang.org/cl/106256 from the master sources. This will tell the go/build to skip files with

[patch, fortran] Handling of .and. and .or. expressions

2018-06-11 Thread Thomas Koenig
Hello world, the attached patch introduces the following changes: If a logical .and. or .or. expression contains a reference to a function which is impure and which also does not behave like a pure function (i.e. does not have the implicit_pure attribute set), it emits a warning with -Wsurprisin

Re: [PATCH] add missing @opindex to Warning Options

2018-06-11 Thread Jeff Law
On 06/07/2018 09:21 PM, Eric Gallager wrote: > On 6/7/18, Martin Sebor wrote: >> A bunch of warning options are missing an @opindex entry, >> usually for the negative form. I went through them all >> and added them where it made sense. >> >> Unless there are objections I will commit the patch to

Re: [PATCH] Come up with Deprecated option flag.

2018-06-11 Thread Jeff Law
On 06/08/2018 05:09 AM, Martin Liška wrote: > Hi. > > First follow-up MPX removal patch comes up with Deprecated option flag. > That prints warning for options that have no effect: > > $ ./xgcc -B. /tmp/main.c -Wchkp -static-libmpxwrappers > xgcc: warning: deprecated command line option ‘-static-

libgo patch committed: Add riscv and js/wasm

2018-06-11 Thread Ian Lance Taylor
This libgo patch add riscv and js/wasm as known targets. This incorporates cut down versions of https://golang.org/cl/102835 and https://golang.org/cl/106256 from the master sources. This will tell the go/build to skip files with those tags. Bootstrapped and ran Go testsuite on x86_64-pc-linux-g

Re: [PING] [PATCH] Add a comma to comment in lower_eh_constructs_2

2018-06-11 Thread Jeff Law
On 06/04/2018 12:56 AM, Zhouyi Zhou wrote: > Hi, >Following patch has not been reviewed for two weeks. I think the > patch is trivial, > it doesn't affect other parts of GCC. > >https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01005.html > >And I don't have write permission to GCC > Than

Re: C++ PATCH for c++/86063, ICE with attribute with pack expansion

2018-06-11 Thread Jason Merrill
On Wed, Jun 6, 2018 at 5:18 PM, Marek Polacek wrote: > We crash on this testcase containing a bogus attribute, because > cp_check_const_attributes accessed TREE_VALUE of a tree that happened to be > expr_pack_expansion. Since here we're merely trying to evaluate constexpr > arguments, I thought w

Re: RFA (symtab): PATCH to symtab_node::nonzero_address DECL_COMDAT handling for c++/80485

2018-06-11 Thread Jeff Law
On 06/05/2018 12:56 AM, Jason Merrill wrote: > On Thu, May 24, 2018 at 11:36 PM, Jeff Law wrote: >> On 05/19/2018 07:07 AM, Jason Merrill wrote: >>> A comment earlier in in nonzero_address says, "Important case of WEAK >>> we want to do well are comdats. Those are handled by later check for >>> de

Re: [PATCH] ltmain.sh: Sort input file list

2018-06-11 Thread Jeff Law
On 06/11/2018 11:06 AM, Joseph Myers wrote: > If we're not doing a general update from upstream libtool, I think we > should use the upstream ltmain.sh fix (libtool commit > 74c8993c178a1386ea5e2363a01d919738402f30, it looks like), or follow it as > close as possible, rather than having our own

Re: [Patch, Fortran, F08] PR 45521: GENERIC resolution with ALLOCATABLE/POINTER and PROCEDURE

2018-06-11 Thread Janus Weil
2018-06-11 19:49 GMT+02:00 Steve Kargl : > On Mon, Jun 11, 2018 at 05:05:17PM +0200, Janus Weil wrote: >> >> the attached patch fixes two remaining problems with the resolution of >> generic functions with POINTER and ALLOCATABLE arguments in F08 >> (coments 16 & 17 in the PR): >> * it deals with a

Re: [PATCH] handle non-constant character assignments in strlen (PR 86083)

2018-06-11 Thread Jeff Law
On 06/11/2018 12:06 PM, Martin Sebor wrote: > On 06/11/2018 01:20 AM, Marc Glisse wrote: >> On Sun, 10 Jun 2018, Martin Sebor wrote: >> >>> The attached patch implements this idea.  (I looked for a simple >>> function that returns true/false based on whether a SSA_NAME is >>> or isn't definitely no

Re: [PATCH][Aarch64] v2: Arithmetic overflow addv patterns [Patch 2/4]

2018-06-11 Thread Richard Sandiford
Michael Collison writes: > +(define_expand "uaddv4" > + [(match_operand:GPI 0 "register_operand") > + (match_operand:GPI 1 "register_operand") > + (match_operand:GPI 2 "register_operand") > + (label_ref (match_operand 3 "" ""))] > + "" > +{ > + emit_insn (gen_add3_compareC (operands[0], o

Re: [PATCH] ltmain.sh: Sort input file list

2018-06-11 Thread Bernhard M. Wiedemann
On 2018-06-11 17:06, Joseph Myers wrote: > If we're not doing a general update from upstream libtool, I think we > should use the upstream ltmain.sh fix (libtool commit > 74c8993c178a1386ea5e2363a01d919738402f30, it looks like), or follow it as > close as possible, rather than having our own var

C++ PATCH for c++/86094, wrong calling convention for move-only class

2018-06-11 Thread Jason Merrill
The fix for 80178 was broken, because I forgot that copy_fn_p is false for move constructors. As a result, the calling convention for a class with a trivial move constructor and deleted copy constructor changed inappropriately. Tested x86_64-pc-linux-gnu, applying to trunk and 8. commit d6cc7705f

Re: [PATCH] update Zero-length array documentation

2018-06-11 Thread Richard Sandiford
Martin Sebor writes: > @@ -1553,12 +1553,28 @@ struct line *thisline = (struct line *) > thisline->length = this_length; > @end smallexample > > -In ISO C90, you would have to give @code{contents} a length of 1, which > -means either you waste space or complicate the argument to @code{malloc}.

Re: [PATCH] handle non-constant character assignments in strlen (PR 86083)

2018-06-11 Thread Martin Sebor
On 06/11/2018 01:20 AM, Marc Glisse wrote: On Sun, 10 Jun 2018, Martin Sebor wrote: The attached patch implements this idea. (I looked for a simple function that returns true/false based on whether a SSA_NAME is or isn't definitely non-zero but couldn't find one so I created one though it seem

Re: [PATCH] PR fortran/68544 -- Issue error for derived type used as actual arg

2018-06-11 Thread Thomas Koenig
Hi Steve, The attach patch fixes an ICE that occurs when a user uses a derived type as an actual argument to subprogram. Regression tested on x86_64-*-freebsd and i586-*-freebsd. OK to commit? OK. Thanks!

Re: [Patch, Fortran, F08] PR 45521: GENERIC resolution with ALLOCATABLE/POINTER and PROCEDURE

2018-06-11 Thread Steve Kargl
On Mon, Jun 11, 2018 at 05:05:17PM +0200, Janus Weil wrote: > > the attached patch fixes two remaining problems with the resolution of > generic functions with POINTER and ALLOCATABLE arguments in F08 > (coments 16 & 17 in the PR): > * it deals with an INTENT(IN) condition that was added in an IR

Re: [PATCH] Avoid excessive function type casts with splay-trees part 2

2018-06-11 Thread David Malcolm
On Fri, 2018-06-08 at 20:41 +, Bernd Edlinger wrote: > On 06/08/18 16:28, David Malcolm wrote: > > On Fri, 2018-06-08 at 14:03 +, Bernd Edlinger wrote: > > > Hi! > > > > > > > > > This patch converts the splay-tree internals into a template, and > > > makes > > > the typed_splay_tree temp

PING 2 [PATCH] restore -Wstringop-overflow for checked strcpy/strcat (PR 85259)

2018-06-11 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-05/msg00652.html On 06/05/2018 01:58 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2018-05/msg00652.html On 05/14/2018 04:41 PM, Martin Sebor wrote: r256683 committed to GCC 8 to avoiding duplicate instances of -Wstringop-overflo

PING 2 [PATCH] relax -Wsizeof-pointer-memaccess for strncpy with size of source (PR 85931)

2018-06-11 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01698.html On 06/04/2018 05:50 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01698.html On 05/29/2018 08:57 PM, Martin Sebor wrote: Warning for a strncpy call whose bound is the same as the size of the source and

PING 3 [PATCH] refine -Wstringop-truncation and -Wsizeof-pointer-memaccess for strncat of nonstrings (PR 85602)

2018-06-11 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01671.html On 06/04/2018 05:48 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01671.html (In IRC last week Franz reported successfully testing the patch. Thanks again.) On 05/29/2018 01:21 PM, Martin Sebor wrote:

PING 3 [PATCH] allow more strncat calls with -Wstringop-truncation (PR 85700)

2018-06-11 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01189.html On 06/04/2018 05:45 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01189.html On 05/29/2018 10:19 AM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01189.html On 05/22/2018 07

Re: [PATCH] ltmain.sh: Sort input file list

2018-06-11 Thread Joseph Myers
If we're not doing a general update from upstream libtool, I think we should use the upstream ltmain.sh fix (libtool commit 74c8993c178a1386ea5e2363a01d919738402f30, it looks like), or follow it as close as possible, rather than having our own variant. -- Joseph S. Myers jos...@codesourcery.co

Re: [PATCH] Fix altivec-7 issues on Power 6

2018-06-11 Thread Segher Boessenkool
On Fri, Jun 08, 2018 at 01:40:02PM -0700, Carl Love wrote: > diff --git a/gcc/testsuite/gcc.target/powerpc/altivec-37.c > b/gcc/testsuite/gcc.target/powerpc/altivec-37.c > new file mode 100644 > index 000..362b6ec > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/altivec-37.c > @@ -0,0

Re: [Patch, Fortran] PR25829: Asynchronous I/O

2018-06-11 Thread John David Anglin
On 2018-06-11 11:24 AM, Rainer Orth wrote: Hi John, On 2018-06-03 2:59 PM, Nicolas Koenig wrote: Since the implementation relies on pthreads, it would be great if somebody could try the patch on non-linux targets, to see whether it causes any problems there. I tried it on hppa64-hp-hpux11.11.

[PATCH] ^d thing (PR85755)

2018-06-11 Thread Segher Boessenkool
Some of the mov* patterns use ^ and $ constraint modifiers, which mean give a penalty to this alternative if this operand needs a reload. They are meant here to give a penalty if a register operand needs reloading (because it needs to be in a different kind of register), not when a memory operand

Re: [Patch, Fortran] PR25829: Asynchronous I/O

2018-06-11 Thread Rainer Orth
Hi John, > On 2018-06-03 2:59 PM, Nicolas Koenig wrote: >> Since the implementation relies on pthreads, it would be great if >> somebody could try the patch on non-linux targets, to see whether it >> causes any problems there. > I tried it on hppa64-hp-hpux11.11.  The gomp support mostly works on

Re: [Patch, Fortran] PR25829: Asynchronous I/O

2018-06-11 Thread John David Anglin
On 2018-06-03 2:59 PM, Nicolas Koenig wrote: Since the implementation relies on pthreads, it would be great if somebody could try the patch on non-linux targets, to see whether it causes any problems there. I tried it on hppa64-hp-hpux11.11.  The gomp support mostly works on this target. I di

[Patch, Fortran, F08] PR 45521: GENERIC resolution with ALLOCATABLE/POINTER and PROCEDURE

2018-06-11 Thread Janus Weil
Hi all, the attached patch fixes two remaining problems with the resolution of generic functions with POINTER and ALLOCATABLE arguments in F08 (coments 16 & 17 in the PR): * it deals with an INTENT(IN) condition that was added in an IR * it deals with polymorphic arguments, which were mistreated p

Re: [PATCH] Fix PR c++/85400

2018-06-11 Thread Jakub Jelinek
On Wed, May 09, 2018 at 12:05:34PM +0200, Eric Botcazou wrote: > > So it isn't clear to me if a cxx_make_decl_one_only is the way to go. Maybe > > doing the recalculation in comdat_linkage and maybe_make_one_only only > > would be sufficient. > > Patch to that effect attached, tested on x86-64/Li

Re: [Patch, Fortran] PR25829: Asynchronous I/O (v2)

2018-06-11 Thread Dominique d'Humières
>>> FAIL: gfortran.dg/f2003_inquire_1.f03 -O1 execution test > > This seems to be a bug in the test suite. It tries to find out whether an id > is pending that is never initialized. > >>> FAIL: gfortran.dg/f2003_io_1.f03 -O* > > And another bug in the test suite. This time the wait afte

PING^2: [PATCH] libitm/x86: Correct offsets of __private_tm and pointer_guard

2018-06-11 Thread H.J. Lu
On Mon, Jun 4, 2018 at 6:10 AM, H.J. Lu wrote: > On Wed, May 30, 2018 at 7:54 AM, H.J. Lu wrote: >> In glibc, sysdeps/i386/nptl/tls.h has >> >> typedef struct >> { >> void *tcb;/* Pointer to the TCB. Not necessarily the >>thread descriptor used by libpth

RE: [PATCH] MIPS: Add support for P6600

2018-06-11 Thread Matthew Fortune
Robert Suchanek writes: > The below adds support for -march=p6600. It includes > a new scheduler plus performance tweaks. > > gcc/ChangeLog: > > 2018-06-01 Matthew Fortune > Prachi Godbole > * config/mips/mips-cpus.def: Define P6600. > * config/mips/mips-tables.opt:

Re: [patch] Remove redundant intrinsics

2018-06-11 Thread Kirill Yukhin
Hello Julia! On 04 июн 10:27, Koval, Julia wrote: > Hi, > > Since pre-Icelake ISA already had 128bit version vpclmul and vaes, we already > have intrinsics for them(_mm_aesdec_si128, _mm_aesdeclast_si128, > _mm_aesenc_si128, _mm_aesenclast_si128, _mm_clmulepi64_si128). Therefore > intrinsics fo

Re: [PATCH] Fix typo done in MPX removal (PR tree-optimization/86089).

2018-06-11 Thread Jakub Jelinek
On Mon, Jun 11, 2018 at 09:05:26AM +0200, Martin Liška wrote: > Hi. > > This is typo I did when MPX was removed. I'm moving back hunk with > BUILT_IN_STPCPY_CHK. > > Ready after testing? > Martin > > gcc/ChangeLog: > > 2018-06-11 Martin Liska > > PR tree-optimization/86089 >

RE: [PATCH] MIPS: Add i6500 processor as an alias for i6400

2018-06-11 Thread Matthew Fortune
Robert Suchanek writes: > This patch adds i6500 CPU as an alias for i6400. > > Regards, > Robert > > gcc/ChangeLog: > > 2018-06-01 Matthew Fortune > > * config/mips/mips-cpus.def: New MIPS_CPU for i6500. > * config/mips/mips-tables.opt: Regenerate. > * config/mips/mips.h (

RE: [PATCH] MIPS: Update I6400 scheduler

2018-06-11 Thread Matthew Fortune
Robert Suchanek writes: > Update to i6400 scheduler. > > Regards, > Robert > > gcc/ChangeLog: > > 2018-06-01 Prachi Godbole > > * config/mips/i6400.md (i6400_gpmuldiv): Remove cpu_unit. > (i6400_gpmul): Add cpu_unit. > (i6400_gpdiv): Likewise. > (i6400_msa_add_d): Up

RE: [PATCH] MIPS: Add support for -mcrc and -mginv options

2018-06-11 Thread Matthew Fortune
Robert Suchanek writes: > This patch adds -mcrc and -mginv options to pass through them > to the assembler. > > Regards, > Robert > > gcc/ChangeLog: > > 2018-06-01 Matthew Fortune > > * config/mips/mips.h (ASM_SPEC): Pass through -mcrc, -mno-crc, > -mginv and -mno-ginv to the as

Re: [patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-11 Thread Olivier Hainque
> On 11 Jun 2018, at 11:24, Jakub Jelinek wrote: > > On Mon, Jun 11, 2018 at 08:50:31AM +0200, Olivier Hainque wrote: >> FWIW, I was surprised by a gotcha while writing tests for this, >> where both >> >> { dg-final { scan-assembler "0x3.*DW_AT_language" } } >> and { dg-final { scan-ass

Re: [patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-11 Thread Jakub Jelinek
On Mon, Jun 11, 2018 at 08:50:31AM +0200, Olivier Hainque wrote: > FWIW, I was surprised by a gotcha while writing tests for this, > where both > > { dg-final { scan-assembler "0x3.*DW_AT_language" } } > and { dg-final { scan-assembler "0xd.*DW_AT_language" } } > > matched for Ada95 (0xd)

[Ada] Double finalization of limited controlled result

2018-06-11 Thread Pierre-Marie de Rodat
This patch disables a build-in-place optimization when a function returns a limited controlled result because the optimization may violate the semantics of finalizable types by performing illegal calls to Finalize. In general, the optimization causes the result object of a build-in-place function

[Ada] Suppress the expansion of ignored assertion pragmas

2018-06-11 Thread Pierre-Marie de Rodat
This patch suppresses the expansion of ignored assertion pragmas. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-06-11 Hristian Kirtchev gcc/ada/ * contracts.adb (Process_Body_Postconditions): Expand only checked postconditions. (Process_Contract_Cases_For): E

[Ada] Improve last exception info availability from C++ handlers

2018-06-11 Thread Pierre-Marie de Rodat
The Most_Recent_Exception service failed to provide accurate information on an Ada exception caught by a C++ handler for foreign exceptions. The service relies on updates of a "current exception buffer" from live exception objects at various points of the propagation process and this update was not

[Ada] Dangling cursor checks in Element function

2018-06-11 Thread Pierre-Marie de Rodat
In Ada.Containers.Ordered_Maps, if a dangling cursor is passed to the Element function, execution is erroneous. Therefore, the compiler is not obligated to detect this error. However, this patch inserts code that will detect this error in some cases, and raise Program_Error. The same applies to Ord

[Ada] Mark parameters as coming from source for GNATprove

2018-06-11 Thread Pierre-Marie de Rodat
When building a separate subprogram declaration for possible inlining of local subprograms in GNATprove mode, correctly mark subprogram parameters as coming from source. This has no impact on compilation. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-06-11 Yannick Moy gcc/ada/

[Ada] Missing predicate function body for derived type in nested package

2018-06-11 Thread Pierre-Marie de Rodat
This patch fixes a bug in the construction of predicate functions. For a derived type, we must ensure that the parent type is already frozen so that its predicate function has been constructed already. This is necessary if the parent is declared in a nested package and its own freeze point has not

[Ada] Reject violation of SPARK 6.1.4(12) with enclosing task unit

2018-06-11 Thread Pierre-Marie de Rodat
SPARK 6.1.4(12) applies both to enclosing subprograms and enclosing task units, but the latter was not correctly rejected. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-06-11 Yannick Moy gcc/ada/ * sem_prag.adb (Check_Mode_Restriction_In_Enclosing_Context): Adapt for

[Ada] Do not query the representation information in CodePeer/GNATprove

2018-06-11 Thread Pierre-Marie de Rodat
Representation information generated when user calls the compiler with -gnatR switch is not available when running the frontend inside CodePeer or GNATprove. Do not query such information in that case, as this leads to spurious messages that it is not available. There is no impact on compilation.

[Ada] Make GNAT.Array_Split a preelaborable unit

2018-06-11 Thread Pierre-Marie de Rodat
This patch makes GNAT.Array_Split a preelaborable unit. As a result, it can be withed by other preelaborated untis. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-06-11 Hristian Kirtchev gcc/ada/ * libgnat/g-arrspl.ads: Add pragma Preelaborate. gcc/testsuite/ * gnat

[Ada] Crash on protected type entry family

2018-06-11 Thread Pierre-Marie de Rodat
The compiler may blow up compiling the body of a protected type that has a family entry whose entry index specification contains a call to a function. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-06-11 Javier Miranda gcc/ada/ * exp_ch9.adb (Expand_N_Protected_Body): Add mis

[Ada] Mark extended return of unconstrained type as never inlined

2018-06-11 Thread Pierre-Marie de Rodat
Calls to subprograms whose body was an extended return of an unconstrained type were marked as not inlined, while the subprogram itself was marked as always inlined. This was inconsistent and could lead to crash in GNATprove. Now such subprograms are marked as not candidates for inlining. This mos

[Ada] Do not force Part_Of on generic units

2018-06-11 Thread Pierre-Marie de Rodat
This fixes the code checking SPARK RM 7.2.6(3) so that generic child units are not forced to use Part_Of to relate their abstract state to the state of their parent. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-06-11 Yannick Moy gcc/ada/ * sem_prag.adb (Analyze_Part_Of): On

[Ada] Don't split AND THEN expressions in GNATprove_Mode

2018-06-11 Thread Pierre-Marie de Rodat
Splitting AND THEN expressions in contracts into separate pragma Check is only useful for compilation when the error message points to a failed conjunct. For proof it is of no use; for flow analysis it is annoying. Also, it makes debugging harder. Now it is disabled in GNATprove_Mode. Compilation

[Ada] Fix handling of Pre/Post contracts with AND THEN expressions

2018-06-11 Thread Pierre-Marie de Rodat
Pre- and postconditions with top-level AND THEN expressions are broken down into checks of indivudial conjuncts for more precise error reporting. This rewrite interfers with detection of potentially unevaluadted use of 'Old, e.g. a contract like "Pre => Foo and then Bar" is rewritten into a two pra

[Ada] Wrong code in array aggregates of Ada coextensions

2018-06-11 Thread Pierre-Marie de Rodat
The compiler generates wrong code when an array aggregate with an others choice whose expression has nested object allocations (ie. others => new R (new S)) is used to initialize an array of access to discriminated types whose discriminant is an access type. Tested on x86_64-pc-linux-gnu, committe

[Ada] Crash with Inline_Always on a function with an extended return

2018-06-11 Thread Pierre-Marie de Rodat
This patch fixes a crash on a unit with a function with the GNAT-specific Inline_Always pragma whose body is an extended return statement, when compiling with no optimization level specified. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-06-11 Ed Schonberg gcc/ada/ * inline.

[Ada] Crash on instantiation of nested generic in private part

2018-06-11 Thread Pierre-Marie de Rodat
This patch fixes a compiler abort on an instantiation of a generic nested within another instance, when the outer instance is declared in the visible part of a package and the inner intance is in the private part of the same package. Tested on x86_64-pc-linux-gnu, committed on trunk 2018-06-11 E

[Ada] Performance degradation with references

2018-06-11 Thread Pierre-Marie de Rodat
This patch modifies the creation of markers for variable references in the context of SPARK elaboration checks. Previously, prior to checking whether a reference requires such a marker, the compiler performed a logarithmic look up to determine whether the reference appears within a call. This actio

[PATCH,MIPS] Fix pr86067 ICE: scal-to-vec1.c:86:1: error: unrecognizable insn with -march=loongson3a

2018-06-11 Thread Paul Hua
Hi: The gcc.c-torture/execute/scal-to-vec1.c trigger a gcc ICE bug. It's a mistake in define_expand vec_setv4hi in loongson.md file. 375 (define_expand "vec_setv4hi" 376 [(set (match_operand:V4HI 0 "register_operand" "=f") 377 (unspec:V4HI [(match_operand:V4HI 1 "register_operand" "f"

Re: [RFC][PR64946] "abs" vectorization fails for char/short types

2018-06-11 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review and sorry for getting back to you late. On 4 June 2018 at 18:38, Richard Biener wrote: > On Mon, Jun 4, 2018 at 10:18 AM Kugan Vivekanandarajah > wrote: >> >> Hi Richard, >> >> Thanks for the review. >> >> On 1 June 2018 at 22:20, Richard Biener wrote: >> > On

[PATCH v3] add support for --disable-gcov

2018-06-11 Thread Rasmus Villemoes
For some targets (in my case VxWorks 5.5), libgcov does not compile due to missing functions and macros such as getpid() and F_OK. Incidentally, gcc/Makefile.in already contains comments such as # Install gcov if it was compiled. but there is no logic in place to actually allow gcov to not be co

Re: [PATCH] handle non-constant character assignments in strlen (PR 86083)

2018-06-11 Thread Marc Glisse
On Sun, 10 Jun 2018, Martin Sebor wrote: The attached patch implements this idea. (I looked for a simple function that returns true/false based on whether a SSA_NAME is or isn't definitely non-zero but couldn't find one so I created one though it seems that extending one of the existing functio

Re: [patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-11 Thread Olivier Hainque
> On 10 Jun 2018, at 21:26, Jakub Jelinek wrote: >> http://wiki.dwarfstd.org/index.php?title=DWARF_Language_Support > > Well, you should better be looking at the pdfs of the standards, that is > more precise. Ok > And there it says: > Names marked with † and their associated values are reser

[PATCH] Fix typo done in MPX removal (PR tree-optimization/86089).

2018-06-11 Thread Martin Liška
Hi. This is typo I did when MPX was removed. I'm moving back hunk with BUILT_IN_STPCPY_CHK. Ready after testing? Martin gcc/ChangeLog: 2018-06-11 Martin Liska PR tree-optimization/86089 * tree-ssa-strlen.c (get_string_length): Move back removed hunk. gcc/testsuite/ChangeLo