Re: libgo patch committed: Add riscv and js/wasm

[Palmer Dabbelt]

On Mon, 11 Jun 2018 12:16:39 PDT (-0700), i...@golang.org wrote:
This libgo patch add riscv and js/wasm as known targets.  This
incorporates cut down versions of https://golang.org/cl/102835 and
https://golang.org/cl/106256 from the master sources.  This will tell
the go/build to skip files with those tags.  Bootstrapped and ran Go
testsuite on x86_64-pc-linux-gnu.  Committed to mainline.

[...]

--- libgo/goarch.sh     (revision 261203)
+++ libgo/goarch.sh     (working copy)
@@ -153,6 +153,11 @@ case $goarch in
                ;;
        esac
        ;;
+    riscv)
+       family=RISCV
+       pcquantum=2
+       ptrsize=4
+       ;;
     riscv64)
        family=RISCV64
        pcquantum=2

I don't know anything about Go, but we've generally been calling the RISC-V 
architectures "riscv32" and "riscv64" as opposed to "riscv" and "riscv64", with 
the idea being that it's a bit more explicit.  Technically, RISC-V is the name 
of a family of ISAs, with "RV32I" and "RV64I" being two base ISAs so this also 
matches the ISA's naming scheme.

Obviously this isn't a big deal, I just saw the patch go by and thought I'd 
bring it up.