Re: [PATCH, i386] Refactor -mprefer-avx[128|256] options into common -mprefer-vector-width=[none|128|256|512]

2017-11-13 Thread Uros Bizjak
On Tue, Nov 14, 2017 at 12:14 AM, Joseph Myers wrote: > On Mon, 13 Nov 2017, Uros Bizjak wrote: > >> [BTW: --mprefer-avx128 should be marked RejectNegative from the >> beginning; let's just assume nobody uses it in its (somehow weird) >> negative "-mno-prefer-avx128" form.] > > It's used in that f

Re: Adjust empty class parameter passing ABI (PR c++/60336)

2017-11-13 Thread Richard Biener
On November 14, 2017 6:21:41 AM GMT+01:00, Jason Merrill wrote: >On Mon, Nov 13, 2017 at 1:02 PM, Marek Polacek >wrote: >> On Mon, Nov 13, 2017 at 11:47:41AM +0100, Jakub Jelinek wrote: >>> On Mon, Nov 13, 2017 at 11:44:38AM +0100, Richard Biener wrote: >>> > > Unfortunately, it's not what I see

Re: Adjust empty class parameter passing ABI (PR c++/60336)

2017-11-13 Thread Jason Merrill
On Mon, Nov 13, 2017 at 1:02 PM, Marek Polacek wrote: > On Mon, Nov 13, 2017 at 11:47:41AM +0100, Jakub Jelinek wrote: >> On Mon, Nov 13, 2017 at 11:44:38AM +0100, Richard Biener wrote: >> > > Unfortunately, it's not what I see. I ran two bootstraps, with and >> > > without the >> > > patch. Th

Re: [PATCH] enhance -Warray-bounds to detect out-of-bounds offsets (PR 82455)

2017-11-13 Thread Martin Sebor
On 11/10/2017 01:00 AM, Richard Biener wrote: On Thu, 9 Nov 2017, Jeff Law wrote: On 11/02/2017 05:48 AM, Richard Biener wrote: There were elaborate transforms of ptr + CST to ptr->a.b.c[3] in the past. We have ripped out _most_ of them because of bad interaction with dependence analysis an

Re: [PATCH] detect nonstring arguments to string functions (PR 82945)

2017-11-13 Thread Martin Sebor
Attached is an improved version that rather than hardcoding the built-in functions to check uses the constness of each built-in's char* argument as a trigger to do the checking. This avoids the problem of the list being incomplete either by omission or due to getting out of sync, and also makes i

Re: [PATCH] detect nonstring arguments to string functions (PR 82945)

2017-11-13 Thread Martin Sebor
On 11/13/2017 12:20 PM, Jakub Jelinek wrote: On Sun, Nov 12, 2017 at 05:52:41PM -0700, Martin Sebor wrote: + the referenced enclosing object or pointer. Otherwise return + null. */ + +tree +get_attr_nonstring_decl (tree expr, tree *ref) +{ + tree dcl = expr; Usually we call vars decl, n

Re: [001/nnn] poly_int: add poly-int.h

2017-11-13 Thread Martin Sebor
On 11/13/2017 04:36 PM, Richard Sandiford wrote: Jeff Law writes: On 11/09/2017 04:06 AM, Richard Sandiford wrote: Let me say at the outset that I struggle to comprehend that a few instructions is even a consideration when not optimizing, especially in light of the bug the macro caused that w

Re: [PATCH] PR fortran/78240 -- kludge of the day

2017-11-13 Thread Steve Kargl
On Mon, Nov 13, 2017 at 04:42:31PM -0500, Fritz Reese wrote: > On Thu, Nov 9, 2017 at 5:02 PM, Steve Kargl > wrote: > > The following patch fixes PR fortran/78240. It seems > > to me to be inelegant, but it does pass regression > > testing. [...] OK to commit? > > Upon closer analysis, the patch

Re: [001/nnn] poly_int: add poly-int.h

2017-11-13 Thread Richard Sandiford
Richard Sandiford writes: > Richard Sandiford writes: >> This patch adds a new "poly_int" class to represent polynomial integers >> of the form: >> >> C0 + C1*X1 + C2*X2 ... + Cn*Xn >> >> It also adds poly_int-based typedefs for offsets and sizes of various >> precisions. In these typedefs, th

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-11-13 Thread Eric Botcazou
> The chance here is, of course (find the PR, it exists...), that SRA then > decomposes the char[] copy bytewise... > > That said, memcpy folding is easy to fix. The question is of course > what the semantic of VIEW_CONVERTs is (SRA _does_ contain > bail-outs on those). Like if you have > > str

Re: [PATCH] enhance -Warray-bounds to detect out-of-bounds offsets (PR 82455)

2017-11-13 Thread Jeff Law
On 11/10/2017 01:00 AM, Richard Biener wrote: > > It's the usual issue with an optimizing compiler vs. a static analyzer. > We try to get rid of the little semantic details of the input languages > that in the end do not matter for code-generation but that makes > using those semantic details hard

Re: [001/nnn] poly_int: add poly-int.h

2017-11-13 Thread Richard Sandiford
Jeff Law writes: > On 11/09/2017 04:06 AM, Richard Sandiford wrote: > >>> Let me say at the outset that I struggle to comprehend that a few >>> instructions is even a consideration when not optimizing, especially >>> in light of the bug the macro caused that would have been prevented >>> by using

Re: [PATCH, i386] Refactor -mprefer-avx[128|256] options into common -mprefer-vector-width=[none|128|256|512]

2017-11-13 Thread Joseph Myers
On Mon, 13 Nov 2017, Uros Bizjak wrote: > [BTW: --mprefer-avx128 should be marked RejectNegative from the > beginning; let's just assume nobody uses it in its (somehow weird) > negative "-mno-prefer-avx128" form.] It's used in that form in various testcases that otherwise fail when GCC is config

[C++ PATCH] P0329R4: Designated Initialization

2017-11-13 Thread Jakub Jelinek
Hi! This patch adds support for c++2a designated initializers. We've been supporting a small restricted subset of C99 initializers as a GNU extension before, the C++2A designated initializers are partly a subset of that, but on the other side extent it more and add some further restrictions. I've

Re: C++ PATCH for c++/56973 (DR 696), lambda capture of const variables

2017-11-13 Thread Jason Merrill
On Tue, Oct 10, 2017 at 1:59 PM, Jason Merrill wrote: > On Thu, Sep 28, 2017 at 3:38 PM, Jason Merrill wrote: >> The G++ lambda implementation previously implemented an early >> tentative resolution of DR 696, whereby mentions of an outer constant >> variable would immediately decay to the consta

Re: [PATCH, rs6000 V4] Fixes for commit 254464

2017-11-13 Thread Segher Boessenkool
Hi Carl, On Thu, Nov 09, 2017 at 08:39:10AM -0800, Carl Love wrote: > The recent commit 254464 to add Power 8 support for the vec_revb() > builtin had a couple of issues that I missed on my testing of the > original patch. First, on Power 8 BE the le_swap1 permute vector value > was wrong in func

gcc-patches@gcc.gnu.org

2017-11-13 Thread Jason Merrill
While working on another issue, I noticed that cp_build_indirect_ref was still folding away *&, which is incorrect because (int)*&var is an odr-use of var, whereas (int)var may not be. However, many of the existing users of cp_build_indirect_ref don't care about that distinction, and indeed rely o

RE: [PATCH 08/22] Add Intel CET support for EH in libgcc.

2017-11-13 Thread Tsimbalist, Igor V
New patch is attached. The difference is that all newly introduced macro are removed except of _Unwind_Frames_Extra macro. They are replaced with new parameters and local variables. Igor 0008-Add-Intel-CET-support-for-EH-in-libgcc.patch Description: 0008-Add-Intel-CET-support-for-EH-in-libgcc.p

Re: [PATCH] PR fortran/78240 -- kludge of the day

2017-11-13 Thread Fritz Reese
On Thu, Nov 9, 2017 at 5:02 PM, Steve Kargl wrote: > The following patch fixes PR fortran/78240. It seems > to me to be inelegant, but it does pass regression > testing. [...] OK to commit? Upon closer analysis, the patch is insufficient to fix the PR. I will explain below. At the bottom of this

Re: [PATCH v2] [libcc1] Rename C{,P}_COMPILER_NAME and remove triplet from them

2017-11-13 Thread Sergio Durigan Junior
On Tuesday, September 26 2017, I wrote: > Ping^2. Ping^3. I'm sending the updated ChangeLog/patch. I'm also removing gdb-patches from the Cc list. libcc1/ChangeLog: 2017-09-01 Sergio Durigan Junior Pedro Alves * Makefile.am: Remove references to c-compiler-name.h and

Re: std::advance istreambuf_iterator overload

2017-11-13 Thread Daniel Krügler
2017-11-13 21:23 GMT+01:00 François Dumont : > On 10/11/2017 21:57, Jonathan Wakely wrote: >>> diff --git a/libstdc++-v3/include/bits/streambuf_iterator.h >>> b/libstdc++-v3/include/bits/streambuf_iterator.h >>> index 0a6c7f9..b60626a 100644 >>> --- a/libstdc++-v3/include/bits/streambuf_iterator.h

Re: std::advance istreambuf_iterator overload

2017-11-13 Thread François Dumont
On 10/11/2017 21:57, Jonathan Wakely wrote: On 09/11/17 22:12 +0100, François Dumont wrote: Hi     Working on istreambuf_iterator I realized that this iterator would really benefit from an std::advance overload so here it is.     Tested under Linux x86_64 normal and debug modes, ok to comm

Re: [PATCH, i386] Refactor -mprefer-avx[128|256] options into common -mprefer-vector-width=[none|128|256|512]

2017-11-13 Thread Uros Bizjak
On Mon, Nov 13, 2017 at 9:13 PM, Uros Bizjak wrote: > On Mon, Nov 13, 2017 at 6:25 PM, Shalnov, Sergey > wrote: >> Hi, >> Modern architectures provides wider and wider vector registers. This patch >> implements >> common (in i386 arch) option to prefer vector register width for the >> vectorize

Re: [PATCH, i386] Refactor -mprefer-avx[128|256] options into common -mprefer-vector-width=[none|128|256|512]

2017-11-13 Thread Uros Bizjak
On Mon, Nov 13, 2017 at 6:25 PM, Shalnov, Sergey wrote: > Hi, > Modern architectures provides wider and wider vector registers. This patch > implements > common (in i386 arch) option to prefer vector register width for the > vectorizer. > Currently, GCC has "-mprefer-avx128" and "-mprefer-avx256

Re: [PATCH, fortran, PR 82869] Introduce default_logical_type_node and logical_type_node

2017-11-13 Thread Janne Blomqvist
On Wed, Nov 8, 2017 at 1:57 PM, Janne Blomqvist wrote: > On Wed, Nov 8, 2017 at 12:27 AM, Steve Kargl > wrote: >> On Tue, Nov 07, 2017 at 10:38:43PM +0200, Janne Blomqvist wrote: >>> On Tue, Nov 7, 2017 at 10:06 PM, Steve Kargl >>> wrote: >>> > On Tue, Nov 07, 2017 at 08:26:15PM +0200, Janne Blo

C++ PATCH for c++/82360, ICE with static_cast in template

2017-11-13 Thread Jason Merrill
My patch to build_static_cast to do type checking in templates ended up calling some functions that should only be used in non-template context. Fixed thus. Tested x86_64-pc-linux-gnu, applying to trunk. commit ba91f219897ce6e205bbdc6776de48f02fbd4a57 Author: Jason Merrill Date: Mon Nov 13 12:

Re: [PATCH] detect nonstring arguments to string functions (PR 82945)

2017-11-13 Thread Jakub Jelinek
On Sun, Nov 12, 2017 at 05:52:41PM -0700, Martin Sebor wrote: > + the referenced enclosing object or pointer. Otherwise return > + null. */ > + > +tree > +get_attr_nonstring_decl (tree expr, tree *ref) > +{ > + tree dcl = expr; Usually we call vars decl, not dcl. Or what does it stand for?

[committed] libcpp: move line typedef and column-numbering comment to top of file

2017-11-13 Thread David Malcolm
The description of our 1-based column-numbering convention was in a non-obvious place withn line-map.h; this patch moves it to the top of that header. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Committed to trunk as r254703. libcpp/ChangeLog: * include/line-map.h (lin

Re: [PATCH v2: 00/14] Preserving locations for variable-uses and constants (PR 43486)

2017-11-13 Thread David Malcolm
On Fri, 2017-11-10 at 16:45 -0500, David Malcolm wrote: > On Thu, 2017-11-02 at 10:46 -0400, Jason Merrill wrote: > > On Tue, Oct 31, 2017 at 5:09 PM, David Malcolm > > > > wrote: > > > On Tue, 2017-10-24 at 09:53 -0400, Jason Merrill wrote: > > > > On Fri, Oct 20, 2017 at 5:53 PM, David Malcolm

Re: [PATCH, wwwdocs] sdb removal release note patch

2017-11-13 Thread Jim Wilson
On Mon, 2017-11-06 at 14:07 -0800, Jim Wilson wrote: > The sdb/coff debug info format removal should be mentioned in the > release notes. Here is a patch to do that. I didn't get an comments on this, so I went ahead and checked it in. Jim

[PATCH libquadmath, pr68686] tgammaq(x) is always negative for noninteger x < 0

2017-11-13 Thread Ed Smith-Rowland
Here is a patch for tammaq for negative argument pr68686. I know about depending on ports from upstream but this was done recently and this (tgammaq) was left out. This patch is basically a one-liner. I have test cases but libquadmath doesn't have a testsuite. One test just shows alternating

Re: Adjust empty class parameter passing ABI (PR c++/60336)

2017-11-13 Thread Marek Polacek
On Mon, Nov 13, 2017 at 11:47:41AM +0100, Jakub Jelinek wrote: > On Mon, Nov 13, 2017 at 11:44:38AM +0100, Richard Biener wrote: > > > Unfortunately, it's not what I see. I ran two bootstraps, with and > > > without the > > > patch. Then I stripped all the .o files and ran cmp on them, but many

Clenaup tree-ssa-sink after profile revamp

2017-11-13 Thread Jan Hubicka
Hi, there is no need to compute frequencies here. Bootstrapped/regtested x86-64-linux, comitted. Honza * tree-ssa-sink.c (select_best_block): Do not use frequencies. Index: tree-ssa-sink.c === --- tree-ssa-sink.c (revisio

Fix profile updating bug in ipa-split

2017-11-13 Thread Jan Hubicka
Hi, this patch fixes bug I noticed while looking for profile mismatches in tramp3d. When split part starts with the loop, the frequency of call to split function is not the same as frequency of this block. This also affects the heuristics which should not count the loopback edges. Patch aslo gets

PING Re: RFA (hash-map): PATCH to support GTY((cache)) with hash_map

2017-11-13 Thread Jason Merrill
Ping. On Fri, Sep 15, 2017 at 5:45 PM, Jason Merrill wrote: > The hash_map interface is a lot more convenient than that of > hash_table for cases where it makes sense, but there hasn't been a way > to get the ggc_cache_remove behavior with a hash_map. In other words, > not marking elements durin

Re: [001/nnn] poly_int: add poly-int.h

2017-11-13 Thread Jeff Law
On 11/09/2017 04:06 AM, Richard Sandiford wrote: >> Let me say at the outset that I struggle to comprehend that a few >> instructions is even a consideration when not optimizing, especially >> in light of the bug the macro caused that would have been prevented >> by using a function instead. But.

Re: [PATCH] Fixes for PR68356, PR81210, and PR81693

2017-11-13 Thread Mike Stump
On Nov 12, 2017, at 6:58 AM, H.J. Lu wrote: > > On Sun, Nov 12, 2017 at 6:22 AM, Dominique d'Humières > wrote: >> The following patch fixes PR68356, PR81210, and PR81693 on darwin. >> >> --- ../_clean/gcc/testsuite/gcc.dg/torture/pr68264.c2016-01-28 >> 00:30:03.0 +0100 >> +++ gcc/t

Re: [PATCH] enhance -Warray-bounds to handle strings and excessive indices

2017-11-13 Thread Martin Sebor
Richard, this thread may have been conflated with the one Re: [PATCH] enhance -Warray-bounds to detect out-of-bounds offsets (PR 82455) They are about different things. I'm still looking for approval of: https://gcc.gnu.org/ml/gcc-patches/2017-10/msg01208.html Thanks Martin The difficulty w

Re: [PATCH] Fix pr81706 tests on darwin

2017-11-13 Thread Mike Stump
On Nov 12, 2017, at 6:05 AM, Dominique d'Humières wrote: > > The following patch fixes pr81706 tests on darwin > > --- ../_clean/gcc/testsuite/gcc.target/i386/pr81706.c 2017-10-26 > 07:16:18.0 +0200 > +++ gcc/testsuite/gcc.target/i386/pr81706.c 2017-11-11 16:02:36.0 > +0100 >

Clenaup ipa-fnsummary/ipa-inline after frequency removal

2017-11-13 Thread Jan Hubicka
Hi, now when frequencies are no longer part of cgraph structure, there is no need to convert counts into fixed point CGRAPH_FREQ_BASE frequency and immediately convert it into sreal. Old code lost precision but also capped large values (frequencies was never over 10). I would be curious to know a

[PATCH, i386] Refactor -mprefer-avx[128|256] options into common -mprefer-vector-width=[none|128|256|512]

2017-11-13 Thread Shalnov, Sergey
Hi, Modern architectures provides wider and wider vector registers. This patch implements common (in i386 arch) option to prefer vector register width for the vectorizer. Currently, GCC has "-mprefer-avx128" and "-mprefer-avx256" options to limit maximum vector register width in vectorizer. To av

Re: [RFA] Implement __VA_OPT__

2017-11-13 Thread Jason Merrill
On Sun, Nov 12, 2017 at 2:33 AM, Tom Tromey wrote: > I'm still [not] too happy with the error message, so if you have any > suggestions there, please let me know. I removed the "C99" branch from > the earlier error message as well, since this isn't a C feature at all. > Again, please check the wo

Re: [PATCH], Generate XXBR{H,W,D} for bswap{16,32,64} on PowerPC ISA 3.0 (power9)

2017-11-13 Thread Segher Boessenkool
Hi! On Fri, Nov 10, 2017 at 06:03:29PM -0500, Michael Meissner wrote: > On Fri, Nov 10, 2017 at 11:45:23AM -0600, Segher Boessenkool wrote: > > > After a burn-in period, I plan to backport a reduced version of the patch > > > (XXBRD only) to gcc 7, unless you think it shouldn't go into gcc 7. > >

[Obvious][PATCH][ARM] Fix more -Wreturn-type fallout (gcc.target/arm/pr67989.C)

2017-11-13 Thread Christophe Lyon
Hi, I've committed the attached small patch as an obvious one, doing the same thing as Martin in the other copy in g++.dg/pr67989.C. Christophe 2017-11-13 Christophe Lyon * gcc.target/arm/pr67989.C: Add -Wno-return-type to dg-additional-options. Index: gcc/testsuite/gcc.targe

[PATCH, rs6000] Repair vec_xl, vec_xst, vec_xl_be, vec_xst_be built-in functions

2017-11-13 Thread Bill Schmidt
Hi, Some previous patches to add support for vec_xl_be and fill in gaps in testing for vec_xl and vec_xst resulted in incorrect semantics for these built-in functions. My fault for not reviewing them in detail. Essentially the vec_xl and vec_xl_be semantics were reversed, and vec_xst received se

Re: [C++ PATCH] Remove the null check from placement new in all modes

2017-11-13 Thread Jason Merrill
On Mon, Nov 13, 2017 at 6:53 AM, Ville Voutilainen wrote: > * g++.dg/tree-ssa/pr31146-2.C: Likewise. > * g++.dg/tree-ssa/pr31146-3.C: New. > * g++.dg/tree-ssa/pr41428-2.C: Likewise. > * g++.dg/tree-ssa/pr41428.C: Adjust. These are testing optimizations, so let's just add -fcheck-n

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-11-13 Thread Richard Biener
On November 13, 2017 3:20:16 PM GMT+01:00, Michael Matz wrote: >Hi, > >On Mon, 13 Nov 2017, Richard Biener wrote: > >> The chance here is, of course (find the PR, it exists...), that SRA >then >> decomposes the char[] copy bytewise... >> >> That said, memcpy folding is easy to fix. The question

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-11-13 Thread Michael Matz
Hi, On Mon, 13 Nov 2017, Richard Biener wrote: > The chance here is, of course (find the PR, it exists...), that SRA then > decomposes the char[] copy bytewise... > > That said, memcpy folding is easy to fix. The question is of course > what the semantic of VIEW_CONVERTs is (SRA _does_ contain

Re: [patch] Fix PR lto/81351

2017-11-13 Thread Richard Biener
On Mon, Nov 13, 2017 at 3:11 PM, Jan Hubicka wrote: >> > 2017-11-10 Eric Botcazou >> > >> > PR lto/81351 >> > * debug.h (dwarf2out_do_eh_frame): Declare. >> > * dwarf2cfi.c (dwarf2out_do_eh_frame): New predicate. >> > (dwarf2out_do_frame): Use it. >> > (dwarf2out_do_cfi_asm)

Re: [patch] Fix PR lto/81351

2017-11-13 Thread Jan Hubicka
> > 2017-11-10 Eric Botcazou > > > > PR lto/81351 > > * debug.h (dwarf2out_do_eh_frame): Declare. > > * dwarf2cfi.c (dwarf2out_do_eh_frame): New predicate. > > (dwarf2out_do_frame): Use it. > > (dwarf2out_do_cfi_asm): Likewise. > > * dwarf2out.c (dwarf2out_frame_finish):

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-11-13 Thread Richard Biener
On Mon, Nov 13, 2017 at 2:46 PM, Michael Matz wrote: > Hi, > > On Mon, 13 Nov 2017, Richard Biener wrote: > >> The main concern here is that GIMPLE is not very well defined for >> aggregate copies and that gimple-fold.c happily optimizes >> memcpy (&a, &b, sizeof (a)) into a = b; > > What you miss

Re: [PATCH][AArch64] Improve aarch64_legitimate_constant_p

2017-11-13 Thread Christophe Lyon
On 6 November 2017 at 15:44, Richard Sandiford wrote: > Wilco Dijkstra writes: >> Richard Sandiford wrote: >>> >>> Yeah, I'd hit this too. I think it's a latent bug that just >>> happened to be exposed by Wilco's patch: although the *movti_aarch64 >>> predicate disallows const_wide_int, the cons

RE: [PATCH 21/22] Add extra field to gtm_jmpbuf on x86 only

2017-11-13 Thread Tsimbalist, Igor V
> -Original Message- > From: H.J. Lu [mailto:hjl.to...@gmail.com] > Sent: Thursday, November 9, 2017 2:37 PM > To: Tsimbalist, Igor V > Cc: Jeff Law ; gcc-patches@gcc.gnu.org; > trie...@redhat.com; Jakub Jelinek > Subject: Re: [PATCH 21/22] Add extra field to gtm_jmpbuf on x86 only > > O

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-11-13 Thread Michael Matz
Hi, On Mon, 13 Nov 2017, Richard Biener wrote: > The main concern here is that GIMPLE is not very well defined for > aggregate copies and that gimple-fold.c happily optimizes > memcpy (&a, &b, sizeof (a)) into a = b; What you missed to mention is that we then discussed about rectifying this sit

Re: [AArch64, testsuite] gfortran.dg/ieee/ieee_8.f90: xfail for aarch64+ilp32

2017-11-13 Thread Charles Baylis
On 30 October 2017 at 08:52, Janne Blomqvist wrote: > On Tue, Oct 24, 2017 at 9:27 PM, Charles Baylis > wrote: >> The test is already marked xfail for aarch64*-*-gnu, but this needs to >> be changed to aarch64*-*-gnu* in order to match >> aarch64-linux-gnu_ilp32. >> >> Test was previously xfail'd

Re: [PATCH][AArch64] Set default sched pressure algorithm

2017-11-13 Thread Christophe Lyon
On 6 November 2017 at 14:05, Wilco Dijkstra wrote: > Maxim Kuvyrkov wrote: >> > On Nov 2, 2017, at 9:41 PM, Wilco Dijkstra wrote: >> > >> > The Arm backend sets the default sched-pressure algorithm to >> > SCHED_PRESSURE_MODEL. Benchmarking on AArch64 shows this >> > speeds up floating point per

Re: [PATCH PR82726/PR70754][2/2]New fix by finding correct root reference in combined chains

2017-11-13 Thread Richard Biener
On Sat, Nov 11, 2017 at 11:19 AM, Bernhard Reutner-Fischer wrote: > On Fri, Nov 10, 2017 at 02:14:25PM +, Bin.Cheng wrote: >> Hmm, the patch... > > + /* Setup UID for all statements in dominance order. */ > + basic_block *bbs = get_loop_body (loop); > + for (i = 0; i < loop->num_nodes; i++

Re: VRP: x+1 and -x cannot be INT_MIN

2017-11-13 Thread Richard Biener
On Sat, Nov 11, 2017 at 11:03 PM, Marc Glisse wrote: > Hello, > > with undefined overflow, just because we know nothing about one of the > arguments of an addition doesn't mean we can't say something about the > result. We could constrain more the cases where we replace VR_VARYING with a > full VR

Re: [RFC PATCH] Merge libsanitizer from upstream

2017-11-13 Thread Christophe Lyon
On 30 October 2017 at 16:21, Maxim Ostapenko wrote: > On 30/10/17 17:08, Christophe Lyon wrote: >> >> On 30/10/2017 11:12, Maxim Ostapenko wrote: >>> >>> Hi, >>> >>> sorry for the late response. >>> >>> On 20/10/17 13:45, Christophe Lyon wrote: Hi, On 19 October 2017 at 13:17,

Re: [RFC, PR 80689] Copy small aggregates element-wise

2017-11-13 Thread Richard Biener
On Fri, Nov 3, 2017 at 5:38 PM, Martin Jambor wrote: > Hi, > > On Thu, Oct 26, 2017 at 02:43:02PM +0200, Richard Biener wrote: >> On Thu, Oct 26, 2017 at 2:18 PM, Martin Jambor wrote: >> > >> > Nevertheless, I still intend to experiment with the limit, I sent out >> > this RFC exactly so that I d

Re: [C++ PATCH] Remove the null check from placement new in all modes

2017-11-13 Thread Ville Voutilainen
On 13 November 2017 at 14:17, Eric Botcazou wrote: >> 2017-11-13 Ville Voutilainen >> >> gcc/ >> >> Remove the null check from placement new in all modes >> * cp/init.c (build_new_1): Don't do a null check for >> a namespace-scope non-replaceable placement new >> in any mode

Re: [patch] Fix PR lto/81351

2017-11-13 Thread Eric Botcazou
> 2017-11-10 Eric Botcazou > > PR lto/81351 > * debug.h (dwarf2out_do_eh_frame): Declare. > * dwarf2cfi.c (dwarf2out_do_eh_frame): New predicate. > (dwarf2out_do_frame): Use it. > (dwarf2out_do_cfi_asm): Likewise. > * dwarf2out.c (dwarf2out_frame_finish): Lik

Re: [C++ PATCH] Remove the null check from placement new in all modes

2017-11-13 Thread Eric Botcazou
> 2017-11-13 Ville Voutilainen > > gcc/ > > Remove the null check from placement new in all modes > * cp/init.c (build_new_1): Don't do a null check for > a namespace-scope non-replaceable placement new > in any mode unless -fcheck-new is provided. Incorrect entry, it shou

Re: [C++ PATCH] Remove the null check from placement new in all modes

2017-11-13 Thread Ville Voutilainen
On 10 November 2017 at 18:55, Ville Voutilainen wrote: > On 10 November 2017 at 18:19, Jason Merrill wrote: >> OK. > > > I see non-obvious testsuite failures, I'll see if adding -fcheck-new > to those cases > cures the problem. Please stay tuned. :) Here. Tested on Linux-PPC64 and Linux-x64. 20

Re: [PATCH][AArch64] Improve scheduling model for X-Gene

2017-11-13 Thread Kyrill Tkachov
On 13/11/17 11:09, Dominik Inführ wrote: Oh sure, I've now successfully bootstrapped on arm-linux-gnueabihf and aarch64-unknown-linux-gnu. Dominik Thanks Dominik, This is ok for trunk. Kyrill On 10 Nov 2017, at 10:53, Kyrill Tkachov wrote: Hi Dominic, On 10/11/17 09:36, Dominik Infüh

Re: [x86][patch] Add -march=cannonlake.

2017-11-13 Thread Uros Bizjak
On Mon, Nov 13, 2017 at 11:29 AM, Koval, Julia wrote: > Hi, here is followup patch to add skylake-avx512. > gcc/ > * config/i386/driver-i386.c (host_detect_local_cpu): Detect > skylake-avx512. OK. Thanks, Uros.

Re: [PATCH][AArch64] Improve scheduling model for X-Gene

2017-11-13 Thread Dominik Inführ
Oh sure, I've now successfully bootstrapped on arm-linux-gnueabihf and aarch64-unknown-linux-gnu. Dominik > On 10 Nov 2017, at 10:53, Kyrill Tkachov wrote: > > Hi Dominic, > > On 10/11/17 09:36, Dominik Inführ wrote: >> Hi, >> >> this patch tries to refine the instruction scheduling model fo

Re: Adjust empty class parameter passing ABI (PR c++/60336)

2017-11-13 Thread Jakub Jelinek
On Mon, Nov 13, 2017 at 11:44:38AM +0100, Richard Biener wrote: > > Unfortunately, it's not what I see. I ran two bootstraps, with and without > > the > > patch. Then I stripped all the .o files and ran cmp on them, but many of > > them > > differ. objdump -dr reveals why -- I see changes like

Re: Adjust empty class parameter passing ABI (PR c++/60336)

2017-11-13 Thread Richard Biener
On Mon, 13 Nov 2017, Marek Polacek wrote: > On Fri, Nov 10, 2017 at 11:16:04AM -0500, Jason Merrill wrote: > > On 11/09/2017 10:26 AM, Richard Biener wrote: > > > > Moving TYPE_EMPTY_P to finalize_type_size revealed a bug in Cilk+, it > > > > was > > > > bogusly (I believe) setting TREE_ADDRESSAB

[Patch, fortran] PR78990 [5/6/7 Regression] ICE when assigning polymorphic array function result

2017-11-13 Thread Paul Richard Thomas
This turned out to be quite a challenging debugging job as often seems to be the case where the scalarizer is involved. Ultimately, I found that the testcase compiled when return_t1 was made a pointer and the resulting code revealed where the problems lay. This modified testcase now works as well b

Re: Adjust empty class parameter passing ABI (PR c++/60336)

2017-11-13 Thread Marek Polacek
On Fri, Nov 10, 2017 at 11:16:04AM -0500, Jason Merrill wrote: > On 11/09/2017 10:26 AM, Richard Biener wrote: > > > Moving TYPE_EMPTY_P to finalize_type_size revealed a bug in Cilk+, it was > > > bogusly (I believe) setting TREE_ADDRESSABLE, so the assert fired. Since > > > Cilk+ is being depreca

Re: [PATCH,doc] Fix latency in pipeline description example

2017-11-13 Thread Luis Machado
On 11/10/2017 08:30 PM, Jim Wilson wrote: On 11/09/2017 03:44 AM, Luis Machado wrote: Am i missing something or is this example incorrect and this should either have a latency of 9 (patch attached) or a different resource utilization description, say, containing "div*6" instead? The numbers a

RE: [x86][patch] Add -march=cannonlake.

2017-11-13 Thread Koval, Julia
Hi, here is followup patch to add skylake-avx512. gcc/ * config/i386/driver-i386.c (host_detect_local_cpu): Detect skylake-avx512. > -Original Message- > From: Uros Bizjak [mailto:ubiz...@gmail.com] > Sent: Sunday, November 12, 2017 5:05 PM > To: Koval, Julia > Cc: GCC Patches ;

Re: [PATCH], Enable fminf and fmaxf

2017-11-13 Thread Richard Biener
On Thu, Nov 9, 2017 at 2:44 PM, Michael Meissner wrote: > In my previous patch enabling some of the built-in functions for _Float and > _FloatX datatypes, I missed making fminf128 and fmaxf128 generate the > minimum and maximum inline code when -ffast-math is used. This patch to > match.pd enable

Re: [PATCH] Handle different bit_not_p in store merging (PR tree-optimization/78821)

2017-11-13 Thread Richard Biener
On Fri, 10 Nov 2017, Jakub Jelinek wrote: > Hi! > > This is something Uros requested in the PR, at least with BIT_NOT_EXPRs > it is easy. Previous store merging changes required that bit_not_p > is equal on all stores in the group (in all 3 spots, i.e. on the result > of BIT_{AND,IOR,XOR}_EXPR a

Re: [RFC] [Patch X86_64]: Pass to split FMA to MUL and ADD

2017-11-13 Thread Richard Biener
On Tue, Nov 7, 2017 at 4:44 PM, Michael Matz wrote: > Hi, > > On Tue, 7 Nov 2017, Richard Biener wrote: > >> > With FMA however the situation is different becuase there are rounding >> > differences. Why we can convert multiplicatoin+add into FMA without >> > -ffast-math at first place? >> >> We d

Re: [SFN+LVU+IEPM v4 7/9] [LVU] Introduce location views

2017-11-13 Thread Richard Biener
On Fri, Nov 10, 2017 at 3:34 AM, Alexandre Oliva wrote: > This patch introduces an option to enable the generation of location > views along with location lists. The exact format depends on the > DWARF version: it can be a separate attribute (DW_AT_GNU_locviews) or > (DW_LLE_view_pair) entries in

Re: bootstrap-debug-lean + flags in producer vs compare

2017-11-13 Thread Richard Biener
On Sat, Nov 11, 2017 at 1:15 AM, Alexandre Oliva wrote: > On Oct 30, 2017, Jeff Law wrote: > >> I'd support either or both. Your call. > > Thanks. I think I'll go with both, then. > > Ok to install as follows? (edited the comments and added a ChangeLog) Ok. > > Use compare-debug for bootstrap

Re: fix -fcompare-debug OBJ_TYPE_REF dumps of linker plugin-less LTO builds

2017-11-13 Thread Richard Biener
On Sat, Nov 11, 2017 at 12:57 AM, Alexandre Oliva wrote: > There are two patches below. Each one of them fixes the problem > described below by itself, and both would also fix it together. > > The former preserves OBJ_TYPE_REF type info in all dumps that > should/would have it, even after TYPE_BI

Fwd: [patch] implement generic debug() for vectors and hash sets

2017-11-13 Thread Aldy Hernandez
PING*3 -- Forwarded message -- From: Aldy Hernandez Date: Mon, Oct 16, 2017 at 9:52 AM Subject: [patch] implement generic debug() for vectors and hash sets To: gcc-patches We have a generic mechanism for dumping types from the debugger with: (gdb) call debug(some_type) Howeve

Re: [PATCH] detect nonstring arguments to string functions (PR 82945)

2017-11-13 Thread Bernhard Reutner-Fischer
On 13 November 2017 01:52:41 CET, Martin Sebor wrote: s/^\(he array\)/t\1/ thanks,

[committed] [AArch64] More aarch64_endian_lane_rtx

2017-11-13 Thread Richard Sandiford
r254466 failed to update some uses of ENDIAN_LANE_N that were added after the patch was initially written, which meant that we were treating the mode number as an element count. Tested on aarch64-linux-gnu and aarch64_be-elf and installed as obvious. Sorry for the breakage... Richard 2017-11-13

Re: [PATCH] Fix store-merging of cst followed by load (PR tree-optimization/82954)

2017-11-13 Thread Richard Biener
On Sun, 12 Nov 2017, Jakub Jelinek wrote: > Hi! > > The conditions split groups if some operand is loaded in first stmt > and the second load is incompatible with it, or if it is loaded and > second stmt has constant in there instead of load. > But as this testcase shows, I didn't handle properly