Re: Go patches committed: merge recent changes to gofrontend

2017-05-10 Thread Uros Bizjak
Hello! > I have committed a large patch to update the Go frontend and libgo to > the recent changes in the gofrontend repository. I had postponed > merging changes during the GCC 7 release process. I am now merging > all the changes that were pending during that period. Although this > is a mer

[PATCH][X86] Add missing intrinsics for VRSQRT14

2017-05-10 Thread Koval, Julia
Hi, These are 4 missing intrinsics for VRSQRT14 instruction. Ok for trunk? gcc/ * config/i386/avx512fintrin.h (_mm_mask_rsqrt14_sd, _mm_maskz_rsqrt14_sd, _mm_mask_rsqrt14_ss, _mm_maskz_rsqrt14_ss): New intrinsics. * config/i386/i386-builtin.def (__builtin_ia32_rsqrt14sd_m

Re: [PING] [PATCH] [AArch64] vec_pack_trunc_ should split after register allocator

2017-05-10 Thread Hurugalawadi, Naveen
Hi, Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same. https://gcc.gnu.org/ml/gcc-patches/2017-04/msg01334.html Thanks, Naveen

Re: [PING] [PATCH] [AArch64] Implement ALU_BRANCH fusion

2017-05-10 Thread Hurugalawadi, Naveen
Hi, Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same. https://gcc.gnu.org/ml/gcc-patches/2017-04/msg01333.html Thanks, Naveen   

Re: [PING] [PATCH] [AArch64] PR target/71663 Improve Vector Initializtion

2017-05-10 Thread Hurugalawadi, Naveen
Hi, Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same. https://gcc.gnu.org/ml/gcc-patches/2017-04/msg01260.html Thanks, Naveen

Re: [PING2] [PATCH][AArch64] Add neon_pairwise_add & neon_pairwise_add_q types

2017-05-10 Thread Hurugalawadi, Naveen
Hi,  Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same.  https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00505.html Thanks, Naveen    

Re: [PING2][PATCH][AArch64] Add crypto_pmull attribute

2017-05-10 Thread Hurugalawadi, Naveen
Hi,   Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same.   https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00504.html Thanks, Naveen    

Re: [PING2][PATCH] [AArch64] Implement automod load and store for Thunderx2t99

2017-05-10 Thread Hurugalawadi, Naveen
Hi,   Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same.   https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00226.html Thanks, Naveen

Re: [PING2][PATCH][AArch64] Add addr_type attribute

2017-05-10 Thread Hurugalawadi, Naveen
Hi,  Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same.  https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00222.html Thanks, Naveen    

Re: [PING2][PATCH][AArch64] Add addr_type attribute

2017-05-10 Thread Hurugalawadi, Naveen
Hi,  Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same.  https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00222.html Thanks, Naveen    

Re: [PING2][PATCH][AArch64] Add addr_type attribute

2017-05-10 Thread Hurugalawadi, Naveen
Hi,  Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same.  https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00222.html Thanks, Naveen    

Re: [PING2][PATCH][AArch64] Add addr_type attribute

2017-05-10 Thread Hurugalawadi, Naveen
Hi,  Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same.  https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00222.html Thanks, Naveen    

Re: [PING][PATCH] Move the check for any_condjump_p from sched-deps to target macros

2017-05-10 Thread Hurugalawadi, Naveen
Hi, >> Doesn't this avoid calling the target hook in cases where it used to >> call it before? Yes. Thanks for pointing it out. >> Consider a conditional jump inside a parallel that is not a single set. Please find attached the modified patch that handles the case mentioned. Please review the

Re: Go patches committed: merge recent changes to gofrontend

2017-05-10 Thread Andrew Pinski
On Wed, May 10, 2017 at 5:37 PM, Andrew Pinski wrote: > On Wed, May 10, 2017 at 10:26 AM, Ian Lance Taylor wrote: >> I have committed a large patch to update the Go frontend and libgo to >> the recent changes in the gofrontend repository. I had postponed >> merging changes during the GCC 7 relea

Re: Go patches committed: merge recent changes to gofrontend

2017-05-10 Thread Andrew Pinski
On Wed, May 10, 2017 at 10:26 AM, Ian Lance Taylor wrote: > I have committed a large patch to update the Go frontend and libgo to > the recent changes in the gofrontend repository. I had postponed > merging changes during the GCC 7 release process. I am now merging > all the changes that were pe

[PATCH] hppa: Fix pa_assemble_integer

2017-05-10 Thread John David Anglin
There are situations on hppa when call assemble_external will result in actual assembly code being generated. An example is shown in PR target/80090 where compiling autodock-vina fails. The problem is that output_addr_const may output visibility information while outputting an address constant

[Committed] hppa: Reject changes to/from modes with zero size in pa_cannot_change_mode_class

2017-05-10 Thread John David Anglin
The attached change fixes PR target/79027 On gcc-8 and gcc-7, under some conditions that are a bit hard to reproduce, we get a floating point exception when regcprop.c tries to change a SImode value to BLKmode. The attached patch to pa_cannot_change_mode_class reject such changes. As a result

[PATCH] Move target independent code to support target_clones attributes from i386 to common code

2017-05-10 Thread Michael Meissner
As I mentioned in the mail message: https://gcc.gnu.org/ml/gcc/2017-05/msg00060.html I'm working on adding the target_clones attribute support to the PowerPC. I have an implementation right now, but I want to iterate on it somewhat. In doing the patch, I noticed there were several functions that

[RFA] Improve tree-ssa-uninit.c's predicate simplification

2017-05-10 Thread Jeff Law
So I have some improvements to jump threading that are regressing one of the uninit-preds testcases. The problem is we end up threading deeper into the CFG during VRP1. This changes the shape of the CFG such that the condition guarding a use changes in an interesting way. Background: The

Re: [PATCH] Kill -fdump-translation-unit

2017-05-10 Thread Nathan Sidwell
On 05/10/2017 01:58 PM, Jakub Jelinek wrote: A quick search indicates that people have published .tu parsers in Perl, JS (producing json), the person objecting on IRC apparently used Python, and I'm aware of another Python-based parser by Bruce Merry. Prior to Alex mentioning it, I was unaware

[C++ PATCH] address of overload

2017-05-10 Thread Nathan Sidwell
We were gratuitously checking for an overload before using OVL_CURRENT, and then unilaterally using OVL_CURRENT on the result of that. I also simplify taking the address of an overloaded fn by using'for (tree fn ...) idiom. And strip out another unneeded anticipated decl stripping. Applied

Re: [PATCH] Kill -fdump-translation-unit

2017-05-10 Thread Alexander Monakov
On Wed, 10 May 2017, Jakub Jelinek wrote: > Can it at least be taken out of -fdump-tree-all? It is huge, often larger > than the sum of all the other dump files, and don't remember ever using it > for anything. Yes, apart from advertising the capability I don't imagine it's useful to produce that

[C++ PATCH] ambiguous candidate printing

2017-05-10 Thread Nathan Sidwell
Ambiguous lookups return a tree list that can contain embedded overload lists. This patch separates the printing somewhat more, so that the overload iterator I'll be introduce will slot in better. It'd be nice for ambiguous lookups to return a specially marked overload, but that's a change fo

Re: [patch] FreeBSD arm libgcc config.host

2017-05-10 Thread Andreas Tobler
On 07.05.17 21:30, Andreas Tobler wrote: Hi all, I'm going to commit the below patch to all active branches. (8,7,6,5) It makes arm*-*-freebsd* use the generic FreeBSD t-slibgcc-elf-ver definition. This makes all FreeBSD targets 'consistent' in this area. If not ok, please speak up soon. Comm

Re: Bump version namespace and remove _Rb_tree useless template parameter

2017-05-10 Thread François Dumont
On 10/05/2017 11:28, Jonathan Wakely wrote: On 10/05/17 11:15 +0200, Paolo Carlini wrote: Hi, On 10/05/2017 11:12, Jonathan Wakely wrote: Looks good to me. Paolo, what do you think about bumping the versioned namespace and SONAME to 8? Sure, makes sense to me too. Please commit it then, Fra

[C++ PATCH] remove unnecessary hidden pruning

2017-05-10 Thread Nathan Sidwell
Name lookup as it currently is already removes hidden names for regular lookup (sometimes more than once!). It also strips anticipated builtins. So there's no need to do it again when building a function call. Applied to trunk. nathan -- Nathan Sidwell 2017-05-10 Nathan Sidwell * cp-tre

Re: [RFC PATCH, i386]: Enable post-reload compare elimination pass

2017-05-10 Thread Jakub Jelinek
On Wed, May 10, 2017 at 09:57:56PM +0200, Uros Bizjak wrote: > BTW: This patch now catches 417 cases (instead of 200+) in linux > build, including e.g.: > > (parallel [ > (set (reg:CCZ 17 flags) > (compare:CCZ (lshiftrt:SI (reg:SI 4 si [orig:93 _10 ] [93]) >

[PATCH] sparc: Set noexecstack on mulsi3, divsi3, and modsi3

2017-05-10 Thread Adhemerval Zanella
A recent GLIBC fix for sparc [1] made some configuration to show an executable stack on ld.so (shown on elf/check-execstack testcase failure). It is because with generated sparc toolchain from build-many-glibcs.py (a GLIBC script to produce cross-compiling toolchains) the minimum supported sparc32

Minor C++ PATCH to make unify_invalid a common breakpoint

2017-05-10 Thread Jason Merrill
It's periodically been a minor headache that there was no one place I could set a breakpoint on when exactly deduction fails. This patch makes unify_invalid that place. Tested x86_64-pc-linux-gnu, applying to trunk. commit 387302d431ce2d837c947c6893cbcbce1cdd1318 Author: Jason Merrill Date: We

C++ PATCH for CWG DR 1847, partial ordering and non-deduced context

2017-05-10 Thread Jason Merrill
The resolution of Core DRs 1391 and 1847 clarified that function parameters that don't involve deducible template parameters are not considered for partial ordering. I also experimented with handling this at a finer-grained level, in unify, so that we would handle a typename vs. a concrete type ev

Re: [RFC PATCH, i386]: Enable post-reload compare elimination pass

2017-05-10 Thread Uros Bizjak
On Wed, May 10, 2017 at 9:05 PM, Uros Bizjak wrote: > On Wed, May 10, 2017 at 5:18 PM, Uros Bizjak wrote: >> On Wed, May 10, 2017 at 4:27 PM, Jakub Jelinek wrote: >>> On Tue, May 09, 2017 at 06:06:47PM +0200, Uros Bizjak wrote: Attached patch enables post-reload compare elimination pass by

Re: Make tree-ssa-strlen.c handle partial unterminated strings

2017-05-10 Thread Richard Sandiford
Jakub Jelinek writes: > Hi! > > Note the intent of the pass is to handle the most common cases, it is fine > if some cases that aren't common aren't handled, it is all about the extra > complexity vs. how much it helps on real-world code. OK. > On Sun, May 07, 2017 at 10:10:48AM +0100, Richard S

Re: [RFC PATCH, i386]: Enable post-reload compare elimination pass

2017-05-10 Thread Uros Bizjak
On Wed, May 10, 2017 at 5:18 PM, Uros Bizjak wrote: > On Wed, May 10, 2017 at 4:27 PM, Jakub Jelinek wrote: >> On Tue, May 09, 2017 at 06:06:47PM +0200, Uros Bizjak wrote: >>> Attached patch enables post-reload compare elimination pass by >>> providing expected patterns (duplicates of existing pa

Re: [PATCH][x86] Add missing intrinsics for MAX[SD,SS] and MIN[SD,SS]

2017-05-10 Thread Uros Bizjak
On Tue, May 9, 2017 at 1:43 PM, Peryt, Sebastian wrote: > Hi, > > This patch adds missing intrinsics for MAXSD, MAXSS, MINSD and MINSS > instructions. > > 2017-05-09 Sebastian Peryt > > gcc/ > * config/i386/avx512fintrin.h (_mm_mask_max_round_sd, > _mm_maskz_max_round_sd, _mm_m

Re: [PATCH][x86] Add missing intrinsics for DIV[SD,SS] and MUL[SD,SS]

2017-05-10 Thread Uros Bizjak
On Tue, May 9, 2017 at 1:39 PM, Peryt, Sebastian wrote: > Hi, > > This patch adds missing intrinsics for DIVSD, DIVSS, MULSD and MULSS > instructions. > > 2017-05-09 Sebastian Peryt > > gcc/ > * config/i386/avx512fintrin.h (_mm_mask_mul_round_sd, > _mm_maskz_mul_round_sd, _mm_m

Re: [PR80582][X86] Add missing __mm256_set[r] intrinsics

2017-05-10 Thread Uros Bizjak
On Tue, May 9, 2017 at 11:42 AM, Koval, Julia wrote: > Sorry, fixed that. > > Thanks, > Julia > > -Original Message- > From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: Tuesday, May 09, 2017 11:36 AM > To: Koval, Julia > Cc: GCC Patches ; Uros Bizjak ; > Kirill Yukhin > Subject: Re:

Re: [PATCH][x86] Add missing intrinsics for vrcp14sd/ss instructions.

2017-05-10 Thread Uros Bizjak
On Tue, May 9, 2017 at 8:21 AM, Koval, Julia wrote: > Hi, > > This patch adds missing intrinsics for VRCP14SD and VRCP14SS instructions: > _mm_mask_rcp14_sd > _mm_maskz_rcp14_sd > _mm_mask_rcp14_ss > _mm_maskz_rcp14_ss > > These instructions and intrinsics are described in SDM Vol. 2C 5-487. > > g

Re: [PATCH, rs6000] Add x86 instrinsic headers to GCC PPC64LE taget

2017-05-10 Thread Steven Munroe
On Tue, 2017-05-09 at 16:03 -0500, Segher Boessenkool wrote: > On Tue, May 09, 2017 at 02:33:00PM -0500, Steven Munroe wrote: > > On Tue, 2017-05-09 at 12:23 -0500, Segher Boessenkool wrote: > > > On Mon, May 08, 2017 at 09:49:57AM -0500, Steven Munroe wrote: > > > > Thus I would like to restrict t

Re: [PATCH] Kill -fdump-translation-unit

2017-05-10 Thread Jakub Jelinek
On Wed, May 10, 2017 at 08:51:22PM +0300, Alexander Monakov wrote: > On Wed, 10 May 2017, Richard Biener wrote: > > > On Tue, May 9, 2017 at 5:41 PM, Nathan Sidwell wrote: > > > -fdump-translation-unit is an inscrutably opaque dump. It turned out that > > > most of the uses of the tree-dump head

Re: [c++ PATCH] PR c++/80682

2017-05-10 Thread Nathan Sidwell
On 05/10/2017 01:13 PM, Richard Biener wrote: On May 10, 2017 6:36:20 PM GMT+02:00, Nathan Sidwell wrote: On 05/10/2017 10:21 AM, Ville Voutilainen wrote: IIUC backports have to fix a regression. So you'll need to convince the release maintainer. From a C++ POV you're approved. Wrong-cod

Re: [PATCH] Kill -fdump-translation-unit

2017-05-10 Thread Alexander Monakov
On Wed, 10 May 2017, Richard Biener wrote: > On Tue, May 9, 2017 at 5:41 PM, Nathan Sidwell wrote: > > -fdump-translation-unit is an inscrutably opaque dump. It turned out that > > most of the uses of the tree-dump header file was to indirectly get at > > dumpfile.h, and the dump_function entry

Go patches committed: merge recent changes to gofrontend

2017-05-10 Thread Ian Lance Taylor
I have committed a large patch to update the Go frontend and libgo to the recent changes in the gofrontend repository. I had postponed merging changes during the GCC 7 release process. I am now merging all the changes that were pending during that period. Although this is a merged patch, the cha

Re: [PATCH] Ada/x32: PR ada/80626: Correct Memory_Size

2017-05-10 Thread Arnaud Charlet
> Here is the patch: > > X32 uses 64 as word size instead of 32. This must not affect the > Address type definition which is based on Memory_Size. > > PR ada/80626 > * system-linux-x86.ads (Memory_Size): Use Long_Integer'Size > instead of Word_Size. > > Tested on x86-64 with -m64/-m32/-mx32.

Re: [CHKP] Fix for PR79990

2017-05-10 Thread Ilya Enkovich
2017-05-09 16:29 GMT+03:00 Alexander Ivchenko : > Hi, > > Here is the latest version of the patch with all comments addressed: > > gcc/ChangeLog: > > 2017-05-09 Alexander Ivchenko > > * tree-chkp.c (chkp_get_hard_register_var_fake_base_address): > New function. > (chkp_get_hard_r

Re: [c++ PATCH] PR c++/80682

2017-05-10 Thread Richard Biener
On May 10, 2017 6:36:20 PM GMT+02:00, Nathan Sidwell wrote: >On 05/10/2017 10:21 AM, Ville Voutilainen wrote: >> On 10 May 2017 at 14:40, Nathan Sidwell wrote: > >> >> I appreciate that, but given that I operate under Write-After >Approval, I need >> more than a no-objection, I will need an actu

Re: [c++ PATCH] PR c++/80682

2017-05-10 Thread Nathan Sidwell
On 05/10/2017 10:21 AM, Ville Voutilainen wrote: On 10 May 2017 at 14:40, Nathan Sidwell wrote: I appreciate that, but given that I operate under Write-After Approval, I need more than a no-objection, I will need an actual ok from a maintainer. :) IIUC backports have to fix a regression.

Re: OpenACC C front end maintenance: c_parser_oacc_single_int_clause (was: [OpenACC] num_gangs, num_workers and vector_length in c++)

2017-05-10 Thread Jakub Jelinek
On Tue, May 09, 2017 at 11:27:14PM +0200, Thomas Schwinge wrote: > Hi! > > On Wed, 4 Nov 2015 14:10:29 -0800, Cesar Philippidis > wrote: > > > [...] > > > > Thanks. I've applied this patch to trunk. > > > gcc/cp/ > > * (cp_parser_oacc_single_int_clause): New function. > > (cp_parse

Minor C++ PATCH for dependent_type_p sanity check

2017-05-10 Thread Jason Merrill
A while back I noticed that we were calling dependent_type_p with global_type_node, which should never happen. I fixed that separately, but this patch adds a check to catch it if it happens again. Tested x86_64-pc-linux-gnu, applying to trunk. commit f9b1055070c90162f505d11a929a797f55d3230f Autho

Re: Use "oacc kernels parallelized" attribute for parallelized OpenACC kernels (was: Use "oacc kernels" attribute for OpenACC kernels)

2017-05-10 Thread Jakub Jelinek
On Tue, May 09, 2017 at 10:57:34PM +0200, Thomas Schwinge wrote: > commit b6b5d549089423e3fbe387f63467d052b956f3f7 > Author: Thomas Schwinge > Date: Tue May 9 20:14:03 2017 +0200 > > Use "oacc kernels parallelized" attribute for parallelized OpenACC kernels > > gcc/ >

Re: Use "oacc kernels" attribute for OpenACC kernels

2017-05-10 Thread Jakub Jelinek
On Mon, May 08, 2017 at 09:29:28PM +0200, Thomas Schwinge wrote: > commit fac5c3214f58812881635d3fb1e1751446d4b660 > Author: Thomas Schwinge > Date: Mon May 8 21:24:46 2017 +0200 > > Use "oacc kernels" attribute for OpenACC kernels > > gcc/ > * omp-expand.c (exp

Re: [patch, fortran] Reduce stack use in blocked matmul

2017-05-10 Thread Andreas Schwab
On Mai 10 2017, Thomas Koenig wrote: > ... on a 32-bit system, of course. http://gcc.gnu.org/ml/gcc-testresults/2017-05/msg01063.html FAIL: gfortran.dg/generic_20.f90 -O0 execution test FAIL: gfortran.dg/generic_20.f90 -O1 execution test FAIL: gfortran.dg/generic_20.f90 -O2 execution t

Re: C++ PATCHes for c++/79549 and 79556 (ICE with auto parameter pack)

2017-05-10 Thread Jason Merrill
On Fri, Feb 17, 2017 at 1:41 PM, Jason Merrill wrote: > In 79556, we try to deduce an auto type from a dependent initializer > with null TREE_TYPE, which doesn't work; fixed by catching that case > in do_auto_deduction. > > In 79549, we try to tsubst into the type of a NONTYPE_ARGUMENT_PACK, > whi

Re: [patch, fortran] Reduce stack use in blocked matmul

2017-05-10 Thread Andreas Schwab
On Mai 10 2017, Thomas Koenig wrote: > If you manage to come up with a legal Fortran testcas which > sets b_dim1 to 0xdeadbeef, I owe you a beer :-) grep is your friend. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B

Re: [patch, fortran] Reduce stack use in blocked matmul

2017-05-10 Thread Thomas Koenig
Am 10.05.2017 um 17:42 schrieb Thomas Koenig: If you manage to come up with a legal Fortran testcas which sets b_dim1 to 0xdeadbeef, I owe you a beer :-) ... on a 32-bit system, of course.

Re: [C++ Patch] PR 80186 ("ICE on C++ code with invalid constructor...")

2017-05-10 Thread Jason Merrill
> On Mon, May 8, 2017 at 7:25 AM, Paolo Carlini > wrote: >> in order to avoid this error recovery issue I think we want to check the >> return value of grok_ctor_properties, as we do in decl.c, for its only other >> use. Tested x86_64-linux. The new testcase fails with -std=c++1z because the rva

Re: Test cases to check OpenACC offloaded function's attributes and classification

2017-05-10 Thread Jakub Jelinek
On Mon, May 08, 2017 at 07:02:15PM +0200, Thomas Schwinge wrote: > Hi! > > Ping. > > On Thu, 4 Aug 2016 16:06:10 +0200, I wrote: > > Ping. > > > > On Wed, 27 Jul 2016 10:59:02 +0200, I wrote: > > > OK for trunk? > > (In the mean time, I also added some more testing.) > > commit b7d61270dfc581a

Re: OpenACC 2.5 default (present) clause

2017-05-10 Thread Jakub Jelinek
On Fri, Apr 07, 2017 at 05:08:55PM +0200, Thomas Schwinge wrote: > Hi! > > OpenACC 2.5 added a default (present) clause, which "causes all arrays or > variables of aggregate data type used in the compute construct that have > implicitly determined data attributes to be treated as if they appeared

Re: [patch, fortran] Reduce stack use in blocked matmul

2017-05-10 Thread Thomas Koenig
Hi Andreas, + index_type t1_dim; + t1_dim = (a_dim1-1) * 256 + b_dim1; + if (t1_dim > 65536) + t1_dim = 65536; + +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wvla" + 'rtype_name` t1[t1_dim]; /* was [256][256] */ That does the wrong thing if b_dim1 ==

Re: [PATCH] Output DIEs for outlined OpenMP functions in correct lexical scope

2017-05-10 Thread Jakub Jelinek
On Fri, May 05, 2017 at 10:23:59AM -0700, Kevin Buettner wrote: > On Fri, 5 May 2017 14:23:14 +0300 (MSK) > Alexander Monakov wrote: > > > On Thu, 4 May 2017, Kevin Buettner wrote: > > > diff --git a/gcc/omp-expand.c b/gcc/omp-expand.c > > > index 5c48b78..7029951 100644 > > > --- a/gcc/omp-expan

Re: [RFC PATCH, i386]: Enable post-reload compare elimination pass

2017-05-10 Thread Uros Bizjak
On Wed, May 10, 2017 at 4:27 PM, Jakub Jelinek wrote: > On Tue, May 09, 2017 at 06:06:47PM +0200, Uros Bizjak wrote: >> Attached patch enables post-reload compare elimination pass by >> providing expected patterns (duplicates of existing patterns with >> setters of reg and flags switched in the pa

Re: [1/2] PR 78736: New warning -Wenum-conversion

2017-05-10 Thread Martin Sebor
On 05/10/2017 06:19 AM, Prathamesh Kulkarni wrote: On 9 May 2017 at 23:34, Martin Sebor wrote: On 05/09/2017 07:24 AM, Prathamesh Kulkarni wrote: ping https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00161.html Thanks, Prathamesh On 3 May 2017 at 11:30, Prathamesh Kulkarni wrote: On 3 May 2

[PATCH] Ada/x32: PR ada/80626: Correct Memory_Size

2017-05-10 Thread H.J. Lu
On Tue, May 9, 2017 at 7:32 PM, H.J. Lu wrote: > On Tue, Apr 4, 2017 at 4:46 AM, Andreas Krebbel > wrote: >> On 04/03/2017 06:18 PM, Eric Botcazou wrote: On S/390 UNITS_PER_WORD is: 8 with -m64 4 with -m31 8 with -m31 -mzarch This has been chosen to support use of 64

Re: [PATCH GCC8][01/33]Handle TRUNCATE between tieable modes in rtx_cost

2017-05-10 Thread Bin.Cheng
On Wed, May 3, 2017 at 11:09 AM, Kyrill Tkachov wrote: > Hi Bin, > > > On 03/05/17 11:02, Bin.Cheng wrote: >> >> On Wed, May 3, 2017 at 9:38 AM, Bin.Cheng wrote: >>> >>> On Wed, May 3, 2017 at 7:17 AM, Eric Botcazou >>> wrote: > > 2017-04-11 Bin Cheng > >* rtlanal.c (r

Re: [RFC PATCH, i386]: Enable post-reload compare elimination pass

2017-05-10 Thread Jakub Jelinek
On Tue, May 09, 2017 at 06:06:47PM +0200, Uros Bizjak wrote: > Attached patch enables post-reload compare elimination pass by > providing expected patterns (duplicates of existing patterns with > setters of reg and flags switched in the parallel) for flag setting > arithmetic instructions. > > The

Re: [c++ PATCH] PR c++/80682

2017-05-10 Thread Ville Voutilainen
On 10 May 2017 at 14:40, Nathan Sidwell wrote: >>> Full testsuite run is clean. Is it ok to backport this change to >>> gcc-6? (And gcc-7, too) >> >> >> ..and gcc-5. Backporting everywhere allows library implementations >> including libc++ to >> just use the intrinsic, without using std::is_constr

Re: [PATCH 1/2] x86,s390: add compiler memory barriers when expanding atomic_thread_fence (PR 80640)

2017-05-10 Thread Alexander Monakov
While fixing the fences issue of PR80640 I've noticed that a similar oversight is present in expansion of atomic loads on x86: they become volatile loads, but that is insufficient, a compiler memory barrier is still needed. Volatility prevents tearing the load (preserves non-divisibility of atomic

[PATCH] Make PRE/FRE elimination not do useless work

2017-05-10 Thread Richard Biener
So this is a patch that makes skipping unreachable code when doing elimination possible. Previously interesting interactions with tail-merging made this impossible, now I seem to have figured a way around this. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. With this more elabor

[PATCH] Verify loops with TODO_verify_il

2017-05-10 Thread Richard Biener
This fixes two remaining issues with properly preserving loops, one academic with -dx which skips all RTL optimizers and then ICEs in clean_state when trying to verify loops after we freed everything else. One maybe serious where TM instrumentation wrecks loops but doesn't tell others about this

Re: Make tree-ssa-strlen.c handle partial unterminated strings

2017-05-10 Thread Jakub Jelinek
Hi! Note the intent of the pass is to handle the most common cases, it is fine if some cases that aren't common aren't handled, it is all about the extra complexity vs. how much it helps on real-world code. On Sun, May 07, 2017 at 10:10:48AM +0100, Richard Sandiford wrote: > I've got most of the

[PATCH 1/2] x86,s390: add compiler memory barriers when expanding atomic_thread_fence (PR 80640)

2017-05-10 Thread Alexander Monakov
Hi, When expanding __atomic_thread_fence(x) to RTL, the i386 backend doesn't emit any instruction except for x==__ATOMIC_SEQ_CST (which emits 'mfence'). This is incorrect: although no machine barrier is needed, the compiler still must emit a compiler barrier into the IR to prevent propagation an

[gomp5] Add C/C++ lastprivate(conditional: ...) parsing

2017-05-10 Thread Jakub Jelinek
Hi! This patch adds so far just parsing and diagnostics of conditional: modifier to lastprivate clause. Implementation for simd will require some vectorizer improvements, for non-orphaned worksharing I think I can add a shared variable on the parallel holding max so far stored iteration # and redu

Re: [PATCH 0/3] v3 of C++ template type diffing

2017-05-10 Thread Nathan Sidwell
On 05/09/2017 09:41 PM, David Malcolm wrote: On Tue, 2017-05-09 at 10:52 -0400, Nathan Sidwell wrote: I split out the non-c++ bits into a separate patch. v3 of the patch kit is thus three parts: [1/3] Non-C++ parts of template type diff printing I believe I can self-approve this part [2/

Re: [PATCH, v4] Fix PR51513, switch statement with default case containing __builtin_unreachable leads to wild branch

2017-05-10 Thread Richard Biener
On Tue, 9 May 2017, Peter Bergner wrote: > Here is the updated patch to use gimple_seq_unreachable_p() which scans the > sequence backwards so it bails out earlier in the common case (ie, no call > to __builtin_unreachable). As discussed in the previous thread, we remove > case statement labels f

Re: [PATCH] Fix bootstrap on arm target

2017-05-10 Thread Arnaud Charlet
> >> It is due to a -Werror warning when passing GNAT_EXCEPTION_CLASS > >> which is a string constant to exception_class_eq, but C++ forbids to > >> cast > >> that to "char*". > >> > >> Not sure what is the smartest solution, I tried the following and it > >> seems to work for x86_64-pc-linux-gnu a

Re: [PATCH] Fix bootstrap on arm target

2017-05-10 Thread Bernd Edlinger
On 05/09/17 15:10, Arnaud Charlet wrote: >> >> since a few days the bootstrap of ada fails on a native arm target. >> >> It is due to a -Werror warning when passing GNAT_EXCEPTION_CLASS >> which is a string constant to exception_class_eq, but C++ forbids to cast >> that to "char*". >> >> Not sure w

[C++ PATCH] add_method, clone_function_decl

2017-05-10 Thread Nathan Sidwell
Another cleanup from modules. Changed the final parms to bool from tree and int respectively. In the former case we were only using its non-nullness. Although cloning a ctor can clone an inherited ctor (via a using-decl), we don't need to record the usingness on the complete or base ctors.

Re: [1/2] PR 78736: New warning -Wenum-conversion

2017-05-10 Thread Prathamesh Kulkarni
On 9 May 2017 at 23:34, Martin Sebor wrote: > On 05/09/2017 07:24 AM, Prathamesh Kulkarni wrote: >> >> ping https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00161.html >> >> Thanks, >> Prathamesh >> >> On 3 May 2017 at 11:30, Prathamesh Kulkarni >> wrote: >>> >>> On 3 May 2017 at 03:28, Martin Sebor

[PATCH] tabify dumpfile.h

2017-05-10 Thread Nathan Sidwell
Committed this pre-patch to tabify dumpfile.h. It was inconsistently using spaces and tabs for alignment. nathan -- Nathan Sidwell 2017-05-10 Nathan Sidwell * dumpfile.h: Tabify. Index: dumpfile.h === --- dumpfile.h (revision

Re: [c++ PATCH] PR c++/80682

2017-05-10 Thread Nathan Sidwell
On 05/10/2017 05:37 AM, Ville Voutilainen wrote: On 10 May 2017 at 09:57, Ville Voutilainen wrote: Full testsuite run is clean. Is it ok to backport this change to gcc-6? (And gcc-7, too) ..and gcc-5. Backporting everywhere allows library implementations including libc++ to just use the in

Re: [PATCH] make RTL/TREE/IPA dump kind an index

2017-05-10 Thread Nathan Sidwell
On 05/10/2017 05:05 AM, Richard Biener wrote: On Tue, May 9, 2017 at 9:00 PM, Nathan Sidwell wrote: + +#define TDF_ADDRESS(1 << 3)/* dump node addresses */ this leaves 1 << 2 unused. Yes, that was intentional (though I suspect my note about it was hidden). As you say, I expec

[Committed][AArch64] Fix PR80671

2017-05-10 Thread Wilco Dijkstra
Move an use-after-free access before the delete. Committed as obvious. ChangeLog: 2017-05-10 Wilco Dijkstra PR target/80671 * config/aarch64/cortex-a57-fma-steering.c (merge_forest): Move member access before delete. -- diff --git a/gcc/config/aarch64/cortex-a57-fma-s

Re: [PATCH 01/13] improve safety of freeing bitmaps

2017-05-10 Thread Richard Biener
On Wed, May 10, 2017 at 12:52 PM, Trevor Saunders wrote: > On Wed, May 10, 2017 at 10:14:17AM +0200, Richard Biener wrote: >> On Tue, May 9, 2017 at 10:52 PM, wrote: >> > From: Trevor Saunders >> > >> > There's two groups of changes here, first taking a sbitmap &, so that we >> > can assign nul

Re: [PATCH, GCC/LTO, ping3] Fix PR69866: LTO with def for weak alias in regular object file

2017-05-10 Thread Thomas Preudhomme
Hi, On 09/05/17 23:36, Jan Hubicka wrote: Ping? Sorry for late reply Hi, This patch fixes an assert failure when linking one LTOed object file having a weak alias with a regular object file containing a strong definition for that same symbol. The patch is twofold: + do not add an alias to a

Re: [PATCH 01/13] improve safety of freeing bitmaps

2017-05-10 Thread Trevor Saunders
On Wed, May 10, 2017 at 10:14:17AM +0200, Richard Biener wrote: > On Tue, May 9, 2017 at 10:52 PM, wrote: > > From: Trevor Saunders > > > > There's two groups of changes here, first taking a sbitmap &, so that we > > can assign null to the pointer after freeing the sbitmap to prevent use > > aft

Re: PR77644

2017-05-10 Thread Richard Biener
On Wed, 10 May 2017, Prathamesh Kulkarni wrote: > On 10 May 2017 at 14:28, Richard Biener wrote: > > On Tue, 9 May 2017, Prathamesh Kulkarni wrote: > > > >> Hi, > >> The attached patch adds the following pattern to match.pd > >> sqrt(x) cmp sqrt(y) -> x cmp y. > >> and is enabled with -funsafe-ma

Re: [c++ PATCH] PR c++/80682

2017-05-10 Thread Ville Voutilainen
On 10 May 2017 at 09:57, Ville Voutilainen wrote: > On 9 May 2017 at 17:14, Nathan Sidwell wrote: >> On 05/09/2017 08:06 AM, Ville Voutilainen wrote: >>> >>> Tested on Linux-x64, not tested with the full suite yet. >>> >>> 2017-05-09 Ville Voutilainen >>> >>> gcc/ >>> >>> PR c++/8068

Re: Bump version namespace and remove _Rb_tree useless template parameter

2017-05-10 Thread Jonathan Wakely
On 10/05/17 11:15 +0200, Paolo Carlini wrote: Hi, On 10/05/2017 11:12, Jonathan Wakely wrote: Looks good to me. Paolo, what do you think about bumping the versioned namespace and SONAME to 8? Sure, makes sense to me too. Please commit it then, François - thanks!

Re: PR77644

2017-05-10 Thread Prathamesh Kulkarni
On 10 May 2017 at 14:28, Richard Biener wrote: > On Tue, 9 May 2017, Prathamesh Kulkarni wrote: > >> Hi, >> The attached patch adds the following pattern to match.pd >> sqrt(x) cmp sqrt(y) -> x cmp y. >> and is enabled with -funsafe-math-optimization and -fno-math-errno. >> >> Bootstrapped+tested

Re: Bump version namespace and remove _Rb_tree useless template parameter

2017-05-10 Thread Paolo Carlini
Hi, On 10/05/2017 11:12, Jonathan Wakely wrote: Looks good to me. Paolo, what do you think about bumping the versioned namespace and SONAME to 8? Sure, makes sense to me too. Paolo.

Re: Bump version namespace and remove _Rb_tree useless template parameter

2017-05-10 Thread Jonathan Wakely
On 09/05/17 22:03 +0200, François Dumont wrote: On 05/05/2017 15:08, Jonathan Wakely wrote: On 04/05/17 22:16 +0200, François Dumont wrote: Hi Here is the patch to remove the useless _Is_pod_comparator _Rb_tree_impl template parameter. As this is an ABI breaking change it is limited to the

Re: Trivial iter_swap cleanup

2017-05-10 Thread Jonathan Wakely
On 09/05/17 22:33 +0200, François Dumont wrote: Hi A trivial code simplification in a pre-C++11 piece of code. Ok to commit ? Good catch! OK, thanks.

Re: [PATCH] make RTL/TREE/IPA dump kind an index

2017-05-10 Thread Richard Biener
On Tue, May 9, 2017 at 9:00 PM, Nathan Sidwell wrote: > Currently, the TDF_foo flags serve 3 purposes: > 1) what kind of dump > 2) how detailed to print it > 3) auxiliary message control > > This addresses #1, which currently uses a bit mask of TDF_{TREE,RTL,IPA}, of > which exactly one must be se

Re: PR77644

2017-05-10 Thread Richard Biener
On Tue, 9 May 2017, Prathamesh Kulkarni wrote: > Hi, > The attached patch adds the following pattern to match.pd > sqrt(x) cmp sqrt(y) -> x cmp y. > and is enabled with -funsafe-math-optimization and -fno-math-errno. > > Bootstrapped+tested on x86_64-unknown-linux-gnu. > Cross-tested on arm*-*-*,

Re: [PATCH] Kill -fdump-translation-unit

2017-05-10 Thread Richard Biener
On Tue, May 9, 2017 at 5:41 PM, Nathan Sidwell wrote: > -fdump-translation-unit is an inscrutably opaque dump. It turned out that > most of the uses of the tree-dump header file was to indirectly get at > dumpfile.h, and the dump_function entry point it had forwarded to a dumper > in tree-cfg.c.

Re: [PATCH] non-checking pure attribute

2017-05-10 Thread Richard Biener
On Tue, May 9, 2017 at 5:16 PM, Nathan Sidwell wrote: > On 05/09/2017 09:39 AM, Richard Biener wrote: >> >> On Tue, May 9, 2017 at 3:33 PM, Nathan Sidwell wrote: > > >>> I wondered if we'd get sane backtraces and what not, if the optimizer >>> thought such functions never barfed. >> >> >> Well, I

Re: [PATCH 13/13] make inverted_post_order_compute() operate on a vec

2017-05-10 Thread Richard Biener
On Tue, May 9, 2017 at 10:52 PM, wrote: > From: Trevor Saunders > > gcc/ChangeLog: Ok. Richard. > 2017-05-09 Trevor Saunders > > * cfganal.c (inverted_post_order_compute): Change argument type > to vec *. > * cfganal.h (inverted_post_order_compute): Adjust prototype

Re: [PATCH 09/13] use auto_bitmap more with alternate obstacks

2017-05-10 Thread Richard Biener
On Tue, May 9, 2017 at 10:52 PM, wrote: > From: Trevor Saunders > > gcc/ChangeLog: Ok. > 2017-05-09 Trevor Saunders > > * df-core.c (df_set_blocks): Start using auto_bitmap. > (df_compact_blocks): Likewise. > * df-problems.c (df_rd_confluence_n): Likewise. >

Re: [PATCH 12/13] make depth_first_search_ds a class

2017-05-10 Thread Richard Biener
On Tue, May 9, 2017 at 10:52 PM, wrote: > From: Trevor Saunders > > gcc/ChangeLog: Ok. > 2017-05-09 Trevor Saunders > > * cfganal.c (connect_infinite_loops_to_exit): Adjust. > (depth_first_search::depth_first_search): Change structure init > function to this constructor. >

Re: [PATCH 07/13] use auto_bitmap more

2017-05-10 Thread Richard Biener
On Tue, May 9, 2017 at 10:52 PM, wrote: > From: Trevor Saunders > > gcc/ChangeLog: Ok. Richard. > 2017-05-09 Trevor Saunders > > * bt-load.c (combine_btr_defs): Use auto_bitmap to manage bitmap > lifetime. > (migrate_btr_def): Likewise. > * cfgloop.c (get_lo

Re: [PATCH 04/13] allow auto_bitmap to use other bitmap obstacks

2017-05-10 Thread Richard Biener
On Tue, May 9, 2017 at 10:52 PM, wrote: > From: Trevor Saunders > > gcc/ChangeLog: Ok. > 2017-05-07 Trevor Saunders > > * bitmap.h (class auto_bitmap): New constructor taking > bitmap_obstack * argument. > --- > gcc/bitmap.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/

  1   2   >