GCC doc patch committed

2017-02-23 Thread Ian Lance Taylor
I committed this patch to wwwdocs/htdocs/gcc-7/changes.html to describe the status of Go in the GCC 7 release. Ian Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-7/changes.html,v retrieving revision 1.65 diff -u -r1.65

Re: [PATCH] PR79584, lra ICE in base_to_reg

2017-02-23 Thread Alan Modra
I'm going to wait for Vlad's opinion. I've written a couple of replies and erased them, since I figure whatever I have to say doesn't carry much weight. -- Alan Modra Australia Development Lab, IBM

enable -Wformat-truncation with -Og (PR 79691)

2017-02-23 Thread Martin Sebor
Bug 79691 - -Wformat-truncation suppressed by (and only by) -Og points out that the gimple-ssa-sprintf pass doesn't run when this optimization option is used. That's because I forgot to add it to the set of optimization passes that run with that option. The attached trivial patch tested on x86_6

Re: [PATCH] PR79584, lra ICE in base_to_reg

2017-02-23 Thread Richard Sandiford
Alan Modra writes: > On Thu, Feb 23, 2017 at 11:41:09AM +1030, Alan Modra wrote: >> lo_sum is indeed not valid for mem:SD. simplify_operand_subreg is >> where the subreg disappears. > > Richard, doesn't the following say that lra is expecting to reload > exactly the lo_sum address you seem to thi

Re: [PATCH] restore -Wunused-variable on a typedef'd variable in a function template (PR 79548)

2017-02-23 Thread Jason Merrill
On Thu, Feb 23, 2017 at 12:56 PM, Martin Sebor wrote: > On 02/22/2017 05:43 PM, Jason Merrill wrote: >> On Wed, Feb 22, 2017 at 3:44 PM, Martin Sebor wrote: >>> On 02/22/2017 11:02 AM, Jason Merrill wrote: >>> The TREE_USED bit on the type (i.e., on >>> TREE_TYPE(decl) where decl is the u in the

[visium] Clean up C testsuite

2017-02-23 Thread Eric Botcazou
This eliminates all the regressions that recently crept in (except for the famous gcc.dg/tree-ssa/ssa-thread-14.c present on several other platforms). Tested on visium-elf, applied on the mainline. 2017-02-23 Eric Botcazou * config/visium/visium.md (type): Add trap. (b): New

[PATCH,MIPS] Handle paired single test changes

2017-02-23 Thread Matthew Fortune
Hi Catherine, I missed a couple of testsuite changes that are needed to deal with the fallout of fixing the ABI issues for floating point vectors. I had them in my tree but forgot to post. The ABI change for V2SF i.e. paired single is a bug fix as the behaviour was unintended and violates the go

Re: fwprop fix for PR79405

2017-02-23 Thread Jeff Law
On 02/23/2017 01:57 AM, Richard Biener wrote: On Wed, Feb 22, 2017 at 6:19 PM, Jeff Law wrote: On 02/16/2017 12:41 PM, Bernd Schmidt wrote: We have two registers being assigned to each other: (set (reg 213) (reg 209)) (set (reg 209) (reg 213)) These being the only definitions, we are happ

Re: [PATCH, doc]: Mention that -mfpmath=sse is the default on 32bit x86 w/ SSE2 and -ffast-math

2017-02-23 Thread Martin Sebor
On 02/23/2017 12:01 PM, Uros Bizjak wrote: On Thu, Feb 23, 2017 at 7:07 PM, Martin Sebor wrote: A minor grammatical nit: +This is the default choice for most of x86-32 targets. "for most x86-32 targets" is correct unless the targets are some specific subset, in which case "most of the [pre

Re: [PATCH] Move -Wrestrict warning later in the FEs and fix some issues in it (PR c++/79588)

2017-02-23 Thread Jeff Law
On 02/20/2017 01:35 PM, Jakub Jelinek wrote: Hi! As mentioned in the PR, -Wrestrict warning is done way too early, where e.g. default arguments aren't filled up yet (reason for ICE on first testcase) or where arguments in templates aren't instantiated yet (reason why we don't diagnose anything o

Re: [PATCH PR79663]Only reversely combine refs for ZERO length chains in predcom

2017-02-23 Thread Jeff Law
On 02/23/2017 04:24 AM, Bin Cheng wrote: Hi, This patch resolves spec2k/mgrid regression as reported by PR79663. Root cause has been described thoroughly in comment #1/#2 of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79663 This patch handles ZERO/non-ZERO length chains differently and only r

Re: [PATCH,testsuite] Use logical_op_short_circuit to skip targets in ssa-thread-14.c.

2017-02-23 Thread Jeff Law
On 02/23/2017 04:04 AM, Toma Tabacu wrote: Hi, The ssa-thread-14.c test has been failing for MIPS for a while. According to Patrick Palka, who modified this test's target selector in the fix for PR71314, this test fails on targets which don't use non-short-circuit logical ops and should be skip

[PATCH][PR tree-optimization/79578] Use OEP_ADDRESS_OF

2017-02-23 Thread Jeff Law
Per Richi's request use OEP_ADDRESS_OF in the call to operand_equal_p. Bootstrapped and regression tested on x86_64-linux-gnu. Installed on the trunk. jeff commit 9715bea8d2c2a8332acca572afdd6c0403e677a9 Author: law Date: Thu Feb 23 21:43:03 2017 + PR tree-optimization/79578

Re: [PATCH] Improve ifcvt (PR tree-optimization/79389)

2017-02-23 Thread Bernd Schmidt
On 02/23/2017 10:27 PM, Jakub Jelinek wrote: Now successfully bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? LGTM. Bernd

Re: [PATCH] Improve ifcvt (PR tree-optimization/79389)

2017-02-23 Thread Jakub Jelinek
On Thu, Feb 23, 2017 at 03:07:14PM +0100, Jakub Jelinek wrote: > On Thu, Feb 23, 2017 at 02:47:11PM +0100, Bernd Schmidt wrote: > > On 02/23/2017 02:36 PM, Jakub Jelinek wrote: > > > and both UNLT and GE can be reversed. But if the arguments of the > > > condition > > > are canonicalized, we run

Re: [PATCH][PR tree-optimization/79578] Use operand_equal_p rather than pointer equality for base test

2017-02-23 Thread Jeff Law
On 02/23/2017 02:02 AM, Richard Biener wrote: diff --git a/gcc/tree-ssa-dse.c b/gcc/tree-ssa-dse.c index 84c0b11..a82e164 100644 --- a/gcc/tree-ssa-dse.c +++ b/gcc/tree-ssa-dse.c @@ -176,7 +176,7 @@ clear_bytes_written_by (sbitmap live_bytes, gimple *stmt, ao_ref *ref) /* Verify we have the s

Re: [PATCH] restore -Wunused-variable on a typedef'd variable in a function template (PR 79548)

2017-02-23 Thread Martin Sebor
On 02/22/2017 05:43 PM, Jason Merrill wrote: On Wed, Feb 22, 2017 at 3:44 PM, Martin Sebor wrote: On 02/22/2017 11:02 AM, Jason Merrill wrote: On Tue, Feb 21, 2017 at 4:27 PM, Martin Sebor wrote: Ah, I see, your patch changes attribute unused handling for local variables from tracking TREE

Re: [PATCH, doc]: Mention that -mfpmath=sse is the default on 32bit x86 w/ SSE2 and -ffast-math

2017-02-23 Thread Uros Bizjak
On Thu, Feb 23, 2017 at 7:07 PM, Martin Sebor wrote: > A minor grammatical nit: > > +This is the default choice for most of x86-32 targets. > > "for most x86-32 targets" is correct unless the targets are some > specific subset, in which case "most of the [previously mentioned] > x86-32 targets"

[PATCH] Ensure includes

2017-02-23 Thread Jonathan Wakely
Lars noticed that didn't include as it's supposed to. I checked the other TS headers and they're OK. * include/experimental/iterator: Include . * testsuite/experimental/iterator/requirements.cc: Check for contents of . Tested powerpc64le-linux, committed to trunk. com

Re: [PATCH, doc]: Mention that -mfpmath=sse is the default on 32bit x86 w/ SSE2 and -ffast-math

2017-02-23 Thread Martin Sebor
On 02/23/2017 04:09 AM, Uros Bizjak wrote: Hello! This patch documents a little gcc secret... 2017-02-23 Uros Bizjak * doc/invoke.texi (x86 Options, -mfpmath=sse): Mention that -mfpmath=sse is the default also for x86-32 targets with SSE2 instruction set when @option{-ffast-math

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-02-23 Thread Wilco Dijkstra
  ping From: Wilco Dijkstra Sent: 17 January 2017 19:23 To: GCC Patches Cc: nd; Kyrill Tkachov; Richard Earnshaw Subject: [PATCH][ARM] Remove DImode expansions for 1-bit shifts     A left shift of 1 can always be done using an add, so slightly adjust rtx cost for DImode left shift by 1 so t

Re: [PATCH][ARM] Remove Thumb-2 iordi_not patterns

2017-02-23 Thread Wilco Dijkstra
  ping From: Wilco Dijkstra Sent: 17 January 2017 18:00 To: GCC Patches Cc: nd; Kyrylo Tkachov; Richard Earnshaw Subject: [PATCH][ARM] Remove Thumb-2 iordi_not patterns     After Bernd's DImode patch [1] almost all DImode operations are expanded early (except for -mfpu=neon). This means the

Re: [PATCH v3][AArch64] Fix symbol offset limit

2017-02-23 Thread Wilco Dijkstra
  ping From: Wilco Dijkstra Sent: 17 January 2017 15:14 To: Richard Earnshaw; GCC Patches; James Greenhalgh Cc: nd Subject: Re: [PATCH v3][AArch64] Fix symbol offset limit     Here is v3 of the patch - tree_fits_uhwi_p was necessary to ensure the size of a declaration is an integer. So the

Re: [PATCH][ARM] Fix ldrd offsets

2017-02-23 Thread Wilco Dijkstra
    ping From: Wilco Dijkstra Sent: 03 November 2016 12:20 To: GCC Patches Cc: nd Subject: [PATCH][ARM] Fix ldrd offsets     Fix ldrd offsets of Thumb-2 - for TARGET_LDRD the range is +-1020, without -255..4091.  This reduces the number of addressing instructions when using DI mode operations

Re: [PATCH][ARM] Improve max_insns_skipped logic

2017-02-23 Thread Wilco Dijkstra
    ping From: Wilco Dijkstra Sent: 10 November 2016 17:19 To: GCC Patches Cc: nd Subject: [PATCH][ARM] Improve max_insns_skipped logic     Improve the logic when setting max_insns_skipped.  Limit the maximum size of IT to MAX_INSN_PER_IT_BLOCK as otherwise multiple IT instructions are needed

Re: [PATCH][ARM] Remove movdi_vfp_cortexa8

2017-02-23 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 29 November 2016 11:05 To: GCC Patches Cc: nd Subject: [PATCH][ARM] Remove movdi_vfp_cortexa8     Merge the movdi_vfp_cortexa8 pattern into movdi_vfp and remove it to avoid unnecessary duplication and repeating bugs like PR78439 due to changes being applied only

Re: [C++ Patch] PR 79361

2017-02-23 Thread Jason Merrill
Ok. On Thu, Feb 23, 2017 at 6:02 AM, Paolo Carlini wrote: > Hi, > > in this error recovery regression, we ICE after (a lot after) a sensible > diagnostic, when lower_function_body encounters an error_mark_node. I worked > quite a bit on the issue, and, all in all, I propose to simply check the >

Re: [PR 78140] Reuse same IPA bits and VR info

2017-02-23 Thread Martin Jambor
Hi, On Wed, Feb 22, 2017 at 11:11:14AM +0100, Martin Jambor wrote: > Hello, > > this is a fix for PR 78140 which is about LTO WPA of Firefox taking > 1GB memory more than gcc 6. > > It works by reusing the ipa_bits and value_range that we previously > had directly in jump functions and which are

[gomp4] DEV-PHASE change

2017-02-23 Thread Tom de Vries
[ was: r241221 [1/2] - in /branches/gomp-4_0-branch: ] On 16/10/16 22:13, tschwi...@gcc.gnu.org wrote: Author: tschwinge Date: Sun Oct 16 20:13:18 2016 New Revision: 241221 URL: https://gcc.gnu.org/viewcvs?rev=241221&root=gcc&view=rev Log: svn merge -r 235033:240831 svn+ssh://gcc.gnu.org/s

Re: [PATCH] PR 68749: S/390: Disable ifcvt-4.c for -m31.

2017-02-23 Thread Andreas Krebbel
On 02/15/2017 12:19 PM, Dominik Vogt wrote: > The attached patch disables the test ifcvt-4.c on s390 and on > s390x with -31, and adds -march=z196 for s390x. It should no > longer fail on s390 and s390x. > > Tested on s390x biarch. > > Ciao > > Dominik ^_^ ^_^ > Applied. Thanks! -Andreas-

[PATCH] PR79389, path-splitting

2017-02-23 Thread Richard Biener
This PR shows another defect in path-splittings cost model which the following patch tries to improve further. Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2017-02-23 Richard Biener PR tree-optimization/79389 * gimple-ssa-split-paths.c (is_feasible_tra

Re: PR79286, ira combine_and_move_insns in loops

2017-02-23 Thread Jeff Law
On 02/23/2017 02:52 AM, Alan Modra wrote: On Thu, Feb 23, 2017 at 12:46:17AM -0700, Jeff Law wrote: And thus we keep the equivalence. Ultimately may_trap_p considers a PIC memory reference as non-trapping. Which is obviously a bug, because this access is segfaulting.. Not that I want to poke

Re: [gomp4] add -finform-parallelism

2017-02-23 Thread Cesar Philippidis
On 02/22/2017 12:17 AM, Thomas Schwinge wrote: > On Mon, 20 Feb 2017 20:42:59 -0800, Cesar Philippidis > wrote: >> --- a/gcc/omp-low.c >> +++ b/gcc/omp-low.c > >> +/* Provide diagnostics on OpenACC loops LOOP, its siblings and its >> + children. */ >> + >> +static void >> +inform_oacc_loop (

Re: [PATCH PR79663]Only reversely combine refs for ZERO length chains in predcom

2017-02-23 Thread Richard Biener
On Thu, Feb 23, 2017 at 12:24 PM, Bin Cheng wrote: > Hi, > This patch resolves spec2k/mgrid regression as reported by PR79663. Root > cause has been > described thoroughly in comment #1/#2 of > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79663 > This patch handles ZERO/non-ZERO length chains d

[gomp4] backport OPTGROUP_OPENMP

2017-02-23 Thread Cesar Philippidis
This patch backports OPTGROUP_OPENMP from trunk. The patch was originally posted by Martin Jambor here . Thomas, I know that you have a patch to rename this to OPTGROUP_OMP. But in order to keep things consistent with trunk, I kept it OPTGR

Re: [PATCH] Improve ifcvt (PR tree-optimization/79389)

2017-02-23 Thread Jakub Jelinek
On Thu, Feb 23, 2017 at 03:07:14PM +0100, Jakub Jelinek wrote: > On Thu, Feb 23, 2017 at 02:47:11PM +0100, Bernd Schmidt wrote: > > On 02/23/2017 02:36 PM, Jakub Jelinek wrote: > > > and both UNLT and GE can be reversed. But if the arguments of the > > > condition > > > are canonicalized, we run

[PATCH, wwwdocs] Update AArch64 entry in readings.html

2017-02-23 Thread Richard Earnshaw (lists)
This patch tweaks the wording in the entry for AArch64 and also adds a Manufacturer: entry similar to that for ARM. Committed. R. Index: readings.html === RCS file: /cvs/gcc/wwwdocs/htdocs/readings.html,v retrieving revision 1.261 di

Re: [PATCH] Improve ifcvt (PR tree-optimization/79389)

2017-02-23 Thread Jakub Jelinek
On Thu, Feb 23, 2017 at 02:47:11PM +0100, Bernd Schmidt wrote: > On 02/23/2017 02:36 PM, Jakub Jelinek wrote: > > and both UNLT and GE can be reversed. But if the arguments of the condition > > are canonicalized, we run into: > > /* Test for an integer condition, or a floating-point comparison >

[C++ Patch] PR 79361

2017-02-23 Thread Paolo Carlini
Hi, in this error recovery regression, we ICE after (a lot after) a sensible diagnostic, when lower_function_body encounters an error_mark_node. I worked quite a bit on the issue, and, all in all, I propose to simply check the return value of duplicate_decls as called by register_specializati

Re: [PATCH] Improve ifcvt (PR tree-optimization/79389)

2017-02-23 Thread Bernd Schmidt
On 02/23/2017 02:36 PM, Jakub Jelinek wrote: and both UNLT and GE can be reversed. But if the arguments of the condition are canonicalized, we run into: /* Test for an integer condition, or a floating-point comparison in which NaNs can be ignored. */ if (CONST_INT_P (arg0) || (GE

Re: [PATCH] Improve ifcvt (PR tree-optimization/79389)

2017-02-23 Thread Jakub Jelinek
On Thu, Feb 23, 2017 at 02:26:24PM +0100, Bernd Schmidt wrote: > On 02/23/2017 12:46 PM, Jakub Jelinek wrote: > > But as soon as we only have the (unlt (reg:DF 100) (reg:DF 97)), > > reversed_comparison_code fails on it: > > case UNLT: > > case UNLE: > > case UNGT: > > case UNGE: >

Re: [PATCH] Improve ifcvt (PR tree-optimization/79389)

2017-02-23 Thread Bernd Schmidt
On 02/23/2017 12:46 PM, Jakub Jelinek wrote: But as soon as we only have the (unlt (reg:DF 100) (reg:DF 97)), reversed_comparison_code fails on it: case UNLT: case UNLE: case UNGT: case UNGE: /* We don't have safe way to reverse these yet. */ return UNKNOWN; I do ha

[PATCH] Improve ifcvt (PR tree-optimization/79389)

2017-02-23 Thread Jakub Jelinek
Hi! Uros noted in the PR that in many cases with floating point comparisons ifcvt fails to RTL if-convert or end up being RTL if-converted in worse way than it could be (e.g. something that ought to be noce_try_addcc optimizable is only if-converted using noce_try_cmove_arith, resulting in worse p

[PATCH PR79663]Only reversely combine refs for ZERO length chains in predcom

2017-02-23 Thread Bin Cheng
Hi, This patch resolves spec2k/mgrid regression as reported by PR79663. Root cause has been described thoroughly in comment #1/#2 of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79663 This patch handles ZERO/non-ZERO length chains differently and only reversely combines refs for ZERO length cha

[PATCH, doc]: Mention that -mfpmath=sse is the default on 32bit x86 w/ SSE2 and -ffast-math

2017-02-23 Thread Uros Bizjak
Hello! This patch documents a little gcc secret... 2017-02-23 Uros Bizjak * doc/invoke.texi (x86 Options, -mfpmath=sse): Mention that -mfpmath=sse is the default also for x86-32 targets with SSE2 instruction set when @option{-ffast-math} is enabled Bootstrapped on x86_64-linux-gn

[PATCH,testsuite] Use logical_op_short_circuit to skip targets in ssa-thread-14.c.

2017-02-23 Thread Toma Tabacu
Hi, The ssa-thread-14.c test has been failing for MIPS for a while. According to Patrick Palka, who modified this test's target selector in the fix for PR71314, this test fails on targets which don't use non-short-circuit logical ops and should be skipped for such targets. In the case of MIPS, LO

Re: [PATCH, i386]: Fix PR79593: Poor/Worse code generation for FPU on versions after 6

2017-02-23 Thread Uros Bizjak
On Tue, Feb 21, 2017 at 7:52 PM, Uros Bizjak wrote: > Hello! > > Attached patch fixes oversight in standard_x87sse_constant_load > splitter and its float-extend counterpart, where a FP reg-reg move > insn RTX can be tagged with REG_EQUIV or REG_EQUAL const_double RTX. > > find_constant_src and ix8

Re: PR79286, ira combine_and_move_insns in loops

2017-02-23 Thread Alan Modra
On Thu, Feb 23, 2017 at 12:46:17AM -0700, Jeff Law wrote: > And thus we keep the equivalence. Ultimately may_trap_p considers a PIC > memory reference as non-trapping. Which is obviously a bug, because this access is segfaulting.. Not that I want to poke at the bug. :) > I really wonder if we s

[PATCH] Fix PR79684

2017-02-23 Thread Richard Biener
The following makes sure to initialize the location range for c_exprs the gimple parser routines eventually return. Bootstrap / regtest in progress on x86_64-unknown-linux-gnu. Richard. 2017-02-23 Richard Biener PR c/79684 * gimple-parser.c (c_parser_gimple_statement): Use s

Re: [PATCH][PR tree-optimization/79578] Use operand_equal_p rather than pointer equality for base test

2017-02-23 Thread Richard Biener
On Thu, Feb 23, 2017 at 6:49 AM, Jeff Law wrote: > > tree-ssa-dse.c needs to verify when two writes have the same base address. > Right now it uses pointer equality. The testcase in BZ79578 shows that we > should have been using operand_equal_p. > > This one-liner fixes that oversight. Bootstrap

Re: fwprop fix for PR79405

2017-02-23 Thread Richard Biener
On Wed, Feb 22, 2017 at 6:19 PM, Jeff Law wrote: > On 02/16/2017 12:41 PM, Bernd Schmidt wrote: >> >> We have two registers being assigned to each other: >> >> (set (reg 213) (reg 209)) >> (set (reg 209) (reg 213)) >> >> These being the only definitions, we are happy to forward propagate reg >>

[PATCH] Fix PR79683

2017-02-23 Thread Richard Biener
The following fixes BB vectorization to not forget addr-space qualifications of loads. Bootstrap / regtest running on x86_64-unknown-linux-gnu. Richard. 2017-02-23 Richard Biener PR tree-optimization/79683 * tree-vect-stmts.c (vect_analyze_stmt): Do not overwrite ve