Re: [PATCH] PR rtl-optimization/67029: gcc-5.2.0 unable to find a register to spill with O3 fsched-pressure fschedule-insns

2015-08-05 Thread H.J. Lu
On Wed, Aug 05, 2015 at 01:24:20PM -0700, H.J. Lu wrote: > Since ira_implicitly_set_insn_hard_regs may be called outside of > ira-lives.c, it can't use the local variable, preferred_alternatives. > This patch adds an alternative_mask argument to > ira_implicitly_set_insn_hard_regs. > > OK for mast

RE: [PATCH] Obvious fix for PR66828: left shift with undefined behavior in bswap pass

2015-08-05 Thread Thomas Preud'homme
Hi, > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Thomas Preud'homme > Sent: Tuesday, July 28, 2015 3:04 PM > > > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > > ow...@gcc.gnu.org] On Behalf Of Thomas Preud'homme > > > > ChangeLog entry

2 C++ cleanup PATCHes

2015-08-05 Thread Jason Merrill
1) While working on 66260, it struck me as odd that finish_id_expression had its own code for determining whether an id-expression is dependent, rather than using type_dependent_expression_p. So this patch tears out a bunch of code and replaces it with a call; t_d_e_p already handled everythin

Re: [PR64164] drop copyrename, integrate into expand

2015-08-05 Thread Alexandre Oliva
On Aug 5, 2015, Richard Biener wrote: > It was just a hunch when you talked about BLKmode and params in memory. > As coalescing is about SSA name (thus register) coalescing I was thinking > that if you coalesce a register with incoming memory you'll end up with > more memory accesses? Since we

Re: Minor typo fixes

2015-08-05 Thread Abe
Thank you, sir. :-) Regards, Abe On 8/3/15 10:53 PM, Jeff Law wrote: I was starting to look at Abe's changes to the gimple if-converter and realized a handful of the changes were just fixing comments. No reason those shouldn't go in immediately. So I pulled them out and applied those

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

2015-08-05 Thread Segher Boessenkool
On Wed, Aug 05, 2015 at 03:59:18PM +0200, Richard Biener wrote: > >> Makes it quite unparsable to editors of course ... > > > > The idea of having .S files that aren't reasonably editable seems kind > > of silly, but I guess its up to the gas people. > > Heh, indeed. Maybe instead do > > .insert

Re: [Patch, fortran] Rename gfc_code's expr4 field

2015-08-05 Thread Steve Kargl
On Wed, Aug 05, 2015 at 10:53:29PM +0200, Mikael Morin wrote: > Le 05/08/2015 21:24, Steve Kargl a écrit : > > On Wed, Aug 05, 2015 at 08:54:21PM +0200, Mikael Morin wrote: > >> > >> +/* LOCK/UNLOCK statements */ > >> +struct > >> +{ > >> + gfc_expr *acquired_lock; > >> +} > >

Re: Elimitate duplication of get_catalogs in different abi

2015-08-05 Thread Jonathan Wakely
On 30/07/15 21:57 +0200, François Dumont wrote: It seems that this patch results in unresolved symbols. I am quite sure that the code is right but build system should be adapted. I noticed that *_cow.cc files are built with -fimplicit-templates. I try to apply the same with the old abi but I st

Re: [PATCH, libstdc++, testsuite] Remove redundant -save-temps options

2015-08-05 Thread Jonathan Wakely
On 04/08/15 20:09 +0300, Nikolai Bozhenov wrote: Hi, the attached patch removes redundant -save-temps options from some libstdc++ tests, since the option is not needed in dg-do-compile/scan-assembler tests. Thanks, committed.

Re: [Patch, fortran] Rename gfc_code's expr4 field

2015-08-05 Thread Mikael Morin
Le 05/08/2015 21:24, Steve Kargl a écrit : On Wed, Aug 05, 2015 at 08:54:21PM +0200, Mikael Morin wrote: +/* LOCK/UNLOCK statements */ +struct +{ + gfc_expr *acquired_lock; +} +lock; Just curious. Why add a struct with a single member? I would have thought s/expr4/a

[PATCH] PR rtl-optimization/67029: gcc-5.2.0 unable to find a register to spill with O3 fsched-pressure fschedule-insns]

2015-08-05 Thread H.J. Lu
- Forwarded message from "H.J. Lu" - Date: Wed, 5 Aug 2015 13:24:20 -0700 From: "H.J. Lu" To: g...@gcc.gnu.org Cc: Eric Botcazou , Steven Bosscher , Richard Sandiford Subject: [PATCH] PR rtl-optimization/67029: gcc-5.2.0 unable to find a register to spill with O3 fsched-

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

2015-08-05 Thread Trevor Saunders
On Wed, Aug 05, 2015 at 11:34:28AM -0400, David Malcolm wrote: > On Wed, 2015-08-05 at 11:28 -0400, David Malcolm wrote: > > On Wed, 2015-08-05 at 13:47 +0200, Richard Biener wrote: > > > On Wed, Aug 5, 2015 at 12:57 PM, Trevor Saunders > > > wrote: > > > > On Mon, Jul 27, 2015 at 11:06:58AM +020

Re: [Patch, fortran] Rename gfc_code's expr4 field

2015-08-05 Thread Steve Kargl
On Wed, Aug 05, 2015 at 08:54:21PM +0200, Mikael Morin wrote: > > this renames the expr4 field of gfc_code to the more descriptive > ext.lock.acquired_lock. > Regression tested on x86_64-unkown-linux-gnu. OK for trunk? > I don't have a problem with a name change. > +/* LOCK/UNLOCK stateme

[Patch, fortran] Rename gfc_code's expr4 field

2015-08-05 Thread Mikael Morin
Hello, this renames the expr4 field of gfc_code to the more descriptive ext.lock.acquired_lock. Regression tested on x86_64-unkown-linux-gnu. OK for trunk? Mikael 2015-08-05 Mikael Morin * gfortran.h (struct gfc_code): Move expr4 field to ext.lock.acquired_lock. *

Re: [PATCH] warn for unsafe calls to __builtin_return_address

2015-08-05 Thread Martin Sebor
On 08/05/2015 10:02 AM, Jiong Wang wrote: On 28/07/15 16:44, Martin Sebor wrote: Attached is an updated patch with the changes above. gcc/testsuite/ChangeLog 2015-07-28 Martin Sebor * g++.dg/Wframe-address-in-Wall.C: New test. * g++.dg/Wframe-address.C: New test. * g++.dg/W

C++ PATCH for c++/66260 (various variable template specialization issues)

2015-08-05 Thread Jason Merrill
The fundamental problem here was that I was setting the type of a variable TEMPLATE_ID_EXPR to unknown_type_node, which is not dependent, so places such as finish_id_expression that check dependent_type_p to determine whether an expression is type-dependent were getting the wrong answer. Fixi

C++ PATCH for c++/65195 (variable template of reference type)

2015-08-05 Thread Jason Merrill
We were missing a convert_from_reference. Tested x86_64-pc-linux-gnu, applying to trunk and 5. commit f1f2cd02b7e4549657cf6eeab1d7eae0466ac7a8 Author: Jason Merrill Date: Wed Aug 5 11:46:48 2015 -0400 PR c++/65195 PR c++/66619 * semantics.c (finish_id_expression): Call convert_

Re: Fix reload1.c warning for some targets

2015-08-05 Thread Richard Sandiford
Jeff Law writes: > On 08/05/2015 08:18 AM, Richard Sandiford wrote: >> Building some targets results in a warning about orig_dup[i] potentially >> being used uninitialised. I think the warning is fair, since it isn't >> obvious that the reog_data-based loop bound remains unchanged between: >> >>

Re: RFA: RL78: Fix multiply costs when optimizing for size

2015-08-05 Thread DJ Delorie
> OK to apply ? Ok. Thanks! > gcc/ChangeLog > 2015-08-05 Nick Clifton > > * config/rl78/rl78.c (rl78_rtx_costs): Treat MULT insns as cheap > if optimizing for size. > > Index: gcc/config/rl78/rl78.c > === > RCS f

Re: Fix reload1.c warning for some targets

2015-08-05 Thread Jeff Law
On 08/05/2015 08:18 AM, Richard Sandiford wrote: Building some targets results in a warning about orig_dup[i] potentially being used uninitialised. I think the warning is fair, since it isn't obvious that the reog_data-based loop bound remains unchanged between: for (i = 0; i < recog_data.n_

Re: [PATCH][AARCH64]Add backend combine_bfi pattern.

2015-08-05 Thread Renlin Li
Hi Kyrill, On 30/07/15 17:08, Kyrill Tkachov wrote: Hi Renlin, On 30/07/15 16:50, Renlin Li wrote: Hi all, This insn should match the following similar rtx pattern and remove the redundant zero_extend operation if the width of zero_extract and inner-size of zero_extend totally match. (set (z

Re: [PATCH] Optimize certain end of loop conditions into min/max operation

2015-08-05 Thread Jeff Law
On 08/05/2015 10:07 AM, Alan Lawrence wrote: Richard Biener wrote: Furthermore it doesn't work for three such ops which would require an additional pattern like (simplfiy (bit_and:c (op @0 (min @1 @2)) (op @0 @3)) (op @0 (min (min @1 @2) @3 if that's profitable? Shouldn't that be j

Re: [PATCH] Optimize certain end of loop conditions into min/max operation

2015-08-05 Thread Alan Lawrence
Richard Biener wrote: Furthermore it doesn't work for three such ops which would require an additional pattern like (simplfiy (bit_and:c (op @0 (min @1 @2)) (op @0 @3)) (op @0 (min (min @1 @2) @3 if that's profitable? Shouldn't that be just a case of binding @1 in the original patte

Re: Re: [PATCH] warn for unsafe calls to __builtin_return_address

2015-08-05 Thread Jiong Wang
On 28/07/15 16:44, Martin Sebor wrote: Attached is an updated patch with the changes above. gcc/testsuite/ChangeLog 2015-07-28 Martin Sebor * g++.dg/Wframe-address-in-Wall.C: New test. * g++.dg/Wframe-address.C: New test. * g++.dg/Wno-frame-address.C: New test. * gcc.dg/Wfr

[committed] Reduce size of insn_data

2015-08-05 Thread Richard Sandiford
At the moment insn_data contains entries for define_splits and define_peephole2s "only for reasons of consistency and to simplify genrecog". We don't need that any more and it just adds bloat. This patch instead uses separate counters for define_split and define_peephole2. It also removes a redun

RE: Regression in target MIC compiler

2015-08-05 Thread Thomas Schwinge
Hi! On Wed, 5 Aug 2015 15:10:40 +0100, David Sherwood wrote: > In lto_input_mode_table there is the following line of code: [...] Thanks! That's not exactly it, but you put me on the right track. Testing a patch. Grüße, Thomas pgpvL8b1BSU6F.pgp Description: PGP signature

[committed] Add a get_c_test helper function to gensupport

2015-08-05 Thread Richard Sandiford
Add a new function to return the C condition that must hold for an .md rtx to be valid. This is needed by the next patch but is a minor clean-up anyway. Bootstrapped and regression-tested on x86_64-linux-gnu. Thanks, Richard gcc/ * gensupport.h (get_c_test): Declare. * gensuppor

[committed] Add get_num_insn_codes to gensupport

2015-08-05 Thread Richard Sandiford
This patch adds a gensupport routine that generators can use to get the number of unique INSN_CODEs, rather than having to track it themselves. This is needed for a later patch that changes the way in which INSN_CODE is calculated. Bootstrapped and regression-tested on x86_64-linux-gnu. Thanks,

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

2015-08-05 Thread David Malcolm
On Wed, 2015-08-05 at 11:28 -0400, David Malcolm wrote: > On Wed, 2015-08-05 at 13:47 +0200, Richard Biener wrote: > > On Wed, Aug 5, 2015 at 12:57 PM, Trevor Saunders > > wrote: > > > On Mon, Jul 27, 2015 at 11:06:58AM +0200, Richard Biener wrote: > > >> On Sat, Jul 25, 2015 at 4:37 AM, wrote:

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

2015-08-05 Thread David Malcolm
On Wed, 2015-08-05 at 13:47 +0200, Richard Biener wrote: > On Wed, Aug 5, 2015 at 12:57 PM, Trevor Saunders > wrote: > > On Mon, Jul 27, 2015 at 11:06:58AM +0200, Richard Biener wrote: > >> On Sat, Jul 25, 2015 at 4:37 AM, wrote: > >> > From: Trevor Saunders > >> > > >> > * config/arc/

Re: [PATCH 1/3] tree-ssa-tail-merge: add IPA ICF infrastructure.

2015-08-05 Thread Martin Liška
On 08/03/2015 07:38 PM, Jeff Law wrote: > On 07/16/2015 05:03 AM, Martin Liška wrote: >>> So a general question. We're passing in STRICT to several routines, which >>> is fine. But then we're also checking M_TAIL_MERGE_MODE. What's the >>> difference between the two? Can they be unified? >> >

Re: [PATCH 2/n] OpenMP 4.0 offloading infrastructure: LTO streaming

2015-08-05 Thread Ilya Verbin
On Wed, Aug 05, 2015 at 10:40:44 +0200, Richard Biener wrote: > On Fri, Jul 31, 2015 at 4:20 PM, Ilya Verbin wrote: > > On Fri, Jul 31, 2015 at 16:08:27 +0200, Thomas Schwinge wrote: > >> We had established the use of a boolean flag have_offload in gcc::context > >> to indicate whether during comp

Re: [PATCH][AArch64][12/14] Target attributes and target pragmas tests

2015-08-05 Thread James Greenhalgh
On Mon, Aug 03, 2015 at 12:32:15PM +0100, James Greenhalgh wrote: > On Fri, Jul 24, 2015 at 09:40:28AM +0100, Kyrill Tkachov wrote: > > > > On 21/07/15 18:14, James Greenhalgh wrote: > > > On Thu, Jul 16, 2015 at 04:21:15PM +0100, Kyrill Tkachov wrote: > > >> Hi all, > > >> > > >> These are the te

Re: [PATCH][AArch64][12/14] Target attributes and target pragmas tests

2015-08-05 Thread Kyrill Tkachov
On 05/08/15 15:27, Andreas Schwab wrote: Kyrill Tkachov writes: On 05/08/15 10:03, Andreas Schwab wrote: Kyrill Tkachov writes: diff --git a/gcc/testsuite/gcc.target/aarch64/target_attr_1.c b/gcc/testsuite/gcc.target/aarch64/target_attr_1.c new file mode 100644 index 000..72d0838 ---

Re: [PATCH] Add X != !X pattern

2015-08-05 Thread James Greenhalgh
On Wed, Aug 05, 2015 at 02:56:08PM +0100, Richard Biener wrote: > For reference see below (testing on aarch64 appreciated). Looks good to me on aarch64-none-elf. Thanks, James > Bootstrap & regtest running on x86_64-unknown-linux-gnu. > > Richard. > > 2015-08-05 Richard Biener > > *

Re: [PATCH] Add X != !X pattern

2015-08-05 Thread Andreas Schwab
Richard Biener writes: > For reference see below (testing on aarch64 appreciated). > > Bootstrap & regtest running on x86_64-unknown-linux-gnu. > > Richard. > > 2015-08-05 Richard Biener > > * gimple-fold.c (gimple_fold_stmt_to_constant_1): Simplify > bool comparison canonicalizati

Re: [PATCH][AArch64][12/14] Target attributes and target pragmas tests

2015-08-05 Thread Andreas Schwab
Kyrill Tkachov writes: > On 05/08/15 10:03, Andreas Schwab wrote: >> Kyrill Tkachov writes: >> >>> diff --git a/gcc/testsuite/gcc.target/aarch64/target_attr_1.c >>> b/gcc/testsuite/gcc.target/aarch64/target_attr_1.c >>> new file mode 100644 >>> index 000..72d0838 >>> --- /dev/null >>> +++ b

Fix reload1.c warning for some targets

2015-08-05 Thread Richard Sandiford
Building some targets results in a warning about orig_dup[i] potentially being used uninitialised. I think the warning is fair, since it isn't obvious that the reog_data-based loop bound remains unchanged between: for (i = 0; i < recog_data.n_dups; i++) orig_dup[i] = *recog_data.dup_loc[i];

Remove bogus can_extend

2015-08-05 Thread Richard Sandiford
Richard Henderson writes: > On 07/28/2015 01:36 PM, Richard Sandiford wrote: > > Index: gcc/target-insns.def > > === > > --- gcc/target-insns.def2015-07-28 20:56:29.721512028 +0100 > > +++ gcc/target-insns.def2015-07-28 20:56:

Re: PR66311: Fix extension in mpz->wide_int conversions

2015-08-05 Thread Richard Biener
On Wed, Aug 5, 2015 at 4:14 PM, Richard Sandiford wrote: > wi::from_mpz reads the absolute value of the mpz and then negates the > result if the mpz is negative. When the top bit of the most-significant > HOST_WIDE_INT in the absolute value is set, we implicitly sign- > rather than zero-extend it

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

2015-08-05 Thread Richard Biener
On Wed, Aug 5, 2015 at 3:36 PM, Trevor Saunders wrote: > On Wed, Aug 05, 2015 at 01:47:30PM +0200, Richard Biener wrote: >> On Wed, Aug 5, 2015 at 12:57 PM, Trevor Saunders >> wrote: >> > On Mon, Jul 27, 2015 at 11:06:58AM +0200, Richard Biener wrote: >> >> On Sat, Jul 25, 2015 at 4:37 AM, wro

PR66311: Fix extension in mpz->wide_int conversions

2015-08-05 Thread Richard Sandiford
wi::from_mpz reads the absolute value of the mpz and then negates the result if the mpz is negative. When the top bit of the most-significant HOST_WIDE_INT in the absolute value is set, we implicitly sign- rather than zero-extend it to full precision. For example, 1 << 63 gets mangled to (1 << pr

RE: Regression in target MIC compiler

2015-08-05 Thread David Sherwood
Hi Thomas, In lto_input_mode_table there is the following line of code: machine_mode inner = (machine_mode) table[bp_unpack_value (&bp, 8)]; Is this right? In lto_write_mode_table this inner mode is written out explicitly into the stream already, so do we just need this instead? machine_mode in

Re: RFA: RL78: Remove far operand optimization in rl78_force_nonfar_3

2015-08-05 Thread Nick Clifton
Hi DJ, This is OK, but note that it prevents some operations like: __far int i; foo() { i ++; } from being implemented with a minimum set of opcodes. This might be particularly troublesome for volatile far things. Right - it is something I will have to look into. Cheers Nick

Re: [PATCH] Add X != !X pattern

2015-08-05 Thread Richard Biener
; > > > >> > > > > > >> > * gimple-fold.c (gimple_fold_stmt_to_constant_1): > > > > > >> > Canonicalize > > > > > >> > bool compares on RHS. > > > > > >> > * match.pd: Add

RFA: RL78: Fix multiply costs when optimizing for size

2015-08-05 Thread Nick Clifton
Hi DJ, The patch below fixes a small problem with the RL78 backend. When optimizing for size it is better to use a slow multiply instruction than a faster, but larger, shift sequence. So the patch tweaks the rtx costs for MULT insns when speed is not a priority. Tested with no regress

Re: [PATCH] Add X != !X pattern

2015-08-05 Thread James Greenhalgh
imple_fold_stmt_to_constant_1): Canonicalize > > > > >> > bool compares on RHS. > > > > >> > * match.pd: Add X ==/!= !X is false/true pattern. > > > > >> > > > > >> ERROR in VTST/VTSTQ > > > > >> (/opt/

Re: [gofrontend-dev] Re: libgo patch committed: Kill sleep processes in testsuite

2015-08-05 Thread Ian Lance Taylor
[ + Andrew Wilkins ] On Wed, Aug 5, 2015 at 1:58 AM, Andreas Schwab wrote: > PASS > kill: not enough arguments > FAIL: net > Makefile:4696: recipe for target 'net/check' failed > make[4]: *** [net/check] Error 1 > > $ cat net/check-testlog > PASS > kill: not enough arguments > FAIL: net > ../../.

Re: [PATCH] Add X != !X pattern

2015-08-05 Thread Richard Biener
ld_stmt_to_constant_1): Canonicalize > > > > >> > bool compares on RHS. > > > > >> > * match.pd: Add X ==/!= !X is false/true pattern. > > > > >> > > > > >> ERROR in VTST/VTSTQ > > > > >> (/opt/gcc/gcc-20150805/g

Re: [libquadmath, patch] Add logbq() to libquadmath

2015-08-05 Thread Dominique d'Humières
> Le 5 août 2015 à 15:11, FX a écrit : > >> AFAICT there is something missing in the patch: I do not see any compilation >> of math/logbq.c and indeed no trace of logbq in libquadmath. What I am >> missing? > > Maybe you didn’t regenerate the Makefile.in? Indeed I did not!-(I have never succ

Re: [PATCH] Add X != !X pattern

2015-08-05 Thread Richard Biener
hwab wrote: > > > > > > > >> Richard Biener writes: > > > >> > > > >> > * gimple-fold.c (gimple_fold_stmt_to_constant_1): Canonicalize > > > >> > bool compares on RHS. > > > >> > * match.pd: A

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

2015-08-05 Thread Trevor Saunders
On Wed, Aug 05, 2015 at 01:47:30PM +0200, Richard Biener wrote: > On Wed, Aug 5, 2015 at 12:57 PM, Trevor Saunders > wrote: > > On Mon, Jul 27, 2015 at 11:06:58AM +0200, Richard Biener wrote: > >> On Sat, Jul 25, 2015 at 4:37 AM, wrote: > >> > From: Trevor Saunders > >> > > >> > * conf

Re: [PATCH] Add X != !X pattern

2015-08-05 Thread James Greenhalgh
rites: > > >> > > >> > * gimple-fold.c (gimple_fold_stmt_to_constant_1): Canonicalize > > >> > bool compares on RHS. > > >> > * match.pd: Add X ==/!= !X is false/true pattern. > > >> > > >> ERROR in VTS

[PATCH] Cleanup gimple.h accesses to ops array

2015-08-05 Thread Richard Biener
This cleans up the acceses to ops arrays in gimple accessors that already take a code-specific class as argument. There is no need to go through the indirection of gimple_ops () computing the offset of the ops array at runtime. For all cases there is also already index checking in place in the a

Re: [libquadmath, patch] Add logbq() to libquadmath

2015-08-05 Thread FX
> AFAICT there is something missing in the patch: I do not see any compilation > of math/logbq.c and indeed no trace of logbq in libquadmath. What I am > missing? Maybe you didn’t regenerate the Makefile.in? The patch was sent without this regenerated file, as is (as I understand) the custom on

[PATCH] Fix PR67120

2015-08-05 Thread Richard Biener
The following fixes comparing of &i and &i if i is volatile. We were using operand_equal_p to compare i with i which of course results in a false negative. The following restricts us to the interesting cases (SSA names and decls) and then simply use ==. Bootstrapped on x86_64-unknown-linux-gnu,

[PATCH] Fix PR67121

2015-08-05 Thread Richard Biener
Similar to if-combine if-conversion invalidates range info on stmts that are executed unconditionally only after the transform. Thus we have to invalidate it. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2015-08-05 Richard Biener PR tree-optimization/6712

Re: [Bug fortran/52846] [F2008] Support submodules - part 3/3

2015-08-05 Thread Paul Richard Thomas
Dear All, I had some unexpected regressions, which turned out to be associated with mulling over FX's problem with intrinsic IEEE modules. Sendinggcc/fortran/ChangeLog Sendinggcc/fortran/module.c Sendinggcc/fortran/trans-decl.c Sendinggcc/testsuite/ChangeLog Sendin

Re: [PATCH][AArch64] elf toolchain does not pass -shared linker option

2015-08-05 Thread Christophe Lyon
On 24 July 2015 at 18:18, Szabolcs Nagy wrote: > On 24/07/15 14:20, Marcus Shawcroft wrote: >> On 22 July 2015 at 18:22, Szabolcs Nagy wrote: >> >>> 2015-07-22 Szabolcs Nagy >>> >>> * config/aarch64/aarch64-elf-raw.h (LINK_SPEC): Handle -h, -static, >>> -shared, -symbolic, -rdy

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

2015-08-05 Thread Richard Biener
On Wed, Aug 5, 2015 at 12:57 PM, Trevor Saunders wrote: > On Mon, Jul 27, 2015 at 11:06:58AM +0200, Richard Biener wrote: >> On Sat, Jul 25, 2015 at 4:37 AM, wrote: >> > From: Trevor Saunders >> > >> > * config/arc/arc.h, config/bfin/bfin.h, config/frv/frv.h, >> > config/ia64/ia

Re: [libquadmath, patch] Add logbq() to libquadmath

2015-08-05 Thread Dominique d'Humières
> The attached patch adds logbq() to libquadmath, with code lifted from glibc. AFAICT there is something missing in the patch: I do not see any compilation of math/logbq.c and indeed no trace of logbq in libquadmath. What I am missing? TIA Dominique

Re: [fortran,patch] Extend IEEE support to all real kinds

2015-08-05 Thread FX
> FAIL: gfortran.dg/ieee/large_1.f90 -O0 (test for excess errors) > Excess errors: > large_1.f90:(.text+0x1792): undefined reference to `logbq’ Fixed by the patch there: https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00124.html Waiting for review. FX

Re: [RFC] [Patch]: Try and vectorize with shift for mult expr with power 2 integer constant.

2015-08-05 Thread Richard Biener
On Tue, Aug 4, 2015 at 6:49 PM, Kumar, Venkataramanan wrote: > Hi Richard, > > >> -Original Message- >> From: Richard Biener [mailto:richard.guent...@gmail.com] >> Sent: Tuesday, August 04, 2015 4:07 PM >> To: Kumar, Venkataramanan >> Cc: Jeff Law; Jakub Jelinek; gcc-patches@gcc.gnu.org >>

Re: PR middle-end/16351 NULL dereference warnings

2015-08-05 Thread Richard Biener
On Mon, 3 Aug 2015, Manuel López-Ibáñez wrote: > PING: https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01860.html > > Actually, the xfailed test was because the function folded to nothing > and the offending code was removed without warning. Fixed in the > attached version. Same changelog. Ok. Th

Re: [committed, gomp4] Fix release_dangling_ssa_names

2015-08-05 Thread Richard Biener
On Wed, 5 Aug 2015, Tom de Vries wrote: > On 05/08/15 11:30, Richard Biener wrote: > > On Wed, 5 Aug 2015, Tom de Vries wrote: > > > > > On 05/08/15 09:29, Richard Biener wrote: > > > > > This patch fixes that by making sure we reset the def stmt to NULL. > > > > > This > > > > > means > > > > >

Re: [PATCH] Add X != !X pattern

2015-08-05 Thread Richard Biener
Canonicalize > >> > bool compares on RHS. > >> > * match.pd: Add X ==/!= !X is false/true pattern. > >> > >> ERROR in VTST/VTSTQ > >> (/opt/gcc/gcc-20150805/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c > >> line 97 in buffe

Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function

2015-08-05 Thread Trevor Saunders
On Mon, Jul 27, 2015 at 11:06:58AM +0200, Richard Biener wrote: > On Sat, Jul 25, 2015 at 4:37 AM, wrote: > > From: Trevor Saunders > > > > * config/arc/arc.h, config/bfin/bfin.h, config/frv/frv.h, > > config/ia64/ia64-protos.h, config/ia64/ia64.c, config/ia64/ia64.h, > >

Re: [committed, gomp4] Fix release_dangling_ssa_names

2015-08-05 Thread Tom de Vries
On 05/08/15 11:30, Richard Biener wrote: On Wed, 5 Aug 2015, Tom de Vries wrote: On 05/08/15 09:29, Richard Biener wrote: This patch fixes that by making sure we reset the def stmt to NULL. This means we can simplify release_dangling_ssa_names to just test for NULL def stmts. Not sure if I

RE: Regression in target MIC compiler

2015-08-05 Thread Thomas Schwinge
Hi! On Wed, 5 Aug 2015 11:18:32 +0100, David Sherwood wrote: > If this looks like my fault Well, not necessarily your fault -- might as well just be something that has already been lurking in gcc/lto-streamer-in.c:lto_input_mode_table, but so far we've gotten away without tripping over it. > I

Re: [PATCH] Add X != !X pattern

2015-08-05 Thread Andrew Pinski
atch.pd: Add X ==/!= !X is false/true pattern. >> >> ERROR in VTST/VTSTQ >> (/opt/gcc/gcc-20150805/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c >> line 97 in buffer 'expected_signed') at type uint8x8 index 1: got 0x1 != >> 0xff (signed input

RE: Regression in target MIC compiler

2015-08-05 Thread David Sherwood
Hi Thomas, If this looks like my fault I am happy to look into this and fix the bug if you can tell me how to reproduce it. I recently changed GET_MODE_INNER (m) to return 'm' itself if there is no inner mode and I thought I'd fixed up lto, but it seems I got it wrong. It also sounds like there is

Re: [PATCH] Add X != !X pattern

2015-08-05 Thread Richard Biener
On Wed, 5 Aug 2015, Andreas Schwab wrote: > Richard Biener writes: > > > * gimple-fold.c (gimple_fold_stmt_to_constant_1): Canonicalize > > bool compares on RHS. > > * match.pd: Add X ==/!= !X is false/true pattern. > > ERROR in VTST/VTSTQ > (/o

Re: [PATCH][AArch64][12/14] Target attributes and target pragmas tests

2015-08-05 Thread Kyrill Tkachov
On 05/08/15 10:03, Andreas Schwab wrote: Kyrill Tkachov writes: diff --git a/gcc/testsuite/gcc.target/aarch64/target_attr_1.c b/gcc/testsuite/gcc.target/aarch64/target_attr_1.c new file mode 100644 index 000..72d0838 --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/target_attr_1.c @@

Re: [PATCH] Add X != !X pattern

2015-08-05 Thread Andreas Schwab
Richard Biener writes: > * gimple-fold.c (gimple_fold_stmt_to_constant_1): Canonicalize > bool compares on RHS. > * match.pd: Add X ==/!= !X is false/true pattern. ERROR in VTST/VTSTQ (/opt/gcc/gcc-20150805/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vtst.c

[PATCH] Fix PR67055

2015-08-05 Thread Richard Biener
The inliner decides sth stupid here (IMHO - inlining a function into a thunk) but at least we shouldn't crash (the tailcall in the thunk has no BLOCK associated with it). Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-08-05 Richard Biener PR tree-optimiz

RE: [RFC] [Patch]: Try and vectorize with shift for mult expr with power 2 integer constant.

2015-08-05 Thread Kumar, Venkataramanan
Hi Richard, > -Original Message- > From: Richard Biener [mailto:richard.guent...@gmail.com] > Sent: Wednesday, August 05, 2015 2:21 PM > To: Kumar, Venkataramanan > Cc: Jeff Law; Jakub Jelinek; gcc-patches@gcc.gnu.org > Subject: Re: [RFC] [Patch]: Try and vectorize with shift for mult expr

Re: Regression in target MIC compiler

2015-08-05 Thread Thomas Schwinge
Hi! It seems as if David's »[PATCH][1/N] Change GET_MODE_INNER to always return a non-void mode« is relevant here: On Tue, 4 Aug 2015 16:06:23 +0300, Ilya Verbin wrote: > On Tue, Aug 04, 2015 at 14:35:11 +0200, Thomas Schwinge wrote: > > On Fri, 31 Jul 2015 20:13:02 +0300, Ilya Verbin wrote: >

Re: [committed, gomp4] Fix release_dangling_ssa_names

2015-08-05 Thread Richard Biener
On Wed, 5 Aug 2015, Tom de Vries wrote: > On 05/08/15 09:29, Richard Biener wrote: > > > This patch fixes that by making sure we reset the def stmt to NULL. This > > > means > > > >we can simplify release_dangling_ssa_names to just test for NULL def > > > stmts. > > Not sure if I understand the pr

Re: [PR64164] drop copyrename, integrate into expand

2015-08-05 Thread Richard Biener
On Wed, Aug 5, 2015 at 2:38 AM, Alexandre Oliva wrote: > On Aug 4, 2015, Richard Biener wrote: > >> Though I wonder on whether splitting the patch into a first one with >> disabling >> coalescing of parms (their default defs(?)) and a followup implementing the >> support for that. > > We can't

Re: [RFC] Elimination of zext/sext - type promotion pass

2015-08-05 Thread Richard Biener
On Wed, Aug 5, 2015 at 2:12 AM, kugan wrote: > >> You indeed need to use CONVERT_EXPR here, maybe you can elaborate >> on the optimization issues. >> >>> 2. for inline asm (a reduced test case that might not make much as a >>> stand alone test-case, but I ran into similar cases with valid >>> prog

Re: [PATCH][AArch64][12/14] Target attributes and target pragmas tests

2015-08-05 Thread Andreas Schwab
Kyrill Tkachov writes: > diff --git a/gcc/testsuite/gcc.target/aarch64/target_attr_1.c > b/gcc/testsuite/gcc.target/aarch64/target_attr_1.c > new file mode 100644 > index 000..72d0838 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/aarch64/target_attr_1.c > @@ -0,0 +1,12 @@ > +/* { dg-do as

Re: libgo patch committed: Kill sleep processes in testsuite

2015-08-05 Thread Andreas Schwab
PASS kill: not enough arguments FAIL: net Makefile:4696: recipe for target 'net/check' failed make[4]: *** [net/check] Error 1 $ cat net/check-testlog PASS kill: not enough arguments FAIL: net ../../../libgo/testsuite/gotest: line 514: gotest-timeout: No such file or directory Andreas. -- Andr

Re: [RFC] [Patch]: Try and vectorize with shift for mult expr with power 2 integer constant.

2015-08-05 Thread Richard Biener
On Tue, Aug 4, 2015 at 6:49 PM, Kumar, Venkataramanan wrote: > Hi Richard, > > >> -Original Message- >> From: Richard Biener [mailto:richard.guent...@gmail.com] >> Sent: Tuesday, August 04, 2015 4:07 PM >> To: Kumar, Venkataramanan >> Cc: Jeff Law; Jakub Jelinek; gcc-patches@gcc.gnu.org >>

Re: [committed, gomp4] Fix release_dangling_ssa_names

2015-08-05 Thread Tom de Vries
On 05/08/15 09:29, Richard Biener wrote: This patch fixes that by making sure we reset the def stmt to NULL. This means >we can simplify release_dangling_ssa_names to just test for NULL def stmts. Not sure if I understand the problem correctly but why are you not simply releasing the SSA name wh

Re: [PATCH 2/n] OpenMP 4.0 offloading infrastructure: LTO streaming

2015-08-05 Thread Richard Biener
On Fri, Jul 31, 2015 at 4:20 PM, Ilya Verbin wrote: > On Fri, Jul 31, 2015 at 16:08:27 +0200, Thomas Schwinge wrote: >> We had established the use of a boolean flag have_offload in gcc::context >> to indicate whether during compilation, we've actually seen any code to >> be offloaded (see cited be

[PATCH, MIPS] Remove W32 and W64 pseudo-processors

2015-08-05 Thread Robert Suchanek
Hi, Since the I6400 scheduler is committed, W32/W64 pseudo-processors are not needed anymore and can be removed. Ok to commit? Regards, Robert gcc/ * config/mips/mips.c (mips_rtx_cost_data): Remove costs for W32 and W64 pseudo-processors. * config/mips/mips.md (processor

[PATCH, MIPS] Enable load/store bonding for I6400

2015-08-05 Thread Robert Suchanek
Hi, Following up https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01730.html The patch below enables the load-load/store-store bonding for MIPS32/MIPS64 R6. Ok to apply? Regards, Robert gcc/ * config/mips/mips.h (ENABLE_LD_ST_PAIRS): Enable load/store pairs for I6400. --- gcc/co

Re: [PATCH, i386] Disable AVX-512VL insns for scalar mode operands on -march=knl.

2015-08-05 Thread Kirill Yukhin
Hello, Is it ok to backport the patch to gcc-5-branch? -- Thanks, K > On 04 Aug 15:31, Kirill Yukhin wrote: > > commit 1055739cb51648794a01afd85f59efadd14378ed > Author: Kirill Yukhin > Date: Mon Aug 3 15:21:06 2015 +0300 > > Fix vec_concatv2df and vec_dupv2df to block wrongly enabled A

[PATCH] Fix PR67109

2015-08-05 Thread Richard Biener
The following fixes invalid group detection in the vectorizer where the size doesn't fit an unsigned int. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-08-05 Richard Biener PR tree-optimization/67109 * tree-vect-data-refs.c (vect_analyze_group_a

Re: [fortran,patch] Extend IEEE support to all real kinds

2015-08-05 Thread Andreas Schwab
FAIL: gfortran.dg/ieee/large_1.f90 -O0 (test for excess errors) Excess errors: large_1.f90:(.text+0x1792): undefined reference to `logbq' Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something compl

Re: r226516 - in /trunk/gcc: ChangeLog testsuite/Ch...

2015-08-05 Thread Andreas Schwab
FAIL: gcc.dg/pr66314.c (test for excess errors) Excess errors: /usr/local/gcc/gcc-20150805/gcc/testsuite/gcc.dg/pr66314.c:1:0: warning: -fsanitize=address and -fsanitize=kernel-address are not supported for this target Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint

[PATCH] Fix PR67107

2015-08-05 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-08-05 Richard Biener PR middle-end/67107 * match.pd: Guard const_binop result checking against NULL_TREE result. * gcc.dg/pr67107.c: New testcase. Index: gcc/match.pd

Re: [committed, gomp4] Fix release_dangling_ssa_names

2015-08-05 Thread Richard Biener
On Wed, 5 Aug 2015, Tom de Vries wrote: > [ was: Re: Expand oacc kernels after pass_fre ] > On 04/06/15 18:02, Tom de Vries wrote: > > > Please move this out of the class body. > > > > > > > Fixed and committed (ommitting patch as trivial). > > > > > > +{ > > > > + unsigned res = execu

Re: [PATCH] warn for unsafe calls to __builtin_return_address

2015-08-05 Thread Andreas Schwab
> * gcc.dg/Wframe-address.c: New test. > * gcc.dg/Wno-frame-address.c: New test. FAIL: g++.dg/Wno-frame-address.C -std=gnu++11 (test for excess errors) Excess errors: /usr/local/gcc/gcc-20150805/gcc/testsuite/g++.dg/Wframe-address.C:42:30: error: unsupported argument to 'void* __bui

[committed, gomp4] Fix release_dangling_ssa_names

2015-08-05 Thread Tom de Vries
[ was: Re: Expand oacc kernels after pass_fre ] On 04/06/15 18:02, Tom de Vries wrote: Please move this out of the class body. Fixed and committed (ommitting patch as trivial). +{ + unsigned res = execute_expand_omp (); + + /* After running pass_expand_omp_ssa to expand the oac