Re: [PR25529] Convert (unsigned t * 2)/2 into unsigned (t & 0x7FFFFFFF)

2015-07-06 Thread Marc Glisse
On Tue, 7 Jul 2015, Hurugalawadi, Naveen wrote: Please find attached the patch "PR25529.patch" that converts the pattern:- (unsigned * 2)/2 is into unsigned &0x7FFF +/* Simplify (unsigned t * 2)/2 -> unsigned t & 0x7FFF. */ +(for div (trunc_div ceil_div floor_div round_div exact_div)

Re: [PR23664] Fold (a & C1) + (b & C2) to (a & C1) | (b & C2) iff (C1 & C2) == 0

2015-07-06 Thread Marc Glisse
On Tue, 7 Jul 2015, Hurugalawadi, Naveen wrote: Please find attached the patch "PR23664.patch" that converts the pattern:- (a & C1) + (b & C2) into (a & C1) | (b & C2) iff (C1 & C2) == 0. We already have the following. I believe it would be better to merge them (use a 'for'). (simplify (bi

Re: move a * (1 << b) -> a << b pattern from fold-const.c to match.pd

2015-07-06 Thread Marc Glisse
On Tue, 7 Jul 2015, Prathamesh Kulkarni wrote: +/* a * (1 << b) -> a << b */ +(simplify + (mult:c @a (lshift integer_onep @b)) + (if (!FLOAT_TYPE_P (type)) +(lshift @a @b))) The test FLOAT_TYPE_P seems unnecessary, 'type' is (up to a useless conversion) the result of a shift, so integer

[PR25530] Convert (unsigned t / 2) * 2 into (unsigned t & ~1)

2015-07-06 Thread Hurugalawadi, Naveen
Hi, Please find attached the patch PR25530.patch that converts the pattern:- (unsigned / 2) * 2 is into (unsigned & ~1). Please review and let me know if its okay. Regression tested on AARH64 and x86_64. Thanks, Naveen gcc/testsuite/ChangeLog: 2015-07-07 Naveen H.S PR middle-end/2

[PR25529] Convert (unsigned t * 2)/2 into unsigned (t & 0x7FFFFFFF)

2015-07-06 Thread Hurugalawadi, Naveen
Hi, Please find attached the patch "PR25529.patch" that converts the pattern:- (unsigned * 2)/2 is into unsigned &0x7FFF Please review and let me know if its okay. Regression tested on AARH64 and x86_64. Thanks, Naveen gcc/testsuite/ChangeLog: 2015-07-07 Naveen H.S PR middle-e

[PR23664] Fold (a & C1) + (b & C2) to (a & C1) | (b & C2) iff (C1 & C2) == 0

2015-07-06 Thread Hurugalawadi, Naveen
Hi, Please find attached the patch "PR23664.patch" that converts the pattern:- (a & C1) + (b & C2) into (a & C1) | (b & C2) iff (C1 & C2) == 0. Please review and let me know if its okay. Regression tested on AARH64 and x86_64. Thanks, Naveen gcc/testsuite/ChangeLog: 2015-07-07 Naveen H.S

[PING 3] Re: [PATCH] warn for unsafe calls to __builtin_return_address

2015-07-06 Thread Martin Sebor
This is a small change to diagnose unsafe calls to __builtin_{frame,return}_address (with an argument > 2) than tend to return bogus values or lead to crashes at runtime. A review would be appreciated. Thanks Martin On 06/26/2015 05:49 PM, Martin Sebor wrote: Is this patch okay for trunk? On

RE: [Patch,microblaze]: Optimized usage of reserved stack space for function arguments.

2015-07-06 Thread Ajit Kumar Agarwal
-Original Message- From: Oleg Endo [mailto:oleg.e...@t-online.de] Sent: Monday, July 06, 2015 7:07 PM To: Ajit Kumar Agarwal Cc: GCC Patches; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mekala Subject: Re: [Patch,microblaze]: Optimized usage of reserved stack space

Re: fix segfault in verify_flow_info() with -dx option

2015-07-06 Thread Prathamesh Kulkarni
On 6 July 2015 at 12:00, Richard Biener wrote: > On Sun, Jul 5, 2015 at 2:07 PM, Prathamesh Kulkarni > wrote: >> Hi, >> Passing -dx causes segmentation fault: >> Test case: void f(void) {} >> >> ./test.c: In function 'f': >> ../test.c:3:1: internal compiler error: Segmentation fault >> } >> ^ >

Re: [PATCH 4/7] Fix int overflow

2015-07-06 Thread Mikhail Maltsev
On 07.07.2015 1:55, Jeff Law wrote: >> len = d_number (di); >> - if (len <= 0) >> + if (len <= 0 || len > INT_MAX) >> return NULL; >> ret = d_identifier (di, len); >> di->last_name = ret; > Isn't this only helpful if sizeof (long) > sizeof (int)? Otherwise the > compiler is go

RE: [PATCH] MIPS: fix failing branch range checks for micromips

2015-07-06 Thread Moore, Catherine
Hi Andrew, > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Andrew Bennett > Sent: Friday, July 03, 2015 7:50 PM > Subject: [PATCH] MIPS: fix failing branch range checks for micromips > > diff --git a/gcc/testsuite/gcc.targe

Re: [PATCH 5/7] Fix braced-init-list demangling

2015-07-06 Thread Jeff Law
On 07/06/2015 01:37 PM, Mikhail Maltsev wrote: --- libiberty/cp-demangle.c | 2 ++ libiberty/testsuite/demangle-expected | 4 2 files changed, 6 insertions(+) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index befa6b6..424b1c5 100644 --- a/libiberty/cp-de

Re: [PATCH 4/7] Fix int overflow

2015-07-06 Thread Jeff Law
On 07/06/2015 01:36 PM, Mikhail Maltsev wrote: --- libiberty/cp-demangle.c | 3 ++- libiberty/testsuite/demangle-expected | 4 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 44a0a9b..befa6b6 100644 --- a

Re: [PATCH 1/7] Add CHECK_DEMANGLER

2015-07-06 Thread Jeff Law
On 07/06/2015 01:31 PM, Mikhail Maltsev wrote: --- libiberty/cp-demangle.h | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/libiberty/cp-demangle.h b/libiberty/cp-demangle.h index 6fce025..c37a91f 100644 --- a/libiberty/cp-demangle.h +++ b/

Re: [PATCH] rtx_costs vs. const_int

2015-07-06 Thread Jeff Law
On 06/14/2015 08:33 PM, Alan Modra wrote: This patch changes the targetm.rtx_costs interface to pass a mode parameter, and removes a redundant parameter. The reason for the change is that powerpc and other backends need the mode that a const_int is used in to properly determine the cost. For in

Re: [PATCH 2/7] Fix build with CP_DEMANGLE_DEBUG

2015-07-06 Thread Jeff Law
On 07/06/2015 01:33 PM, Mikhail Maltsev wrote: --- libiberty/cp-demangle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 2988b6b..12093cc 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-demangle.c @@ -715,7 +

C++ PATCH to argument_pack_element_is_expansion_p

2015-07-06 Thread Jason Merrill
In tsubst_pack_expansion, when we don't have fully instantiated arguments we try to do a partial instantiation of the pattern if all the arguments we have are of similar form, for instance if all of them are pack expansions. In one case with concepts we were failing to do that and falling back

C++ PATCH to template template parm partial instantiation

2015-07-06 Thread Jason Merrill
The concepts work ran into a bug whereby the TEMPLATE_PARM_DECL of a TEMPLATE_TEMPLATE_PARM was missing its DECL_TEMPLATE_RESULT. Looking into this more, I see that when instantiating a template template parameter we end up with two TEMPLATE_DECLs: the main one and another in the TEMPLATE_PARM

Re: [PATCH] config/bfin/bfin.c (hwloop_optimize): Use return false instead of gcc_assert for checking jump_insn.

2015-07-06 Thread Chen Gang
On 7/6/15 20:51, Bernd Schmidt wrote: > On 07/03/2015 04:13 AM, Chen Gang wrote: >> On 07/01/2015 11:27 PM, Chen Gang wrote: >>> On 7/1/15 21:52, Bernd Schmidt wrote: Below is a patch. Can you test this with anything you have beyond the testsuite? >>> >>> It can fix this issue (Bug6

Re: fix segfault in verify_flow_info() with -dx option

2015-07-06 Thread Jeff Law
On 07/05/2015 06:07 AM, Prathamesh Kulkarni wrote: Hi, Passing -dx causes segmentation fault: Test case: void f(void) {} ./test.c: In function 'f': ../test.c:3:1: internal compiler error: Segmentation fault } ^ 0xab6baf crash_signal /home/prathamesh.kulkarni/gnu-toolchain/src/gcc.gi

Re: [PR66726] Factor conversion out of COND_EXPR

2015-07-06 Thread Jeff Law
On 07/04/2015 06:32 AM, Kugan wrote: p.txt diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr66726.c b/gcc/testsuite/gcc.dg/tree-ssa/pr66726.c index e69de29..93f1ace 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/pr66726.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr66726.c @@ -0,0 +1,13 @@ + +/* { dg-do c

[PATCH, i386]: Use insv

2015-07-06 Thread Uros Bizjak
Hello! Similar to my previous patch, attached patch renames obsolete insv to insv. 2015-07-06 Uros Bizjak * config/i386/i386.md (insv): Rename from insv. Use SWI48 modes for operands 0 and 3. Use SImode for operands 2 and 3. Copy operand 0 to a temporary if !ext_register_operand

Re: [PATCH 1/2] Allow REG_EQUAL for ZERO_EXTRACT

2015-07-06 Thread Jeff Law
On 07/05/2015 05:16 PM, Kugan wrote: diff --git a/gcc/ChangeLog b/gcc/ChangeLog index fc23abd..5796f16 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ + +2015-06-26 Kugan Vivekanandarajah + + * cse.c (cse_insn): Calculate src_eqv for ZERO_EXTRACT. + * emit-rtl.c (set

Re: [Ada] Add DragonFly support to System.OS_Constants template

2015-07-06 Thread Eric Botcazou
> Please consider incorporating the patch into trunk. Applied with ChangeLog sent privately. -- Eric Botcazou

Re: move a * (1 << b) -> a << b pattern from fold-const.c to match.pd

2015-07-06 Thread Jeff Law
On 07/06/2015 02:28 PM, Prathamesh Kulkarni wrote: Hi, The attached patch moves pattern a * (1 << b) -> a << b. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. OK for trunk if testing passes ? Thank you, Prathamesh ChangeLog.txt 2015-07-06 Prathamesh Kulkarni * fold-

Fix some ptx breakage

2015-07-06 Thread Nathan Sidwell
I'd somehow managed to break the ptx build for trunk when merging my reorg cleanup. Fixed thusly (applied as obvious). nathan 2015-07-06 Nathan Sidwell * config/nvptx/nvptx.c (nvptx_reorg): Remove unused vars. Fix call to nvptx_reorg_subreg. Index: config/nvptx/nvptx.c =

Re: [PATCH 1/4] Add classname/filename/line metadata to struct pass_data

2015-07-06 Thread Jeff Law
On 06/25/2015 03:36 PM, David Malcolm wrote: gcc/ChangeLog: * tree-pass.h (struct pass_data): Add fields "classname", "filename", "line_num". (PASS_DATA_INIT): New macro. All 4 parts of this patchkit are OK. jeff

Re: fix PR46029: reimplement if conversion of loads and stores

2015-07-06 Thread Jeff Law
On 06/25/2015 03:43 AM, Richard Biener wrote: Yes, and if you just look at scalar code then with the rewrite we can enable store if-conversion unconditionally. _But_ when the new scheme triggers vectorization cannot succeed on the result as we get if (cond) *p = val; if-converted to

RE: [PATCH] MIPS: Do not generate micromips code for the no-smartmips-lwxs.c testcase

2015-07-06 Thread Moore, Catherine
> -Original Message- > From: Andrew Bennett [mailto:andrew.benn...@imgtec.com] > Sent: Monday, July 06, 2015 9:34 AM > To: gcc-patches@gcc.gnu.org > Cc: Matthew Fortune; Moore, Catherine > Subject: [PATCH] MIPS: Do not generate micromips code for the no- > smartmips-lwxs.c testcase > > H

Re: [gomp4.1] Support #pragma omp target {enter,exit} data

2015-07-06 Thread Jakub Jelinek
On Mon, Jul 06, 2015 at 09:45:30PM +0300, Ilya Verbin wrote: > > What exactly do you have in mind here? > > > > void foo (int *p) > > { > > #pragma omp enter data (to:p[10]) > > ... > > #pragma omp exit data (from:p[10]) > > } > > > > where the latter will only deallocate &p[0] ... &p[9], but not

Re: [MOXIE] Hookize GO_IF_LEGITIMATE_ADDRESS

2015-07-06 Thread Jeff Law
On 07/05/2015 09:58 AM, Anatoliy Sokolov wrote: Hi. This patch removes obsolete GO_IF_LEGITIMATE_ADDRESS macros from the MOXIE back end in the GCC and introduces equivalent TARGET_ADDR_SPACE_LEGITIMATE_ADDRESS_P target hook. Regression tested on moxie-unknown-elf. OK for trunk? 2015-07-05 An

move a * (1 << b) -> a << b pattern from fold-const.c to match.pd

2015-07-06 Thread Prathamesh Kulkarni
Hi, The attached patch moves pattern a * (1 << b) -> a << b. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. OK for trunk if testing passes ? Thank you, Prathamesh 2015-07-06 Prathamesh Kulkarni * fold-const.c (fold_binary_loc): Remove pattern a * 1 << b -> a << b.

Re: [V850] Hookize GO_IF_LEGITIMATE_ADDRESS

2015-07-06 Thread Jeff Law
On 07/02/2015 12:18 PM, Anatoliy Sokolov wrote: Hi. This patch removes obsolete GO_IF_LEGITIMATE_ADDRESS macros from the V850 back end in the GCC and introduces equivalent TARGET_LEGITIMATE_ADDRESS_P target hook. Regression tested on v850-unknown-eabi. 2015-07-02 Anatoly Sokolov * con

Re: [PATCH PR66702]Skip pr48052 on targets not support vect_int_mult

2015-07-06 Thread Jeff Law
On 07/03/2015 02:02 AM, Bin Cheng wrote: Hi, The test failed on sparc because sparc doesn't support vect_int_mult. This patch adds the prerequisite condition thus skips test on such platforms. An obvious change, will apply it in 24h. Thanks, bin gcc/testsuite/ChangeLog 2015-07-02 Bin Cheng

Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

2015-07-06 Thread Jeff Law
On 07/01/2015 09:51 PM, Ajit Kumar Agarwal wrote: -Original Message- From: Joseph Myers [mailto:jos...@codesourcery.com] Sent: Wednesday, July 01, 2015 3:48 AM To: Ajit Kumar Agarwal Cc: l...@redhat.com; GCC Patches; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mek

Re: [Patch, fortran, pr66578, v1] [F2008] Invalid free on allocate(...,source=a(:)) in block

2015-07-06 Thread Paul Richard Thomas
Andre, Forget my comment. I was seeing arrows all pointing in one direction ! Cheers Paul On 6 July 2015 at 21:42, Andre Vehreschild wrote: > Hi Paul, > > Thanks for the review, but I don't understand the regexp. rank_remap = > ss->dimen < ndim != 0 in my eyes is not a legal expression. Did y

Re: [Patch, fortran, pr66578, v1] [F2008] Invalid free on allocate(...,source=a(:)) in block

2015-07-06 Thread Andre Vehreschild
Hi Paul, Thanks for the review, but I don't understand the regexp. rank_remap = ss->dimen < ndim != 0 in my eyes is not a legal expression. Did you mean something like rank_remap = ss->dimen < ndim && ndim != 0, or the like? Regards, Andre Am 6. Juli 2015 21:36:18 MESZ, schrieb Paul Richard Th

Re: [patch] [fixincludes] Ignore .DS_Store junk files when running make check

2015-07-06 Thread Jeff Law
On 07/05/2015 04:58 PM, Eric Gallager wrote: I was just matching the code that was already used there... should the lines to ignore the CVS and .svn folders be re-written into the style you propose, too? Might as well have a consistent style. Embedding them into the "find" ought to be marginall

Re: [Patch, fortran, pr66578, v1] [F2008] Invalid free on allocate(...,source=a(:)) in block

2015-07-06 Thread Paul Richard Thomas
Dear Andre, Whilst it is probably OK in most circumstances, I would change: s/rank_remap = ss->dimen < ndim/rank_remap = ss->dimen < ndim != 0 Apart from that, it is indeed OK for trunk, in spite of your expectations :-) Thanks for the patch Paul On 6 July 2015 at 14:58, Andre Vehreschild wro

Re: [gomp] Move openacc vector& worker single handling to RTL

2015-07-06 Thread Nathan Sidwell
On 07/04/15 16:41, Nathan Sidwell wrote: On 07/03/15 19:11, Jakub Jelinek wrote: If the builtins are not meant to be used by users directly (I assume they aren't) nor have a 1-1 correspondence to a library routine, it is much better to emit them as internal calls (see internal-fn.{c,def}) inst

[PATCH 7/7] Fix several crashes in d_find_pack

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.c | 3 +++ libiberty/testsuite/demangle-expected | 12 2 files changed, 15 insertions(+) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 289a704..4ca285e 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-demangle.c @

[PATCH 6/7] Fix DEMANGLE_COMPONENT_LOCAL_NAME

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.c | 7 +++ libiberty/testsuite/demangle-expected | 4 2 files changed, 11 insertions(+) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 424b1c5..289a704 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-demangle.c @@ -324

[PATCH 5/7] Fix braced-init-list demangling

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.c | 2 ++ libiberty/testsuite/demangle-expected | 4 2 files changed, 6 insertions(+) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index befa6b6..424b1c5 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-demangle.c @@ -3167,6 +3

[PATCH 4/7] Fix int overflow

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.c | 3 ++- libiberty/testsuite/demangle-expected | 4 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 44a0a9b..befa6b6 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-demangle

[PATCH 3/7] Fix trinary op

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.c | 4 +++- libiberty/testsuite/demangle-expected | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 12093cc..44a0a9b 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-deman

[PATCH 2/7] Fix build with CP_DEMANGLE_DEBUG

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 2988b6b..12093cc 100644 --- a/libiberty/cp-demangle.c +++ b/libiberty/cp-demangle.c @@ -715,7 +715,7 @@ d_dump (struct demangle_component *dc, int

[PATCH 1/7] Add CHECK_DEMANGLER

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.h | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/libiberty/cp-demangle.h b/libiberty/cp-demangle.h index 6fce025..c37a91f 100644 --- a/libiberty/cp-demangle.h +++ b/libiberty/cp-demangle.h @@ -135,12 +135,41 @@ struc

[PATCH 0/7] Fix bugs found during demangler fuzz-testing

2015-07-06 Thread Mikhail Maltsev
Hi, all! I performed some fuzz-testing of C++ demangler (libiberty/cp-demangle.c). The test revealed several bugs, which are addressed by this series of patches. Here is a brief description of them: First one adds a macro CHECK_DEMANGLER. When this macro is defined, d_peek_next_char and d_advance

Re: [gomp4.1] Support #pragma omp target {enter,exit} data

2015-07-06 Thread Ilya Verbin
On Mon, Jul 06, 2015 at 19:25:09 +0200, Jakub Jelinek wrote: > On Mon, Jul 06, 2015 at 06:34:25PM +0300, Ilya Verbin wrote: > > On Thu, Jul 02, 2015 at 00:06:58 +0300, Ilya Verbin wrote: > > > The patch is not ready though, I don't know how to unmap GOMP_MAP_POINTER > > > vars. > > > In gomp_unmap

[gomp4.1] Parsing of defaultmap(tofrom:scalar) and private/firstprivate clauses on target construct

2015-07-06 Thread Jakub Jelinek
Hi! This patch adds parsing of defaultmap(tofrom:scalar) clause as well as allowing of private/firstprivate on target construct. Next step will be to handle private/firstprivate in clause splitting and gimplification rules, then expansion of firstprivate and private with pointer-assignment on tar

Re: flatten cfgloop.h

2015-07-06 Thread Jeff Law
On 07/06/2015 07:38 AM, Michael Matz wrote: Hi, On Sun, 5 Jul 2015, Prathamesh Kulkarni wrote: Hi, The attached patches flatten cfgloop.h. patch-1.diff moves around prototypes and structures to respective header-files. patch-2.diff (mostly auto-generated) replicates cfgloop.h includes in c fil

Re: [PATCH] PR target/66749: Add -march=iamcu to optimize for IA MCU

2015-07-06 Thread Uros Bizjak
On Mon, Jul 6, 2015 at 7:03 PM, H.J. Lu wrote: > On Mon, Jul 6, 2015 at 9:58 AM, Dominique d'Humières > wrote: >> This breaks bootstrap on x86_64-apple-darwin14: >> >> ../../work/gcc/config/i386/i386-c.c: In function 'void >> ix86_target_macros_internal(long long int, processor_type, processor_

Re: [PATCH] fix PR46029: reimplement if conversion of loads and stores [2nd submitted version of patch]

2015-07-06 Thread Abe
[Abe wrote:] This seems like an opportunity for more optimization in the future [On 7/6/15 10:09 AM, Alan Lawrence wrote:] we get enough benefit from the patch, even without my suggested extra change. Ok, fair enough! Thanks for the clarification. You are welcome, sir. [Alan wrote:]

Re: [PATCH 2/2][ARM] fix movdi expander to avoid illegal ldrd/strd

2015-07-06 Thread Alan Lawrence
Richard Earnshaw wrote: On 03/07/15 16:27, Alan Lawrence wrote: The previous patch caused a regression in gcc.c-torture/execute/20040709-1.c at -O0 (only), and the new align_rec2.c test fails, both outputting an illegal assembler instruction (ldrd on an odd-numbered reg) from output_move_double

RE: [Patch, MIPS] Enable fp-contract on MIPS and update -mfused-madd

2015-07-06 Thread Steve Ellcey
On Mon, 2015-06-29 at 12:07 -0700, Matthew Fortune wrote: > If nobody can identify any further functional issues with this patch then > I'd like to get this committed and pursue enhancements as a second round. > Catherine, would you be happy for this to be committed on that basis? > > Thanks, > M

Re: [RFC] two-phase marking in gt_cleare_cache

2015-07-06 Thread Tom de Vries
On 06/07/15 15:29, Richard Biener wrote: On Mon, Jul 6, 2015 at 3:25 PM, Richard Biener wrote: On Mon, Jul 6, 2015 at 10:57 AM, Tom de Vries wrote: Hi, Using attached untested patch, I managed to minimize a test-case failure for PR 66714. The patch introduces two-phase marking in gt_cleare_

Re: [gomp4.1] Support #pragma omp target {enter,exit} data

2015-07-06 Thread Jakub Jelinek
On Mon, Jul 06, 2015 at 06:34:25PM +0300, Ilya Verbin wrote: > On Thu, Jul 02, 2015 at 00:06:58 +0300, Ilya Verbin wrote: > > On Tue, Jun 30, 2015 at 18:10:44 +0200, Jakub Jelinek wrote: > > > The thing is whether it is actually a good idea to allocate the enter data > > > allocated objects togethe

Re: [PATCH] Enable two UNSIGNED_FLOAT simplifications in simplify_unary_operation_1

2015-07-06 Thread Kyrill Tkachov
On 23/06/15 11:43, Renlin Li wrote: Hi Christophe, Yes, we have also noticed this failure. Here I have a simple patch to remove the mfloat-abi option for hard-float toolchain. The default abi is used. For non-hardfloat toolchain, softfp abi is specified. I have checked with arm-none-eabi and

Re: [PATCH] PR target/66749: Add -march=iamcu to optimize for IA MCU

2015-07-06 Thread H.J. Lu
On Mon, Jul 6, 2015 at 9:58 AM, Dominique d'Humières wrote: > This breaks bootstrap on x86_64-apple-darwin14: > > ../../work/gcc/config/i386/i386-c.c: In function 'void > ix86_target_macros_internal(long long int, processor_type, processor_type, > fpmath_unit, void (*)(cpp_reader*, const > char

Re: [patch] [fixincludes] Ignore .DS_Store junk files when running make check

2015-07-06 Thread Andreas Schwab
Eric Gallager writes: > I was just matching the code that was already used there... should the > lines to ignore the CVS and .svn folders be re-written into the style > you propose, too? Yes, that would be an improvement. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint =

Re: [PATCH] PR target/66749: Add -march=iamcu to optimize for IA MCU

2015-07-06 Thread Dominique d'Humières
This breaks bootstrap on x86_64-apple-darwin14: ../../work/gcc/config/i386/i386-c.c: In function 'void ix86_target_macros_internal(long long int, processor_type, processor_type, fpmath_unit, void (*)(cpp_reader*, const char*))':../../work/gcc/config/i386/i386-c.c:59:10: error: enumeration value

Re: [PATCH] Optimize i?86-*-elfiamcu for iamcu by default

2015-07-06 Thread Uros Bizjak
On Mon, Jul 6, 2015 at 6:43 PM, H.J. Lu wrote: > Default -mtune=/-march= to iamcu for i[34567]86-*-elfiamcu targets. > > OK for trunk? > > Thanks. > > H.J. > --- > * config.gcc (x86_archs): Add iamcu. > (with_cpu): Default to iamcu for i[34567]86-*-elfiamcu. > (with_arch):

[PATCH, i386]: Use extv and extzv

2015-07-06 Thread Uros Bizjak
Hello! Attached patch renames (obsolete) extv and extzv expanders to extv and extzv. Since the patch uses SImode for operands 2 and 3 on both, 32bit and 64bit targets, we can remove a couple of BT patterns that were used for DImode operands. The patch also removes some modes from const_int operan

Re: [PATCH 1/2][ARM] PR/65956 AAPCS update for alignment attribute

2015-07-06 Thread Alan Lawrence
Ramana Radhakrishnan wrote: On 06/07/15 17:38, Alan Lawrence wrote: Trying to push these now (svn!), patch 2 is going first. I realize my second iteration of patch 1/2, dropped the testcases from the first version. Okay to include those as per https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00

[PATCH] Optimize i?86-*-elfiamcu for iamcu by default

2015-07-06 Thread H.J. Lu
Default -mtune=/-march= to iamcu for i[34567]86-*-elfiamcu targets. OK for trunk? Thanks. H.J. --- * config.gcc (x86_archs): Add iamcu. (with_cpu): Default to iamcu for i[34567]86-*-elfiamcu. (with_arch): Likewise. * doc/invoke.texi: Add iamcu. --- gcc/config.gcc

Re: [PATCH 1/2][ARM] PR/65956 AAPCS update for alignment attribute

2015-07-06 Thread Ramana Radhakrishnan
On 06/07/15 17:38, Alan Lawrence wrote: > Trying to push these now (svn!), patch 2 is going first. > > I realize my second iteration of patch 1/2, dropped the testcases from the > first version. Okay to include those as per > https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00215.html ? Yeah the

Re: [PATCH 1/2][ARM] PR/65956 AAPCS update for alignment attribute

2015-07-06 Thread Alan Lawrence
Trying to push these now (svn!), patch 2 is going first. I realize my second iteration of patch 1/2, dropped the testcases from the first version. Okay to include those as per https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00215.html ? Cheers, Alan Ramana Radhakrishnan wrote: On 06/07/15 12

Re: [ARM] Fix PR middle-end/65958

2015-07-06 Thread Ramana Radhakrishnan
On 18/06/15 20:02, Eric Botcazou wrote: >> Please mark this pattern with (set_attr "type" "multiple"). > > Done. > >> While I suspect that stack probing is done before any insns with invalid >> constants in the function, it would be better to model the length of >> this insn so that the minipoo

Re: [PATCH][AArch64] PR target/66731 Fix fnmul insn with -frounding-math

2015-07-06 Thread Marcus Shawcroft
On 6 July 2015 at 09:20, Szabolcs Nagy wrote: > 2015-07-06 Szabolcs Nagy > > * gcc.target/aarch64/fnmul-1.c: New. > * gcc.target/aarch64/fnmul-2.c: New. > * gcc.target/aarch64/fnmul-3.c: New. > * gcc.target/aarch64/fnmul-4.c: New. +float +foo_s (float a, float

RE: [PATCH] MIPS: Update stack-1.c testcase to match micromips jraddiusp instruction.

2015-07-06 Thread Moore, Catherine
> -Original Message- > From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] > Sent: Monday, July 06, 2015 11:00 AM > To: Andrew Bennett; gcc-patches@gcc.gnu.org > Cc: Moore, Catherine > Subject: RE: [PATCH] MIPS: Update stack-1.c testcase to match micromips > jraddiusp instruction. >

Re: [gomp4.1] Support #pragma omp target {enter,exit} data

2015-07-06 Thread Ilya Verbin
On Thu, Jul 02, 2015 at 00:06:58 +0300, Ilya Verbin wrote: > On Tue, Jun 30, 2015 at 18:10:44 +0200, Jakub Jelinek wrote: > > The thing is whether it is actually a good idea to allocate the enter data > > allocated objects together. > > In OpenMP 4.0, generally objects would be allocated and deallo

Re: flatten cfgloop.h

2015-07-06 Thread Andrew MacLeod
On 07/06/2015 09:38 AM, Michael Matz wrote: Hi, On Sun, 5 Jul 2015, Prathamesh Kulkarni wrote: Hi, The attached patches flatten cfgloop.h. patch-1.diff moves around prototypes and structures to respective header-files. patch-2.diff (mostly auto-generated) replicates cfgloop.h includes in c fil

Re: [PATCH] PR target/66749: Add -march=iamcu to optimize for IA MCU

2015-07-06 Thread H.J. Lu
On Mon, Jul 6, 2015 at 8:13 AM, Uros Bizjak wrote: > On Mon, Jul 6, 2015 at 3:28 PM, H.J. Lu wrote: >> IA MCU is based on Intel Pentium ISA without x87 and passing parameters >> in registers. We want to optimize for IA MCU without changing existing >> Pentium codegen. This patch adds PROCESSOR_

Re: [Patch, ARM]: remove TARGET_ASM_FILE_START_APP_OFF

2015-07-06 Thread Ramana Radhakrishnan
On 30/06/15 13:07, Christian Bruel wrote: > Hi, > > A little bit of polishing around arm/thumb attribute_target emission and > testing: Since the arch mode is emitted for each function, the file setting > becomes useless or redundant. > > for example with attr_thumb.c: > > =>.arm > =>

Re: [PATCH] PR target/66749: Add -march=iamcu to optimize for IA MCU

2015-07-06 Thread Uros Bizjak
On Mon, Jul 6, 2015 at 3:28 PM, H.J. Lu wrote: > IA MCU is based on Intel Pentium ISA without x87 and passing parameters > in registers. We want to optimize for IA MCU without changing existing > Pentium codegen. This patch adds PROCESSOR_IAMCU for -march=iamcu, > which is based on -march=pentiu

Re: [PATCH] fix PR46029: reimplement if conversion of loads and stores [2nd submitted version of patch]

2015-07-06 Thread Alan Lawrence
Abe wrote: On 7/2/15 4:49 AM, Alan Lawrence wrote: As before, I'm still confused here. This still returns false, i.e. bails out of if-conversion, if the statement could trap. Doesn't the scratchpad let us handle that? Or do we just not care because it won't be vectorizable anyway??? This seems

RE: [PATCH] MIPS: Update stack-1.c testcase to match micromips jraddiusp instruction.

2015-07-06 Thread Matthew Fortune
Andrew Bennett writes: > The stack-1.c testcase fails when being compiled for micromips with the > -O0 optimization level. The reason is the testcase is expecting the > following sequence at the end of the function: > >addiu $sp,$sp,16 >jrc $31 > > But for micromips it gen

Re: [PATCH][10/n] Remove GENERIC stmt combining from SCCVN

2015-07-06 Thread Kyrill Tkachov
On 06/07/15 15:46, Richard Biener wrote: On Mon, 6 Jul 2015, Kyrill Tkachov wrote: Hi Richard, On 01/07/15 14:03, Richard Biener wrote: This merges the complete comparison patterns from the match-and-simplify branch, leaving incomplete implementations of fold-const.c code alone. Bootstrappe

Re: Get rid of move_iterator in debug checks

2015-07-06 Thread Jonathan Wakely
On 05/07/15 23:23 +0200, François Dumont wrote: Ok ? Yes, OK, thanks.

Re: [PATCH] libstdc++ os_defines now required for DragonFly

2015-07-06 Thread Jonathan Wakely
On 06/07/15 15:57 +0200, John Marino wrote: On the development branch of DragonFly BSD, it was discovered that __LONG_LONG_SUPPORTED was accidently unconditionally defined. This had a positive side effect of allowing GCC conftests to pass for C99 support via wchar.h. When the bug was fixed, the

Re: [PATCH][10/n] Remove GENERIC stmt combining from SCCVN

2015-07-06 Thread Richard Biener
On Mon, 6 Jul 2015, Kyrill Tkachov wrote: > Hi Richard, > > On 01/07/15 14:03, Richard Biener wrote: > > This merges the complete comparison patterns from the match-and-simplify > > branch, leaving incomplete implementations of fold-const.c code alone. > > > > Bootstrapped and tested on x86_64-u

Re: [PATCH 4/7] use #if for HARD_FRAME_POINTER_IS_FRAME_POINTER less

2015-07-06 Thread Segher Boessenkool
On Mon, Jul 06, 2015 at 08:11:27AM -0400, tbsaunde+...@tbsaunde.org wrote: > From: Trevor Saunders > > gcc/ChangeLog: > > 2015-07-06 Trevor Saunders > > * combine.c (can_combine_def_p): Don't check the value of > * HARD_FRAME_POINTER_IS_FRAME_POINTER with the preprocessor.

Re: [RFC 2/2] Add steady_clock support to condition_variable

2015-07-06 Thread Jonathan Wakely
On 06/07/15 15:18 +0100, Mike Crowe wrote: On Monday 06 July 2015 at 14:54:06 +0100, Jonathan Wakely wrote: Do you have a copyright assignment in place for GCC contributions? Not yet. From my reading of https://gcc.gnu.org/contribute.html I should probably ask you for the forms. :-) Yep :-)

Re: [PATCH 2/7] remove #if for HAVE_cc0 in combine.c

2015-07-06 Thread Segher Boessenkool
On Mon, Jul 06, 2015 at 08:11:25AM -0400, tbsaunde+...@tbsaunde.org wrote: > @@ -1327,7 +1322,7 @@ combine_instructions (rtx_insn *f, unsigned int nregs) >We need this special code because data flow connections >via CC0 do not get entered in LOG_LINKS. */ > > - if (

Re: [PATCH][10/n] Remove GENERIC stmt combining from SCCVN

2015-07-06 Thread Andreas Schwab
Kyrill Tkachov writes: > This broke some tests on aarch64: > FAIL: gcc.target/aarch64/subs.c scan-assembler subs\tw[0-9] > FAIL: gcc.target/aarch64/subs1.c scan-assembler subs\tw[0-9]+, w[0-9]+, > w[0-9]+ > FAIL: gcc.target/aarch64/subs1.c scan-assembler subs\tw[0-9]+, w[0-9]+, > w[0-9]+, lsl 3

Re: [RFC 1/2] gthread: Add __gthread_cond_timedwaitonclock

2015-07-06 Thread Jonathan Wakely
On 06/07/15 15:10 +0100, Mike Crowe wrote: On Monday 06 July 2015 at 14:51:42 +0100, Jonathan Wakely wrote: This isn't correct, because it's possible to include before including any C++ Standard Library header, so the _GLIBCXX_ macro defined in libstdc++'s c++config.h will not have been defined

[PATCH] MIPS: Update stack-1.c testcase to match micromips jraddiusp instruction.

2015-07-06 Thread Andrew Bennett
Hi, The stack-1.c testcase fails when being compiled for micromips with the -O0 optimization level. The reason is the testcase is expecting the following sequence at the end of the function: addiu $sp,$sp,16 jrc $31 But for micromips it generates the following: jradd

Re: [PATCH][10/n] Remove GENERIC stmt combining from SCCVN

2015-07-06 Thread Kyrill Tkachov
Hi Richard, On 01/07/15 14:03, Richard Biener wrote: This merges the complete comparison patterns from the match-and-simplify branch, leaving incomplete implementations of fold-const.c code alone. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-07-01 Richard Biene

Re: [PATCH 1/2][ARM] PR/65956 AAPCS update for alignment attribute

2015-07-06 Thread Ramana Radhakrishnan
On 06/07/15 12:00, Alan Lawrence wrote: > Eric Botcazou wrote: >>> Technically this is incorrect since AGGREGATE_TYPE_P includes ARRAY_TYPE >>> and ARRAY_TYPE doesn't have TYPE_FIELDS. I doubt we could reach that >>> case though (unless there's a language that allows passing arrays by value). >>

Re: [RFC 2/2] Add steady_clock support to condition_variable

2015-07-06 Thread Mike Crowe
On Monday 06 July 2015 at 14:54:06 +0100, Jonathan Wakely wrote: > Do you have a copyright assignment in place for GCC contributions? Not yet. From my reading of https://gcc.gnu.org/contribute.html I should probably ask you for the forms. :-) Mike.

RE: [PATCH] MIPS: For micromips allow near-far-3.c test to use the jals instruction to call near_func

2015-07-06 Thread Andrew Bennett
> OK. Committed as SVN 225457. Regards, Andrew

Re: [RFC 1/2] gthread: Add __gthread_cond_timedwaitonclock

2015-07-06 Thread Mike Crowe
On Monday 06 July 2015 at 14:51:42 +0100, Jonathan Wakely wrote: > On 06/07/15 13:55 +0100, Mike Crowe wrote: > >diff --git a/libgcc/gthr-posix.h b/libgcc/gthr-posix.h > >index fb59816..0e01866 100644 > >--- a/libgcc/gthr-posix.h > >+++ b/libgcc/gthr-posix.h > >@@ -33,6 +33,7 @@ see the files COPYI

Re: [Ada] Add DragonFly support to System.OS_Constants template

2015-07-06 Thread Thomas Quinot
* John Marino, 2015-07-06 : > The System.OS_Constants templates for GNAT has three preprocessor checks > for FreeBSD. In all three cases, DragonFly BSD needs to be treated the > same as FreeBSD. The attached patch accomplishes this. Thanks John, looks good to me! Thomas.

Re: Clean-ups in match.pd

2015-07-06 Thread Richard Biener
On Sat, Jul 4, 2015 at 4:34 PM, Marc Glisse wrote: > Hello, > > these are just some minor changes. I believe I had already promised a build_ > function to match integer_each_onep. > > Bootstrap+testsuite on powerpc64le-unknown-linux-gnu (it looks like > *-match.c takes about 10 minutes to compile

Re: [PATCH 7/7] always define WORD_REGISTER_OPERATIONS

2015-07-06 Thread Segher Boessenkool
Hi Trevor, On Mon, Jul 06, 2015 at 08:11:30AM -0400, tbsaunde+...@tbsaunde.org wrote: > * defaults.h: Provide default for WORD_REGISTER_OPERATIONS. > * config/alpha/alpha.h: Define WORD_REGISTER_OPERATIONS to 1. > * config/arc/arc.h: Likewise. > * config/arm/arm.h: Likewise

[PATCH] libstdc++ os_defines now required for DragonFly

2015-07-06 Thread John Marino
On the development branch of DragonFly BSD, it was discovered that __LONG_LONG_SUPPORTED was accidently unconditionally defined. This had a positive side effect of allowing GCC conftests to pass for C99 support via wchar.h. When the bug was fixed, the wchar C99 conftest now fails, resulting in a

Re: [RFC 2/2] Add steady_clock support to condition_variable

2015-07-06 Thread Jonathan Wakely
On 06/07/15 13:55 +0100, Mike Crowe wrote: If __gthread_cond_timedwaitonclock is available it can be used it to fix part of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=41861 by supporting std::chrono::steady_clock properly with std::condition_variable. This means that code using std::condition_

Re: [RFC 1/2] gthread: Add __gthread_cond_timedwaitonclock

2015-07-06 Thread Jonathan Wakely
On 06/07/15 13:55 +0100, Mike Crowe wrote: diff --git a/libgcc/gthr-posix.h b/libgcc/gthr-posix.h index fb59816..0e01866 100644 --- a/libgcc/gthr-posix.h +++ b/libgcc/gthr-posix.h @@ -33,6 +33,7 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see #define __GTHREADS_CXX0X 1

Re: [PING][PATCH, 2/2][PR66642] Add empty loop exit block in transform_to_exit_first_loop_alt

2015-07-06 Thread Richard Biener
On Mon, 6 Jul 2015, Tom de Vries wrote: > On 25/06/15 09:43, Tom de Vries wrote: > > Hi, > > > > I ran into a failure with parloops for reduction loop testcase > > libgomp/testsuite/libgomp.c/parloops-exit-first-loop-alt-3.c. When we > > exercise the low iteration count loop, the test-case fails

Re: [PING][PATCH, 1/2] Merge rewrite_virtuals_into_loop_closed_ssa from gomp4 branch

2015-07-06 Thread Richard Biener
On Mon, 6 Jul 2015, Tom de Vries wrote: > On 25/06/15 09:42, Tom de Vries wrote: > > Hi, > > > > this patch merges rewrite_virtuals_into_loop_closed_ssa (originally > > submitted here: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01236.html > > ) to trunk. > > > > Bootstrapped and reg-tested on

  1   2   >