Re: Mostly rewrite genrecog

2015-04-29 Thread Andreas Schwab
Richard Sandiford writes: > /* Represents a test and the action that should be taken on the result. >If a transition exists for the test outcome, the machine switches >to the transition's target state. If no suitable transition exists, >the machine either falls through to the next de

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Andreas Schwab
Trevor Saunders writes: >> diff --git a/libobjc/encoding.c b/libobjc/encoding.c >> index 7333908..20ace46 100644 >> --- a/libobjc/encoding.c >> +++ b/libobjc/encoding.c >> @@ -1167,7 +1167,7 @@ objc_layout_structure_next_member (struct >> objc_struct_layout *layout) >>/* Record must have at

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Andreas Schwab
Trevor Saunders writes: > actually pointing out libojc/encoding.c was more useful since that makes > it pretty clear the ifndef PCC_BITFIELD_TYPE_MATTERS there just needs to > be changed to #if ! That probably won't work on arm or powerpc or vax: gcc/config/arm/arm.h:#define PCC_BITFIELD_TYPE_M

Re: Mostly rewrite genrecog

2015-04-29 Thread Bin.Cheng
On Mon, Apr 27, 2015 at 6:20 PM, Richard Sandiford wrote: > I think it's been the case for a while that parallel builds of GCC tend > to serialise around the compilation of insn-recog.c, especially with > higher --enable-checking settings. This patch tries to speed that > up by replacing most of

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-29 Thread Uros Bizjak
On Wed, Apr 29, 2015 at 11:22 PM, Caroline Tice wrote: > Here is a new patch to update the cold name partition so that it will > only be treated like a function name and be given a size on the > architectures that specifically define macros for such. > > I also updated the test case to try to only

Re: Refactor gcc/tree-vectorize.c:vectorize_loops

2015-04-29 Thread Jeff Law
On 04/29/2015 08:37 AM, Aditya K wrote: Thanks for the feedback. I have added comment and properly indented the code. I made a couple more formatting fixes (spaces -> tab & line wrapping), improved the ChangeLog, did a bootstrap & regression test on x86_64-linux-gnu and installed the final pat

Re: [PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

2015-04-29 Thread Jeff Law
On 04/29/2015 02:01 AM, Bernhard Reutner-Fischer wrote: 2012-09-21 H.J. Lu PR target/48904 * config.gcc (x86_64-*-knetbsd*-gnu): Add i386/knetbsd-gnu64.h. * config/i386/knetbsd-gnu64.h: New file OK. Please install on the trunk. THanks, Jeff

Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-04-29 Thread Jeff Law
On 04/29/2015 01:55 AM, Mikhail Maltsev wrote: [ Big Snip ] Couple minor issues. Can you please check the changes to do_jump_1, the indention looked weird in the patch. If it's correct, just say so. The ChangeLog needed some work. I'm attaching the one I'd use for the patch as it stands to

Re: [PATCH] add self-tuning to x86 hardware fast path in libitm

2015-04-29 Thread Andi Kleen
Nuno Diegues writes: > Hello, > > I have taken the chance to improve the patch by addressing the > comments above in this thread. > Namely: > - to use a simple random generator managed inside the library only > - removed floating point usage and replaced by fixed arithmetic > - added some comm

Re: [patch] Rewrite check_global_declarations() generically

2015-04-29 Thread Aldy Hernandez
On 04/29/2015 12:33 PM, Jason Merrill wrote: On 04/28/2015 09:01 PM, Aldy Hernandez wrote: The approach looks good to me. - analyze_functions (); + analyze_functions (true); In the C++ front end at least we comment anonymous boolean arguments, i.e. analyze_functions (/*first_time*/true)

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-29 Thread Jack Howarth
The new patch bootstraps fine on x86_64-apple-darwin14. On Wed, Apr 29, 2015 at 5:22 PM, Caroline Tice wrote: > Here is a new patch to update the cold name partition so that it will > only be treated like a function name and be given a size on the > architectures that specifically define macros f

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Jeff Law
On 04/29/2015 08:10 PM, Trevor Saunders wrote: I decided to commit this, it seems like testing it can be slow on some targets and I did a bootstrap on x86_64-linux-gnu (with regtest queued) and it seems very very unlikely to break anything else. Seems reasonable.Thanks for taking care of it

More type narrowing in match.pd

2015-04-29 Thread Jeff Law
This is an incremental improvement to the type narrowing in match.pd. It's largely based on the pattern I added to fix 47477. Basically if we have (bit_and (arith_op (convert A) (convert B)) mask) Where the conversions are widening and the mask turns off all bits outside the original types

Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-04-29 Thread Jeff Law
On 04/29/2015 01:55 AM, Mikhail Maltsev wrote: I probably would have done separate patches for the std::swap changes. They're not really related to the rtx subclasses work. OK, sending 2 separate patches. Note that they a not "commutative": std::swap should be applied before the main one, beca

Re: [PATCH] add self-tuning to x86 hardware fast path in libitm

2015-04-29 Thread Nuno Diegues
Hello, I have taken the chance to improve the patch by addressing the comments above in this thread. Namely: - to use a simple random generator managed inside the library only - removed floating point usage and replaced by fixed arithmetic - added some comments where relevant Re-running the ST

Re: [PATCH] Fix PR62283

2015-04-29 Thread H.J. Lu
On Tue, Apr 28, 2015 at 1:29 AM, Richard Biener wrote: > > The following fixes a missed optimization in basic-block vectorization. > Currently we require the SLP chain to end up in a sequence of loads > we support. But of course we can in theory end the SLP chain at > any point and simply constru

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Trevor Saunders
On Wed, Apr 29, 2015 at 08:13:16PM -0400, Trevor Saunders wrote: > On Wed, Apr 29, 2015 at 04:29:26PM -0600, Jeff Law wrote: > > On 04/29/2015 04:25 PM, Trevor Saunders wrote: > > >On Wed, Apr 29, 2015 at 04:00:47PM -0600, Jeff Law wrote: > > >>On 04/29/2015 03:55 PM, Andreas Schwab wrote: > > >>>T

mismatch in configure.ac for libgomp

2015-04-29 Thread Pedro Giffuni
Hello; I was checking out some old gcc revisions and I found this commit: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=140497 It has an obvious error that is still carried today: Instead of adding adding the check for the header a redundant check for was added. The mismatch is sti

[debug-early] fix -fdump-go-spec

2015-04-29 Thread Aldy Hernandez
Hi guys! Despite what Go thinks: /* The debug hooks are used to implement -fdump-go-spec because it gives a simple and stable API for all the information we need to dump. */ ...the debug hooks are not stable... :). The godump-1.c test is failing in the debug-early branch. It seem

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Trevor Saunders
On Wed, Apr 29, 2015 at 04:29:26PM -0600, Jeff Law wrote: > On 04/29/2015 04:25 PM, Trevor Saunders wrote: > >On Wed, Apr 29, 2015 at 04:00:47PM -0600, Jeff Law wrote: > >>On 04/29/2015 03:55 PM, Andreas Schwab wrote: > >>>Trevor Saunders writes: > >>> > it passes for me on x86_64-linux after

[C++ Patch] PR 61683

2015-04-29 Thread Paolo Carlini
Hi, this seems pretty straightforward given the grammar. Tested x86_64-linux. Thanks, Paolo. /cp 2015-04-30 Paolo Carlini PR c++/61683 * parser.c (cp_parser_mem_initializer): Allow for decltype-specifier. /testsuite 2015-04-30 Paolo Carlini

Re: [PATCH 0/13] Add musl support to GCC

2015-04-29 Thread Joseph Myers
On Wed, 29 Apr 2015, Szabolcs Nagy wrote: > only affects [u]int_fastN_t types > (on 64bit systems for N=16,32 musl uses int but glibc uses long) > > i can fix glibc-stdint.h, but it's yet another way in which the > compiler is tied to a particular libc. > > (using musl-stdint.h would be nicer, b

Re: [C/C++ PATCH] Implement -Wshift-negative-value (PR c/65179)

2015-04-29 Thread Joseph Myers
On Mon, 27 Apr 2015, Marek Polacek wrote: > trigger by default. One change is that we reject programs that use shift with > undefined behavior in a context where a constant expression is required, thus > e.g. enum E { A = -1 << 0 }; > But I hope that's reasonable. That seems appropriate (for C99

Go patch committed: Fix escape analysis for multi-result calls

2015-04-29 Thread Ian Lance Taylor
This patch from Chris Manghane fixes the handling of multi-result calls in escape analysis. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 76359c093067 go/escape.cc --- a/go/escape.cc Wed Apr 29 15:09:15 2015 -0700 +++ b/go/escape.cc W

Re: [Patch/rtl-expand] Take tree range info into account to improve LSHIFT_EXP expanding

2015-04-29 Thread Jeff Law
On 04/29/2015 03:36 PM, Jiong Wang wrote: Jeff Law writes: On 04/27/2015 02:21 PM, Jiong Wang wrote: Jeff, Sorry, I can't understand the meaning of "overlap between t_low and low", assume "right" in "right value" means the opposite of "left" not "correct". So what you mean

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Jeff Law
On 04/29/2015 04:25 PM, Trevor Saunders wrote: On Wed, Apr 29, 2015 at 04:00:47PM -0600, Jeff Law wrote: On 04/29/2015 03:55 PM, Andreas Schwab wrote: Trevor Saunders writes: it passes for me on x86_64-linux after that commit, what platform is this? Any one with #undef PCC_BITFIELD_TYPE_MA

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Jeff Law
On 04/29/2015 04:25 PM, Trevor Saunders wrote: On Wed, Apr 29, 2015 at 04:00:47PM -0600, Jeff Law wrote: On 04/29/2015 03:55 PM, Andreas Schwab wrote: Trevor Saunders writes: it passes for me on x86_64-linux after that commit, what platform is this? Any one with #undef PCC_BITFIELD_TYPE_MA

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Trevor Saunders
On Wed, Apr 29, 2015 at 04:00:47PM -0600, Jeff Law wrote: > On 04/29/2015 03:55 PM, Andreas Schwab wrote: > >Trevor Saunders writes: > > > >>it passes for me on x86_64-linux after that commit, what platform is > >>this? > > > >Any one with #undef PCC_BITFIELD_TYPE_MATTERS. See libobjc/encoding.c.

Go patch committed: Propagate escape info from closures to enclosed variables

2015-04-29 Thread Ian Lance Taylor
This patch from Chris Manghane fixes the Go frontend to propagate escape information from closures to the enclosed variables to which they refer. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 0010ef165479 go/escape.cc --- a/go/escape.cc We

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Jeff Law
On 04/29/2015 03:55 PM, Andreas Schwab wrote: Trevor Saunders writes: it passes for me on x86_64-linux after that commit, what platform is this? Any one with #undef PCC_BITFIELD_TYPE_MATTERS. See libobjc/encoding.c. Can't you just answer the question Andreas instead of making Trevor go loo

Re: [Patch/rtl-expand] Take tree range info into account to improve LSHIFT_EXP expanding

2015-04-29 Thread Jiong Wang
Jeff Law writes: > On 04/27/2015 02:21 PM, Jiong Wang wrote: > >> Jeff, >> >>Sorry, I can't understand the meaning of "overlap between t_low and low", >>assume "right" in "right value" means the opposite of "left" not >>"correct". >> >>So what you mean is t_low and low share the s

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Andreas Schwab
Trevor Saunders writes: > it passes for me on x86_64-linux after that commit, what platform is > this? Any one with #undef PCC_BITFIELD_TYPE_MATTERS. See libobjc/encoding.c. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276

Re: [PATCH] gfortran testsuite: implicitly cleanup-modules

2015-04-29 Thread Joseph Myers
On Thu, 23 Apr 2015, Bernhard Reutner-Fischer wrote: > I've done the above some time ago, dejagnu >= 1.5.2 has a "libdirs" > variable so i'd like to propose to: > > - Bump the required dejagnu version for gcc-6 to (let's say) 1.5.3 1.5.2 is only a few months old. I suggest waiting until a given

libgo patch committed: Support -buildmode=c-archive

2015-04-29 Thread Ian Lance Taylor
The upcoming Go 1.5 release of the gc compiler adds support for "go build -buildmode=c-archive". This can be used to build Go code into an archive (a .a file) that can be linked with a non-Go program, such that the non-Go program can call into Go code. This patch adds support for that to gccgo.

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Trevor Saunders
On Wed, Apr 29, 2015 at 02:35:39PM +0200, Andreas Schwab wrote: > spawn /daten/aranym/gcc/gcc-20150429/Build/gcc/xgcc > -B/daten/aranym/gcc/gcc-20150429/Build/gcc/ > /daten/aranym/gcc/gcc-20150429/gcc/testsuite/objc/execute/bf-1.m > -fno-diagnostics-show-caret -fdiagnostics-color=

New Danish PO file for 'gcc' (version 5.1.0)

2015-04-29 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Danish team of translators. The file is available at: http://translationproject.org/latest/gcc/da.po (This file, 'gcc-5.1.0.da.po', has just

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-29 Thread Caroline Tice
Here is a new patch to update the cold name partition so that it will only be treated like a function name and be given a size on the architectures that specifically define macros for such. I also updated the test case to try to only test on the appropriate architectures. I am not sure I got the

Re: [PATCH 5/14][AArch64] Add basic fp16 support

2015-04-29 Thread Joseph Myers
On Wed, 22 Apr 2015, Alan Lawrence wrote: > [Resending with correct in-reply-to header] > > This adds basic support for moving __fp16 values around, passing and > returning, and operating on them by promoting to 32-bit floats. Also a few > scalar testcases. I'd think it would be desirable to sha

Re: [PATCH, i386]: Fix PR 65871, bzhi builtin/intrinsic wrongly assumes bzhi instruction doesn't set the ZF flag

2015-04-29 Thread Uros Bizjak
On Wed, Apr 29, 2015 at 9:02 PM, Uros Bizjak wrote: > Hello! > > Attached patch implements a CCZ-only setting pattern for a couple of > BMI[,2] intrinsics. These two insns are three operand instructions, and some peephole2 patterns were not prepared for this. Please note that clobbered register c

RE: [Patch, MIPS] Change mips4 default processor to r10K

2015-04-29 Thread Moore, Catherine
> -Original Message- > From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] > Sent: Tuesday, April 28, 2015 2:38 PM > > Steve Ellcey writes: > > > > 2015-04-28 Steve Ellcey > > > > * config/mips/mips-cpus.def: (mips4): Change default processor > > from PROCESSOR_R8000 to

Re: C++ PATCH for c++/50800 (ICE with may_alias and templates)

2015-04-29 Thread Jason Merrill
On 04/29/2015 07:41 AM, Markus Trippelsdorf wrote: I'm getting hundreds of new warnings when building LLVM, e.g.: Whoops. Fixed thus. commit 7da5a68ba55cd49c46ff9ac547df59248bd90f7d Author: Jason Merrill Date: Wed Apr 29 16:04:08 2015 -0400 PR c++/50800 * tree.c (apply_identity

Re: [PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2015-04-29 Thread Jeff Law
On 04/26/2015 07:09 PM, Josh Triplett wrote: handle_section_attribute contains many levels of nested conditionals and branching code flow paths, with the error cases sometimes in the else case and sometimes in the if case. Simplify the code flow into a series of potential failure cases ending wi

RE: [PATCH v4][MIPS] fix CRT_CALL_STATIC_FUNCTION macro

2015-04-29 Thread Moore, Catherine
> -Original Message- > From: Petar Jovanovic [mailto:petar.jovano...@rt-rk.com] > Sent: Friday, April 24, 2015 10:51 AM > Subject: [PATCH v4][MIPS] fix CRT_CALL_STATIC_FUNCTION macro > > gcc/ChangeLog: > > 2015-04-21 Petar Jovanovic > > * config/mips/mips.h (CRT_CALL_STATIC_FU

Re: [C PATCH] c_incomplete_type_error TLC

2015-04-29 Thread Jeff Law
On 04/29/2015 12:51 PM, Marek Polacek wrote: This patch cleans up c_incomplete_type_error a bit: today, we should prefer using %qT over %<%s %E%> (the code is largely intact since 1992), and second, we should print the type if we can. The "invalid use of incomplete typedef" error wasn't tested a

Re: [patch] Rewrite check_global_declarations() generically

2015-04-29 Thread Jason Merrill
On 04/28/2015 09:01 PM, Aldy Hernandez wrote: The approach looks good to me. - analyze_functions (); + analyze_functions (true); In the C++ front end at least we comment anonymous boolean arguments, i.e. analyze_functions (/*first_time*/true); Let's do that here, too. Similarly for the

Re: [PATCH, i386]: Fix PR 65871, bzhi builtin/intrinsic wrongly assumes bzhi instruction doesn't set the ZF flag

2015-04-29 Thread Uros Bizjak
On Wed, Apr 29, 2015 at 9:23 PM, Jakub Jelinek wrote: > On Wed, Apr 29, 2015 at 09:02:16PM +0200, Uros Bizjak wrote: >> Hello! >> >> Attached patch implements a CCZ-only setting pattern for a couple of >> BMI[,2] intrinsics. > > What about the case when the result is used, but also tested for zero

Re: [PATCH, i386]: Fix PR 65871, bzhi builtin/intrinsic wrongly assumes bzhi instruction doesn't set the ZF flag

2015-04-29 Thread Jakub Jelinek
On Wed, Apr 29, 2015 at 09:02:16PM +0200, Uros Bizjak wrote: > Hello! > > Attached patch implements a CCZ-only setting pattern for a couple of > BMI[,2] intrinsics. What about the case when the result is used, but also tested for zero or non-zero? Like e.g. int bar (void); int foo (unsigned int

Re: [RFC]: Remove Mem/address type assumption in combiner

2015-04-29 Thread Jeff Law
On 04/29/2015 03:25 AM, Kumar, Venkataramanan wrote: Hi Jeff/Segher, When we see an RTX code with PLUS or MINUS then it is treated as MEM/address type (we are inside address RTX). Is there any significance on that assumption? I removed this assumption and the test case in the PR 63949 passe

Re: [RFC]: Remove Mem/address type assumption in combiner

2015-04-29 Thread Jeff Law
On 04/29/2015 11:03 AM, Segher Boessenkool wrote: Right. It would be good if you could find out for what targets it matters. The thing is, if a target expects only the patterns as combine used to make them, it will regress (as you've seen on aarch64); but it will regress _silently_. Which isn'

Re: [RFC]: Remove Mem/address type assumption in combiner

2015-04-29 Thread Jeff Law
On 04/29/2015 03:25 AM, Kumar, Venkataramanan wrote: Hi Jeff/Segher, Restarting the discussion on the GCC combiner assumption about Memory/address type. Ref: https://gcc.gnu.org/ml/gcc-patches/2015-01/msg01298.html https://gcc.gnu.org/ml/gcc/2015-04/msg00028.html Regards, Venkat. PS: I am

[PATCH, i386]: Fix PR 65871, bzhi builtin/intrinsic wrongly assumes bzhi instruction doesn't set the ZF flag

2015-04-29 Thread Uros Bizjak
Hello! Attached patch implements a CCZ-only setting pattern for a couple of BMI[,2] intrinsics. 2015-04-29 Uros Bizjak PR target/65871 * config/i386/i386.md (*bmi_bextr__cczonly): New pattern. (*bmi2_bzhi_3_1_cczonly): Ditto. testsuite/ChangeLog: 2015-04-29 Uros Bizjak P

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-29 Thread Caroline Tice
Thank you; I will work with your suggestions and try to get a new patch done soon. -- Caroline Tice cmt...@google.com On Wed, Apr 29, 2015 at 11:34 AM, Uros Bizjak wrote: > On Wed, Apr 29, 2015 at 7:47 PM, Uros Bizjak wrote: >> On Wed, Apr 29, 2015 at 7:38 PM, Caroline Tice wrote: >>> The att

Contents of PO file 'cpplib-5.1.0.sv.po'

2015-04-29 Thread Translation Project Robot
cpplib-5.1.0.sv.po.gz Description: Binary data The Translation Project robot, in the name of your translation coordinator.

New Swedish PO file for 'cpplib' (version 5.1.0)

2015-04-29 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'cpplib' has been submitted by the Swedish team of translators. The file is available at: http://translationproject.org/latest/cpplib/sv.po (This file, 'cpplib-5.1.0.sv.po',

[C PATCH] c_incomplete_type_error TLC

2015-04-29 Thread Marek Polacek
This patch cleans up c_incomplete_type_error a bit: today, we should prefer using %qT over %<%s %E%> (the code is largely intact since 1992), and second, we should print the type if we can. The "invalid use of incomplete typedef" error wasn't tested at all, so I'm also adding a test to exercise th

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-29 Thread Uros Bizjak
On Wed, Apr 29, 2015 at 7:47 PM, Uros Bizjak wrote: > On Wed, Apr 29, 2015 at 7:38 PM, Caroline Tice wrote: >> The attached patch can revert the previous patch, if that is the way >> we should proceed on this. If you want me to apply the reversion, >> please let me know. >> >> I would be happy t

Re: [PATCH] [libstdc++/65839] whatis support for xmethods

2015-04-29 Thread Jonathan Wakely
On 29/04/15 10:57 -0700, Doug Evans wrote: On Tue, Apr 28, 2015 at 5:16 AM, Jonathan Wakely wrote: On 27/04/15 15:44 -0700, Doug Evans wrote: PR libstdc++/65839 * python/libstdcxx/v6/xmethods.py (get_bool_type): New function. Replace all lookups of "bool" with this.

Re: [PATCH] Use consistent naming in libstdcxx/v6/xmethods.py

2015-04-29 Thread Jonathan Wakely
On 29/04/15 09:49 -0700, Doug Evans wrote: Hi. This patch splits out from the patch for 65839 the consistent naming suggested here. https://gcc.gnu.org/ml/libstdc++/2015-04/msg00155.html Regression tested on amd64-linux. Ok to commit? Thanks for doing this, OK to commit.

Re: [PATCH] [libstdc++/65839] whatis support for xmethods

2015-04-29 Thread Doug Evans
On Tue, Apr 28, 2015 at 5:16 AM, Jonathan Wakely wrote: > On 27/04/15 15:44 -0700, Doug Evans wrote: >> >> PR libstdc++/65839 >> * python/libstdcxx/v6/xmethods.py (get_bool_type): New function. >> Replace all lookups of "bool" with this. >> (get_std_size_type): New

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-29 Thread Uros Bizjak
On Wed, Apr 29, 2015 at 7:38 PM, Caroline Tice wrote: > The attached patch can revert the previous patch, if that is the way > we should proceed on this. If you want me to apply the reversion, > please let me know. > > I would be happy to fix to the problem, rather than just reverting the > patch

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-29 Thread Caroline Tice
The attached patch can revert the previous patch, if that is the way we should proceed on this. If you want me to apply the reversion, please let me know. I would be happy to fix to the problem, rather than just reverting the patch, but I do not have expertise in assembly language on other platfo

Re: [PATCH] Tidy up locking for libgomp OpenACC entry points

2015-04-29 Thread Thomas Schwinge
Hi Julian! On Fri, 24 Apr 2015 18:13:08 +0100, Julian Brown wrote: > On Thu, 23 Apr 2015 18:41:34 +0200 > Thomas Schwinge wrote: > > On Wed, 22 Apr 2015 19:42:43 +0100, Julian Brown > > wrote: > > > This patch is an attempt to fix some potential race conditions with > > > accesses to shared da

Re: [RFC]: Remove Mem/address type assumption in combiner

2015-04-29 Thread Segher Boessenkool
Hello Venkat, On Wed, Apr 29, 2015 at 09:25:21AM +, Kumar, Venkataramanan wrote: > diff --git a/gcc/combine.c b/gcc/combine.c > index 5c763b4..945abdb 100644 > --- a/gcc/combine.c > +++ b/gcc/combine.c > @@ -7703,8 +7703,6 @@ make_compound_operation (rtx x, enum rtx_code in_code) > but o

[PATCH] Use consistent naming in libstdcxx/v6/xmethods.py

2015-04-29 Thread Doug Evans
Hi. This patch splits out from the patch for 65839 the consistent naming suggested here. https://gcc.gnu.org/ml/libstdc++/2015-04/msg00155.html Regression tested on amd64-linux. Ok to commit? 2015-04-29 Doug Evans Use consistent naming for value type attributes. * python/lib

[debug-early] adjust tests for new defined/used warnings

2015-04-29 Thread Aldy Hernandez
This fixes the remaining regressions. With the new design for check_global_declaration*(), we diagnose many more warnings and so far, no false positives. Committed to branch. commit 7aeb35184b29f3c67470b63fcf107b54f075ffd7 Author: Aldy Hernandez Date: Wed Apr 29 09:43:48 2015 -0700 Adj

Re: C PATCH to reject va_arg (ap, void) (PR c/65901)

2015-04-29 Thread Marek Polacek
On Tue, Apr 28, 2015 at 09:07:09PM -0600, Martin Sebor wrote: > The error message in the test cases below isn't quite right. > The type of the aggregates isn't undefined, it's incomplete. > Looking at the function, I wonder if the first argument > should be EXPR rather than than NULL_TREE? Alternat

Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning)

2015-04-29 Thread Uros Bizjak
Hello! > 2015-03-27 Caroline Tice > > * final.c (final_scan_insn): Change 'cold_function_name' to > 'cold_partition_name' and make it a global variable; also output > assembly to give it a 'FUNC' type, if appropriate. > * varasm.c (cold_partition_name): Declare a

Re: [PATCH 6/n] OpenMP 4.0 offloading infrastructure: option handling

2015-04-29 Thread Thomas Schwinge
Hi! On Tue, 28 Apr 2015 15:24:08 +0200, Bernd Schmidt wrote: > On 04/27/2015 06:08 PM, Thomas Schwinge wrote: > > >>> OK to do the following instead? (Coding style/code copied from > >>> gcc/config/i386/intelmic-mkoffload.c for consistency.) > > Err, was this a question for me? I'm fine with

Re: [PATCH] libstdc++: Fix list.cc xmethods test.

2015-04-29 Thread Jonathan Wakely
On 29 April 2015 at 17:04, Doug Evans wrote: > Tested the same patch on the gcc 5.0 branch. > Just double checking ... ok to apply there too? Yes, OK for the branch too. > btw, the test is currently marked as unsupported by the test run. > I don't know what would be involved in marking it as fail

Re: Help needed debugging std::is_convertible problem (PR 65760)

2015-04-29 Thread Jonathan Wakely
On 17/04/15 01:03 +0200, Daniel Krügler wrote: 2015-04-16 14:33 GMT+02:00 Jonathan Wakely : https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65760 I don't understand why commenting out *any one* of the lines marked (1), (2), (3), (4) causes this to compile: #include struct C { C() = default;

[PATCH] PR ld/18355: --enable-shared doesn't work

2015-04-29 Thread H.J. Lu
When bfd is configured as a shared library, we need to configure zlib with --enable-host-shared since zlib is used by bfd. Any comments, feedbacks, objections? H.J. -- PR ld/18355 * Makefile.def: Add extra_configure_flags to host zlib. * configure.ac (extra_host_zlib_conf

Re: [PATCH] libstdc++: Fix list.cc xmethods test.

2015-04-29 Thread Doug Evans
On Mon, Apr 27, 2015 at 3:41 PM, Jonathan Wakely wrote: > On 27 April 2015 at 23:33, Doug Evans wrote: >> Hi. >> >> While we should eventually get the xmethods to handle cxx11, >> this patch fixes the current failure. >> The xmethod matcher doesn't currently handle __cxx11 in the type name. >> >>

Re: OMP_CLAUSES with clauses in operand 0

2015-04-29 Thread Thomas Schwinge
Hi! On Wed, 29 Apr 2015 17:28:54 +0200, Jakub Jelinek wrote: > On Wed, Apr 29, 2015 at 05:25:39PM +0200, Thomas Schwinge wrote: > > Done. (I also reverted the gcc/cp/pt.c:tsubst_expr change which > > motivated this patch; will include that with the patch adding support for > > C++ templates usag

Re: OMP_CLAUSES with clauses in operand 0

2015-04-29 Thread Thomas Schwinge
Hi Jakub! On Wed, 29 Apr 2015 16:36:24 +0200, Jakub Jelinek wrote: > On Wed, Apr 29, 2015 at 04:31:32PM +0200, Thomas Schwinge wrote: > > > So yes, I really prefer OMP_STANDALONE_CLAUSES over OMP_CLAUSES for > > > everything. > > > > Like this (for trunk)? > > > > commit 300e28fce192cb56d73cb61

Re: OMP_CLAUSES with clauses in operand 0

2015-04-29 Thread Jakub Jelinek
On Wed, Apr 29, 2015 at 05:25:39PM +0200, Thomas Schwinge wrote: > Done. (I also reverted the gcc/cp/pt.c:tsubst_expr change which > motivated this patch; will include that with the patch adding support for > C++ templates usage with OpenACC directives.) OK for trunk? Ok, thanks. Jakub

Re: [Patch, fortran, PR44672, v4] [F08] ALLOCATE with SOURCE and no array-spec

2015-04-29 Thread Andre Vehreschild
Hi all, this is the fourth version of the patch, adapting to the current state of trunk. This patch is based on my patch for 65584 version 2 and needs that patch applied beforehand to apply cleanly. The patch for 65548 is available from: https://gcc.gnu.org/ml/fortran/2015-04/msg00121.html Scope

Re: Fix librayr name of __builtin_allocal_with_align

2015-04-29 Thread Sandra Loosemore
On 04/28/2015 08:22 PM, Jan Hubicka wrote: I also looked into extend.texi and both __builtin_alloca and __builtin_alloca_with_align is missing (along with many other builtins) which is probably quite bad omission (__builtin_alloca_with_align is used at some places, i.e. in Firefox) Sandra, sin

[patch] libstdc++/64657 support iterators with overloaded comma operator

2015-04-29 Thread Jonathan Wakely
I think this covers all the places in the library where we do: ++i, ++j Tested powerpc64le-linux, committed to trunk. commit 572881116b98ee50027dbd5e8880ea6d92e86cca Author: Jonathan Wakely Date: Sun Jan 18 17:04:10 2015 + PR libstdc++/64657 * include/bits/basic_string (basic_

Re: [PATCH, AArch64] [4.8] [4.9] Backport PR64304 fix (miscompilation with -mgeneral-regs-only )

2015-04-29 Thread Marcus Shawcroft
Picking up this old back port request... On 5 March 2015 at 06:36, Chen Shanyao wrote: > +2015-03-05 Shanyao Chen There should be two spaces after the date and two before the < marker in a ChangeLog name line. This comment applies to each of the ChangeLogs presented. > +/* { dg-final { clea

[ubsan] Add -fsanitize=bounds-strict

2015-04-29 Thread Marek Polacek
This patch adds the -fsanitize=bounds-strict option Martin U. wanted; it is actually based on his earlier patch, I did only some small adjustments. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2015-04-29 Marek Polacek Martin Uecker * c-ubsan.c (ubsan_instrument_

Re: [gomp4.1] Initial support for some OpenMP 4.1 construct parsing

2015-04-29 Thread Thomas Schwinge
Hi Jakub! On Wed, 29 Apr 2015 14:06:44 +0200, Jakub Jelinek wrote: > On Wed, Apr 29, 2015 at 01:52:24PM +0200, Thomas Schwinge wrote: > > > --- gcc/tree-pretty-print.c.jj2015-04-29 10:58:01.663745452 +0200 > > > +++ gcc/tree-pretty-print.c 2015-04-29 11:03:04.648990986 +0200 > > > @@ -5

RE: Refactor gcc/tree-vectorize.c:vectorize_loops

2015-04-29 Thread Aditya K
Thanks for the feedback. I have added comment and properly indented the code. -Aditya > Date: Wed, 29 Apr 2015 09:31:46 +0200 > From: ja...@redhat.com > To: l...@redhat.com > CC: hiradi...@msn.com; gcc-patches@gcc.gnu.org > Subject: Re: Refactor gcc/tree-

Re: OMP_CLAUSES with clauses in operand 0

2015-04-29 Thread Jakub Jelinek
On Wed, Apr 29, 2015 at 04:31:32PM +0200, Thomas Schwinge wrote: > > So yes, I really prefer OMP_STANDALONE_CLAUSES over OMP_CLAUSES for > > everything. > > Like this (for trunk)? > > commit 300e28fce192cb56d73cb61f787872643030f0bf > Author: Thomas Schwinge > Date: Wed Apr 29 16:18:49 2015 +02

Re: OMP_CLAUSES with clauses in operand 0

2015-04-29 Thread Thomas Schwinge
Hi Jakub! On Wed, 29 Apr 2015 13:43:55 +0200, Jakub Jelinek wrote: > On Wed, Apr 29, 2015 at 01:13:29PM +0200, Thomas Schwinge wrote: > > On Wed, 29 Apr 2015 11:32:31 +0200, Jakub Jelinek wrote: > > > Yeah, it is a non-starter, it has unnecessary runtime overhead everywhere > > > where it is use

Re: Bare bones of type verifier

2015-04-29 Thread Jan Hubicka
Hi, this is updated patch that passes all languages LTO and non-LTO testing on ppc64. I found few issues - C++ FE messes up METHOD pointers becuase sometimes it duplicated a type while METHOD list is incomplete, so there are type variants that points to the middle of the final list. (I sup

Re: [patch] Perform anonymous constant propagation during inlining

2015-04-29 Thread Jan Hubicka
> On Wed, Apr 29, 2015 at 3:23 PM, Jan Hubicka wrote: > >> Historically the pragma Inline_Always of GNAT had been implemented in the > >> FE > >> because the RTL inliner and then the Tree inliner weren't invoked at -O0 or > >> powerful enough to inline some constructs. But this approach had > >

Re: [PATCH][AArch64] Increase static buffer size in aarch64_rewrite_selected_cpu

2015-04-29 Thread Kyrill Tkachov
On 20/04/15 21:30, James Greenhalgh wrote: On Mon, Apr 20, 2015 at 05:24:39PM +0100, Kyrill Tkachov wrote: Hi all, When trying to compile a testcase with -mcpu=cortex-a57+crypto+nocrc I got the weird assembler error: Assembler messages: Error: missing architectural extension Error: unrecognize

Re: [PATCH 5/13] microblaze musl support

2015-04-29 Thread Szabolcs Nagy
On 29/04/15 14:17, Michael Eager wrote: > On 04/27/2015 07:35 AM, Szabolcs Nagy wrote: >> >> On 20/04/15 19:54, Szabolcs Nagy wrote: >>> Set up dynamic linker name for microblaze. >>> >> >> Patch v2. >> (undef MUSL_DYNAMIC_LINKER that comes from config/linux.h) >> >> gcc/Changelog: >> >> 2015-04-

Re: Mostly rewrite genrecog

2015-04-29 Thread Richard Sandiford
Jeff Law writes: > On 04/27/2015 04:20 AM, Richard Sandiford wrote: >> Tested on x86_64-linux-gnu, aarch64-linux-gnu and arm-none-eabi. >> Also tested by building the testsuite for each of the targets above >> and making sure there were no assembly differences. Made sure that no >> objects in spe

Re: Mostly rewrite genrecog

2015-04-29 Thread Richard Sandiford
Eric Botcazou writes: >> Also, the code is all goto-based, which makes it rather hard to step >> through. > > Do you mean the code in genrecog.c or the generated code in insn-recog.c? The generated code. genrecog.c itself isn't bad. :-) >> PS. I've attached the new genrecog.c since the diff ver

Re: [patch] Perform anonymous constant propagation during inlining

2015-04-29 Thread Richard Biener
On Wed, Apr 29, 2015 at 3:23 PM, Jan Hubicka wrote: >> Historically the pragma Inline_Always of GNAT had been implemented in the FE >> because the RTL inliner and then the Tree inliner weren't invoked at -O0 or >> powerful enough to inline some constructs. But this approach had drawbacks, >> espe

Re: [PATCH][AArch64] Fix PR/65770 vstN_lane on bigendian

2015-04-29 Thread Marcus Shawcroft
On 16 April 2015 at 18:27, Alan Lawrence wrote: > As per bugzilla entry, indices in the generated assembly for bigendian are > flipped when they should not be (and, flipped always relative to a > Q-register!). > > This flips the lane indices back again at assembly time, fixing PR. The > "indices"

Re: [PATCH 0/13] Add musl support to GCC

2015-04-29 Thread Szabolcs Nagy
On 29/04/15 00:27, Joseph Myers wrote: > On Mon, 20 Apr 2015, Szabolcs Nagy wrote: > >> * On powerpc it seems the only configure option to choose the default >> long-double abi is --with-long-double-128, but that's the default with >> sufficiently new glibc. (musl gets 64bit long-double because

Re: [C++ Patch] PR 64667

2015-04-29 Thread Jason Merrill
On 04/29/2015 08:52 AM, Paolo Carlini wrote: + /* Handle references. */ + if (TREE_CODE (val) == INDIRECT_REF) Let's use REFERENCE_REF_P here. OK with that change. Jason

Re: [PATCH][AArch64] Fix PR/65770 vstN_lane on bigendian

2015-04-29 Thread Alan Lawrence
Alan Lawrence wrote: As per bugzilla entry, indices in the generated assembly for bigendian are flipped when they should not be (and, flipped always relative to a Q-register!). This flips the lane indices back again at assembly time, fixing PR. The "indices" contained in the RTL are still wron

Re: [patch] Perform anonymous constant propagation during inlining

2015-04-29 Thread Jan Hubicka
> Historically the pragma Inline_Always of GNAT had been implemented in the FE > because the RTL inliner and then the Tree inliner weren't invoked at -O0 or > powerful enough to inline some constructs. But this approach had drawbacks, > especially wrt debug info. These restrictions were gradua

Re: [PATCH,rs6000] Change -mcrypto to only affect Category:Vector.Crypto instructions

2015-04-29 Thread David Edelsohn
On Wed, Mar 4, 2015 at 3:14 PM, Bill Schmidt wrote: > Hi, > > I recently observed that -mno-crypto disables all instructions in > section 5.11 of the 2.07 ISA, rather than just those flagged as > Category:Vector.Crypto. This patch fixes that undesirable situation. > > The main fix is to ensure th

Re: [PATCH 5/13] microblaze musl support

2015-04-29 Thread Michael Eager
On 04/27/2015 07:35 AM, Szabolcs Nagy wrote: On 20/04/15 19:54, Szabolcs Nagy wrote: Set up dynamic linker name for microblaze. Patch v2. (undef MUSL_DYNAMIC_LINKER that comes from config/linux.h) gcc/Changelog: 2015-04-24 Gregor Richards * config/microblaze/linux.h (MUSL_DYNAM

[C++ Patch] PR 64667

2015-04-29 Thread Paolo Carlini
Hi, Jonathan noticed in the audit trail the probably his work for c++/18016 could be easily extended to handle references: simply looking through INDIRECT_REFs appears to do the trick. Tested x86_64-linux. Thanks, Paolo. /cp 2015-04-29 Paolo Carlini PR c++/64

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Andreas Schwab
spawn /daten/aranym/gcc/gcc-20150429/Build/gcc/xgcc -B/daten/aranym/gcc/gcc-20150429/Build/gcc/ /daten/aranym/gcc/gcc-20150429/gcc/testsuite/objc/execute/bf-1.m -fno-diagnostics-show-caret -fdiagnostics-color=never -w -O0 -fgnu-runtime -I/daten/aranym/gcc/gcc-20150429/gcc/testsuite

  1   2   >