[PATCH] Fix PR64059

2014-11-24 Thread Markus Trippelsdorf
This fixes PR64059 where a call to get_dynamic_type wasn't guarded by flag_devirtualize. Tested on powerpc64-unknown-linux-gnu. Preapproved by Honza on bugzilla. Commited to trunk. PR ipa/64059 * ipa-prop.c (ipa_analyze_call_uses): Don't call get_dynamic_type when devirtua

Re: [PATCH] Fix find_base_term in 32-bit -fpic code (PR lto/64025)

2014-11-24 Thread Uros Bizjak
On Tue, Nov 25, 2014 at 12:25 AM, Jakub Jelinek wrote: > The fallback delegitimization I've added as last option mainly for > debug info purposes, when we don't know if the base is a PIC register > or say a PIC register plus some addend, unfortunately in some tests > broke find_base_term, which f

[Patch, Fortran] convert almost all {warning,error}_now to common diagnostic

2014-11-24 Thread Tobias Burnus
With this patch – and the still pending patch for gfc_internal_error at https://gcc.gnu.org/ml/gcc-patches/2014-11/msg03003.html – all error/warning messages have been converted to the common diagnostic, except for: (a) those majority which might need buffering (gfc_error, gfc_warning); (b) th

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-24 Thread Jeff Law
On 11/24/14 18:09, Sebastian Pop wrote: Sebastian Pop wrote: I removed the return -1 and started a bootstrap on powerpc64-linux. Bootstrap passed on top of the 4 previous patches on powerpc64-linux. I will report the valgrind output. The output from valgrind looks closer to the output of m

[PATCH] Fix a bug in bt-load.c

2014-11-24 Thread Segher Boessenkool
This caused ICEs on sh64. `min_cost' and `def' here are supposed to refer to the same element; removing it from the heap before asking the heap for the key doesn't work (and at the end of the loop here we will ask for min_key on an empty heap, which then does gcc_unreachable). Bootstrapped and te

[PATCH] crtstuff: Add missing semicolon

2014-11-24 Thread Segher Boessenkool
I wonder how this survived so long, I must be building some strange configs (it failed on an avr cross). Okay for trunk? Segher 2014-11-24 Segher Boessenkool libgcc/ * crtstuff.c (__do_glbal_ctors_1): Add missing semicolon. --- libgcc/crtstuff.c | 2 +- 1 file changed, 1 insertio

[PATCH] mn10300: Fix an ICE

2014-11-24 Thread Segher Boessenkool
`lcc' is not an insn but just a pattern. This caused a build error in libgcc. Tested with a cross compiler build (which fails without and succeeds with the patch). Not tested much more; this compiler really likes to ICE, something with ipa-icf. Is this okay for trunk? Segher 2014-11-24 Segh

[PATCH] rs6000: Replace a stray addic with addi

2014-11-24 Thread Segher Boessenkool
Tested as usual... okay for trunk? Segher 2014-11-24 Segher Boessenkool gcc/ * config/rs6000/sysv4.h (ASM_OUTPUT_REG_POP): Use addi instead of addic. --- gcc/config/rs6000/sysv4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/rs6000/sysv4.

[PATCH] rs6000: Remove iorxor/IORXOR code attrs

2014-11-24 Thread Segher Boessenkool
As Richard pointed out, those do nothing more than code/CODE. Tested etc.; okay for trunk? Segher 2014-11-21 Segher Boessenkool gcc/ * config/rs6000/rs6000.md (iorxor, IORXOR): Delete code_attrs. (rest of file): Replace those with code resp. CODE. --- gcc/config/rs6000/rs6

Re: [C PATCH] Fix PR63877

2014-11-24 Thread Joseph Myers
On Mon, 24 Nov 2014, Marek Polacek wrote: > This PR is basically the same as PR54113, except this time it's about > -Wmissing-declarations and not about -Wmissing-prototypes. The problem > here is that we were emitting bogus warning for a correct use of an > inline function. Thus fixed in the sa

Re: [PATCH][AArch64] Remove crypto extension from default for cortex-a53, cortex-a57

2014-11-24 Thread Gerald Pfeifer
On Tuesday 2014-11-18 09:38, Kyrill Tkachov wrote: Here's what I propose. + The cryptographic extensions to the ARMv8-A architecture are no + longer enabled by default when specifying the + -mcpu=cortex-a53, -mcpu=cortex-a57 or + -mcpu=cortex-a57.cortex-a53 options. To e

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-24 Thread Sebastian Pop
Sebastian Pop wrote: > I removed the return -1 and started a bootstrap on powerpc64-linux. Bootstrap passed on top of the 4 previous patches on powerpc64-linux. > I will report the valgrind output. The output from valgrind looks closer to the output of master with no other patches: still 1M more

Re: [RFC] First steps towards segregating types.

2014-11-24 Thread Joseph Myers
On Mon, 24 Nov 2014, Richard Biener wrote: > > TREE_LIST should die (with the typical replacement being vec); > > most lists do not need all the overhead of individually allocated objects > > with (code, flags, type, chain, value, purpose). Probably TREE_VEC too. > > Note that there is nothing w

Re: [PATCH v3] Use strtoll instead of atoll in gcov-tool.c

2014-11-24 Thread John David Anglin
On 15-Sep-14, at 5:40 AM, Richard Biener wrote: Let's wait for other opinions. We now have implementations of strtol and strtoll in libiberty. So, it's better to use these than atoll. As suggested by Jakub, the patch now falls back to int64_t if the host doesn't have long long. Tested

Re: [PATCH v2] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

2014-11-24 Thread Chen Gang
OK, thank you for your work, I shall send patch v3 for it. Send from Lenovo A788t. Joseph Myers wrote: >On Sun, 23 Nov 2014, Chen Gang wrote: > >> + gcc_assert (wi::fits_to_tree_p(value, integer_type_node)); > >Watch formatting: space before '(' in the wi::fits_to_tree_p call. >Applies elsew

Re: patch to fix PR63897

2014-11-24 Thread H.J. Lu
On Fri, Nov 21, 2014 at 1:32 PM, Vladimir Makarov wrote: > The following patch fixes PR63897. The details can be found on > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63897 > > The patch was successfully bootstrapped and tested on x86 and x86-64. > > Committed as rev. 217947. > > 2014-11-21

[PATCH] Add verify_sese

2014-11-24 Thread Tom de Vries
Richard, I ran into a problem with my oacc kernels directive patch series where tail-merge added another entry into a region that was previously single-entry-single-exit. That resulted in hitting this assert in calc_dfs_tree: ... /* This aborts e.g. when there is _no_ path from ENTRY to EXI

Re: [PATCH v2] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

2014-11-24 Thread Joseph Myers
On Sun, 23 Nov 2014, Chen Gang wrote: > + gcc_assert (wi::fits_to_tree_p(value, integer_type_node)); Watch formatting: space before '(' in the wi::fits_to_tree_p call. Applies elsewhere in this patch as well. When making such an interface change, (a) you should update the comment on builtin_

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-24 Thread Sebastian Pop
Jeff Law wrote: > On 11/23/14 15:22, Sebastian Pop wrote: > >Jeff Law wrote: > >>>PS: I have run some perf analysis with the patch: > >>>- on a bootstrap of GCC I see 3209 FSM jump threads > >>>- libpng and libjpeg contain FSM jump threads, the perf increase is in the > >>>1% > >>> (measured on

[committed] Replace abort instruction with __builtin_trap() in config/pa/linux_atomic.c

2014-11-24 Thread John David Anglin
The attached change uses __builtin_trap() instead of an asm as the compiler can better optimize code using __builtin_trap. Tested on hppa-unknown-linux-gnu. Committed to trunk. Dave -- John David Anglin dave.ang...@bell.net 2014-11-24 John David Anglin * config/pa/linux-at

[PATCH] Fix building of gengtype

2014-11-24 Thread Jakub Jelinek
Hi! My last 2 bootstraps failed, both because of a race while building host gengtype (each time different gengtype*.o). Looking at the history, we have two versions of gengtype, one in build/, another one in . (host one). Initially, the copy in build/ was built with -DGENERATOR_FILE, included bco

Re: [Patch, Fortran] Remove gfc_fatal_error_1

2014-11-24 Thread Tobias Burnus
Tobias Burnus wrote: It converts the remaining fatal error calls to the common diagnostic infrastructure and retires (removes) the old gfc_fatal_error_1. I will build and regtest it after Manuel's commit. OK, when it succeeds? The patch needed additionally a '...' added in two test-suite file

[PATCH] Fix find_base_term in 32-bit -fpic code (PR lto/64025)

2014-11-24 Thread Jakub Jelinek
Hi! The fallback delegitimization I've added as last option mainly for debug info purposes, when we don't know if the base is a PIC register or say a PIC register plus some addend, unfortunately in some tests broke find_base_term, which for PLUS looks only at the first operand and recursion on it

[PATCH] Fix linemap_line_start (PR preprocessor/60436)

2014-11-24 Thread Jakub Jelinek
Hi! As mentioned in the PR, when preprocessing very large files, if there are huge numbers of lines where no #line is emitted, we might not detect overflowinging into adhoc locations. Apparently in the add_map case we already handle that fine, by first stopping tracking columns and after another 2

[committed] Fix !$omp atomic handling (PR fortran/63938)

2014-11-24 Thread Jakub Jelinek
Hi! This fixes Fortran !$omp atomic handling to match C/C++, goa_lhs_expr_p is not able to find out matches of more complex expressions after tree unsharing, so this patch helps it find what it needs. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. Will backport soon.

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-24 Thread Jeff Law
On 11/23/14 15:22, Sebastian Pop wrote: Jeff Law wrote: PS: I have run some perf analysis with the patch: - on a bootstrap of GCC I see 3209 FSM jump threads - libpng and libjpeg contain FSM jump threads, the perf increase is in the 1% (measured on simulators and reduced data sets) - coremark

Re: PR 13631 Problems in messages

2014-11-24 Thread François Dumont
On 24/11/2014 01:23, Jonathan Wakely wrote: On 24/11/14 00:13 +0100, François Dumont wrote: Hello As we are at doing some evolution in the ABI I would like to take the opportunity to merge branch libstdcxx_so_7-2. The first fix was I don't think we want to merge everything, but it's cert

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-24 Thread Jeff Law
On 11/24/14 15:05, Sebastian Pop wrote: I did an experiment around these lines over the week-end, and now that you mention it, I feel less shy to speak about; well the patch does not yet pass bootstrap, and there still are about 20 failing test-cases. I feel better reading the code generation p

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-24 Thread Sebastian Pop
Sebastian Pop wrote: > > Using a SEME region copier is also something I really wanted to do > > long term. In fact, I believe a lot of tree-ssa-threadupdate.c > > ought to be ripped out and replaced with a SEME based copier. > > I did an experiment around these lines over the week-end, and now th

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-24 Thread Sebastian Pop
Jeff Law wrote: > On 11/23/14 15:22, Sebastian Pop wrote: > >The second patch attached limits the search for FSM jump threads to loops. > >With > >that patch, we are now down to 470 jump threads in an x86_64-linux bootstrap > >(and 424 jump threads on powerpc64-linux bootstrap.) > > > Yea, that w

Re: [PATCH/TopLevel] Fix compiling libgo with a combined sources

2014-11-24 Thread Jeff Law
On 11/22/14 21:20, Andrew Pinski wrote: Hi, The problem here is here is that OBJCOPY is not being set to the newly built objcopy when compiling libgo. This patch adds OBJCOPY_FOR_TARGET to the toplevel configure/Makefile so that when libgo is compiled OBJCOPY is set to OBJCOPY_FOR_TARGET. I

Re: [PATCH, ciklplus]: Use -ffloat-store for 32bit x86 in cilk-plus/AN/builtin_fn_{custom,mutating}.c

2014-11-24 Thread Jeff Law
On 11/22/14 11:50, Uros Bizjak wrote: Hello! These two tests fix PR target/63847 [1], where x87 excess precision causes testcase to fail. The problem was triggered by -fpic, please see the PR for analysis. The patch adds -ffloat-store for 32bit x86 target, a standard and well tested solution fo

Re: [Android] Enable ifuncs on Android

2014-11-24 Thread Jeff Law
On 11/24/14 02:49, Alexander Ivchenko wrote: *ping* thanks, Alexander Can you put a reference to the actual patch you want to ping (or just attach the patch you want to ping)? I'll review given the updated context/changes from HJ. jeff

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-24 Thread Jeff Law
On 11/23/14 15:22, Sebastian Pop wrote: The second patch attached limits the search for FSM jump threads to loops. With that patch, we are now down to 470 jump threads in an x86_64-linux bootstrap (and 424 jump threads on powerpc64-linux bootstrap.) Yea, that was one of the things I was going t

Re: [PATCH, PR 63551] Use proper type in evaluate_conditions_for_known_args

2014-11-24 Thread Richard Biener
On November 24, 2014 7:12:01 PM CET, Martin Jambor wrote: >On Sat, Nov 22, 2014 at 07:36:59PM +0100, Richard Biener wrote: >> On November 22, 2014 12:45:58 PM CET, Jakub Jelinek > wrote: >> >On Sat, Nov 22, 2014 at 12:09:46PM +0100, Martin Jambor wrote: >> >> 2014-11-21 Martin Jambor >> >> >>

Re: Merging configure bits with Binutils

2014-11-24 Thread Jeff Law
On 11/24/14 09:52, Jan-Benedict Glaw wrote: On Mon, 2014-11-24 09:42:57 -0700, Jeff Law wrote: On 11/23/14 00:31, Jan-Benedict Glaw wrote: This is my current patch series for GCC to merge all the config bits from Binutils. It's not yet testet, but I'd like to post it early to get feedback. Tha

Re: [patch] Restore bootstrap on powerpc*-apple-darwin*

2014-11-24 Thread Iain Sandoe
On 24 Nov 2014, at 17:02, FX wrote: > Bootstrap is currently broken on ppc-darwin due to PR63703 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63703). > This is also broken on 4.9, and actually made it into the 4.9.2 release. > > This patch fixes it, restores bootstrap (well, it gets cc1 to b

Re: [PATCH 9/9] ipa-inline uses sreal for as fibonacci_heap template argument.

2014-11-24 Thread H.J. Lu
On Thu, Nov 13, 2014 at 12:10 PM, mliska wrote: > gcc/ChangeLog: > > 2014-11-13 Martin Liska > > * ipa-inline.c (edge_badness): long is replaced by sreal > as fibonacci_heap template type. > (update_edge_key): Likewise. > (inline_small_functions): Likewise. This

[C++ Patch/RFC] PR 63757

2014-11-24 Thread Paolo Carlini
Hi, in this rejects-valid, as part of build_user_type_conversion_1, standard_conversion is called by implicit_conversion with a *null* expr, thus the condition in standard_conversion /* [conv.ptr] A null pointer constant can be converted to a pointer type; ... A null pointer const

Re: [PATCH] Fix dump scan in test devirt-40.C

2014-11-24 Thread H.J. Lu
On Mon, Nov 24, 2014 at 10:41 AM, Paolo Carlini wrote: > Hi again, > > > On 11/24/2014 07:33 PM, Paolo Carlini wrote: >> >> Hi, >> >> On 11/12/2014 03:02 AM, H.J. Lu wrote: >>> >>> I am checking in this. >> >> Looks like devirt-42.C is failing again and reverting your tweak would fix >> it?!? > >

Re: [PATCH] Fix dump scan in test devirt-40.C

2014-11-24 Thread Paolo Carlini
Hi again, On 11/24/2014 07:33 PM, Paolo Carlini wrote: Hi, On 11/12/2014 03:02 AM, H.J. Lu wrote: I am checking in this. Looks like devirt-42.C is failing again and reverting your tweak would fix it?!? Sorry, in fact now the line failing is "First type is base of second" 3, a different one.

Re: [PATCH] Fix dump scan in test devirt-40.C

2014-11-24 Thread Paolo Carlini
Hi, On 11/12/2014 03:02 AM, H.J. Lu wrote: I am checking in this. Looks like devirt-42.C is failing again and reverting your tweak would fix it?!? Thanks, Paolo.

Re: [PATCH, 8/8] Do simple omp lowering for no address taken var

2014-11-24 Thread Tom de Vries
On 24-11-14 13:12, Richard Biener wrote: On Mon, 24 Nov 2014, Tom de Vries wrote: On 24-11-14 12:28, Tom de Vries wrote: On 17-11-14 11:13, Richard Biener wrote: On Sat, 15 Nov 2014, Tom de Vries wrote: On 15-11-14 13:14, Tom de Vries wrote: Hi, I'm submitting a patch series with initial

Re: [PATCH] [AArch64, RTL] Bics instruction generation for aarch64

2014-11-24 Thread Alex Velenko
On 11/11/14 10:38, Alex Velenko wrote: From 98bb6d7323ce79e28be8ef892b919391ed857e1f Mon Sep 17 00:00:00 2001 From: Alex Velenko Date: Fri, 31 Oct 2014 18:43:32 + Subject: [PATCH] [AArch64, RTL] Bics instruction generation for aarch64 Hi, This patch adds rtl patterns for aarch64 to genera

Re: [PATCH, PR 63551] Use proper type in evaluate_conditions_for_known_args

2014-11-24 Thread Martin Jambor
On Sat, Nov 22, 2014 at 07:36:59PM +0100, Richard Biener wrote: > On November 22, 2014 12:45:58 PM CET, Jakub Jelinek wrote: > >On Sat, Nov 22, 2014 at 12:09:46PM +0100, Martin Jambor wrote: > >> 2014-11-21 Martin Jambor > >> > >>PR ipa/63551 > >>* ipa-inline-analysis.c (evaluate_condi

Re: Pushing recent libtool fix to binutils-gdb and newlib/libgloss

2014-11-24 Thread FX
> Done: > https://sourceware.org/ml/binutils/2014-11/msg00318.html Thanks!

Re: [PATCH] Don't unilaterally include when checking for fpsetmask

2014-11-24 Thread FX
>> The attached change fixes the build of libgfortran on hppa1.1-hp-hpux10.20 >> (I know I'm going >> for the oldest system that will build gfortran). OK

[PATCH/AARCH64] make bswap vector consistent with scalar name

2014-11-24 Thread Andrew Pinski
I had some local patches in my tree which adds a bswap tree code. This breaks the aarch64 back-end vectorizing of byteswaps as we use the standard mechanism to see if a tree code vectorizes (optabs). Since it make sense to have consistent of the pattern names between the vector version and the scal

Re: [patch] Define new std::ios_base::failure with abi_tag("cxx11")

2014-11-24 Thread Tom de Vries
On 24-11-14 18:12, Jonathan Wakely wrote: On 24/11/14 17:48 +0100, Tom de Vries wrote: On 14-11-14 13:18, Jonathan Wakely wrote: This adds system_error support to iostreams, including the required base class changes to std::ios_base::failure. The abi_tag is used to make it a distinct type. Thi

Re: [PATCH] Don't unilaterally include when checking for fpsetmask

2014-11-24 Thread John David Anglin
On 8/7/2014 4:22 PM, John David Anglin wrote: The attached change fixes the build of libgfortran on hppa1.1-hp-hpux10.20 (I know I'm going for the oldest system that will build gfortran). OK? Ping. Dave -- John David Anglindave.ang...@bell.net

Re: Pushing recent libtool fix to binutils-gdb and newlib/libgloss

2014-11-24 Thread H.J. Lu
Done: https://sourceware.org/ml/binutils/2014-11/msg00318.html On Mon, Nov 24, 2014 at 9:04 AM, FX wrote: > *ping* > > Didn’t get any response to my question so far… > > >>> Thanks everyone for the comments and review. >>> Committed as r217366 >> >> I cannot push the change to binutils-gdb as I

Re: [patch] Define new std::ios_base::failure with abi_tag("cxx11")

2014-11-24 Thread Jonathan Wakely
On 24/11/14 17:48 +0100, Tom de Vries wrote: On 14-11-14 13:18, Jonathan Wakely wrote: This adds system_error support to iostreams, including the required base class changes to std::ios_base::failure. The abi_tag is used to make it a distinct type. This changes the type of I/O exceptions thrown

Go patch committed: Don't deref named pointer type for method

2014-11-24 Thread Ian Lance Taylor
This patch by Chris Manghane fixes the Go compiler to not dereference a named pointer type when looking up a method. Before this patch that could happen if the pointer type pointed to a struct with an inherited method. This is http://golang.org/issue/9018. Bootstrapped and ran testsuite on x86_6

Pushing recent libtool fix to binutils-gdb and newlib/libgloss

2014-11-24 Thread FX
*ping* Didn’t get any response to my question so far… >> Thanks everyone for the comments and review. >> Committed as r217366 > > I cannot push the change to binutils-gdb as I don’t have write access there. > Also, Joseph Myers said I needed to commit to newlib/libgloss, but their > webpage on

[patch] Restore bootstrap on powerpc*-apple-darwin*

2014-11-24 Thread FX
Bootstrap is currently broken on ppc-darwin due to PR63703 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63703). This is also broken on 4.9, and actually made it into the 4.9.2 release. This patch fixes it, restores bootstrap (well, it gets cc1 to build, at least… I don’t have a ppc to test the

Re: [PATCH 3/3] remove gengtype support for param_is use_param, if_marked and splay tree allocators

2014-11-24 Thread Jeff Law
On 11/23/14 21:11, tsaund...@mozilla.com wrote: From: Trevor Saunders Hi, The one interesting part of this is what we do about plugins. As you can tell from the diff removing support for these gengtype features makes things much simpler, and I think the only way to do that is to remove the pl

Re: [PING][PATCH] Change contrib/test_installed for testing cross compilers

2014-11-24 Thread Alan Lawrence
Having just been experimenting with testing of installed compilers - yes something like this could be useful, however: to do cross-testing I found I also (a) had to set my target_list; so either an extra flag for that, or maybe just a generic 'extra_site_flags' parameter? (b) I had to set up som

Re: Merging configure bits with Binutils

2014-11-24 Thread Jan-Benedict Glaw
On Mon, 2014-11-24 09:42:57 -0700, Jeff Law wrote: > On 11/23/14 00:31, Jan-Benedict Glaw wrote: > > This is my current patch series for GCC to merge all the config > > bits from Binutils. It's not yet testet, but I'd like to post it > > early to get feedback. That way, I hope to not forget someth

Re: [patch] Define new std::ios_base::failure with abi_tag("cxx11")

2014-11-24 Thread Tom de Vries
On 14-11-14 13:18, Jonathan Wakely wrote: This adds system_error support to iostreams, including the required base class changes to std::ios_base::failure. The abi_tag is used to make it a distinct type. This changes the type of I/O exceptions thrown by the library but exceptions are very rarely

Re: [PATCH 1/3] remove param_is from nvptx

2014-11-24 Thread Jeff Law
On 11/23/14 21:11, tsaund...@mozilla.com wrote: From: Trevor Saunders Hi, $subject Trev gcc/ * config/nvptx/nvptx.c: Convert htabs to hash_table. This is fine and I think can go in now rather than waiting for the next stage1. It's an obvious cleanup and one could argue I should ha

Re: [PATCH RFC 4/4] Regenerate ./configure

2014-11-24 Thread Jeff Law
On 11/23/14 00:33, Jan-Benedict Glaw wrote: 2014-11-22 Jan-Benedict Glaw * configure: Regenerate. OK. jeff

Re: [PATCH] Fix regressions in libgomp testsuite: set flag_fat_lto_objects for offload

2014-11-24 Thread Ilya Verbin
On 17 Nov 10:57, Richard Biener wrote: > On Fri, Nov 14, 2014 at 6:08 PM, Ilya Verbin wrote: > > On 14 Nov 09:01, H.J. Lu wrote: > >> On Fri, Nov 14, 2014 at 8:51 AM, Ilya Verbin wrote: > >> > On 14 Nov 08:46, H.J. Lu wrote: > >> >> What happens when -flto is used on command line? Will we > >> >

Re: [PATCH RFC 3/4] Merge the ./config directory between GCC and Binutils

2014-11-24 Thread Jeff Law
On 11/23/14 00:33, Jan-Benedict Glaw wrote: This pulls in the missing Binutils pieces into the ./config directory. Contains these missing Binutils changes: 2014-08-14 Alan Modra * plugins.m4: Test for dlfcn.h or windows.h here to set default for --enable-plugins. Report erro

Re: [PATCH RFC 1/4] Merge ./configure.ac with Binutils

2014-11-24 Thread Jeff Law
On 11/23/14 00:33, Jan-Benedict Glaw wrote: GCC and Binutils had a common ./configure.ac after this commit: commit 08d081652f50df83f7e9768f8dbb7a99b0df50a2 Author: sandra Date: Wed May 14 23:20:59 2014 + 2014-05-14 Sandra Loosemore * co

Re: Merging configure bits with Binutils

2014-11-24 Thread Jeff Law
On 11/23/14 00:31, Jan-Benedict Glaw wrote: Hi! This is my current patch series for GCC to merge all the config bits from Binutils. It's not yet testet, but I'd like to post it early to get feedback. That way, I hope to not forget something obvious. FWIW, one could easily argue this should be a

Re: [C++ PATCH] Detect UB in shifts in constexpr functions

2014-11-24 Thread Marek Polacek
On Mon, Nov 24, 2014 at 05:05:08PM +0100, Jakub Jelinek wrote: > On Mon, Nov 24, 2014 at 04:58:22PM +0100, Marek Polacek wrote: > > > Consider say: > > > > > > constexpr int p = 1; > > > constexpr int foo (int a) > > > { > > > return a << (int) &p; > > > } > > > constexpr int bar (int a) > > > {

Re: Track dynamic type changes

2014-11-24 Thread H.J. Lu
On Sun, Oct 5, 2014 at 9:34 AM, Jan Hubicka wrote: > Hi, > this patch makes ipa_polymorphic_call_context::get_dynamic_type to > track if vptr has changed in between function entry and polymorphic > call. > > The patch also add logic skipping if (a==0) checks in multiple > inheritance so I can cons

Improve inliner's handling of aliases

2014-11-24 Thread Jan Hubicka
Hi, the original update of inliner for aliases contined some lazyness. This patch fixes I think last remainder of it where inliner did not remove symbol with aliases on it. This is more important now when ICF uses aliases quite often. Bootstrapped/regtested x86_64-linux, comitted. PR ipa

Re: [C++ PATCH] Detect UB in shifts in constexpr functions

2014-11-24 Thread Jakub Jelinek
On Mon, Nov 24, 2014 at 04:58:22PM +0100, Marek Polacek wrote: > > Consider say: > > > > constexpr int p = 1; > > constexpr int foo (int a) > > { > > return a << (int) &p; > > } > > constexpr int bar (int a) > > { > > return ((int) &p) << a; > > } > > constexpr int q = foo (5); > > constexpr i

Re: [C++ PATCH] Detect UB in shifts in constexpr functions

2014-11-24 Thread Marek Polacek
On Mon, Nov 24, 2014 at 04:49:25PM +0100, Jakub Jelinek wrote: > On Mon, Nov 24, 2014 at 02:51:14PM +0100, Marek Polacek wrote: > > --- gcc/cp/constexpr.c > > +++ gcc/cp/constexpr.c > > @@ -1451,6 +1451,43 @@ verify_constant (tree t, bool allow_non_constant, > > bool *non_constant_p, > >return

Re: [PING**4] [PATCH] Fix PR ipa/61190, 2nd edition�??

2014-11-24 Thread Jan Hubicka
+cgraph_node::call_for_symbol_thunks_and_aliases_1 (bool (*callback) +(cgraph_node *, void *), + void *data, + bool include_overwritable, +

Re: [C++ PATCH] Detect UB in shifts in constexpr functions

2014-11-24 Thread Jakub Jelinek
On Mon, Nov 24, 2014 at 02:51:14PM +0100, Marek Polacek wrote: > --- gcc/cp/constexpr.c > +++ gcc/cp/constexpr.c > @@ -1451,6 +1451,43 @@ verify_constant (tree t, bool allow_non_constant, bool > *non_constant_p, >return *non_constant_p; > } > > +/* Return true if the shift operation on LHS

Re: [RS6000] Fix -mlongcall with nested functions on AIX

2014-11-24 Thread David Edelsohn
[Please explicitly copy me on relevant patches] 2014-10-17 Eric Botcazou * config/rs6000/rs6000.c (rs6000_call_aix): For the AIX ABI, do not load the static chain if the call was originally direct. 2014-10-17 Eric Botcazou * gcc.target/powerpc/longcall-2.c: New test. Okay. Thanks, Davi

Re: [PATCH] Improve i?86 address delegitimization after 32-bit pic changes (PR target/63542)

2014-11-24 Thread H.J. Lu
On Tue, Oct 21, 2014 at 9:03 AM, Jakub Jelinek wrote: > On Mon, Sep 29, 2014 at 01:08:56PM +0200, Jakub Jelinek wrote: >> I wonder if during/after reload we just couldn't look at >> ORIGINAL_REGNO of hard regs if ix86_use_pseudo_pic_reg. Or is that >> the other case, where you don't have any PIC

[C PATCH] Fix PR63877

2014-11-24 Thread Marek Polacek
This PR is basically the same as PR54113, except this time it's about -Wmissing-declarations and not about -Wmissing-prototypes. The problem here is that we were emitting bogus warning for a correct use of an inline function. Thus fixed in the same way as PR54113, that is, don't warn for inline f

Re: [PATCH RFC]Pair load store instructions using a generic scheduling fusion pass

2014-11-24 Thread James Greenhalgh
On Fri, Nov 14, 2014 at 02:43:12AM +, Bin.Cheng wrote: > On Fri, Nov 7, 2014 at 7:13 AM, Jeff Law wrote: > > On 11/05/14 02:30, Bin.Cheng wrote: > >> Thanks very much for reviewing. I refined the patch according to your > >> comments. Also made two small changes: a) skip breaking dependency

Re: [PATCH, MPX wrappers 2/3] Replace some function calls with wrapper calls during instrumentation

2014-11-24 Thread Ilya Enkovich
On 18 Nov 19:42, Ilya Enkovich wrote: > On 18 Nov 16:23, Joseph Myers wrote: > > On Tue, 18 Nov 2014, Ilya Enkovich wrote: > > > > > +@item -fcheck-pointer-bounds > > > +@opindex fcheck-pointer-bounds > > > +@opindex fno-check-pointer-bounds > > > +Enable Pointer Bounds Checker instrumentation. E

Re: [PATCH, MPX wrappers 1/3] Add MPX wrappers library

2014-11-24 Thread Ilya Enkovich
On 21 Nov 23:32, Joseph Myers wrote: > On Fri, 21 Nov 2014, Ilya Enkovich wrote: > > > * c-family/c.opt (static-libmpxwrappers): New. > > New options need documenting in invoke.texi. This includes driver > options. > I'll include it into patch with all checker options documented bacause of

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-24 Thread Ilya Enkovich
On 21 Nov 23:20, Joseph Myers wrote: > On Fri, 21 Nov 2014, Ilya Enkovich wrote: > > > +# Disable libmpx on unsupported systems. > > +if test -d ${srcdir}/libmpx; then > > +if test x$enable_libmpx = x; then > > + AC_MSG_CHECKING([for libmpx support]) > > + if (srcdir=${srcdir}/libm

RE: [PATCH] Work around in-tree gmp configure problems

2014-11-24 Thread Bernd Edlinger
Hi Richard, On Mon, 24 Nov 2014 14:11:19 +0100, Jan-Benedict Glaw wrote: > > Hi Richard, > > On Mon, 2014-11-24 12:53:11 +0100, Richard Biener > wrote: >> On Sat, Nov 22, 2014 at 4:34 PM, Jan-Benedict Glaw wrote: >>> On Sat, 2014-11-22 14:33:29 +0100, Bernd Edlinger >>> wrote: since r2

[C++ PATCH] Detect UB in shifts in constexpr functions

2014-11-24 Thread Marek Polacek
Constant expressions can't contain undefined behavior, which means that using an expression containing UB in a context requiring a constant expression makes the program invalid and we're required to diagnose that. We fail to diagnose UB if using shifts, because fold_binary_loc returns zero for a sh

[PATCH] check_GNU_style.sh "80 characters exceeded" error fix

2014-11-24 Thread Mantas Mikaitis
check_GNU_style.sh error "Lines should not exceed 80 characters" does not return the file name and line number where error is present, only the line of code. Whereas other kind of errors return full information. This small patch will fix this and make check_GNU_style.sh return full information

RE: [PATCH] AArch64: Add TARGET_SCHED_REASSOCIATION_WIDTH

2014-11-24 Thread Wilco Dijkstra
> Richard Earnshaw wrote: > If all cores seem to benefit from FP reassociation set to 4, then it > seems odd that 4 is not also the default for generic. > > Andrew, you may need to pick a target-specific value for ThunderX; I > think Wilco has just picked something that seems plausible because he

[Patch, Fortran] Move gfc_internal_error to common diagnostics

2014-11-24 Thread Tobias Burnus
Dear all, this patch uses the common diagnostic code for gfc_internal_error; the change is essentially only in error.c, but I additionally changed: * Use gfc_fatal_error for the user-reachable message: if (gfc_option.flag_allow_leading_underscore && letter == '_') gfc_internal_error ("Opt

Re: [Patch, Fortran] Remove gfc_fatal_error_1

2014-11-24 Thread H.J. Lu
On Sun, Nov 23, 2014 at 12:21 PM, Tobias Burnus wrote: > This patch depends on Manuel's %L patch. > > It converts the remaining fatal error calls to the common diagnostic > infrastructure and retires (removes) the old gfc_fatal_error_1. > > I will build and regtest it after Manuel's commit. > OK,

Re: [PATCH/TopLevel] Fix compiling libgo with a combined sources

2014-11-24 Thread Jan-Benedict Glaw
Hi Andrew, On Sat, 2014-11-22 20:20:08 -0800, Andrew Pinski wrote: > Hi, > The problem here is here is that OBJCOPY is not being set to the > newly built objcopy when compiling libgo. This patch adds > OBJCOPY_FOR_TARGET to the toplevel configure/Makefile so that when > libgo is compiled OBJCO

Re: [PATCH] Work around in-tree gmp configure problems

2014-11-24 Thread Jan-Benedict Glaw
Hi Richard, On Mon, 2014-11-24 12:53:11 +0100, Richard Biener wrote: > On Sat, Nov 22, 2014 at 4:34 PM, Jan-Benedict Glaw wrote: > > On Sat, 2014-11-22 14:33:29 +0100, Bernd Edlinger > > wrote: > > > since r217627 we use an updated AutoMake "missing" script. However > > > that revealed a hid

Re: [C++ Patch] PR 63203

2014-11-24 Thread Jason Merrill
OK. Jason

Re: C++ PATCH for c++/63942 (mangling compat alias problems)

2014-11-24 Thread Jason Merrill
On 11/21/2014 04:32 PM, Jason Merrill wrote: In this testcase, the wrong old mangling for one constructor matches the correct mangling for the other constructor, and the testcase was failing to compile as a result. But compatibility aliases should not be treated as conflicting with real declarat

Re: [PATCH] Fix PR64044

2014-11-24 Thread Andrew Haley
On 11/24/2014 12:29 PM, Richard Biener wrote: > > The following fixes an issue I found when more aggressively > constant-folding from static initializers. The Java frontend > fails to provide an initializer for the classdollar field > it creates but nevertheless marks them with TREE_READONLY > w

Re: [RFC,PATCH,testsuite] Set gcc_force_conventional_output even without LTO linker plugin

2014-11-24 Thread Richard Biener
On Mon, Nov 24, 2014 at 1:40 PM, Matthew Fortune wrote: > Richard Biener writes: >> On Sun, Nov 23, 2014 at 10:15 AM, Matthew Fortune >> wrote: >> > Hi, >> > >> > I have had to use this patch several times when performing cross testing >> > but I'm not sure if it is the right fix. The MIPS targe

RE: [RFC,PATCH,testsuite] Set gcc_force_conventional_output even without LTO linker plugin

2014-11-24 Thread Matthew Fortune
Richard Biener writes: > On Sun, Nov 23, 2014 at 10:15 AM, Matthew Fortune > wrote: > > Hi, > > > > I have had to use this patch several times when performing cross testing > > but I'm not sure if it is the right fix. The MIPS target testsuite runs > > all tests regardless of the current compiler

[PATCH] Fix PR64044

2014-11-24 Thread Richard Biener
The following fixes an issue I found when more aggressively constant-folding from static initializers. The Java frontend fails to provide an initializer for the classdollar field it creates but nevertheless marks them with TREE_READONLY whilst being static. Thus the following patch removes sett

Re: [PATCH, 8/8] Do simple omp lowering for no address taken var

2014-11-24 Thread Richard Biener
On Mon, 24 Nov 2014, Tom de Vries wrote: > On 24-11-14 12:28, Tom de Vries wrote: > > On 17-11-14 11:13, Richard Biener wrote: > > > On Sat, 15 Nov 2014, Tom de Vries wrote: > > > > > > > >On 15-11-14 13:14, Tom de Vries wrote: > > > > > > >Hi, > > > > > > > > > > > > > >I'm submitting a patch se

Re: [PATCH, 8/8] Do simple omp lowering for no address taken var

2014-11-24 Thread Richard Biener
On Mon, 24 Nov 2014, Tom de Vries wrote: > On 17-11-14 11:13, Richard Biener wrote: > > On Sat, 15 Nov 2014, Tom de Vries wrote: > > > > > >On 15-11-14 13:14, Tom de Vries wrote: > > > > > >Hi, > > > > > > > > > > > >I'm submitting a patch series with initial support for the oacc > > > > kernels

Re: [PATCH 2/3] move gimple_canonical_types htab out of gc memory

2014-11-24 Thread Richard Biener
On Mon, Nov 24, 2014 at 5:11 AM, wrote: > From: Trevor Saunders > > Hi, > > The memory allocated for the hash table is never rooted by anything, so > keeping > it in gc memory only works if it never needs to survive a gc. Ok. Thanks, Richard. > Trev > > lto/ > > * lto.c (read_cgraph_

Re: [RFC,PATCH,testsuite] Set gcc_force_conventional_output even without LTO linker plugin

2014-11-24 Thread Richard Biener
On Sun, Nov 23, 2014 at 10:15 AM, Matthew Fortune wrote: > Hi, > > I have had to use this patch several times when performing cross testing > but I'm not sure if it is the right fix. The MIPS target testsuite runs > all tests regardless of the current compiler configuration and downgrades > run te

Re: [PATCH/TopLevel] Fix compiling libgo with a combined sources

2014-11-24 Thread Richard Biener
On Sun, Nov 23, 2014 at 5:20 AM, Andrew Pinski wrote: > Hi, > The problem here is here is that OBJCOPY is not being set to the > newly built objcopy when compiling libgo. This patch adds > OBJCOPY_FOR_TARGET to the toplevel configure/Makefile so that when > libgo is compiled OBJCOPY is set to O

Re: [PATCH] Improve shrink wrap for lo_sum

2014-11-24 Thread Richard Biener
On Sun, Nov 23, 2014 at 5:09 AM, Andrew Pinski wrote: > Hi, > As discussed at > https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00997.html, this is the > one line patch which improves shrink wrapping for lo_sum. > > OK? Bootstrapped and tested on x86_64 and built and tested for > aarch64-elf with

Re: [PATCH] Work around in-tree gmp configure problems

2014-11-24 Thread Richard Biener
On Sat, Nov 22, 2014 at 4:34 PM, Jan-Benedict Glaw wrote: > Hi! > > On Sat, 2014-11-22 14:33:29 +0100, Bernd Edlinger > wrote: >> since r217627 we use an updated AutoMake "missing" script. However >> that revealed a hidden bug in gmp-4.3.2's (up to gmp-6.0.0a) >> configure script. That is: an

  1   2   >