Re: [PATCH] PR libstdc++/60132, implement the remaining C++11 is_trivially_* traits

2014-10-08 Thread Ville Voutilainen
On 9 October 2014 01:45, Jonathan Wakely wrote: > Some of the tests have copyright dates of 2012-2014 - I think they > should be just 2014, even if you copied existing files. Some of them also had 010 as the month. :) > > Please break the ChangeLog entries to fit in 80 columns, e.g. > >

Re: Towards GNU11

2014-10-08 Thread Jeff Law
On 10/07/14 15:07, Marek Polacek wrote: Hi! I'd like to kick off a discussion about moving the default standard for C from gnu89 to gnu11. This really shouldn't be much of a surprise: the docs mention that gnu11 is intended future default for a year now. I would presume now is a good time to m

Re: [C PATCH] Don't warn on = { } initialization (PR c/63480)

2014-10-08 Thread Jeff Law
On 10/08/14 06:00, Marek Polacek wrote: PR63480 points out that -Wmissing-field-initializers warns about initializing with { }. Given that we suppress the warning for initializing with { 0 }, I think it makes sense to suppress it for { } as well. (Initializing with { } is a GNU extension and -pe

Re: [PATCH, RTX]: Additional fix for PR 57003

2014-10-08 Thread Jeff Law
On 10/03/14 11:54, Uros Bizjak wrote: Hello! My r215428 change exposed another PR 57003 problem on x86_64. When compiling gcc.target/i386/pr57003.c we refer to clobbered %rdi register after the call to memcpy: --- pr57003.s 2014-10-03 15:08:24.0 +0200 +++ pr57003_.s 2014-10-03 15:08:

Re: RFA: RTL typesafety improvements for ira.c

2014-10-08 Thread Jeff Law
On 10/01/14 17:27, David Malcolm wrote: FWIW, presumably "insn" here also can now be an rtx_insn *? (I'd like to eventually strengthen the params to the note-handling functions, so fixing this up now would help with that). Here's the updated patch to include strengthening insn to rtx_insn *.

C++ PATCH for c++/63485

2014-10-08 Thread Jason Merrill
My recent change to build_cplus_array_type failed to consider typedef variants. Tested x86_64-pc-linux-gnu, applying to trunk. commit f28aac3ccf4b8d4ecea7f34a37dc18ff1a45649a Author: Jason Merrill Date: Wed Oct 8 12:19:38 2014 -0400 PR c++/63485 * tree.c (build_cplus_array_type): L

Re: [PATCH] AutoFDO patch for trunk

2014-10-08 Thread Dehao Chen
Hi, Honza, Sorry for the delay. I just picked up the original patch, and updated it with your comments. I've addressed most of your comments. Something else to discuss inlined. I had refactored the patch to make it much less intrusive. New patch is attached (ChangeLog will be added in the final

[PATCH] move gcov-dump functionality to gcov-tool

2014-10-08 Thread Rong Xu
Hi This patch moves the gcov-dump functionality to gcov-tool (which is installed by default). The options are exactly the same as before. The difference is instead of calling "gcov-dump ...", we now call "gcov-tool dump ..." gcov-dump is useful in debugging fdo issues. I think it would be very he

Re: [PATCH] libgcc: unwind-dw2-fde.h: Use "(const fde *)" instead of "(char *)" to avoid qualifier warning

2014-10-08 Thread Chen Gang
OK, thanks, and after this patch, I shall try to find and send another patch for gcc within this month. Hope I can succeed. Thanks. Send from Lenovo A788t. Richard Henderson wrote: >On 10/08/2014 03:47 AM, Chen Gang wrote: >> It passes "make -k check" under Darwin x86_64. >> >> 2014-10-07 C

[SH][committed] Add missing set of T_REG in SH4A atomic patterns

2014-10-08 Thread Oleg Endo
Hi, Some of the SH4A LL/CS atomic sequences leave the T bit set to 1 after they have finished executing. Somehow this went unnoticed when the patterns were initially added a while a go. Committed as obvious to trunk (r216018), 4.9 (r216019) and 4.8 (216020). Cheers, Oleg gcc/ChangeLog:

Re: [PATCH] PR libstdc++/60132, implement the remaining C++11 is_trivially_* traits

2014-10-08 Thread Jonathan Wakely
On 08/10/14 23:28 +0300, Ville Voutilainen wrote: PR libstdc++/60132 * include/std/type_traits (is_trivially_copyable, is_trivially_constructible, is_trivially_default_constructible, is_trivially_copy_constructible, is_trivially_move_constructible, is_trivially_assignable, is_trivially_copy

Re: [PATCH, Pointer Bounds Checker 14/x] Passes [2/n] IPA passes

2014-10-08 Thread Jan Hubicka
> > I prevent clone's body from removal and therefore original should call > clone (otherwise clone may have no callers and be removed). I think > call edge may work (need to recall other cases when reference do its > work) but is it OK to have call with no stmt for non thunk nodes? OK, I guess

Re: [PATCH, Pointer Bounds Checker 14/x] Passes [2/n] IPA passes

2014-10-08 Thread Jan Hubicka
> 2014-10-08 23:41 GMT+04:00 Jan Hubicka : > >> +/* Pointer Bounds Checker has two IPA passes to support code > >> instrumentation. > >> + > >> +In instrumented code each pointer is provided with bounds. For input > >> +pointer parameters it means we also have bounds passed. For calls i

Re: [PATCH RFC]Pair load store instructions using a generic scheduling fusion pass

2014-10-08 Thread Jeff Law
On 10/08/14 04:27, Ramana Radhakrishnan wrote: If the port has a splitter to rip apart a douple-word load into single-word loads, then we'd obviously only want to do that in cases where the double-word load actually generates > 1 assembly instruction. Or indeed if it is really a performance w

[PATCH, testsuite] Fix a few vmx tests

2014-10-08 Thread Pat Haugen
The following patch fixes recent failures with the tests after a dg-options string was added to them which prevented the default options from vmx.exp from being used. Committed as obvious. 2014-10-08 Pat Haugen gcc/testsuite: * gcc.dg/vmx/3c-01a.c: Add default options from vmx.exp

Re: [Fortran, Patch] Implement IMPLICIT NONE

2014-10-08 Thread Dominique d'Humières
This is what I have committed as r216016 Index: gcc/testsuite/ChangeLog === --- gcc/testsuite/ChangeLog (revision 216014) +++ gcc/testsuite/ChangeLog (working copy) @@ -1,3 +1,7 @@ +2014-10-08 Dominique d'Humieres + +

Re: __intN patch 3/5: main __int128 -> __intN conversion.

2014-10-08 Thread DJ Delorie
> > if (same_type_p (TYPE_MAIN_VARIANT (t1), long_long_unsigned_type_node) > > || same_type_p (TYPE_MAIN_VARIANT (t2), > > long_long_unsigned_type_node)) > > return build_type_attribute_variant (long_long_unsigned_type_node, > >

Re: [PATCH, Pointer Bounds Checker 14/x] Passes [2/n] IPA passes

2014-10-08 Thread Ilya Enkovich
2014-10-08 23:41 GMT+04:00 Jan Hubicka : >> +/* Pointer Bounds Checker has two IPA passes to support code >> instrumentation. >> + >> +In instrumented code each pointer is provided with bounds. For input >> +pointer parameters it means we also have bounds passed. For calls it >> +me

constexpr and const qual in C++14

2014-10-08 Thread Marc Glisse
Hello, another tiny bit for C++14 constexpr. I tested it on x86_64-linux-gnu together with another patch, so I'll retest it alone to be sure, but it passed. I added 'const' in addition to 'constexpr' for most testcases where it was needed, except for 2 where I explicitly check that const is i

[PATCH] PR libstdc++/60132, implement the remaining C++11 is_trivially_* traits

2014-10-08 Thread Ville Voutilainen
Tested on Linux-X64. Massive thanks to Jason for doing the heavy lifting on the front-end side. 2014-10-08 Ville Voutilainen PR libstdc++/60132 * include/std/type_traits (is_trivially_copyable, is_trivially_constructible, is_trivially_default_constructible, is_trivially_copy_construct

RE: [Patch, MIPS] Cleanup mips header files.

2014-10-08 Thread Matthew Fortune
> 2014-10-08 Steve Ellcey > > * config/mips/mti-linux.h (DRIVER_SELF_SPECS): Change > LINUX64_DRIVER_SELF_SPECS to LINUX_DRIVER_SELF_SPECS OK. I'd agree with obvious here. Matthew

[C++ PAtch] More C++11 and C++14 constexpr work

2014-10-08 Thread Paolo Carlini
Hi, the below tries to make progress on some relatively easy issues I noticed while working on c++/55250. At least: 1- We rejected using declarations and using directives in constructors. 2- In C++14 mode we rejected compound-statements both in constructors and elsewhere (and in C++11 we provi

Re: [RFC: Patch, PR 60102] [4.9/4.10 Regression] powerpc fp-bit ices@dwf_regno

2014-10-08 Thread Maciej W. Rozycki
Ulrich, > > While emitting the location descriptors of multiple registers (SPE high/low > > part) individually, the GCC hard register number is converted in to DWARF > > register number using "dbx_reg_number" [Statement "A", "B" & "C" below]. > > > But statement "C" macro "DBX_REGISTER_NUMBER" g

Re: [PATCH] add overlap function to gcov-tool

2014-10-08 Thread Jan Hubicka
> On Tue, Oct 7, 2014 at 9:31 PM, Jan Hubicka wrote: > >> Hi, > >> > >> This patch adds overlap functionality to gcov-tool. The overlap score > >> estimates the similarity of two profiles. Currently it only computes > >> overlap for arc counters. > >> > >> The overlap score is defined as > >> \sum

Re: [PATCH, Pointer Bounds Checker 14/x] Passes [2/n] IPA passes

2014-10-08 Thread Jan Hubicka
> +/* Pointer Bounds Checker has two IPA passes to support code > instrumentation. > + > +In instrumented code each pointer is provided with bounds. For input > +pointer parameters it means we also have bounds passed. For calls it > +means we have additional bounds arguments for poi

[PATCH, Pointer Bounds Checker 14/x] Passes [17/n] Add checker passes into passes list

2014-10-08 Thread Ilya Enkovich
Hi, This patch adds instrumentation passes into passes list. Thanks, Ilya -- gcc/ 2014-10-08 Ilya Enkovich * passes.def (pass_ipa_chkp_versioning): New. (pass_early_local_passes): Renamed to pass_build_ssa_passes. (pass_fixup_cfg): Moved to pass_chkp_instrumentation_p

[PATCH, Pointer Bounds Checker 14/x] Passes [16/n] Reduce bounds lifetime

2014-10-08 Thread Ilya Enkovich
Hi, This patch adds a bounds lifetime reduction into checker optimization. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c (chkp_reduce_bounds_lifetime): New. (chkp_opt_execute): Run bounds lifetime reduction algorithm. diff --git a/gcc/tree-chkp.c b/gcc/tree-

[PATCH, Pointer Bounds Checker 14/x] Passes [15/n] Optimize redundant checks

2014-10-08 Thread Ilya Enkovich
Hi, This patch adds removal of redundant (covered by other) checks into checker optimization. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c (chkp_compare_checks): New. (chkp_remove_redundant_checks): New. (chkp_opt_execute): Run redundant checks removal

[PATCH, Pointer Bounds Checker 14/x] Passes [14/n] Optimize constant checks

2014-10-08 Thread Ilya Enkovich
Hi, This patch adds a removal of checks known to always pass into checker optimization. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c (chkp_remove_check_if_pass): New. (chkp_remove_constant_checks): New. (chkp_opt_execute): Run constant check removal

[PATCH, Pointer Bounds Checker 14/x] Passes [13/n] Optimize bounds intersections

2014-10-08 Thread Ilya Enkovich
Hi, This patch adds removal of unnecessary intersections into checker optimizations. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c (chkp_release_check_info): New. (chkp_init_check_info): New. (chkp_gather_checks_info): New. (chkp_get_check_result): New

[PATCH, Pointer Bounds Checker 14/x] Passes [12/n] Optimize string functions

2014-10-08 Thread Ilya Enkovich
Hi, This patch introduces simple optimization of string function calls using variants with no checks and/or bounds copy when possible. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c (check_infos): New. (chkp_get_nobnd_fndecl): New. (chkp_get_nochk_fndecl): New

[PATCH, Pointer Bounds Checker 14/x] Passes [11/n] Optimization helpers

2014-10-08 Thread Ilya Enkovich
Hi, This patch introduces structures and manipulation functions used by simple checker optimizations. Structures are used to hold checks information - type of check and checked address in a polinomial form. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c (check_type): New.

[PATCH, Pointer Bounds Checker 14/x] Passes [10/n] Stores handler

2014-10-08 Thread Ilya Enkovich
Hi, This patch adds an assignment processing function which is used by lnliner for newly generated stores. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c (chkp_copy_bounds_for_assign): New. * tree-chkp.h (chkp_copy_bounds_for_assign): New. diff --git a/gcc/tree-chkp

[PATCH, Pointer Bounds Checker 14/x] Passes [9/n] Static constructors

2014-10-08 Thread Ilya Enkovich
Hi, This patch introduces functions to handle static pointers and static bounds. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c (MAX_STMTS_IN_STATIC_CHKP_CTOR): New. (chkp_ctor_stmt_list): New. (chkp_register_var_initializer): New. (chkp_add_modificatio

[PATCH, Pointer Bounds Checker 14/x] Passes [8/n] Remove useless builtin calls

2014-10-08 Thread Ilya Enkovich
Hi, This patch adds removal of user calls to chkp builtins which become useless after instrumentation. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c (chkp_remove_useless_builtins): New. (chkp_execute): Remove useless calls to Pointer Bounds Checker builtins.

[PATCH, Pointer Bounds Checker 14/x] Passes [7/n] Instrument params

2014-10-08 Thread Ilya Enkovich
Hi, This patch adds bounds initialization for address taken input arguments. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c (chkp_instrument_function): Store bounds for address taken args. diff --git a/gcc/tree-chkp.c b/gcc/tree-chkp.c index 6bbceb0..5443950 100644 -

[PATCH, Pointer Bounds Checker 14/x] Passes [6/n] Instrument calls and returns

2014-10-08 Thread Ilya Enkovich
Hi, This patch adds intrumentation of calls and returns into instrumentation pass. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c (chkp_add_bounds_to_ret_stmt): New. (chkp_replace_address_check_builtin): New. (chkp_replace_extract_builtin): New. (chkp_f

Re: [PATCH] Enhance array types debug info. for Ada

2014-10-08 Thread Pierre-Marie de Rodat
On 10/07/2014 10:29 AM, Jakub Jelinek wrote: But isn't there a risk that you will have PLACEHOLDER_EXPRs (likely for Ada only) in some trees not constructed by the langhook? I mean, DW_OP_push_object_address isn't meaningful in all DWARF contexts, in some it is forbidden, in others there is reall

[PATCH, Pointer Bounds Checker 14/x] Passes [5/n] Replace function pointers

2014-10-08 Thread Ilya Enkovich
Hi, This patch add function pointers replacement into instrumentation pass. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c: Include ipa-chkp.h. (chkp_replace_function_pointer): New. (chkp_replace_function_pointers): New. (chkp_instrument_function): Call

[PATCH, Pointer Bounds Checker 14/x] Passes [4/n] Memory accesses instrumentation

2014-10-08 Thread Ilya Enkovich
Hi, This is the main chunk of instrumentation codes. This patch introduces instrumentation pass which instruments memory accesses. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c (chkp_may_complete_phi_bounds): New. (chkp_may_finish_incomplete_bounds): New. (c

[PATCH, Pointer Bounds Checker 14/x] Passes [3/n] Helper functions

2014-10-08 Thread Ilya Enkovich
Hi, This patch introduces helper functions used by instrumentation. These helpers are used to access local structures, generate typical expressions, vars and statements. I also included local data initializer into this patch. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.c

[PATCH, Pointer Bounds Checker 14/x] Passes [2/n] IPA passes

2014-10-08 Thread Ilya Enkovich
Hi, This patch introduces two IPA passes used by Pointer Bounds Checker. One pass creates clones for instrumentation. The other one transforms unneeded functions into thunks. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * ipa-chkp.c: New. * ipa-chkp.h: New. * Makefile.

[PATCH, Pointer Bounds Checker 14/x] Passes [1/n] Expand interfaces

2014-10-08 Thread Ilya Enkovich
Hi, This patch starts a series which is a result of split of Pointer Bounds Checker patch #14 (Pointer Bounds Checker passes). This patch introduces compiler flags used by checker and helper functions mostly used by expand pass. Thanks, Ilya -- 2014-10-08 Ilya Enkovich * tree-chkp.

Re: [PATCH 2/4] [AARCH64,NEON] Convert arm_neon.h to use new builtins for vld[234](q?)_lane_*

2014-10-08 Thread Charles Baylis
On 26 September 2014 13:47, Tejas Belagod wrote: > If we use type-punning, there are unnecessary spills that are generated > which is also incorrect for BE because of of the way we spill (st1 {v0.16b - > v1.16b}, [sp]) and restore. The implementation without type-punning seems to > give a more opt

Re: [RFC: Patch, PR 60102] [4.9/4.10 Regression] powerpc fp-bit ices@dwf_regno

2014-10-08 Thread David Edelsohn
On Wed, Oct 8, 2014 at 2:09 PM, Ulrich Weigand wrote: > rohitarulraj wrote: > >> I was able to narrow down the issue. > [snip] >> While emitting the location descriptors of multiple registers (SPE high/low >> part) individually, the GCC hard register number is converted in to DWARF >> register num

Re: [RFC: Patch, PR 60102] [4.9/4.10 Regression] powerpc fp-bit ices@dwf_regno

2014-10-08 Thread Ulrich Weigand
rohitarulraj wrote: > I was able to narrow down the issue. [snip] > While emitting the location descriptors of multiple registers (SPE high/low > part) individually, the GCC hard register number is converted in to DWARF > register number using "dbx_reg_number" [Statement "A", "B" & "C" below]. >

Re: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.

2014-10-08 Thread Rainer Orth
Jonathan Wakely writes: > On 08/10/14 16:21 +0200, Rainer Orth wrote: >>I'd already tried that patch before you committed it, and unfortunately >>it didn't help. > > Oh dear. Did you do a clean build, or at least > 'touch libstdc++-v3/src/*/*.cc' to ensure the library sources get > rebuilt? Chan

RFA: AVR: add infrastructure for device packages

2014-10-08 Thread Joern Rennecke
As the steering commitee still hasn't spoken on the maintainership issue, apparently this still has to go the write-after-approval route. The purpose of this patch is to make it possible to add support for new devices (MCUs) to the AVR toolchain, without having to re-build the entire toolchain. T

Re: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.

2014-10-08 Thread Jonathan Wakely
On 08/10/14 16:21 +0200, Rainer Orth wrote: I'd already tried that patch before you committed it, and unfortunately it didn't help. Oh dear. Did you do a clean build, or at least 'touch libstdc++-v3/src/*/*.cc' to ensure the library sources get rebuilt? Changes to headers do not trigger everyt

RE: [Patch, MIPS] Cleanup mips header files.

2014-10-08 Thread Steve Ellcey
Matthew, I just discovered that I dropped one of the files I changed as part of my MIPS header file cleanup patch and so it did not get checked in. This change was part of my testing, I just didn't include it in the patch I submitted and checked in. Is this (hopefully obvious) change OK for check

Re: C++ Patch for c++/60894

2014-10-08 Thread Fabien Chêne
2014-10-07 23:13 GMT+02:00 Jason Merrill : > On 09/24/2014 05:15 PM, Jason Merrill wrote: >> >> On 09/24/2014 05:06 PM, Fabien Chêne wrote: >>> >>> Unfortunately, just stripping the USING_DECL in lookup_and_check_tag >>> does not really work because some diagnotic codes expect the >>> USING_DECL no

[PATCH 2/2] [AARCH64,NEON] Convert arm_neon.h to use new builtins for vld[234](q?)_lane_*

2014-10-08 Thread charles . baylis
From: Charles Baylis This patch replaces the inline assembler implementations of the vld[234](q?)_lane_* intrinsics with new versions which exploit the new builtin functions added in patch 1. Tested (with the rest of the patch series) with make check on aarch64-oe-linux with qemu, and also cause

[PATCH 0/2] [AARCH64,NEON] Improve vld[234](q?)_lane intrinsics v2

2014-10-08 Thread charles . baylis
From: Charles Baylis This patch series converts the vld[234](q?)_lane intrinsics to use builtin functions instead of the previous inline assembler syntax. Changes since v1: . the type-punning to change between the array of vector types and the internal builtin types has been removed, as this i

[PATCH 1/2] [AARCH64,NEON] Add patterns + builtins for vld[234](q?)_lane_* intrinsics

2014-10-08 Thread charles . baylis
From: Charles Baylis This patch adds new patterns and builtins to represent single lane structure loads instructions, which will be used to implement the vld[234](q?)_lane_* intrinsics. Tested (with the rest of the patch series) with make check on aarch64-oe-linux with qemu, and also causes no r

Re: [PATCH] add overlap function to gcov-tool

2014-10-08 Thread Rong Xu
On Tue, Oct 7, 2014 at 9:31 PM, Jan Hubicka wrote: >> Hi, >> >> This patch adds overlap functionality to gcov-tool. The overlap score >> estimates the similarity of two profiles. Currently it only computes >> overlap for arc counters. >> >> The overlap score is defined as >> \sum minimum (p1-count

Re: [gomp4] reduction bug fix

2014-10-08 Thread Cesar Philippidis
On 10/08/2014 02:38 AM, Thomas Schwinge wrote: > On Fri, 3 Oct 2014 09:22:52 -0700, Cesar Philippidis > wrote: >> There is a reduction bug [...] > > Thanks for looking into this! > >> This is a problem because initialize_reduction_data originally expected >> a GIMPLE_BIND at the very beginning

Re: [PATCH, ARM] attribute target (thumb,arm)

2014-10-08 Thread Ramana Radhakrishnan
Hi Christian, On 08/10/14 15:38, Christian Bruel wrote: Hi Ramana, Thanks for your feedback. Just a few comments while you continue the review Sure - all thoughts are welcome, this isn't a trivial project and I'm dredging tertiary storage in my brain and old notes for context on all the go

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-08 Thread Jiong Wang
On 08/10/14 17:19, Maxim Ostapenko wrote: Hi Jiong, I couldn't reproduce tests failures on my box, perhaps I missed something. How can I test this? Hi Maxim, What I mean is after this patch, those fails gone away on my test environment also. I am just not sure whether the remove will c

RE: [Patch, MIPS] Cleanup mips header files.

2014-10-08 Thread Steve Ellcey
On Mon, 2014-10-06 at 14:25 -0700, Matthew Fortune wrote: > Hi Steve, > > You're the lucky recipient of my first review so apologies for being > slow and cautious... > > I tried to find a reason why the files were originally separated like this > and I can't see anything obvious. I assume you al

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-08 Thread Maxim Ostapenko
Hi Jiong, I couldn't reproduce tests failures on my box, perhaps I missed something. How can I test this? -Maxim On 10/08/2014 06:30 PM, Jiong Wang wrote: On 08/10/14 15:00, Maxim Ostapenko wrote: Hm, as I see, others testsuites such as gfortran.exp, go.exp etc. do not call restore_ld_libra

Re: RFA: Merge definitions of get_some_local_dynamic_name

2014-10-08 Thread Richard Sandiford
Rainer Orth writes: > Hi Richard, > >> Does this work for you? I tested it on x86_64-linux-gnu but obviously >> that's not particularly useful for SEQUENCEs. > > the patch is fine, as tested on both sparc-sun-solaris2.11 and (for good > measure) i386-pc-solaris2.11. OK, great. To recap, the ide

[libquadmath,committed] Fix typo in doc

2014-10-08 Thread FX
Committed as trivial, rev. 216006 2014-10-08 Francois-Xavier Coudert PR libquadmath/63487 * libquadmath.texi (sincosq): Fix typo. Index: libquadmath.texi === --- libquadmath.texi(revision 215645) +++ libquad

Re: [PATCH] PR63404, gcc 5 miscompiles linux block layer

2014-10-08 Thread Jiong Wang
On 30/09/14 19:36, Jiong Wang wrote: 2014-09-30 17:30 GMT+01:00 Jeff Law : On 09/30/14 08:37, Jiong Wang wrote: On 30/09/14 05:21, Jeff Law wrote: I do agree with Richard that it would be useful to see the insns that are incorrectly sunk and the surrounding context. So I must be missing so

[4.8 & 4.9] Backport of r211885

2014-10-08 Thread Felix Yang
The enclosed patch for 4.8 & 4.9 branch is a backport of r211885 from trunk. The only change is to use: for (def_rec = DF_INSN_INFO_DEFS (insn_info); *def_rec; def_rec++) other than the new FOR_EACH_INSN_INFO_DEF interface. Bootstrapped on x86_64-SUSE-Linux for both branches. OK to apply? Ind

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-08 Thread Ilya Verbin
I rebased and updated kyukhin/gomp4-offload branch. It contains renaming of sections/symbols and fixes the cleanup of temporary directories in the offload emulator. On 07 Oct 21:40, Jakub Jelinek wrote: > One more thing, I've noticed that running target-1.exe testcase also leaves > /tmp/offload_XX

Re: [PATCH] libgcc: unwind-dw2-fde.h: Use "(const fde *)" instead of "(char *)" to avoid qualifier warning

2014-10-08 Thread Richard Henderson
On 10/08/2014 03:47 AM, Chen Gang wrote: > It passes "make -k check" under Darwin x86_64. > > 2014-10-07 Chen Gang > > * unwind-dw2-fde.h (last_fde): Use "(const fde *)" instead of > "(char *)" to avoid qualifier warning by 'xgcc' compiling. Ok. r~

Re: [PATCH, ARM] attribute target (thumb,arm)

2014-10-08 Thread Christian Bruel
Hi Ramana, Thanks for your feedback. Just a few comments while you continue the review 1) about the documentation in extend.texi, it was in the patch already : did I miss a part ? * doc/extend.texi (arm, thumb): Document target attributes. * doc/invoke.texi (arm, thumb): Mention targ

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-08 Thread Jiong Wang
On 08/10/14 15:00, Maxim Ostapenko wrote: Hm, as I see, others testsuites such as gfortran.exp, go.exp etc. do not call restore_ld_library_path at all. Perhaps we could simply follow this way? Would failing tests still fail if remove restore_ld_library_path from {asan, tsan, ubsan}_finish? Hi

Re: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.

2014-10-08 Thread Rainer Orth
Jonathan Wakely writes: > On 08/10/14 12:37 +0100, Jonathan Wakely wrote: >>On 08/10/14 13:27 +0200, Rainer Orth wrote: >>>On Solaris 11 (both SPARC and x86), the test execution FAILs: >>> >>>Assertion failed: os && std::stod(os.str()) == d, file >>> /vol/gcc/src/hg/trunk/local/libstdc++-v3/tests

C++ PATCH for copying volatile class with ellipsis constructor

2014-10-08 Thread Jason Merrill
Ville's test in progress for is_trivially_constructible discovered this corner case ICE; trying to force a copy for passing to the ellipsis was resulting in infinite recursion as we call the ellipsis ctor to call the ellipsis ctor to Fixed by short-circuiting this into a call to the actua

libgo patch committed: Fix recover.go test for large args, FFI

2014-10-08 Thread Ian Lance Taylor
This patch to libgo fixes PR 60406, in which a problem arises when passing a large argument to a deferred function. The current code generates a thunk that looks like this: if (__go_set_defer_retaddr (&&L)) goto L; deferred_function(args); L: Then the deferred_function calls

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-08 Thread Maxim Ostapenko
Hm, as I see, others testsuites such as gfortran.exp, go.exp etc. do not call restore_ld_library_path at all. Perhaps we could simply follow this way? Would failing tests still fail if remove restore_ld_library_path from {asan, tsan, ubsan}_finish? On 10/08/2014 03:40 PM, Marcus Shawcroft wr

Re: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.

2014-10-08 Thread Jonathan Wakely
On 08/10/14 12:37 +0100, Jonathan Wakely wrote: On 08/10/14 13:27 +0200, Rainer Orth wrote: On Solaris 11 (both SPARC and x86), the test execution FAILs: Assertion failed: os && std::stod(os.str()) == d, file /vol/gcc/src/hg/trunk/local/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_arit

Re: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.

2014-10-08 Thread Jonathan Wakely
On 08/10/14 11:07 +0100, Jonathan Wakely wrote: On 07/10/14 21:10 +0200, Andreas Schwab wrote: That cannot work. std::__convert_from_v always passes __prec before __v, but the format is "%a". Ah yes. I'm testing this fix now. Committed. I assume it was working for me because __convert_from

Re: [PATCH, ARM] attribute target (thumb,arm)

2014-10-08 Thread Ramana Radhakrishnan
Hi Christian, Thanks for looking at this. I will need to read the code in detail but this is a first top level reivew. On 09/29/14 12:03, Christian Bruel wrote: Hi Ramana, Richard, This patch implements the attribute target (and pragma) to allow function based interworking. as in the updat

Re: [PATCH 2/2] PR debug/63240 Add DWARF representation for C++11 defaulted member function.

2014-10-08 Thread Jason Merrill
On 10/07/2014 09:36 AM, Siva Chandra wrote: Barring some incompleteness, for which patches are very close to getting committed, I believe GDB has the rest of the information. Interesting. It is still the case that defaulting in the class is different from defaulting outside the class, though;

Re: RFA: Fix debug address mode for TARGET_MEM_REF

2014-10-08 Thread Joern Rennecke
On 8 October 2014 12:02, Richard Biener wrote: ... > - if (POINTER_TYPE_P (TREE_TYPE (exp))) > - as = TYPE_ADDR_SPACE (TREE_TYPE (TREE_TYPE (exp))); > - else > - as = ADDR_SPACE_GENERIC; > - > + as = TYPE_ADDR_SPACE (TREE_TYPE (TREE_TYPE (TREE_OPERAND (exp, 0; >

Re: [Patch ARM-AArch64/testsuite v2 01/21] Neon intrinsics execution tests initial framework.

2014-10-08 Thread Ramana Radhakrishnan
What do you prefer me to do for these tests? I can think of: - do not include them at all until fp16 is fully supported on both AArch32 and AArch64 - include only those with float16x4_t - include both float16x4_t and float16x8_t tests, leaving float16x8_t commented I would include them both an

Re: [PATCH] gcc.dg/torture/ cleanup

2014-10-08 Thread Marek Polacek
On Wed, Oct 08, 2014 at 01:06:50PM +0200, Rainer Orth wrote: > This patch completely broke the builtin-apply-4.c execution tests on > Solaris 11/x86 (and undoubtedly on many other platforms). > stackalign.exp has this comment: > > # default_flags are replaced by a dg-options test directive, or app

[C PATCH] Don't warn on = { } initialization (PR c/63480)

2014-10-08 Thread Marek Polacek
PR63480 points out that -Wmissing-field-initializers warns about initializing with { }. Given that we suppress the warning for initializing with { 0 }, I think it makes sense to suppress it for { } as well. (Initializing with { } is a GNU extension and -pedantic warns on that.) Bootstrapped/regte

Re: [PATCH, RTL]: Fix PR 63483, Scheduler performs Invalid move of aliased memory reference

2014-10-08 Thread Uros Bizjak
On Wed, Oct 8, 2014 at 12:51 PM, Richard Biener wrote: >> This message revives an old thread [1], where the miscompilation of gfortran >> on alpha was found that that resulted in: [...] > As said in the audit trail of the bugreport I think that the caller > of alpha_set_memflags is wrong in app

RE: [Patch, MIPS] Add .note.GNU-stack section

2014-10-08 Thread Matthew Fortune
> I talked to Andrew about what files he changed in GCC and created and > tested this new patch. Andrew also mentioned changing some assembly > files in glibc but I don't see any use of '.section .note.GNU-stack' in > any assembly files in glibc (for any platform) so I wasn't planning on > creatin

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-08 Thread Marcus Shawcroft
On 8 October 2014 11:10, Maxim Ostapenko wrote: > Does it work without restore_ld_library_path in {asan, ubsan, tsan}_finish? > > I see two opportunities to fix the issue: > > 1) Implement a stack of saved contexts. > > 2) Implement new functions, say {asan, ubsan, tsan}_restore_ld_library_path, >

Re: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.

2014-10-08 Thread Jonathan Wakely
On 08/10/14 13:27 +0200, Rainer Orth wrote: On Solaris 11 (both SPARC and x86), the test execution FAILs: Assertion failed: os && std::stod(os.str()) == d, file /vol/gcc/src/hg/trunk/local/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_arithmetic/char/hexfloat.cc, line 51, function test0

Re: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.

2014-10-08 Thread Rainer Orth
Jonathan Wakely writes: > On 28/03/14 08:56 +0900, Luke Allardyce wrote: >>It looks like the new standard also requires the precision to be >>ignored for hexfloat >> >>>For conversion from a floating-point type, if floatfield != >> (ios_base::fixed | ios_base:: scientific), str.precision() is spe

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-08 Thread Jakub Jelinek
On Mon, Oct 06, 2014 at 07:53:17PM +0400, Ilya Verbin wrote: > 2014-10-06 Jakub Jelinek > Ilya Verbin > Thomas Schwinge > Andrey Turetskiy > > libgomp/ > * libgomp.map (GOMP_4.0.1): New symbol version. > Add GOMP_offload_register. > * libgom

Re: [PATCH] gcc.dg/torture/ cleanup

2014-10-08 Thread Rainer Orth
Marek Polacek writes: > This patch is a cleanup of tests in gcc.dg/torture directory. > See https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02656.html for more info. > > Tested on x86_64-linux: vanilla results == results with this patch == > results with this patch and gnu11 as a default. > > Ok? >

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-10-08 Thread Mark Wielaard
On Wed, 2014-10-08 at 12:35 +0200, Jakub Jelinek wrote: > On Wed, Oct 08, 2014 at 12:29:38PM +0200, Mark Wielaard wrote: > > On Wed, 2014-10-08 at 12:17 +0200, Marek Polacek wrote: > > > On Wed, Oct 08, 2014 at 12:13:55PM +0200, Mark Wielaard wrote: > > > > This lang hook will be more useful when D

Re: RFA: Fix debug address mode for TARGET_MEM_REF

2014-10-08 Thread Richard Biener
On Wed, Oct 8, 2014 at 10:16 AM, Joern Rennecke wrote: > Trying to build avr2 strftime of avr-libc ICEs as we are trying to > convert a PSImode address to HImode. There is no reason to > do this conversion in the first place - it is a case of failing to recognize > the proper address space. > > T

Re: [PATCH, RTL]: Fix PR 63483, Scheduler performs Invalid move of aliased memory reference

2014-10-08 Thread Richard Biener
On Wed, 8 Oct 2014, Uros Bizjak wrote: > Hello! > > This message revives an old thread [1], where the miscompilation of gfortran > on alpha was found that that resulted in: > > FAIL: gfortran.dg/assumed_rank_3.f90:15.20: > > print *, ubound(x,dim=3) ! << wrong dim > 1 >

[PATCH] libgcc: unwind-dw2-fde.h: Use "(const fde *)" instead of "(char *)" to avoid qualifier warning

2014-10-08 Thread Chen Gang
If no negative effect with keeping code clear and simple, need try to avoid warning, especially use our own 'xgcc' for our own code. The related warning under Darwin is: /var/root/upstream/build-gcc-new/./gcc/xgcc -B/var/root/upstream/build-gcc-new/./gcc/ -B/usr/local/x86_64-apple-darwin13.4.0

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-10-08 Thread Jakub Jelinek
On Wed, Oct 08, 2014 at 12:29:38PM +0200, Mark Wielaard wrote: > On Wed, 2014-10-08 at 12:17 +0200, Marek Polacek wrote: > > On Wed, Oct 08, 2014 at 12:13:55PM +0200, Mark Wielaard wrote: > > > This lang hook will be more useful when DWARFv5 gets out, which is > > > supposed to define language iden

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-10-08 Thread Mark Wielaard
On Wed, 2014-10-08 at 12:17 +0200, Marek Polacek wrote: > On Wed, Oct 08, 2014 at 12:13:55PM +0200, Mark Wielaard wrote: > > This lang hook will be more useful when DWARFv5 gets out, which is > > supposed to define language identifiers for newer C and C++ versions. > > It might have been discusse

Re: [PATCH RFC]Pair load store instructions using a generic scheduling fusion pass

2014-10-08 Thread Ramana Radhakrishnan
>> If the port has a splitter to rip apart a douple-word load into single-word >> loads, then we'd obviously only want to do that in cases where the >> double-word load actually generates > 1 assembly instruction. Or indeed if it is really a performance win. And I think that should purely be a p

Re: [PATCH 1/2] PR debug/63239 Add DWARF representation for C++11 deleted member function.

2014-10-08 Thread Mark Wielaard
On Wed, 2014-10-08 at 10:56 +0200, Rainer Orth wrote: > Steven Bosscher writes: > > On Mon, Oct 6, 2014 at 9:54 AM, Mark Wielaard wrote: > >> Just removing the # prefix (but keeping the space) from > >> scan-assembler-times should work for both our cases. I just don't know > >> why our .s outputs

Re: [PATCH 4/n] OpenMP 4.0 offloading infrastructure: lto-wrapper

2014-10-08 Thread Jakub Jelinek
On Thu, Oct 02, 2014 at 07:14:57PM +0400, Ilya Verbin wrote: > @@ -1296,6 +1297,9 @@ static const char *const standard_startfile_prefix_2 > relative to the driver. */ > static const char *const tooldir_base_prefix = TOOLDIR_BASE_PREFIX; > > +/* A prefix to be used when this is an accelerato

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-10-08 Thread Marek Polacek
On Wed, Oct 08, 2014 at 12:13:55PM +0200, Mark Wielaard wrote: > Hi, > > This patch was written a long time ago by Jakub and has been in Fedora > gcc for some time. All I did was rebase it to current gcc trunk > and add a testcase. Back when it was originally proposed the issue was > that because

[PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-10-08 Thread Mark Wielaard
Hi, This patch was written a long time ago by Jakub and has been in Fedora gcc for some time. All I did was rebase it to current gcc trunk and add a testcase. Back when it was originally proposed the issue was that because DWARF was generated late adding new lang hooks for this was problematic for

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-08 Thread Maxim Ostapenko
Does it work without restore_ld_library_path in {asan, ubsan, tsan}_finish? I see two opportunities to fix the issue: 1) Implement a stack of saved contexts. 2) Implement new functions, say {asan, ubsan, tsan}_restore_ld_library_path, to be able {asan, ubsan, tsan}_finish functions restore co

Re: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.

2014-10-08 Thread Jonathan Wakely
On 07/10/14 21:10 +0200, Andreas Schwab wrote: That cannot work. std::__convert_from_v always passes __prec before __v, but the format is "%a". Ah yes. I'm testing this fix now. commit 543771e2db1642715854ae4bec81d803ca8e2e59 Author: Jonathan Wakely Date: Wed Oct 8 10:39:27 2014 +0100

  1   2   >