Re: [GSoC] Elimination of CLooG library installation dependency

2014-08-19 Thread Bin.Cheng
On Wed, Aug 20, 2014 at 1:24 PM, Roman Gareev wrote: > Which configure options do you use? Have you tried to bootstrap > r214105 with same configure options? > Have you tried to manually export the path to isl to LD_RUN_PATH? > (You've probably tried. I just want to make sure.) I can't access the

[Patch,GCC/Thumb1]Use immediate_operand in 64bit split pattern

2014-08-19 Thread Terry Guo
Hi there, The gcc now uses immediate_operand for const_double_operand, update this split pattern accordingly. Tested with gcc regression test on thumb1 target, no regression. Is it ok to trunk? BR, Terry 2014-08-20 Terry Guo * config/arm/thumb1.md (64bit splitter): Replace const_double_

Re: [GSoC] Elimination of CLooG library installation dependency

2014-08-19 Thread Roman Gareev
Which configure options do you use? Have you tried to bootstrap r214105 with same configure options? Have you tried to manually export the path to isl to LD_RUN_PATH? (You’ve probably tried. I just want to make sure.) 2014-08-20 9:28 GMT+06:00 Bin.Cheng : > I suspect this causes arm/aarch64 nativ

Re: [wwwdocs] Update GCC5 changes.html

2014-08-19 Thread Marek Polacek
Ping. On Wed, Aug 13, 2014 at 01:33:08PM +0200, Marek Polacek wrote: > I've put together a few lines describing what I (except > -fsanitize=alignment) implemented for GCC 5. > It's the file wwwdocs/htdocs/gcc-5/changes.html. > > Ok? > > --- changes.html.mp 2014-08-13 12:21:57.059610612 +0200 >

Re: [GSoC] Elimination of CLooG library installation dependency

2014-08-19 Thread Bin.Cheng
I suspect this causes arm/aarch64 native bootstrap failure with below messages. aarch64-none-linux-gnu-g++ -c -g -O2 -DIN_GCC-fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -W

Re: [PATCH] Fix bootstrap on ppc64

2014-08-19 Thread Richard Henderson
On 08/19/2014 10:17 AM, Marek Polacek wrote: > My recent patch broke bootstrap on ppc64, because, by default, > char on ppc defaults to be an unsigned char. But the code relied > on char being signed by default. > Furthermore, the compat warning about // comments shouldn't be issued > in C++ mode

Re: Bootstrap failure/ ICE in rtl.h (was: Re: [PATCH 225/236] Work towardgmane.comp.gcc.patchess NEXT_INSN/PREV_INSN requiring insns as their params)

2014-08-19 Thread David Malcolm
On Wed, 2014-08-20 at 00:15 +0200, Tobias Burnus wrote: > I am not sure about which patch causes the problem, but with Rev. 214197 > boostrapping fails here (x86-64-gnu-linux) while an incremental build > with a few other of your changes it worked. > > Currently, it fails in Stage 1 with the Sta

[PATCH][ARM] Fix -fcall-saved-rX for X > 7

2014-08-19 Thread Thomas Preud'homme
This patch makes -fcall-saved-rX for X > 7 on Thumb target when optimizing for size. It works by adding a new field x_user_set_call_save_regs in struct target_hard_regs to track whether an entry in fields x_fixed_regs, x_call_used_regs and x_call_really_used_regs was user set or is in its defaul

Re: [PATCH] Asan static optimization (draft)

2014-08-19 Thread Konstantin Serebryany
BTW, here is one particular kind of static analysis which I am very much interested in: https://code.google.com/p/address-sanitizer/wiki/CompileTimeOptimizations#Escape_analysis_for_use-after-return Here we can prove that a does not escape foo() and thus we may avoid putting it on fake stack. int

Re: [PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params

2014-08-19 Thread Richard Henderson
On 08/19/2014 02:35 PM, David Malcolm wrote: > This one is quite ugly: the pre-existing code has two locals named > "note", both of type rtx, with one shadowing the other. This patch > introduces a third, within the scope where the name "note" is used for > insns. In the other scopes the two othe

Re: [PATCH] Asan static optimization (draft)

2014-08-19 Thread Konstantin Serebryany
On Mon, Aug 18, 2014 at 1:05 PM, Yuri Gribov wrote: > On Fri, Aug 15, 2014 at 10:34 PM, Konstantin Serebryany > wrote: >> If this is -O1 or higher, then most (but not all) of your cases >> *should* be optimized by the compiler before asan kicks in. > > You mean hoisting memory accesses from bran

[Patch AArch64] Fix for PR62040

2014-08-19 Thread Carrot Wei
Hi Current AArch64 backend can generate rtl expressions like (vec_duplicate:DI (const_int 0 [0])), which causes ICE in simplify_const_unary_operation because vec_duplicate should generate vector mode only. As suggested by Andrew in the bug entry, I split the original insn patterns to avoid scalar

Re: [PATCH PR preprocessor/51303] Wmissing-include-dirs warnings reported as [enabled by default]

2014-08-19 Thread Joseph S. Myers
On Wed, 20 Aug 2014, Manuel L?pez-Ib??ez wrote: > The fix is almost trivial. Just use the appropriate flags when warning. > > Bootstrapped and regression tested on x86_64-linux-gnu. > > OK? OK. -- Joseph S. Myers jos...@codesourcery.com

Bootstrap failure/ ICE in rtl.h (was: Re: [PATCH 225/236] Work towardgmane.comp.gcc.patchess NEXT_INSN/PREV_INSN requiring insns as their params)

2014-08-19 Thread Tobias Burnus
I am not sure about which patch causes the problem, but with Rev. 214197 boostrapping fails here (x86-64-gnu-linux) while an incremental build with a few other of your changes it worked. Currently, it fails in Stage 1 with the Stage 1 compiler with the following message. Tobias ../../../..

[PATCH PR preprocessor/51303] Wmissing-include-dirs warnings reported as [enabled by default]

2014-08-19 Thread Manuel López-Ibáñez
The fix is almost trivial. Just use the appropriate flags when warning. Bootstrapped and regression tested on x86_64-linux-gnu. OK? gcc/ChangeLog: 2014-08-20 Manuel López-Ibáñez * incpath.c (remove_duplicates): Use cpp_warning. gcc/c-family/ChangeLog: 2014-08-20 Manuel López-Ibáñez

Re: [C PATCH] Encode CPP options in c.opt

2014-08-19 Thread Joseph S. Myers
On Tue, 19 Aug 2014, Manuel L?pez-Ib??ez wrote: > The following patch adds a new CPP() to *.opt files that tells the > options machinery to keep in sync libcpp options and GCC options. > > This will allow us to fix a lot of latent bugs where CPP warnings do > not follow the rules of other warning

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-08-19 Thread Joseph S. Myers
On Fri, 15 Aug 2014, Sylvestre Ledru wrote: > It is indeed useless. I removed it. Thanks > http://sylvestre.ledru.info/0001-Enable-warning-Wreturn-type-by-default.patch I don't think most of the testsuite changes in this patch should be needed, and we should be conservative about changing existi

Re: [PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params

2014-08-19 Thread David Malcolm
On Tue, 2014-08-19 at 13:57 -0700, Richard Henderson wrote: > On 08/06/2014 10:23 AM, David Malcolm wrote: > > diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c > > index 59d633d..5e42a97 100644 > > --- a/gcc/cfgrtl.c > > +++ b/gcc/cfgrtl.c > > @@ -1604,6 +1604,7 @@ force_nonfallthru_and_redirect (edge e, b

[Patch, documentation] Add documentation for check_effective_target_strict_align

2014-08-19 Thread Steve Ellcey
I was pinged about the lack of documentation for the check_effective_target_non_strict_align procedure I added to target-supports.exp. This patch fixes that. If I don't get any objections in the next day or two I will check this in as an obvious patch. Steve Ellcey sell...@mips.com 2014-08-19

Re: [PATCH 222/236] Use rtx_insn in more places in dwarf2cfi.c

2014-08-19 Thread David Malcolm
On Tue, 2014-08-19 at 13:56 -0700, Richard Henderson wrote: > On 08/06/2014 10:23 AM, David Malcolm wrote: > >else if (computed_jump_p (insn)) > > { > > for (rtx_expr_list *lab = forced_labels; lab; lab = lab->next ()) > > - maybe_record_trace_start (lab->element (), insn);

Re: [PATCH 035/236] Return types of unlink_insn_chain and duplicate_insn_chain

2014-08-19 Thread David Malcolm
On Wed, 2014-08-13 at 11:56 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * rtl.h (unlink_insn_chain): Strengthen return type from rtx to > > rtx_insn *. > > (duplicate_insn_chain): Likewise. > > * cfgrtl.c (unlink_insn_chain): Strengthen return type

Re: [PATCH 034/236] next_cc0_user and prev_cc0_setter scaffolding

2014-08-19 Thread David Malcolm
On Wed, 2014-08-13 at 11:55 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * rtl.h (next_cc0_user): Strengthen return type from rtx to > > rtx_insn *. > > (prev_cc0_setter): Likewise. > > > > * emit-rtl.c (next_cc0_user): Strengthen return type from rt

Re: [PATCH 229/236] NEXT_INSN and PREV_INSN take a const rtx_insn

2014-08-19 Thread Richard Henderson
On 08/06/2014 10:23 AM, David Malcolm wrote: > This patch updates NEXT_INSN and PREV_INSN to work on rtx_insn *, rather > than plain rtx - plus miscellaneous fixes needed to get there. Ug. Bigger than I'd have liked, but still ok. r~

Re: [PATCH 236/236] END OF PATCHES: Delete rtx-classes-status.txt

2014-08-19 Thread Richard Henderson
On 08/06/2014 10:23 AM, David Malcolm wrote: > / > rtx-classes-status.txt: Delete > --- > rtx-classes-status.txt | 9 - > 1 file changed, 9 deletions(-) > delete mode 100644 rtx-classes-status.txt #230 - #236 are ok. r~

Re: [PATCH 228/236] tablejump_p takes an rtx_insn

2014-08-19 Thread Richard Henderson
On 08/06/2014 10:23 AM, David Malcolm wrote: > gcc/ > * rtl.h (tablejump_p): Strengthen first param from const_rtx to > const rtx_insn *. > (label_is_jump_target_p): Likewise for second param. > > * rtlanal.c (tablejump_p): Likewise for param "insn". > (label_is_jump_

Re: [testsuite patch] another fix to arm_v8_neon_ok

2014-08-19 Thread Mike Stump
On Aug 18, 2014, at 4:48 PM, Janis Johnson wrote: > Tested with gcc.target/neon tests for mainline arm-none-eabi with many > sets of multilib options; OK for mainline and 4.9? Ok.

Re: [PATCH 224/236] insn_current_reference_address takes an rtx_insn

2014-08-19 Thread Richard Henderson
On 08/06/2014 10:23 AM, David Malcolm wrote: > gcc/ > * output.h (insn_current_reference_address): Strengthen param > from rtx to rtx_insn *. > * final.c (insn_current_reference_address): Likewise. #223 and #224 are ok. r~

Re: [PATCH 225/236] Work towards NEXT_INSN/PREV_INSN requiring insns as their params

2014-08-19 Thread Richard Henderson
On 08/06/2014 10:23 AM, David Malcolm wrote: > diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c > index 59d633d..5e42a97 100644 > --- a/gcc/cfgrtl.c > +++ b/gcc/cfgrtl.c > @@ -1604,6 +1604,7 @@ force_nonfallthru_and_redirect (edge e, basic_block > target, rtx jump_label) > >if (EDGE_COUNT (e->src->s

Re: [PATCH 033/236] emit_move et al return rtx_insn *

2014-08-19 Thread David Malcolm
On Wed, 2014-08-13 at 11:54 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * expr.h (emit_move_insn): Strengthen return type from rtx to > > rtx_insn *. > > (emit_move_insn_1): Likewise. > > (emit_move_complex_push): Likewise. > > (emit_move_comple

Re: [PATCH 222/236] Use rtx_insn in more places in dwarf2cfi.c

2014-08-19 Thread Richard Henderson
On 08/06/2014 10:23 AM, David Malcolm wrote: >else if (computed_jump_p (insn)) > { > for (rtx_expr_list *lab = forced_labels; lab; lab = lab->next ()) > - maybe_record_trace_start (lab->element (), insn); > + maybe_record_trace_start (lab->insn (), insn); >

Re: [PATCH 220/236] Strengthen return_label and naked_return_label to rtx_code_label *

2014-08-19 Thread Richard Henderson
On 08/06/2014 10:23 AM, David Malcolm wrote: > gcc/ > * function.h (struct rtl_data): Strengthen fields "x_return_label" > and "x_naked_return_label" from rtx to rtx_code_label *. > --- > gcc/function.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) #207 - #220 are all OK

Re: [PATCH 221/236] Add insn method to rtx_expr_list

2014-08-19 Thread Richard Henderson
On 08/06/2014 10:23 AM, David Malcolm wrote: > gcc/ > * rtl.h (rtx_expr_list::insn): New method. > --- > gcc/rtl.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/gcc/rtl.h b/gcc/rtl.h > index d028be1..d5811c2 100644 > --- a/gcc/rtl.h > +++ b/gcc/rtl.h > @@ -414,6 +414,10

[Patch] Switch elimination pass for PR 54742

2014-08-19 Thread Steve Ellcey
Here is an official submission for the switch optimization described in PR 54742. I have addressed the formatting/comment issues that were raised and also added a test case based on comment #27 from PR 54742 and I fixed a bug I found while doing benchmarking with SPEC2006 (the perl benchmark was g

Re: [PATCH 032/236] emit_* functions return rtx_insn

2014-08-19 Thread David Malcolm
On Wed, 2014-08-13 at 11:52 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > More scaffolding: strengthen the return types from the various emit_ > > functions from rtx to rtx_insn * (or to the rtx_barrier * subclass in a > > few cases). > > > > These will ultimately have their

Re: [PATCH 031/236] emit_jump_table_data returns an rtx_jump_table_data *

2014-08-19 Thread David Malcolm
On Wed, 2014-08-13 at 07:45 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * emit-rtl.c (emit_jump_table_data): Strengthen return type from > > rtx to rtx_jump_table_data *. Also for local. > > * rtl.h (emit_jump_table_data): Likwise. > OK. Thanks. Comm

Re: [PATCH 030/236] Convert various rtx to rtx_note *

2014-08-19 Thread David Malcolm
On Wed, 2014-08-06 at 13:20 -0400, David Malcolm wrote: > gcc/ > * basic-block.h (create_basic_block_structure): Strengthen third > param "bb_note" from rtx to rtx_note *. > * rtl.h (emit_note_before): Strengthen return type from rtx to > rtx_note *. > (emit_note_after

Re: [patch] libstdc++/29988 Rb_Tree reuse allocated nodes

2014-08-19 Thread François Dumont
Any news regarding this proposal ? Thanks François On 30/07/2014 23:39, François Dumont wrote: Hi Now that patch on testsuite allocator is in I would like to reactivate this one. Here it is again. See previous answer below regarding modification of _M_begin/_M_cbegin. 201

Re: [PATCH 029/236] rtl_data.x_parm_birth_insn is an insn

2014-08-19 Thread David Malcolm
On Wed, 2014-08-13 at 07:44 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * function.h (struct rtl_data): Strengthen field > > "x_parm_birth_insn" from rtx to rtx_insn *. > > * function.c (struct assign_parm_data_all): Strengthen fields > > "first_con

Re: [PATCH 028/236] cfgexpand.c: Use rtx_insn

2014-08-19 Thread David Malcolm
On Wed, 2014-08-13 at 07:42 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * cfgexpand.c (expand_used_vars): Strengthen return type from rtx > > to rtx_insn *; also for local "var_end_seq". > > (maybe_dump_rtl_for_gimple_stmt): Likewise for param "since".

Re: [PATCH 027/236] asan_emit_stack_protection returns an insn

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 21:56 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * asan.h (asan_emit_stack_protection): Strengthen return type from > > rtx to rtx_insn *. > > * asan.c (asan_emit_stack_protection): Likewise. Add local > > "insns" to hold the

Re: [PATCH 026/236] bb_note returns a rtx_note *

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 21:55 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * basic-block.h (bb_note): Strengthen return type from rtx to rtx_note > > *. > > * sched-int.h (bb_note): Likewise. > > * cfgrtl.c (bb_note): Likewise. Add a checked cast to rtx_

RE: [PATCH, AArch64] Fix typo

2014-08-19 Thread Evandro Menezes
Ping, pretty please. -- Evandro Menezes Austin, USA e.mene...@samsung.com +1-512-425-3365 -Original Message- From: Evandro Menezes [mailto:e.mene...@samsung.com] Sent: Monday, August 18, 2014 10:02 To: 'James Greenhalgh' Cc: 'gcc-patches@gcc

Re: [PATCH 025/236] make_insn_raw returns an rtx_insn

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 21:54 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > Doing so means strengthening the types of the make_raw callbacks within > > emit-rtl.c from rtx to rtx_insn * as used by the emit_pattern_* > > internal functions. There's more that could be done in te

Re: [PATCH 024/236] last_call_insn returns an rtx_call_insn *

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 21:52 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * emit-rtl.c (last_call_insn): Strengthen return type from rtx to > > rtx_call_insn *. > > * rtl.h (is_a_helper ::test): New overload, accepting > > an rtx_insn *. > > (last

Re: [wwwdocs] Re: gcc.gnu.org/simtest-howto.html (was: Question for ARM person re asm_fprintf)(

2014-08-19 Thread Oleg Endo
On Tue, 2014-08-19 at 07:02 -0400, Hans-Peter Nilsson wrote: > On Mon, 18 Aug 2014, Oleg Endo wrote: > > On Mon, 2014-08-18 at 16:57 -0400, Hans-Peter Nilsson wrote: > > > On Mon, 18 Aug 2014, Oleg Endo wrote: > > > > On Sun, 2014-08-17 at 16:56 -0400, Hans-Peter Nilsson wrote: > > > > > On Fri, 15

Re: [PATCH diagnostics/Fortran] Implement Fortran prefix/caret style using the common diagnostics machinery

2014-08-19 Thread Manuel López-Ibáñez
On 19 August 2014 21:21, Tobias Burnus wrote: > [Side remark: By itself, using "^" would be fine also for gfortran; however, > it uses a digit like "1" because it also has a few error messages of the > kind "Duplicate statement label %d at %L and %L", which uses two locations > with the labels "1"

Re: [PATCH 023/236] delete_trivially_dead_insns works on insns

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 21:51 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * rtl.h (delete_trivially_dead_insns): Strengthen initial param > > "insns" from rtx to rtx_insn *. > > * cse.c (delete_trivially_dead_insns): Likewise, also do it for > > local

Re: [PATCH 022/236] Make tablejump_p accept a rtx_jump_table_data **

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 21:51 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * rtl.h (tablejump_p): Strengthen third param from rtx * to > > rtx_jump_table_data **. > > > > * cfgbuild.c (make_edges): Introduce local "table", using it in > > place of "tmp

Re: [PATCH diagnostics/Fortran] Implement Fortran prefix/caret style using the common diagnostics machinery

2014-08-19 Thread Tobias Burnus
Hi, Manuel López-Ibáñez wrote: This patch is relative to this one here: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg01652.html It implements the Fortran style of prefix and caret line in the gfc_diagnostic_starter by using the common pretty-printer. Looks good to me. Thanks for the patch!

Re: [PATCH, PR61776] verify_flow_info failed: control flow in the middle of basic block with -fprofile-generate

2014-08-19 Thread Wei Mi
Sorry for the late reply. I took some time to make myself more familiar with NORETURN and related code, and finally I understood what you mean and saw why only GF_CALL_CTRL_ALTERING was enough and GF_CALL_NORETURN was unneeded. With your suggestion, the change looks much briefer! Please check if th

Re: [PATCH 021/236] entry_of_function returns an insn

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 21:04 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * rtl.h (entry_of_function): Strengthen return type from rtx to > > rtx_insn *. > > * cfgrtl.c (entry_of_function): Likewise. > OK. Thanks; committed to trunk as r214182.

[PATCH diagnostics/Fortran] Implement Fortran prefix/caret style using the common diagnostics machinery

2014-08-19 Thread Manuel López-Ibáñez
Hi, This patch is relative to this one here: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg01652.html It implements the Fortran style of prefix and caret line in the gfc_diagnostic_starter by using the common pretty-printer. This requires making configurable the caret character in the diagnostic

C++ PATCH for tree-optimization/62091

2014-08-19 Thread Jason Merrill
The C++ front end already means to clear DECL_EXTERNAL on callable functions, we just need to update that for devirtualization. Tested x86_64-pc-linux-gnu, applying to trunk. commit a87e57625b130bb9e1fec2130643a4e5d7a3b807 Author: Jason Merrill Date: Tue Aug 19 13:52:25 2014 -0400 PR tr

Re: [PATCH 020/236] Return rtx_insn from get_insns/get_last_insn

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 16:01 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > Ultimately, the underlying fields should become rtx_insn *, but for now we > > can do this with a checked cast. > > > > Note to self: > >config/m32c/m32c.c: m32c_leaf_function_p directly manipulates

Re: [C/C++ PATCH] Implement -Wbool-compare (PR c++/62153)

2014-08-19 Thread Marek Polacek
On Tue, Aug 19, 2014 at 01:41:44PM -0400, Jason Merrill wrote: > On 08/19/2014 12:52 PM, Marek Polacek wrote: > >+ tree cst = TREE_CODE (op0) == INTEGER_CST > >+ ? op0 : TREE_CODE (op1) == INTEGER_CST ? op1 : NULL_TREE; > > This indentation won't survive Emacs auto-indent; please add pare

Re: [PATCH 019/236] Strengthen return type of gen_label_rtx

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 16:00 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > gcc/ > > * rtl.h (gen_label_rtx): Strengthen return type from rtx to > > rtx_code_label *. > > > > * emit-rtl.c (gen_label_rtx): Likewise. > Presumably at some point we'll look at the gen_XX

Re: [PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-19 Thread Richard Henderson
On 08/06/2014 10:19 AM, David Malcolm wrote: > @@ -2772,11 +2772,11 @@ mn10300_adjust_sched_cost (rtx insn, rtx link, rtx > dep, int cost) >if (!TARGET_AM33) > return 1; > > - if (GET_CODE (insn) == PARALLEL) > -insn = XVECEXP (insn, 0, 0); > + if (GET_CODE (PATTERN (insn)) == PAR

[PATCH/PR c/59304] #pragma diagnostic pop after warning fails for options unspecified in the command-line and disabled by default

2014-08-19 Thread Manuel López-Ibáñez
The idea is that when we see a change of classification, and the option was originally unspecified, we record the command-line status. This way, when doing pop later, we already check if the option was reclassified so we get the command-line status. This also works with -Wall, since all dependent o

Re: [PATCH] Add guality [p]type test.

2014-08-19 Thread Mark Wielaard
On Tue, 2014-08-19 at 14:16 +0200, Richard Biener wrote: > On Tue, Aug 19, 2014 at 2:10 PM, Mark Wielaard wrote: > > gcc/testsuite/ChangeLog > > 2014-08-19 Mark Wielaard > > > > * gcc.dg/guality/restrict.c: Add `used' attribute to all variables. > > (cpy): Change type of last argument t

Re: [C/C++ PATCH] Implement -Wbool-compare (PR c++/62153)

2014-08-19 Thread Jason Merrill
On 08/19/2014 12:52 PM, Marek Polacek wrote: + tree cst = TREE_CODE (op0) == INTEGER_CST +? op0 : TREE_CODE (op1) == INTEGER_CST ? op1 : NULL_TREE; This indentation won't survive Emacs auto-indent; please add parentheses. + int sign = TREE_CODE (op0) == INTEGER_CST +

Re: [PATCH 018/236] Strengthen return types of various {next|prev}_*insn from rtx to rtx_insn *

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 15:59 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > These should all eventually require an rtx_insn * as an argument, > > but we'll save that for a later patch. > > > > gcc/ > > * rtl.h (previous_insn): Strengthen return type from rtx to > > rtx_

[c++-concepts] normalization checks

2014-08-19 Thread Andrew Sutton
This patch adds checks for user-defined logical operators during constraint normalization and ensures that all atomics can be converted to bool. 2014-08-14 Andrew Sutton Implement normalization checks. * gcc/cp/constraint.cc (normalize_expr): Delegate cast and atomic no

Re: C++ PATCH to set DECL_COMDAT on undefined inlines/templates

2014-08-19 Thread Jason Merrill
Another needed tweak, applying to trunk. commit aac24a75af315fb6aa6099a159c6bce339706bc1 Author: Jason Merrill Date: Mon Aug 18 21:34:12 2014 -0400 PR lto/53808 PR c++/61659 * decl.c (maybe_commonize_var): Don't use DECL_COMDAT to trigger comdat_linkage. diff --git a/gcc/c

[PATCH] Fix bootstrap on ppc64

2014-08-19 Thread Marek Polacek
My recent patch broke bootstrap on ppc64, because, by default, char on ppc defaults to be an unsigned char. But the code relied on char being signed by default. Furthermore, the compat warning about // comments shouldn't be issued in C++ mode at all. Sorry about that. Bootstrapped on ppc64-linux,

[PATCH AArch64] Add a builtin for rbit(q?)_p8; add intrinsics and tests.

2014-08-19 Thread Alan Lawrence
This patch adds the missing vrbit_p8 and vrbitq_p8 intrinsics to arm_neon.h, and implements all the vrbit(q?)_[psu]8 intrinsics using a new builtin, rather than the previous temporary asm. Also adds a testcase checking (a) execution results and (b) that we output rbit vXX.8b,vYY.8b or correspond

Re: [PATCH 017/236] Add subclasses for the various kinds of instruction

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 21:07 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > gcc/ > > * coretypes.h (class rtx_real_insn): Add forward declaration. > > (class rtx_debug_insn): Likewise. > > (class rtx_nonjump_insn): Likewise. > > (class rtx_jump_insn): Likewise.

Re: [PATCH] PowerPC: Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV

2014-08-19 Thread Adhemerval Zanella
Ping. On 06-08-2014 17:21, Adhemerval Zanella wrote: > On 01-08-2014 12:31, Joseph S. Myers wrote: >> On Thu, 31 Jul 2014, David Edelsohn wrote: >> >>> Thanks for implementing the FENV support. The patch generally looks >>> good to me. >>> >>> My one concern is a detail in the implementation of

Re: [C/C++ PATCH] Implement -Wbool-compare (PR c++/62153)

2014-08-19 Thread Marek Polacek
On Mon, Aug 18, 2014 at 10:23:49PM +0200, Marek Polacek wrote: > On Mon, Aug 18, 2014 at 04:10:49PM -0400, Jason Merrill wrote: > > On 08/18/2014 04:04 PM, Marek Polacek wrote: > > >Unfortunately, this warning cannot be enabled by -Wall yet, because > > >of a few blunders we have in the codebase.

Re: [PATCH][AArch64] Use CC_Z and CC_NZ with csinc and similar instructions

2014-08-19 Thread Kyrill Tkachov
On 19/08/14 17:09, Richard Henderson wrote: (define_special_predicate "cc_register_zero" (match_code "reg") { return (REGNO (op) == CC_REGNUM && (GET_MODE (op) == CCmode || GET_MODE (op) == CC_Zmode || GET_MODE (op) == CC_NZmode)); }) ... and now t

Re: [PATCH 016/236] BND_TO scaffolding

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 15:22 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > gcc/ > > * sel-sched-ir.h (BND_TO): insn_t will eventually be an > > rtx_insn *. To help with transition, for now, convert from an > > access macro into a pair of functions: BND_TO, returni

Re: [PATCH][AArch64][tests]Skip graphite tests that don't fit -mcmodel=tiny

2014-08-19 Thread Mike Stump
On Aug 19, 2014, at 6:12 AM, Kyrill Tkachov wrote: > So how about this? Ok. Thanks.

Re: [PATCH, i386]: Fix PR62011, False data dependency in popcnt instruction

2014-08-19 Thread H.J. Lu
On Mon, Aug 18, 2014 at 12:29 PM, Uros Bizjak wrote: > On Mon, Aug 18, 2014 at 9:16 PM, H.J. Lu wrote: > >>> Attached patch fixes the problem with false data dependency on output >>> register for popcnt, lzcnt and tzcnt insns on sandybridge and haswell >>> targets. >>> >>> The new insn pattern sh

Re: PATCH: PR other/62168: error in configure: line 21572: test: =: unary operator expected

2014-08-19 Thread H.J. Lu
On Mon, Aug 18, 2014 at 08:51:35AM -0700, H.J. Lu wrote: > When --enable-gold=no is used to configure gcc, we will see > > configure: line 21572: test: =: unary operator expected > > I checked in this patch to set install_gold_as_default to no for > --enable-gold=no. Tested on Linux/x86-64. > >

Re: [PATCH][AArch64] Use CC_Z and CC_NZ with csinc and similar instructions

2014-08-19 Thread Richard Henderson
> (define_special_predicate "cc_register_zero" > (match_code "reg") > { > return (REGNO (op) == CC_REGNUM > && (GET_MODE (op) == CCmode > || GET_MODE (op) == CC_Zmode > || GET_MODE (op) == CC_NZmode)); > }) ... and now that I read the backend more closely,

Re: [PATCH 015/236] BB_NOTE_LIST scaffolding

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 15:22 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > gcc/ > > * sel-sched-ir.h (BB_NOTE_LIST): struct sel_region_bb_info_def's > > "note_list" field will eventually be an rtx_insn *. To help with > > transition, for now, convert from an acces

Re: [PATCH] Quash Wbool-compare warning in optabs.c

2014-08-19 Thread Richard Henderson
On 08/19/2014 08:54 AM, Marek Polacek wrote: > Works as well. So is the following ok once the regtest finishes? > > Bootstrapped on x86_64-linux. > > 2014-08-19 Marek Polacek > > * config/alpha/alpha.h (CLZ_DEFINED_VALUE_AT_ZERO, > CTZ_DEFINED_VALUE_AT_ZERO): Return 0/1 rather th

Re: [PATCH] Quash Wbool-compare warning in optabs.c

2014-08-19 Thread Marek Polacek
On Tue, Aug 19, 2014 at 07:52:33AM -0700, Richard Henderson wrote: > On 08/19/2014 07:12 AM, Marek Polacek wrote: > > On some archs, C[TL]Z_DEFINED_VALUE_AT_ZERO macros return only > > true/false, so -Wbool-compare would warn. > > Then we should fix them to return 0/1 instead. Works as well. So

[COMMITTED] Remove myself from MAINTAINERS

2014-08-19 Thread Christopher Faylor
Committed as revision 214157. 2014-08-19 Christopher Faylor * MAINTAINERS: Remove myself Index: MAINTAINERS === --- MAINTAINERS (revision 214153) +++ MAINTAINERS (working copy) @@ -136,7 +136,6 @@ VMS

Re: [PATCH][AArch64] Use CC_Z and CC_NZ with csinc and similar instructions

2014-08-19 Thread Kyrill Tkachov
On 19/08/14 16:25, Richard Henderson wrote: On 08/19/2014 06:29 AM, Kyrill Tkachov wrote: +(define_special_predicate "cc_register_zero" + (and (match_code "reg") + (and (match_test "REGNO (op) == CC_REGNUM") + (ior (match_test "mode == GET_MODE (op)") +(ior (mat

[committed] Fix typo in diagnostics

2014-08-19 Thread Marek Polacek
I noticed a typo in a diagnostic message. No test needs adjusting. Bootstrapped/regtested on x86_64-linux, applying to trunk. 2014-08-19 Marek Polacek * lex.c (_cpp_lex_direct): Fix a typo. diff --git gcc/lex.c gcc/lex.c index 0713f65..827cfb0 100644 --- gcc/lex.c +++ gcc/lex.c @@ -

Re: [PATCH 014/236] VINSN_INSN_RTX scaffolding

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 15:21 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > For now, convert into VINSN_INSN_RTX a pair of functions. We will > > eventually change them back to a macro once the relevant field is of type > > rtx_insn *. > > > > gcc/ > > * sel-sched-ir.h (VI

Re: [PATCH] gcc/c/c-aux-info.c: Resize 'buff' from 10 to 14 bytes

2014-08-19 Thread Chen Gang
Excuse me, I did not finish in time. At present, I shall be mainly focus on testsuite. Before I finish it, I can do nothing (I should do nothing) for this patch. Originally: - I get a PC (not buy), it is low quality which cause reboot after run several hours with full cpu used, I wasted much

Re: [PATCH 013/236] DEP_PRO/DEP_CON scaffolding

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 15:21 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > For now, convert DEP_PRO and DEP_CON into functions. We will eventually > > change them back to macros once the relevant fields are of type > > rtx_insn *. > > > > gcc/ > > * sched-int.h (DEP_PRO):

Re: [PATCH] _cxa_thread_atexit fixes for Cygwin/MinGW-w64

2014-08-19 Thread Kai Tietz
Applied at revision 214163. Thanks, Kai

Re: [PATCH] cygwin: accept -pthread

2014-08-19 Thread Kai Tietz
Patch is ok. Applied this patch at revision 214161 together with your followup-patch at revision 214162. Thanks, Kai

Re: [PATCH] cygwin: __cxa_atexit support

2014-08-19 Thread Kai Tietz
Patch is ok. Applied this patch at revision 214162 together with your followup-patch at revision 214161. Thanks, Kai

Re: [PATCH][AArch64] Use CC_Z and CC_NZ with csinc and similar instructions

2014-08-19 Thread Richard Henderson
On 08/19/2014 06:29 AM, Kyrill Tkachov wrote: > +(define_special_predicate "cc_register_zero" > + (and (match_code "reg") > + (and (match_test "REGNO (op) == CC_REGNUM") > + (ior (match_test "mode == GET_MODE (op)") > + (ior (match_test "mode == VOIDmode > +

[PATCH][ARM][1/7] Convert FP mnemonics to UAL | mov patterns

2014-08-19 Thread Kyrill Tkachov
Hi all, In this patch the move patterns are updated. For the fconst case where the constant is encoded in a decimal representation before going into the immediate field of the assembly instruction UAL syntax allows for the real operand to be output directly and leaves the assembler to do the enco

Re: [PATCH 012/236] Convert DF_REF_INSN to a function for now

2014-08-19 Thread David Malcolm
On Tue, 2014-08-12 at 15:20 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > DF_REF_INSN looks up the "insn" field of the referenced df_insn_info. > > This will eventually be an rtx_insn *, but for now is just an rtx. > > > > As further scaffolding: for now, convert DF_REF_INSN

[PATCH][ARM][2/7] Convert FP mnemonics to UAL | add/sub/div/abs patterns

2014-08-19 Thread Kyrill Tkachov
Hi all, Nothing too controversial here, convert the concerned patterns to UAL. The size of the data types in the operation is expressed in the .f32 or .f64 suffix. Ok for trunk? Thanks, Kyrill 2014-08-19 Kyrylo Tkachov * config/arm/vfp.md (*abssf2_vfp): Use UAL assembly syntax. (

[COMMITTED] Add myself to MAINTAINERS (Write After Approval)

2014-08-19 Thread VandeVondele Joost
Committed revision 214159. 2014-08-19 Joost VandeVondele * MAINTAINERS (Write After Approval): Add myself. Index: MAINTAINERS === --- MAINTAINERS (revision 214158) +++ MAINTAINERS (working copy) @@ -561,6 +561,7 @@ Markus

Re: [PATCH] Move caret printing to diagnostics_finalizer

2014-08-19 Thread Dodji Seketeli
Manuel López-Ibáñez writes: > This patch is in preparation for further patches moving the Fortran FE > to use the common diagnostics machinery. > > Fortran has its own way of printing the caret information, so we need > a way to override the default in the diagnostics machinery. A simple > way is

[PATCH][ARM][7/7] Convert FP mnemonics to UAL | f{ld,st}m -> v{ld,st}m

2014-08-19 Thread Kyrill Tkachov
Hi all, This patch updates some FP load/store multiple patterns and in the vfp_output_vstmd case when the instruction is used as a push to sp it now emits a vpush mnemonic instead of vstmdb. Ok for trunk? Thanks, Kyrill 2014-08-19 Kyrylo Tkachov * config/arm/arm.md (vfp_pop_multiple

[PATCH][ARM][6/7] Convert FP mnemonics to UAL | movcc_vfp (fmstat)

2014-08-19 Thread Kyrill Tkachov
Hi all, The ARM ARM explicitly says that fmstat is translated into 'vmrs APSR_nzcvm, FPSCR' in UAL syntax so this patch does that. Ok for trunk? Thanks, Kyrill 2014-08-19 Kyrylo Tkachov * config/arm/vfp.md (*movcc_vfp): Use UAL syntax.commit f33bf477f1e30e1125250838843343facb2a7716 A

[PATCH][ARM][5/7] Convert FP mnemonics to UAL | sqrt and FP compare patterns

2014-08-19 Thread Kyrill Tkachov
Hi all, The sqrt and floating point compare patterns. For the case when we compare with floating-point 0 the ARM ARM uses the syntax 'vcmp {s,d}, #0.0' but current gas has a bug and doesn't accept that form, only 'vcmp {s,d}, #0' There is a gas patch in review on the binutils mailing list but

[PATCH][ARM][4/7] Convert FP mnemonics to UAL | vcvt patterns

2014-08-19 Thread Kyrill Tkachov
Hi all, These are the fp<->fp and int<->fp convert patterns. IMHO these are much more readable than the pre-UAL ones because they use two suffixes to indicate which data types are being converted to and from. Ok for trunk? Thanks, Kyrill 2014-08-19 Kyrylo Tkachov * config/arm/vfp.md

[PATCH][ARM][3/7] Convert FP mnemonics to UAL | mul+add patterns

2014-08-19 Thread Kyrill Tkachov
Hi all, This patch switches over the FP mul+add, mul+neg+add etc patterns. Mixing some of the mnemonics up is a danger but the ARM ARM has a handy section that maps each mnemonic to its UAL equivalent. Ok for trunk? Thanks, Kyrill 2014-08-19 Kyrylo Tkachov * config/arm/vfp.md (*muls

Re: [PATCH] cygwin: fix --tsaware, add --large-address-aware

2014-08-19 Thread Kai Tietz
Applied for you at revision 214158. Kai

[PATCH][0/7][ARM] Convert VFP mnemonics to UAL

2014-08-19 Thread Kyrill Tkachov
Hi all, This patch series converts the arm backend to output unified assembly syntax for the VFP instructions. This makes it more readable since most UAL mnemonics also include various type suffixes such as .f32 and .f64 that quickly allow to identify the data types being operated on. Each p

Re: [PATCH] Fix cygwin-stdint.h

2014-08-19 Thread Kai Tietz
Applied for you at revision 214156. Kai

  1   2   >