Re: [C/C++ PATCH] Implement -Wbool-compare (PR c++/62153)

[Marek Polacek]

On Tue, Aug 19, 2014 at 01:41:44PM -0400, Jason Merrill wrote:
> On 08/19/2014 12:52 PM, Marek Polacek wrote:
> >+  tree cst = TREE_CODE (op0) == INTEGER_CST
> >+         ? op0 : TREE_CODE (op1) == INTEGER_CST ? op1 : NULL_TREE;
> 
> This indentation won't survive Emacs auto-indent; please add parentheses.
> 
> >+      int sign = TREE_CODE (op0) == INTEGER_CST
> >+             ? tree_int_cst_sgn (cst) : -tree_int_cst_sgn (cst);
> 
> Likewise.

All right, will fix 'em.
 
> OK with those fixed.

Thanks!

        Marek