Hello All:
It is a simple way for finding these kinds of issues (issues may not be
bugs), one sample for 'strncpy' (the same way for sprintf, strcpy,
memcpy ...):
- grep strncpy in all source code.
- and then check each one by one.
- at present, I have finish check about 30% for strncpy.
Al
On Jul 28, 2014, at 5:14 PM, H.J. Lu wrote:
> wide-int change introduced C++ templates in header file, like
>
> generic_wide_int::precision>>
>
> create_user_defined_type in gengtype.c calls
Hum… In the original wide-int, the templates where less beefy; the code worked
because the types were
Hi there,
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61330.
There will be an ICE in gcc trunk for targets support section anchor
optimization when compiling this case(like arm and mips). This looks like an
old bug which is exposed by recent patch.
In make_decl_rtl, when you declare register ty
wide-int change introduced C++ templates in header file, like
generic_wide_int::precision>>
create_user_defined_type in gengtype.c calls
1. strtok (arg, ",>").
2. resolve_typedef (field_name, pos), which calls create_user_defined_type,
which calls strtok (arg, ",>") again.
3. strtok (0, ",>"), w
Applied, though I noticed the mirror is a few weeks behind right now.
Gerald
Index: mirrors.html
===
RCS file: /cvs/gcc/wwwdocs/htdocs/mirrors.html,v
retrieving revision 1.224
diff -u -r1.224 mirrors.html
--- mirrors.html18 J
On 7/28/2014 12:42 PM, Jeff Law wrote:
On 07/27/14 01:26, David Wohlferd wrote:
I'm not sure which maintainer to cc for inline asm stuff?
I have a release on file with the FSF, but don't have SVN write access.
Problem:
extract_insn() in recog.c will ICE if (noperands > MAX_RECOG_OPERANDS).
No
On Thu, 24 Jul 2014, Jakub Jelinek wrote:
> On Wed, Jul 23, 2014 at 04:52:23PM -0700, Andrew Pinski wrote:
> > > Comments, objections? Ok to apply the preliminary patch?
> >
> > Yes, what if you don't move the tests but just change how the .exp to
> > use the same infrastructure as gcc.dg/torture
On Wed, 23 Jul 2014, David Wohlferd wrote:
> 2014-07-23 David Wohlferd
>
> * doc/c-family/c-format.c: Add support for target macro
> ASM_FPRINTF_TABLE, remove arm-specific formats.
> * gcc/config/arm/arm.h: Use ASM_FPRINTF_TABLE for %@ and %r.
> * gcc/doc/tm.te
I agree with you that rtl_verify_edges() shouldn't be changed.
While I am not sure about purge_dead_edges() since it is not something
one looks at when bringing a new flag. But it hasn't caused problems
so far, so I can't necessitate changing it either...
On Tue, Jul 22, 2014 at 8:16 PM, Jeff Law
From: Trevor Saunders
Hi,
It turns out r212968 broke i686-elf because dispite appearances to the
contrary ix86_return_in_memory () doesn't actually always use the fntype
argument (sometimes the macro takes it and ignores it). So revert the relevent
hunk from that commit.
tested that x86_64-un
>> In the case of loc_checksum(), we're tied to MD5 by the DWARF
>> standard. Otherwise, we could just rewrite it to use inchash
>> throughout.
>
> I'm not sure I understand the motivation. If gcc hashes in
> gcc specific stuff (and this hash, even before my changes is)
> then the output can never
This patch implements -fcoarray=lib support for CRITICAL blocks and
includes some preparatory work for locking. In particular:
* Updated the documentation for locking/critical, minor cleanup. The
patch goes on top of the unreviewed patch
https://gcc.gnu.org/ml/fortran/2014-07/msg00155.html
*
On Mon, 28 Jul 2014, Marek Polacek wrote:
> -Wodr entry was missing an @item. Plus some corrections.
>
> Ok for trunk?
>
> 2014-07-28 Marek Polacek
>
> * doc/invoke.texi (-Wno-odr): Fix @item entry. Tweak wording.
Jeff already okayed, but in any case you should feel welcome to
make c
On 07/27/14 01:26, David Wohlferd wrote:
I'm not sure which maintainer to cc for inline asm stuff?
I have a release on file with the FSF, but don't have SVN write access.
Problem:
extract_insn() in recog.c will ICE if (noperands > MAX_RECOG_OPERANDS).
Normally this isn't a problem since expand_
> Jan Hubicka writes:
>
> > There are similar testcases in bugzilla where we do not devirtualize
> > because we
> > lost track of type promises C++ language makes on memory accesses. This may
> > give us a clue how common these are.
>
> How would the user know without some optional warning?
I
On Mon, Jul 28, 2014 at 11:48:58AM -0700, Cary Coutant wrote:
> > + /* ??? MD5 of another hash doesn't make a lot of sense... */
> > + hash = hstate.end();
> >CHECKSUM (hash);
>
> [citation needed] I don't see why you think that. Maybe it'd be nicer
> if we could use hash_loc_operands() to f
It turned out that I needed to insert this cleanup before the final one. This
patch breaks out the dumping functionality from gcov exit, and thereby removes
the global variables from the former. This makes gcov-tool less dependent on
what should be internal interfaces in libgcov.
I also noti
> + /* ??? MD5 of another hash doesn't make a lot of sense... */
> + hash = hstate.end();
>CHECKSUM (hash);
[citation needed] I don't see why you think that. Maybe it'd be nicer
if we could use hash_loc_operands() to feed its input directly into
the MD5 checksum, but I think in this case it'
On 2014-07-28 13:09, Andrew Sutton wrote:
3) auto (*f (auto)) (auto); // generic function 'f' constrained to
returning a unary function pointer deduced from the return
expression.
Really? I've read the comment and I'm still not sure how to read this
declaration.
The first and last 'auto' in
On 07/28/14 09:19, Marek Polacek wrote:
-Wodr entry was missing an @item. Plus some corrections.
Ok for trunk?
2014-07-28 Marek Polacek
* doc/invoke.texi (-Wno-odr): Fix @item entry. Tweak wording.
OK.
Jeff
Senthil Kumar Selvaraj schrieb:
The below patch adds a new preprocessor define for the device name
(__AVR_DEVICE_NAME__) that was passed to the compiler.
While the device name macro (say __AVR_ATmega128__) can be used to
check for a specific device, there is no way right now for code
to get th
I just committed this change from upstream config.sub (there are no
changes upstream in config.guess).
Thanks,
AG
2014-07-28 Anthony Green
Import from savannah.gnu.org:
* config.sub: Update to 2014-07-28 version.
Index: config.sub
=
On 07/28/2014 10:02 AM, Thomas Schwinge wrote:
> Hi Cesar!
>
> On Sun, 6 Jul 2014 16:10:56 -0700, Cesar Philippidis
> wrote:
>> This patch is the first step to enabling parallel reductions in openacc.
>
> I think I have found one issue in this code -- but please verify that my
> understanding o
On 07/27/2014 10:06 PM, Braden Obrzut wrote:
So given this, should I leave the test cases that fail for this reason
alone or should I still change them to dg-message? It sounds like GCC's
behavior with auto in function parameters needs to be changed, but that
definitely sounds like a separate pa
On Wed, 16 Jul 2014, Peter Bergner wrote:
> > > This seems weird. Why wasn't this file included before or whenever it
> > > was added for other *-linux targets? This seems to define SPECs that
> > > should have been necessary before now.
>
> This was comitted by Joseph with revision 168711 and s
On Fri, Jul 25, 2014 at 09:38:49PM +, Joseph S. Myers wrote:
> On Tue, 15 Jul 2014, Michael Meissner wrote:
>
> > This patch is the machine independent patch for libgcc to add IEEE 128-bit
> > floating point to the PowerPC.
> >
> > This patch allows the PowerPC port to override the TFtype in
On 07/28/2014 09:27 AM, Thomas Schwinge wrote:
> On Mon, 28 Jul 2014 07:26:30 -0700, Cesar Philippidis
> wrote:
>> After testing the reduction clause inside fortran subroutines, I noticed
>> that I wasn't handling reference variables properly. This patch fixes
>> that. Is this OK for gomp-4_0-br
Hi Cesar!
On Sun, 6 Jul 2014 16:10:56 -0700, Cesar Philippidis
wrote:
> This patch is the first step to enabling parallel reductions in openacc.
I think I have found one issue in this code -- but please verify that my
understanding of reductions is correct. Namely:
> --- a/gcc/omp-low.c
> +++
On 07/26/2014 05:35 AM, Uros Bizjak wrote:
> On Mon, May 2, 2011 at 9:21 AM, Uros Bizjak wrote:
>
>> It looks that GP relative relocations do not fit anymore into GPREL16
>> reloc, so bootstrap on alpha hosts fail in stage2 with "relocation
>> truncated to fit: GPREL16 against ...". I found no o
On 07/25/2014 09:01 AM, Thomas Schwinge wrote:
> On Thu, 24 Jul 2014 15:44:13 -0700, Cesar Philippidis
> wrote:
>> On 07/24/2014 06:11 AM, Thomas Schwinge wrote:
>>> I'd suggest to continue to handle all the data clauses [...]
>>
>> I moved all of the data clause matching back to gfc_match_omp_c
Jan Hubicka writes:
> There are similar testcases in bugzilla where we do not devirtualize because
> we
> lost track of type promises C++ language makes on memory accesses. This may
> give us a clue how common these are.
How would the user know without some optional warning?
-Andi
Update the overloading rules for constraints to bring them into line
with the current wording. This handles overloads of member functions
of class template specializations separately from function templates.
Currently, functions that are not specializations of templates (or
temploids) can only be
Hi Cesar!
On Mon, 28 Jul 2014 07:26:30 -0700, Cesar Philippidis
wrote:
> After testing the reduction clause inside fortran subroutines, I noticed
> that I wasn't handling reference variables properly. This patch fixes
> that. Is this OK for gomp-4_0-branch?
Yes, thanks!
Grüße,
Thomas
pgpAk
On Jul 28, 2014, at 3:29 AM, Gerald Pfeifer wrote:
> On Fri, 25 Jul 2014, Martin Liška wrote:
>>> Yes, --enable-languages=all is the default, so it only builds the
>>> frontends that are enabled by default, so it does not build the Go or
>>> Ada frontends. I know it doesn't make much sense.
>> I
Please find the following patch for init_priority support for microblaze.
Testing Done : No regressions seen in gcc and g++ regressions testsuite.
[Patch, microblaze]: Add Init_priority support.
Added TARGET_ASM_CONSTRUCTOR and TARGET_ASM_DESTRUCTOR macros. These
macros allows use
-Wodr entry was missing an @item. Plus some corrections.
Ok for trunk?
2014-07-28 Marek Polacek
* doc/invoke.texi (-Wno-odr): Fix @item entry. Tweak wording.
diff --git gcc/doc/invoke.texi gcc/doc/invoke.texi
index aaa5a68..7cebb9e 100644
--- gcc/doc/invoke.texi
+++ gcc/doc/invoke.
Tom> I've finally updated this patch. I think I've addressed all the review
Tom> comments.
Ping.
Tom
Hi,
this patch removes some unused variables and fixes bootstrap of the
gomp-4_0-branch.
Committed to gomp-4_0-branch as trivial.
Thanks,
- Tom
2014-07-28 Tom de Vries
* omp-low.c (process_reduction_data): Remove unused variables.
diff --git a/gcc/omp-low.c b/gcc/omp-low.c
index b188e2d.
Hi,
this patch implements basic support for speculation within polymorphic call
contextes. As we are still having heated discussion how much types in memory
can change, this allows us to deal with these cases speculatively - that is,
anticipate that placement news are not present.
This patch als
> Matthias Klose wrote:
>
> > #define rs6000_special_adjust_field_align_p(FIELD, COMPUTED) 0
> >
> > is what succeeds for me. false is not defined for ObjC. Checked in on the
> > trunk
> > and the branches.
>
> Since we didn't backport the actual ABI change to the branches, only the
> warning,
On Mon, Jul 28, 2014 at 06:29:22PM +0400, Yury Gribov wrote:
> On 07/28/2014 03:01 PM, Trevor Saunders wrote:
> >>Yeah. Do you have some particular complaints btw?
> >
> >I haven't actually used it in a while, but istr there's an issue where
> >if you change the prototype of a function mklog makes
On 07/28/2014 03:01 PM, Trevor Saunders wrote:
Yeah. Do you have some particular complaints btw?
I haven't actually used it in a while, but istr there's an issue where
if you change the prototype of a function mklog makes an entry for the
previous function.
I think this is because mklog relie
Hi Thomas,
After testing the reduction clause inside fortran subroutines, I noticed
that I wasn't handling reference variables properly. This patch fixes
that. Is this OK for gomp-4_0-branch?
Thanks,
Cesar
2014-07-24 Cesar Philippidis
gcc/
* omp-low.c (get_base_type): New function.
(scan_s
On 07/24/2014 11:48 AM, Jakub Jelinek wrote:
> So, either support for just EAF*, or perhaps support for DECL_ATTRIBUTES
> for internal-fns, say by having some tree array where you'd store
what you
> stick into DECL_ATTRIBUTES normally.
I'd prefer to avoid attributes. Would something like this b
On Mon, 2014-07-28 at 02:35 +0530, Prathamesh Kulkarni wrote:
> - if (o->type == operand::OP_CAPTURE)
> + if (is_a (o))
> {
> - capture *c = static_cast (o);
> - fprintf (f, "@%s", (static_cast (o))->where);
> + capture *c = as_a (o);
FWIW, if you're doing an is_a followed b
On Sat, 2014-07-26 at 06:24 -0400, David Edelsohn wrote:
> On Fri, Jul 25, 2014 at 3:26 PM, Peter Bergner wrote:
> > * config.gcc (powerpc*-*-linux*): Include gnu-user.h in tm_file.
> > * config/rs6000/sysv4.h (CC!_SPEC): Undefine it before defining it.
> > * config/rs6000/
Please find attached the fixed patch files for this change:
1. Add command line option -fforce-dwarf-lexical-blocks.
2. Support flag_force_dwarf_blocks in C.
3. Support flag_force_dwarf_blocks in C++.
Attached also are the proposed ChangeLog additions, named according to
On 02/07/14 09:15, Sebastian Huber wrote:
> This change is necessary to support Cortex-R based chips in RTEMS.
>
> This patch should be applied to GCC 4.8, 4.9 and mainline. I do not
> have write access, so in case this gets approved, please commit it for
> me.
>
> gcc/ChangeLog
> 2014-07-02 Se
'errbuf' assumes itself will be zero terminated, and it also assumes
cpnative_getErrorString() may get larger length string than 'errbuf'.
So after strncpy(), 'errbuf' may not be zero terminated.
strncpy() is sure of zero pad, but not be sure of zero terminated.
Signed-off-by: Chen Gang
---
li
>> It sounds like GCC's behavior with auto in function parameters
>> needs to be changed, but that definitely sounds like a separate
>> patch to me.
>>
> I think so. It's definitely a different patch.
Agreed.
> I've been
> thinking about a simple way for your patch to add to the
> constraints fo
Matthias Klose wrote:
> #define rs6000_special_adjust_field_align_p(FIELD, COMPUTED) 0
>
> is what succeeds for me. false is not defined for ObjC. Checked in on the
> trunk
> and the branches.
Since we didn't backport the actual ABI change to the branches, only the
warning,
I think it would be
> On 07/24/2014 07:36 PM, Jan Hubicka wrote:
> >ipa-deivrt has code to do the tracking for you. All is needed is to cal
> >get_odr_type
> >for all polymorphic type that we care about. build_type_inheritance_graph
> >just
> >walks all virtual methods to register all polymorphic types that matters
Ping!
2014-07-14 16:16 GMT+04:00 Richard Biener :
> On Mon, Jul 14, 2014 at 12:16 PM, Yuri Rumyantsev wrote:
>> Ping!
>
> It's in my queue (pretty large patch for a drive-by review - maybe there is
> an opportunity to split the patch up?).
>
> Won't get to it before the Cauldron though.
>
> Richa
On Mon, Jul 28, 2014 at 10:42:51AM +0400, Yury Gribov wrote:
> On 07/21/2014 12:55 PM, Trevor Saunders wrote:
> >I'm not really sure which is the better UI,
> >but I'd rather time be spent
> >on better automatic change log generation.
>
> Yeah. Do you have some particular complaints btw?
I haven'
On Fri, 25 Jul 2014, Martin Liška wrote:
>> Yes, --enable-languages=all is the default, so it only builds the
>> frontends that are enabled by default, so it does not build the Go or
>> Ada frontends. I know it doesn't make much sense.
> I would suggest to replace currently used 'all' to 'default'
On Sun, Jul 27, 2014 at 11:05 PM, Prathamesh Kulkarni
wrote:
> Is it okay to include is-a.h ?
> I have adjusted print_operand to use is_a<> and as_a<> in this patch.
>
> * genmatch.c (is-a.h): Include.
> (is_a_helper::test): Specialize for operand subclasses.
> (print_operand): Adjust to u
On Sun, Jul 27, 2014 at 10:45 PM, Prathamesh Kulkarni
wrote:
> Added checks to see if either cmmand-line options is not repeated,
> and generates match-and-simplify code on both GENERIC and GIMPLE
> if both -generic and -gimple are specified.
I don't think we want to do this - in GCC earlier opti
Hi,
here is updated version of the patch to avoid streaming trees that are local.
I made it mostly to see what effect it have on collisions (as I think having
unmergeable trees in the SCC hash artificially increase collision rate for
trees derrived from this).
To my surprise the number are quite d
On Sat, Jul 26, 2014 at 10:14 PM, Prathamesh Kulkarn
wrote:
> Reject for that has no pattern defined.
> eg - (for op in plus minus)
>
> * genmatch.c (parse_for): Reject for that has no pattern defined.
Thanks - commited.
Richard.
> Thanks and Regards,
> Prathamesh
Jakub,
we're using expand_omp_for_static_chunk with a chunk_size of one to expand the
openacc loop construct.
This results in an inner and outer loop being generated, with the inner loop
having a trip count of one, which means that the inner loop can be simplified to
just the inner loop body. How
On Mon, 28 Jul 2014, Markus Trippelsdorf wrote:
> On 2014.07.28 at 10:53 +0200, Jakub Jelinek wrote:
> > On Mon, Jul 28, 2014 at 10:44:15AM +0200, Jakub Jelinek wrote:
> > > On Mon, Jul 28, 2014 at 09:50:24AM +0200, Richard Biener wrote:
> > > > --- gcc/testsuite/gcc.target/i386/pr61801.c (rev
On 2014.07.28 at 10:53 +0200, Jakub Jelinek wrote:
> On Mon, Jul 28, 2014 at 10:44:15AM +0200, Jakub Jelinek wrote:
> > On Mon, Jul 28, 2014 at 09:50:24AM +0200, Richard Biener wrote:
> > > --- gcc/testsuite/gcc.target/i386/pr61801.c (revision 0)
> > > +++ gcc/testsuite/gcc.target/i386/pr6180
This fixes the performance regression introduced by my recent patch that added
the X - Y CMP 0 to X CMP Y transformation to the folder for other operators
than the equality operators. It turns out that it badly interacts with another
one in fold_cond_expr_with_comparison which attempts to synth
On Mon, Jul 28, 2014 at 10:44:15AM +0200, Jakub Jelinek wrote:
> On Mon, Jul 28, 2014 at 09:50:24AM +0200, Richard Biener wrote:
> > --- gcc/testsuite/gcc.target/i386/pr61801.c (revision 0)
> > +++ gcc/testsuite/gcc.target/i386/pr61801.c (working copy)
> > @@ -0,0 +1,22 @@
> > +/* { dg-do compile }
> On Mon, Jul 28, 2014 at 10:23:36AM +0200, Jan Hubicka wrote:
> > > On Sun, Jul 27, 2014 at 1:02 PM, Marek Polacek wrote:
> > > > Wodr in common.opt was missing a Var, which means:
> > > > 1) we ICE with -Wodr, since -Wodr isn't handled in opts.c;
> > > > 2) -Wno-odr wouldn't work.
> > > > Thus f
> > > Fixes for high level libraries should also be
> > > high level (dmult vs __FLT_MAX_EXP__); i.e. there should be no change in
> a
> > > different package which is specific for MIPS. The type double should
> stay
> > > double and is handled without a problem when the FPU is 32 bit in ABI
> o32.
On Fri, 25 Jul 2014, Jeff Law wrote:
> On 07/24/14 03:35, Richard Biener wrote:
> >
> > The following fixes one of the most annoying parts of non-working -ftrapv,
> > namely that we only support >= word_mode trappings (quite annoying on
> > 64bit archs where 'int' is not handled). At least on x8
On Mon, Jul 28, 2014 at 09:50:24AM +0200, Richard Biener wrote:
> --- gcc/testsuite/gcc.target/i386/pr61801.c (revision 0)
> +++ gcc/testsuite/gcc.target/i386/pr61801.c (working copy)
> @@ -0,0 +1,22 @@
> +/* { dg-do compile } */
> +/* { dg-options "-Os -fcompare-debug" } */
> +
> +int a, b, c;
On Mon, Jul 28, 2014 at 10:23:36AM +0200, Jan Hubicka wrote:
> > On Sun, Jul 27, 2014 at 1:02 PM, Marek Polacek wrote:
> > > Wodr in common.opt was missing a Var, which means:
> > > 1) we ICE with -Wodr, since -Wodr isn't handled in opts.c;
> > > 2) -Wno-odr wouldn't work.
> > > Thus fixed. I'd t
> On Sun, Jul 27, 2014 at 1:02 PM, Marek Polacek wrote:
> > Wodr in common.opt was missing a Var, which means:
> > 1) we ICE with -Wodr, since -Wodr isn't handled in opts.c;
> > 2) -Wno-odr wouldn't work.
> > Thus fixed. I'd think this doesn't need a testcase...
> >
> > Bootstrapped/regtested on
This fixes PR61921 - I failed to remember PTA builds fake global
decls which we don't have a varpool node for. Fixed.
Tested on x86_64-unknown-linux-gnu, applied.
Richard.
2014-07-28 Richard Biener
PR tree-optimization/61921
* tree-ssa-structalias.c (create_variable_info_fo
On Sun, Jul 27, 2014 at 9:37 PM, Andi Kleen wrote:
> From: Andi Kleen
>
> gcc/:
>
> 2014-07-25 Andi Kleen
>
> * asan.c (asan_mem_ref_hasher::hash): Convert to inchash.
> ---
> gcc/asan.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/asan.c b/gcc/a
External function gfc_explicit_interface_required() assumes the input
parameter 'errmsg' will be a zero terminated string after return, and
the input parameter 'err_len' is full length of 'errmsg'.
If 'err_len' would have real effect -- truncate 'errmsg' by strncpy()
which will zero pad but not be
On Sun, Jul 27, 2014 at 8:01 PM, Richard Sandiford
wrote:
> PR 61919 is another ripple from the patch to take advantage of rtx
> sharing rules when instantiating virtual registers. In this case
> the invalid sharing is coming from tree-outof-ssa.c, where the same
> MEM rtx is being used in severa
On Sun, Jul 27, 2014 at 1:02 PM, Marek Polacek wrote:
> Wodr in common.opt was missing a Var, which means:
> 1) we ICE with -Wodr, since -Wodr isn't handled in opts.c;
> 2) -Wno-odr wouldn't work.
> Thus fixed. I'd think this doesn't need a testcase...
>
> Bootstrapped/regtested on x86_64-linux,
Tested on x86_64-unknown-linux-gnu, applied to trunk and branches.
Richard.
2014-07-28 Richard Biener
PR rtl-optimization/61801
* gcc.target/i386/pr61801.c: New testcase.
Index: gcc/testsuite/gcc.target/i386/pr61801.c
=
On Fri, 25 Jul 2014, Martin Jambor wrote:
> Hi,
>
> parameter stmt of sra_modify_assign and sra_modify_constructor_assign
> is currently gimple*, although there is no need for the extra level of
> indirection and dereferencing. Thus this patch removes quite few
> stars and one ampersand.
>
> Bo
On 2014-07-28 3:06, Braden Obrzut wrote:
So given this, should I leave the test cases that fail for this
reason alone or should I still change them to dg-message?
I'm not sure what GCC's policy is here, Jason will.
It sounds like GCC's behavior with auto in function parameters
needs to be cha
78 matches
Mail list logo
