Re: update address taken: don't drop clobbers

2014-07-11 Thread Marc Glisse
On Thu, 10 Jul 2014, Richard Biener wrote: --- gcc/tree-into-ssa.c (revision 212109) +++ gcc/tree-into-ssa.c (working copy) @@ -1831,26 +1831,38 @@ maybe_register_def (def_operand_p def_p, { tree def = DEF_FROM_PTR (def_p); tree sym = DECL_P (def) ? def : SSA_NAME_VAR (def); /* If DEF

Re: [PATCH, libstdc++] Add the logistic distribution as an extension

2014-07-11 Thread Ed Smith-Rowland
On 07/11/2014 11:42 AM, Paolo Carlini wrote: Hi, On 07/11/2014 05:38 PM, Ed Smith-Rowland wrote: OK? Ok, thanks, but please adjust the dates you have on the testcases to the date of the actual commit (I suppose today or tomorrow) Thanks again! Paolo. As committed. Thanks all for looking a

Re: [Patch] PR 61662

2014-07-11 Thread David Wohlferd
Doh! Since the component here is 'Target', I probably should have included the x86-64 Port Maintainer in the TO line. Jan, while I have a release on file with the FSF, I don't have SVN write access. dw On 7/9/2014 12:51 AM, David Wohlferd wrote: As requested, I am posting this patch to gcc

libgo patch committed: Update to revision 19185

2014-07-11 Thread Ian Lance Taylor
This patch to libgo merges in master revision 19185. This revision renamed and edited several files in the runtime directory. The files were changed from .c to .goc; .goc is a file that uses Go function declaration syntax with C function bodies. It's a convenient way to write Go-callable functio

[PATCH, alpha]: Add TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-07-11 Thread Uros Bizjak
Hello! Attached patch implements TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook for alpha. The implementation is mostly copied from arm/arm.c, where calls to target builtins are replaced with calls to __ieee_{get,set}_fp_control function, as defined in OSF/1 ABI. The patch also includes a small fix to che

Re: [C++ Patch] PR 53159 (Take 2)

2014-07-11 Thread Jason Merrill
On 07/11/2014 02:02 PM, Paolo Carlini wrote: Is the condition still necessary? I'm removing it and retesting. In any case (the eventual) check_narrowing will return immediately if !ARITHMETIC_TYPE_P (type) is true... Would the amended patch be Ok? Yes, thanks. Jason

[PATCH] Fix #pragma omp task if (0) depend (...) handling

2014-07-11 Thread Jakub Jelinek
Hi! As has been mentioned on omp-lang some time ago, what I've implemented for if (0) tasks is wrong for tasks that depend on some earlier tasks. I chose to ignore the if (0) and make them deferred tasks anyway, but that is not allowed. Instead, we need to wait on all the dependencies and when th

Re: [PATCH] Fix undefined behavior in x86_64 backend (PR target/61656)

2014-07-11 Thread Jan Hubicka
> Hi! > > As mentioned in the PR, if bit_offset is not zero, subclasses array > may contain for unions more entries than classes array. We are going > to ignore the extra entries, because we only check the ones below words, > but as classes[words] and above is uninitialized, this triggers undefin

[PATCH] Fix undefined behavior in x86_64 backend (PR target/61656)

2014-07-11 Thread Jakub Jelinek
Hi! As mentioned in the PR, if bit_offset is not zero, subclasses array may contain for unions more entries than classes array. We are going to ignore the extra entries, because we only check the ones below words, but as classes[words] and above is uninitialized, this triggers undefined behavior.

Re: [PATCH] -Wmemset-transposed-args (PR middle-end/61294, take 2)

2014-07-11 Thread Jakub Jelinek
On Fri, Jul 11, 2014 at 01:29:12AM +0200, Gerald Pfeifer wrote: > On Thu, 10 Jul 2014, Jakub Jelinek wrote: > > +Wmemset-transposed-args > > +C ObjC C++ ObjC++ Var(warn_memset_transposed_args) Warning LangEnabledBy(C > > ObjC C++ ObjC++,Wall) > > +Warn about suspicious call to memset where the thi

Re: Re: [PING][PATCH] Fix for PR 61561

2014-07-11 Thread Christophe Lyon
The new testcase causes an ICE when the compile is configured --with-thumb or when forcing -mthumb. Christophe. On 11 July 2014 11:08, Marat Zakirov wrote: > Thank to you all. > > Committed revision 212450. > > --Marat > > > Original Message > Subject:Re: [PING][PATCH]

Re: [PATCH] offline gcda profile processing tool

2014-07-11 Thread Rong Xu
On Fri, Jul 11, 2014 at 11:46 AM, Jan Hubicka wrote: >> Richard, >> >> I looked at my patch again. I already add -Wno-error to libgcov-util.o >> compilation: >> In line 200 of gcc/Makefile.in >> libgcov-util.o-warn = -Wno-error >> >> In my test, I used gcc-4.6 as the host compiler. I got warning l

[PATCH C++/57644] [C++1y] Cannot bind bitfield to lvalue reference

2014-07-11 Thread Smith-Rowland, Edward M
Just add a test case and close. Can I add this to 4.9 too? Ed CL_pr57644 Description: CL_pr57644 patch_pr57644 Description: patch_pr57644

Re: [PATCH] offline gcda profile processing tool

2014-07-11 Thread Jan Hubicka
> Richard, > > I looked at my patch again. I already add -Wno-error to libgcov-util.o > compilation: > In line 200 of gcc/Makefile.in > libgcov-util.o-warn = -Wno-error > > In my test, I used gcc-4.6 as the host compiler. I got warning like this: > > In file included from ../../gcc/gcc/../libgcc

Re: Use separate sections to stream non-trivial constructors

2014-07-11 Thread Jan Hubicka
Hi this is patch i am going to commit after testing. It removes DECL_INIT_IO timevar that guards only one variable set (so hardly measure anything) and moves GIMPLE_IN to proper place. It also adds CTORS_IN and CTORS_OUT. I get: ipa lto gimple out : 0.37 ( 0%) usr 0.21 ( 3%) sys 0.64 (

Re: [PATCH] offline gcda profile processing tool

2014-07-11 Thread Rong Xu
Richard, I looked at my patch again. I already add -Wno-error to libgcov-util.o compilation: In line 200 of gcc/Makefile.in libgcov-util.o-warn = -Wno-error In my test, I used gcc-4.6 as the host compiler. I got warning like this: In file included from ../../gcc/gcc/../libgcc/libgcov-util.c:30:0

Re: [C++ Patch] PR 53159 (Take 2)

2014-07-11 Thread Paolo Carlini
Hi, On 07/11/2014 07:58 PM, Jason Merrill wrote: Oops, this patch didn't thread with the earlier one... Yeah, sorry, I considered my drafts of yesterday evening a distraction and wanted to start a fresh thread with a complete (more meaningful) new proposal. Probably not a good idea, after all,

Re: [C++ Patch] PR 53159 (Take 2)

2014-07-11 Thread Jason Merrill
Oops, this patch didn't thread with the earlier one... On 07/11/2014 06:15 AM, Paolo Carlini wrote: if (SCALAR_TYPE_P (type)) Is the condition still necessary? - check_narrowing (type, init); + flags |= LOOKUP_NO_NARROWING; Jason

Re: [C++ Patch/RFC] Back to PR 53159

2014-07-11 Thread Jason Merrill
On 07/10/2014 06:38 PM, Paolo Carlini wrote: if (SCALAR_TYPE_P (type)) + if (!CLASS_TYPE_P (TREE_TYPE (init))) Why this change? check_narrowing only deals with scalar types. Jason

Re: Use separate sections to stream non-trivial constructors

2014-07-11 Thread Jan Hubicka
Hi, this is the variant of patch I comitted. I noticed that partitioning actually calls ctor_for_folding just to figure out if the constant value may be used that drags in every readonly variable ctor into memory at WPA. So now we have separate predicate varpool_ctor_useable_for_folding_p to check

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

2014-07-11 Thread Sriraman Tallam
Ping. On Thu, Jun 26, 2014 at 10:54 AM, Sriraman Tallam wrote: > Hi Uros, > >Could you please review this patch? > > Thanks > Sri > > On Fri, Jun 20, 2014 at 5:17 PM, Sriraman Tallam wrote: >> Patch Updated. >> >> Sri >> >> On Mon, Jun 9, 2014 at 3:55 PM, Sriraman Tallam wrote: >>> Ping. >>

Fix ICE in ipa-devirt while building firefox

2014-07-11 Thread Jan Hubicka
Hi, Firefox build ICEs in ipa-devirt (types_same_for_odr) not being able to establish ODR equivalency for non-polymorphic types. This is because ipa-prop and ipa-cp does call get_binfo_at_offset where it really wants to propagate on types and offsets. Before this is fixed this patch avoids the IC

Re: possible negative patch for gcc/tree-ssa-loop-im.c (or removal of an assert)

2014-07-11 Thread Gaius Mulley
Gaius Mulley writes: > Hello, > > I've been looking through tree-ssa-loop-im.c (while hunting down a bug > in the modula-2 front end) and found a curiosity in > gcc/tree-ssa-loop-im.c. > > It seems that there is dead code in function determine_max_movement > as mem_ref_in_stmt can never return NU

Patch to fix a bug in LRA inheritance

2014-07-11 Thread Vladimir Makarov
The following patch fixes a bug in LRA inheritance found on compiling a big file on s390x. Unfortunately, the bug is very hard to reproduce and the test is too big and can not be included. But even if it were included, checking a correct code generation would be a problem too. The bug was in

Re: update address taken: don't drop clobbers

2014-07-11 Thread Jeff Law
On 07/11/14 06:05, Michael Matz wrote: Hi, On Thu, 10 Jul 2014, Jeff Law wrote: The insight to note is, that undefined SSA names should really be coalesced with something (otherwise you lost an optimization opportunity), but it doesn't matter with _what_ each use of the undefined name is coale

possible negative patch for gcc/tree-ssa-loop-im.c (or removal of an assert)

2014-07-11 Thread Gaius Mulley
Hello, I've been looking through tree-ssa-loop-im.c (while hunting down a bug in the modula-2 front end) and found a curiosity in gcc/tree-ssa-loop-im.c. It seems that there is dead code in function determine_max_movement as mem_ref_in_stmt can never return NULL. static mem_ref_p mem_ref_in_s

Re: [PATCH] offline gcda profile processing tool

2014-07-11 Thread Rong Xu
I did see the warning in the bootstrap, but it did not exit the build. I thought it was ok. I'll have a patch for this and send for review. -Rong On Fri, Jul 11, 2014 at 9:13 AM, Xinliang David Li wrote: > right. > > Rong, the fix would be just change ctr array size to 1. For each > function, t

Re: [PATCH] offline gcda profile processing tool

2014-07-11 Thread Rong Xu
I should use _WIN32 macro. This code is for windows mkdir api. I'll commit a patch for this shortly (approved by honza). -Rong On Fri, Jul 11, 2014 at 8:49 AM, Xinliang David Li wrote: > What is the macro to test POSIX IO on host? The guard uses > TARGET_POSIX_IO which is not right. > > David >

Re: [BUILDROBOT] gcov patch

2014-07-11 Thread Rong Xu
On Fri, Jul 11, 2014 at 8:06 AM, Jan Hubicka wrote: >> Sorry. This code meant to work with the different mkdir api in >> windows. I used wrong ifdef. >> >> Here is the patch. OK for checkin? > OK. I also see the following with LTO bootstrap: > ../../gcc/../libgcc/libgcov-util.c:41:24: error: type

Re: [patch 1/4] change specific int128 -> generic intN

2014-07-11 Thread DJ Delorie
> > PSImode is 20 bits, fits in a 20 bit register, and uses 20 bit operations. > > Then why do you need this change? Because parts of the gcc code use the byte size instead of the bit size, or round up, or assume powers-of-two sizes. > > - TYPE_SIZE (type) = bitsize_int (GET_MODE_BITSIZE (

Re: [Patch, avr] Add atmel ata5782 and ata5831 devices

2014-07-11 Thread Denis Chertykov
2014-07-11 12:50 GMT+04:00 S, Pitchumani : > This patch adds supports for Atmel's ata5782 and ata5831 devices. > > These devices ISA matches with AVR5 architecture except that text section > start for these two devices is 0x8000. By default 0x0 is used as the text > start address. This patch adds a

Re: [PATCH] offline gcda profile processing tool

2014-07-11 Thread Xinliang David Li
right. Rong, the fix would be just change ctr array size to 1. For each function, there should be at least one kind of counters -- see the assertion in build_fn_info_type. There are some code that do 'sizeof(gcov_fn_info)' when computing heap size -- they can be adjusted or leave it as it is (if

Re: [PATCH] offline gcda profile processing tool

2014-07-11 Thread Jakub Jelinek
On Fri, Jul 11, 2014 at 08:42:27AM -0700, Xinliang David Li wrote: > I wonder why. The struct definition for gcov_fn_info has not changed > in this patch. Perhaps it has been used only in C until now? Jakub

Re: [PATCH] offline gcda profile processing tool

2014-07-11 Thread Xinliang David Li
What is the macro to test POSIX IO on host? The guard uses TARGET_POSIX_IO which is not right. David On Fri, Jul 11, 2014 at 1:12 AM, Christophe Lyon wrote: > On 11 July 2014 10:07, Richard Biener wrote: >> On Mon, May 5, 2014 at 7:17 PM, Rong Xu wrote: >>> Here is the updated patch. The diffe

Re: [PATCH, libstdc++] Add the logistic distribution as an extension

2014-07-11 Thread Paolo Carlini
Hi, On 07/11/2014 05:38 PM, Ed Smith-Rowland wrote: OK? Ok, thanks, but please adjust the dates you have on the testcases to the date of the actual commit (I suppose today or tomorrow) Thanks again! Paolo.

Re: [PATCH] offline gcda profile processing tool

2014-07-11 Thread Xinliang David Li
I wonder why. The struct definition for gcov_fn_info has not changed in this patch. David On Fri, Jul 11, 2014 at 1:07 AM, Richard Biener wrote: > On Mon, May 5, 2014 at 7:17 PM, Rong Xu wrote: >> Here is the updated patch. The difference with patch set 3 is >> (1) use the gcov-counter.def for

Re: [PATCH, libstdc++] Add the logistic distribution as an extension

2014-07-11 Thread Ed Smith-Rowland
On 07/10/2014 06:16 AM, Paolo Carlini wrote: .. I have another comment: are we sure the usual strategy: template result_type operator()(_UniformRandomNumberGenerator& __urng) { return this->operator()(__urng, this->_M_param); } doesn't make sense here too? Paolo. >> Look OK

Re: [PATCH v2 2/3] libstdc++ testsuite: Turn off GDB's auto-load, list loaded libs

2014-07-11 Thread Jonathan Wakely
On 10/07/14 22:48 -0400, Samuel Bronson wrote: We load our pretty-printers explicitly, and we shouldn't need any other random -gdb.gdb or -gdb.py files from anywhere, so in this patch we turn that off by running "set auto-load no". Also, run "info share" so that the list of loaded libraries end

Re: [PATCH v2 1/3] Make libstdc++ testsuite work with pre-color GCC versions again

2014-07-11 Thread Jonathan Wakely
On 10/07/14 22:48 -0400, Samuel Bronson wrote: When I try to build & test just libstdc++, or to run the testsuite from trunk against my installed libstdc++, the testsuite tries to pass "-fdiagnostics-color=never" to the system GCC, which is too old to know what that is. Since I really just want

[c++-concepts] fixes

2014-07-11 Thread Andrew Sutton
Fix a couple of issues causing a test regression and boostrap build errors. 2014-07-11 Andrew Sutton * gcc/cp/typeck.c (cp_build_function_call_vec): Emit diagnostic at the input location. * gcc/cp/error.c (dump_template_decl): Constraints are never invalid in thi

Re: [BUILDROBOT] gcov patch

2014-07-11 Thread Jan Hubicka
> Sorry. This code meant to work with the different mkdir api in > windows. I used wrong ifdef. > > Here is the patch. OK for checkin? OK. I also see the following with LTO bootstrap: ../../gcc/../libgcc/libgcov-util.c:41:24: error: type of �gcov_max_filename� does not match original declaration

[PATCH] AIX COMDAT

2014-07-11 Thread David Edelsohn
This patch enables COMDAT functionality on AIX. It defines MAKE_DECL_ONE_ONLY and removes the historical legacy link-line option of -bnodelcsect. -bnodelcsect instructs the AIX (garbage collecting) linker to preserve un-referenced CSECTs (like ELF sections). In the distant past, GCC emitted code

Re: [PATCH] Fix for PR 61561

2014-07-11 Thread Richard Earnshaw
On 19/06/14 21:19, Yuri Gribov wrote: >> Thirdly, we also need to fix movhi_bytes (for pre-v4) thumb2_movhi_insn >> (for thumb2) and, quite possibly, thumb1_movhi_insn (for thumb1). There >> may well be additional changes for movqi variants as well. > > A general question: how should one test ARM

Re: [PATCH preprocessor/61389] - libcpp diagnostics shouldn't talk about ISO C99 for C++ input files

2014-07-11 Thread Andreas Schwab
Tested on x86_64-suse-linux and installed as obvious. Andreas. PR preprocessor/61389 * gcc.dg/cpp/macsyntx.c: Update expected warnings. * gcc.dg/cpp/sysmac1.c: Likewise. diff --git a/gcc/testsuite/gcc.dg/cpp/macsyntx.c b/gcc/testsuite/gcc.dg/cpp/macsyntx.c index 495921e.

Re: Fix PR61772: ifcvt removing asm volatile gotos

2014-07-11 Thread Steven Bosscher
On Fri, Jul 11, 2014 at 2:34 PM, Michael Matz wrote: > PR rtl-optimization/61772 > * ifcvt.c (dead_or_predicable): Check jump to be free of side > effects. This is OK. Ciao! Steven

Re: [BUILDROBOT] gcov patch

2014-07-11 Thread Rong Xu
Sorry. This code meant to work with the different mkdir api in windows. I used wrong ifdef. Here is the patch. OK for checkin? Thanks, -Rong 2014-07-11 Rong Xu * gcov-tool.c (gcov_output_files): Fix build error. Index: gcov-tool.c ===

Re: [PATCH preprocessor/61389] - libcpp diagnostics shouldn't talk about ISO C99 for C++ input files

2014-07-11 Thread Dominique Dhumieres
> Here is a preprocessor patch to make error messages show C++11 > and other relevant C++ language instead of C99. > > Built and tested on x86_64-linux. This caused FAIL: gcc.dg/cpp/macsyntx.c (test for excess errors) FAIL: gcc.dg/cpp/macsyntx.c (test for excess errors) FAIL: gcc.dg/cpp/macsyntx

Re: [PATCH v3 3/3] Port libstdc++ pretty-printers to Python 2 + Python 3

2014-07-11 Thread Jonathan Wakely
On 10/07/14 22:48 -0400, Samuel Bronson wrote: PR libstdc++/58962 * python/libstdcxx/v6/printers.py: Port to Python 2+3 (imap): New compat function. (izip): Likewise. (Iterator): New mixin to allow writing iterators in Python 3 style regardl

Re: [GSoC] generation of Gimple loops with empty bodies

2014-07-11 Thread Tobias Grosser
On 11/07/2014 15:41, Roman Gareev wrote: I've attached an improved version of the patch and the ChangeLog entry. Are they fine for trunk? LGTM. Thank you! Tobias

[PATCH][Ping v4] Add patch for debugging compiler ICEs

2014-07-11 Thread Maxim Ostapenko
Ping. Added small changes due to previous discussion in community. Original Message Subject:[PATCH][Ping v3] Add patch for debugging compiler ICEs Date: Fri, 04 Jul 2014 18:32:44 +0400 From: Maxim Ostapenko To: GCC Patches CC: Yury Gribov , Slava Garbuzov ,

Re: [PATCH][RFC] Fix PR61473, inline small memcpy/memmove during tree opts

2014-07-11 Thread Jakub Jelinek
On Fri, Jul 11, 2014 at 03:36:15PM +0200, Richard Biener wrote: > *** c_strlen (tree src, int only_value) > *** 606,612 > > /* If the offset is known to be out of bounds, warn, and call strlen at >runtime. */ > ! if (offset < 0 || offset > max) > { >

Re: [GSoC] generation of Gimple loops with empty bodies

2014-07-11 Thread Roman Gareev
I've attached an improved version of the patch and the ChangeLog entry. Are they fine for trunk? -- Cheers, Roman Gareev. 2014-07-11 Roman Gareev gcc/ * graphite-isl-ast-to-gimple.c (gmp_cst_to_tree): New function. (graphite_ve

Re: [PATCH][RFC] Fix PR61473, inline small memcpy/memmove during tree opts

2014-07-11 Thread Richard Biener
On Fri, 11 Jul 2014, Richard Biener wrote: > On Thu, 10 Jul 2014, Jakub Jelinek wrote: > > > On Thu, Jul 10, 2014 at 04:30:13PM +0200, Richard Biener wrote: > > > Compromise "hack" below. It simply avoids the transform for > > > sources that c_strlen can compute a length of. That "fixes" all >

Re: [PATCH][sched-deps] Generalise usage of macro fusion to work on any two insns

2014-07-11 Thread Kyrill Tkachov
On 11/07/14 14:20, Alexander Monakov wrote: On Fri, 11 Jul 2014, Kyrill Tkachov wrote: On 10/07/14 22:53, Maxim Kuvyrkov wrote: The patch looks good to me, but some cleanup suggestions below. Thanks, here's an updated patch. How's this? You need to remove 'if (targetm. ...) SCHED_GROUP_P (in

Re: Change an assignment to an assert in varpool

2014-07-11 Thread Jan Hubicka
> I noticed that we set node->definition = true in > varpool_assemble_decl. The surrounding code suggests that we should > only ever get there if definition is already true, so I changed it > to an assert. The question is interesting for some modifications I'm > making for ptx (which requires decla

Re: [PATCH][sched-deps] Generalise usage of macro fusion to work on any two insns

2014-07-11 Thread Alexander Monakov
On Fri, 11 Jul 2014, Kyrill Tkachov wrote: > > On 10/07/14 22:53, Maxim Kuvyrkov wrote: > > The patch looks good to me, but some cleanup suggestions below. > > Thanks, here's an updated patch. > How's this? You need to remove 'if (targetm. ...) SCHED_GROUP_P (insn) = 1;' from the first if branch

Re: [PATCH, AArch64, Testsuite] Specify -fno-use-caller-save for func-ret* tests

2014-07-11 Thread Yufeng Zhang
Hi Tom, On 8 July 2014 20:45, Tom de Vries wrote: > On 01-07-14 19:26, Jeff Law wrote: >> >> On 07/01/14 09:51, Yufeng Zhang wrote: >>> >>> Hi, >>> >>> This patch resolves a conflict between the aapcs64 test framework for >>> func-ret tests and the optimization option -fuse-caller-save, which was

Re: [BUILDROBOT] gcov patch

2014-07-11 Thread Jan-Benedict Glaw
On Fri, 2014-07-11 15:03:06 +0200, Jan-Benedict Glaw wrote: > See eg. http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=289639, > it breaks like this: > > [...] > g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions > -fno-rtti -fasynchronous-unwind-tables -W -Wall

[BUILDROBOT] gcov patch (was: r212448 - in /trunk: gcc/ChangeLog gcc/Makefile...)

2014-07-11 Thread Jan-Benedict Glaw
On Fri, 2014-07-11 05:48:08 -, x...@gcc.gnu.org wrote: > Author: xur > Date: Fri Jul 11 05:48:07 2014 > New Revision: 212448 > > URL: https://gcc.gnu.org/viewcvs?rev=212448&root=gcc&view=rev > Log: > 2014-07-10 Rong Xu > > Add gcov-tool: an offline gcda profile processing tool >

Change an assignment to an assert in varpool

2014-07-11 Thread Bernd Schmidt
I noticed that we set node->definition = true in varpool_assemble_decl. The surrounding code suggests that we should only ever get there if definition is already true, so I changed it to an assert. The question is interesting for some modifications I'm making for ptx (which requires declaration

Re: [PATCH 2/2] Enable elimination of zext/sext

2014-07-11 Thread Richard Biener
On Fri, Jul 11, 2014 at 1:52 PM, Kugan wrote: > Thanks foe the review and suggestions. > > On 10/07/14 22:15, Richard Biener wrote: >> On Mon, Jul 7, 2014 at 8:55 AM, Kugan >> wrote: > > [...] > >>> >>> For -fwrapv, it is due to how PROMOTE_MODE is defined in arm back-end. >>> In the test-case,

Re: [PATCH][sched-deps] Generalise usage of macro fusion to work on any two insns

2014-07-11 Thread Kyrill Tkachov
On 10/07/14 22:53, Maxim Kuvyrkov wrote: On Jul 10, 2014, at 8:00 PM, Kyrill Tkachov wrote: On 30/06/14 21:39, Jeff Law wrote: On 06/27/14 02:29, Kyrill Tkachov wrote: Hi all, This patch generalises the TARGET_MACRO_FUSION_PAIR_P hook usage to work on more than just compares and conditiona

Fix PR61772: ifcvt removing asm volatile gotos

2014-07-11 Thread Michael Matz
Hi, our kernel guys saw this problem when they used an asm goto to implement a conditional where the then-block was empty. RTL ifcvt happily goes on and removes the whole block and the jump instruction, even though it has side-effects (as marked with the volatility). Patch below fixes it by

Re: Optimize type streaming

2014-07-11 Thread Jan Hubicka
> > Ah, ok. Well, let's hope walk_tree walks all edges the DFS walk walks ;) > A quick look tells me it doesn't walk DECL_VINDEX or > DECL_FUNCTION_PERSONALITY for example. I guess it should - will try patch adding that :) Both seems like just ommisions - these fileds were added quite recently (

Re: Use separate sections to stream non-trivial constructors

2014-07-11 Thread Jan Hubicka
> > Well, just make them regular (anonymous) VAR_DECLs then ... (the fact > that a CONST_DECL is anonymous is probably the only real difference - > and that they are mergeable by content). Something like that, perhaps. Plan to do that incrementally - having them in symbol tabel first is an impor

Re: Optimize type streaming

2014-07-11 Thread Richard Biener
On Fri, 11 Jul 2014, Jan Hubicka wrote: > > On Fri, 11 Jul 2014, Jan Hubicka wrote: > > > > > > > Hmm, walking everything first and then starting streaming sounds bad > > > > > idea > > > > > for locality. Can't I just re-do the walk since I know what the SCC > > > > > is? > > > > > I will rea

Re: update address taken: don't drop clobbers

2014-07-11 Thread Michael Matz
Hi, On Thu, 10 Jul 2014, Jeff Law wrote: > > The insight to note is, that undefined SSA names should really be > > coalesced with something (otherwise you lost an optimization opportunity), > > but it doesn't matter with _what_ each use of the undefined name is > > coalesced, you can even identif

Re: Optimize type streaming

2014-07-11 Thread Jan Hubicka
> On Fri, 11 Jul 2014, Jan Hubicka wrote: > > > > > Hmm, walking everything first and then starting streaming sounds bad > > > > idea > > > > for locality. Can't I just re-do the walk since I know what the SCC is? > > > > I will read the code more after lunch. > > > > > > Might be possible with

Re: Optimize type streaming

2014-07-11 Thread Richard Biener
On Fri, 11 Jul 2014, Jan Hubicka wrote: > > > Hmm, walking everything first and then starting streaming sounds bad idea > > > for locality. Can't I just re-do the walk since I know what the SCC is? > > > I will read the code more after lunch. > > > > Might be possible with a 2nd SCC stack set up

Re: Use separate sections to stream non-trivial constructors

2014-07-11 Thread Richard Biener
On Fri, 11 Jul 2014, Jan Hubicka wrote: > > On Fri, 11 Jul 2014, Jan Hubicka wrote: > > > > > Hi, > > > since we both agreed offlining constructors from global decl stream is a > > > good > > > idea, I went ahead and implemented it. I would like to followup by an > > > cleanups; for example the

Re: Optimize type streaming

2014-07-11 Thread Jan Hubicka
> > Hmm, walking everything first and then starting streaming sounds bad idea > > for locality. Can't I just re-do the walk since I know what the SCC is? > > I will read the code more after lunch. > > Might be possible with a 2nd SCC stack set up, yes. I set up hash_map to store the hash values

Re: Use separate sections to stream non-trivial constructors

2014-07-11 Thread Jan Hubicka
> On Fri, 11 Jul 2014, Jan Hubicka wrote: > > > Hi, > > since we both agreed offlining constructors from global decl stream is a > > good > > idea, I went ahead and implemented it. I would like to followup by an > > cleanups; for example the sections are still tagged as function sections, > > b

Re: [PATCH 2/2] Enable elimination of zext/sext

2014-07-11 Thread Kugan
Thanks foe the review and suggestions. On 10/07/14 22:15, Richard Biener wrote: > On Mon, Jul 7, 2014 at 8:55 AM, Kugan > wrote: [...] >> >> For -fwrapv, it is due to how PROMOTE_MODE is defined in arm back-end. >> In the test-case, a function (which has signed char return type) returns >> -1

Re: Use separate sections to stream non-trivial constructors

2014-07-11 Thread Richard Biener
On Fri, 11 Jul 2014, Jan Hubicka wrote: > Hi, > since we both agreed offlining constructors from global decl stream is a good > idea, I went ahead and implemented it. I would like to followup by an > cleanups; for example the sections are still tagged as function sections, but > I > would like t

Re: [GSoC] generation of Gimple loops with empty bodies

2014-07-11 Thread Tobias Grosser
On 11/07/2014 13:11, Roman Gareev wrote: The struct now contains only a single element such that there seems to be no need for it anymore. Should we remove it? (We could still use a typedef if you believe the datatype is too long). I don't mind removing it. However I think that we should choose

Re: [GSoC] generation of Gimple loops with empty bodies

2014-07-11 Thread Roman Gareev
> The struct now contains only a single element such that there seems to be no > need for it anymore. Should we remove it? (We could still use a typedef if > you believe the datatype is too long). I don't mind removing it. However I think that we should choose the way of transferring of sese regio

Re: [Patch ARM-AArch64/testsuite v2 01/21] Neon intrinsics execution tests initial framework.

2014-07-11 Thread Richard Earnshaw
On 10/07/14 11:12, Marcus Shawcroft wrote: > On 1 July 2014 11:05, Christophe Lyon wrote: >> * documentation (README) >> * dejanu driver (neon-intrinsics.exp) >> * support macros (arm-neon-ref.h, compute-ref-data.h) >> * Tests for 3 intrinsics: vaba, vld1, vshl > > Hi, The terminology in armv8 is

Re: FWD: Re: OpenACC subarray specifications in the GCC Fortran front end

2014-07-11 Thread Jakub Jelinek
On Fri, Jul 11, 2014 at 12:11:10PM +0200, Thomas Schwinge wrote: > To avoid duplication of work: with Jakub's Fortran OpenMP 4 target > changes recently committed to trunk, and now merged into gomp-4_0-branch, > I have trimmed down Ilmir's patch to just the OpenACC bits, OpenMP 4 > target changes r

Re: [Patch 2/2][AArch64]Split insn type alu_reg into alu_sreg and alu_dsp_reg

2014-07-11 Thread Richard Earnshaw
On 10/07/14 09:06, Terry Guo wrote: > Hi there, > > As the second and final patch in this series, it intends to update alu_reg > and alus_reg types for AArch64 port. With this change, the gcc can be > successfully built for AArch64. Is it OK to trunk? > > BR, > Terry > > 2014-07-10 Terry Guo

Re: [Patch 1/2][ARM]Split insn type alu_reg into alu_sreg and alu_dsp_reg

2014-07-11 Thread Richard Earnshaw
On 10/07/14 08:46, Terry Guo wrote: > Hi there, > > Currently the insn type of DSP-kind instructions like QSUB8 is alu_reg which > is same as other normal instructions like SUB. In order to distinguish those > DSP-kind instructions, this patch intends to replace current alu_reg with > two sub cate

[PATCH-v3] Generate more efficient memory barriers for LEON3

2014-07-11 Thread Daniel Cederman
ChangeLog: 2014-07-11 Daniel Cederman gcc/config/sparc/ * sync.md: Generate more efficient memory barriers for LEON3 --- gcc/config/sparc/sync.md | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gcc/config/sparc/sync.md b/gcc/config/sparc/sync.md index e6e

Re: [PATCH] Generate more efficient memory barriers for LEON3

2014-07-11 Thread Daniel Cederman
That was an error on my side. The wrong memory model had gotten cached in a generated make script. Lets drop membar_leon3 also then :) On 2014-07-11 11:15, Eric Botcazou wrote: The full barrier pattern membar_leon3 also gets generated so I think that one should be kept also. Do you have a tes

[C++ Patch] PR 53159 (Take 2)

2014-07-11 Thread Paolo Carlini
Hi, only today it occurred to me that we can as well delay all the diagnostic at issue to the check_narrowing at the end of convert_like_real and avoid at once possible issues with duplicate warnings. Tested x86_64-linux. Thanks, Paolo. // /cp 2014-07-11 Paolo Carlini

Re: Optimize type streaming

2014-07-11 Thread Richard Biener
On Fri, 11 Jul 2014, Jan Hubicka wrote: > > > > > > We hash only on outgoing SCC edges. You can easily have > > > main variant type T and variants T1,T2 that are same all used by type > > > T again. > > > > Ok, but then the two variants shouldn't be in the same SCC or at > > least not in the sa

Re: FWD: Re: OpenACC subarray specifications in the GCC Fortran front end

2014-07-11 Thread Thomas Schwinge
Hi! On Thu, 22 May 2014 11:31:25 +0400, Ilmir Usmanov wrote: > On 16.05.2014 19:44, Ilmir Usmanov wrote: > > On 16.05.2014 19:12, Thomas Schwinge wrote: > >> You recently indicated that you have already begun implementing OpenACC > >> subarray specifications in the GCC Fortran front end, but have

Re: [PATCH] Fix PR61762, reads from string constants

2014-07-11 Thread Richard Biener
On Fri, 11 Jul 2014, Jakub Jelinek wrote: > On Fri, Jul 11, 2014 at 11:13:12AM +0200, Richard Biener wrote: > > + if (offset >= off) > > + ptr[offset - off] = value; > > For original off != 0, you aren't checking whether offset - off < len > though (various places), you don't want to w

Re: Optimize type streaming

2014-07-11 Thread Jan Hubicka
> > > > We hash only on outgoing SCC edges. You can easily have > > main variant type T and variants T1,T2 that are same all used by type > > T again. > > Ok, but then the two variants shouldn't be in the same SCC or at > least not in the same SCC as the main variant. They will because T refers

Re: [RFC, PATCH 1/n] IPA C++ refactoring

2014-07-11 Thread Jan Hubicka
> Hi, >this first patch continues with rafactoring of IPA infrastructure so that > we will have C++ API. In the patch, I transformed many global functions to > members of symtab_node and cgraph_node. > > Example: > cgraph_remove_node (struct cgraph_node *node) -> cgraph_node::remove (void) >

Re: Optimize type streaming

2014-07-11 Thread Richard Biener
On Fri, 11 Jul 2014, Jan Hubicka wrote: > > > > Well - as we re-use the streamer cache to store the hash value it isn't > > really possible to do better ... (at least I don't have a clever idea) > > OK, no cleverness on my side either. > > > > Yeah (though you wouldn't need the extra hashing -

Re: [PATCH] Fix PR61762, reads from string constants

2014-07-11 Thread Jakub Jelinek
On Fri, Jul 11, 2014 at 11:13:12AM +0200, Richard Biener wrote: > + if (offset >= off) > + ptr[offset - off] = value; For original off != 0, you aren't checking whether offset - off < len though (various places), you don't want to write beyond end of buffer. > - return total_bytes; >

Re: Optimize type streaming

2014-07-11 Thread Jan Hubicka
> > Well - as we re-use the streamer cache to store the hash value it isn't > really possible to do better ... (at least I don't have a clever idea) OK, no cleverness on my side either. > > Yeah (though you wouldn't need the extra hashing - we only need to know > the hash of the SCC). The curre

Re: [patch,gomp-4_0-branch] openacc collapse clause

2014-07-11 Thread Thomas Schwinge
Hi Cesar! On Thu, 10 Jul 2014 11:47:42 -0700, Cesar Philippidis wrote: > These patch enables the collapse clause with a value greater than one. Thanks! > Is this patch OK for gomp-4_0-branch? OK with the following addressed: > --- a/gcc/c/c-parser.c > +++ b/gcc/c/c-parser.c > @@ -11260,6 +11

Re: [GSoC] generation of Gimple loops with empty bodies

2014-07-11 Thread Tobias Grosser
I tried to incorporate all your comments in the attached patch. Nice. It looks now very good to me. One final and last detail: +/* TREE_FROM_ISL_ID maps ISL's scattering and parameter identifiers + to corresponding trees. */ + +typedef struct ivs_params { + std::map tree_from_isl_id; +} *i

Use separate sections to stream non-trivial constructors

2014-07-11 Thread Jan Hubicka
Hi, since we both agreed offlining constructors from global decl stream is a good idea, I went ahead and implemented it. I would like to followup by an cleanups; for example the sections are still tagged as function sections, but I would like to do it incrementally. There is quite some uglyness in

Re: [PATCH] Generate more efficient memory barriers for LEON3

2014-07-11 Thread Eric Botcazou
> The full barrier pattern membar_leon3 also gets generated so I think > that one should be kept also. Do you have a testcase? membar is generated by sparc_emit_membar_for_model and, for the TSO model of LEON3, implied = StoreStore | LoadLoad | LoadStore so mm can only be StoreLoad, which means

Re: [patch,gomp-4_0-branch] misc reduction clause bug fixes

2014-07-11 Thread Thomas Schwinge
Hi Cesar! On Thu, 10 Jul 2014 11:43:11 -0700, Cesar Philippidis wrote: > This patch addresses two bugs openacc reduction clause bugs. Thanks! OK; one question/suggestion, though: > --- a/gcc/omp-low.c > +++ b/gcc/omp-low.c > @@ -9679,11 +9679,23 @@ process_reduction_data (gimple_seq *body, gi

Re: [PATCH] Fix PR61762, reads from string constants

2014-07-11 Thread Richard Biener
On Fri, 11 Jul 2014, Richard Biener wrote: > On Fri, 11 Jul 2014, Jakub Jelinek wrote: > > > On Fri, Jul 11, 2014 at 10:00:01AM +0200, Richard Biener wrote: > > > I started with adding an optional arg to native_encode_expr but then > > > figured that all the current workers return failure if the

Re: Optimize type streaming

2014-07-11 Thread Richard Biener
On Fri, 11 Jul 2014, Jan Hubicka wrote: > > Are we sure it ever stabilizes? But yes, I had something like this in mind > > (just do one iteration always) in case we need to improve hashing. > > Hi, > this is bit quick experiment with strengthening the hash by iteration. I don't > seem to be able

Fwd: Re: [PING][PATCH] Fix for PR 61561

2014-07-11 Thread Marat Zakirov
Thank to you all. Committed revision 212450. --Marat Original Message Subject:Re: [PING][PATCH] Fix for PR 61561 Date: Thu, 10 Jul 2014 14:01:24 +0100 From: Ramana Radhakrishnan To: Marat Zakirov , "gcc-patches@gcc.gnu.org" CC: Richard Earnshaw , Kyrylo Tkacho

Re: [patch 1/4] change specific int128 -> generic intN

2014-07-11 Thread Eric Botcazou
> PSImode is 20 bits, fits in a 20 bit register, and uses 20 bit operations. Then why do you need this change? > - TYPE_SIZE (type) = bitsize_int (GET_MODE_BITSIZE (TYPE_MODE (type))); > + TYPE_SIZE (type) = bitsize_int (GET_MODE_PRECISION (TYPE_MODE > (type))); TYPE_SIZE_UNIT (type) =

  1   2   >