Re: PR59723: fix LTO + fortran namelist ICEs

2014-01-21 Thread Richard Biener
Aldy Hernandez wrote: >Hi folks. > >The problem here is that while streaming the DECL_NAME with >stream_read_tree() and consequently lto_output_tree(), we trigger an >ICE >because we are recursing on the DFS walk: > > else > { > /* This is the first time we see EXPR, write all reacha

RE: [Patch, microblaze]: Remove SECONDARY_MEMORY_NEEDED

2014-01-21 Thread David Holsgrove
Hi Michael, > -Original Message- > From: Michael Eager [mailto:ea...@eagerm.com] > Sent: Friday, 17 January 2014 4:44 am > To: David Holsgrove; gcc-patches@gcc.gnu.org > Cc: Edgar Iglesias; John Williams; Vidhumouli Hunsigida; Nagaraju Mekala > Subject: Re: [Patch, microblaze]: Remove SECO

RE: [Patch, microblaze]: Fix ICE with mhard-float

2014-01-21 Thread David Holsgrove
> -Original Message- > From: Michael Eager [mailto:ea...@eagerm.com] > Sent: Friday, 17 January 2014 4:36 am > To: David Holsgrove; gcc-patches@gcc.gnu.org > Cc: Edgar Iglesias; John Williams; Vidhumouli Hunsigida; Nagaraju Mekala > Subject: Re: [Patch, microblaze]: Fix ICE with mhard-float

Re: Patch committed: Fix ChangeLog entry

2014-01-21 Thread Kito Cheng
Thanks :) On Wed, Jan 22, 2014 at 1:15 AM, Richard Sandiford wrote: > Ian Lance Taylor writes: >> This patch moves to the gcc/ChangeLog file a gcc ChangeLog entry that >> was incorrectly added to the top-level ChangeLog file. Changes to >> ChangeLog files do not themselves get ChangeLog entries

RE: [PATCH RFC] MIPS add support for MIPS SIMD ARCHITECTURE V1.07

2014-01-21 Thread Matthew Fortune
> > And as you imply, o32+fp64 is already an established ABI so I think we > > have to support the current form alongside any new one. I agree with > > Joseph that it'd be better to realign the stack dynamically instead. > > This is what x86 does, so it's well tested within gcc. > > With glibc, o

RE: [PATCH RFC] MIPS add support for MIPS SIMD ARCHITECTURE V1.07

2014-01-21 Thread Matthew Fortune
> Just wanted to add a couple of MIPS-specific things on top of what Joseph > said: > > Matthew Fortune writes: > > The MSA patch as submitted is another variation of O32 ABI which could > > be described as O32+FP64+MSA(+nan2008) and would be link incompatible > > with both O32 and O32+FP64(+/-na

Re: [google gcc-4_8] Tree Loop Unrolling - Relax code size increase with -O2

2014-01-21 Thread Xinliang David Li
ok. David On Tue, Jan 21, 2014 at 4:46 PM, Sriraman Tallam wrote: > On Tue, Jan 21, 2014 at 2:49 PM, Xinliang David Li wrote: >> I think it might be better to introduce a new parameter for max peel >> insn at O2 (e.g, call it MAX_O2_COMPLETELY_PEEL_INSN or >> MAX_DEFAULT_...), and use the same

Re: [google gcc-4_8] Tree Loop Unrolling - Relax code size increase with -O2

2014-01-21 Thread Sriraman Tallam
On Tue, Jan 21, 2014 at 2:49 PM, Xinliang David Li wrote: > I think it might be better to introduce a new parameter for max peel > insn at O2 (e.g, call it MAX_O2_COMPLETELY_PEEL_INSN or > MAX_DEFAULT_...), and use the same logic in your patch to override the > MAX_COMPLETELY_PEELED_INSN paramete

Re: fix inconsistent install paths between gccgo and go tool

2014-01-21 Thread Ian Lance Taylor
On Tue, Jan 21, 2014 at 3:29 PM, Michael Hudson-Doyle wrote: > > This patch for the 4.8 branch fixes an inconsistency between gccgo's > libgo and the go tool over where libraries installed with "go install > -compiler gccgo" end up. Even if it's not strictly required, it makes > sense to me that

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-01-21 Thread Jan Hubicka
> On 01/17/14 14:32, Jan Hubicka wrote: > >>* combine-stack-adj.c (combine_stack_adjustments_for_block): Remove > >>ARG_SIZE note when adjustment was eliminated. > > > >Ping... This patch prevents me from switching the accumulate-args default > >for generic and I am waiting for that witht

Re: Resolve pr44194-1.c failure by refining scan-rtl-dump-not pattern

2014-01-21 Thread Eric Botcazou
> It looks like the committed version removed the space after "insn". > Was that intentional? It now triggers on MIPS because of the frame-related > (insn/f) prologue instruction that stores the link register. The posted > version works for me FWIW. I found out that it didn't fail with the space

fix inconsistent install paths between gccgo and go tool

2014-01-21 Thread Michael Hudson-Doyle
Hi, This patch for the 4.8 branch fixes an inconsistency between gccgo's libgo and the go tool over where libraries installed with "go install -compiler gccgo" end up. Even if it's not strictly required, it makes sense to me that as gccgo implements go 1.1 it should match the go tool from that pa

Re: [C PATCH] Warn about unused RHS of COMPOUND_EXPR (PR c/59871)

2014-01-21 Thread Jakub Jelinek
On Tue, Jan 21, 2014 at 11:54:03PM +0100, Marek Polacek wrote: > On Tue, Jan 21, 2014 at 11:34:42PM +0100, Jakub Jelinek wrote: > > On Tue, Jan 21, 2014 at 11:30:58PM +0100, Marek Polacek wrote: > > > I made another small change: in the second hunk, in > > > emit_side_effect_warnings, I got rid of

Re: [C PATCH] Warn about unused RHS of COMPOUND_EXPR (PR c/59871)

2014-01-21 Thread Marek Polacek
On Tue, Jan 21, 2014 at 11:34:42PM +0100, Jakub Jelinek wrote: > On Tue, Jan 21, 2014 at 11:30:58PM +0100, Marek Polacek wrote: > > I made another small change: in the second hunk, in > > emit_side_effect_warnings, I got rid of the while, since it seems to > > me we never get COMPOUND_EXPR in TREE_

Re: [google gcc-4_8] Tree Loop Unrolling - Relax code size increase with -O2

2014-01-21 Thread Xinliang David Li
I think it might be better to introduce a new parameter for max peel insn at O2 (e.g, call it MAX_O2_COMPLETELY_PEEL_INSN or MAX_DEFAULT_...), and use the same logic in your patch to override the MAX_COMPLETELY_PEELED_INSN parameter at O2). By so doing, we don't need to have a hard coded factor o

PR59723: fix LTO + fortran namelist ICEs

2014-01-21 Thread Aldy Hernandez
Hi folks. The problem here is that while streaming the DECL_NAME with stream_read_tree() and consequently lto_output_tree(), we trigger an ICE because we are recursing on the DFS walk: else { /* This is the first time we see EXPR, write all reachable trees to OB. */

Re: [C PATCH] Warn about unused RHS of COMPOUND_EXPR (PR c/59871)

2014-01-21 Thread Jakub Jelinek
On Tue, Jan 21, 2014 at 11:30:58PM +0100, Marek Polacek wrote: > I made another small change: in the second hunk, in > emit_side_effect_warnings, I got rid of the while, since it seems to > me we never get COMPOUND_EXPR in TREE_OPERAND (r, 1). For bar (), 1, 2, 3, 4, 5, 6, 7, 8; sure, but what abo

Re: [C PATCH] Warn about unused RHS of COMPOUND_EXPR (PR c/59871)

2014-01-21 Thread Marek Polacek
On Tue, Jan 21, 2014 at 07:50:13PM +0100, Jakub Jelinek wrote: > On Tue, Jan 21, 2014 at 07:38:10PM +0100, Marek Polacek wrote: > > --- gcc/gcc/c/c-typeck.c.mp 2014-01-21 11:59:33.221215248 +0100 > > +++ gcc/gcc/c/c-typeck.c2014-01-21 18:10:53.900279750 +0100 > > @@ -4757,6 +4757,18 @@ build_co

Merge from trunk to gccgo branch

2014-01-21 Thread Ian Lance Taylor
I merged revision 206906 from trunk to the gccgo branch. Ian

Re: Fix bootstrap with -mno-accumulate-outgoing-args

2014-01-21 Thread Jeff Law
On 01/17/14 14:32, Jan Hubicka wrote: * combine-stack-adj.c (combine_stack_adjustments_for_block): Remove ARG_SIZE note when adjustment was eliminated. Ping... This patch prevents me from switching the accumulate-args default for generic and I am waiting for that witht he inlin

Re: [C PATCH] Warn about unused RHS of COMPOUND_EXPR (PR c/59871)

2014-01-21 Thread Marek Polacek
On Tue, Jan 21, 2014 at 09:18:17PM +0100, Marc Glisse wrote: > On Tue, 21 Jan 2014, Marek Polacek wrote: > > >--- gcc/libdecnumber/decNumberLocal.h.mp 2014-01-21 18:34:32.235540589 > >+0100 > >+++ gcc/libdecnumber/decNumberLocal.h2014-01-21 19:04:12.173243034 > >+0100 > >@@ -155,8 +1

[google gcc-4_8] Tree Loop Unrolling - Relax code size increase with -O2

2014-01-21 Thread Sriraman Tallam
Hi, Currently, tree unrolling pass(cunroll) does not allow any code size growth in O2 mode. Code size growth is permitted only if O3 or funroll-loops/fpeel-loops is used. I have created a patch to allow partial code size increase in O2 mode. With funroll-loops the maximum allowed code growt

patch to fix PR59896

2014-01-21 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59896 The patch was successfully bootstrapped and tested on x86/x86-64. Committed as rev 206908. 2014-01-21 Vladimir Makarov PR rtl-optimization/59896 * lra-constraints.c (process_alt_operands): Check

Re: [PATCH] Fix use-after-return-1.c

2014-01-21 Thread Mike Stump
On Jan 21, 2014, at 5:51 AM, Maxim Ostapenko wrote: > This patch fixes c-c++-common/asan/use-after-return-1.c not to fail on darwin > target (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59897). > > Ok to commit? Ok.

Re: [PATCH RFC] MIPS add support for MIPS SIMD ARCHITECTURE V1.07

2014-01-21 Thread Joseph S. Myers
On Tue, 21 Jan 2014, Richard Sandiford wrote: > And as you imply, o32+fp64 is already an established ABI so I think we > have to support the current form alongside any new one. I agree with > Joseph that it'd be better to realign the stack dynamically instead. > This is what x86 does, so it's wel

[MIPS, committed] Adding missing register move costs for M16_REGS

2014-01-21 Thread Richard Sandiford
This patch fixes a stupid oversight in: 2008-10-24 Richard Sandiford * config/mips/mips.c (mips_canonicalize_move_class): New function. (mips_move_to_gpr_cost): Likewise. (mips_move_from_gpr_cost): Likewise. (mips_register_move_cost): Make more fine-grained. Th

Re: Resolve pr44194-1.c failure by refining scan-rtl-dump-not pattern

2014-01-21 Thread Richard Sandiford
Eric Botcazou writes: >> I have made the adjustment and test it. Please check the new attachment. > > Thanks, applied on the mainline as obvious. It looks like the committed version removed the space after "insn". Was that intentional? It now triggers on MIPS because of the frame-related (insn/f

[jit] Add gcc_jit_function_add_comment

2014-01-21 Thread David Malcolm
Committed to dmalcolm/jit branch: Add gcc_jit_function_add_comment, a way to add a no-op textual comment to the internal representation of the code. It will be optimized away, but will be visible in some dumps and thus may be of use when debugging how client code's internal representation gets co

Re: [PATCH RFC] MIPS add support for MIPS SIMD ARCHITECTURE V1.07

2014-01-21 Thread Richard Sandiford
Hi Matthew, Just wanted to add a couple of MIPS-specific things on top of what Joseph said: Matthew Fortune writes: > The MSA patch as submitted is another variation of O32 ABI which could > be described as O32+FP64+MSA(+nan2008) and would be link incompatible > with both O32 and O32+FP64(+/-nan

Re: [C PATCH] Warn about unused RHS of COMPOUND_EXPR (PR c/59871)

2014-01-21 Thread Marc Glisse
On Tue, 21 Jan 2014, Marek Polacek wrote: --- gcc/libdecnumber/decNumberLocal.h.mp2014-01-21 18:34:32.235540589 +0100 +++ gcc/libdecnumber/decNumberLocal.h 2014-01-21 19:04:12.173243034 +0100 @@ -155,8 +155,10 @@ see the files COPYING3 and COPYING.RUNTI /* Store a uInt, etc., into b

Re: [Patch] Fix regex `nosubs` correctly

2014-01-21 Thread Tim Shen
On Tue, Jan 21, 2014 at 2:39 PM, Jonathan Wakely wrote: > OK, thanks for confirming that. In that case your patch is OK to > commit. Committed. > I'll raise a defect report against the standard as I don't think the > specification of nosubs is clear. If that's what it means then it > should be

Re: [PATCH] libgcc: use linker script for libgcc_s.so on xtensa

2014-01-21 Thread Sterling Augustine
On Mon, Jan 20, 2014 at 9:46 PM, Baruch Siach wrote: > Hi Sterling, > > On Mon, Jan 20, 2014 at 12:06:59PM -0800, Sterling Augustine wrote: >> On Sun, Jan 19, 2014 at 1:21 AM, Baruch Siach wrote: >> > The xtensa port uses __xtensa_libgcc_window_spill in libgcc to implement >> > __builtin_frame_ad

Re: [Patch] Fix regex `nosubs` correctly

2014-01-21 Thread Jonathan Wakely
On 21/01/14 14:14 -0500, Tim Shen wrote: My conclusion is actually based on Boost.Regex's behavior. boost::basic_regex::mark_count() returns 1 with nosubs flag. Note that boost::basic_regex::mark_count() == std::basic_regex::mark_count() + 1, because std does not count the 0th capture (the whole

Re: [patch] fix libstdc++/56267 - local iterator requirements

2014-01-21 Thread Jonathan Wakely
On 21 January 2014 10:00, Jonathan Wakely wrote: > On 20 January 2014 21:11, François Dumont wrote: >> On 01/20/2014 04:53 PM, Jonathan Wakely wrote: >> >> With this new design couldn't we change the conditions that are used to >> decide when to cache the hash code. I haven't study it in detail bu

Re: [PATCH] Fix up expand_small_movmem_or_setmem (PR target/59003)

2014-01-21 Thread Jan Hubicka
> On Tue, Jan 21, 2014 at 08:08:19PM +0100, Jan Hubicka wrote: > > Yes, this is OK. > > Thanks. BTW, I wonder if we got small expected_size_exp like in this > case (6), if it is desirable to emit the large >= 32 size handling > inline, if (say unless -minline-all-stringops) we couldn't just emit

Re: patch to fix PR59858

2014-01-21 Thread Vladimir Makarov
On 01/21/2014 02:17 PM, Vladimir Makarov wrote: > The following patch fixes > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59858 > > The patch was successfully bootstrapped and tested on x86/x86-64. > > Committed as rev. 206897. > > 2014-01-21 Vladimir Makarov > > PR rtl-optimiz

patch to fix PR59858

2014-01-21 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59858 The patch was successfully bootstrapped and tested on x86/x86-64. Committed as rev. 206897. 2014-01-21 Vladimir Makarov PR rtl-optimization/59858 * gcc.target/arm/pr59858.c: New. 2014-01-21

Re: [PATCH] Fix up expand_small_movmem_or_setmem (PR target/59003)

2014-01-21 Thread Jakub Jelinek
On Tue, Jan 21, 2014 at 08:08:19PM +0100, Jan Hubicka wrote: > Yes, this is OK. Thanks. BTW, I wonder if we got small expected_size_exp like in this case (6), if it is desirable to emit the large >= 32 size handling inline, if (say unless -minline-all-stringops) we couldn't just emit for that a l

Re: [Patch] Fix regex `nosubs` correctly

2014-01-21 Thread Tim Shen
On Tue, Jan 21, 2014 at 5:08 AM, Jonathan Wakely wrote: > What does Boost.Regex do? My conclusion is actually based on Boost.Regex's behavior. boost::basic_regex::mark_count() returns 1 with nosubs flag. Note that boost::basic_regex::mark_count() == std::basic_regex::mark_count() + 1, because std

Re: [PATCH] Fix up expand_small_movmem_or_setmem (PR target/59003)

2014-01-21 Thread Jan Hubicka
> Hi! > > As the testcase shows, for the memset (x, 0, y); snippet which handles > y from 16 to 31 inclusive for some tunings, we generate: > .L36: > movq$0, (%rdi) > movq$0, 8(%rdi) > movq$0, -8(%rsi,%rdi) Oops... > which is correct only for y from 16 to 24 inclus

[PATCH] Fix up expand_small_movmem_or_setmem (PR target/59003)

2014-01-21 Thread Jakub Jelinek
Hi! As the testcase shows, for the memset (x, 0, y); snippet which handles y from 16 to 31 inclusive for some tunings, we generate: .L36: movq$0, (%rdi) movq$0, 8(%rdi) movq$0, -8(%rsi,%rdi) which is correct only for y from 16 to 24 inclusive, if y is 25 to 31,

Re: [PATCH AArch64_BE 4/4] Big-Endian lane numbering fix

2014-01-21 Thread Alex Velenko
Hi, Can someone, please, commit this patch as I do not have privileges to do so. Kind regards, Alex Velenko On 21/01/14 13:34, Marcus Shawcroft wrote: 2014/1/16 Alex Velenko : Hi, In previous BE patches the way lane indexing in lanes is calculated has been changed. To accommodate the change, ar

Re: [PATCH AArch64_BE 3/4] Big-Endian lane numbering fix

2014-01-21 Thread Alex Velenko
Hi, Can someone, please, commit this patch as I do not have privileges to do so. Kind regards, Alex Velenko On 21/01/14 13:32, Marcus Shawcroft wrote: On 16 January 2014 11:50, Alex Velenko wrote: Hi, This patch by James Greenhalgh fixes "by-lane" patterns broken by previous patches. Regres

Re: [PATCH AArch64_BE 2/4] Big-Endian lane numbering fix

2014-01-21 Thread Alex Velenko
Hi, Can someone, please, commit this patch as I do not have privileges to do so. Kind regards, Alex Velenko On 21/01/14 13:31, Marcus Shawcroft wrote: On 16 January 2014 11:49, Alex Velenko wrote: Hi, This patch changes get_lane intrinsics to provide a correct big-endian indexing. This fixes n

Re: [PATCH AArch64_BE 1/4] Big-Endian lane numbering fix

2014-01-21 Thread Alex Velenko
Hi, Can someone, please, commit this patch as I do not have privileges to do so. Kind regards, Alex Velenko On 21/01/14 13:27, Marcus Shawcroft wrote: On 16 January 2014 11:49, Alex Velenko wrote: Hi, This patch is the first patch in a series of patches fixing Big-Endian lane numbering. The go

Re: [PATCH i386 11/8] [AVX512] [2/2] Add missing packed PF gathers/scatters.

2014-01-21 Thread Kirill Yukhin
Hello, This is non-trivial part of the patch. > On 15 Jan 20:53, Uros Bizjak wrote: > On Tue, Jan 14, 2014 at 7:13 AM, Kirill Yukhin > wrote: > Did you try to add DF/SF mode to the unspec? I am not familiar with > this insn, but shouldn't the mode of mem access be somehow similar to > the avx512

Re: [C PATCH] Warn about unused RHS of COMPOUND_EXPR (PR c/59871)

2014-01-21 Thread Jakub Jelinek
On Tue, Jan 21, 2014 at 07:38:10PM +0100, Marek Polacek wrote: > --- gcc/gcc/c/c-typeck.c.mp 2014-01-21 11:59:33.221215248 +0100 > +++ gcc/gcc/c/c-typeck.c 2014-01-21 18:10:53.900279750 +0100 > @@ -4757,6 +4757,18 @@ build_compound_expr (location_t loc, tre >expr2 = TREE_OPERAND (exp

Re: [PATCH,rs6000] Add tests for vec_insert and vec_extract implemented with VSX instructions

2014-01-21 Thread David Edelsohn
> A previous patch of mine implemented support for -maltivec=be for little > endian targets when expanding the vec_insert and vec_extract builtins. > However, I neglected to include test cases for V2DI and V2DF, which are > implemented using VSX instructions and therefore need different compile > o

RE: [PATCH RFC] MIPS add support for MIPS SIMD ARCHITECTURE V1.07

2014-01-21 Thread Joseph S. Myers
On Tue, 21 Jan 2014, Matthew Fortune wrote: > The MSA patch as submitted is another variation of O32 ABI which could > be described as O32+FP64+MSA(+nan2008) and would be link incompatible > with both O32 and O32+FP64(+/-nan2008). The same of course applies to > N32/N64 being link incompatible

[C PATCH] Warn about unused RHS of COMPOUND_EXPR (PR c/59871)

2014-01-21 Thread Marek Polacek
In this PR the problem was that the C FE, unlike the C++ FE, didn't warn on e.g. bar (), 1;, that the RHS has no effect. This patch tries to tweak the C FE so that it follows what the C++ FE does. Note that the C++ FE uses quite imprecise locus info; the C FE's info is better. I had to slightly a

Re: Patch committed: Fix ChangeLog entry

2014-01-21 Thread Richard Sandiford
Ian Lance Taylor writes: > This patch moves to the gcc/ChangeLog file a gcc ChangeLog entry that > was incorrectly added to the top-level ChangeLog file. Changes to > ChangeLog files do not themselves get ChangeLog entries. Committed as > obvious. Sorry, this was my bad, not Kito's fault at all

[PATCH,rs6000] Add tests for vec_insert and vec_extract implemented with VSX instructions

2014-01-21 Thread Bill Schmidt
Hi, A previous patch of mine implemented support for -maltivec=be for little endian targets when expanding the vec_insert and vec_extract builtins. However, I neglected to include test cases for V2DI and V2DF, which are implemented using VSX instructions and therefore need different compile option

Patch committed: Fix ChangeLog entry

2014-01-21 Thread Ian Lance Taylor
This patch moves to the gcc/ChangeLog file a gcc ChangeLog entry that was incorrectly added to the top-level ChangeLog file. Changes to ChangeLog files do not themselves get ChangeLog entries. Committed as obvious. Ian Index: ChangeLog ===

Re: Fix a dbr_schedule vs. delete_related_insns liveness bug

2014-01-21 Thread Jeff Law
On 01/18/14 03:12, Richard Sandiford wrote: Jeff Law writes: gcc/ * jump.c (delete_related_insns): Keep (use (insn))s. * reorg.c (redundant_insn): Check for barriers too. OK. Any chance you've got a testcase you can add to the suite? ISTM it's potentially valuable given the p

[C++ patch] PR 59482

2014-01-21 Thread Ville Voutilainen
As analysed in the bug report, the scope for the accessibility check was incorrect, and hence the friend was not allowed access. Fixed by pushing into the class scope before parsing the base-clause, and popping afterwards to let the surrounding nested-name-specifier popping work correctly. Tested

Re: [C++ patch] PR 59482

2014-01-21 Thread Jason Merrill
OK, thanks. Jason

Re: [C++ Patch] PR 58980

2014-01-21 Thread Paolo Carlini
Hi, On 01/21/2014 03:55 PM, Jason Merrill wrote: I think I would prefer to change the "child" assert to be MAYBE_CLASS_TYPE_P rather than CLASS_TYPE_P. .. Ok, but then it seems to me that we have to explicitly handle the TYPENAME_TYPE case, otherwise we end up simply accepting the testcase (ev

Re: [C++ PATCH] Emit array initialization from ctor as loop if possible (PR c++/59659)

2014-01-21 Thread Jakub Jelinek
On Tue, Jan 21, 2014 at 10:11:45AM -0500, Jason Merrill wrote: > I'm inclined to handle this situation by using a RANGE_EXPR in > process_init_constructor_array, and then handling that appropriately > in build_vec_init, so that we don't have to build up the huge > CONSTRUCTOR. Would you like to do

Re: [PATCH i386 11/8] [AVX512] [1/2] Rename vmov* intrinsics according to EAS.

2014-01-21 Thread Uros Bizjak
On Tue, Jan 21, 2014 at 4:07 PM, Kirill Yukhin wrote: >> > I have a doubts about changes to sse.md. >> > I've splitted existing (SF-only) patterns into 2: DF and SF. >> > As far as insn operands and final instruction have no such data >> > type discrimination I set this data type to (mem:..) part

Re: [C++ PATCH] Emit array initialization from ctor as loop if possible (PR c++/59659)

2014-01-21 Thread Jason Merrill
I'm inclined to handle this situation by using a RANGE_EXPR in process_init_constructor_array, and then handling that appropriately in build_vec_init, so that we don't have to build up the huge CONSTRUCTOR. Would you like to do that, or shall I take it over? Jason

Re: [PATCH i386 11/8] [AVX512] [1/2] Rename vmov* intrinsics according to EAS.

2014-01-21 Thread Kirill Yukhin
Hello, On 15 Jan 20:53, Uros Bizjak wrote: > On Tue, Jan 14, 2014 at 7:13 AM, Kirill Yukhin > wrote: > > I have a doubts about changes to sse.md. > > I've splitted existing (SF-only) patterns into 2: DF and SF. > > As far as insn operands and final instruction have no such data > > type discrimin

Re: [C++ Patch] PR 58980

2014-01-21 Thread Jason Merrill
I think I would prefer to change the "child" assert to be MAYBE_CLASS_TYPE_P rather than CLASS_TYPE_P. Jason

RE: [PATCH RFC] MIPS add support for MIPS SIMD ARCHITECTURE V1.07

2014-01-21 Thread Matthew Fortune
Hi Richard, I'd like to get some more of your thoughts on the ABI implications of MSA. Generally, any thoughts you have (or anyone else) on the current state of MIPS ABIs would be welcome. As an example I'm curious whether you see variations of O32 as being new ABIs or extensions of O32, it can

Re: [RFC][gomp4] Offloading patches (1/3): Add '-fopenmp_target' option

2014-01-21 Thread Bernd Schmidt
On 12/17/2013 12:35 PM, Michael V. Zolotukhin wrote: Here is a set of patches implementing one more piece of offloading support in GCC. These three patches allow to build a host binary with target image and all tables embedded. Along with patches for libgomp and libgomp plugin, which hopefully

Re: [PATCH][AVX512] Add forgotten intrinsics.

2014-01-21 Thread Uros Bizjak
On Tue, Jan 21, 2014 at 2:42 PM, Ilya Tocar wrote: > I found out that we forgot to implement some of AVX512 intrinsics. > Here is a patch that adds them. Sorry for huge patch, but changes are > mostly trivial. > Ok for trunk? > +(define_insn "avx512f_2_mask_store" > + [(set (match_operand:PMOV_

[PATCH] Fix use-after-return-1.c

2014-01-21 Thread Maxim Ostapenko
Hi, This patch fixes c-c++-common/asan/use-after-return-1.c not to fail on darwin target (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59897). Ok to commit? -Maxim. 2014-01-21 Dominique Dhumieres * c-c++-common/asan/use-after-return-1.c: Fixed to pass on darwin. diff --git a/gcc/testsui

Re: [Patch,AArch64] Support SISD variants of SCVTF,UCVTF

2014-01-21 Thread Marcus Shawcroft
On 13 January 2014 19:27, Vidya Praveen wrote: > Hello, > > This patch adds support to the SISD variants of SCVTF/UCVTF instructions. > This also refactors the existing support for floating point instruction > variants of SCVTF/UCVTF in order to direct the instruction selection based > on the cons

Re: [PATCH AArch64_BE 4/4] Big-Endian lane numbering fix

2014-01-21 Thread Marcus Shawcroft
2014/1/16 Alex Velenko : > Hi, > In previous BE patches the way lane indexing in lanes is calculated has > been changed. To accommodate the change, arm neon intrinsics had to be > updated. > > Is it okay? OK /Marcus

Re: [PATCH AArch64_BE 3/4] Big-Endian lane numbering fix

2014-01-21 Thread Marcus Shawcroft
On 16 January 2014 11:50, Alex Velenko wrote: > Hi, > > This patch by James Greenhalgh fixes "by-lane" patterns broken by > previous patches. > > > Regression tested on aarch64-none-elf and aarch64_be-none-elf > with no unexpected issues. > > OK? > OK /Marcus

Re: [PATCH AArch64_BE 2/4] Big-Endian lane numbering fix

2014-01-21 Thread Marcus Shawcroft
On 16 January 2014 11:49, Alex Velenko wrote: > Hi, > This patch changes get_lane intrinsics to provide a correct big-endian > indexing. This fixes numerous BE load and store issues based on getting > correct lane. > > Is this good for trunk? OK /Marcus

Re: [PATCH AArch64_BE 1/4] Big-Endian lane numbering fix

2014-01-21 Thread Marcus Shawcroft
On 16 January 2014 11:49, Alex Velenko wrote: > Hi, > This patch is the first patch in a series of patches fixing Big-Endian > lane numbering. The goal of this series of patches is to make proper > bridge between pure GCC big-endian view on lane numbering and internal > architected view. OK /Marc

Re: RFC Asan instrumentation control

2014-01-21 Thread Dominique Dhumieres
> Patches should be posted to gcc-patches. >From pr59897 --- ../_clean/gcc/testsuite/c-c++-common/asan/use-after-return-1.c 2014-01-09 10:14:04.0 +0100 +++ gcc/testsuite/c-c++-common/asan/use-after-return-1.c2014-01-09 15:51:04.0 +0100 @@ -48,6 +48,6 @@ int main(int

Re: [PATCH] Fix PR59890, improve var-tracking compile-time

2014-01-21 Thread Alexandre Oliva
On Jan 20, 2014, Jakub Jelinek wrote: > On Mon, Jan 20, 2014 at 06:24:36PM -0200, Alexandre Oliva wrote: >> But I think this one is wrong. >> if (var->onepart == ONEPART_VALUE) >> { >> if (local_get_addr_cache == NULL) >> return; > But when local_get_addr_cache is non-NULL, no matter if we fin

[C++ Patch] PR 58980

2014-01-21 Thread Paolo Carlini
Hi, in this relatively serious ICE on invalid regression (we don't emit any sensible diagnostic before ICE-ing) the problem is that is_ancestor simply asserts that the second argument can be only a NAMESPACE_DECL or a CLASS_TYPE_P, whereas in the erroneous input at issue it's a TYPENAME_TYPE.

Re: [PATCH, committed] Fix PR 57422

2014-01-21 Thread Andrey Belevantsev
On 23.12.2013 10:52, Andrey Belevantsev wrote: Hello, As described in the PR, the ICE reason was the typo made when introducing calls to add_hard_reg_set. Fixed by the first attached patch, bootstrapped and tested on both ia64 and x86_64, committed as obvious. The test case is very sensitive t

Re: RFC Asan instrumentation control

2014-01-21 Thread Jakub Jelinek
On Tue, Jan 21, 2014 at 04:14:23PM +0400, Maxim Ostapenko wrote: > > On x86_64-apple-darwin1* the test > c-c++-common/asan/use-after-return-1.c (new at r206458) fails. > > Yes, unfortunately I forgot about this. The patch makes sense. > > Should I commit it to fix this bug? Patches should be pos

RE: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2014-01-21 Thread Bernd Edlinger
Hi, since there was no progress in the last 2 months on that matter, and we are quite late in Phase 3 now, I dare to propose an alternative, very simple solution for this bug now. It does not try to improve or degade the perfomance at all, instead it simply detects binary files with embedded NULs

Re: RFC Asan instrumentation control

2014-01-21 Thread Maxim Ostapenko
> On x86_64-apple-darwin1* the test c-c++-common/asan/use-after-return-1.c (new at r206458) fails. Yes, unfortunately I forgot about this. The patch makes sense. Should I commit it to fix this bug? -Maxim

[Ada] Work on pragma SPARK_Mode

2014-01-21 Thread Arnaud Charlet
This patch redoes the data structures for pragma SPARK_Mode so that the tree captures full information on the SPARK_Mode setting in all cases, so that it can easily be accessed by gnat2why. It also fully implements the error checking on "monotonicity" of SPARK_Mode settings, and also properly chec

[Ada] Allow to extend a project imported only by extended projects

2014-01-21 Thread Arnaud Charlet
A project that is imported by an extended project was not allowed to be extended. This patch fixes this. Invoking gnatmake -P test_util.gpr should not result in an error such as cannot extend an already imported project file or cannot import an already extended project file with "test_b.gpr

[ARM] fix big.LITTLE spec rewriting

2014-01-21 Thread James Greenhalgh
Hi, As with the AArch64 case, ( http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01317.html ) the way that we rewrite command lines for big.LITTLE systems causes bugs where more than one source file is to be used. The solution here is identical to that proposed for AArch64, we update the spec comman

[AArch64] fix big.LITTLE spec rewriting

2014-01-21 Thread James Greenhalgh
Hi, As Charles Baylis pointed out here: http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00921.html The way that we rewrite command lines for big.LITTLE systems causes bugs where more than one source file is to be used. The problem fundamentally is that -mcpu never makes it to the second cc1 invoca

[PATCH] Fix for PR59600

2014-01-21 Thread Yury Gribov
Hi, This patch fixes the problem reported in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59600 : functions with mismatching no_sanitize_address attributes should not be considered for inlining, otherwise the meaning of no_sanitize_address will not be preserved. I didn't get feedback in Bugz

RE: [PING][PATCH]Improving mklog [was: Re: RFC Asan instrumentation control]

2014-01-21 Thread Tatiana Udalova
> Apologies for the delay. The patch is OK. Thanks. Committed revision 206875. Thank you, Tatiana Udalova

Re: [Patch] Fix regex `nosubs` correctly

2014-01-21 Thread Jonathan Wakely
On 20/01/14 17:43 -0500, Tim Shen wrote: The semantic of `nosubs` should simply be that `let all parentheses not be a subexpression and do not capture it`. It's not clear to me whether the standard says that nosubs implies mark_count() == 0 or that the mark count remains the same, but no sub-ex

Re: [patch] fix libstdc++/56267 - local iterator requirements

2014-01-21 Thread Jonathan Wakely
On 20 January 2014 21:11, François Dumont wrote: > On 01/20/2014 04:53 PM, Jonathan Wakely wrote: > > With this new design couldn't we change the conditions that are used to > decide when to cache the hash code. I haven't study it in detail but it > looks like the default constructible constraint

Re: RFC Asan instrumentation control

2014-01-21 Thread Dominique Dhumieres
> Thanks, commited in 206458 without c-c++-common/asan/no-asan-stack.c > testfile. ... This caused http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59897. TIA Dominique

Re: Commit: MSP430: Add -mcpu= option

2014-01-21 Thread nick clifton
Hi Gerald, "command-line option", I think, and I suggest to use ... around the actual options. OK - I have made those changes and committed the result. Cheers Nick

[Ada] Update spec for Compile_Time_Known_Value

2014-01-21 Thread Arnaud Charlet
This is an internal change to documentation, and the interface to one function in the compiler. No functional effect, so no test needed. Tested on x86_64-pc-linux-gnu, committed on trunk 2014-01-21 Robert Dewar * sem_eval.adb (Compile_Time_Known_Value): Add Ignore_CRT paramete

[Ada] Spurious visibility error with nlined subprogram in with-clauses

2014-01-21 Thread Arnaud Charlet
A compilation unit that is a subprogram is rewritten as a package (the wrapper package) containing the body of the actual subprogram instance. The wrapping happens when the unit is compiled upon its appearance in the context of some unit. If it appears in several such contexts, and the subprogram i

[Ada] Spurious visibility error for operator in pre-condition

2014-01-21 Thread Arnaud Charlet
If a user-defined operator renames a predefined one, a use of that operator is rewritten with the predefined one, because the back-end requires it. This transformation must not be performed when analyzing the expression in a pre- or postcondition aspect or pragma, because the expression will be rea

[Ada] Adjust internal flags for Do_Discrminant_Check

2014-01-21 Thread Arnaud Charlet
This is a preliminary internal change for setting Do_Discriminant_Check flags properly in the tree. No functional effect, so no test needed Tested on x86_64-pc-linux-gnu, committed on trunk 2014-01-21 Robert Dewar * sinfo.ads, sinfo.adb: Change Do_Discriminant_Check to use new Flag1.