Re: RFC Asan instrumentation control

2014-01-09 Thread Jakub Jelinek
On Fri, Jan 10, 2014 at 11:49:43AM +0400, Maxim Ostapenko wrote: > 2014-01-10 Max Ostapenko > > * c-c++-common/asan/no-asan-stack.c: New test. > --- /dev/null > +++ b/gcc/testsuite/c-c++-common/asan/no-asan-stack.c > @@ -0,0 +1,17 @@ > +/* { dg-do assemble { target { x86_64-unknown-linux

Re: RFC Asan instrumentation control

2014-01-09 Thread Maxim Ostapenko
Hi! >>> * c-c++-common/asan/no-asan-stack.c (this triggers read overflow >>> because we haven't found a cross-platform way to grep for stack >>> redzones instrumentation) >> >> I'd prefer no test in that case, or just some semi-platform specific test >> (scan that the 0x41b58ab3 constant doesn't

Go patch committed: Use backend interface for slice info

2014-01-09 Thread Ian Lance Taylor
This patch from Chris Manghane changes gccgo to use the backend interface for slice info. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 44fc257ad7f2 go/expressions.cc --- a/go/expressions.cc Thu Jan 09 15:25:44 2014 -0800 +++ b/go/expressions.

[PATCH] MIPS: improve Loongson-2E/2F/3A detection for -march=native

2014-01-09 Thread Huacai Chen
Hi all, For human-readability, I submit a patch to Linux kernel to display Loongson-2E/2F/3A in /proc/cpuinfo. But that break -march=native, this patch fix that. Regards, Huacai 2014-01-10 Huacai Chen * config/mips/driver-native.c: improve Loongson-2E/2F/3A detection --- gcc/confi

Re: [gofrontend-dev] libgo patch committed: Fix 32-bit memory allocation

2014-01-09 Thread Ian Lance Taylor
On Thu, Jan 9, 2014 at 6:34 PM, Michael Hudson-Doyle wrote: > > Ian Lance Taylor writes: > >> This patch to libgo fixes memory allocation on 32-bit systems when a lot >> of memory has been allocated. The problem is described in this patch to >> the master repository: https://codereview.appspot.c

Re: Improving mklog [was: Re: RFC Asan instrumentation control]

2014-01-09 Thread Yury Gribov
> I hacked a simple addition to mklog which skips unchanged functions > in diff-log while adding function names to the final ChangeLog. > > New mklog results were verified by testsuite which compares reference > ChangeLogs of patches from gcc trunk with logs generated by mklog. > > Patched mklog c

Re: [PATCH] libsanitizer demangling using cp-demangle.c

2014-01-09 Thread Konstantin Serebryany
On Thu, Jan 9, 2014 at 5:57 PM, Jakub Jelinek wrote: > On Thu, Jan 09, 2014 at 05:51:05PM +0400, Konstantin Serebryany wrote: >> On Tue, Dec 10, 2013 at 3:38 PM, Jakub Jelinek wrote: >> > On Fri, Dec 06, 2013 at 06:40:52AM -0800, Ian Lance Taylor wrote: >> >> There was a recent buggy patch to the

RE: [PATCH] Add zero-overhead looping for xtensa backend

2014-01-09 Thread Yangfei (Felix)
And here is the xtensa configuration tested (include/xtensa-config.h): #define XCHAL_HAVE_BE 0 #define XCHAL_HAVE_LOOPS1 > > Hi Sterling, > > Please note that version 2 of the patch is for gcc trunk, not for > gcc-4.8 branch. > Since the doloop_end pattern fo

Re: [gofrontend-dev] libgo patch committed: Fix 32-bit memory allocation

2014-01-09 Thread Michael Hudson-Doyle
Ian Lance Taylor writes: > This patch to libgo fixes memory allocation on 32-bit systems when a lot > of memory has been allocated. The problem is described in this patch to > the master repository: https://codereview.appspot.com/49460043 . Here's a patch for the 4.8 branch if you are interest

Re: [PATCH] Tiny predcom improvement (PR tree-optimization/59643)

2014-01-09 Thread H.J. Lu
On Tue, Dec 31, 2013 at 11:04 AM, Jakub Jelinek wrote: > Hi! > > As written in the PR, I've been looking why is llvm 3.[34] so much faster > on Scimark2 SOR benchmark and the reason is that it's predictive commoning > or whatever it uses doesn't give up on the inner loop, while our predcom > unnec

Re: [PATCH][IRA] Analysis of register usage of functions for usage by IRA.

2014-01-09 Thread Tom de Vries
On 09-01-14 22:10, Andi Kleen wrote: Tom de Vries writes: Is this patch OK for stage1 (after proper retesting)? Could you perhaps post the latest series first? I don't think it made it to the mailing list. Andi, the current status is: - toplevel of patch series: http://gcc.gnu.org/ml/

Re: [PATCH] Add zero-overhead looping for xtensa backend

2014-01-09 Thread Felix Yang
Hi Sterling, Please note that version 2 of the patch is for gcc trunk, not for gcc-4.8 branch. Since the doloop_end pattern format has changed, this patch need small adaptation in order for it to work on gcc-4.8. Although I test it on gcc-4.8, I think the testing result still holds fo

Re: [PING^2][PATCH] -fuse-caller-save - Implement TARGET_FN_OTHER_HARD_REG_USAGE hook for MIPS

2014-01-09 Thread Tom de Vries
On 09-01-14 16:31, Richard Sandiford wrote: Tom de Vries writes: On 25/12/13 14:02, Tom de Vries wrote: On 07-12-13 16:07, Tom de Vries wrote: Richard, This patch implements the target hook TARGET_FN_OTHER_HARD_REG_USAGE (posted here: http://gcc.gnu.org/ml/gcc-patches/2013-03/msg01318.html)

[committed] Fix vect_analyze_data_refs (PR middle-end/59670)

2014-01-09 Thread Jakub Jelinek
Hi! I forgot to check is_gimple_call before checking gimple_call_internal_p. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed as obvious. 2014-01-09 Jakub Jelinek PR middle-end/59670 * tree-vect-data-refs.c (vect_analyze_data_refs): Check

[patch] fix libstdc++/59680

2014-01-09 Thread Jonathan Wakely
PR libstdc++/59680 * src/c++11/thread.cc (__sleep_for): Fix call to ::sleep. Tested x86_64-linux, and tested again with a hacked c++config.h to use ::sleep(), committed to trunk. commit 3de5274663e0214b8c5335e99ef85f325f709840 Author: Jonathan Wakely Date: Thu Jan 9 14:33:20 201

Re: [PATCH] Allocate all target globals using GC for SWITCHABLE_TARGETs

2014-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2014 at 08:42:03AM -0800, Richard Henderson wrote: > On 01/09/2014 08:35 AM, Jakub Jelinek wrote: > > That would be fine for 1), but would mean 2). It is also fine to GC > > allocate each structure individually, but some (like bb_reorder) are say > > just 4 bytes long, so it might

Go patch committed: Add flattening pass

2014-01-09 Thread Ian Lance Taylor
This patch from Chris Manghane adds a flattening pass to the Go frontend. This is a step toward moving more types of expressions into the backend interface. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 447683c37ddf go/expressions.h --- a/go/

libgo patch committed: Fix 32-bit memory allocation

2014-01-09 Thread Ian Lance Taylor
This patch to libgo fixes memory allocation on 32-bit systems when a lot of memory has been allocated. The problem is described in this patch to the master repository: https://codereview.appspot.com/49460043 . runtime: fix 32-bit malloc for pointers >= 0x8000 The spans array is alloc

Re: PR 59712 patch

2014-01-09 Thread Jonathan Wakely
On 9 January 2014 21:55, François Dumont wrote: > > All unordered_* tests run under Linux x86_64. Please make sure you run the entire testsuite, not just the parts that seem relevant.

Re: Rb tree node recycling patch

2014-01-09 Thread Paolo Carlini
Hi > Could you point me to the bugzilla entry you are mentioning ? libstdc++/29988 Thanks, Paolo

Re: Question about gimplify.c:gimplify_adjust_omp_clauses_1, GOVD_MAP_TO_ONLY

2014-01-09 Thread Thomas Schwinge
Hi! On Thu, 09 Jan 2014 23:21:26 +0100, I wrote: > On Thu, 9 Jan 2014 21:43:35 +0100, Jakub Jelinek wrote: > > On Thu, Jan 09, 2014 at 09:38:25PM +0100, Thomas Schwinge wrote: > > > In gimplify.c:gimplify_adjust_omp_clauses_1, does the case for > > > GOVD_MAP_TO_ONLY have a real current use case

Re: Question about gimplify.c:gimplify_adjust_omp_clauses_1, GOVD_MAP_TO_ONLY

2014-01-09 Thread Thomas Schwinge
Hi! On Thu, 9 Jan 2014 21:43:35 +0100, Jakub Jelinek wrote: > On Thu, Jan 09, 2014 at 09:38:25PM +0100, Thomas Schwinge wrote: > > In gimplify.c:gimplify_adjust_omp_clauses_1, does the case for > > GOVD_MAP_TO_ONLY have a real current use case (I couldn't spot any), or > > is it "just for complet

[Patch] Fix PR plugin/59335, plugins not compiling

2014-01-09 Thread Steve Ellcey
Some header files needed by plugins are not present in the installed plugin include directory. This patch adds those headers. I added all the headers I needed for my plugin plus the ones mentioned in the patch. I did not add the x86 specific *.def files but this should fix all the generic platfo

Re: Rb tree node recycling patch

2014-01-09 Thread François Dumont
On 01/08/2014 02:34 PM, Paolo Carlini wrote: Hi, On 12/27/2013 07:30 PM, François Dumont wrote: Note that this patch contains also a cleanup of a useless template parameter _Is_pod_comparator on _Rb_tree_impl. The useless parameter is a remnant of an attempt at exploiting the EBO for _Rb_tree_

PR 59712 patch

2014-01-09 Thread François Dumont
Hi Here is a patch for this small problem with clang. It is not a blocking issue for the 4.9 release but at the same time it is a rather safe fix so just tell me if I can commit it. All unordered_* tests run under Linux x86_64. I haven't clang installed at the moment so a clang feedb

Re: [PATCH][IRA] Analysis of register usage of functions for usage by IRA.

2014-01-09 Thread Andi Kleen
Tom de Vries writes: > > Is this patch OK for stage1 (after proper retesting)? Could you perhaps post the latest series first? I don't think it made it to the mailing list. -Andi

Re: Question about gimplify.c:gimplify_adjust_omp_clauses_1, GOVD_MAP_TO_ONLY

2014-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2014 at 09:38:25PM +0100, Thomas Schwinge wrote: > In gimplify.c:gimplify_adjust_omp_clauses_1, does the case for > GOVD_MAP_TO_ONLY have a real current use case (I couldn't spot any), or > is it "just for completeness"? It is typically for any artificial vars that are known not to

Re: [PATCH][IRA] Analysis of register usage of functions for usage by IRA.

2014-01-09 Thread Tom de Vries
On 09-01-14 15:41, Richard Earnshaw wrote: On 30/03/13 16:10, Tom de Vries wrote: On 29/03/13 13:54, Tom de Vries wrote: I split the patch up into 10 patches, to facilitate further review: ... 0001-Add-command-line-option.patch 0002-Add-new-reg-note-REG_CALL_DECL.patch 0003-Add-implicit-paramet

Question about gimplify.c:gimplify_adjust_omp_clauses_1, GOVD_MAP_TO_ONLY

2014-01-09 Thread Thomas Schwinge
Hi! In gimplify.c:gimplify_adjust_omp_clauses_1, does the case for GOVD_MAP_TO_ONLY have a real current use case (I couldn't spot any), or is it "just for completeness"? diff --git gcc/gimplify.c gcc/gimplify.c index 3738589..870550c 100644 --- gcc/gimplify.c +++ gcc/gimplify.c @@ -6136,9 +6136,9

Re: [Patch] Remove references to non-existent tree-flow.h file

2014-01-09 Thread Richard Biener
Steve Ellcey wrote: >While looking at PR 59335 (plugin doesn't build) I saw the comments >about >tree-flow.h and tree-flow-inline.h not existing anymore. While these >files have been removed there are still some references to them in >Makefile.in, doc/tree-ssa.texi, and a couple of source files.

Re: [PATCH] Ignore DECL_ALIGN of SSA_NAME underlying decls for dynamic stack realignment (PR middle-end/47735)

2014-01-09 Thread Richard Biener
Jakub Jelinek wrote: >Hi! > >As discussed in the PR, if a var isn't addressable and has gimple reg >type, >I don't see any point to honor it's DECL_ALIGN, we only refer to the >var through SSA_NAME_VAR of SSA_NAMEs, nothing is allocated on the >stack >immediately and the SSA_NAMEs are turned into

[MIPS, committed] Backport bswap patches to 4.8

2014-01-09 Thread Richard Sandiford
I got an off-list request to backport the bswap patterns to 4.8. They've been in trunk for a while without any problems being reported and they should be relatively safe. Here's what I applied after testing on mips64-linux-gnu (with --with-arch=mips64r2). The only difference is the use of: [(s

Re: [MIPS, committed] Revert some Octeon BADDU patches

2014-01-09 Thread Richard Sandiford
Eric Botcazou writes: >> This patch just reverts some changes I'd made to the BADDU patterns >> for the infamous (truncate:QI (plus:SI ...)) -> (plus:QI ...) >> simplification. That simplification was limited to CISCy targets for PR >> 58295. >> >> Tested on mips64-linux-gnu and applied. It fixe

Re: [PATCH] Fix devirtualization ICE (PR tree-optimization/59622, take 5)

2014-01-09 Thread Richard Biener
Jakub Jelinek wrote: >On Thu, Jan 09, 2014 at 02:27:40PM +0100, Richard Biener wrote: >> > Perhaps, if you don't like the !gimple_in_ssa_p (cfun) in the >condition >> > we can just drop the lhs always in that case, just doing what we do >for >> > __builtin_unreachable if lhs is SSA_NAME: >> > tr

[Patch, Fortran, committed] Fix buglet in cpp.c

2014-01-09 Thread Tobias Burnus
Committed as obvious: Rev. 206487. Tobias Index: gcc/fortran/ChangeLog === --- gcc/fortran/ChangeLog (Revision 206486) +++ gcc/fortran/ChangeLog (Arbeitskopie) @@ -1,3 +1,8 @@ +2014-01-09 Tobias Burnus + + * cpp.c (gfc_cpp_handle_

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2014-01-09 Thread Rong Xu
My bad. Thanks for the fix! -Rong On Thu, Jan 9, 2014 at 11:47 AM, H.J. Lu wrote: > On Wed, Jan 8, 2014 at 2:33 PM, Rong Xu wrote: >> On Fri, Dec 6, 2013 at 6:23 AM, Jan Hubicka wrote: @@ -325,6 +311,9 @@ static struct gcov_summary all_prg; #endif /* crc32 for this program. *

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2014-01-09 Thread H.J. Lu
On Wed, Jan 8, 2014 at 2:33 PM, Rong Xu wrote: > On Fri, Dec 6, 2013 at 6:23 AM, Jan Hubicka wrote: >>> @@ -325,6 +311,9 @@ static struct gcov_summary all_prg; >>> #endif >>> /* crc32 for this program. */ >>> static gcov_unsigned_t crc32; >>> +/* Use this summary checksum rather the computed

Re: PATCH: Remove the unused btver1

2014-01-09 Thread Uros Bizjak
On Thu, Jan 9, 2014 at 8:32 PM, H.J. Lu wrote: > btver1 iis never used. This patch removes it. It avoids: > > insn-attrtab.c:extern int internal_dfa_insn_code_btver1 (rtx); > insn-attrtab.c:extern int insn_default_latency_btver1 (rtx); > > OK to install? OK. Thanks, Uros.

PATCH: Remove the unused btver1

2014-01-09 Thread H.J. Lu
Hi Uros, btver1 iis never used. This patch removes it. It avoids: insn-attrtab.c:extern int internal_dfa_insn_code_btver1 (rtx); insn-attrtab.c:extern int insn_default_latency_btver1 (rtx); OK to install? Thanks. -- H.J. -- 2014-01-09 H.J. Lu * config/i386/i386.md (cpu): Remove the unu

Re: [Patch, testsuite, mips] Fix test gcc.dg/delay-slot-1.c for MIPS

2014-01-09 Thread Richard Sandiford
"Steve Ellcey " writes: > 2014-01-09 Steve Ellcey > > * gcc.dg/delay-slot-1.c: Add check for 64 bit support. OK, thanks. Pedantically it's "Restrict -mabi=64 to 64-bit processors.", since we're not really checking whether the support is there, but whether n64 is compatible with the curr

Re: [PATCH,rs6000] Add -maltivec={le,be} options

2014-01-09 Thread David Edelsohn
On Thu, Jan 9, 2014 at 1:14 PM, Bill Schmidt wrote: > Thanks for the comments! Here is a second go-round at the patch with > improved documentation. I'm happy to change the wording if it can be > further improved. > > Thanks, > Bill > > 2014-01-09 Bill Schmidt > > * doc/invoke.texi: A

[Patch, testsuite, mips] Fix test gcc.dg/delay-slot-1.c for MIPS

2014-01-09 Thread Steve Ellcey
The gcc.dg/delay-slot-1.c test is failing for MIPS targets that do not support the 64 bit ABI because it didn't check to see if that support existed before using the -mabi=64 flag. This patch fixes the problem by using the mips64 check. OK to checkin? Steve Ellcey sell...@mips.com 2014-01-09

Re: [PATCH,rs6000] Add -maltivec={le,be} options

2014-01-09 Thread Joseph S. Myers
On Thu, 9 Jan 2014, Bill Schmidt wrote: > +When -maltivec is used, rather than -maltivec=le or -maltivec=be, the > +element order for Altivec intrinsics such as vec_splat, vec_extract, > +and vec_insert will match array element order corresponding to the > +endianness of the target. That is, elem

Re: std::vector move assign patch

2014-01-09 Thread Jonathan Wakely
On 9 January 2014 12:22, H.J. Lu wrote: > On Fri, Dec 27, 2013 at 10:27 AM, François Dumont > wrote: >> Hi >> >> Here is a patch to fix an issue in normal mode during the move >> assignment. The destination vector allocator instance is moved too during >> the assignment which is wrong. >> >>

Re: [PATCH, AArch64 4/6] soft-fp: Commonize creation of TImode types

2014-01-09 Thread Joseph S. Myers
On Thu, 9 Jan 2014, Richard Henderson wrote: > > This isn't the right conditional. _FP_W_TYPE_SIZE is ultimately an > > optimization choice and need not be related to whether any TImode > > functions are being defined using soft-fp, or whether TImode is supported > > at all. I think the most

Re: PATCH: Put a breakpoint on __sanitizer::Report

2014-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2014 at 10:28:56AM -0800, H.J. Lu wrote: > Hi, > > This patch puts a breakpoint on __sanitizer::Report to help > with debugging sanitizer issues. OK to install? Ok. > 2014-01-09 H.J. Lu > > * gdbasan.in: Put a breakpoint on __sanitizer::Report. > diff --git a/gcc/gdbasan.in

Re: [patch] PR56572 flatten unnecessary nested transactions after inlining

2014-01-09 Thread Aldy Hernandez
On 01/06/14 13:40, Richard Henderson wrote: On 12/19/2013 11:06 AM, Richard Biener wrote: Aldy Hernandez wrote: I'd still like to catch the common cases, like I do with this patch. Perhaps we move this code to the .tmmark pass and handle the uninstrumented case. rth? tmmark is way way late

PATCH: Put a breakpoint on __sanitizer::Report

2014-01-09 Thread H.J. Lu
Hi, This patch puts a breakpoint on __sanitizer::Report to help with debugging sanitizer issues. OK to install? Thanks. -- H.J. -- 2014-01-09 H.J. Lu * gdbasan.in: Put a breakpoint on __sanitizer::Report. diff --git a/gcc/gdbasan.in b/gcc/gdbasan.in index cf05825..3a6fca0 100644 --- a/gcc

[PATCH] Fix devirtualization ICE (PR tree-optimization/59622, take 5)

2014-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2014 at 02:27:40PM +0100, Richard Biener wrote: > > Perhaps, if you don't like the !gimple_in_ssa_p (cfun) in the condition > > we can just drop the lhs always in that case, just doing what we do for > > __builtin_unreachable if lhs is SSA_NAME: > > tree var = create_tmp_var (TREE

[PATCH] Ignore DECL_ALIGN of SSA_NAME underlying decls for dynamic stack realignment (PR middle-end/47735)

2014-01-09 Thread Jakub Jelinek
Hi! As discussed in the PR, if a var isn't addressable and has gimple reg type, I don't see any point to honor it's DECL_ALIGN, we only refer to the var through SSA_NAME_VAR of SSA_NAMEs, nothing is allocated on the stack immediately and the SSA_NAMEs are turned into pseudos for which we only care

Re: [PATCH,rs6000] Add -maltivec={le,be} options

2014-01-09 Thread Bill Schmidt
Thanks for the comments! Here is a second go-round at the patch with improved documentation. I'm happy to change the wording if it can be further improved. Thanks, Bill 2014-01-09 Bill Schmidt * doc/invoke.texi: Add -maltivec={be,le} options, and document default element-ord

Re: [PATCH, go]: Skip some go tests

2014-01-09 Thread Ian Lance Taylor
On Thu, Jan 9, 2014 at 2:54 AM, Uros Bizjak wrote: > > There are two remaining warnings: > > go.test/test/nilcheck.go: unrecognized test line: // errorcheck -0 -N -d=nil > go.test/test/nilptr3.go: unrecognized test line: // errorcheck -0 -d=nil Thanks, not sure how I missed those. Those tests ar

[ping] Re: [patch] Pass -fuse-ld=gold to gccgo on targets supporting -fsplit-stack

2014-01-09 Thread Matthias Klose
ping patch Am 29.11.2013 14:29, schrieb Matthias Klose: > to get full advantage of the -fsplit-stack option, gccgo binaries have to be > linked with gold, not the bfd linker. When the system linker defaults to the > bfd linker, then gccgo should explicitly use the gold linker, passing > fuse-ld=g

[C++ testcase, committed] PR 59730

2014-01-09 Thread Paolo Carlini
Hi, this just adds the testcase to mainline. Thanks, Paolo. // 2014-01-09 Paolo Carlini PR c++/59730 * g++.dg/cpp0x/variadic145.C: New. Index: g++.dg/cpp0x/variadic145.C === --- g++.dg/cp

[Patch] Remove references to non-existent tree-flow.h file

2014-01-09 Thread Steve Ellcey
While looking at PR 59335 (plugin doesn't build) I saw the comments about tree-flow.h and tree-flow-inline.h not existing anymore. While these files have been removed there are still some references to them in Makefile.in, doc/tree-ssa.texi, and a couple of source files. This patch removes the re

[PATCH][ARM] Get mode for rtx costs calculations for SET RTX from destination reg

2014-01-09 Thread Kyrill Tkachov
Hi all, SET RTXs don't have a mode, so the code to calculate a reg-to-reg set in the arm rtx costs function needs to get the mode from one of the registers involved. We already did that when the source is a CONST_INT. This patch fixes that oversight and also prevents us from falling through o

[PATCH][ARM] Add CRC32 to the feature flags of Cortex-A53, A57

2014-01-09 Thread Kyrill Tkachov
Hi all, The Cortex-A53 and Cortex-A57 processors support the CRC32 extensions to ARMv8-a, so we specify that in their definitions in arm-cores.def. This also updates their big.LITTLE amalgamation and removes the redundant FL_THUMB_DIV and FL_ARM_DIV there since ARMv8-a already implies those fla

[PATCH][ARM] Fix arm_init_iwmmxt_builtins to handle only iwmmxt entries

2014-01-09 Thread Kyrill Tkachov
Hi all, After my CRC32 intrinsics patch that added new entries into the bdesc_2arg table, the arm_init_iwmmxt_builtins function tries to iterate over them and blows up, causing an ICE when trying to compile with -mcpu=iwmmxt. This patch fixes that by ignoring the non-iwmmxt entries in that ta

Re: [PATCH, go]: Skip some go tests

2014-01-09 Thread Uros Bizjak
On Thu, Jan 9, 2014 at 4:01 PM, Ian Lance Taylor wrote: > On Thu, Jan 9, 2014 at 2:54 AM, Uros Bizjak wrote: >> >> 2014-01-09 Uros Bizjak >> >> * go.test/go-test.exp (go-gc-tests): Don't run peano.go on systems >> which don't support -fsplit-stack. Skip rotate[0123]-out.go. > > This i

[PATCH][testsuite][ARM] Properly figure -mfloat-abi option for crypto tests

2014-01-09 Thread Kyrill Tkachov
Hi all, When adding the testsuite options for the crypto tests we need to make sure that don't end up adding -mfloat-abi=softfp to a hard-float target like arm-none-linux-gnueabihf. This patch adds that code to figure out which -mfpu/-mfloat-abi combination to use in a similar approach to the

Re: [Patch,testsuite] Fix testcases that use bind_pic_locally

2014-01-09 Thread Vidya Praveen
On Wed, Jan 08, 2014 at 12:28:56PM +, Jakub Jelinek wrote: > On Wed, Jan 08, 2014 at 11:49:08AM +, Vidya Praveen wrote: > > On Tue, Jan 07, 2014 at 09:35:54PM +, Mike Stump wrote: > > > On Dec 17, 2013, at 6:06 AM, Vidya Praveen wrote: > > > > bind_pic_locally is broken for targets tha

[PATCH, committed] Fix for PR 59094

2014-01-09 Thread Iyer, Balaji V
Hello Everyone, The following patch will fix the bug in PR 59094. The main issue was that version specific libraries are not stored in the correct location. The patch below should fix that. It is committed since the person who filed the bug has confirmed that the fix works. Index: libci

Re: [PATCH] Allocate all target globals using GC for SWITCHABLE_TARGETs

2014-01-09 Thread Richard Henderson
On 01/09/2014 08:35 AM, Jakub Jelinek wrote: > That would be fine for 1), but would mean 2). It is also fine to GC > allocate each structure individually, but some (like bb_reorder) are say > just 4 bytes long, so it might be overkill. Hmm.. Perhaps define the whole structure as you do, but som

Re: [PATCH] Allocate all target globals using GC for SWITCHABLE_TARGETs

2014-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2014 at 08:25:31AM -0800, Richard Henderson wrote: > > + p = (struct target_globals_extra *) > > + ggc_internal_cleared_alloc_stat (sizeof (struct target_globals_extra) > > + PASS_MEM_STAT); > > + g = (struct target_globals *) p; > > + g->fla

[PING^2] [PATCH]SIMD-Enabled functions for C++

2014-01-09 Thread Iyer, Balaji V
Hello Jakub, Did you get a chance to look at this patch (http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00116.html)? I think I have fixed all the changes you requested. Is it ok for trunk? Thanks, Balaji V. Iyer.

Re: [PATCH] Allocate all target globals using GC for SWITCHABLE_TARGETs

2014-01-09 Thread Richard Henderson
On 01/08/2014 10:34 AM, Jakub Jelinek wrote: >struct target_globals *g; > - > - g = ggc_alloc_target_globals (); > - g->flag_state = XCNEW (struct target_flag_state); > - g->regs = XCNEW (struct target_regs); > + struct target_globals_extra { > +struct target_globals g; > +struct ta

Re: a patch prototype for PR59535 (THUMB code size regression)

2014-01-09 Thread Vladimir Makarov
On 1/9/2014, 10:30 AM, Richard Earnshaw wrote: On 09/01/14 15:21, Vladimir Makarov wrote: Hi, Richard. This week I've been working on THUMB code size issues. Here is the prototype of the patch for spilling into HI_REGS instead of memory. The patch decreases number of generated insns and ma

Fix ipa-devirt ICE on virtual inheritance

2014-01-09 Thread Jan Hubicka
Hi, this patch fixes IPA-devirt testcase that gave me bad sleep for months. The problem turned out to be combination of three issues (that greatly confused me). This patch fixes first two. Here representation of BINFOs of multiple inheritnace actually differs from my mental modem. For diamond sha

Re: [PATCH] Change i?86/x86_64 into SWITCHABLE_TARGET (PR58115, take 2)

2014-01-09 Thread Richard Henderson
On 01/08/2014 04:45 AM, Jakub Jelinek wrote: > 2014-01-07 Jakub Jelinek > > PR target/58115 > * tree-core.h (struct target_globals): New forward declaration. > (struct tree_target_option): Add globals field. > * tree.h (TREE_TARGET_GLOBALS): Define. > (prepare_targ

Re: [PATCH, AArch64 4/6] soft-fp: Commonize creation of TImode types

2014-01-09 Thread Richard Henderson
On 01/08/2014 12:39 PM, Joseph S. Myers wrote: > On Wed, 8 Jan 2014, Richard Henderson wrote: > >> diff --git a/libgcc/soft-fp/soft-fp.h b/libgcc/soft-fp/soft-fp.h >> index 696fc86..b54b1ed 100644 >> --- a/libgcc/soft-fp/soft-fp.h >> +++ b/libgcc/soft-fp/soft-fp.h >> @@ -237,6 +237,11 @@ typedef i

Re: [PATCH i386 4/8] [AVX512] [6/8] Add substed patterns: `sae' subst.

2014-01-09 Thread H.J. Lu
On Wed, Dec 18, 2013 at 5:02 AM, Kirill Yukhin wrote: > Hello, > > On 02 Dec 16:10, Kirill Yukhin wrote: >> Hello, >> On 19 Nov 12:11, Kirill Yukhin wrote: >> > Hello, >> > On 15 Nov 20:07, Kirill Yukhin wrote: >> > > > Is it ok for trunk? >> > > Ping. >> > Ping. >> Ping. > Ping. > > Rebased patch

Re: [PATCH, AArch64 6/6] aarch64: Define add_ssaaaa, sub_ddmmss, umul_ppmm

2014-01-09 Thread Yufeng Zhang
Hi, This patch and the preceding aarch64.md patches all look good to me, but I cannot approve it. Thanks for adding the support for these missing patterns and defines! Yufeng On 01/08/14 18:13, Richard Henderson wrote: We have good support for TImode arithmetic, so no need to do anything wi

Re: [PING^2][PATCH] -fuse-caller-save - Implement TARGET_FN_OTHER_HARD_REG_USAGE hook for MIPS

2014-01-09 Thread Richard Sandiford
Tom de Vries writes: > On 25/12/13 14:02, Tom de Vries wrote: >> On 07-12-13 16:07, Tom de Vries wrote: >>> Richard, >>> >>> This patch implements the target hook TARGET_FN_OTHER_HARD_REG_USAGE (posted >>> here: http://gcc.gnu.org/ml/gcc-patches/2013-03/msg01318.html) for MIPS, to >>> address the

Re: a patch prototype for PR59535 (THUMB code size regression)

2014-01-09 Thread Richard Earnshaw
On 09/01/14 15:21, Vladimir Makarov wrote: > Hi, Richard. > >This week I've been working on THUMB code size issues. Here is the > prototype of the patch for spilling into HI_REGS instead of memory. > The patch decreases number of generated insns and makes the code faster > as it removes a lot

[Patch, Fortran] PR 58026: Bad error recovery for allocatable component of undeclared type

2014-01-09 Thread Janus Weil
Hi all, the attached patch started out as an ICE-on-invalid regression fix, but after the ICE had been fixed recently by other means, it was degraded to a mere error-recovery improvement. It removes some rather 'hackish' code that was added by Paul quite a long time ago. Regtests cleanly on x86_6

Re: [patch] regcprop fix for PR rtl-optimization/54300

2014-01-09 Thread Richard Earnshaw
On 20/11/13 13:57, Richard Earnshaw wrote: > On 19/11/13 17:48, Jeff Law wrote: >> On 11/19/13 10:32, Steven Bosscher wrote: >>> >>> Yes. In the GCC3 days it was important for sincos on i386, and on mk68 >>> it used to be important for some of the funnier patterns. Not sure if >>> it's still useful

a patch prototype for PR59535 (THUMB code size regression)

2014-01-09 Thread Vladimir Makarov
Hi, Richard. This week I've been working on THUMB code size issues. Here is the prototype of the patch for spilling into HI_REGS instead of memory. The patch decreases number of generated insns and makes the code faster as it removes a lot of loads/stores. I am sending the patch for your ev

Re: wide-int, loop

2014-01-09 Thread Richard Biener
On Thu, Jan 2, 2014 at 5:27 AM, Mike Stump wrote: > On Nov 26, 2013, at 1:14 AM, Richard Biener > wrote: @@ -2662,8 +2661,8 @@ iv_number_of_iterations (struct loop *loop, rtx insn, rtx condition, iv1.step = const0_rtx; if (INTVAL (iv0.step) < 0) { >

Re: wide-int, sched

2014-01-09 Thread Richard Biener
On Thu, Jan 2, 2014 at 5:53 AM, Mike Stump wrote: > On Nov 23, 2013, at 11:22 AM, Mike Stump wrote: >> Richi has asked the we break the wide-int patch so that the individual port >> and front end maintainers can review their parts without have to go through >> the entire patch.This patch co

Re: wide-int, ipa

2014-01-09 Thread Richard Biener
On Thu, Jan 2, 2014 at 5:12 AM, Mike Stump wrote: > On Nov 23, 2013, at 11:22 AM, Mike Stump wrote: >> Richi has asked the we break the wide-int patch so that the individual port >> and front end maintainers can review their parts without have to go through >> the entire patch.This patch co

Re: wide-int, gimple

2014-01-09 Thread Richard Biener
On Thu, Jan 2, 2014 at 5:10 AM, Mike Stump wrote: > On Nov 28, 2013, at 6:20 AM, Richard Biener > wrote: >> On Thu, Nov 28, 2013 at 12:58 PM, Richard Sandiford >> wrote: >>> Jakub Jelinek writes: On Mon, Nov 25, 2013 at 12:24:30PM +0100, Richard Biener wrote: > On Sat, Nov 23, 2013 at

Re: wide-int, doc

2014-01-09 Thread Richard Biener
On Sat, Nov 23, 2013 at 8:21 PM, Mike Stump wrote: > Richi has asked the we break the wide-int patch so that the individual port > and front end maintainers can review their parts without have to go through > the entire patch.This patch covers the documentation. > > Ok? Ok. Thanks, Richard

Re: wide-int, build system

2014-01-09 Thread Richard Biener
On Sat, Nov 23, 2013 at 8:20 PM, Mike Stump wrote: > Richi has asked the we break the wide-int patch so that the individual port > and front end maintainers can review their parts without have to go through > the entire patch.This patch covers the build system (make). > > Ok? Needs updating

Re: [PATCH] Add zero-overhead looping for xtensa backend

2014-01-09 Thread Felix Yang
Hi Sterling, Attached please find version 2 of the patch. I applied this updated patch (with small adaptations) to gcc-4.8.2 and carried out some tests. I can execute the testcases in a simulator, which support zero-overhead looping instructions. First of all, I can successfully

Re: [ARM] add armv7ve support

2014-01-09 Thread Renlin Li
Hi Gerald, Sorry for the late reply! We're working on a list of all the ARM-related changes in 4.9. This will also be included. Kind regards, Renlin On 03/01/14 13:24, Gerald Pfeifer wrote: Renlin Li wrote: Hi all, This patch will add armv7ve support to gcc. Armv7ve is basically a armv7-a

Re: [PATCH, go]: Skip some go tests

2014-01-09 Thread Ian Lance Taylor
On Thu, Jan 9, 2014 at 2:54 AM, Uros Bizjak wrote: > > 2014-01-09 Uros Bizjak > > * go.test/go-test.exp (go-gc-tests): Don't run peano.go on systems > which don't support -fsplit-stack. Skip rotate[0123]-out.go. This is OK. Thanks. You might want to tweak the comment just under wher

Re: [Patch] Avoid gcc_assert in libgcov

2014-01-09 Thread Jan Hubicka
> As suggested by Honza, avoid bloating libgcov from gcc_assert by using > a new macro gcov_nonruntime_assert in gcov-io.c that is only mapped to > gcc_assert when not in libgcov. > > Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk? > > Thanks, > Teresa > > 2014-01-09 Teresa J

Re: [PATCH][IRA] Analysis of register usage of functions for usage by IRA.

2014-01-09 Thread Richard Earnshaw
On 30/03/13 16:10, Tom de Vries wrote: > On 29/03/13 13:54, Tom de Vries wrote: >> I split the patch up into 10 patches, to facilitate further review: >> ... >> 0001-Add-command-line-option.patch >> 0002-Add-new-reg-note-REG_CALL_DECL.patch >> 0003-Add-implicit-parameter-to-find_all_hard_reg_sets.p

[Patch] Avoid gcc_assert in libgcov

2014-01-09 Thread Teresa Johnson
As suggested by Honza, avoid bloating libgcov from gcc_assert by using a new macro gcov_nonruntime_assert in gcov-io.c that is only mapped to gcc_assert when not in libgcov. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2014-01-09 Teresa Johnson *

A question about forward_addr.

2014-01-09 Thread Peter Xu
Hi all, I'm confused by the annotation in shold_replace_address. Here is the code in fwprop.c: /* OLD is a memory address. Return whether it is good to use NEW instead, for a memory access in the given MODE. */ static bool should_replace_address (rtx old_rtx, rtx new_rtx, enum machin

Re: [PATCH] Fix PR49718 : allow no_instrument_function attribute in class member definition/declaration

2014-01-09 Thread Laurent Alfonsi
On 01/09/14 06:02, Jeff Law wrote: On 01/08/14 02:05, Laurent Alfonsi wrote: All, I was looking at PR49718. I have enclosed a simple fix for this bug report. 2014-01-07 Laurent Alfonsi * c-family/c-common.c (handle_no_instrument_function_attribute): Allow no_instrument_f

Re: [PATCH] libsanitizer demangling using cp-demangle.c

2014-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2014 at 05:51:05PM +0400, Konstantin Serebryany wrote: > On Tue, Dec 10, 2013 at 3:38 PM, Jakub Jelinek wrote: > > On Fri, Dec 06, 2013 at 06:40:52AM -0800, Ian Lance Taylor wrote: > >> There was a recent buggy patch to the demangler that added calls to > >> malloc and realloc (201

[PING^2][PATCH] -fuse-caller-save - Implement TARGET_FN_OTHER_HARD_REG_USAGE hook for MIPS

2014-01-09 Thread Tom de Vries
On 25/12/13 14:02, Tom de Vries wrote: > On 07-12-13 16:07, Tom de Vries wrote: >> Richard, >> >> This patch implements the target hook TARGET_FN_OTHER_HARD_REG_USAGE (posted >> here: http://gcc.gnu.org/ml/gcc-patches/2013-03/msg01318.html) for MIPS, to >> address the issue that $6 is sometimes use

Re: [PATCH] libsanitizer demangling using cp-demangle.c

2014-01-09 Thread Konstantin Serebryany
On Tue, Dec 10, 2013 at 3:38 PM, Jakub Jelinek wrote: > On Fri, Dec 06, 2013 at 06:40:52AM -0800, Ian Lance Taylor wrote: >> There was a recent buggy patch to the demangler that added calls to >> malloc and realloc (2013-10-25 Gary Benson ). >> That patch must be fixed or reverted before the 4.9 r

Re: [Patch, Fortran, committed] PR 59612: iso_fortran_env segfaults with -fdump-fortran-original

2014-01-09 Thread Janus Weil
After noticing that the bug is actually a regression (see PR 57042): Ok to backport to 4.7 and 4.8? Cheers, Janus 2013/12/29 Janus Weil : > Hi all, > > I have just committed an obvious patch for a segfault with > -fdump-fortran-original (plus a small documentation fix): > > http://gcc.gnu.org/v

Re: [PATCH] Fix devirtualization ICE (PR tree-optimization/59622, take 3)

2014-01-09 Thread Richard Biener
On Thu, 9 Jan 2014, Jakub Jelinek wrote: > On Thu, Jan 09, 2014 at 02:13:39PM +0100, Richard Biener wrote: > > On Thu, 9 Jan 2014, Jakub Jelinek wrote: > > > > > On Thu, Jan 09, 2014 at 01:30:53PM +0100, Richard Biener wrote: > > > > > gimplify_modify_expr has: > > > > > > > > > > if (!gim

Re: [PATCH] Fix devirtualization ICE (PR tree-optimization/59622, take 3)

2014-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2014 at 02:13:39PM +0100, Richard Biener wrote: > On Thu, 9 Jan 2014, Jakub Jelinek wrote: > > > On Thu, Jan 09, 2014 at 01:30:53PM +0100, Richard Biener wrote: > > > > gimplify_modify_expr has: > > > > > > > > if (!gimple_call_noreturn_p (assign)) > > > > gimple_cal

Improving mklog [was: Re: RFC Asan instrumentation control]

2014-01-09 Thread Tatiana Udalova
Hello, I have reproduced the problem with mklog mentioned by Jakub: > In my experience mklog is pretty much useless, e.g. if you add a new > function, it will list the previous function as being modified rather > than the new one, etc. My focus was on functions from headers of diff-log chunks.

Re: [PATCH] Fix devirtualization ICE (PR tree-optimization/59622, take 3)

2014-01-09 Thread Richard Biener
On Thu, 9 Jan 2014, Jakub Jelinek wrote: > On Thu, Jan 09, 2014 at 01:30:53PM +0100, Richard Biener wrote: > > > gimplify_modify_expr has: > > > > > > if (!gimple_call_noreturn_p (assign)) > > > gimple_call_set_lhs (assign, *to_p); > > > > Ok, it seems to be too early then - move i

Re: [PATCH] Fix PR45586

2014-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2014 at 12:48:49PM +0100, Richard Biener wrote: > *** gimple_canonical_types_compatible_p (tre > *** 458,465 > return true; > > /* Can't be the same type if they have different alignment, or mode. */ > ! if (TYPE_ALIGN (t1) != TYPE_ALIGN (t2) > !

  1   2   >