Re: [PATCH] Fix --with-long-double-128 for sparc32 when defaulting to 64-bit

2013-12-03 Thread Jakub Jelinek
On Wed, Dec 04, 2013 at 08:49:32AM +0100, Aurelien Jarno wrote: > On sparc, the --with-long-double-128 option doesn't change anything for > a 64-bit compiler, as it always default to 128-bit long doubles. For > a 32/64-bit compiler defaulting to 32-bit this correctly control the > size of long doub

RE: [PE-POST] Adjust Bit-region in expand_assignment

2013-12-03 Thread Bernd Edlinger
On Tue, 3 Dec 2013 22:55:32, Jef Law wrote: > > On 12/03/13 06:27, Bernd Edlinger wrote: >>> This comment is completely out of sync: There is no longer any force_reg in >>> that if-block, >>> and a constant address in TO_RTX has SImode or DImode in GET_MODE (XEXP >>> (to_rtx, 0)) >>> I do not kno

[PATCH] Fix --with-long-double-128 for sparc32 when defaulting to 64-bit

2013-12-03 Thread Aurelien Jarno
On sparc, the --with-long-double-128 option doesn't change anything for a 64-bit compiler, as it always default to 128-bit long doubles. For a 32/64-bit compiler defaulting to 32-bit this correctly control the size of long double of the 32-bit compiler, however for a 32/64-bit compiler defaulting t

Re: *ping* Re: PR37132 – RFC patch for generation of DWARF symbol for Fortran's namelists (DW_TAG_namelist)

2013-12-03 Thread Tobias Burnus
On November 28, 2013, Tobias Burnus wrote: A slightly early *ping* Tobias Burnus wrote: attached is an updated version of the patch. Change: Tobias Burnus wrote: But for "USE mod_name, only: nml", one is supposed to generate a DW_TAG_imported_declaration. And there I am stuck. For normal va

Re: Two build != host fixes

2013-12-03 Thread Alan Modra
On Tue, Dec 03, 2013 at 11:44:46PM -0500, DJ Delorie wrote: > Alan Modra writes: > > Bootstrapped etc. powerpc64-linux. OK mainline and 4.8 branch? > > > > * configure.ac (BUILD_CXXFLAGS) Don't use ALL_CXXFLAGS for > > build != host. > > : Clear GMPINC. Don't bother > > saving CF

Re: [PE-POST] Adjust Bit-region in expand_assignment

2013-12-03 Thread Jeff Law
On 12/03/13 06:27, Bernd Edlinger wrote: This comment is completely out of sync: There is no longer any force_reg in that if-block, and a constant address in TO_RTX has SImode or DImode in GET_MODE (XEXP (to_rtx, 0)) I do not know how to make it a VOIDmode, therefore the comment does not help

Re: libsanitizer merge from upstream r196090

2013-12-03 Thread Konstantin Serebryany
On Mon, Dec 2, 2013 at 11:32 PM, Jakub Jelinek wrote: > On Mon, Dec 02, 2013 at 05:59:53PM +0100, Konstantin Serebryany wrote: >> >> with #if LINUX_VERSION_CODE >= 132640 >> Good idea, let me try that. > > Had a quick look at this on RHEL 5. > Following patch let me compile at least the first sour

Re: libsanitizer merge from upstream r196090

2013-12-03 Thread Konstantin Serebryany
On Tue, Dec 3, 2013 at 5:42 PM, Jeff Law wrote: > On 12/03/13 08:47, Jakub Jelinek wrote: >> >> On Tue, Dec 03, 2013 at 07:18:14PM +0400, Konstantin Serebryany wrote: >> >> No, so your patch doesn't regress anything. I can configure with >> --disable-libsanitizer to skip build of libsa

Re: libsanitizer merge from upstream r196090

2013-12-03 Thread Konstantin Serebryany
>>> >>> This won't happen any time soon, right? >>> I'd like to ask glibc for many other things, not just this, but the >>> latency >>> of the glibc changes propagating to users is too low, so we don't >>> bother (although we should) >>> E.g. we've been hit by the ugly >>> pthread_getattr_np/pthrea

Re: [PATCH] Fix force_to_mode not to modify in place the passed rtl (PR rtl-optimization/58726)

2013-12-03 Thread Jeff Law
On 12/03/13 15:46, Jakub Jelinek wrote: Hi! As described in the PR, the problem here is that during combine i2 pattern is substituted into more than one place in i3 pattern, unique_copy is 0 (but, even if it would be non-zero, it could happen if the comparison was processed first before the norm

Re: Two build != host fixes

2013-12-03 Thread DJ Delorie
Alan Modra writes: > Bootstrapped etc. powerpc64-linux. OK mainline and 4.8 branch? > > * configure.ac (BUILD_CXXFLAGS) Don't use ALL_CXXFLAGS for > build != host. > : Clear GMPINC. Don't bother > saving CFLAGS. > * configure: Regenerate. Ok for mainline, up to the

Re: [PATCH] Add signed integer overflow checking to ubsan

2013-12-03 Thread Jeff Law
On 12/03/13 15:05, Jakub Jelinek wrote: On Tue, Dec 03, 2013 at 02:14:17PM -0700, Jeff Law wrote: --- gcc/ubsan.h.mp 2013-11-27 08:46:28.046629473 +0100 +++ gcc/ubsan.h 2013-11-27 08:46:57.578753342 +0100 @@ -21,6 +21,12 @@ along with GCC; see the file COPYING3. #ifndef GCC_UBSAN_H #def

Re: [PATCH] Don't ICE with -fno-devirtualize (PR tree-optimization/59355)

2013-12-03 Thread Jeff Law
On 12/03/13 15:36, Jakub Jelinek wrote: Hi! ipa_devirt apparently relies on -fdevirtualize, but -fno-devirtualize doesn't turn off -fdevirtualize-speculatively. I've tried to make it a 3 state option, but then while -O2 implied flag_devirtualize == 2 (i.e. normal + speculative), -O2 -fdevirtual

Re: [PATCH, testsuite] Fix some testcases for nds32 target and provide new nds32 target specific tests

2013-12-03 Thread Chung-Ju Wu
2013/12/3 Mike Stump : > On Dec 2, 2013, at 5:02 AM, Chung-Ju Wu wrote: >> Perhaps I should have used the following description, which seems much >> better: >> >> +/* { dg-skip-if "Variadic funcs have all args on stack. Normal funcs have >> args in registers." { nds32*-*-* } "*" "" } */ > > Read

Re: [PowerPC] libffi fixes and support for PowerPC64 ELFv2

2013-12-03 Thread David Edelsohn
> I haven't tested on AIX or Darwin, sorry If you find any problems on > AIX, please let me know and I'll fix them. I have tested on > powerpc-linux, powerpc64-linux, powerpc64le-linux and powerpc-freebsd, > which are the targets most affected by this change. I have also > bootstrapped and regre

libgo patch committed: Use pthread_sigmask, not sigprocmask

2013-12-03 Thread Ian Lance Taylor
A threaded program is supposed to call pthread_sigmask rather than sigprocmask. The functions do the same thing, and there is no difference on GNU/Linux, but pthread_sigmask is preferred. This patch to libgo changes it to do that. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. C

Two build != host fixes

2013-12-03 Thread Alan Modra
When build != host, the build compiler obviously isn't the same as the host compiler, but BUILD_CXXFLAGS is currently ALL_CXXFLAGS. ALL_CXXFLAGS contains flags for which we run configure tests on the host compiler, which may not work on the build compiler. I ran into this with -Wno-narrowing. It

Re: [PowerPC] libffi fixes and support for PowerPC64 ELFv2

2013-12-03 Thread Alan Modra
On Tue, Dec 03, 2013 at 09:05:53AM -0500, David Edelsohn wrote: > On Thu, Nov 21, 2013 at 9:57 PM, Alan Modra wrote: > > David, > > Here comes the inevitable followup.. I broke backwards compatibility > > when adding an extra field to ffi_cif. I'd like to import again from > > upstream, where I'

Re: [wide-int] Add fast path for hosts with HWI widening multiplication

2013-12-03 Thread Ian Lance Taylor
On Tue, Dec 3, 2013 at 3:55 PM, Richard Sandiford wrote: > > OK, how about this, against trunk? Tested on x86_64-linux-gnu. > > Thanks, > Richard > > > include/ > * longlong.h: New file. > > libgcc/ > * longlong.h: Delete (moved to include/). > > libquadmath/ > * Makefile.

Re: Add TREE_INT_CST_OFFSET_NUNITS

2013-12-03 Thread Richard Sandiford
Richard Biener writes: >>> Looking at the implementation it seems it would also work with >>> >>>return MIN (TREE_INT_CST_EXT_NUNITS (m_t), N / HOST_BITS_PER_WIDE_INT); >> >> Yeah, the MIN in the patch was probably bogus sorry. It only works >> if we can assume that no bitsizetype will have A

Re: [wide-int] Add fast path for hosts with HWI widening multiplication

2013-12-03 Thread Richard Sandiford
Paolo Bonzini writes: > Il 02/12/2013 20:34, Richard Sandiford ha scritto: >> I followed Joseph's suggestion and reused longlong.h. I copied it from >> libgcc rather than glibc since it seemed better for GCC to have a single >> version across both gcc/ and libgcc/. I can put it in

Re: [wwwdocs] Update obvious fix commit policy

2013-12-03 Thread Gerald Pfeifer
On Thu, 28 Nov 2013, Richard Biener wrote: > Why remove ChangeLog files, web pages and comments? I was going to complain about web pages being removed. :-) On Thu, 28 Nov 2013, Diego Novillo wrote: > -Fixes for obvious typos in ChangeLog files, docs, web pages, comments > -and similar stuff. Ju

Re: Fix a bug in points-to solver

2013-12-03 Thread Xinliang David Li
Done. Retested with the suggested change. Ok for trunk? thanks, David On Tue, Dec 3, 2013 at 2:13 AM, Richard Biener wrote: > On Mon, Dec 2, 2013 at 6:38 PM, Xinliang David Li wrote: >> Points to solver has a bug that can cause complex constraints to be >> skipped leading to wrong points-to r

[PATCH] Fix force_to_mode not to modify in place the passed rtl (PR rtl-optimization/58726)

2013-12-03 Thread Jakub Jelinek
Hi! As described in the PR, the problem here is that during combine i2 pattern is substituted into more than one place in i3 pattern, unique_copy is 0 (but, even if it would be non-zero, it could happen if the comparison was processed first before the normal set inside of the parallel) and thus th

[C++ PATCH] Don't ICE on POINTER_PLUS_EXPR during tsubst* (PR c++/59268)

2013-12-03 Thread Jakub Jelinek
Hi! The following testcase ICEs because dfs_accumulate_vtbl_inits creates a POINTER_PLUS_EXPR (not type dependent) which is then fed through tsubst_copy_and_build during instantiation. The following patch teaches tsubst_copy_and_build to handle it. Bootstrapped/regtested on x86_64-linux and i686

[PATCH] Don't ICE with -fno-devirtualize (PR tree-optimization/59355)

2013-12-03 Thread Jakub Jelinek
Hi! ipa_devirt apparently relies on -fdevirtualize, but -fno-devirtualize doesn't turn off -fdevirtualize-speculatively. I've tried to make it a 3 state option, but then while -O2 implied flag_devirtualize == 2 (i.e. normal + speculative), -O2 -fdevirtualize would imply flag_devirtualize == 1, wh

[PATCH] Enhancing the widen-mult pattern in vectorization.

2013-12-03 Thread Cong Hou
Hi The current widen-mult pattern only considers two operands with the same size. However, operands with different sizes can also benefit from this pattern. The following loop shows such an example: char a[N]; short b[N]; int c[N]; for (int i = 0; i < N; ++i) c[i] = a[i] * b[i]; In this cas

Re: [PING] [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-12-03 Thread Bill Schmidt
On Tue, 2013-12-03 at 21:57 +, Yufeng Zhang wrote: > On 12/03/13 20:35, Richard Biener wrote: > > Yufeng Zhang wrote: > >> On 12/03/13 14:20, Richard Biener wrote: > >>> On Tue, Dec 3, 2013 at 1:50 PM, Yufeng Zhang > >> wrote: > On 12/03/13 06:48, Jeff Law wrote: > > > > On 12/02/

Re: _Cilk_spawn and _Cilk_sync for C++

2013-12-03 Thread Jason Merrill
On 12/03/2013 10:22 AM, Iyer, Balaji V wrote: Please remove these langhooks and instead add handling of CILK_SPAWN_STMT to c_gimplify_expr and cp_gimplify_expr. I really cannot do this because if the spawned function returns a value, the whole expression must be pushed into the spawn

Re: [PATCH] Add signed integer overflow checking to ubsan

2013-12-03 Thread Jakub Jelinek
On Tue, Dec 03, 2013 at 02:14:17PM -0700, Jeff Law wrote: > >--- gcc/ubsan.h.mp 2013-11-27 08:46:28.046629473 +0100 > >+++ gcc/ubsan.h 2013-11-27 08:46:57.578753342 +0100 > >@@ -21,6 +21,12 @@ along with GCC; see the file COPYING3. > > #ifndef GCC_UBSAN_H > > #define GCC_UBSAN_H > > > >+/*

Re: [PING] [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-12-03 Thread Bill Schmidt
On Tue, 2013-12-03 at 21:35 +0100, Richard Biener wrote: > Yufeng Zhang wrote: > >On 12/03/13 14:20, Richard Biener wrote: > >> On Tue, Dec 3, 2013 at 1:50 PM, Yufeng Zhang > >wrote: > >>> On 12/03/13 06:48, Jeff Law wrote: > > On 12/02/13 08:47, Yufeng Zhang wrote: > > > > Ping

Re: [PING] [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-12-03 Thread Yufeng Zhang
On 12/03/13 20:35, Richard Biener wrote: Yufeng Zhang wrote: On 12/03/13 14:20, Richard Biener wrote: On Tue, Dec 3, 2013 at 1:50 PM, Yufeng Zhang wrote: On 12/03/13 06:48, Jeff Law wrote: On 12/02/13 08:47, Yufeng Zhang wrote: Ping~ http://gcc.gnu.org/ml/gcc-patches/2013-11/msg03360.ht

Re: libsanitizer merge from upstream r196090

2013-12-03 Thread Jakub Jelinek
On Tue, Dec 03, 2013 at 07:18:14PM +0400, Konstantin Serebryany wrote: > > ==2738==AddressSanitizer CHECK failed: > > ../../../../libsanitizer/sanitizer_common/sanitizer_linux_libcdep.cc:260 > > "((*tls_addr + *tls_size)) <= ((*stk_addr + *stk_size))" (0x2af8df1bc240, > > 0x2af8df1bc000) > > whic

[PATCH/AARCH64 6/6] Support ILP32 multi-lib

2013-12-03 Thread Andrew Pinski
Hi, This is the final patch which adds support for the dynamic linker and multi-lib directories for ILP32. I did not change multi-arch support as I did not know what it should be changed to and internally here at Cavium, we don't use multi-arch. OK? Build and tested for aarch64-linux-gnu with

[PATCH/AARCH64 5/6] Fix TLS for ILP32.

2013-12-03 Thread Andrew Pinski
Hi, With ILP32, some simple usage of TLS variables causes an unrecognizable instruction due to needing to use SImode for loading pointers from memory. This fixes the three (tlsie_small, tlsle_small, tlsdesc_small) patterns to support SImode for pointers. OK? Build and tested on aarch64-elf with

[PATCH/AARCH64 1/6] Fix size and pointer different types for ILP32.

2013-12-03 Thread Andrew Pinski
While compiling some programs, GCC and glibc (and newlib)'s definitions of size_t were not agreeing and causing format warnings to happen. The simple testcase for this is: #include #include int main(void) { ssize_t t = 0x1; printf("%zd\n", t); return 0; } - CUT - OK? Built an

[PATCH/AARCH64 4/6] Implement the trap pattern

2013-12-03 Thread Andrew Pinski
As mentioned in http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02228.html, this implements the trap pattern according to what was decided which brk should be used. OK? Built and tested on aarch64-elf with no regressions. Also built a glibc for aarch64-linux-gnu with this patch included (LP64).

[PATCH/AARCH64 0/6] Add ILP32 GNU/Linux support

2013-12-03 Thread Andrew Pinski
This patch set adds ILP32 support to GCC for GNU/Linux. A patch to size and pointer difference types for ILP32. A middle-end to fix an ICE with __builtin_thread_pointer with ILP32. A patch which fixes multi-lib list as the arguments to --with-multilib-list are exclusive. A patch which adds th

[PATCH/middle-end 2/6] __builtin_thread_pointer and AARCH64 ILP32

2013-12-03 Thread Andrew Pinski
Hi, With ILP32 AARCH64, Pmode (DImode) != ptrmode (SImode) so the variable decl has a mode of SImode while the register is DImode. So the target that gets passed down to expand_builtin_thread_pointer is NULL as expand does not know how to get a subreg for a pointer type. This fixes the problem

[PATCH/AARCH64 3/6] Fix up multi-lib options

2013-12-03 Thread Andrew Pinski
Hi, The arguments to --with-multilib-list for AARCH64 are exclusive but currently is being treated as ones which are not. This causes problems in that we get four library sets with --with-multilib-list=lp64,ilp32: empty, lp64, ilp32, lp64/ilp32. The first and last one does not make sense an

Re: [PATCH] Add signed integer overflow checking to ubsan

2013-12-03 Thread Jeff Law
On 11/27/13 01:13, Marek Polacek wrote: On Fri, Nov 22, 2013 at 10:54:16AM +0100, Marek Polacek wrote: Hi! Working virtually out of Pago Pago. The following is the implementation of the signed integer overflow checking for the UndefinedBehaviorSanitizer. I wrote some of the generic bits; Jaku

RE: [REPOST] Invalid Code when reading from unaligned zero-sized array

2013-12-03 Thread Bernd Edlinger
On Tue, 3 Dec 2013 12:16:39, Jeff Law wrote: > > On 12/03/13 11:40, Bernd Edlinger wrote: >>> >> >> To me it does not feel like a hack at all, if the expansion needs to know in >> what >> context the result will be used, if it is in an LHS or in a RHS or if the >> address of >> the memory is need

Re: [PING] [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-12-03 Thread Richard Biener
Yufeng Zhang wrote: >On 12/03/13 14:20, Richard Biener wrote: >> On Tue, Dec 3, 2013 at 1:50 PM, Yufeng Zhang >wrote: >>> On 12/03/13 06:48, Jeff Law wrote: On 12/02/13 08:47, Yufeng Zhang wrote: > > Ping~ > > http://gcc.gnu.org/ml/gcc-patches/2013-11/msg03360.html

Re: [PATCH] SIMD clones LTO fixes part 1 (PR lto/59326)

2013-12-03 Thread Jeff Law
On 12/03/13 13:14, Jakub Jelinek wrote: On Tue, Dec 03, 2013 at 01:11:08PM -0700, Jeff Law wrote: On 11/28/13 15:58, Jakub Jelinek wrote: + for (i = 0; i < omp_clause_num_ops[OMP_CLAUSE_CODE (expr)]; i++) +stream_write_tree (ob, OMP_CLAUSE_OPERAND (expr, i), ref_p); + if (OMP_CLAUSE_COD

Re: [PATCH] SIMD clones LTO fixes part 1 (PR lto/59326)

2013-12-03 Thread Jakub Jelinek
On Tue, Dec 03, 2013 at 01:11:08PM -0700, Jeff Law wrote: > On 11/28/13 15:58, Jakub Jelinek wrote: > + for (i = 0; i < omp_clause_num_ops[OMP_CLAUSE_CODE (expr)]; i++) > >+stream_write_tree (ob, OMP_CLAUSE_OPERAND (expr, i), ref_p); > >+ if (OMP_CLAUSE_CODE (expr) == OMP_CLAUSE_REDUCTION) >

Re: [PATCH] Masked load/store vectorization (take 6)

2013-12-03 Thread Jeff Law
On 11/28/13 16:09, Jakub Jelinek wrote: On Wed, Nov 27, 2013 at 04:10:16PM +0100, Richard Biener wrote: As you pinged this ... can you re-post a patch with changelog that includes the followups as we decided? Ok, here is the updated patch against latest trunk with the follow-ups incorporated.

Re: [PATCH] Allow compounds with empty initializer in pedantic mode (PR c/59351)

2013-12-03 Thread Marek Polacek
On Tue, Dec 03, 2013 at 01:03:43PM -0700, Jeff Law wrote: > On 12/02/13 13:10, Marek Polacek wrote: > >We triggered an assert on attached testcase, because when building the > >compound literal with empty initial value complete_array_type returns > >3, but we assert it returns 0. It returns 3 only

Re: [PATCH] SIMD clones LTO fixes part 2 (PR lto/59326)

2013-12-03 Thread Jeff Law
On 11/28/13 16:00, Jakub Jelinek wrote: Hi! And here is second part of the fixes. Still, the vect-simd-clone-12.c testcase fails with -flto -flto-partition=1to1, so there is further work to do, but at least all current test succeed and actually use SIMD elementals when they should. Bootstrappe

Re: [PATCH] SIMD clones LTO fixes part 1 (PR lto/59326)

2013-12-03 Thread Jeff Law
On 11/28/13 15:58, Jakub Jelinek wrote: + for (i = 0; i < omp_clause_num_ops[OMP_CLAUSE_CODE (expr)]; i++) +stream_write_tree (ob, OMP_CLAUSE_OPERAND (expr, i), ref_p); + if (OMP_CLAUSE_CODE (expr) == OMP_CLAUSE_REDUCTION) +{ + /* We don't stream these right now, handle it if stre

Re: [PATCH] Allow compounds with empty initializer in pedantic mode (PR c/59351)

2013-12-03 Thread Jeff Law
On 12/02/13 13:10, Marek Polacek wrote: We triggered an assert on attached testcase, because when building the compound literal with empty initial value complete_array_type returns 3, but we assert it returns 0. It returns 3 only in the pedantic mode, where empty initializer braces are forbidden

Re: [RFC][LIBGCC][2 of 2] 64 bit divide implementation for processor without hw divide instruction

2013-12-03 Thread Jeff Law
On 12/02/13 23:39, Kugan wrote: +2013-11-27 Kugan Vivekanandarajah + + * config/arm/bpapi-lib.h (TARGET_HAS_NO_HW_DIVIDE): Define for + architectures that does not have hardware divide instruction. + i.e. architectures that does not define __ARM_ARCH_EXT_IDIV__. + Is this

Re: [PATCH] Add reference binding instrumentation

2013-12-03 Thread Marek Polacek
On Tue, Nov 19, 2013 at 10:07:00AM -0500, Jason Merrill wrote: > On 11/18/2013 11:39 AM, Marek Polacek wrote: > >+init = fold_build2 (COMPOUND_EXPR, TREE_TYPE (init), > >+ubsan_instrument_reference (input_location, init), > >+init); > > This look

Re: [PATCH] _Cilk_for for C and C++

2013-12-03 Thread Jeff Law
On 12/03/13 06:25, Iyer, Balaji V wrote: I understand you both now. Let me look into the OMP routines and see what it is doing and see how I can port it to _Cilk_for. Thanks. I know it's a bit of a pain, but part what's driving the desire to share is to reduce the long term maintenance cost

Re: [PATCH] Use DW_LANG_D for D

2013-12-03 Thread Cary Coutant
> This patches gen_compile_unit_die to use the DW_LANG_D DWARF language > code for D. Is in relation to some other D language fixes that are > going to be submitted to gdb. Is this for a private front end? I'm not aware of any front ends that set the language name to "GNU D". Since it's so trivi

Re: [PATCH, PR 58253] Make IPA-SRA created PARM_DECLs always naturally aligned

2013-12-03 Thread Jeff Law
On 12/03/13 09:53, Martin Jambor wrote: Hi, the patch below fixes a failure on the epiphany target where callers and callees do not agree on registers for parameter passing because they see different alignment of actual arguments and formal parameters (there is some more information on this in b

Re: [patch] combine ICE fix

2013-12-03 Thread Jeff Law
On 12/03/13 12:25, Kenneth Zadeck wrote: On 12/03/2013 01:52 PM, Mike Stump wrote: On Dec 2, 2013, at 10:26 PM, Jeff Law wrote: On 11/27/13 17:13, Cesar Philippidis wrote: I looked into adding support for incremental DF scanning from df*.[ch] in combine but there are a couple of problems. Fir

Re: [patch] combine ICE fix

2013-12-03 Thread Kenneth Zadeck
On 12/03/2013 01:52 PM, Mike Stump wrote: On Dec 2, 2013, at 10:26 PM, Jeff Law wrote: On 11/27/13 17:13, Cesar Philippidis wrote: I looked into adding support for incremental DF scanning from df*.[ch] in combine but there are a couple of problems. First of all, combine does its own DF analysi

Re: [PATCH, ia64] [PR target/52731] internal compiler error: in ia64_st_address_bypass_p, at config/ia64/ia64.c:9357

2013-12-03 Thread Steve Ellcey
On Fri, 2013-11-29 at 15:01 +0300, Kirill Yukhin wrote: > Hello, > On 20 Nov 18:37, Kirill Yukhin wrote: > > Hello, > > Patch in the bottom fixes PR52731. > > Is it ok for trunk? > Ping? > > -- > Thanks, K OK. Steve Ellcey sell...@mips.com

Re: [PING] [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-12-03 Thread Jeff Law
On 12/03/13 08:52, Yufeng Zhang wrote: I still don't like it. It's using the wrong and too expensive tools to do stuff. What kind of bases are we ultimately interested in? Browsing the code it looks like we're having /* Base expression for the chain of candidates: often, but not al

Re: [REPOST] Invalid Code when reading from unaligned zero-sized array

2013-12-03 Thread Jeff Law
On 12/03/13 11:40, Bernd Edlinger wrote: To me it does not feel like a hack at all, if the expansion needs to know in what context the result will be used, if it is in an LHS or in a RHS or if the address of the memory is needed. Expansion needs some context and it's currently passed into ex

Re: [patch] combine ICE fix

2013-12-03 Thread Mike Stump
On Dec 2, 2013, at 10:26 PM, Jeff Law wrote: > On 11/27/13 17:13, Cesar Philippidis wrote: >> >> I looked into adding support for incremental DF scanning from df*.[ch] >> in combine but there are a couple of problems. First of all, combine >> does its own DF analysis. It does so because its usage

Re: [GOMP4] SIMD enabled function for C/C++

2013-12-03 Thread Aldy Hernandez
On 11/30/13 10:15, Iyer, Balaji V wrote: Hello Jakub, I was looking at my elemental function for C patch that I fixed up and send as requested by Aldy, and I saw two changes there that were used for C and C++ and they were pretty obvious. Here are the changes. Can I just commit them?

RE: [REPOST] Invalid Code when reading from unaligned zero-sized array

2013-12-03 Thread Bernd Edlinger
On Tue, 3 Dec 2013 16:14:49, Eric Botcazou wrote: > >> The patch does add a boolean "expand_reference" parameter to >> expand_expr_real and expand_expr_real_1. I pass true when I intend to use >> the returned memory context as an array reference, instead of a value. At >> places where mis-aligned v

Re: [wide-int] small cleanup in wide-int.*

2013-12-03 Thread Mike Stump
On Dec 3, 2013, at 8:52 AM, Richard Sandiford wrote: > You probably already realise this, but for avoidance of doubt, Richard > was also asking that we reduce MAX_BITSIZE_MODE_ANY_INT to 128 on x86_64, > since that's the largest scalar_mode_supported_p mode. Personally, I'd love to see scalar_mo

[PATCH, rs6000] Committed fix for HTM macro name typos

2013-12-03 Thread Peter Bergner
Adhemerval noticed that the _TEXASR_INSTRUCTION_FETCH_CONFLICT and _TEXASRU_INSTRUCTION_FETCH_CONFLICT HTM macros were misspelled. I committed the following patch as obvious to fix them. Peter * config/rs6000/htmintrin.h (_TEXASR_INSTRUCTION_FETCH_CONFLICT): Fix typo in macro name

[PATCH] Fix missing plugin headers

2013-12-03 Thread David Malcolm
I attempted to build gcc-python-plugin against gcc trunk (r205358 specifically). I ran into three kinds of issues: (A) tracking down where declarations have landed in the new layout (B) adding new headers to the list of those to be installed (C) some porting due to "real" changes e.g. passes

[PATCH, PR 58253] Make IPA-SRA created PARM_DECLs always naturally aligned

2013-12-03 Thread Martin Jambor
Hi, the patch below fixes a failure on the epiphany target where callers and callees do not agree on registers for parameter passing because they see different alignment of actual arguments and formal parameters (there is some more information on this in bugzilla). The actual arguments are SSA na

Re: [wide-int] small cleanup in wide-int.*

2013-12-03 Thread Richard Sandiford
Kenneth Zadeck writes: > Index: tree-vrp.c > === > --- tree-vrp.c(revision 205597) > +++ tree-vrp.c(working copy) > @@ -2611,22 +2611,28 @@ extract_range_from_binary_expr_1 (value_ > >signop sign = TYPE_SIGN

Re: libsanitizer merge from upstream r196090

2013-12-03 Thread Jeff Law
On 12/03/13 08:47, Jakub Jelinek wrote: On Tue, Dec 03, 2013 at 07:18:14PM +0400, Konstantin Serebryany wrote: No, so your patch doesn't regress anything. I can configure with --disable-libsanitizer to skip build of libsanitizer, although it would be nice to support RHEL5 derived long-term distr

[PING][PATCH][ARM]Use of vcvt for float to fixed point conversions.

2013-12-03 Thread Renlin Li
Hi Ramana/Richard, Could you please help to review this patch? Thanks in advance! Kind regards, Renlin Li On 20/11/13 16:27, Renlin Li wrote: Hi all, This patch will make the arm back-end use vcvt for float to fixed point conversions when applicable. Test on arm-none-linux-gnueabi has bee

Re: [wide-int] small cleanup in wide-int.*

2013-12-03 Thread Kenneth Zadeck
On 11/29/2013 05:24 AM, Richard Biener wrote: On Thu, Nov 28, 2013 at 6:11 PM, Kenneth Zadeck wrote: This patch does three things in wide-int: 1) it cleans up some comments. 2) removes a small amount of trash. 3) it changes the max size of the wide int from being 4x of MAX_BITSIZE_MODE_ANY_INT

Re: [PING] [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-12-03 Thread Yufeng Zhang
On 12/03/13 14:20, Richard Biener wrote: On Tue, Dec 3, 2013 at 1:50 PM, Yufeng Zhang wrote: On 12/03/13 06:48, Jeff Law wrote: On 12/02/13 08:47, Yufeng Zhang wrote: Ping~ http://gcc.gnu.org/ml/gcc-patches/2013-11/msg03360.html Thanks, Yufeng On 11/26/13 15:02, Yufeng Zhang wrote:

Re: libsanitizer merge from upstream r196090

2013-12-03 Thread Jakub Jelinek
On Tue, Dec 03, 2013 at 07:18:14PM +0400, Konstantin Serebryany wrote: > >> > No, so your patch doesn't regress anything. I can configure with > >> > --disable-libsanitizer to skip build of libsanitizer, although it > >> > would be nice to support RHEL5 derived long-term distributions. > >> Ok, so

Re: patch for elimination to SP when it is changed in RTL (PR57293)

2013-12-03 Thread Vladimir Makarov
On 12/3/2013, 6:54 AM, Marcus Shawcroft wrote: On 2 December 2013 23:44, Vladimir Makarov wrote: If somebody with the rights approves, I can commit it tomorrow. 2013-12-02 Vladimir Makarov * config/aarch64/aarch64.c (aarch64_frame_pointer_required): Check LR_REGNUM.

RE: _Cilk_spawn and _Cilk_sync for C++

2013-12-03 Thread Iyer, Balaji V
> > > case CILK_SPAWN_STMT: > > gcc_assert > > (fn_contains_cilk_spawn_p (cfun) > > && lang_hooks.cilkplus.cilk_detect_spawn_and_unwrap (expr_p)); > > if (!seen_error ()) > > { > > ret = (enum gimplify_status) > >

Re: libsanitizer merge from upstream r196090

2013-12-03 Thread Konstantin Serebryany
On Tue, Dec 3, 2013 at 3:50 PM, Jakub Jelinek wrote: > On Mon, Dec 02, 2013 at 05:43:17PM +0100, Konstantin Serebryany wrote: >> > No, so your patch doesn't regress anything. I can configure with >> > --disable-libsanitizer to skip build of libsanitizer, although it >> > would be nice to support R

Re: [REPOST] Invalid Code when reading from unaligned zero-sized array

2013-12-03 Thread Eric Botcazou
> The patch does add a boolean "expand_reference" parameter to > expand_expr_real and expand_expr_real_1. I pass true when I intend to use > the returned memory context as an array reference, instead of a value. At > places where mis-aligned values are extracted, I do not return a register > with t

Re: [wide-int] Drop some lingering uses of precision 0

2013-12-03 Thread Kenneth Zadeck
if i did not already say so, this is fine. kenny On 12/02/2013 03:20 PM, Richard Sandiford wrote: I noticed that there were still a couple of tests for zero precision. This patch replaces them with asserts when handling separately-supplied precisions and simply drops them when handling existing

Re: [PATCH] Provide a prototype for runtime_traceback

2013-12-03 Thread Ian Lance Taylor
On Tue, Dec 3, 2013 at 1:32 AM, Richard Biener wrote: > On Tue, 3 Dec 2013, Richard Biener wrote: > >> >> Hi, I'm getting a bootstrap fail with Go with our custom patched >> compiler (it adds that warning): >> >> 09:48 < richi> ../../../libgo/runtime/go-signal.c: In function >>'run

Re: [RFC][LIBGCC][2 of 2] 64 bit divide implementation for processor without hw divide instruction

2013-12-03 Thread Ian Lance Taylor
On Mon, Dec 2, 2013 at 10:39 PM, Kugan wrote: > ping This patch needs to be approved by an ARM maintainer. Ian > On 27/11/13 15:30, Kugan wrote: >> On 27/11/13 02:07, Richard Earnshaw wrote: >>> On 23/11/13 01:54, Kugan wrote: >> >> [snip] >> +2013-11-22 Kugan Vivekanandarajah + >>

Re: [PING] [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-12-03 Thread Richard Biener
On Tue, Dec 3, 2013 at 1:50 PM, Yufeng Zhang wrote: > On 12/03/13 06:48, Jeff Law wrote: >> >> On 12/02/13 08:47, Yufeng Zhang wrote: >>> >>> Ping~ >>> >>> http://gcc.gnu.org/ml/gcc-patches/2013-11/msg03360.html >> >> >>> >>> Thanks, >>> Yufeng >>> >>> On 11/26/13 15:02, Yufeng Zhang wrote: >

RE: [PATCH] Strict volatile bit-fields clean-up, Take 2

2013-12-03 Thread Bernd Edlinger
On Tue, 3 Dec 2013 12:23:11, Richard Biener wrote: > > On Tue, Dec 3, 2013 at 12:01 PM, Bernd Edlinger > wrote: >> Hi, >> >> This is my proposal for ulimately getting rid of the nasty >> store_fixed_bit_field recursion. >> >> IMHO, the root of the recursion trouble is here: >> >> @@ -1007,12 +101

Re: [REPOST] Invalid Code when reading from unaligned zero-sized array

2013-12-03 Thread Richard Biener
On Tue, Dec 3, 2013 at 2:10 PM, Richard Biener wrote: > On Tue, Dec 3, 2013 at 1:48 PM, Bernd Edlinger > wrote: >> Hi Jeff, >> >> please find attached the patch (incl. test cases) for the unaligned read BUG >> that I found while investigating >> on PR#57748: http://gcc.gnu.org/bugzilla/show_bug.

Re: [PATCH] _Cilk_for for C and C++

2013-12-03 Thread Jakub Jelinek
On Tue, Dec 03, 2013 at 02:01:17PM +, Iyer, Balaji V wrote: > In Cilk_for you don't need to privatize any variables. I need to pass in > the loop_count, the grain (if the user specifies one), the nested function > and its context to a Cilk specific function:__cilkrts_cilk_for_64 (or 32). > The

Re: [PowerPC] libffi fixes and support for PowerPC64 ELFv2

2013-12-03 Thread David Edelsohn
On Thu, Nov 21, 2013 at 9:57 PM, Alan Modra wrote: > David, > Here comes the inevitable followup.. I broke backwards compatibility > when adding an extra field to ffi_cif. I'd like to import again from > upstream, where I've already fixed the problem. > > https://sourceware.org/ml/libffi-discuss

RE: [REPOST] Invalid Code when reading from unaligned zero-sized array

2013-12-03 Thread Bernd Edlinger
> Date: Tue, 3 Dec 2013 14:51:21 +0100 > Subject: Re: [REPOST] Invalid Code when reading from unaligned zero-sized > array > From: richard.guent...@gmail.com > To: bernd.edlin...@hotmail.de > CC: l...@redhat.com; gcc-patches@gcc.gnu.org; ja...@redhat.com >

Re: [Ping, avr] Emit diagnostics if -f{pic,PIC,pie,PIE} or -shared is passed

2013-12-03 Thread Denis Chertykov
2013/11/18 Senthil Kumar Selvaraj : > Ping! > > Regards > Senthil > > On Mon, Nov 04, 2013 at 06:45:19PM +0530, Senthil Kumar Selvaraj wrote: >> The AVR backend does not generate position independent code, yet it >> happily accepts -fpic, -fPIC, -fpie and -fPIE. The generated code >> doesn't change

RE: [PATCH] _Cilk_for for C and C++

2013-12-03 Thread Iyer, Balaji V
> -Original Message- > From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: Tuesday, December 3, 2013 8:40 AM > To: Iyer, Balaji V > Cc: Jeff Law; Jason Merrill; Aldy Hernandez; gcc-patches@gcc.gnu.org; > r...@redhat.com > Subject: Re: [PATCH] _Cilk_for for C and C++ > > On Tue, Dec 03,

Re: wide-int, avr

2013-12-03 Thread Denis Chertykov
2013/11/23 Mike Stump : > Richi has asked the we break the wide-int patch so that the individual port > and front end maintainers can review their parts without have to go through > the entire patch.This patch covers the avr port. > > Ok? > Ok. Excuse my long delay. I was on vacation. Pleas

Re: [REPOST] Invalid Code when reading from unaligned zero-sized array

2013-12-03 Thread Richard Biener
On Tue, Dec 3, 2013 at 2:10 PM, Richard Biener wrote: > On Tue, Dec 3, 2013 at 1:48 PM, Bernd Edlinger > wrote: >> Hi Jeff, >> >> please find attached the patch (incl. test cases) for the unaligned read BUG >> that I found while investigating >> on PR#57748: http://gcc.gnu.org/bugzilla/show_bug.

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-12-03 Thread Michael V. Zolotukhin
Hi Bernd, I am working on offloading support for OpenMP4, so I'll try to share my vision of how everything works and answer your questions. GCC compiles host version of the code (as usual) and dumps Gimple, as it does for LTO, but for offloading. Gimple IR is stored only for functions/variables

Re: [PATCH][ARM] Implement CRC32 intrinsics for AArch32 in ARMv8-A

2013-12-03 Thread Kyrill Tkachov
Ping? http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02351.html Thanks, Kyrill On 26/11/13 09:44, Kyrill Tkachov wrote: Ping? Thanks, Kyrill On 19/11/13 17:04, Kyrill Tkachov wrote: On 19/11/13 16:26, Joseph S. Myers wrote: In any target header installed for user use, such as arm_acle.h, you

Re: [PATCH] _Cilk_for for C and C++

2013-12-03 Thread Jakub Jelinek
On Tue, Dec 03, 2013 at 01:25:57PM +, Iyer, Balaji V wrote: > > >> As you can tell, this is not how openmp handles a #pragma omp for loop. > > > > > > It's different in detail, but #pragma omp parallel for works very > > > similarly: it creates a separate function for the body of the loop and >

Re: [PATCH] Don't create out-of-bounds BIT_FIELD_REFs

2013-12-03 Thread Tom de Vries
On 03-12-13 13:49, Jakub Jelinek wrote: On Thu, Nov 28, 2013 at 12:23:43AM +0100, Tom de Vries wrote: Committed to trunk. Also ok for 4.8 branch? It's a 4.8/4.9 regression. Ok, but I guess you need to adjust your patch for 4.8 (tree_to_* and tree_fits_* to host_integerp/tree_low_cst), so plea

[PE-POST] Adjust Bit-region in expand_assignment

2013-12-03 Thread Bernd Edlinger
Hi, I almost forgot about this (rather simple) one. It falls in the category "Mostly Harmless", but it would be nice to have the bitregion_start/end consistent in all cases, even when it does currently not cause any mal-function. this was: > Subject: RE: [PATCH, PR 57748] Check for out of bound

RE: [PATCH] _Cilk_for for C and C++

2013-12-03 Thread Iyer, Balaji V
> -Original Message- > From: Jeff Law [mailto:l...@redhat.com] > Sent: Tuesday, December 3, 2013 1:30 AM > To: Jason Merrill; Iyer, Balaji V; Aldy Hernandez > Cc: gcc-patches@gcc.gnu.org; r...@redhat.com; Jakub Jelinek > Subject: Re: [PATCH] _Cilk_for for C and C++ > > On 11/27/13 17:52,

Re: [REPOST] Invalid Code when reading from unaligned zero-sized array

2013-12-03 Thread Richard Biener
On Tue, Dec 3, 2013 at 1:48 PM, Bernd Edlinger wrote: > Hi Jeff, > > please find attached the patch (incl. test cases) for the unaligned read BUG > that I found while investigating > on PR#57748: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57748 > > one test case is this one: > > pr57748-3.c: > /

Re: Ping Re: [gomp4] Dumping gimple for offload.

2013-12-03 Thread Bernd Schmidt
On 11/29/2013 06:12 PM, Jakub Jelinek wrote: > On Fri, Nov 29, 2013 at 06:07:38PM +0100, Bernd Schmidt wrote: >> By what mechanism do you choose? This is unclear to me from what I've >> seen. Does this involve user action, and what's the advantage of doing >> it this way? > > See the 3 threads I'v

[v3 patch] fix formatting in doxygen comment

2013-12-03 Thread Jonathan Wakely
2013-12-03 Jonathan Wakely * include/std/fstream (basic_filebuf::open): Use preformatted text for table in Doxygen comment. Tested x86_64-linux. Committed to trunk. commit 8699304a9d3261d2b52636ee46c0203538de8fa1 Author: Jonathan Wakely Date: Tue Dec 3 12:40:46 2013 +

Re: PATCH: PR target/59363: [4.9 Regression] r203886 miscompiles git

2013-12-03 Thread H.J. Lu
On Tue, Dec 3, 2013 at 4:41 AM, Jan Hubicka wrote: >> Here is the updated patch. Tested on Linux/x86-64. It >> fixed git. OK to install? >> >> Thanks. >> >> -- >> H.J. >> --- >> gcc/ >> >> 2013-12-03 H.J. Lu >> >> PR target/59363 >> * config/i386/i386.c (emit_memset): Adjust destina

  1   2   >