[PATCH][ARM][thumb1] Reduce lr save for leaf function with non-far jump

Current GCC thumb1 has an annoying problem that always assuming far branch. So it forces to save lr, even when unnecessarily. The most extreme case complained by partner is: // compiled with "-mthumb -mcpu=cortex-m0 -Os". void foo() { for (;;); } => foo: push{lr} // Crazy!!! .L2:

Re: Follow-up to PR bootstrap/54820

On Wed, Dec 19, 2012 at 6:13 PM, Cary Coutant wrote: > Two test cases, debug_msg_so.err and debug_msg_ndebug.err, are still > broken by the original patch, because (a) debug_msg.so has a DT_NEEDED > entry for libstdc++.so, (b) the use of -static-libstdc++ means that > that DT_NEEDED entry is unkno

Re: [patch] fix multiarch definition for powerpcspe-linux-gnu

On Wed, Dec 19, 2012 at 11:47 AM, Matthias Klose wrote: > The definition of the multiarch tuple for powerpcspe-linux-gnu was wrong. The > t-spe fragment isn't included for the powerpc*-linux* case, so move it to > t-linux, and use tm_file_list (tm_file is only used in config.gcc). > > Ok for the t

Re: Follow-up to PR bootstrap/54820

Two test cases, debug_msg_so.err and debug_msg_ndebug.err, are still broken by the original patch, because (a) debug_msg.so has a DT_NEEDED entry for libstdc++.so, (b) the use of -static-libstdc++ means that that DT_NEEDED entry is unknown when we link the executable, and (c) the undefined symbols

Re: [google 4.7] fdo build for linux kernel (issue 6968046)

On Wed, Dec 19, 2012 at 5:04 PM, wrote: > The change in gcov-io.h is from a different patch. sorry. here is the patch for gcov-io.h: Index: gcov-io.h === --- gcov-io.h (revision 194562) +++ gcov-io.h (working copy) @@ -781,8 +7

Re: [PATCH] Fix PR gcov-profile/55734 for bootstrapping with older compilers (issue6980044)

On Wed, Dec 19, 2012 at 01:34:34PM -0800, Teresa Johnson wrote: > +#if IN_LIBGCOV > + /* When building libgcov we don't include system.h, which includes > + hwint.h (where floor_log2 is declared). However, libgcov.a > + is built by the bootstrapped compiler and therefore the bu

Re: [google 4.7] fdo build for linux kernel (issue 6968046)

The change in gcov-io.h is from a different patch. David https://codereview.appspot.com/6968046/diff/1/gcc/gcov-io.c File gcc/gcov-io.c (right): https://codereview.appspot.com/6968046/diff/1/gcc/gcov-io.c#newcode688 gcc/gcov-io.c:688: Have you compared this with this impl: while (x) { c++;

Re: [google 4.7] atomic update of profile counters (issue6965050)

On Wed, Dec 19, 2012 at 4:29 PM, Andrew Pinski wrote: > > On Wed, Dec 19, 2012 at 12:08 PM, Rong Xu wrote: > > Hi, > > > > This patch adds the supprot of atomic update the profile counters. > > Tested with google internal benchmarks and fdo kernel build. > > I think you should use the __atomic_ f

Re: [google 4.7] atomic update of profile counters (issue6965050)

On Wed, Dec 19, 2012 at 12:08 PM, Rong Xu wrote: > Hi, > > This patch adds the supprot of atomic update the profile counters. > Tested with google internal benchmarks and fdo kernel build. I think you should use the __atomic_ functions instead of __sync_ functions as they allow better performance

Re: Patch to enable unlimited polymorphism to gfortran

Dear All, Committed as revision 194622 and corrigendum 194626 (removes one test from unlimited_polymorphic_2.f03). Thanks to one and all for the help. Paul On 19 December 2012 07:17, Paul Richard Thomas wrote: > Thanks Tobias and Dominique, > > I'll make the corrections that you have request

Re: [google 4.7] atomic update of profile counters (issue6965050)

This looks good to me for google branches. Useful for trunk too. David On Wed, Dec 19, 2012 at 12:08 PM, Rong Xu wrote: > Hi, > > This patch adds the supprot of atomic update the profile counters. > Tested with google internal benchmarks and fdo kernel build. > > Thanks, > > -Rong > > 2012-12-19

Re: [Patch, Fortran] PR54818 - Fix ICE with TRANSFER to char

Dear Tobias, OK for trunk, apart from: s/the string length if of type gfc_charlen_type_node/the string length is of type gfc_charlen_type_node/ Thanks for the patch Paul On 20 December 2012 00:29, Tobias Burnus wrote: > TRANSFER(..., "string") created on x86-64 an integer(8) string length; tha

[Patch, Fortran] PR54818 - Fix ICE with TRANSFER to char

TRANSFER(..., "string") created on x86-64 an integer(8) string length; that lead to a tree-checking ICE but also might pass the wrong type in 'call sub(transfer(233," ")'. Build and regtested on x86-64-gnu-linux. OK for the trunk? Tobias 2012-12-20 Tobias Burnus PR fortran/54818 * trans-

[Patch, Fortran, committed] Fix -fno-automatic string length static regression

The check whether the string length should be static or not with -fno-automatic failed to take automatic arrays into account. There are three possibilities for string lengths: a) They can be constant b) They can be based on a nonconstant expression c) They can be deferred (b) is an automatic v

Re: PING^2: [PATCH] Support -fuse-ld=bfd and -fuse-ld=gold

On Wed, Dec 19, 2012 at 1:13 PM, Joseph S. Myers wrote: > On Thu, 13 Dec 2012, H.J. Lu wrote: > >> Hi Joseph, >> >> Can you review this? > > I'm still confused as to what's supposed to be reviewed and whether the > issues raised in the previous discussions have been properly addressed. > Looking a

C++ PATCH for c++/55724 (default template argument and non-type parameter)

My changes to handle incomplete packs ended up splitting the late loop in type_unification_real into two loops, one to check whether there are any non-type template parameters that still have a dependent type, and then another to apply default arguments. This breaks the testcase in 55724, whic

Re: [fortran, patch] Allow displaying backtraces from user code

On Wed, Dec 19, 2012 at 5:23 PM, Janus Weil wrote: >>> Attached is a new patch, which expands the documentation according to >>> your proposal, and uses the name BACKTRACE. I hope that both Janne and >>> Tobias can agree with this naming decision ... >> >> Looks fine from my side. > > Great, thank

[PATCH] Fix PR gcov-profile/55734 for bootstrapping with older compilers (issue6980044)

Fix PR gcov-profile/55734 by using methods from hwint.c instead of builtins, to handle non-GCC and older versions of GCC. When building libgcov.a, however, hwint.c is not available, but we are always using the bootstrapped compiler and can therefore use the builtins. Use __builtin_popcount instead

Re: PING^2: [PATCH] Support -fuse-ld=bfd and -fuse-ld=gold

On Thu, 13 Dec 2012, H.J. Lu wrote: > Hi Joseph, > > Can you review this? I'm still confused as to what's supposed to be reviewed and whether the issues raised in the previous discussions have been properly addressed. Looking at , I do

[google 4.7] fdo build for linux kernel (issue6968046)

Hi, This patch updates the support for FDO build in linux kernel for gcc 4.7. Tested with 2.6.34 kernel and google internal benchmarks. Thanks, -Rong 2012-12-19 Rong Xu * libgcc/libgcov.c (gcov_counter_active): v4.7 kernel fdo support. (crc32_unsigned): Include in GC

[google 4.7] atomic update of profile counters (issue6965050)

Hi, This patch adds the supprot of atomic update the profile counters. Tested with google internal benchmarks and fdo kernel build. Thanks, -Rong 2012-12-19 Rong Xu * gcc/common.opt: Add -fprofile-gen-atomic option. * gcc/gcov-io.h: Add profile atomic update support.

Re: [v3] docbook vs. texlive > 2007

> > This patch fixes the previously unknown issues so that the pdf docs > > for libstdc++ can be built on texlive-2007 and texlive-2013. > > This patch broke html generation for me. The new file containing the > bibliography didn't have an xmlns attribute on the root node, so the > element wasn'

Re: [PING] Bugfix: Additional parameter for canonicalize comparison

On Wed, 2012-12-19 15:04:02 +0100, Richard Biener wrote: > On Wed, Dec 19, 2012 at 12:34 PM, Richard Earnshaw wrote: > > On 19/12/12 09:53, Andreas Krebbel wrote: > >> > >> Hi, > >> > >> are the ARM parts of the patch below ok for mainline? > >> > > > > Yes. > > > > Sorry for the delay. > > I t

Re: [PATCH] PR c++/53609 - Wrong argument deduction for pack expansion in argument pack

How about the below? gcc/cp/ * pt.c (argument_pack_element_is_expansion_p) (make_argument_pack_select, use_pack_expansion_extra_args_p) (gen_elem_of_pack_expansion_instantiation): New static functions. (has_bare_parameter_packs): Factorized out of ...

Re: [doc] extend.texi copy-editing, 3/N (hyphenated phrases)

On 12/18/2012 10:42 PM, Gerald Pfeifer wrote: Hi Sandra, On Sat, 10 Nov 2012, Sandra Loosemore wrote: 2012-11-10 Sandra Loosemore gcc/ * doc/extend.texi: Copy-edit to fix incorrect hyphenation phrases involving "bit", "byte", "word", "precision", and "floating"

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

On Thu, 13 Dec 2012, Alexander Ivchenko wrote: > Could you please take a look at the attached patch that implements > the target libc_has_function hook? I didn't change so far the default presence > of c99, but rather tried to preserve the current behaviour of > TARGET_C99_FUNCTIONS. It looks lik

Re: [C PATCH] Don't perform function array conversions on inline asm "m" constrainted inputs (PR c++/55619)

On Wed, 12 Dec 2012, Jakub Jelinek wrote: > 2012-12-12 Jakub Jelinek > > PR c++/55619 > * c-parser.c (c_parser_asm_operands): Remove CONVERT_P > argument, don't call default_function_array_conversion > nor c_fully_fold here. > (c_parser_asm_statement): Adjust call

[patch] fix multiarch definition for powerpcspe-linux-gnu

The definition of the multiarch tuple for powerpcspe-linux-gnu was wrong. The t-spe fragment isn't included for the powerpc*-linux* case, so move it to t-linux, and use tm_file_list (tm_file is only used in config.gcc). Ok for the trunk? Matthias 2012-12-19 Roland Stigge Matthias Klose

[patch] Fix typo in multiarch definition for kfreebsd

Fixes a typo in the multiarch definition for kfreebsd. Committed as obvious. Matthias 2012-12-19 Matthias Klose * config/i386/t-kfreebsd (MULTIARCH_DIRNAME): Add comma to separate arguments in make function. Index: config/i386/t-kfreebsd

Re: [PATCH,x86] Fix combine for condditional instructions.

On Fri, Dec 14, 2012 at 11:47 AM, Yuri Rumyantsev wrote: > With your new fix that add if-then-else splitting for memory operand I > got expected performance speed-up - +6.7% for Atom and +8.4% for SNB. > We need to do all testing this weekend and I will get you our final > feedback on Monday. Af

Re: [ARM] Turning off 64bits ops in Neon and gfortran/modulo-scheduling problem

On 17 December 2012 16:12, Richard Earnshaw wrote: > On 29/11/12 17:16, Christophe Lyon wrote: >> On trunk I have noticed a regression in gfortran when using modulo >> scheduling: sms-1.f90 now fails, but I suspect it's not because of >> this patch since forcing compilation for armv5t makes the sa

Re: PATCH RFA: PR go/55201: Create libatomic convenience library

On Wed, Dec 19, 2012 at 7:38 AM, Matthias Klose wrote: > > The following patch fixes this for me, maybe other target library dependencies > should be added too. > > that would be for > libgfortran on libquadmath, libgcc > libsanitizer on libstdc++ > libstdc++ on libgomp, libgcc > libjava o

Re: [Patch, libgomp] libgomp.fortran/fortran.exp - add -fintrinsic-modules-path ${blddir}

On Wed, Dec 19, 2012 at 04:38:41PM +0100, Tobias Burnus wrote: > 2012-12-19 Tobias Burnus > > * testsuite/libgomp.fortran/fortran.exp: Set > -fintrinsic-modules-path. Okay. Jakub

Re: [PATCH][ARM] AArch32 vmaxnm, vminnm support

On 26/11/12 14:40, Kyrylo Tkachov wrote: Hi all, This patch adds support for the AArch32 vmaxnm and vminnm VFP instructions in that can be used to implement the smax[sf,df]3 and smin[sf,df]3 RTL patterns. The patterns are only used by gcc when unsafe math optimisations are turned on. Two new valu

[Patch, libgomp] libgomp.fortran/fortran.exp - add -fintrinsic-modules-path ${blddir}

The attached patch adds -fintrinsic-modules-path ${blddir} otherwise, the compiler might have trouble finding the libraries using "use, INTRINSIC :: omp_lib". Without "intrinsic" it searches the "-I" directories. (The compiler supports multiple -fintrinsic-modules-path, cf. gfc_add_intrins

Re: PATCH RFA: PR go/55201: Create libatomic convenience library

Am 19.12.2012 01:28, schrieb Ian Lance Taylor: > On Tue, Dec 18, 2012 at 3:15 PM, Richard Henderson wrote: >> On 12/18/2012 02:52 PM, Ian Lance Taylor wrote: >>> Argh. But why? Wouldn't that only apply to cases where the lock was >>> sometimes locked by one library and sometimes locked by a diff

Re: [fortran, patch] Allow displaying backtraces from user code

>> Attached is a new patch, which expands the documentation according to >> your proposal, and uses the name BACKTRACE. I hope that both Janne and >> Tobias can agree with this naming decision ... > > Looks fine from my side. Great, thanks. Janne? > Can you also add a quip to > http://gcc.gnu.or

[Patch, Fortran/GOMP, committed] Moved test case from testsuite/gfortran.dg/gomp to libgomp/

Commited as obvious (Rev. 194611). The test case accesses the .mod file which is generated in libgomp. For some reasons, it works when GCC is installed (i.e. it works for most developers?) but it fails otherwise (e.g. for HJ's builds). Tobias Index: libgomp/ChangeLog =

Re: [Patch, AArch64]: Fix test harness to for unaligned vector mem access.

On 19/12/12 14:47, Tejas Belagod wrote: Hi, Currently on the trunk, we have many vect tests that fail for aarch64-*-* because check_effective_target_vect_no_align () in target-supports.exp returns true for aarch64 where in fact it should be returning false. This causes the tests that check for

Re: [cxx-conversion] Change uses of htab_t in gcc/config to hash_table.

On Tue, Dec 18, 2012 at 11:02 PM, Lawrence Crowl wrote: > Tested on x86-64. > Tested with contrib/config-list.mk. > > > Okay for branch? OK. Diego.

[Patch, AArch64]: Fix test harness to for unaligned vector mem access.

Hi, Currently on the trunk, we have many vect tests that fail for aarch64-*-* because check_effective_target_vect_no_align () in target-supports.exp returns true for aarch64 where in fact it should be returning false. This causes the tests that check for vect_no_align and expect messages for loo

[PATCH] Unbreak bootstrap

I'll check in the following once it survived stage1. Richard. 2012-12-19 Richard Biener * targhooks.h (default_canonicalize_comparison): Fix prototype. * targhooks.c (default_canonicalize_comparison): Define. Index: gcc/targhooks.h ===

Re: [fortran, patch] Allow displaying backtraces from user code

Janus Weil wrote: Attached is a new patch, which expands the documentation according to your proposal, and uses the name BACKTRACE. I hope that both Janne and Tobias can agree with this naming decision ... Looks fine from my side. Can you also add a quip to http://gcc.gnu.org/wiki/GFortran#GCC

Re: [PING] Bugfix: Additional parameter for canonicalize comparison

On Wed, Dec 19, 2012 at 3:04 PM, Richard Biener wrote: > On Wed, Dec 19, 2012 at 12:34 PM, Richard Earnshaw wrote: >> On 19/12/12 09:53, Andreas Krebbel wrote: >>> >>> Hi, >>> >>> are the ARM parts of the patch below ok for mainline? >>> >> >> Yes. >> >> Sorry for the delay. > > I think this brok

RE: [PATCH][ARM] AArch32 vmaxnm, vminnm support

Ping. http://gcc.gnu.org/ml/gcc-patches/2012-11/msg02097.html Thanks, Kyrill > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Kyrylo Tkachov > Sent: 26 November 2012 14:40 > To: gcc-patches@gcc.gnu.org > Cc: Ramana Radhakri

Re: [PING] Bugfix: Additional parameter for canonicalize comparison

On Wed, Dec 19, 2012 at 12:34 PM, Richard Earnshaw wrote: > On 19/12/12 09:53, Andreas Krebbel wrote: >> >> Hi, >> >> are the ARM parts of the patch below ok for mainline? >> > > Yes. > > Sorry for the delay. I think this broke bootstrap on x86_64: /space/rguenther/src/svn/trunk/gcc/config/i386/

Re: libgo patch committed: Update to current library

Hi Ian, > Sorry about that. This patch should fix the build. I have not yet it does, thanks. > tested whether it passes the tests. Bootstrapped on > x86_64-unknown-linux-gnu, which proves nothing since the file is not > used on GNU/Linux. Committed to mainline. I've tried it on i386-pc-sola

Re: [fortran, patch] Allow displaying backtraces from user code

Hi, first off: Some more words on the naming issue. I actually still prefer the most simple and straightforward variant (i.e. BACKTRACE, which can easily be found and does not sound 'clumsy') ... Or, why not just (plain and simple) "BACKTRACE"? >>> >>> The name is the same as backtrace() in

[asan] Use -fno-shrink-wrap for null-deref-1.c test

Hi! Weirdly this test fails just on some boxes and others succeeds (x86_64-linux, -Os only). The problem seems to be in the libasan fast unwinder, if the routine is shrink-wrapped, even when it is compiled with -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer, if the memory dereference which

[asan] Never use memset for clearing of shadow mem in epilogues (PR fortran/55341)

Hi! clear_storage sometimes emits a library call instead of clearing storage by pieces, rep stos* and similar, unfortunately if it is a call that libasan intercepts (memset), it fails because it doesn't allow writes into shadow mem. Fixed by scanning the clear_storage sequence if there are any ca

Re: [PATCH] Add gen_lowpart_for_debug (PR debug/55730)

On Tue, Dec 18, 2012 at 8:03 PM, Jakub Jelinek wrote: > Hi! > > On Tue, Dec 18, 2012 at 09:25:14AM +0100, Paolo Bonzini wrote: >> Il 17/12/2012 22:33, Jakub Jelinek ha scritto: >> > If gen_lowpart_if_possible returns NULL, the default >> > rtl_hooks.gen_lowpart_no_emit hook returns the original va

[PATCH] Fix PR55736

Switch conversion currently makes no effort to hide BLOCKs from locations of expressions it puts into the static constructors built. This causes issues at least for LTO where dead references to BLOCKs end up being produced for the varpool global initializers. But I can very well imagine that late

Re: [PING] Bugfix: Additional parameter for canonicalize comparison

On 19/12/12 09:53, Andreas Krebbel wrote: Hi, are the ARM parts of the patch below ok for mainline? Yes. Sorry for the delay. R. I did a compile test with a cross. Bye, -Andreas- Original Message Subject: [PATCH] Bugfix: Additional parameter for canonicalize comparis

Fix ipa-inline-transform ICE

Hi, the ipa-inline-transform ICE is caused by fact that devirt_benefit in ipa-inline-analysis is able to determine devirtualiation oppurtunity of call to b3, while the ipa-prop responsible for updating function body after inlining is not. This is because the later is missing code turning known con

[PING] Bugfix: Additional parameter for canonicalize comparison

Hi, are the ARM parts of the patch below ok for mainline? I did a compile test with a cross. Bye, -Andreas- Original Message Subject: [PATCH] Bugfix: Additional parameter for canonicalize comparison Date: Wed, 12 Dec 2012 12:23:14 +0100 From: Andreas Krebbel To: rearn...@ar

Re: [fortran, patch] Allow displaying backtraces from user code

On Sun, Dec 16, 2012 at 12:50 AM, Janus Weil wrote: > Hi, > >>> So, in principle I'm fine with all your BACKTRACE_* variants (except >>> for _splurge, maybe ;) >>> >>> Or, why not just (plain and simple) "BACKTRACE"? >> >> The name is the same as backtrace() in glibc, but otherwise, sure why >> no

Re: [Fortran, (RFC) patch] PR49110/51055 Assignment to alloc. deferred-length character vars

Jakub Jelinek wrote: On Tue, Dec 18, 2012 at 10:38:06PM +0100, Tobias Burnus wrote: Updated patch attached. Build and regtested on x86-64-gnu-linux. OK for the trunk? Looks ok to me, thanks. I have now committed it as Rev. 194604. For what it is worth, I have also successfully tested the tes