Re: patch to fix PR55430

2012-11-22 Thread H.J. Lu
On Thu, Nov 22, 2012 at 5:29 PM, Vladimir Makarov wrote: > The following patch fixes > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55430 > > The patch was successfully bootstrapped and tested on x86/x86-64. > > Committed as rev. 193742. > > 2012-11-22 Vladimir Makarov > > PR mid

[GCC ARM-Embedded-4_7]Back port r191457/r193687(prefer short-circuit on ARMv6m) from TRUNK

2012-11-22 Thread Bin Cheng
Hi, I back ported r193687/r191457 from TRUNK to GCC ARM-Embedded-4_7 branch as r193744/r193745. Thanks ChangeLog/r193687 Backport from mainline r193687 2012-11-21 Bin Cheng * config/arm/arm-cores.def (cortex-m0plus): Use v6m. * config/arm/arm-protos.h (tune_par

Re: [libsanitizer] a script to help merging asan from upstream

2012-11-22 Thread Konstantin Serebryany
Done, thanks! r193743. On Fri, Nov 23, 2012 at 2:50 AM, Xinliang David Li wrote: > Looks fine to me. > > David > > On Thu, Nov 22, 2012 at 11:06 AM, Konstantin Serebryany > wrote: >> Anything else? >> >> On Thu, Nov 22, 2012 at 6:42 AM, Konstantin Serebryany >> wrote: >>> Added to README.gcc: >

patch to fix PR55430

2012-11-22 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55430 The patch was successfully bootstrapped and tested on x86/x86-64. Committed as rev. 193742. 2012-11-22 Vladimir Makarov PR middle-end/55430 * lra.c: Move #include "hard-reg-set.h" before #incl

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-22 Thread Wei Mi
cc48-4.8.0-1000/darwin_objdir/./gcc/ -nostdinc++ > -nostdinc++ > -I/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libstdc++-v3/include/x86_64-apple-darwin12.2.0 > > -I/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libstdc++-

Re: [tsan] libsanitizer tweaks

2012-11-22 Thread Diego Novillo
On Thu, Nov 22, 2012 at 8:20 AM, Jakub Jelinek wrote: > On Thu, Nov 22, 2012 at 10:54:00AM +0100, Jakub Jelinek wrote: >> Ok, thanks. The comments can be fixed up incrementally. > > I had closer look at the libsanitizer/tsan configury, and I think I'd prefer > the configure.tgt script to say if t

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-22 Thread Jack Howarth
le-darwin12.2.0/libstdc++-v3/include/x86_64-apple-darwin12.2.0 -I/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libstdc++-v3/include -I/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20121122/libstdc++-v3/libsupc++ -I/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20121122/libst

[PATCH] PR testsuite/55440: Filter out -fsanitize=address from PLUGINCFLAGS

2012-11-22 Thread H.J. Lu
Hi, When GCC is compiled with -fsanitize=address, we passs -fsanitize=address to PLUGINCFLAGS. We either can't find libasan at build-time or run-time. This patch filter-outs -fsanitize=address from PLUGINCFLAGS. OK to install? Thanks. H.J. --- 2012-11-22 H.J. Lu PR testsuite/554

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-22 Thread Jakub Jelinek
On Thu, Nov 22, 2012 at 03:04:23PM -0800, H.J. Lu wrote: > It failed to bootstrap on Linux/i686: > > http://gcc.gnu.org/ml/gcc-regression/2012-11/msg00409.html > > It tried to build tsan on Linux/i686. I'd hope http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01866.html ought to fix that. J

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-22 Thread H.J. Lu
On Thu, Nov 22, 2012 at 2:08 PM, Wei Mi wrote: > Thanks. I checked in the code. > Committed revision 193736. > Committed revision 193737. > > Wei. > > On Thu, Nov 22, 2012 at 1:54 AM, Jakub Jelinek wrote: >> On Wed, Nov 21, 2012 at 11:22:51PM -0800, Wei Mi wrote: >>> I update the tsan patch again

Ping / update: Re: RFA: hookize ADJUST_INSN_LENGTH

2012-11-22 Thread Joern Rennecke
This uses the same interface as my previous patch: http://gcc.gnu.org/ml/gcc-patches/2012-11/msg00473.html , but I refined the algorithm for the get_insn_variants mechanism to work properly with the reworked ARC port - http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01891.html - the only user so far,

Re: [libsanitizer] a script to help merging asan from upstream

2012-11-22 Thread Xinliang David Li
Looks fine to me. David On Thu, Nov 22, 2012 at 11:06 AM, Konstantin Serebryany wrote: > Anything else? > > On Thu, Nov 22, 2012 at 6:42 AM, Konstantin Serebryany > wrote: >> Added to README.gcc: >> The merges from upstream should be done with the aid of the merge.sh script; >> it will also upd

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-22 Thread Wei Mi
Thanks. I checked in the code. Committed revision 193736. Committed revision 193737. Wei. On Thu, Nov 22, 2012 at 1:54 AM, Jakub Jelinek wrote: > On Wed, Nov 21, 2012 at 11:22:51PM -0800, Wei Mi wrote: >> I update the tsan patch against trunk, and create libtsan patch. >> Please see if it is ok.

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-22 Thread Wei Mi
Thanks, Fixed. Wei. On Wed, Nov 21, 2012 at 11:48 PM, Dmitry Vyukov wrote: > On Thu, Nov 22, 2012 at 11:45 AM, Xinliang David Li > wrote: >> >> On Wed, Nov 21, 2012 at 11:35 PM, Dmitry Vyukov >> wrote: >> > What percent of the memory accesses the following can skip? >> > >> > I just don't know

[PATCH, doc]: Fix md.texi warning

2012-11-22 Thread Uros Bizjak
Hello! Attached patch fixes following md.texi warning during build process: ../../gcc-svn/trunk/gcc/doc//md.texi:8931: warning: `.' or `,' must follow @xref, not `)'. ../../gcc-svn/trunk/gcc/doc//md.texi:8931: warning: for cross-references in parentheses, use @pxref. 2012-11-22 Uros Bizjak

[PATCH, i386]: Modernize FP compares using mode attributes, part 2

2012-11-22 Thread Uros Bizjak
Hello! Attached patch converts FP compares inside FP jcc combine helpers. 2012-11-22 Uros Bizjak * config/i386/i386.md (*jcc_0_i387): Macroize insn from *fp_jcc_3_387 using X87MODEF mode iterator. (*jcc_0_r_i387): New. (*jccxf_i387): Ditto. (*jccxf_r_i3

[PATCH] Add --with-build-config=bootstrap-asan support

2012-11-22 Thread H.J. Lu
Hi, This patch adds --with-build-config=bootstrap-asan support. Tested on Linux/x86-64. OK to install? Thanks. H.J. --- 2012-11-21 H.J. Lu * Makefile.def (target_modules): Add bootstrap=true and raw_cxx=true to libsanitizer. * configure.ac (bootstrap_target_libs):

Re: [PATCH, i386]: Modernize FP compares using mode attributes

2012-11-22 Thread Uros Bizjak
On Thu, Nov 22, 2012 at 8:40 PM, Steven Bosscher wrote: > On Thu, Nov 22, 2012 at 5:40 PM, Uros Bizjak wrote: >> No functional change. > > These are all nice cleanups, but is this really stage3-material? Not realy, I agree, but I was fairly confident in the patch due to "no functional change" cl

Re: [PATCH, i386]: Modernize FP compares using mode attributes

2012-11-22 Thread Steven Bosscher
On Thu, Nov 22, 2012 at 5:40 PM, Uros Bizjak wrote: > Hello! > > No functional change. These are all nice cleanups, but is this really stage3-material? Ciao! Steven

Re: [libsanitizer] a script to help merging asan from upstream

2012-11-22 Thread Konstantin Serebryany
Anything else? On Thu, Nov 22, 2012 at 6:42 AM, Konstantin Serebryany wrote: > Added to README.gcc: > The merges from upstream should be done with the aid of the merge.sh script; > it will also update the file MERGE to contain the upstream revision > we merged with. > > > On Wed, Nov 21, 2012 at

Re: [PATCH] Add no_address_safety_analysis attribute (PR sanitizer/55435)

2012-11-22 Thread Konstantin Serebryany
Looks good! (not sure if I am a proper reviewer though) --kcc On Thu, Nov 22, 2012 at 3:07 PM, Jakub Jelinek wrote: > Hi! > > This patch adds the no_address_safety_analysis attribute. Tested on > x86_64-linux, ok for trunk? > > 2012-11-22 Jakub Jelinek > > PR sanitizer/55435 >

[AARCH64-47, PATCH] Remove 'Utf' constraint documentation for AArch64.

2012-11-22 Thread Marcus Shawcroft
I've also committed this to ARM/aarch64-4.7-branch. /Marcus 2012-11-22 Marcus Shawcroft * doc/md.texi (AArch64 family): Remove Utf. diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi index 297058c..6a4e0be 100644 --- a/gcc/doc/md.texi +++ b/gcc/doc/md.texi @@ -1727,9 +1727,6 @@ A memory

[PATCH] Remove 'Utf' constraint documentation for AArch64.

2012-11-22 Thread Marcus Shawcroft
This patch removes the documentation for the AArch64 constraint 'Utf'. The implementation was removed before the port was merged to trunk, but the documentation was missed. Committed as obvious. /Marcus 2012-11-22 Marcus Shawcroft * doc/md.texi (AArch64 family): Remove Utf.diff --

[PATCH, RFC] Dumping expanded MD files

2012-11-22 Thread Kirill Yukhin
Hi folks, This patch adds an utility for dumping MD-files after iterators and define_substs expanding. The new utility is named genmddump and is built along with other gen* programs. I also added new target to Makefile to invoke this utility. However, I’m not sure it’s general enough to be added

Re: [PATCH, RFC] Enable libsanitizer on powerpc{,64}

2012-11-22 Thread Konstantin Serebryany
On Thu, Nov 22, 2012 at 12:38 PM, Evgeniy Stepanov wrote: > Yes, it has 3 asan-rtl frames on top. I'm not sure why this does not > happen on ppc. Different inlining inside run-time. I still prefer a simple PopFrames to anything else, I am sure we can make it reliable. the asan run-time should alw

[PATCH, generic] Fix for define_subst

2012-11-22 Thread Kirill Yukhin
Hello, Here is copy-and-paste from issue raised by Ian (in the bottom). Fix is attached. ChangeLog entry: 2012-11-22 Michael Zolotukhin * gensupport.c (add_c_test): Check if expr isn't NULL. Is it ok for trunk? === CUT HERE === It looks like the recent VEC rewrite might have interact

[Patch,testsuite] ad PR52641: Fix some more tests that fail for small targets

2012-11-22 Thread Georg-Johann Lay
Some more skips for tests that will fail with 16-bit int etc. Ok for trunk? Johann PR testsuite/52641 * gcc.dg/unroll_5.c: Add dg-require-effective-target int32plus. * gcc.dg/pr55150-1.c: Same. * gcc.dg/torture/pr54894.c: Add size32plus. Index: gcc.dg/unroll_5.c =

[PATCH][AARCH64] Fix the name mangling of AdvSIMD vector types

2012-11-22 Thread Yufeng Zhang
Hi, This patch implements the correct name mangling of AArch64 AdvSIMD vector types in conformance to the AAPCS64 doc (Procedure Call Standard for the ARM 64-bit Architecture, Appendix A). OK for the trunk? Thanks, Yufeng gcc/ChangeLog 2012-11-22 Yufeng Zhang * config/aarch64/a

[PATCH, i386]: Modernize FP compares using mode attributes

2012-11-22 Thread Uros Bizjak
Hello! No functional change. 2012-11-22 Uros Bizjak * config/i386/i386.md (FPCMP): New mode iterator. (unord): New mode attribute. (*cmp_0_i387): Macroize insn from *cmpfp_0 using X87MODEF mode iterator. (*cmp_0_cc_i387): Macroize insn from *cmpfp_0_cc

Re: [C++ PATCH] Fix PR 55418

2012-11-22 Thread Paolo Carlini
Hi, On 11/22/2012 04:06 PM, Jakub Jelinek wrote: On Thu, Nov 22, 2012 at 02:28:18PM +0100, Paolo Carlini wrote: On 11/22/2012 01:06 PM, Markus Trippelsdorf wrote: The fix is trivial. I would appreciate if someone could commit this. I agree it qualifies as obvious and I mean to commit the patc

Re: [AARCH64] Update maintainers file

2012-11-22 Thread Gerald Pfeifer
On Thu, 22 Nov 2012, Richard Earnshaw wrote: > Haven't seen any follow-up on this. Since it's fairly trivial, I've > committed it as obvious; but I'm happy to change it if you feel it > should be worded differently. This looks just fine to me, thanks! (I've been in those flying metal tubes mu

C++ PATCH for c++/55137 (dynamic initialization with overflow)

2012-11-22 Thread Jason Merrill
In this PR, fold introduces TREE_OVERFLOW into an expression. This seems wrong, and Jakub has a separate patch to address that issue, but it seemed to me that GCC should still do static initialization even if the initializer involves overflow. So this patch adjusts the constexpr evaluation co

[PATCH] Convert asan to use sanitizer.def builtins, initialize them if the FE didn't

2012-11-22 Thread Jakub Jelinek
On Thu, Nov 22, 2012 at 09:08:23AM +0100, Jakub Jelinek wrote: > On Thu, Nov 22, 2012 at 11:29:05AM +0400, Dmitry Vyukov wrote: > > +static bool > > +tsan_gate (void) > > +{ > > + return flag_tsan != 0 > > +&& builtin_decl_implicit_p (BUILT_IN_TSAN_INIT); > > > > > > What does it mean? Why b

Re: [asan] PATCH: PR driver/55379: Issue an error for -static with fsanitize=address

2012-11-22 Thread Jakub Jelinek
On Thu, Nov 22, 2012 at 06:39:11AM -0800, H.J. Lu wrote: > fsanitize=address doesn't work with static link. This patch issues > an error when both are specified. OK to install? > 2012-11-22 H.J. Lu > > PR driver/55379 Replace driver/ with sanitizer/ > * gcc.c (LINK_COMMAND_SPEC

Re: [C++ PATCH] Fix PR 55418

2012-11-22 Thread Jakub Jelinek
On Thu, Nov 22, 2012 at 02:28:18PM +0100, Paolo Carlini wrote: > On 11/22/2012 01:06 PM, Markus Trippelsdorf wrote: > >The fix is trivial. I would appreciate if someone could commit this. > I agree it qualifies as obvious and I mean to commit the patch on > your behalf before the end of the day if

PATCH: PR driver/55374: [asan] Wrong linking order of libasan and libstdc++

2012-11-22 Thread H.J. Lu
Hi, libasan should come first before any language-specific adjustment/addition. Otherwise, we got g++ -fsanitize=address -static-libasan ... /usr/local/bin/ld: error: /export/build/gnu/gcc-asan/build-x86_64-linux/prev-x86_64-unknown-linux-gnu/libsanitizer/asan/.libs/libasan.a(asan_new_delete.o)

[asan] PATCH: PR driver/55379: Issue an error for -static with fsanitize=address

2012-11-22 Thread H.J. Lu
Hi, fsanitize=address doesn't work with static link. This patch issues an error when both are specified. OK to install? Thanks. H.J. --- 2012-11-22 H.J. Lu PR driver/55379 * gcc.c (LINK_COMMAND_SPEC): Issue an error for -static with -fsanitize=address. diff --git

Re: RFC: Add --with-build-config=bootstrap-asan support

2012-11-22 Thread H.J. Lu
On Thu, Nov 22, 2012 at 5:55 AM, Markus Trippelsdorf wrote: > On 2012.11.21 at 15:54 -0800, H.J. Lu wrote: >> Hi, >> >> I added --with-build-config=bootstrap-asan support on hjl/asan >> branch: >> >> http://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/hjl/asan >> >> Any comments? > > It woul

Re: RFC: Add --with-build-config=bootstrap-asan support

2012-11-22 Thread Markus Trippelsdorf
On 2012.11.21 at 15:54 -0800, H.J. Lu wrote: > Hi, > > I added --with-build-config=bootstrap-asan support on hjl/asan > branch: > > http://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/hjl/asan > > Any comments? It would be nice if one could run: % ~/gcc/configure --with-build-config=boo

Re: [AARCH64] Update maintainers file

2012-11-22 Thread Richard Earnshaw
On 20/11/12 16:44, Richard Earnshaw wrote: On 28/10/12 21:45, Gerald Pfeifer wrote: On Tue, 23 Oct 2012, Richard Earnshaw wrote: On 23/10/12 23:36, Steven Bosscher wrote: Will you also add an announcement of this to the news page (home page) and to gcc-4.8/changes.html? I'm sure we can... :-)

Re: [C++ PATCH] Fix PR 55418

2012-11-22 Thread Paolo Carlini
Hi, On 11/22/2012 01:06 PM, Markus Trippelsdorf wrote: The fix is trivial. I would appreciate if someone could commit this. I agree it qualifies as obvious and I mean to commit the patch on your behalf before the end of the day if nobody objects. To be super-safe, I guess I will also run the t

[tsan] libsanitizer tweaks

2012-11-22 Thread Jakub Jelinek
On Thu, Nov 22, 2012 at 10:54:00AM +0100, Jakub Jelinek wrote: > Ok, thanks. The comments can be fixed up incrementally. I had closer look at the libsanitizer/tsan configury, and I think I'd prefer the configure.tgt script to say if tsan should be built or not. Furthermore, GCC doesn't support -W

Re: Sparc ASAN

2012-11-22 Thread Alexander Potapenko
>> While trying to add support for ARM (AArch32 GNU / Linux) implementation for >> GCC after-hours but still keep seeing failures on my chromebook running an >> ubuntu fs on a ChrOS kernel, because the shadow memory apparently overlaps >> with normal memory. Has anyone else hit this while porting ?

[C++ PATCH] Fix PR 55418

2012-11-22 Thread Markus Trippelsdorf
Hi, Valgrind complains about an uninitialized variable in method.c (implicitly_declare_fn): ==19553== Conditional jump or move depends on uninitialised value(s) ==19553==at 0x63D248: implicitly_declare_fn(special_function_kind, tree_node*, bool, tree_node*, tree_node*) (method.c:1623) ==19

RE: [PATCH][ARM] Define predicable attribute for arm_abssi2 and arm_neg_abssi2

2012-11-22 Thread Kyrylo Tkachov
Thanks for the review. As I do not have write access, can someone please apply? http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01655.html Thanks, Kyrill -Original Message- From: Richard Earnshaw Sent: 20 November 2012 10:32 To: Kyrylo Tkachov Cc: gcc-patches@gcc.gnu.org; Ramana Radhakrish

Re: [PATCH] Add STATIC_LIBASAN_LIBS for -static-libasan

2012-11-22 Thread Jakub Jelinek
On Sun, Nov 18, 2012 at 09:01:17PM -0800, H.J. Lu wrote: > This patch adds STATIC_LIBASAN_LIBS so that one can simply use > "gcc -faddress-sanitizer -static-libasan". OK to install? The usual way other libraries use is some special spec file generated by configure in those libraries and then sour

[PATCH] Add no_address_safety_analysis attribute (PR sanitizer/55435)

2012-11-22 Thread Jakub Jelinek
Hi! This patch adds the no_address_safety_analysis attribute. Tested on x86_64-linux, ok for trunk? 2012-11-22 Jakub Jelinek PR sanitizer/55435 * c-common.c (handle_no_address_safety_analysis_attribute): New function. (c_common_attribute_table): Add no_address

Re: Tighten checking of vector comparisons

2012-11-22 Thread Marc Glisse
(I forgot to send this at the time) On Sun, 4 Nov 2012, Richard Biener wrote: - else if (!INTEGRAL_TYPE_P (type) && TREE_CODE (type) != VECTOR_TYPE) + else if (!INTEGRAL_TYPE_P (type) && !VOID_TYPE_P (type) + && TREE_CODE (type) != VECTOR_TYPE) [...] Ok for th

[C++ testcase] PR 55432

2012-11-22 Thread Paolo Carlini
Hi, tested x86_64-linux, committed to mainline. Thanks, Paolo. / 2012-11-22 Paolo Carlini PR c++/55432 * g++.dg/cpp0x/constexpr-55432.C: New. Index: g++.dg/cpp0x/constexpr-55432.C === --- g++

Re: [PATCH] Use ATTRIBUTE_PACKED in ree.c

2012-11-22 Thread Eric Botcazou
> I'm not sure, but I hope it will. ansidecl.h has > #ifndef GCC_VERSION > #define GCC_VERSION (__GNUC__ * 1000 + __GNUC_MINOR__) > #endif /* GCC_VERSION */ > ... > #if (GCC_VERSION < 2007) > # define __attribute__(x) > #endif > ... > #ifndef ATTRIBUTE_PACKED > # define ATTRIBUTE_PACKED __attribut

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-22 Thread Jakub Jelinek
On Wed, Nov 21, 2012 at 11:22:51PM -0800, Wei Mi wrote: > I update the tsan patch against trunk, and create libtsan patch. > Please see if it is ok. > > gcc/ChangeLog: > 2012-11-22 Dmitry Vyukov > Wei Mi > > * builtins.def (DEF_SANITIZER_BUILTIN): Define tsan builtins. >

Re: [PATCH, RFC] Enable libsanitizer on powerpc{,64}

2012-11-22 Thread Evgeniy Stepanov
Yes, it has 3 asan-rtl frames on top. I'm not sure why this does not happen on ppc. #0 0x40122cdb in __asan::GetStackTrace(__sanitizer::StackTrace*, unsigned long, unsigned long, unsigned long) #1 0x40125167 in __asan_report_error #2 0x40125af3 in __asan_report_load1 On Thu, Nov 22,

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-22 Thread Jakub Jelinek
On Thu, Nov 22, 2012 at 11:29:05AM +0400, Dmitry Vyukov wrote: > +static bool > +tsan_gate (void) > +{ > + return flag_tsan != 0 > + && builtin_decl_implicit_p (BUILT_IN_TSAN_INIT); > > > What does it mean? Why builtin_decl_implicit_p (BUILT_IN_TSAN_INIT)? It is a temporary workaround, I'l