Re: The vec changes needed in gcc/go/gofrontend

2012-11-17 Thread Ian Lance Taylor
On Sat, Nov 17, 2012 at 6:55 PM, Diego Novillo wrote: > Attached. The vec rewrite patch is in as of rev 193595. [ This patch updates the Go frontend for the new vector code in GCC ]. Thanks. Committed to mainline. Ian foo.patch Description: Binary data

Re: [PATCH] Fix up var-tracking notes emitted in between bbs (PR middle-end/43631)

2012-11-17 Thread Alexandre Oliva
On Nov 14, 2012, Jakub Jelinek wrote: > Steven has been complaining for some years that var-tracking inserts > NOTE_INSN_VAR_LOCATION (and NOTE_INSN_CALL_ARG_LOCATION) notes sometimes > in between basic blocks, but with BLOCK_FOR_INSN set (or sometimes extends > a bb ending originally with a nore

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread Konstantin Serebryany
As for the libsanitizer update process, I suggest to move the discussion to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55376 On Sun, Nov 18, 2012 at 7:42 AM, Konstantin Serebryany wrote: > On Sun, Nov 18, 2012 at 7:34 AM, Andrew Pinski wrote: >> On Sat, Nov 17, 2012 at 7:17 PM, Konstantin Sereb

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-17 Thread Markus Trippelsdorf
On 2012.11.17 at 15:54 -0800, H.J. Lu wrote: > Hi, > > This patch adds --with-build-config=bootstrap-asan support. OK to > install? Wouldn't it make more sense to add an "--enable-checking=asan" option instead? -- Markus

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread Konstantin Serebryany
On Sun, Nov 18, 2012 at 7:34 AM, Andrew Pinski wrote: > On Sat, Nov 17, 2012 at 7:17 PM, Konstantin Serebryany > wrote: >> On Sat, Nov 17, 2012 at 7:10 PM, David Miller wrote: >>> From: Konstantin Serebryany >>> Date: Sat, 17 Nov 2012 19:01:56 -0800 >>> I am open to suggestions on how to a

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread David Miller
From: Andrew Pinski Date: Sat, 17 Nov 2012 19:34:34 -0800 > (glibc is the best at doing this). It also uses "make" in pretty much the most inefficient way possible, by causing it to consider 10s of thousands of prefix rules for every rule target. GLIBC has the same ifdef check that is being sug

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread Andrew Pinski
On Sat, Nov 17, 2012 at 7:17 PM, Konstantin Serebryany wrote: > On Sat, Nov 17, 2012 at 7:10 PM, David Miller wrote: >> From: Konstantin Serebryany >> Date: Sat, 17 Nov 2012 19:01:56 -0800 >> >>> I am open to suggestions on how to avoid forking the two versions. >>> If we fork, the original asan

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread Konstantin Serebryany
On Sat, Nov 17, 2012 at 7:26 PM, Diego Novillo wrote: > On Sat, Nov 17, 2012 at 10:10 PM, David Miller wrote: >> From: Konstantin Serebryany >> Date: Sat, 17 Nov 2012 19:01:56 -0800 >> >>> I am open to suggestions on how to avoid forking the two versions. >>> If we fork, the original asan team w

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread David Miller
From: Diego Novillo Date: Sat, 17 Nov 2012 22:26:24 -0500 > We have some new maintainers that are trying to understand how the > system works. Wouldn't we have someone become at least roughly familiar with these kinds of things before we allow them to commit such an invasive set of changes which

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread David Miller
From: Konstantin Serebryany Date: Sat, 17 Nov 2012 19:17:17 -0800 > I'd prefer to mention the ARCHs explicitly where possible, i.e. > #if defined(__x86_64__) || definde (__sparc64__) > instead of >#if __WORDSIZE == 64 || ... You really do need to check __x86_64__ as well the word size, in

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread Diego Novillo
On Sat, Nov 17, 2012 at 10:10 PM, David Miller wrote: > From: Konstantin Serebryany > Date: Sat, 17 Nov 2012 19:01:56 -0800 > >> I am open to suggestions on how to avoid forking the two versions. >> If we fork, the original asan team will not be able to cope with two >> repositories. > > The main

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread Konstantin Serebryany
On Sat, Nov 17, 2012 at 7:10 PM, David Miller wrote: > From: Konstantin Serebryany > Date: Sat, 17 Nov 2012 19:01:56 -0800 > >> I am open to suggestions on how to avoid forking the two versions. >> If we fork, the original asan team will not be able to cope with two >> repositories. > > The maint

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread David Miller
From: Konstantin Serebryany Date: Sat, 17 Nov 2012 19:01:56 -0800 > I am open to suggestions on how to avoid forking the two versions. > If we fork, the original asan team will not be able to cope with two > repositories. The maintainer of the sanitizer's job is to do the merging and resolve the

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread Konstantin Serebryany
On Sat, Nov 17, 2012 at 4:14 PM, David Miller wrote: > From: "H.J. Lu" > Date: Sat, 17 Nov 2012 16:06:23 -0800 > >> On Sat, Nov 17, 2012 at 4:04 PM, David Miller wrote: >>> From: Eric Botcazou >>> Date: Sun, 18 Nov 2012 00:18:15 +0100 >>> error: '__NR_mmap2' was not declared in this scope

Re: VEC re-write [patch 01/25]

2012-11-17 Thread Diego Novillo
On Thu, Nov 15, 2012 at 4:53 PM, Diego Novillo wrote: > I have tested the patch pretty extensively: > > - Regular bootstraps on x86_64, ppc, ia64, sparc and hppa. > - Bootstraps with --enable-checking=release > - Bootstraps with --enable-checking=gc,gcac > - Basic builds on all targets (using con

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread David Miller
From: "H.J. Lu" Date: Sat, 17 Nov 2012 16:06:23 -0800 > On Sat, Nov 17, 2012 at 4:04 PM, David Miller wrote: >> From: Eric Botcazou >> Date: Sun, 18 Nov 2012 00:18:15 +0100 >> >>> error: '__NR_mmap2' was not declared in this scope >>>return (void *)syscall(__NR_mmap2, addr, length, prot, fl

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread H.J. Lu
On Sat, Nov 17, 2012 at 4:04 PM, David Miller wrote: > From: Eric Botcazou > Date: Sun, 18 Nov 2012 00:18:15 +0100 > >> error: '__NR_mmap2' was not declared in this scope >>return (void *)syscall(__NR_mmap2, addr, length, prot, flags, fd, offset); > > The people making libsanitizer changes ar

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread David Miller
From: Eric Botcazou Date: Sun, 18 Nov 2012 00:18:15 +0100 > error: '__NR_mmap2' was not declared in this scope >return (void *)syscall(__NR_mmap2, addr, length, prot, flags, fd, offset); The people making libsanitizer changes are really going to have to stop making i386 specific changes to t

PATCH: Add --with-build-config=bootstrap-asan support

2012-11-17 Thread H.J. Lu
Hi, This patch adds --with-build-config=bootstrap-asan support. OK to install? Thanks. H.J. --- 2012-11-17 H.J. Lu * Makefile.def (target_modules): Add bootstrap=true for libsanitizer. * Makefile.tpl (LIBASAN_LIBS): New for gcc-bootstrap. Defined if $(BUILD

Re: PATCH: Add -static-libasan to the GCC driver

2012-11-17 Thread H.J. Lu
On Sat, Nov 17, 2012 at 12:22 PM, Jakub Jelinek wrote: > On Sat, Nov 17, 2012 at 12:00:00PM -0800, H.J. Lu wrote: >> This patch adds -static-libasan. OK to install? > > Okay, thanks. > >> 2012-11-17 H.J. Lu >> >> * common.opt (static-libasan): New option. >> * gcc.c (LIBASAN_SPEC):

Re: [PATCH] Enable building of libsanitizer on sparc linux again.

2012-11-17 Thread Eric Botcazou
> So, here is the (IMO obvious) patch to enable libsanitizer's build on > sparc linux, even if asan is not supported on that platform yet. > > OK for trunk? > > libsanitizer/ChangeLog: > > * configure.tgt: Enable sparc linux. libtool: compile: /home/ebotcazou/build/./gcc/g++ - B/home/ebo

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-11-17 Thread H.J. Lu
On Tue, Nov 13, 2012 at 1:57 PM, Sriraman Tallam wrote: > Patch committed now after making the changes. > Your libgcc change caused: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55370 -- H.J.

Re: PATCH: Add -static-libasan to the GCC driver

2012-11-17 Thread Jakub Jelinek
On Sat, Nov 17, 2012 at 12:00:00PM -0800, H.J. Lu wrote: > This patch adds -static-libasan. OK to install? Okay, thanks. > 2012-11-17 H.J. Lu > > * common.opt (static-libasan): New option. > * gcc.c (LIBASAN_SPEC): New macro. > (LINK_COMMAND_SPEC): Replace -lasan with LIBAS

Re: Patch ping

2012-11-17 Thread Richard Henderson
On 11/16/2012 01:10 AM, Jakub Jelinek wrote: > Hi! > > - PR54921 invalidate sp in cselib on fp setter insn > http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02035.html > (perhaps in light of PR54402 the single_succ (ENTRY_BLOCK_PTR) > from the patch should be nuked) > + rtx expr = find_re

PATCH: Add -static-libasan to the GCC driver

2012-11-17 Thread H.J. Lu
Hi, This patch adds -static-libasan. OK to install? Thanks. H.J. --- 2012-11-17 H.J. Lu * common.opt (static-libasan): New option. * gcc.c (LIBASAN_SPEC): New macro. (LINK_COMMAND_SPEC): Replace -lasan with LIBASAN_SPEC. * doc/invoke.texi: Document -static-l

Re: ASAN merge...

2012-11-17 Thread Toon Moene
On 11/16/2012 04:35 PM, Ian Lance Taylor wrote: I expect it's pronounced with a sort of throat-clearing noise that is hard to write. Sort of like the gargling sound represented by "argh." argh32 and argh64. I thought it was a nice way to enshrine a Monty Python joke into silicon. -- Toon M

Re: Patch ping

2012-11-17 Thread Richard Henderson
On 11/16/2012 01:10 AM, Jakub Jelinek wrote: > - PR55236 range test optimization fix with -fwrapv > http://gcc.gnu.org/ml/gcc-patches/2012-11/msg00707.html > (perhaps PLUS_EXPR can be handled similarly instead of bailing out) > Ok. r~

Re: Patch ping

2012-11-17 Thread Richard Henderson
On 11/16/2012 01:10 AM, Jakub Jelinek wrote: > - PR55188 testcase fix for targets with different branch cost > http://gcc.gnu.org/ml/gcc-patches/2012-11/msg00361.html Ok. r~

Re: [patch] instrument clones

2012-11-17 Thread Richard Henderson
On 11/16/2012 01:28 PM, Aldy Hernandez wrote: > * trans-mem (collect_bb2reg): Stop scanning at irrevocable > * blocks. > (get_bb_regions_instrumented): Add new traverse_clone argument and > use it. > (expand_regions_1): Same. > (expand_region): Same. > (exe

Re: [COMMITTED] Move libsanitizer configure logic to subdirectory

2012-11-17 Thread Richard Henderson
On 11/16/2012 11:55 PM, Hans-Peter Nilsson wrote: >> > +# the Free Software Foundation; either version 2 of the License, or >> > +# (at your option) any later version. > Heh, "version 2"... > But licensing changes are never obvious, right? Heh. I noticed and fixed the use of the old Boston street

Re: [PATCH, generic] New RTL primitive: `define_subst'

2012-11-17 Thread Richard Henderson
On 11/15/2012 05:50 AM, Kirill Yukhin wrote: > Hi guys, > thanks for review. Comments along with updated patch are below. Version 6 is now ok. Please apply. r~

patch to fix PR55342

2012-11-17 Thread Vladimir Makarov
The following patch solves http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55342 LRA after spilling a pseudo tries to assign freed hard regno to other reload pseudos and chooses the best. The more reload pseudos got the freed hard regno, the less cost of spilling. But the reload pseudos cou

Re: [PATCH] Avoid unnecessary __cxa_quard_{acquire,release} (PR middle-end/54630)

2012-11-17 Thread Jason Merrill
I suppose these changes are fine, but it might be more future-proof to compile with -fno-threadsafe-statics...or fix the build system so that the C++ library is available when linking the compiler. Jason

C++ PATCH: tidy diagnostic about invalid of use of automatic variable

2012-11-17 Thread Gabriel Dos Reis
Now that we can actually declare a variable as `auto', it becomes important to be precise in our terminology when diagnosing invalid uses of variables with automatic storage -- especially if the variable isn't declared 'auto'. Applied to trunk. -- Gaby 2012-11-17 Gabriel Dos Reis *

Re: VEC re-write [patch 22/25]

2012-11-17 Thread David Edelsohn
On Thu, Nov 15, 2012 at 4:54 PM, Diego Novillo wrote: > 2012-11-15 Diego Novillo > > Adjust for new vec API > (http://gcc.gnu.org/wiki/cxx-conversion/cxx-vec) > > * config/spu/spu-c.c: Use new vec API in vec.h. Okay. Thanks, David

Re: VEC re-write [patch 20/25]

2012-11-17 Thread David Edelsohn
On Thu, Nov 15, 2012 at 4:54 PM, Diego Novillo wrote: > 2012-11-15 Diego Novillo > > Adjust for new vec API > (http://gcc.gnu.org/wiki/cxx-conversion/cxx-vec) > > * config/rs6000/rs6000-c.c: Use new vec API in vec.h. > * config/rs6000/rs6000.c: Likewise. Okay. Thanks,

Re: [PING] [PATCH] PR c++/54401 - Confusing diagnostics about type-alias at class scope

2012-11-17 Thread Dodji Seketeli
Gabriel Dos Reis a écrit: > On Fri, Nov 16, 2012 at 8:51 AM, Jason Merrill wrote: >> Would it work to just do a cp_parser_commit_to_tentative_parse after we see >> the '='? I guess you mean in cp_parser_alias_declaration like in the updated patch below? > I like that solution better. Ok, than

[PATCH, PR 55260] Use info of the correct node in find_aggregate_values_for_callers_subset

2012-11-17 Thread Martin Jambor
Hi, PR 55260 contains two testcases which trigger two different bugs in ipa-cp.c. The first problem is that at one place in find_aggregate_values_for_callers_subset we use variable info instead of caller_info when determining whether a callee is a clone which then leads to an ICE. Fixed thusly a

[PATCH] Avoid unnecessary __cxa_quard_{acquire,release} (PR middle-end/54630)

2012-11-17 Thread Jakub Jelinek
Hi! This PR points out that unnecessarily in two gcc spots we now use __cxa_guard_acquire/release. In the first case, there is no point to make the var static, it is always created and disposed in the same function, so making it an automatic variable is certainly cheaper, there is no need to init

Re: [PATCH] Fix up builtin memcpy calls generated by Fortran FE (PR fortran/55341)

2012-11-17 Thread Thomas Koenig
Hi Jakub, Hi! This PR is about ASAN failing with checking failures. The problem is on the Fortran FE side, which calls BUILT_IN_MEMCPY sometimes with wrong type of the last argument (which is not type compatible with the size_type_node type). Fixed thusly, bootstrapped/regtested on x86_64-lin

[PATCH] Fix up builtin memcpy calls generated by Fortran FE (PR fortran/55341)

2012-11-17 Thread Jakub Jelinek
Hi! This PR is about ASAN failing with checking failures. The problem is on the Fortran FE side, which calls BUILT_IN_MEMCPY sometimes with wrong type of the last argument (which is not type compatible with the size_type_node type). Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-l

[v3] libstdc++/55363

2012-11-17 Thread Paolo Carlini
Hi, a thinko in my work to add debug-mode std::array. Committed to mainline. Thanks, Paolo. // 2012-11-17 Paolo Carlini PR libstdc++/55363 * include/std/array (tuple_size, tuple_element): Move out NAMESPACE_CONTAINER. * testsuite/23_co

[PATCH, PR55315] Don't assume a nonzero address plus a const is a nonzero address

2012-11-17 Thread Tom de Vries
Richard, This patch fixes PR 55315. When compiling for the mips target with -O2, function f is folded to 0, while the address of data is not known compile-time: ... int data[4096]; int f (void) { return (((unsigned int) &data[0]) == 0xdeadbea0U); } What happens is that expand turns the c

Re: [PATCH, generic] New RTL primitive: `define_subst'

2012-11-17 Thread Hans-Peter Nilsson
On Wed, 14 Nov 2012, Jakub Jelinek wrote: > > Which brings us to the question of what to do with the patch for 4.8. > > It's true that you made the deadline for stage1 closure. But there will > > be no users of this feature, so it begs the question of why we should > > apply it now. Have you a co

*ping* [patch, fortran] PR 30146, errors for INTENT(OUT) and INTENT(INOUT) for DO loop variables

2012-11-17 Thread Thomas Koenig
I wrote: Attached is the new version of the patch, regression-tested. http://gcc.gnu.org/ml/gcc-patches/2012-11/msg00836.html Thanks for the review! OK for trunk? Ping?