Re: [PATCH] Replace const_vector with match_operand in sse.md

2012-11-05 Thread Kirill Yukhin
Hi, > Yes, the patch is OK for mainline SVN. Checked into trunk: http://gcc.gnu.org/ml/gcc-cvs/2012-11/msg00155.html Thanks, K

Re: [x86] Fix gcc.c-torture/compile/20080806-1.c failures

2012-11-05 Thread Richard Sandiford
"H.J. Lu" writes: > On Mon, Nov 5, 2012 at 3:34 PM, H.J. Lu wrote: >> On Mon, Nov 5, 2012 at 10:56 AM, Richard Sandiford >> wrote: >>> Uros Bizjak writes: On Mon, Nov 5, 2012 at 9:30 AM, Richard Sandiford wrote: > gcc/ > PR target/55204 > * config/i386/i38

committed: Use mode parameter in epiphany_address_cost

2012-11-05 Thread Joern Rennecke
2012-11-06 Joern Rennecke * config/epiphany/epiphany.c (epiphany_address_cost): Use MODE parameter. Index: config/epiphany/epiphany.c === --- config/epiphany/epiphany.c (revision 193204) +++ config/epiphany/epip

[PATCH] Enable -mcpu=power8 for PowerPC

2012-11-05 Thread Peter Bergner
This patch enables new -mcpu and -mtune options for POWER8. The -mcpu=power8 option currently is just an alias for power7. The affect of these options will be expanded when more technical details are released by IBM. Bootstrapped and regtested on powerpc64-linux. Ok for mainline or should we wa

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-05 Thread Peter Bergner
On Mon, 2012-11-05 at 15:47 +0100, Jakub Jelinek wrote: > On Mon, Nov 05, 2012 at 08:40:00AM -0600, Peter Bergner wrote: > > Well we also patch config.in and configure.ac/configure. If those are > > acceptable to be patched later too, then great. If not, the patch > > That is the same thing as c

RFC: PATCH to add abi_tag attribute

2012-11-05 Thread Jason Merrill
As discussed at the Cauldron in Prague, this patch introduces a C++ abi_tag attribute which can be attached to a function or class to modify its mangled name and avoid name collisions with earlier versions with a different ABI. It also adds a -Wabi-tag warning option to make the compiler sugge

[patch] generate dual code paths in transactions

2012-11-05 Thread Aldy Hernandez
As originally discussed here... http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02648.html ...the goal is to generate dual code paths for transactions: one for the instrumented code path, and one without instrumentation. In keeping with tradition, the implementation was nightmarish and our plan

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-05 Thread Easwaran Raman
I'd like to get a small patch to tree reassociation ( http://gcc.gnu.org/ml/gcc-patches/2012-10/msg01761.html ) in. Thanks, Easwaran On Mon, Oct 29, 2012 at 10:56 AM, Jakub Jelinek wrote: > Status > == > > I'd like to close the stage 1 phase of GCC 4.8 development > on Monday, November 5th.

[patch] Contribute performance comparison script.

2012-11-05 Thread Lawrence Crowl
Add a contrib script for comparing the performance of two sets of compiler runs. Usage documentation is in the script. The script produces output of the form: $ compare_two_ftime_report_sets "Log0/*perf" "Log3/*perf" Arithmetic sample for timevar log files "Log0/*perf" and selecting lines conta

Re: [PATCH] fix libgomp.c++/pr24455.C failures on darwin

2012-11-05 Thread Mike Stump
On Nov 5, 2012, at 12:40 PM, Jack Howarth wrote: > These can be fixed for darwin by passing -Wl,-undefined,dynamic_lookup on > dg-options as has been > recommended by the darwin linker maintainer. > Okay for gcc trunk? Ok.

[PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-05 Thread Dehao Chen
Hi, This is a patch to do some obvious cleanup and setting correct input_location in ipa_prop (because it invokes gimplification routines). Bootstrapped and passed gcc regression tests. Is it okay for trunk? Thanks, Dehao gcc/ChangeLog: 2010-11-05 Dehao Chen * ipa-prop.c (ipa_modif

[Patch] libitm: add HTM fastpath

2012-11-05 Thread Torvald Riegel
This patch adds support for using strongly-isolated HTMs with serial-irrevocable mode as fallback. Such HTMs can execute uninstrumented code transactionally, and eventually aborted transactions will cause no visible side effects. Data conflicts with nontransactional accesses lead to transactions

Re: Minimize downward code motion during reassociation

2012-11-05 Thread Easwaran Raman
I am unable to figure out the right way to handle the debug statements. What I tried was to find debug statements that use the SSA name defined by the statement I moved (using SSA_NAME_IMM_USE_NODE) and then moved them as well at the right place. Thus, if I have to move t1 = a + b down (after the d

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-05 Thread Wei Mi
Hi Jakub, Thanks for the comments. I fix most of them except the setting of TODO_ The new patch.txt is attached. Thanks, Wei. >> + TODO_verify_all | TODO_update_ssa > > Ideally you shouldn't need TODO_update_ssa. > I got error when I removed TODO_update_ssa, so I kept it. >> +| TODO_u

committed: fix extract_insn HAVE_ATTR_enabled SNAFU

2012-11-05 Thread Joern Rennecke
Committed as obvious. 2012-11-05 Joern Rennecke * recog.c (extract_insn): Enabled alternative defaults to 1. Index: recog.c === --- recog.c (revision 193202) +++ recog.c (revision 193203) @@ -2165,7 +2165,7 @@

Re: [v3] Fix profile mode failures

2012-11-05 Thread Jonathan Wakely
On 6 November 2012 00:06, Jonathan Wakely wrote: > > There's still a failure for 23_containers/map/modifiers/emplace/1.cc > (which didn't even compile in profile mode previously) that I'll look > into. That turned out to be trivial, fixed like so. * include/profile/map.h (map::emplace_hin

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Steve Ellcey
On Mon, 2012-11-05 at 23:22 +, Richard Sandiford wrote: > No, same here: I don't use --with-sysroot for the newlib targets. > Do you build a unified gcc+newlib tree? If not, I don't think > the above boilerplate works; you'll have to use something else > instead. E.g. install newlib first, c

[v3] Fix profile mode failures

2012-11-05 Thread Jonathan Wakely
* include/profile/deque: Constrain InputIterator parameters. * include/profile/forward_list: Likewise. * include/profile/list: Likewise. * include/profile/map.h: Likewise. * include/profile/multimap.h: Likewise. * include/profile/set.h: Likewise.

Re: [x86] Fix gcc.c-torture/compile/20080806-1.c failures

2012-11-05 Thread H.J. Lu
On Mon, Nov 5, 2012 at 3:34 PM, H.J. Lu wrote: > On Mon, Nov 5, 2012 at 10:56 AM, Richard Sandiford > wrote: >> Uros Bizjak writes: >>> On Mon, Nov 5, 2012 at 9:30 AM, Richard Sandiford >>> wrote: gcc/ PR target/55204 * config/i386/i386.c (ix86_address_subreg_oper

Re: [x86] Fix gcc.c-torture/compile/20080806-1.c failures

2012-11-05 Thread H.J. Lu
On Mon, Nov 5, 2012 at 10:56 AM, Richard Sandiford wrote: > Uros Bizjak writes: >> On Mon, Nov 5, 2012 at 9:30 AM, Richard Sandiford >> wrote: >>> gcc/ >>> PR target/55204 >>> * config/i386/i386.c (ix86_address_subreg_operand): Remove stack >>> pointer check. >>>

Re: RFC: PR middle-end/55142: Check Pmode instead of ptr_mode for address mode

2012-11-05 Thread H.J. Lu
On Mon, Nov 5, 2012 at 3:06 PM, Richard Sandiford wrote: > "H.J. Lu" writes: >> On Sat, Nov 3, 2012 at 1:14 AM, H.J. Lu wrote: >>> Hi, >>> >>> The testcase shows -O -mx32 -maddress-mode=long -fPIC -S generates; >>> >>> x.i:22:37: internal compiler error: in plus_constant, at explow.c:88 >>> in

Re: RFC: PR middle-end/55142: Check Pmode instead of ptr_mode for address mode

2012-11-05 Thread H.J. Lu
On Mon, Nov 5, 2012 at 3:06 PM, Richard Sandiford wrote: > "H.J. Lu" writes: >> On Sat, Nov 3, 2012 at 1:14 AM, H.J. Lu wrote: >>> Hi, >>> >>> The testcase shows -O -mx32 -maddress-mode=long -fPIC -S generates; >>> >>> x.i:22:37: internal compiler error: in plus_constant, at explow.c:88 >>> in

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Richard Sandiford
Steve Ellcey writes: > On Mon, 2012-11-05 at 22:55 +, Richard Sandiford wrote: >> Steve Ellcey writes: >> > I am not sure how ld is supposed to find crt0.o in the uninstalled >> > setup, it exists in obj-mips-mti-elf/newlib/mips-mti-elf/libgloss/mips. >> >> The newlib and libgloss flags are

Re: [Dwarf Fission] Implement Fission Proposal (issue6305113)

2012-11-05 Thread Cary Coutant
> +/* %:replace-extension spec function. Replaces the extension of the > + first argument with the second argument. */ > + > +const char * > +replace_extension_spec_func (int argc, const char **argv) > +{ > + char *name; > + char *p; > + char *result; > + > + if (argc != 2) > +fatal_err

Re: RFC: PR middle-end/55142: Check Pmode instead of ptr_mode for address mode

2012-11-05 Thread Richard Sandiford
"H.J. Lu" writes: > On Sat, Nov 3, 2012 at 1:14 AM, H.J. Lu wrote: >> Hi, >> >> The testcase shows -O -mx32 -maddress-mode=long -fPIC -S generates; >> >> x.i:22:37: internal compiler error: in plus_constant, at explow.c:88 >> info[0x6eff - dyn->d_tag + 12] = dyn; >> >> expand_expr_real_2 ha

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Steve Ellcey
On Mon, 2012-11-05 at 22:55 +, Richard Sandiford wrote: > Steve Ellcey writes: > > I am not sure how ld is supposed to find crt0.o in the uninstalled > > setup, it exists in obj-mips-mti-elf/newlib/mips-mti-elf/libgloss/mips. > > The newlib and libgloss flags are usually added by the dejagnu

[patch RFA middle-end] Fix PR target/41993

2012-11-05 Thread Kaz Kojima
Hi, The attached patch is to solve PR target/41993 which will affect targets using MODE_EXIT. Without it, we can't find all return registers for __builtin_return in mode-switching.c:create_pre_exit. See the trail #4 by Uros in the PR for the details. The patch is tested with bootstrap and regtes

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Richard Sandiford
Steve Ellcey writes: > I am not sure how ld is supposed to find crt0.o in the uninstalled > setup, it exists in obj-mips-mti-elf/newlib/mips-mti-elf/libgloss/mips. The newlib and libgloss flags are usually added by the dejagnu baseboard file. E.g. for mips-sim.exp: set_board_info cflags "[libgl

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Steve Ellcey
On Mon, 2012-11-05 at 13:40 -0800, Steve Ellcey wrote: > Hm, I configured GCC with '--enable-languages=c,c++', I think this might > set ENABLE_LTO to '0' and cause check_effective_target_lto to return > FALSE and cause the -ffat-lto-objects flag to not be added. Of course > this raises the questi

Re: New badness metric for inliner

2012-11-05 Thread David Miller
From: Jan Hubicka Date: Mon, 5 Nov 2012 23:19:16 +0100 > Is line 784 for you "gcc_checking_assert (uninlined_call_time >= 0);"? Yes.

Re: [RFA:] PR55186 - gcc.dg/const-uniq-1.c fails due to vector not in the constant pool

2012-11-05 Thread Hans-Peter Nilsson
> From: Eric Botcazou > Date: Mon, 5 Nov 2012 15:29:11 +0100 > > But, for cris-elf (and reasonably the same for other targets) > > there might not be such a constant-pool entry in the first > > place: the vectors are too short to rule out piecewise > > initialization as optimal for size (counting

Re: New badness metric for inliner

2012-11-05 Thread Jan Hubicka
> > This broke the bootstrap on sparc: > > /home/davem/src/GIT/GCC/build-sparc32-linux/./prev-gcc/g++ > -B/home/davem/src/GIT/GCC/build-sparc32\ > -linux/./prev-gcc/ -B/usr/local/sparc-unknown-linux-gnu/bin/ -nostdinc++ > -B/home/davem/src/GIT/GCC\ > /build-sparc32-linux/prev-sparc-unknown-linu

[Patch, Fortran, OOP] PR 54917: [4.7/4.8 Regression] TRANSFER on polymorphic variable causes ICE

2012-11-05 Thread Janus Weil
Hi all, the attached patch implements support for polymorphic arguments to TRANSFER. For details and discussion see the PR. The patch was regtested successfully on x86_64-unknown-linux-gnu. Ok for trunk? Btw, as part of the PR is a regression in 4.7 and trunk, I would like to backport the target

[patch] PR55191 - ICE in tree-ssa-pre.c due to missing fake edge for an infinite loop

2012-11-05 Thread Steven Bosscher
Hello, I hadn't expected that cfganal.c's reverse-CFG DFS would actually depend on the order of the basic blocks. The attached patch fixes that small oversight... Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for trunk? Ciao! Steven * cfganal.c (connect_infinite_loops_to_exit):

[Cilkplus] Merged with trunk at revision 193151

2012-11-05 Thread Iyer, Balaji V
Cilk Plus branch was merged with trunk at revision 193151. Committed as revision 193192. Thanks, Balaji V. Iyer.

Re: RFC: PR middle-end/55142: Check Pmode instead of ptr_mode for address mode

2012-11-05 Thread H.J. Lu
On Sat, Nov 3, 2012 at 1:14 AM, H.J. Lu wrote: > Hi, > > The testcase shows -O -mx32 -maddress-mode=long -fPIC -S generates; > > x.i:22:37: internal compiler error: in plus_constant, at explow.c:88 > info[0x6eff - dyn->d_tag + 12] = dyn; > > expand_expr_real_2 has > > /* No sense savin

Re: patch to fix PR55151

2012-11-05 Thread H.J. Lu
On Mon, Nov 5, 2012 at 8:43 AM, Vladimir Makarov wrote: > The following patch fixes PR55151. The patch affects a sensitive part of > LRA code. So it took some time to find a PR solution. For the test there > were to many reloads into hard registers for an insn and LRA failed to > assign hard

RE: [Ping]FW: [PATCH] Cilk Plus merging to trunk (2 of n)

2012-11-05 Thread Iyer, Balaji V
Hello Joseph, Here is the fixed patch with all your changes and the ChangeLog entries below. gcc/ChangeLog 2012-11-05 Balaji V. Iyer * Makefile.in (C_COMMON_OBJS): Added c-family/array-notation-common.o. * doc/passes.texi (Cilk Plus Transformation): Documented array

[v3] 55028

2012-11-05 Thread Benjamin De Kosnik
Missing exports for unordered_* containers in debug mode. The patches between mainline/4.7 are a slight bit different, but equivalent. tested x86/linux tested x86/linux --enable-symvers=gnu-versioned-namespace 2012-11-05 Benjamin Kosnik Oleg Smolsky PR libstdc++/55028 * con

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Steve Ellcey
On Mon, 2012-11-05 at 21:28 +, Richard Sandiford wrote: > Does it work for you if you run it separately? E.g. with: > > make check-gcc RUNTESTFLAGS=dg-torture.exp=mips-sdata-1.c > > Richard Hm, I configured GCC with '--enable-languages=c,c++', I think this might set ENABLE_LTO to '0' a

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Richard Sandiford
Steve Ellcey writes: > On Mon, 2012-11-05 at 20:38 +, Richard Sandiford wrote: >> This sort of thing should usually be handled automatically by >> scan-assembler, and is for me: >> >> /foo/gcc/xgcc -B/foo/gcc/ /bar/gcc/testsuite/gcc.dg/torture/mips-sdata-1.c >> -fno-diagnostics-show-caret

Re: [patch] Fix PR tree-optimization/54986

2012-11-05 Thread Jakub Jelinek
On Mon, Nov 05, 2012 at 10:16:31PM +0100, Eric Botcazou wrote: > Bootstrapped/regtested on x86_64-suse-linux, OK for mainline and 4.7 branch? > > > 2012-11-05 Eric Botcazou > > PR tree-optimization/54986 > * gimple-fold.c (canonicalize_constructor_val): Strip again all no-op >

[patch] Fix PR tree-optimization/54986

2012-11-05 Thread Eric Botcazou
Hi, this is a regression present on the 4.7 branch and caused by my fix for another regression: http://gcc.gnu.org/ml/gcc-patches/2012-07/msg00825.html It turns out that canonicalize_constructor_val has side effects: on the 4.7 branch, it calls add_referenced_var on the base variable of an addr

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Steve Ellcey
On Mon, 2012-11-05 at 20:38 +, Richard Sandiford wrote: > This sort of thing should usually be handled automatically by > scan-assembler, and is for me: > > /foo/gcc/xgcc -B/foo/gcc/ /bar/gcc/testsuite/gcc.dg/torture/mips-sdata-1.c > -fno-diagnostics-show-caret > -O2 -flto -fuse-linker-plu

Re: [v3] Fix allocator-aware container requirements for forward_list

2012-11-05 Thread Jonathan Wakely
This updates the debug-mode and profile-mode forward_list code to match my recent allocator changes to the default mode. It also adds checking for unswappable allocators, and fixes some tests that those new checks showed were broken. * include/profile/forward_list: Update to meet allocato

Re: exception safety validation

2012-11-05 Thread François Dumont
I apply the attached patch. 2012-10-05 François Dumont * include/ext/throw_allocator.h (__throw_value_base): Add move semantic, not throwing. (__throw_value_limit): Likewise. (__throw_value_random): Likewise. * testsuite/util/exception/safety.h: Add validation of C++11

Re: [PATCH Version 2][RFA]Improving register pressure directed hoist

2012-11-05 Thread Jeff Law
On 11/02/2012 02:34 AM, Bin Cheng wrote: Also I don't understand why the bogus patch can catch more hoist opportunities and improve code size, so please help if you have any idea about this. Well, perturbing the code, particularly in a way which is supposed to change the amount of register pre

[PATCH] fix libgomp.c++/pr24455.C failures on darwin

2012-11-05 Thread Jack Howarth
Currently the following testcases are failing on x86_64-apple-darwin11/12... FAIL: libgomp.c++/pr24455.C -O0 (test for excess errors) WARNING: libgomp.c++/pr24455.C -O0 compilation failed to produce executable FAIL: libgomp.c++/pr24455.C -O1 (test for excess errors) WARNING: libgomp.c++/pr24

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Richard Sandiford
Richard Sandiford writes: > "Steve Ellcey " writes: >> diff --git a/gcc/testsuite/gcc.dg/torture/mips-sdata-1.c >> b/gcc/testsuite/gcc.dg/torture/mips-sdata-1.c >> index 8ffd4d8..53c9e4f 100644 >> --- a/gcc/testsuite/gcc.dg/torture/mips-sdata-1.c >> +++ b/gcc/testsuite/gcc.dg/torture/mips-sdata-

Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Richard Sandiford
"Steve Ellcey " writes: > diff --git a/gcc/testsuite/gcc.dg/torture/mips-sdata-1.c > b/gcc/testsuite/gcc.dg/torture/mips-sdata-1.c > index 8ffd4d8..53c9e4f 100644 > --- a/gcc/testsuite/gcc.dg/torture/mips-sdata-1.c > +++ b/gcc/testsuite/gcc.dg/torture/mips-sdata-1.c > @@ -1,6 +1,7 @@ > /* Check

Re: [google] Add attributes: always_patch_for_instrumentation and never_patch_for_instrumentation (issue6821051)

2012-11-05 Thread Xinliang David Li
It does not hurt to submit the patch for review -- you need to provide more background and motivation for this work 1) comparison with -finstrument-functions (runtime overhead etc) 2) use model difference (production binary ..) 3) Interesting examples of use cases (with graphs). thanks, David On

Re: [PATCH 08/10] Factorize condition insertion code out of build_check_stmt

2012-11-05 Thread Dodji Seketeli
Jakub Jelinek writes: > On Sat, Nov 03, 2012 at 12:03:45AM +0100, Dodji Seketeli wrote: >> + int fallthrough_probability = >> +then_more_likely_p >> +? PROB_VERY_UNLIKELY >> +: PROB_ALWAYS - PROB_VERY_UNLIKELY; > > Just a formatting nit, I think = needs to go on the next line, so > >

Re: [google] Add attributes: always_patch_for_instrumentation and never_patch_for_instrumentation (issue6821051)

2012-11-05 Thread Harshit Chopra
Thanks David for the review. My comments are inline. On Sat, Nov 3, 2012 at 12:38 PM, Xinliang David Li wrote: > > Harshit, Nov 5 is the gcc48 cutoff date. If you want to have the x-ray > instrumentation feature into this release, you will need to port your > patch and submit for trunk review no

[google] Add attributes: always_patch_for_instrumentation and never_patch_for_instrumentation (issue6821051)

2012-11-05 Thread Harshit Chopra
2012-11-05 Harshit Chopra * gcc/c-family/c-common.c (handle_always_patch_for_instrumentation_attribute): Handle always_patch_for_instrumentation attribute and turn inlining off for the function. (handle_never_patch_for_instrumentation_attribute): Handle never_patch_for_ins

Re: [PATCH] Vzeroupper placement/47440

2012-11-05 Thread Uros Bizjak
Hello! > 2012-11-04 Vladimir Yakovlev > >* mode-switching.c (create_pre_exit): Added code for > maybe_builtin_apply case. The part above is already committed. >* config/i386/i386-protos.h (emit_i387_cw_initialization): Deleted. >(emit_vzero): Added prototype. >

Re: [PATCH, middle-end]: Fix mode-switching MODE_EXIT check with __builtin_apply/__builtin_return

2012-11-05 Thread Eric Botcazou
> Unfortunately the proposed patch fails the testcase from PR41993: > > --cut here-- > short retframe_short (void *rframe) > { > __builtin_return (rframe); > } OK, so that's not only an issue with the mode of the return register, but with the return register itself. Then the original patch

Re: New badness metric for inliner

2012-11-05 Thread David Miller
This broke the bootstrap on sparc: /home/davem/src/GIT/GCC/build-sparc32-linux/./prev-gcc/g++ -B/home/davem/src/GIT/GCC/build-sparc32\ -linux/./prev-gcc/ -B/usr/local/sparc-unknown-linux-gnu/bin/ -nostdinc++ -B/home/davem/src/GIT/GCC\ /build-sparc32-linux/prev-sparc-unknown-linux-gnu/libstdc++-

[v3] libstdc++/55215

2012-11-05 Thread Paolo Carlini
Hi, tested x86_64-linux, committed to mainline (and soon 4_7-branch too). Thanks, Paolo. // 2012-11-05 Paolo Carlini PR libstdc++/55215 * include/bits/random.tcc (mersenne_twister_engine<>::seed(_Sseq&)): Assign state_size to _M_p. * testsuite

Re: [PATCH/MIPS] Use ins/dins instruction when written manually

2012-11-05 Thread Andrew Pinski
On Mon, 2012-11-05 at 19:19 +, Richard Sandiford wrote: > Hi Andrew, > > Andrew Pinski writes: > > On Fri, Oct 5, 2012 at 8:43 PM, Andrew Pinski > > wrote: > >> On Sun, Aug 19, 2012 at 10:13 AM, Richard Sandiford > >> wrote: > >>> Andrew Pinski writes: > Right now we only produce in

[patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c

2012-11-05 Thread Steve Ellcey
The test gcc.dg/torture/mips-sdata-1.c fails when compiled with -fno-fat-lto-objects because when that option is used no assembly code is output and thus the scan does not find the '.sdata' line. Checked with the mips-mti-elf target. OK to checkin? Steve Ellcey sell...@mips.com 2012-11-05 Stev

Re: [PATCH/MIPS] Use ins/dins instruction when written manually

2012-11-05 Thread Richard Sandiford
Hi Andrew, Andrew Pinski writes: > On Fri, Oct 5, 2012 at 8:43 PM, Andrew Pinski > wrote: >> On Sun, Aug 19, 2012 at 10:13 AM, Richard Sandiford >> wrote: >>> Andrew Pinski writes: Right now we only produce ins when a zero_extract is used on the right hand side. We can do better b

Re: [PATCH, middle-end]: Fix mode-switching MODE_EXIT check with __builtin_apply/__builtin_return

2012-11-05 Thread Uros Bizjak
On Mon, Nov 5, 2012 at 7:43 PM, Uros Bizjak wrote: As discussed above, modes of loads, generated from __builtin_apply have no connection to function return mode. mode-switching.c does detect __builtin_apply situation and raises maybe_builtin_apply flag, but doesn't use it to s

Re: [x86] Fix gcc.c-torture/compile/20080806-1.c failures

2012-11-05 Thread Richard Sandiford
Uros Bizjak writes: > On Mon, Nov 5, 2012 at 9:30 AM, Richard Sandiford > wrote: >> gcc/ >> PR target/55204 >> * config/i386/i386.c (ix86_address_subreg_operand): Remove stack >> pointer check. >> (print_reg): Use true_regnum rather than REGNO. >> (ix86_pri

Re: [patch][google/gcc-4_7] Extend expiration date for pr54127 (issue6817091)

2012-11-05 Thread Ollie Wild
OK. Ollie On Mon, Nov 5, 2012 at 12:40 PM, Paul Pluzhnikov wrote: > Greetings, > > This patch is for google/gcc-4_7 branch. > > Thanks, > > > 2012-11-05 Paul Pluzhnikov > > * contrib/testsuite-management/powerpc-grtev3-linux-gnu.xfail: > extend expiration date for pr54127. >

Re: [PATCH, middle-end]: Fix mode-switching MODE_EXIT check with __builtin_apply/__builtin_return

2012-11-05 Thread Uros Bizjak
On Mon, Nov 5, 2012 at 7:34 PM, Uros Bizjak wrote: > On Mon, Nov 5, 2012 at 7:05 PM, Eric Botcazou wrote: >>> This sequence breaks assumption in mode-switching.c, that final >>> function return register load operates in MODE_EXIT mode and triggere >>> following code: >>> >>> for

[patch][google/gcc-4_7] Extend expiration date for pr54127 (issue6817091)

2012-11-05 Thread Paul Pluzhnikov
Greetings, This patch is for google/gcc-4_7 branch. Thanks, 2012-11-05 Paul Pluzhnikov * contrib/testsuite-management/powerpc-grtev3-linux-gnu.xfail: extend expiration date for pr54127. Index: contrib/testsuite-management/powerpc-grtev3-linux-gnu.xfail =

Re: [PATCH] Do not change scope for unknown locations

2012-11-05 Thread Eric Botcazou
> Because we do want location and its block to be tightly coupled. I may > want to add an assertion that if location is known, the block should > *not* be NULL. Yes, that would be a first step towards always continuing. But that's 4.9 material, let's install the posted patch as-is for 4.8. --

Re: [PATCH, middle-end]: Fix mode-switching MODE_EXIT check with __builtin_apply/__builtin_return

2012-11-05 Thread Uros Bizjak
On Mon, Nov 5, 2012 at 7:05 PM, Eric Botcazou wrote: >> This sequence breaks assumption in mode-switching.c, that final >> function return register load operates in MODE_EXIT mode and triggere >> following code: >> >> for (j = n_entities - 1; j >= 0; j--) >> {

Re: [patch][RFC] Filename based shared library versioning on AIX

2012-11-05 Thread David Edelsohn
On Mon, Nov 5, 2012 at 1:10 PM, Michael Haubenwallner wrote: > Well, as long as the old sharedlibs were not created as standalone shared > objects (lib.so), this is similar to a normal "soname"-bump on AIX, in that > it is still possible for the package manager to transfer the old shared > object

Re: [patch][RFC] Filename based shared library versioning on AIX

2012-11-05 Thread Michael Haubenwallner
On 11/02/2012 12:16 AM, David Edelsohn wrote: > I would like to introduce filename-based shared library versioning (known as > the "soname" in ELF world) for AIX, activated by the '--enable-aix-soname' > configure flag. > As discussed in the Bugzilla, I think this is a good feature and a > nice t

Re: [PATCH, middle-end]: Fix mode-switching MODE_EXIT check with __builtin_apply/__builtin_return

2012-11-05 Thread Eric Botcazou
> This sequence breaks assumption in mode-switching.c, that final > function return register load operates in MODE_EXIT mode and triggere > following code: > > for (j = n_entities - 1; j >= 0; j--) > { > int e = entity_map[j]; >

PR 54805: __gthread_tsd* in vxlib-tls.c

2012-11-05 Thread rbmj
Hello all, Since nobody has commented on bug 54805, and I'm pretty sure this is valid (and obvious), I'm just submitting it to the list. This removes warnings about implicit declarations and fixes one of the function calls in vxlib-tls.c for vxworks targets. I got the old prototypes from h

Re: [PING^2] [C++ PATCH] Add overflow checking to __cxa_vec_new[23]

2012-11-05 Thread Florian Weimer
On 11/02/2012 01:14 PM, Paolo Carlini wrote: On 11/02/2012 01:09 PM, Florian Weimer wrote: I looked at this again and made a new copy of the test case instead. It has been successfully tested on x86_64-redhat-linux-gnu. Is this okay for trunk? Looks very nice to me, and after all the issue s

libgo patch committed: NetBSD fix

2012-11-05 Thread Ian Lance Taylor
This patch from Shenghou Ma fixes gccgo on libgo by not losing the TLS pointer. This works around what I would describe as a bug in the NetBSD libc. Bootstrapped on x86_64-unknown-linux-gnu, not that that proves much. Committed to mainline. Ian diff -r df61836f495f libgo/runtime/proc.c --- a/l

Re: [PATCH] Disable aggregate jump functions for bit-field stores

2012-11-05 Thread Martin Jambor
On Mon, Nov 05, 2012 at 05:20:46PM +0100, Jan Hubicka wrote: > > Hi, > > > > the patch below disables generation of aggregate jump functions from > > bit-field stores because currently we depend on type size of the value > > to determine the size of the stored value and that does not work with > >

libgo patch committed

2012-11-05 Thread Ian Lance Taylor
This patch from Shenghou Ma supports the os.Stat function on some more operating systems. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 5d8ca2f79dba libgo/Makefile.am --- a/libgo/Makefile.am Fri Nov 02 16:37:20 2012 -0700 +++ b/libgo/Makefile.

Re: [PATCH] New configuration options to enable additional executable/startfile/shared library prefixes

2012-11-05 Thread Michael Meissner
On Sat, Nov 03, 2012 at 07:01:04PM -0400, David Edelsohn wrote: > On Thu, Nov 1, 2012 at 5:17 PM, Michael Meissner > wrote: > > > This patch adds 4 additional configuration switches, that allow the person > > building the compiler to add additional prefixes to search for additional > > executable

committed: Fix dbr processing of conditional returns

2012-11-05 Thread Joern Rennecke
fill_simple_delay_slots would call optimize_skip with a conditional return, which would cause a segfault when it calls next_active_insn (RETURN). Other places in reorg.c check that they are not operating on a return insn before doing branch-insn only processing, so I added this check there too.

Re: [PATCH] Update source location for PRE inserted stmt

2012-11-05 Thread Xinliang David Li
For the example I listed, the new statement is generated for source construct at program point (2). However unlike simple code motion, (2) is not going away after PRE. How would setting the location of the new statement at the insertion point break coverage? Besides, the new statement won't create

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-05 Thread Kenneth Zadeck
Jakub and Richi, At this point I have decided to that i am not going to get the rest of the wide-int patches into a stable enough form for this round. The combination of still living without power at my house and some issues that i hit with the front ends has made it impossible to get this fi

Re: [PR54693] loss of debug info in jump threading and loop ivopts

2012-11-05 Thread Jeff Law
On 11/03/2012 10:11 AM, Alexandre Oliva wrote: On Nov 2, 2012, Alexandre Oliva wrote: On Nov 1, 2012, Jakub Jelinek wrote: Even for stmt frontiers it is IMHO undesirable to duplicate (perhaps many times) the whole sequence, as one would then reply the var changing sequence in the debugger

Implement simple peeling on tree level; remove RTL peeling code

2012-11-05 Thread Jan Hubicka
Hi, this patch removes RTL loop peeling code and makes tree-cunroll pass to also perform simple peeling (i.e. one done with profile feedback when loop is expected to iterate just few times). The motivation is 1) I want to do some re-tunning of tree peeling heuristics first week(s) of stage 3.

patch to fix PR55151

2012-11-05 Thread Vladimir Makarov
The following patch fixes PR55151. The patch affects a sensitive part of LRA code. So it took some time to find a PR solution. For the test there were to many reloads into hard registers for an insn and LRA failed to assign hard registers to all reload pseudos. There is another more costl

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-05 Thread David Malcolm
On Wed, 2012-10-31 at 11:13 +0100, Richard Biener wrote: > On Mon, Oct 29, 2012 at 6:56 PM, Jakub Jelinek wrote: > > Status > > == > > > > I'd like to close the stage 1 phase of GCC 4.8 development > > on Monday, November 5th. If you have still patches for new features you'd > > like to see i

Re: [PATCH] Disable aggregate jump functions for bit-field stores

2012-11-05 Thread Jan Hubicka
> Hi, > > the patch below disables generation of aggregate jump functions from > bit-field stores because currently we depend on type size of the value > to determine the size of the stored value and that does not work with > bit-fields, making it impossible for IPA-CP to organize them in their >

Re: [PATCH] Minor ipa-prop.c internal interface tweak

2012-11-05 Thread Jan Hubicka
> 2012-10-31 Martin Jambor > > * ipa-prop.c (ipa_get_param_decl_index_1): New function. > (ipa_get_param_decl_index): Just call ipa_get_param_decl_index_1. > (ipa_populate_param_decls): Accept descriptors parameter rather > than the whole info. > (load_from_unmodif

Re: [PATCH 08/10] Factorize condition insertion code out of build_check_stmt

2012-11-05 Thread Jakub Jelinek
On Sat, Nov 03, 2012 at 12:03:45AM +0100, Dodji Seketeli wrote: > + int fallthrough_probability = > +then_more_likely_p > +? PROB_VERY_UNLIKELY > +: PROB_ALWAYS - PROB_VERY_UNLIKELY; Just a formatting nit, I think = needs to go on the next line, so int fallthrough_probability =

Re: [PATCH] Update source location for PRE inserted stmt

2012-11-05 Thread Dehao Chen
> No, there is nothing natural (and this can even be wrong). The statements > must have the source location corresponding to the source construct they are > generated for, which may be totally different from that of the insertion > point. Yes, that can generate jumpiness in GDB, but this is far b

Re: [PATCH] Do not change scope for unknown locations

2012-11-05 Thread Dehao Chen
> OK, thanks. What happens if you go one step farther and always continue? Because we do want location and its block to be tightly coupled. I may want to add an assertion that if location is known, the block should *not* be NULL. Dehao > > -- > Eric Botcazou

[committed] 3 backports to 4.7 branch

2012-11-05 Thread Jakub Jelinek
Hi! I've backported 3 patches of mine to 4.7 branch, and committed them after bootstrap/regtest on x86_64-linux and i686-linux. Jakub 2012-11-05 Jakub Jelinek Backported from mainline 2012-10-10 Jakub Jelinek PR tree-optimization/54877 * tree-vect-l

[committed] Fix up pr54970.c testcase

2012-11-05 Thread Jakub Jelinek
Hi! I've noticed that while I'm including ../nop.h header, I was using "NOP" and so the inclusion was useless. It makes a difference only on ia64/s390*/mmix where I didn't test, anyway, this should fix that. Committed as obvious. 2012-11-05 Jakub Jelinek PR debug/54970 PR deb

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-05 Thread Jakub Jelinek
On Mon, Nov 05, 2012 at 08:40:00AM -0600, Peter Bergner wrote: > Well we also patch config.in and configure.ac/configure. If those are > acceptable to be patched later too, then great. If not, the patch That is the same thing as config.gcc bits. > isn't really very large. We did do this for po

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-05 Thread Peter Bergner
On Mon, 2012-11-05 at 13:53 +0100, Jakub Jelinek wrote: > On Mon, Nov 05, 2012 at 06:41:47AM -0600, Peter Bergner wrote: > > I'd like to post later today (hopefully this morning) a very minimal > > configure patch that adds the -mcpu=power8 and -mtune=power8 compiler > > options to gcc. Currently,

Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-11-05 Thread Bernd Schmidt
On 10/31/2012 01:12 PM, Richard Sandiford wrote: > OK with those changes for the rtl bits. Can't approve the generator > stuff though. That's also OK. Bernd

Re: [RFA:] PR55186 - gcc.dg/const-uniq-1.c fails due to vector not in the constant pool

2012-11-05 Thread Eric Botcazou
> But, for cris-elf (and reasonably the same for other targets) > there might not be such a constant-pool entry in the first > place: the vectors are too short to rule out piecewise > initialization as optimal for size (counting the vectors once > per use). Let's increase them. Twice might just b

Re: [Committed] Fix 54524: Wrong code with some 64bit addition with registers as 32bits

2012-11-05 Thread Eric Botcazou
> Hmm, like you said originally in the PR, I think generating the invalid > PLUS is the bug here. I agree (as Richard B said) that an invalid PLUS > shouldn't cause us to generate wrong code, but an assert seems better > than a check. Eric, what do you think? I think that this boils down to deci

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-05 Thread Kenneth Zadeck
On 11/04/2012 11:54 AM, Richard Biener wrote: On Thu, Nov 1, 2012 at 2:10 PM, Richard Sandiford wrote: Kenneth Zadeck writes: I would like you to respond to at least point 1 of this email. In it there is code from the rtl level that was written twice, once for the case when the size of the

New badness metric for inliner

2012-11-05 Thread Jan Hubicka
Hi, this patch implements new badness metric for inliner. It is now based on relative speedup, but not of calee, but of the caller + callee combo. This nicely encompasses the edge frequency and other parameters simplifying the actual badness code. I re-added code considering growth after inlining

Re: [x86] Fix gcc.c-torture/compile/20080806-1.c failures

2012-11-05 Thread H.J. Lu
On Mon, Nov 5, 2012 at 2:21 AM, H.J. Lu wrote: > On Mon, Nov 5, 2012 at 1:01 AM, Uros Bizjak wrote: >> On Mon, Nov 5, 2012 at 9:30 AM, Richard Sandiford >> wrote: >>> This is a case where we had: >>> >>> (set (reg:HI foo) (plus:HI (reg:HI sp) (const_int X))) >>> (clobber (reg:CC FLAGS_REG))

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-05 Thread Jakub Jelinek
On Mon, Nov 05, 2012 at 06:41:47AM -0600, Peter Bergner wrote: > On Mon, 2012-10-29 at 18:56 +0100, Jakub Jelinek wrote: > > I'd like to close the stage 1 phase of GCC 4.8 development > > on Monday, November 5th. If you have still patches for new features you'd > > like to see in GCC 4.8, please p

  1   2   >