> But, for cris-elf (and reasonably the same for other targets)
> there might not be such a constant-pool entry in the first
> place: the vectors are too short to rule out piecewise
> initialization as optimal for size (counting the vectors once
> per use).  Let's increase them.  Twice might just break-even for
> cris-elf so let's make them four times as long.  Sanity-checked
> for x86_64 w/w.o -m32 for a gcc-version that includes the
> optimization for which the test-case tests (CCing author).

I don't know cris at all, but 4 times sounds quite a lot compared to the other 
architectures (I presume that the test passes on most of them).

> Ok to commit?
> 
> gcc/testsuite:
>       PR testsuite/55186
>       * gcc/testsuite/gcc.dg/const-uniq-1.c (a): Increase length four times.

No objections by me though.

-- 
Eric Botcazou

Reply via email to