Re: [PATCH 06/13] Implement protection of stack variables

2012-11-01 Thread Xinliang David Li
Changing the option is part of the plan. Dodji, can you make the option change part of one the patches (e.g, the first one that introduces it) -- there seems no need for a separate patch for it. thanks, David On Thu, Nov 1, 2012 at 9:12 PM, Konstantin Serebryany wrote: > > > On Thu, Nov 1, 201

[GCC arm-embedded-4_7]Backport r192603/r192604 to arm-embedded-4_7 branch

2012-11-01 Thread Bin Cheng
Hi, I back ported revision 192603/192604 to arm-embedded-4_7 branch as r193088. Thanks. r193088 | amker | 2012-11-02 10:15:42 +0800 (五, 02 11月 2012) | 39 lines Backport from mainline r192604 2012-10-19 Bin Cheng * common.opt (flag_ira_hoist_pressure): New. * d

[v3] Fix allocator-aware container requirements for forward_list

2012-11-01 Thread Jonathan Wakely
This fixes the new LWG issue 2210 and only uses allocator::construct() for the elements not the nodes. 2012-11-02 Jonathan Wakely * include/bits/forward_list.h (forward_list(size_type)): Add missing allocator parameter. (_Fwd_list_node_base): Use NSDMI and define constr

Re: [doc,libstdc++] Link maintenance for the libstdc++ manual

2012-11-01 Thread Gerald Pfeifer
On Fri, 2 Nov 2012, Jonathan Wakely wrote: >> There is a _lot_ left to do, especially around the imported lwg >> pages; those are in a vary bade state. Any volunteer for that >> one? > They're imported, do we really want to tweak them? And then tweak them > again next time we import them? > > If

Re: [doc,libstdc++] Link maintenance for the libstdc++ manual

2012-11-01 Thread Jonathan Wakely
On 2 November 2012 00:29, Gerald Pfeifer wrote: > > There is a _lot_ left to do, especially around the imported lwg > pages; those are in a vary bade state. Any volunteer for that > one? They're imported, do we really want to tweak them? And then tweak them again next time we import them? If the

[doc,libstdc++] Link maintenance for the libstdc++ manual

2012-11-01 Thread Gerald Pfeifer
So that the libstdc++ guys cannot complain I am only spending time on Java. ;-) There is a _lot_ left to do, especially around the imported lwg pages; those are in a vary bade state. Any volunteer for that one? Applied. Gerald 2012-11-02 Gerald Pfeifer * doc/xml/manual/codecvt.xml:

Re: [PATCH] skip gcc.target/i386/pr53249.c on darwin

2012-11-01 Thread Jack Howarth
On Thu, Nov 01, 2012 at 03:38:13PM -0700, H.J. Lu wrote: > On Thu, Nov 1, 2012 at 2:41 PM, H.J. Lu wrote: > > On Thu, Nov 1, 2012 at 6:47 AM, Jack Howarth > > wrote: > >> On Fri, Aug 24, 2012 at 04:13:20PM +0200, Rainer Orth wrote: > >>> Jack Howarth writes: > >>> > >>> >Currently the new t

Re: [PATCH] Add extra location information - PR43486

2012-11-01 Thread Manuel López-Ibáñez
On 18 September 2012 12:58, Arnaud Charlet wrote: > This is a relatively large patch which tackles the difficult issue of > generating more sloc information in front-ends (in particular C and C++ > front-ends), so that "static analyzers" based on GCC can get more useful > and detailed information.

[doc] Remove moxie web reference from install.texi

2012-11-01 Thread Gerald Pfeifer
"Apache 2 Test Page powered by CentOS" is not exactly what I expect from a web page references from install.texi. Either those guys are belly up or their IT is broken. Either way, the link is gone. Gerald 2012-11-02 Gerald Pfeifer * doc/install.texi (Specific): Remove moxie web refe

[wwwdocs] Re: [Go,doc] Adjust reference to Go specification

2012-11-01 Thread Gerald Pfeifer
On Thu, 1 Nov 2012, Gerald Pfeifer wrote: > 2012-11-01 Gerald Pfeifer > > * doc/standards.texi (Standards): Adjust reference to Go > specification. Turns out there is another reference on our web page. Fixed thusly. Gerald Index: readings.html ===

Re: [PATCH] Reset source location for instructions moved out of its original residing basic block

2012-11-01 Thread Xinliang David Li
On Thu, Nov 1, 2012 at 4:16 PM, Dehao Chen wrote: > On Thu, Nov 1, 2012 at 4:07 PM, Xinliang David Li wrote: >> On Thu, Nov 1, 2012 at 3:57 PM, Ian Lance Taylor wrote: >>> On Thu, Nov 1, 2012 at 10:00 AM, Dehao Chen wrote: I see your point. How about we guard these changes with a flag

[wwwdocs,Java] Update reference to Java language specification

2012-11-01 Thread Gerald Pfeifer
Unlike other webmasters, Sun's/Oracle's actually took care of a redirect. Still we should update the link, and that was "recent" many years ago, so I adjusted this on the way. Applied. Gerald 2012-11-02 Gerald Pfeifer * faq.html: Update reference to Java language specification.

Re: [PATCH] New configuration options to enable additional executable/startfile/shared library prefixes

2012-11-01 Thread Gerald Pfeifer
On Thu, 1 Nov 2012, Michael Meissner wrote: > * doc/install.texi (--with-extra-prefix=): Document new configure > switches. > (--with-extra-exec-prefix=): Likewise. > (--with-extra-startfile-prefix=): Likewise. > (--with-extra-rpath-prefix=): Likewise. +On powerpc64-l

Re: [patch][RFC] Filename based shared library versioning on AIX

2012-11-01 Thread David Edelsohn
I would like to introduce filename-based shared library versioning (known as the "soname" in ELF world) for AIX, activated by the '--enable-aix-soname' configure flag. (libgcc_s) Optional filename-based shared library versioning on AIX. * Makefile.in (enable_aix_soname): Define.

Re: [PATCH] Reset source location for instructions moved out of its original residing basic block

2012-11-01 Thread Dehao Chen
On Thu, Nov 1, 2012 at 4:07 PM, Xinliang David Li wrote: > On Thu, Nov 1, 2012 at 3:57 PM, Ian Lance Taylor wrote: >> On Thu, Nov 1, 2012 at 10:00 AM, Dehao Chen wrote: >>> >>> I see your point. How about we guard these changes with a flag, say >>> -gless-jumpy, so that people can always choose

Re: [PATCH] skip gcc.target/i386/pr53249.c on darwin

2012-11-01 Thread H.J. Lu
On Thu, Nov 1, 2012 at 3:43 PM, Jakub Jelinek wrote: > On Thu, Nov 01, 2012 at 03:38:13PM -0700, H.J. Lu wrote: >> >> --- gcc/testsuite/gcc.target/i386/pr53249.c (revision 193061) >> >> +++ gcc/testsuite/gcc.target/i386/pr53249.c (working copy) >> >> @@ -1,4 +1,4 @@ >> >> -/* { dg-do compi

[patch, lra, pr55103, committed] Save lra_int struct.

2012-11-01 Thread Steve Ellcey
I checked in this patch as obvious. It fixes PR 55103 which is a compiler abort on MIPS with the -mips16 flag. After committing I realized I forgot to put the bug number in the ChangeLog, I will update PR 55103 by hand. Steve Ellcey sell...@mips.com 2012-11-01 Steve Ellcey * target

[wwwdocs] Remove Gelato reference from svn.html

2012-11-01 Thread Gerald Pfeifer
Looks like Gelato is gone, not surprising given the outlooks (or lack thereof) for ia64 itself, so I applied the following. Remove Gelato reference and abbreviate the description of the ia64-improvements branch. Gerald Index: svn.html =

Re: [PATCH] Reset source location for instructions moved out of its original residing basic block

2012-11-01 Thread Xinliang David Li
On Thu, Nov 1, 2012 at 3:57 PM, Ian Lance Taylor wrote: > On Thu, Nov 1, 2012 at 10:00 AM, Dehao Chen wrote: >> >> I see your point. How about we guard these changes with a flag, say >> -gless-jumpy, so that people can always choose between better coverage >> and less jumpy gdb behavior (it's als

Re: Lower unsupported VEC_COND_EXPR

2012-11-01 Thread Richard Henderson
On 2012-11-02 02:44, Marc Glisse wrote: > 2012-11-01 Marc Glisse > > PR middle-end/55001 > > gcc/ > tree-vect-generic.c (expand_vector_condition): New function. > (expand_vector_operations_1): Call it. > > testsuite/ > g++.dg/ext/vector19.C: Remove target restrictions. > g

[wwwdocs] Update gccupc download link

2012-11-01 Thread Gerald Pfeifer
Applied. Gerald Index: gupc.html === RCS file: /cvs/gcc/wwwdocs/htdocs/projects/gupc.html,v retrieving revision 1.6 diff -u -3 -p -r1.6 gupc.html --- gupc.html 10 Jan 2012 00:56:57 - 1.6 +++ gupc.html 1 Nov 2012 23:01:35

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Wei Mi
The patch has been checked in. Committed revision 193074. Thanks, Wei. On Thu, Nov 1, 2012 at 3:16 PM, Wei Mi wrote: > Ok, I will check in the patch. > > Thanks, > Wei. > > On Thu, Nov 1, 2012 at 3:03 PM, Xinliang David Li wrote: >> On Thu, Nov 1, 2012 at 2:23 PM, Xinliang David Li wrote: >>>

[Go,doc] Adjust reference to Go specification

2012-11-01 Thread Gerald Pfeifer
Applied to GCC trunk. Gerald 2012-11-01 Gerald Pfeifer * doc/standards.texi (Standards): Adjust reference to Go specification. Index: doc/standards.texi === --- doc/standards.texi (revision 193072) +++ doc/stand

Re: [PATCH] Reset source location for instructions moved out of its original residing basic block

2012-11-01 Thread Ian Lance Taylor
On Thu, Nov 1, 2012 at 10:00 AM, Dehao Chen wrote: > > I see your point. How about we guard these changes with a flag, say > -gless-jumpy, so that people can always choose between better coverage > and less jumpy gdb behavior (it's also important for some other > clients like AutoFDO). I will have

Re: [PATCH] skip gcc.target/i386/pr53249.c on darwin

2012-11-01 Thread H.J. Lu
On Thu, Nov 1, 2012 at 2:41 PM, H.J. Lu wrote: > On Thu, Nov 1, 2012 at 6:47 AM, Jack Howarth wrote: >> On Fri, Aug 24, 2012 at 04:13:20PM +0200, Rainer Orth wrote: >>> Jack Howarth writes: >>> >>> >Currently the new testcase for gcc.target/i386/pr53249.c is failing >>> > on darwin due to th

[PATCH] New configuration options to enable additional executable/startfile/shared library prefixes

2012-11-01 Thread Michael Meissner
I may have submitted this shortly before the Caudren, and it got lost. This patch adds 4 additional configuration switches, that allow the person building the compiler to add additional prefixes to search for additional executables and startfiles. If the backend has the appropriate tweaks install

Re: [PATCH] skip gcc.target/i386/pr53249.c on darwin

2012-11-01 Thread Jakub Jelinek
On Thu, Nov 01, 2012 at 03:38:13PM -0700, H.J. Lu wrote: > >> --- gcc/testsuite/gcc.target/i386/pr53249.c (revision 193061) > >> +++ gcc/testsuite/gcc.target/i386/pr53249.c (working copy) > >> @@ -1,4 +1,4 @@ > >> -/* { dg-do compile { target { ! { ia32 } } } } */ > >> +/* { dg-do compile {

Re: [PATCH] skip gcc.target/i386/pr53249.c on darwin

2012-11-01 Thread H.J. Lu
On Thu, Nov 1, 2012 at 2:41 PM, H.J. Lu wrote: > On Thu, Nov 1, 2012 at 6:47 AM, Jack Howarth wrote: >> On Fri, Aug 24, 2012 at 04:13:20PM +0200, Rainer Orth wrote: >>> Jack Howarth writes: >>> >>> >Currently the new testcase for gcc.target/i386/pr53249.c is failing >>> > on darwin due to th

Re: patch to fix constant math - 8th patch - tree-vrp.c

2012-11-01 Thread Kenneth Zadeck
either way, this needs to be investigated. it could just be my bad. On 11/01/2012 06:28 PM, Marc Glisse wrote: On Thu, 1 Nov 2012, Kenneth Zadeck wrote: This patch converts tree-vpn to use wide-int. In doing so it gets rid of all restrictions that this pass currently has on the target or so

Re: patch to fix constant math - 4th patch - wide-int.[ch] refresh

2012-11-01 Thread Kenneth Zadeck
This patch refreshes wide-int.[ch]. Most of the changes are bug fixes that were fixed for tree-vrp.c in patch 8. There are two significant differences: 1) There are now constructors to override the precision and bitsize that are normally taken from the type. These are used to perform the fi

Re: patch to fix constant math - 8th patch - tree-vrp.c

2012-11-01 Thread Marc Glisse
On Thu, 1 Nov 2012, Kenneth Zadeck wrote: This patch converts tree-vpn to use wide-int. In doing so it gets rid of all restrictions that this pass currently has on the target or source word size. The pass's reliance on a finite "infinite precision" representation has been preserved. It fi

[wwwdocs,Java] Use https for redhat.com.

2012-11-01 Thread Gerald Pfeifer
Like some other domains, redhat.com now defaults to http, so this adjusts the link. Gerald 2012-11-01 Gerald Pfeifer * news.html: Use https for redhat.com. Index: news.html === RCS file: /cvs/gcc/wwwdocs/htdocs/java/new

[PATCH] Fix an error in r193053

2012-11-01 Thread Dehao Chen
Hi, In r193053, input_location was mistakenly used. This patch changed to use curr_insn_location instead. This looks like an obvious patch, can I check it in to trunk? Bootstrapped and passed gcc/gdb regression test. Thanks, Dehao gcc/ChangeLog: 2012-11-01 Dehao Chen * expr.c (expan

[wwwdocs,Java] comparison of libgcj with Kaffe link is gone

2012-11-01 Thread Gerald Pfeifer
The regular comparison with Kaffe is gone after the restructuring/ move to github, and I could not find any replacement URL. I applied this patch. If any of you has a new URL, we can resurrect. Gerald 2012-11-01 Gerald Pfeifer * status.html: Remove comparison with Kaffe. Index: stat

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Wei Mi
Ok, I will check in the patch. Thanks, Wei. On Thu, Nov 1, 2012 at 3:03 PM, Xinliang David Li wrote: > On Thu, Nov 1, 2012 at 2:23 PM, Xinliang David Li wrote: >> On Thu, Nov 1, 2012 at 2:17 PM, Wei Mi wrote: >>> Thanks for the suggestion! >>> >>> The planned svn commands will be: >>> >>> svn

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Xinliang David Li
On Thu, Nov 1, 2012 at 2:23 PM, Xinliang David Li wrote: > On Thu, Nov 1, 2012 at 2:17 PM, Wei Mi wrote: >> Thanks for the suggestion! >> >> The planned svn commands will be: >> >> svn mv libasan libsanitizer >> svn add libsanitizer/asan >> svn add libsanitizer/tsan > > Probably keep the tsan cre

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Xinliang David Li
Yes, there is no need to repeat the error made in asan branch in trunk. David On Thu, Nov 1, 2012 at 2:55 PM, Jakub Jelinek wrote: > On Thu, Nov 01, 2012 at 02:52:52PM -0700, Xinliang David Li wrote: >> I think it is better to apply this patch to asan first to avoid extra >> thread. You probab

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Jakub Jelinek
On Thu, Nov 01, 2012 at 02:52:52PM -0700, Xinliang David Li wrote: > I think it is better to apply this patch to asan first to avoid extra > thread. You probably just need to retrieve your runtime part of the > trunk patch and resend it. Make sense? Yeah, for trunk I believe it would be better t

Re: [PATCH 02/13] Rename tree-asan.[ch] to asan.[ch]

2012-11-01 Thread Joseph S. Myers
On Thu, 1 Nov 2012, do...@redhat.com wrote: > From: dnovillo > > Following a discussion we had on this list, this patch renames the > file tree-asan.* into asan.*. > > * asan.c: Rename from tree-asan.c. > Update all users. > * asan.h: Rename from tree-asan.h > Update all

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Xinliang David Li
I think it is better to apply this patch to asan first to avoid extra thread. You probably just need to retrieve your runtime part of the trunk patch and resend it. Make sense? thanks, David On Thu, Nov 1, 2012 at 2:47 PM, Dodji Seketeli wrote: > Instead of planning this change for the branch

[wwwdocs] Remove broken GSCO 2011 link

2012-11-01 Thread Gerald Pfeifer
Applied. Gerald Index: news.html === RCS file: /cvs/gcc/wwwdocs/htdocs/news.html,v retrieving revision 1.133 diff -u -3 -p -r1.133 news.html --- news.html 9 Apr 2012 14:02:08 - 1.133 +++ news.html 1 Nov 2012 21:49:03 -0

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Dodji Seketeli
Instead of planning this change for the branch, would it be possible to plan it for trunk directly, on top of the patches that I posted for review there? The patch could go in on top of the patches I posted. Wei Mi writes: > This is the part2. > > On Thu, Nov 1, 2012 at 1:02 PM, Wei Mi wrote:

[wwwdocs] Disable fileboar.com GCC mirror

2012-11-01 Thread Gerald Pfeifer
This has been unreachable for a while, so I am removing it from the GCC mirrors list for now. Gerald Index: mirrors.html === RCS file: /cvs/gcc/wwwdocs/htdocs/mirrors.html,v retrieving revision 1.218 diff -u -3 -p -r1.218 mirrors.htm

Re: [PATCH] Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-11-01 Thread Steven Bosscher
On Thu, Nov 1, 2012 at 10:26 PM, Teresa Johnson wrote: > I'll do some testing of the fix below, but do you have any comments on > the correctness or the potential issue I raised (see my note just > below the patch)? Sorry, I don't know the pro- and epilogue threading code well enough to be of any

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Xinliang David Li
It is not always true though -- only when the array address is picked by the pass to be the induction variable. David On Thu, Nov 1, 2012 at 2:24 PM, Jakub Jelinek wrote: > On Thu, Nov 01, 2012 at 02:19:43PM -0700, Xinliang David Li wrote: >> Right -- I found the same thing, it is the ivopt that

Re: [PATCH] skip gcc.target/i386/pr53249.c on darwin

2012-11-01 Thread H.J. Lu
On Thu, Nov 1, 2012 at 6:47 AM, Jack Howarth wrote: > On Fri, Aug 24, 2012 at 04:13:20PM +0200, Rainer Orth wrote: >> Jack Howarth writes: >> >> >Currently the new testcase for gcc.target/i386/pr53249.c is failing >> > on darwin due to the absence of -mx32 support on that target. The followin

Re: [PATCH] Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-11-01 Thread Teresa Johnson
On Tue, Oct 30, 2012 at 10:48 AM, Steven Bosscher wrote: > On Tue, Oct 30, 2012 at 6:20 AM, Teresa Johnson wrote: >> Index: bb-reorder.c >> === >> --- bb-reorder.c(revision 192692) >> +++ bb-reorder.c(working copy) >>

Re: [PATCH] Fix CDDCE miscompilation (PR tree-optimization/55018)

2012-11-01 Thread Jan Hubicka
> On Thu, Nov 01, 2012 at 09:26:25PM +0100, Hans-Peter Nilsson wrote: > > > Attached patch was bootstrapped&tested on > > > > gcc/ > > PR tree-optimization/55018 > > * basic-block.h (dfs_find_deadend): New prototype. > > * cfganal.c (dfs_find_deadend): No longer static. Use bitmap > >

Re: [PATCH] Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-11-01 Thread Teresa Johnson
On Thu, Nov 1, 2012 at 10:19 AM, Teresa Johnson wrote: > On Wed, Oct 31, 2012 at 4:02 PM, Steven Bosscher > wrote: >> On Tue, Oct 30, 2012 at 10:43 PM, Teresa Johnson wrote: >>> Sure, I will give this a try after your verification patch tests >>> complete. Does this mean that the patch you poste

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Jakub Jelinek
On Thu, Nov 01, 2012 at 02:19:43PM -0700, Xinliang David Li wrote: > Right -- I found the same thing, it is the ivopt that resets it -- the > IV opt pass should have a TODO_update_address_taken. That wouldn't change anything. The IVopts pass adds some_ptr = &a[0]; to the IL, so a is then address

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Xinliang David Li
On Thu, Nov 1, 2012 at 2:17 PM, Wei Mi wrote: > Thanks for the suggestion! > > The planned svn commands will be: > > svn mv libasan libsanitizer > svn add libsanitizer/asan > svn add libsanitizer/tsan Probably keep the tsan creation out of this patch. David > cd libsanitizer > for i in `ls asan

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Xinliang David Li
Right -- I found the same thing, it is the ivopt that resets it -- the IV opt pass should have a TODO_update_address_taken. thanks, David On Thu, Nov 1, 2012 at 2:07 PM, Jakub Jelinek wrote: > On Thu, Nov 01, 2012 at 01:57:40PM -0700, Xinliang David Li wrote: >> I looked at it pretty late in th

Tighten checking of vector comparisons

2012-11-01 Thread Marc Glisse
Hello, this patch makes gimple checking of vector comparisons more strict by ensuring that it doesn't return a boolean. It also fixes a bug that this check detected in fold-const.c: for (void)(x<0), the C front-end was calling fold_unary_loc on the conversion to void, which was then converted

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Jakub Jelinek
On Thu, Nov 01, 2012 at 01:57:40PM -0700, Xinliang David Li wrote: > I looked at it pretty late in the pipeline -- during cfgexpand and I > had specified -O2 in the command line. That was too late, ivopts pass (after pre where tsan pass was put around) marks it TREE_ADDRESSABLE again, because it c

Re: Optimize hashtable allocator

2012-11-01 Thread François Dumont
Attached patch applied. 2012-11-01 François Dumont * include/bits/hashtable_policy.h (__details::_Before_begin<>): New, combine a base node instance and an allocator. * include/bits/hashtable.h (_Hashtable<>::_M_node_allocator): Remove. (_Hashtable<>::_M_before_begin): Rename

Re: [PATCH] Fix CDDCE miscompilation (PR tree-optimization/55018)

2012-11-01 Thread Jakub Jelinek
On Thu, Nov 01, 2012 at 09:26:25PM +0100, Hans-Peter Nilsson wrote: > > Attached patch was bootstrapped&tested on > > gcc/ > PR tree-optimization/55018 > * basic-block.h (dfs_find_deadend): New prototype. > * cfganal.c (dfs_find_deadend): No longer static. Use bitmap > ins

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Xinliang David Li
On Thu, Nov 1, 2012 at 1:47 PM, Jakub Jelinek wrote: > On Thu, Nov 01, 2012 at 12:34:54PM -0700, Xinliang David Li wrote: >> On Thu, Nov 1, 2012 at 12:16 PM, Jakub Jelinek wrote: >> > On Thu, Nov 01, 2012 at 11:57:21AM -0700, Xinliang David Li wrote: >> >> That is exactly related to tsan -- it sh

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Jakub Jelinek
On Thu, Nov 01, 2012 at 12:34:54PM -0700, Xinliang David Li wrote: > On Thu, Nov 1, 2012 at 12:16 PM, Jakub Jelinek wrote: > > On Thu, Nov 01, 2012 at 11:57:21AM -0700, Xinliang David Li wrote: > >> That is exactly related to tsan -- it should skip local variable that > >> is not address taken (th

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Jakub Jelinek
On Thu, Nov 01, 2012 at 11:35:42PM +0400, Dmitry Vyukov wrote: > Wow! It's cool! > Is it costly to compute? No, it is just a couple of instructions and bitmap_bit_p test. Jakub

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Xinliang David Li
that sounds good to me. David On Thu, Nov 1, 2012 at 1:31 PM, Jakub Jelinek wrote: > On Thu, Nov 01, 2012 at 01:19:42PM -0700, Xinliang David Li wrote: >> Will it be easier if you just rolled back your previous libasan >> library changes, and resubmit it with the restructured directory? > > I th

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Jakub Jelinek
On Thu, Nov 01, 2012 at 01:19:42PM -0700, Xinliang David Li wrote: > Will it be easier if you just rolled back your previous libasan > library changes, and resubmit it with the restructured directory? I think better would be if you didn't apply it as a patch with lots of svn add/svn rm commands, b

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Wei Mi
Yes. That will be easier and clearer. The patch is too big. Thanks, Wei. On Thu, Nov 1, 2012 at 1:19 PM, Xinliang David Li wrote: > Will it be easier if you just rolled back your previous libasan > library changes, and resubmit it with the restructured directory? > > David > > On Thu, Nov 1, 201

Re: [PATCH] Fix CDDCE miscompilation (PR tree-optimization/55018)

2012-11-01 Thread Hans-Peter Nilsson
> From: Steven Bosscher > Date: Sun, 28 Oct 2012 19:33:29 +0100 > On Mon, Oct 22, 2012 at 11:09 PM, Jakub Jelinek wrote: > > On Mon, Oct 22, 2012 at 10:51:43PM +0200, Steven Bosscher wrote: > > Wouldn't it be way cheaper to just export dfs_find_deadend from cfganal.c > > and call it in calc_dfs_t

Re: [asan] change libasan to libsanitizer

2012-11-01 Thread Xinliang David Li
Will it be easier if you just rolled back your previous libasan library changes, and resubmit it with the restructured directory? David On Thu, Nov 1, 2012 at 1:17 PM, Wei Mi wrote: > patch.part2.txt.bz2 and patch.part3.txt.bz2 are still too big. > > Divide patch.part2.txt.bz2 into two parts: >

[asan] change libasan to libsanitizer

2012-11-01 Thread Wei Mi
Hi, Here is the patch to change libasan to libsanitizer and reorganize the directory. I divided the patch into three parts for review. patch.part1.txt: Contains the changes in the outermost level. patch.part2.txt.bz2: Remove libasan patch.part3.txt.bz2: Add libsanitizer Is it ok for asan branch?

[PATCH] Poison loc_t in system.h

2012-11-01 Thread David Edelsohn
The name loc_t is too enticing for developers to avoid, but it unfortunately conflicts with a visible symbol in an AIX header file, which repeatedly causes conflicts. This patch poisons the symbols in GCC system.h to prevent developers from using it. Bootstrapped on powerpc-ibm-aix7.1.0.0 Okay?

[PATCH 12/13] Instrument built-in memory access function calls

2012-11-01 Thread dodji
From: dodji This patch instruments many memory access patterns through builtins. Basically, for a call like: __builtin_memset (from, 0, n_bytes); the patch would only instrument the accesses at the beginning and at the end of the memory region [from, from + n_bytes]. This is the strategy

[PATCH 07/13] Implement protection of global variables

2012-11-01 Thread dodji
From: jakub This patch implements the protection of global variables. The basic idea is to insert a red zone between two global variables and install a constructor function that calls the asan runtime to do the populating of the relevant shadow memory regions at load time. So the patch lays out

[PATCH 06/13] Implement protection of stack variables

2012-11-01 Thread dodji
From: jakub This patch implements the protection of stack variables. To understand how this works, lets look at this example on x86_64 where the stack grows downward: int foo () { char a[23] = {0}; int b[2] = {0}; a[5] = 1; b[1] = 2; return a[5] + b[1]; } For this function

[PATCH 04/13] Emit GIMPLE directly instead of gimplifying GENERIC.

2012-11-01 Thread dodji
From: jakub This patch cleanups the instrumentation code generation by emitting GIMPLE directly, as opposed to emitting GENERIC tree and then gimplifying them. It also does some cleanups here and there * Makefile.in (GTFILES): Add $(srcdir)/asan.c. * asan.c (shadow_ptr_types): N

[PATCH 10/13] Make build_check_stmt accept an SSA_NAME for its base

2012-11-01 Thread dodji
From: dodji This patch makes build_check_stmt accept its memory access parameter to be an SSA name. This is useful for a subsequent patch that will re-use. Tested by running cc1 -fasan on the program below with and without the patch and inspecting the gimple output to see that there is no chang

[PATCH 00/13] Request to merge Address Sanitizer in

2012-11-01 Thread dodji
From: Dodji Seketeli Hello, The set of patches following this message represents the work that happened on the asan branch to build up the Address Sanitizer work started in the Google branch. Address Sanitizer (aka asan) is a memory error detector. It finds use-after-free and {heap,stack,globa

[PATCH 08/13] Fix a couple of ICEs.

2012-11-01 Thread dodji
From: jakub After the previous patches uncovered the fact a NOTE_INSN_BASIC_BLOCK could show up in the middle of a basic block and thus violating an important invariant. THe cfgexpand.c hunk fixes that. Then it appeared that we could get tree sharing violation if build_check_stmt doesn't unshar

[PATCH 05/13] Allow asan at -O0

2012-11-01 Thread dodji
From: jakub This patch defines a new asan pass gate that is activated at -O0, in addition to the -O3 level at which it was initially activated. The patch also does some comment cleanups here and there. * asan.c (build_check_stmt): Rename join_bb variable to else_bb. (gate_asan_O

[PATCH 11/13] Factorize condition insertion code out of build_check_stmt

2012-11-01 Thread dodji
From: dodji This patch splits a new create_cond_insert_point_before_iter function out of build_check_stmt, to be used by a later patch. Tested by running cc1 -fasan on the test program below with and without the patch and by inspecting the gimple output to see that there is no change. void foo

[PATCH 02/13] Rename tree-asan.[ch] to asan.[ch]

2012-11-01 Thread dodji
From: dnovillo Following a discussion we had on this list, this patch renames the file tree-asan.* into asan.*. * asan.c: Rename from tree-asan.c. Update all users. * asan.h: Rename from tree-asan.h Update all users. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/bran

[PATCH 09/13] Don't forget to protect 32 bytes aligned global variables.

2012-11-01 Thread dodji
From: wmi It appeared that we were forgetting to protect global variables that are already 32 bytes aligned. Fixed thus. * varasm.c (assemble_variable): Set asan_protected even for decls that are already ASAN_RED_ZONE_SIZE or more bytes aligned. git-svn-id: svn+ssh://gc

[PATCH 03/13] Initial asan cleanups

2012-11-01 Thread dodji
From: jakub This patch defines a new asan_shadow_offset target macro, instead of having a mere macro in the asan.c file. It becomes thus cleaner to define the target macro for targets that supports asan, namely x86 for now. The ASAN_SHADOW_SHIFT (which, along with the asan_shadow_offset constan

[PATCH 01/13] Initial import of asan from the Google branch

2012-11-01 Thread dodji
From: dnovillo This patch merely imports the initial state of asan as it was in the Google branch. It provides basic infrastructure for asan to instrument memory accesses on the heap, at -O3. Note that it supports neither stack nor global variable protection. The rest of the patches of the set

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Xinliang David Li
On Thu, Nov 1, 2012 at 12:16 PM, Jakub Jelinek wrote: > On Thu, Nov 01, 2012 at 11:57:21AM -0700, Xinliang David Li wrote: >> That is exactly related to tsan -- it should skip local variable that >> is not address taken (though still addressable, which by addressable, >> it means the variable has

[wwwdocs,Java] remove sources.redhat.com reference from papers/nosb.html

2012-11-01 Thread Gerald Pfeifer
Applied. Gerald 2012-10-31 Gerald Pfeifer * papers/nosb.html: Remove reference to sources.redhat.com. Index: papers/nosb.html === RCS file: /cvs/gcc/wwwdocs/htdocs/java/papers/nosb.html,v retrieving revision 1.4 diff -u

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Jakub Jelinek
On Thu, Nov 01, 2012 at 11:57:21AM -0700, Xinliang David Li wrote: > That is exactly related to tsan -- it should skip local variable that > is not address taken (though still addressable, which by addressable, > it means the variable has a memory home). > > The problem is that if 'addressable' bi

patch to fix PR55150

2012-11-01 Thread Vladimir Makarov
The following patch fixes the second test of PR55150 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55150 The patch was successfully bootstrapped on x86/x86-64. Committed as rev. 193065. 2012-11-01 Vladimir Makarov PR middle-end/55150 * lra-constraints.c (lra_constraints): Check

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Xinliang David Li
That is exactly related to tsan -- it should skip local variable that is not address taken (though still addressable, which by addressable, it means the variable has a memory home). The problem is that if 'addressable' bit is not equivalent to 'address taken', it will be too conservative to use it

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Jakub Jelinek
On Thu, Nov 01, 2012 at 11:32:01AM -0700, Xinliang David Li wrote: > For the following case: > > int foo() > { >int a[100]; > > // use 'a' as a[i] > ... > } > > Assuming there is no assignment of the form p = &a[i] in the source, > variable 'a' still will be allocated in stack and it

Re: RFA: hookize ADJUST_INSN_LENGTH

2012-11-01 Thread Joern Rennecke
Quoting Richard Sandiford : > But I think extending the FSM from just being an on-the-fly transformatino during final (as for ARM) to something that happens earlier is a pretty major step in terms of the interface between the backend and the rest of GCC. There are then undocumented restriction

[wwwdocs] testing/testing-blitz.html update

2012-11-01 Thread Gerald Pfeifer
Something tells me, nobody(?) is really doing the kind of regular testing that we once envisioned, but while we have the page, let's at least make sure the link works. Anyone has been using a newer version and wants to update the description? Gerald Index: testing-blitz.html

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Xinliang David Li
For the following case: int foo() { int a[100]; // use 'a' as a[i] ... } Assuming there is no assignment of the form p = &a[i] in the source, variable 'a' still will be allocated in stack and its address is is needed. Is the addressable bit set for 'a'? If yes, then it is not the sa

[wwwdocs] sites.google.com defaults to https

2012-11-01 Thread Gerald Pfeifer
Applied. Gerald Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.7/changes.html,v retrieving revision 1.128 diff -u -3 -p -r1.128 changes.html --- changes.html8 Oct 2012 08:54:49 - 1.128 +++ changes.h

[wwwdocs] benchmarks/index.html -- Richi related updates

2012-11-01 Thread Gerald Pfeifer
I applied the change below, adjusting to Richi's name change and some (announced?) change on the SUSE web infrastructure side (which does a permanent redirect). On a related note, Tobias, http://users.physik.fu-berlin.de/~tburnus/gcc-trunk/benchmark/ now gives an "Internal Server Error". Gerald

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Jakub Jelinek
On Thu, Nov 01, 2012 at 11:11:13AM -0700, Xinliang David Li wrote: > But it skips those globals without static storage and marked as not > addressable. > > It seems to me you want to skip all stack local variables that are not > address escaped. Without address escape analysis, the address taken

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Diego Novillo
On Thu, Nov 1, 2012 at 2:11 PM, Xinliang David Li wrote: > The TREE_ADDRESSABLE check seems redundant -- if the var_decl (instead > of ssa name) appears in the assignment, why would it not be > 'addressable'? And being addressable does not mean it is address taken > either. Yes, it does mean tha

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Xinliang David Li
On Thu, Nov 1, 2012 at 11:16 AM, Dmitry Vyukov wrote: > On Thu, Nov 1, 2012 at 10:14 PM, Dmitry Vyukov wrote: >>> >>> >> > On Wed, Oct 31, 2012 at 11:00:17PM -0700, Xinliang David Li wrote: >>> >> >> > + /* Below are things we do not instrument >>> >> >> > + (no possibility of races or not i

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-01 Thread Xinliang David Li
On Thu, Nov 1, 2012 at 10:06 AM, Dmitry Vyukov wrote: > On Thu, Nov 1, 2012 at 7:47 PM, Xinliang David Li > wrote: >> >> On Wed, Oct 31, 2012 at 11:27 PM, Jakub Jelinek wrote: >> > On Wed, Oct 31, 2012 at 11:00:17PM -0700, Xinliang David Li wrote: >> >> > + /* Below are things we do not instrum

Re: [patch] Remove unused ebitmap and unused sbitmap functions.

2012-11-01 Thread Lawrence Crowl
On 11/1/12, Diego Novillo wrote: > On 2012-10-31 18:47 , Lawrence Crowl wrote: >> 2012-10-31 Lawrence Crowl >> >> * ebitmap.h: Remove unused. >> * ebitmap.c: Remove unused. >> * Makefile.in: Remove ebitmap.h and ebitmap.c. >> * sbitmap.h (SBITMAP_SIZE_BYTES): Move to source

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-01 Thread Sterling Augustine
Hi Jakub, I would like to get the fission implementation in before stage 1. It has been under review for some time, and is awaiting another round of review now. More info here: http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02684.html Sterling

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-01 Thread Sharad Singhai
On Thu, Nov 1, 2012 at 9:44 AM, Diego Novillo wrote: > On Thu, Nov 1, 2012 at 12:40 PM, Sharad Singhai wrote: >> I found the problem and the following patch fixes it. The issue with >> my testing was that I was only looking at 'FAIL' lines but forgot to >> tally the 'UNRESOLVED' test cases, the r

Re: [patch] Normalize bitmap iteration.

2012-11-01 Thread Lawrence Crowl
On 11/1/12, Diego Novillo wrote: > On 2012-10-31 13:43 , Lawrence Crowl wrote: > > Rename the EXECUTE_IF_SET_IN_SBITMAP macro to > > EXECUTE_IF_SET_IN_BITMAP. Its implementation is now identical to > > that in bitmap.h. To prevent redefinition errors, both definitions > > are now guarded by #ifn

Fwd/Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-11-01 Thread Joern Rennecke
Quoting Richard Sandiford : OK with those changes for the rtl bits. Can't approve the generator stuff though. Can you build machinery maintainers also review gen* and *.def patches, of this patch ( http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02897.html ). or are you strictly limited to *.in

Re: [patch] Normalize more bitmap function names.

2012-11-01 Thread Lawrence Crowl
On 11/1/12, Diego Novillo wrote: > On 2012-10-31 13:41 , Lawrence Crowl wrote: >> This patch normalizes more bitmap function names. >> >>sbitmap.h >> >> TEST_BIT -> bitmap_bit_p >> SET_BIT -> bitmap_set_bit > > I wonder if it wouldn't it be more consistent if TEST_BIT became > bitmap

  1   2   >