RE: [PATCH GCC]Improving register pressure directed hoist

2012-10-30 Thread Bin Cheng
> -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On > Behalf Of Bin Cheng > Sent: Monday, October 29, 2012 2:59 PM > To: gcc-patches@gcc.gnu.org > Subject: [PATCH GCC]Improving register pressure directed hoist > > Hi, > This patch improves

Re: [PATCH] Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-10-30 Thread Teresa Johnson
On Tue, Oct 30, 2012 at 2:33 PM, Steven Bosscher wrote: > On Tue, Oct 30, 2012 at 10:28 PM, Steven Bosscher wrote: >> Hello Teresa, >> >> Could you try this patch for me also? It moves bbpart outside the part >> of the passes pipeline that works in cfglayout mode. > > where's the "unsend" button i

committed: Fix target/52498

2012-10-30 Thread Joern Rennecke
Tested by building cc1 for powerpc64-unknown-linux-gnu X alpha-dec-vms. Committed as obvious. PR target/52498 * vmsdbgout.c (vmsdbgout_write_source_line): Comment out names of last two parameters. Index: vmsdbgout.c

Re: [PR54693] loss of debug info in jump threading and loop ivopts

2012-10-30 Thread Alexandre Oliva
On Oct 30, 2012, Alexandre Oliva wrote: >> BTW, I'd also think that the first loop should set count = 2 if >> the debug stmt already has a non-trivial expression > Good! Will do. Here's the revised patch. Bootstrap completed, test nearly finished. Ok to install if it passes? Replace PHI node

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Teresa Johnson
On Tue, Oct 30, 2012 at 2:31 PM, Teresa Johnson wrote: > On Tue, Oct 30, 2012 at 12:33 PM, Xinliang David Li > wrote: >> On Tue, Oct 30, 2012 at 12:25 PM, Steven Bosscher >> wrote: >>> On Tue, Oct 30, 2012 at 5:59 PM, Teresa Johnson wrote: I will try testing your patch on top of mine with

committed: Fix build for targets that have SECONDARY_MEMORY_NEEDED ignoring CLASS* arguments.

2012-10-30 Thread Joern Rennecke
Build tested on powerpc64-unknown-linux-gnu X microblaze-elf . Committed as obvious. 2012-10-31 Joern Rennecke * lra-constraints.c (choose_split_class): Add ATTRIBUTE_UNUSED to hard_reg_class. Index: lra-constraints.c ===

Re: [patch,libgcc] m32r*rtems* add crtinit.o and crtfinit.o

2012-10-30 Thread Ralf Corsepius
On 10/30/2012 07:03 PM, Ian Lance Taylor wrote: On Tue, Oct 30, 2012 at 12:10 AM, Ralf Corsepius wrote: I would like to apply the patch below to trunk and gcc-4.7-branch. This patch was originalyl submitted by Joel Sherrill back in May (http://gcc.gnu.org/ml/gcc-patches/2012-05/msg01180.html)

Re: [patch] move GIMPLE_TRANSACTION expansion to tmmark pass

2012-10-30 Thread Richard Henderson
On 2012-10-30 05:32, Aldy Hernandez wrote: > + // If we have a ``_transaction_cancel [[outer]]'', there is only > + // one abnormal edge: to the transaction marked OUTER. > + tree arg = gimple_call_arg (stmt, 0); > + if (TREE_CODE (arg) == INTEGER_CST) > + { > + if (TR

[wwwdocs,Java] Remove java/libgcj-platforms.html

2012-10-30 Thread Gerald Pfeifer
When trying to address some issues with this page, I realized it is not linked, and hasn't for probably a decade or more. And the contents is not up-to-date either or more or less covered elsewhere. Sooo, gone it is. Gerald 2012-10-31 Gerald Pfeifer * libgcj-platforms.html: Remove.

[v3] Fix memory leak in forward_list

2012-10-30 Thread Jonathan Wakely
This fixes a memory leak in the allocator-extended move constructor I added to _Fwd_list_base two weeks ago. When the supplied allocator is not equal to the one in the rvalue parameter the rvalue's head pointer was zeroed out, without freeing the nodes it pointed to. This new version leaves the rv

Re: Is libstdcxx-time still experimental?

2012-10-30 Thread Jonathan Wakely
On 26 August 2012 18:20, Jonathan Wakely wrote: >> I'm working on a patch to enable it by default and to define >> this_thread::sleep_xxx and this_thread::yield unconditionally. > > For anyone interested, here's a work-in-progress patch that enables > this_thread::sleep_for() and this_thread::yield

Go patch committed: Add -fgo-relative-import-path option

2012-10-30 Thread Ian Lance Taylor
The go tool, used by many people to build Go programs, handles relative import paths by passing a special option to the compiler. The option is a prefix to use for any relative import. The go tool does this so that programs can be built in a temporary directory and can still find packages importe

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-10-30 Thread Sriraman Tallam
On Tue, Oct 30, 2012 at 12:10 PM, Jason Merrill wrote: > On 10/27/2012 09:16 PM, Sriraman Tallam wrote: >> >> + /* See if there's a match. For functions that are >> multi-versioned, >> +all the versions match. */ >> if (same_type_p (target_fn_type, static_fn_type (

[google] Add attributes: always_patch_for_instrumentation and never_patch_for_instrumentation (issue6821051)

2012-10-30 Thread Harshit Chopra
Adding function attributes: 'always_patch_for_instrumentation' and 'never_patch_for_instrumentation' to always patch a function or to never patch a function, respectively, when given the option -mpatch-functions-for-instrumentation. Additionally, the attribute always_patch_for_instrumentation d

Re: [Patch] Potential fix for PR55033

2012-10-30 Thread Alan Modra
On Tue, Oct 30, 2012 at 02:45:40PM +0100, Sebastian Huber wrote: > On 10/26/2012 02:22 PM, Sebastian Huber wrote: > >Hello, > > > >here is a test case for PR55033. > > > > Is there something wrong with this test case? It compiles well with Alan's > patch. It looks OK to me if you replace your "

Re: [PATCH] Update source location for PRE inserted stmt

2012-10-30 Thread Xinliang David Li
It will make the location info for the newly synthesized stmt more deterministic, I think. David On Tue, Oct 30, 2012 at 4:38 PM, Steven Bosscher wrote: > On Wed, Oct 31, 2012 at 12:00 AM, Dehao Chen wrote: >> This patch aims to improve debugging of optimized code. It ensures >> that PRE inserte

Re: [patch][RFC] Filename based shared library versioning on AIX

2012-10-30 Thread Joseph S. Myers
On Wed, 31 Oct 2012, Michael Haubenwallner wrote: > I would like to introduce filename-based shared library versioning (known as > the "soname" in ELF world) for AIX, activated by the '--enable-aix-soname' > configure flag. Patches adding new configure options should include the changes to insta

Re: [PATCH] Update source location for PRE inserted stmt

2012-10-30 Thread Dehao Chen
Sorry, new patch attached... On Tue, Oct 30, 2012 at 4:38 PM, Steven Bosscher wrote: > On Wed, Oct 31, 2012 at 12:00 AM, Dehao Chen wrote: >> This patch aims to improve debugging of optimized code. It ensures >> that PRE inserted statements have the same source location as the >> statement at the

[C++ Patch] PR 54583

2012-10-30 Thread Paolo Carlini
Hi, this diagnostic issue is about spurious "value computed is not used" warnings with VLAs, emitted by convert_to_void (on the TYPE_SIZE, a MULT_EXPR): the warning is already gated by !TREE_NO_WARNING (expr) thus setting it at the end of build_cplus_array_type seems a rather straightforward

Re: [PATCH] Update source location for PRE inserted stmt

2012-10-30 Thread Steven Bosscher
On Wed, Oct 31, 2012 at 12:00 AM, Dehao Chen wrote: > This patch aims to improve debugging of optimized code. It ensures > that PRE inserted statements have the same source location as the > statement at the insertion point, instead of UNKNOWN_LOCATION. Wrong patch attached. However, is it really

[patch][RFC] Filename based shared library versioning on AIX

2012-10-30 Thread Michael Haubenwallner
Hello! I would like to introduce filename-based shared library versioning (known as the "soname" in ELF world) for AIX, activated by the '--enable-aix-soname' configure flag. Attached patch is for libgcc_s only, patches for libtool have been posted (although without any reply so far) to: http://l

Remove left-overs of RTX_UNCHANGING_P

2012-10-30 Thread Eric Botcazou
In the form of a couple of references in comments from cse.c. Tested on x86_64-suse-linux, applied on the mainline and 4.7 branch. 2012-10-30 Eric Botcazou * cse.c (hash_rtx_cb): Replace RTX_UNCHANGING_P with MEM_READONLY_P in head comment. (hash_rtx): Likewise. --

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-10-30 Thread Sharad Singhai
Hi Jakub, My -fopt-info pass filtering patch (http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02704.html) is being reviewed and I hope to get this in by Nov. 5 for inclusion in gcc 4.8.0. Thanks, Sharad On Mon, Oct 29, 2012 at 10:56 AM, Jakub Jelinek wrote: > Status > == > > I'd like to close

Re: [PR54693] loss of debug info in jump threading and loop ivopts

2012-10-30 Thread Alexandre Oliva
On Oct 30, 2012, Jakub Jelinek wrote: > On Tue, Oct 30, 2012 at 03:51:19PM +0100, Richard Biener wrote: >> + if (!comp) >> + BREAK_FROM_IMM_USE_STMT (imm_iter); >> how does comp magically become NULL_TREE here? > Looks like pasto to me, from the first loop. Mo

Re: dead_debug_local_finish may be used uninit warning

2012-10-30 Thread Alexandre Oliva
On Oct 30, 2012, Roland McGrath wrote: > The only initialization is conditional, but at least the first and last > uses are unconditional. (I don't understand the conditions of the second > use enough to know whether it's always kosher.) Lawrence let me know about that warning earlier today. I

[PATCH] Update source location for PRE inserted stmt

2012-10-30 Thread Dehao Chen
Hi, This patch aims to improve debugging of optimized code. It ensures that PRE inserted statements have the same source location as the statement at the insertion point, instead of UNKNOWN_LOCATION. Bootstrapped on x86_64, and passed gcc regression tests and gdb regression tests. Is it okay for

[Ada] Fix Makefile dependencies of C files

2012-10-30 Thread Eric Botcazou
This will hopefully fix the build failure reported by Diego. Apart from adding missing dependencies, this also removes redundant command lines. Tested on x86_64-suse-linux, applied on the mainline and 4.7 branch. 2012-10-30 Eric Botcazou * gcc-interface/Make-lang.in: Fix and clean

Re: Patch: add @direntry for gcov

2012-10-30 Thread Joseph S. Myers
On Tue, 30 Oct 2012, Tom Tromey wrote: > This patch adds a @direntry for gcov. > > I noticed that it was missing today, when I tried to find the gcov > manual from the info "dir" node. Then I found out that I had filed PR > 50899 for this ages ago. > > Ok? OK. -- Joseph S. Myers jos...@codes

Re: [7/8] BITS_BIG_ENDIAN vs. (zero_extract (const_int ...) ...)

2012-10-30 Thread Eric Botcazou
> gcc/ > * combine.c (simplify_comparison): If BITS_BIG_ENDIAN, always assume > that zero_extracts of const_ints are doing word-sized extractions. This looks plausible. -- Eric Botcazou

Re: [6/8] Simplify make_extraction

2012-10-30 Thread Eric Botcazou
> gcc/ > * combine.c (make_extraction): Remove dead wanted_inner_mode- > and pos_rtx-related code. OK, thanks. -- Eric Botcazou

Re: [5/8] Add narrow_bit_field_mem

2012-10-30 Thread Eric Botcazou
> This patch splits out a fairly common operation: that of narrowing a MEM > to a particular mode and adjusting the bit number accordingly. > > I've kept with "bit_field" rather than "bitfield" for consistency with > the callers, although we do have "bitfield" in "adjust_bitfield_address". My bad

Re: [4/8] Separate reg and mem uses of insv and ext(z)v

2012-10-30 Thread Eric Botcazou
> gcc/ > * expmed.c (store_bit_field_1): Move generation of MEM insvs > to the MEM_P block. > (extract_bit_field_1): Likewise extvs and extzvs. I guess it's in keeping with your earlier changes in these functions. -- Eric Botcazou

Re: [8/8] Rename some powerpc patterns

2012-10-30 Thread David Edelsohn
On Tue, Oct 30, 2012 at 3:44 PM, Richard Sandiford wrote: > The optabs patches that I'm working on treat patterns with names like > "insvsi" and "insvdi" as part of the public target interface. > Those names clash with some existing rs6000.md patterns, so this patch adds > some _internal suffixes

Re: [3/8] Split out insv and ext(z)v code

2012-10-30 Thread Eric Botcazou
> gcc/ > * expmed.c (store_bit_field_using_insv): New function, > split out from... > (store_bit_field_1): ...here. > (extract_bit_field_using_extv): New function, split out from... > (extract_bit_field_1): ...here. No objections to this cleanup. -- Eric Botcazou

Re: [2/8] Remove redundant MAX_MACHINE_MODE tests

2012-10-30 Thread Eric Botcazou
> gcc/ > * expmed.c (store_bit_field_1): Use OP_MODE to check whether an > insv pattern is available. Remove redundant checks for OP_MODE > being MAX_MACHINE_MODE. > (extract_bit_field_1): Remove redundant checks for EXT_MODE being > MAX_MACHINE_MODE. We have had a s

Re: [1/8] Remove redundant BLKmode test

2012-10-30 Thread Eric Botcazou
> gcc/ > * expmed.c (store_bit_field_1): Remove test for BLKmode values. This looks fine to me. -- Eric Botcazou

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-10-30 Thread Sriraman Tallam
Hi Jakub, My function multiversioning patch is being reviewed and I hope to get this in by Nov. 5. Thanks, -Sri. On Mon, Oct 29, 2012 at 10:56 AM, Jakub Jelinek wrote: > Status > == > > I'd like to close the stage 1 phase of GCC 4.8 development > on Monday, November 5th. If you have st

Re: [PATCH] Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-10-30 Thread Teresa Johnson
On Tue, Oct 30, 2012 at 2:33 PM, Steven Bosscher wrote: > On Tue, Oct 30, 2012 at 10:28 PM, Steven Bosscher wrote: >> Hello Teresa, >> >> Could you try this patch for me also? It moves bbpart outside the part >> of the passes pipeline that works in cfglayout mode. > > where's the "unsend" button i

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Steven Bosscher
On Tue, Oct 30, 2012 at 10:31 PM, Teresa Johnson wrote: > In an attempt to provoke the failures I was seeing on a smaller test > case, I tried enabling -freorder-blocks-and-partition by default in my > common.opt file and running through the regression test suite (without > my fixes). But I didn't

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Xinliang David Li
There are not many -- see gcc/testsuite/gcc.dg/tree-prof directory. Under that, 5 cases explicitly set the option. David On Tue, Oct 30, 2012 at 2:31 PM, Teresa Johnson wrote: > On Tue, Oct 30, 2012 at 12:33 PM, Xinliang David Li > wrote: >> On Tue, Oct 30, 2012 at 12:25 PM, Steven Bosscher

Re: [PATCH] Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-10-30 Thread Steven Bosscher
On Tue, Oct 30, 2012 at 10:28 PM, Steven Bosscher wrote: > Hello Teresa, > > Could you try this patch for me also? It moves bbpart outside the part > of the passes pipeline that works in cfglayout mode. where's the "unsend" button if you need it... So, to complete the mail... Could you try this

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Teresa Johnson
On Tue, Oct 30, 2012 at 12:33 PM, Xinliang David Li wrote: > On Tue, Oct 30, 2012 at 12:25 PM, Steven Bosscher > wrote: >> On Tue, Oct 30, 2012 at 5:59 PM, Teresa Johnson wrote: >>> I will try testing your patch on top of mine with our fdo benchmarks. >> >> Thanks. But you should expect a lot of

Re: [PATCH] Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-10-30 Thread Steven Bosscher
Hello Teresa, Could you try this patch for me also? It moves bbpart outside the part of the passes pipeline that works in cfglayout mode.

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-10-30 Thread Lawrence Crowl
On 10/30/12, Diego Novillo wrote: > On Mon, Oct 29, 2012 at 1:56 PM, Jakub Jelinek wrote: >> Status >> == >> >> I'd like to close the stage 1 phase of GCC 4.8 development >> on Monday, November 5th. If you have still patches for new features >> you'd >> like to see in GCC 4.8, please post th

Re: [patch] Apply conditional down cast to cgraph.h et.al.

2012-10-30 Thread Xinliang David Li
Good cleanup! Simple and consistent interfaces are usually self-documenting, and this one is a good step forward. thanks, David On Tue, Oct 30, 2012 at 2:09 PM, Lawrence Crowl wrote: > On 10/30/12, Diego Novillo wrote: >> On Tue, Oct 30, 2012 at 4:53 PM, Lawrence Crowl wrote: >>> On 10/30/12,

Re: [patch] Apply conditional down cast to cgraph.h et.al.

2012-10-30 Thread Lawrence Crowl
On 10/30/12, Diego Novillo wrote: > On Tue, Oct 30, 2012 at 4:53 PM, Lawrence Crowl wrote: >> On 10/30/12, Diego Novillo wrote: >>> >>> So, to use these three functions, the user must define this single >>> 'is_a_helper' routine? Nothing else? >> >> You need to distinguish which kind user. Som

committed: Fix building of targets without SECONDARY_MEMORY_NEEDED

2012-10-30 Thread Joern Rennecke
Build-tested for mmix-knuth-mmixware. Commited as obvious. 2012-10-30 Joern Rennecke * lra-constraints.c (check_secondary_memory_needed_p): Add ATTRIBUTE_UNUSED to parameters. Index: lra-constraints.c === --- lra-

Re: [patch] Apply conditional down cast to cgraph.h et.al.

2012-10-30 Thread Diego Novillo
On Tue, Oct 30, 2012 at 4:53 PM, Lawrence Crowl wrote: > On 10/30/12, Diego Novillo wrote: >> >> So, to use these three functions, the user must define this single >> 'is_a_helper' routine? Nothing else? > > You need to distinguish which kind user. Someone just wanting > to convert does not nee

Re: [patch, mips] Modify mips-mti-linux-gnu build

2012-10-30 Thread Richard Sandiford
"Steve Ellcey " writes: > 2012-10-30 Steve Ellcey > > * config/mips/mti-linux.h (SYSROOT_SUFFIX_SPEC): Change order > and add mabi=64. > (DRIVER_SELF_SPECS): Make -n32 the default on mips64* archs. > * config/mips/t-mti-linux (MULTILIB_OPTIONS): Change order. > (MU

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-10-30 Thread Kenneth Zadeck
jakub, i am hoping to get the rest of my wide integer conversion posted by nov 5. I am under some adverse conditions here: hurricane sandy hit her pretty badly. my house is hooked up to a small generator, and no one has any power for miles around. So far richi has promised to review them.

[patch] Handle NULL in slim RTL dumps of patterns

2012-10-30 Thread Steven Bosscher
Hello, NULL patterns happen in some REG_NOTEs. Will commit as obvious in a bit... Ciao! Steven * sched-vis.c (print_pattern): Handle NULL patterns. Index: gcc/sched-vis.c === --- gcc/sched-vis.c (revision 192992) +++

Re: [patch] Apply conditional down cast to cgraph.h et.al.

2012-10-30 Thread Lawrence Crowl
On 10/30/12, Diego Novillo wrote: > On 2012-10-29 15:01 , Lawrence Crowl wrote: >> On 10/27/12, Marc Glisse wrote: >>> On Fri, 26 Oct 2012, Lawrence Crowl wrote: 2012-10-26 Lawrence Crowl >> >>> missing '>' >> >> Fixed. >> * is-a.h: New. (is_a (U*)): New. Test for is-a re

[patch, mips] Modify mips-mti-linux-gnu build

2012-10-30 Thread Steve Ellcey
This patch makes a few changes to the work I have been doing on the mips-mti-linux-gnu target that I recently added. It adds an -mabi=64 build to MULTILIBS and changes the order of MULTILIB_OPTIONS to be consistent with the mips-mti-elf target. It also makes the N32 ABI the default when compiling

Re: [PATCH, GCC 4.7] Backport fix for PR tree-optimization/53708

2012-10-30 Thread Peter Bergner
On Tue, 2012-10-30 at 20:37 +0100, Jakub Jelinek wrote: > On Tue, Oct 30, 2012 at 02:03:44PM -0500, Peter Bergner wrote: > > Ok, then I'll bootstrap and regtest your suggested change while we > > wait for richi to comment. I'm fine with whatever you and richi > > decide is best. The ObjC guys sho

Patch: add @direntry for gcov

2012-10-30 Thread Tom Tromey
This patch adds a @direntry for gcov. I noticed that it was missing today, when I tried to find the gcov manual from the info "dir" node. Then I found out that I had filed PR 50899 for this ages ago. Ok? Tom 2012-10-30 Tom Tromey PR other/50899 * doc/gcc.texi: Add @direntry

[8/8] Rename some powerpc patterns

2012-10-30 Thread Richard Sandiford
The optabs patches that I'm working on treat patterns with names like "insvsi" and "insvdi" as part of the public target interface. Those names clash with some existing rs6000.md patterns, so this patch adds some _internal suffixes (a bit like fix_truncsi2_internal, for example). AFAICT there are

Re: [PATCH, GCC 4.7] Backport fix for PR tree-optimization/53708

2012-10-30 Thread Jakub Jelinek
On Tue, Oct 30, 2012 at 02:03:44PM -0500, Peter Bergner wrote: > Ok, then I'll bootstrap and regtest your suggested change while we > wait for richi to comment. I'm fine with whatever you and richi > decide is best. The ObjC guys should probably test it though too. > > I assume you think we shou

[7/8] BITS_BIG_ENDIAN vs. (zero_extract (const_int ...) ...)

2012-10-30 Thread Richard Sandiford
Combine tries to optimise comparisons involving: (zero_extract (const_int X) (const_int 1) (var Y)) and so on BITS_BIG_ENDIAN targets it tries gamely to work out what mode X actually has. At the moment it tries reading the mode from operand 1 of extzv, but

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Xinliang David Li
On Tue, Oct 30, 2012 at 12:25 PM, Steven Bosscher wrote: > On Tue, Oct 30, 2012 at 5:59 PM, Teresa Johnson wrote: >> I will try testing your patch on top of mine with our fdo benchmarks. > > Thanks. But you should expect a lot of errors, hopefully you can make > something out of it for Bugzilla. >

[6/8] Simplify make_extraction

2012-10-30 Thread Richard Sandiford
On a change of tack, this tackles some redundant code in combine. It has code to convert a variable bit position to the mode required by the bit position operand to insv, extv or extzv: [A] else if (pos_rtx != 0 && GET_MODE_SIZE (pos_mode) < GET_MODE_SIZE (GET_MODE (pos_rtx))) pos

[5/8] Add narrow_bit_field_mem

2012-10-30 Thread Richard Sandiford
This patch splits out a fairly common operation: that of narrowing a MEM to a particular mode and adjusting the bit number accordingly. I've kept with "bit_field" rather than "bitfield" for consistency with the callers, although we do have "bitfield" in "adjust_bitfield_address". Tested as descri

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Steven Bosscher
On Tue, Oct 30, 2012 at 5:59 PM, Teresa Johnson wrote: > I will try testing your patch on top of mine with our fdo benchmarks. Thanks. But you should expect a lot of errors, hopefully you can make something out of it for Bugzilla. > For the others on the cc list, you may need to include my patch

[4/8] Separate reg and mem uses of insv and ext(z)v

2012-10-30 Thread Richard Sandiford
This patch simply separates out the MEM and non-MEM insv and ext(z)v cases. On it's own, it's probably a wash whether this is an improvement or not, but it makes the optabs patches much easier. Tested as described in the covering note. OK to install? Richard gcc/ * expmed.c (store_bit_

[3/8] Split out insv and ext(z)v code

2012-10-30 Thread Richard Sandiford
This patch splits out the code to handle insv and ext(z)v from store_bit_field_1 and extract_bit_field_1 respectively. I removed "x" prefixes from some of the variables and tried to make the placement of the REG and SUBREG handling more consistent, but there are no behavioural changes. Tested as

[2/8] Remove redundant MAX_MACHINE_MODE tests

2012-10-30 Thread Richard Sandiford
extract_bit_field_1 has a block beginning: /* If OP0 is a memory, try copying it to a register and seeing if a cheap register alternative is available. */ if (ext_mode != MAX_MACHINE_MODE && MEM_P (op0)) { and within it there are tests for whether ext_mode != MAX_MACHINE_MODE. This

[1/8] Remove redundant BLKmode test

2012-10-30 Thread Richard Sandiford
This patch removes what I believe is a redundant check in store_bit_field_1 for whether the value to insert (i.e. the rhs) has BLKmode. We shouldn't see BLKmode values here, and even if we did, the only effect of the test is to fall through to store_fixed_bit_field, which can't handle BLKmode eith

[0/8] Preparing for insv and ext(z)v optabs

2012-10-30 Thread Richard Sandiford
I'm finishing off some patches to allow insv, extv and extzv to be defined as normal direct optabs (such as "insvsi" and "insvdi" rather than just "insv"). This series of patches does some groundwork to make that possible. The patches are not supposed to change the generated code. I checked that

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

2012-10-30 Thread Jason Merrill
On 10/27/2012 09:16 PM, Sriraman Tallam wrote: + /* See if there's a match. For functions that are multi-versioned, +all the versions match. */ if (same_type_p (target_fn_type, static_fn_type (fn))) - matches = tree_cons (fn, NULL_TREE, matches); +

[committed] A global default for SLOW_UNALIGNED_ACCESS

2012-10-30 Thread Richard Sandiford
This patch replaces three separate default definitions of SLOW_UNALIGNED_ACCESS with a single global one. Note that tm.texi requires SLOW_UNALIGNED_ACCESS to be true if STRICT_ALIGNMENT. Tested on x86_64-linux-gnu, powerpc64-linux-gnu and mipsisa64-elf. Applied as obvious. Richard gcc/

Re: [PATCH, GCC 4.7] Backport fix for PR tree-optimization/53708

2012-10-30 Thread Peter Bergner
On Tue, 2012-10-30 at 19:55 +0100, Jakub Jelinek wrote: > On Tue, Oct 30, 2012 at 01:43:33PM -0500, Peter Bergner wrote: > > Commenting on Richard's question from the bugzilla: > > > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53708#c10 > > > > I suppose if attribute((__aligned__)) truly does

Re: Ping / update: RFA: replace #ifdef with if/#if for HAVE_ATTR_*

2012-10-30 Thread Richard Sandiford
I can't approve the whole thing of course, but I like the idea. However... Joern Rennecke writes: > +@deftypevr {Target Hook} bool TARGET_HAVE_CC0 > +@deftypevrx {Target Hook} {bool} TARGET_AUTO_INC_DEC > +@deftypevrx {Target Hook} {bool} TARGET_STACK_REGS > +@deftypevrx {Target Hook} {bool} TARG

Re: [PATCH, GCC 4.7] Backport fix for PR tree-optimization/53708

2012-10-30 Thread Jakub Jelinek
On Tue, Oct 30, 2012 at 01:43:33PM -0500, Peter Bergner wrote: > Commenting on Richard's question from the bugzilla: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53708#c10 > > I suppose if attribute((__aligned__)) truly does just set a minimum alignment > value (and the documentation seems t

Re: [PATCH] Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-10-30 Thread Steven Bosscher
On Tue, Oct 30, 2012 at 6:48 PM, Steven Bosscher wrote: > On Tue, Oct 30, 2012 at 6:20 AM, Teresa Johnson wrote: >> Index: bb-reorder.c >> === >> --- bb-reorder.c(revision 192692) >> +++ bb-reorder.c(working copy) >> @

Re: [PATCH, GCC 4.7] Backport fix for PR tree-optimization/53708

2012-10-30 Thread Peter Bergner
On Tue, 2012-10-30 at 11:58 -0500, Peter Bergner wrote: > I'm hitting the same bug as in PR53708 when compiling GLIBC's dlfcn.c when > vectorization is enabled on powerpc64-linux. A reduced test case is: > > bergner@bns:~/gcc/BUGS> cat foo.i > static void (*const init_array []) (void) > __attr

Non-dominating loop bounds in tree-ssa-loop-niter 2/4

2012-10-30 Thread Jan Hubicka
Hi, this patch implements the second part of planned change - to determine loop bounds based by shortest path discovery. This allows to bound number of iterations on loops with bounds in statements that do not dominate the latch. I originally planned to implement this as part of maybe_lower_iter

Re: [patch] Unify bitmap interface.

2012-10-30 Thread Lawrence Crowl
On 10/30/12, Diego Novillo wrote: > On Oct 30, 2012 Bin.Cheng wrote: > > Just one question: Should we change the name of functions > > "sbitmap_intersection_of_succs/sbitmap_intersection_of_preds/ > > sbitmap_union_of_succs/sbitmap_union_of_preds" too? It might > > be a little confusing that sbit

Re: [PATCH] Replace const_vector with match_operand in sse.md

2012-10-30 Thread Uros Bizjak
On Tue, Oct 30, 2012 at 6:53 PM, Andrey Turetskiy wrote: > Thanks for explanation, I understand it. > I fixed issue which you marked. Changelog is unchanged. > >>> I changed the patch according Uros' remarks. Please, have a look. >>> >>> Changelog: >>> >>> 2012-10-30 Andrey Turetskiy >>> >>>

Re: [patch,libgcc] m32r*rtems* add crtinit.o and crtfinit.o

2012-10-30 Thread Ian Lance Taylor
On Tue, Oct 30, 2012 at 12:10 AM, Ralf Corsepius wrote: > > I would like to apply the patch below to trunk and gcc-4.7-branch. > > This patch was originalyl submitted by Joel Sherrill back in May > (http://gcc.gnu.org/ml/gcc-patches/2012-05/msg01180.html), > but had never received any feedback. >

Re: [PATCH] Replace const_vector with match_operand in sse.md

2012-10-30 Thread Andrey Turetskiy
Thanks for explanation, I understand it. I fixed issue which you marked. Changelog is unchanged. --- Best regards, Andrey Turetskiy On Tue, Oct 30, 2012 at 7:40 PM, Uros Bizjak wrote: > On Tue, Oct 30, 2012 at 3:47 PM, Andrey Turetskiy > wrote: >> I changed the patch according Uros' remarks. Pl

Re: [PATCH] Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-10-30 Thread Steven Bosscher
On Tue, Oct 30, 2012 at 6:20 AM, Teresa Johnson wrote: > Index: bb-reorder.c > === > --- bb-reorder.c(revision 192692) > +++ bb-reorder.c(working copy) > @@ -2188,6 +2188,8 @@ insert_section_boundary_note (void) >

Re: [PATCH] Fix debug info for expr and jump stmt

2012-10-30 Thread Dehao Chen
> gcc/ChangeLog: > 2012-10-25 Dehao Chen > > * tree-eh.c (do_return_redirection): Set location for jump statement. > (do_goto_redirection): Likewise. > (frob_into_branch_around): Likewise. > (lower_try_finally_nofallthru): Likewise. > (lower_try_finally_co

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Teresa Johnson
On Tue, Oct 30, 2012 at 9:26 AM, Steven Bosscher wrote: > Hello, > > Hot/cold partitioning is apparently a hot topic all of a sudden, which > is a good thing of course, because it's in need of some TLC. > > The attached patch adds another check the RTL cfg checking > (verify_flow_info) for the par

[PATCH, GCC 4.7] Backport fix for PR tree-optimization/53708

2012-10-30 Thread Peter Bergner
I'm hitting the same bug as in PR53708 when compiling GLIBC's dlfcn.c when vectorization is enabled on powerpc64-linux. A reduced test case is: bergner@bns:~/gcc/BUGS> cat foo.i static void (*const init_array []) (void) __attribute__ ((section (".init_array"), aligned (sizeof (void *)), used))

Re: [PATCH] Fix debug info for expr and jump stmt

2012-10-30 Thread Dehao Chen
> The debugger isn't the only consumer of debug info, and other tools might need > a finer granularity than a GIMPLE location, so clearing EXPR_LOCATION to work > around a debug info size issue seems very short-sighted (to say the least). Hi, Eric, There might be some misunderstanding here. Clear

Re: [PING^2] [C++ PATCH] Add overflow checking to __cxa_vec_new[23]

2012-10-30 Thread Florian Weimer
On 10/30/2012 05:17 PM, Paolo Carlini wrote: Sorry, I don't know the code well enough to review your patch, but since I'm in CC, I still don't understand why, instead of adding a full libstdc++ testcase you are extending a C++ testcase, in old-deja even, normally considered legacy. AFAIK, th

Re: [PATCH] Fix debug info for expr and jump stmt

2012-10-30 Thread Dehao Chen
BTW, one thing I found confusing is that in expr.c, some code is for frontend, while some are for rtl. Shall we separate them into two files? And we don't expect to see EXPR_LOCATION in the rtl side. Thanks, Dehao

Re: [PATCH] Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)

2012-10-30 Thread Steven Bosscher
On Tue, Oct 30, 2012 at 8:49 AM, Matthew Gretton-Dann wrote: > On 30 October 2012 05:20, Teresa Johnson wrote: >> Index: cfgrtl.c >> === >> --- cfgrtl.c(revision 192692) >> +++ cfgrtl.c(working copy) >> @@ -912,7 +912,8 @@ rtl_

Re: [PATCH] Fix debug info for expr and jump stmt

2012-10-30 Thread Dehao Chen
On Tue, Oct 30, 2012 at 8:29 AM, Richard Biener wrote: > On Tue, Oct 30, 2012 at 4:21 PM, Jakub Jelinek wrote: >> On Tue, Oct 30, 2012 at 04:15:38PM +0100, Richard Biener wrote: >>> So maybe TER (well, those looking up the stmt) should pick the location >>> from the TERed statement properly then?

[PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Steven Bosscher
Hello, Hot/cold partitioning is apparently a hot topic all of a sudden, which is a good thing of course, because it's in need of some TLC. The attached patch adds another check the RTL cfg checking (verify_flow_info) for the partitioning: A hot block can never be dominated by a cold block (becaus

Re: [PING^2] [C++ PATCH] Add overflow checking to __cxa_vec_new[23]

2012-10-30 Thread Paolo Carlini
Hi, Florian Weimer ha scritto: >Ping? > >Patch is at: http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01416.html Sorry, I don't know the code well enough to review your patch, but since I'm in CC, I still don't understand why, instead of adding a full libstdc++ testcase you are extending a C++ t

Re: RFA: hookize ADJUST_INSN_LENGTH (Was: RFA: Add lock_lenth attribute to support the ARC port)

2012-10-30 Thread Joern Rennecke
Quoting Richard Biener : Apart from the iteration_threshold the hookization would be straight-forward. Now I cannot decipher from the patch what functional change it introduces ;) The only change occurs if we reach an iteration count of MAX_INT iterations - which should already be indicative o

Re: [PATCH] pass filtering for -fopt-info

2012-10-30 Thread Xinliang David Li
On Tue, Oct 30, 2012 at 8:28 AM, Richard Biener wrote: > On Tue, Oct 30, 2012 at 9:21 AM, Sharad Singhai wrote: >> As per discussion in http://gcc.gnu.org/ml/gcc/2012-10/msg00225.html, >> I have added the -fopt-info pass filtering in the attached patch. >> >> The basic idea is that there are opti

[PING^2] [C++ PATCH] Add overflow checking to __cxa_vec_new[23]

2012-10-30 Thread Florian Weimer
On 09/17/2012 12:54 PM, Florian Weimer wrote: On 09/17/2012 12:15 PM, Paolo Carlini wrote: Hi, On 09/17/2012 11:51 AM, Florian Weimer wrote: On 08/21/2012 12:37 PM, Florian Weimer wrote: I don't think there are any callers out there, but let's fix this for completeness. A compiler emitting c

Re: [PATCH] Fix debug info for expr and jump stmt

2012-10-30 Thread Eric Botcazou
> I'd say either we should do the TREE_BLOCK setting on all non-shareable > trees during gimple-low and clear the block (but then likely whole > location?; it doesn't make sense to say in the debugger that something > has certain source location when you can't print variables declared in that > loc

Re: [PATCH] pass filtering for -fopt-info

2012-10-30 Thread Xinliang David Li
On Tue, Oct 30, 2012 at 1:21 AM, Sharad Singhai wrote: > As per discussion in http://gcc.gnu.org/ml/gcc/2012-10/msg00225.html, > I have added the -fopt-info pass filtering in the attached patch. > > The basic idea is that there are optimization pass groups and a user > can selectively enable dumps

Re: [PATCH] Replace const_vector with match_operand in sse.md

2012-10-30 Thread Uros Bizjak
On Tue, Oct 30, 2012 at 3:47 PM, Andrey Turetskiy wrote: > I changed the patch according Uros' remarks. Please, have a look. > > Changelog: > > 2012-10-30 Andrey Turetskiy > >* config/i386/i386.c (bdesc_args): Rename CODE_FOR_avx2_umulhrswv16hi3 > to >CODE_FOR_avx2_pmulhrswv16h

Re: PATCH: PR rtl-optimization/55093: [4.8 Regression] [x32] -maddress-mode=long failed

2012-10-30 Thread Vladimir Makarov
On 10/30/2012 06:34 AM, Richard Sandiford wrote: "H.J. Lu" writes: LRA has if (REG_P (reg) && (ep = get_elimination (reg)) != NULL) { rtx to_rtx = replace_p ? ep->to_rtx : ep->from_rtx; if (! replace_p) { offset += (ep->offset

Re: [PATCH] Fix debug info for expr and jump stmt

2012-10-30 Thread Richard Biener
On Tue, Oct 30, 2012 at 4:21 PM, Jakub Jelinek wrote: > On Tue, Oct 30, 2012 at 04:15:38PM +0100, Richard Biener wrote: >> So maybe TER (well, those looking up the stmt) should pick the location >> from the TERed statement properly then? > > Perhaps, but Micha's patch doesn't do that. > But in tha

Re: [PATCH] pass filtering for -fopt-info

2012-10-30 Thread Richard Biener
On Tue, Oct 30, 2012 at 9:21 AM, Sharad Singhai wrote: > As per discussion in http://gcc.gnu.org/ml/gcc/2012-10/msg00225.html, > I have added the -fopt-info pass filtering in the attached patch. > > The basic idea is that there are optimization pass groups and a user > can selectively enable dumps

Re: [PATCH] Fix debug info for expr and jump stmt

2012-10-30 Thread Jakub Jelinek
On Tue, Oct 30, 2012 at 04:15:38PM +0100, Richard Biener wrote: > So maybe TER (well, those looking up the stmt) should pick the location > from the TERed statement properly then? Perhaps, but Micha's patch doesn't do that. But in that case IMHO it still would help to set all expr locations to UNK

  1   2   >