Re: [bootstrap] Tentative fix for PR 54281

> From: Diego Novillo > Date: Thu, 16 Aug 2012 21:12:56 +0200 > On 12-08-16 15:00 , Diego Novillo wrote: > This is the patch I'm currently testing. I need someone with a very old > toolchain (4.1 or earlier) to also give this a try (the original problem > does not occur in g++ more recent than

Re: combine permutations in gimple

On Wed, 15 Aug 2012, Richard Guenther wrote: > On Wed, Aug 15, 2012 at 1:56 PM, Ramana Radhakrishnan > wrote: > > Of-course, the problem here is this change of semantics with the hook > > TARGET_VEC_PERM_CONST_OK. Targets were expanding to generic permutes > > with constants in the *absence* of be

[PATCH] AIX libgcc.map missing symbols

When libgcc was moved to its own directory, reorganized and refactored, the tmakefile fragment for AIX was broken. t-ibm-ldouble must come after t-slibgcc-aix because t-ibm-ldouble appends to SHLIB_MAPFILES Makefile variable and t-slibgcc-aix. This omitted ibm-ldouble support symbols from the lib

Re: [PATCH, ARM] Don't pull in unwinder for 64-bit division routines

On Thu, Aug 16, 2012 at 11:56 AM, Ramana Radhakrishnan wrote: > On 07/24/12 13:27, Julian Brown wrote: >> >> On Fri, 20 Jul 2012 11:15:27 +0100 >> Julian Brown wrote: >> >>> Anyway: this revised version of the patch removes the strange libgcc >>> Makefile-fragment changes, the equivalent of which

Re: [PATCH, MIPS] DSP ALU scheduling

On 08/16/2012 01:27 PM, Richard Sandiford wrote: Sandra Loosemore writes: @@ -569,7 +569,7 @@ UNSPEC_DPAU_H_QBL))] "ISA_HAS_DSP&& !TARGET_64BIT" "dpau.h.qbl\t%q0,%2,%3" - [(set_attr "type" "imadd") + [(set_attr "type" "dspmac") (set_attr "mode" "SI")]) (d

Re: [Google 4.7] Generate pubnames compatible with gdb-index version 7. (issue6459099)

> +/* Output a single entry in the pubnames table. */ > + > +static void > +output_pubname (dw_offset die_offset, pubname_entry *entry) For this function, I'd suggest a comment to the effect that the logic is lifted from GDB. > @@ -2424,6 +2424,10 @@ gpubnames > Common RejectNegative Var(debug_

Re: [bootstrap] Tentative fix for PR 54281

On Thu, Aug 16, 2012 at 12:12 PM, Diego Novillo wrote: > > This is the patch I'm currently testing. I need someone with a very old > toolchain (4.1 or earlier) to also give this a try (the original problem > does not occur in g++ more recent than 4.1). > > > Thanks. Diego. > > diff --git a/gcc/C

[Google 4.7] Generate pubnames compatible with gdb-index version 7. (issue6459099)

The enclosed patch adds a new option -ggnu-pubnames to solve the problem that current pubnames don't supply enough information for Gold to generate a version 7 gdb index. The patch encodes the flag byte from gdb-index version 7, and saves it between the offset and name in the pubtype. We can't gen

Re: Interaction between first stage build with g++ and $PATH

On Aug 15, 2012, at 10:17 PM, Gary Funck wrote: > 1. I have "." on $PATH. Yeah, the problem is we build up g++ instead of xg++; gcc builds up as xgcc for a reason. Search xgcc, and g++, and modify g++ to look like xgcc. . is never a security problem, if you never cd to a directory that you don'

Committed: add cris-* and crisv32-* to lists in sync_int_long and sync_char_short

See also PR54261 and gcc.dg/torture/pr54261-1.c. I was about to also add an #elif defined (__CRIS__) in cas_int (which commendably uses __GCC_HAVE_SYNC_COMPARE_AND_SWAP_4 but nevertheless needs to be manually enabled because of PR54266), but cas_int only guards test-cases that grep dumps for tree/

Re: [PATCH] Set correct source location for deallocator calls

ping. Thanks, Dehao On Fri, Aug 10, 2012 at 8:38 PM, Dehao Chen wrote: > New patch attached. > > Bootstrapped and passed GCC regression tests. > > Ok for trunk? > > Thanks, > Dehao > > gcc/ChangeLog > 2012-08-07 Dehao Chen > > * tree-eh.c (goto_queue_node): New field. > (

[PATCH] PR c++/53540 - using fails to be equivalent to typedef

Hello, In the example of this problem report, during the substituting of int into 'function', tsubst_aggr_type fails for the alias ctxt1. This is because TYPE_TEMPLATE_INFO looks for the TEMPLATE_INFO of the ctxt1 alias at the wrong place and was wrongly finding it to be NULL. Namely, it was look

Re: [SH] PR 54236 - Improve addc/subc utilization

Oleg Endo wrote: > The attached patch improves the utilization of the addc and subc > instructions as mentioned in the PR. > Tested on rev 190396 with > make -k check RUNTESTFLAGS="--target_board=sh-sim > \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}" > > and no new failures. > I'

Re: [SH] PR 39423

Oleg Endo wrote: > This fixes the issue mentioned in the PR's comment #29. > Tested on rev 190396 with > make -k check RUNTESTFLAGS="--target_board=sh-sim > \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}" > > and no new failures. > OK? OK. Regards, kaz

Re: [SH] PR 54089

Oleg Endo wrote: > This fixes the case where a dynamic shift would expand into a P27 shift > sequence that clobbers T_REG, which would result in wrong code. > Tested on rev 190396 with > make -k check RUNTESTFLAGS="--target_board=sh-sim > \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-m

Re: [RFA:] fix PR54261, reverse operator emitted for compare_and_swap-libfunc targets

> From: Hans-Peter Nilsson > Date: Wed, 15 Aug 2012 02:20:37 +0200 > I looked around and it seems only cris{v32,}-axis-linux-gnu is > affected. Still, besides that target, for a 4.7/r189762 import > and c/c++ testing, boot+regtest in progress for x86_64-linux and > cross-test for cris-axis-elf.

Re: [C PATCH] -Wsizeof-pointer-memaccess warning

On Thu, 16 Aug 2012, Jakub Jelinek wrote: > Hi! > > On Wed, Aug 15, 2012 at 04:29:55PM +, Joseph S. Myers wrote: > > On Wed, 15 Aug 2012, Jakub Jelinek wrote: > > > > > I was mainly interested in whether such an approach is acceptable, or > > > whether I need to stop evaluating sizeof right

[committed] TILE-Gx/TILEPro: add stub header file

This patch adds a stub header file "feedback.h," needed to compile glibc and linux. Walter Index: gcc/config.gcc === --- gcc/config.gcc (revision 190448) +++ gcc/config.gcc (working copy) @@ -2440,6 +2440,7 @@ tilegx-*-lin

Re: LEA-splitting improvement patch.

On Wed, Aug 15, 2012 at 12:58 PM, Yuri Rumyantsev wrote: > I send you new patch with fixed space/tab alignments. > > About your comment. > > It is more optimal to put adding of constant before adding of the > register only for case when 3 instructions must be generated to split > lea. In all othe

Re: Reproducible gcc builds, gfortran, and -grecord-gcc-switches

On Thu, Aug 16, 2012 at 06:59:09PM +0200, Simon Baldwin wrote: > On 16 August 2012 16:40, Michael Matz wrote: > > > > ,,, > > > > Do you have considered to use a new option flag (usable in the .opt files) > > instead of a langhook? I.e. add a flag cl_dont_record to cl_option, a > > string Norecor

Re: [PATCH, ARM] Don't pull in unwinder for 64-bit division routines

On Thu, 16 Aug 2012 19:56:52 +0100 Ramana Radhakrishnan wrote: > On 07/24/12 13:27, Julian Brown wrote: > > On Fri, 20 Jul 2012 11:15:27 +0100 > > Julian Brown wrote: > > > >> Anyway: this revised version of the patch removes the strange > >> libgcc Makefile-fragment changes, the equivalent of w

Re: [PATCH, MIPS] DSP ALU scheduling

Sandra Loosemore writes: > @@ -569,7 +569,7 @@ > UNSPEC_DPAU_H_QBL))] >"ISA_HAS_DSP && !TARGET_64BIT" >"dpau.h.qbl\t%q0,%2,%3" > - [(set_attr "type" "imadd") > + [(set_attr "type" "dspmac") > (set_attr "mode" "SI")]) > > (define_insn "mips_dpau_h_qbr" > @@ -580

Re: [bootstrap] Tentative fix for PR 54281

On 12-08-16 15:00 , Diego Novillo wrote: On 12-08-16 14:46 , Joseph S. Myers wrote: On Thu, 16 Aug 2012, Diego Novillo wrote: diff --git a/gcc/intl.h b/gcc/intl.h index c4db354..745fefd 100644 --- a/gcc/intl.h +++ b/gcc/intl.h @@ -27,8 +27,8 @@ # define setlocale(category, locale) (locale)

Re: C++ PR 54197: lifetime of reference not properly extended

On Wed, Aug 15, 2012 at 9:52 AM, Ollie Wild wrote: > (Adding other C++ maintainers in case someone else wants to have a stab.) > > Ping? I consider Jason to be the expert on this; so let see what he says. -- Gaby > > Ollie > > > On Mon, Aug 13, 2012 at 4:01 PM, Ollie Wild wrote: >> >> On Mon,

[SH] PR 54236 - Improve addc/subc utilization

Hello, The attached patch improves the utilization of the addc and subc instructions as mentioned in the PR. Tested on rev 190396 with make -k check RUNTESTFLAGS="--target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}" and no new failures. I've also briefly checked th

Re: Merge C++ conversion into trunk (4/6 - hash table rewrite)

On 8/16/12, Richard Guenther wrote: > On Wed, 15 Aug 2012, Lawrence Crowl wrote: > > On 8/15/12, Richard Henderson wrote: > > > On 2012-08-15 07:29, Richard Guenther wrote: > > > > + typedef typename Element::Element_t Element_t; > > > > > > Can we use something less ugly than Element_t? > > >

Re: [bootstrap] Tentative fix for PR 54281

On 12-08-16 14:46 , Joseph S. Myers wrote: On Thu, 16 Aug 2012, Diego Novillo wrote: diff --git a/gcc/intl.h b/gcc/intl.h index c4db354..745fefd 100644 --- a/gcc/intl.h +++ b/gcc/intl.h @@ -27,8 +27,8 @@ # define setlocale(category, locale) (locale) #endif -#ifdef ENABLE_NLS #include +#

Re: [PATCH, ARM] Don't pull in unwinder for 64-bit division routines

On 07/24/12 13:27, Julian Brown wrote: On Fri, 20 Jul 2012 11:15:27 +0100 Julian Brown wrote: Anyway: this revised version of the patch removes the strange libgcc Makefile-fragment changes, the equivalent of which have since been incorporated into mainline GCC now anyway, so the patch is somew

Re: [bootstrap] Tentative fix for PR 54281

On Thu, 16 Aug 2012, Diego Novillo wrote: > diff --git a/gcc/intl.h b/gcc/intl.h > index c4db354..745fefd 100644 > --- a/gcc/intl.h > +++ b/gcc/intl.h > @@ -27,8 +27,8 @@ > # define setlocale(category, locale) (locale) > #endif > > -#ifdef ENABLE_NLS > #include > +#ifdef ENABLE_NLS I'm not s

[SH] PR 39423

Hello, This fixes the issue mentioned in the PR's comment #29. Tested on rev 190396 with make -k check RUNTESTFLAGS="--target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}" and no new failures. OK? Cheers, Oleg ChangeLog: PR target/39423 * config/sh

Re: [bootstrap] Tentative fix for PR 54281

I have reverted my original fix and propose this one. My fix caused build failures in Ada (which includes system.h inside 'extern "C"' blocks) and it also breaks in-tree isl/cloog. Richi, I've tried building my own 4.1, but it doesn't build on my system. Could you try this patch? It include

[lra] patch to remove lra-equivs.c

File lra-equivs.c was removed as not used anymore. The patch was committed as rev. 190448. 2012-08-16 Vladimir Makarov * lra-equivs.c: Remove.

Re: C++ PR 54197: lifetime of reference not properly extended

On Thu, Aug 16, 2012 at 12:12 PM, Diego Novillo wrote: > > I wonder if it wouldn't make more sense to iterate until we find the > rightmost element in a compound_expr chain, but I don't think they are > neither common nor long enough to matter. Yeah, that was my thinking. I can certainly do what

[SH] PR 54089

Hello, This fixes the case where a dynamic shift would expand into a P27 shift sequence that clobbers T_REG, which would result in wrong code. Tested on rev 190396 with make -k check RUNTESTFLAGS="--target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}" and no new fail

Re: [bootstrap] Tentative fix for PR 54281

On Thu, Aug 16, 2012 at 1:50 PM, Magnus Fromreide wrote: > On Thu, Aug 16, 2012 at 07:55:51AM -0400, Diego Novillo wrote: >> Richi, this implements your idea for fixing PR 54281. I don't >> have an old enough compiler. Could you please test it in your >> system? >> >> I debated whether to remove

Re: [bootstrap] Tentative fix for PR 54281

On Thu, Aug 16, 2012 at 07:55:51AM -0400, Diego Novillo wrote: > Richi, this implements your idea for fixing PR 54281. I don't > have an old enough compiler. Could you please test it in your > system? > > I debated whether to remove the GENERATOR_FILE predicate from the > inclusion (some files i

PATCH: PR target/20020: 128 bit structs not targeted to TImode

Hi, My email sent to gcc-patches@gcc.gnu.org was bounced as spam. I am resending it. This patch defines both MAX_FIXED_MODE_SIZE and MEMBER_TYPE_FORCES_BLK for i386. MEMBER_TYPE_FORCES_BLK is needed so that we always put union with XFmode field in BLKmode. This patch doesn't change any ABI sin

PATCH: Add x32 support to config.guess

Hi, GCC on Linux/x86-64 may be configured for x32: https://sites.google.com/site/x32abi/ by default and the Linux/x32 target should be x86_64-VENDOR-linux-gnux32. This patch adds x32 support to config.guess. OK to install? Thanks. H.J. --- 2012-08-16 H.J. Lu * config.guess (x86_6

Re: [google] Modification of gcov pmu format to reduce gcda size bloat (issue 6427063)

Hi David, Could you take a look at the patch I mailed to gcc-patches when you get a chance? Thanks, Chris http://codereview.appspot.com/6427063/

Re: C++ PR 54197: lifetime of reference not properly extended

On Wed, Aug 15, 2012 at 10:52 AM, Ollie Wild wrote: > (Adding other C++ maintainers in case someone else wants to have a stab.) > > Ping? > > Ollie I wonder if it wouldn't make more sense to iterate until we find the rightmost element in a compound_expr chain, but I don't think they are neither c

Re: Reproducible gcc builds, gfortran, and -grecord-gcc-switches

On 16 August 2012 16:40, Michael Matz wrote: > > ,,, > > Do you have considered to use a new option flag (usable in the .opt files) > instead of a langhook? I.e. add a flag cl_dont_record to cl_option, a > string Norecord for the .opt files, some handling for it in > opt-functions.awk and the lik

Re: Merge C++ conversion into trunk

On 12-08-16 12:50 , Iain Sandoe wrote: On 14 Aug 2012, at 19:59, Diego Novillo wrote: After the merge is in, I will send an announcement and request major branch merges to wait for another 24 hrs to allow testers the chance to pick up this merge. The following patch (mimicking what has bee

Re: Merge C++ conversion into trunk

On 14 Aug 2012, at 19:59, Diego Novillo wrote: > > After the merge is in, I will send an announcement and request major branch > merges to wait for another 24 hrs to allow testers the chance to pick up this > merge. The following patch (mimicking what has been done elsewhere at r190402) resto

Re: RFA: Support infinity, NaN, and denormalized numbers in floatformat.c

Ian Lance Taylor writes: > @@ -306,8 +359,18 @@ floatformat_to_double (fmt, from, to) >mant = get_field (ufrom, fmt->byteorder, fmt->totalsize, >mant_off, mant_bits); > > - dto += ldexp ((double)mant, exponent - mant_bits); > - exponent -= mant_bits; >

Ping^2 Re: Add --no-sysroot-suffix driver option

Ping^2. This patch is still pending review. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] Free redirect_callers vector in tree-sra.c

On Thu, 16 Aug 2012, Richard Guenther wrote: > > I noticed we leak the redirect_callers vector in SRA and also noticed > we compute it and then immediately re-compute cgraph edges which > looks weird to me. > > Thus the following patch which frees the vector and makes its lifetime > more obvious

[PATCH, MIPS] add new peephole for 74k dspr2

This patch adds a peephole optimization to use a clever trick to zero-initialize the two halves of an accumulator register with one instruction instead of a mtlo/mthi pair. OK to check in? -Sandra 2012-08-16 Sandra Loosemore Julian Brown MIPS Technologies, Inc.

Re: [PATCH] Decrease integer-share-limit

On Thu, Aug 16, 2012 at 04:44:03PM +0200, Richard Guenther wrote: > On Thu, 16 Aug 2012, Paolo Carlini wrote: > > On 08/16/2012 03:39 PM, Richard Guenther wrote: > > > This decreases the integer-share-limit to make sure the TREE_VEC we > > > allocate for the small cached integers has a reasonable s

Re: Merge C++ conversion into trunk (4/6 - hash table rewrite)

On Thu, 16 Aug 2012, Paolo Carlini wrote: > Hi, > > I have another "out of curiosity"-type question ;) > > On 08/16/2012 11:19 AM, Richard Guenther wrote: > > > > ! > > ! template > > ! inline int > > ! pointer_hash::equal (const T *existing, > > ! const T *candidate) >

Re: Merge C++ conversion into trunk (4/6 - hash table rewrite)

Hi, I have another "out of curiosity"-type question ;) On 08/16/2012 11:19 AM, Richard Guenther wrote: ! ! template ! inline int ! pointer_hash::equal (const T *existing, ! const T *candidate) ! { ! return existing == candidate; } are these uses in the new cod

Re: [PATCH] Decrease integer-share-limit

On Thu, 16 Aug 2012, Paolo Carlini wrote: > Hi, > > On 08/16/2012 03:39 PM, Richard Guenther wrote: > > This decreases the integer-share-limit to make sure the TREE_VEC we > > allocate for the small cached integers has a reasonable size for > > our GC memory allocator. > Out of curiosity (just in

Re: [PATCH 6/7] rs6000: Remove -mabi=ieeelongdouble.

There are some problems with it: - On at least 4.6 and later, it crashes the compiler together with -m64; - On older versions, it generates incorrect code together with -m64; - Supposedly it doesn't actually work on 32-bit either, on the glibc side; - It isn't listed in --target-help, becaus

Re: PATCH: Replace target MEMBER_TYPE_FORCES_BLK macro with a target hook

On Thu, Aug 16, 2012 at 3:09 AM, Richard Guenther wrote: > On Thu, Aug 16, 2012 at 1:50 AM, H.J. Lu wrote: >> Hi, >> >> This patch replaces MEMBER_TYPE_FORCES_BLK with a target hook. I >> also pass the type to the target hook in addition to field, which will >> be used by i386 backend for >> >>

Re: [PATCH] Decrease integer-share-limit

Hi, On 08/16/2012 03:39 PM, Richard Guenther wrote: This decreases the integer-share-limit to make sure the TREE_VEC we allocate for the small cached integers has a reasonable size for our GC memory allocator. Out of curiosity (just in case you hav two spare minutes) do you have any idea why th

Re: [PATCH] Set current_function_decl in {push,pop}_cfun and push_struct_function

On Thu, Aug 16, 2012 at 10:21 AM, Michael Matz wrote: > Hi, > > On Thu, 16 Aug 2012, Diego Novillo wrote: > >> I like this approach, particularly since it would be used in contexts >> where there is no simpler scheme. I'm not crazy about overloading >> unused fields, but it's fine if we wrap it a

Re: [patch] PR54146 - rewrite rewrite_into_loop_closed_ssa

On Thu, Aug 16, 2012 at 4:24 PM, Michael Matz wrote: > Btw, then the comment is still wrong. You're returning the innermost > common outer loop, not the outermost (which would be trivial). I'll fix the comment. Ciao! Steven

Re: [patch] PR54146 - rewrite rewrite_into_loop_closed_ssa

Hi, On Thu, 16 Aug 2012, Steven Bosscher wrote: > 2. In find_sibling_superloop the first step is to align the loop depth: >... > 3. Now that USE_LOOP and DEF_LOOP are at the same nesting depth, Ah, that's the crucial point I missed, the while loops starts out with loops at the same depth; yes

[PATCH] Add working-set size and hotness information to fdo summary (issue6465057)

This is a revision of my earlier patch to add working set information to the gcov program summary based on discussions between Honza, David and I and approved with changes by Honza in this earlier thread on the first patch: http://gcc.gnu.org/ml/gcc-patches/2012-07/msg01412.html I plan to commit

Re: [PATCH] Set current_function_decl in {push,pop}_cfun and push_struct_function

Hi, On Thu, 16 Aug 2012, Diego Novillo wrote: > I like this approach, particularly since it would be used in contexts > where there is no simpler scheme. I'm not crazy about overloading > unused fields, but it's fine if we wrap it around a special accessor. I > suppose we could also make ENTR

[PATCH] Free redirect_callers vector in tree-sra.c

I noticed we leak the redirect_callers vector in SRA and also noticed we compute it and then immediately re-compute cgraph edges which looks weird to me. Thus the following patch which frees the vector and makes its lifetime more obvious. Queued for testing. Richard. 2012-08-16 Richard Guenth

Re: [patch] PR54146 - rewrite rewrite_into_loop_closed_ssa

On Thu, Aug 16, 2012 at 2:56 PM, Michael Matz wrote: > Hi, > > On Wed, 15 Aug 2012, Steven Bosscher wrote: > > Please convince me that this : > > +/* Return the outermost superloop LOOP of USE_LOOP that is a superloop of > + both DEF_LOOP and USE_LOOP. */ > +static inline struct loop * > +find_

Re: [bootstrap] Tentative fix for PR 54281

On 12-08-16 09:08 , Richard Guenther wrote: On Thu, 16 Aug 2012, Diego Novillo wrote: Richi, this implements your idea for fixing PR 54281. I don't have an old enough compiler. Could you please test it in your system? I debated whether to remove the GENERATOR_FILE predicate from the inclusio

[PATCH] Decrease integer-share-limit

This decreases the integer-share-limit to make sure the TREE_VEC we allocate for the small cached integers has a reasonable size for our GC memory allocator. With the current value (256) and a reduced testcase from PR54146 we see tree.c:1224 (build_int_cst_wide) 40: 0.0%

Re: [PATCH 6/7] rs6000: Remove -mabi=ieeelongdouble.

On Wed, Aug 15, 2012 at 6:29 PM, Segher Boessenkool wrote: > There are some problems with it: > - On at least 4.6 and later, it crashes the compiler together with -m64; > - On older versions, it generates incorrect code together with -m64; > - Supposedly it doesn't actually work on 32-bit either,

[4.6] Add /lib to Solaris default library search path

On recent Solaris 11 Update 1 builds, the 4.6 branch failed to bootstrap in libjava: the configure test for connect failed since libsocket.so indirectly depends on libcryptoutil.so which only lives in /lib, not /usr/lib: configure:20311: checking for connect in -lsocket configure:20339: /var/gcc/r

Re: [bootstrap] Tentative fix for PR 54281

On 12-08-16 09:08 , Richard Guenther wrote: It fixes it. Thus, ok from my side (if your testing succeeds). Worked here too. Committed to trunk. Diego.

Re: [PATCH] Set current_function_decl in {push,pop}_cfun and push_struct_function

On Thu, Aug 16, 2012 at 8:40 AM, Michael Matz wrote: > Hi, > > On Thu, 16 Aug 2012, Richard Guenther wrote: > >> If dumping a statement needs the containing function then we need to >> either pass that down, provide a way to get from statement to function, >> or stop requiring the function. Makin

[PATCH] Fix memleaks obvious from PR54146

This fixes some memleaks which look obvious when looking at -fmem-report of PR54146. Most important the tree-ssa-loop-im.c leak. Bootstrap and regtest ongoing on x86_64-unknown-linux-gnu. Richard. 2012-08-16 Richard Guenther PR middle-end/54146 * tree-ssa-loop-niter.c (find

Re: [bootstrap] Tentative fix for PR 54281

On Thu, 16 Aug 2012, Diego Novillo wrote: > Richi, this implements your idea for fixing PR 54281. I don't > have an old enough compiler. Could you please test it in your > system? > > I debated whether to remove the GENERATOR_FILE predicate from the > inclusion (some files include gmp.h uncondi

Re: [patch] PR54146 - rewrite rewrite_into_loop_closed_ssa

Hi, On Wed, 15 Aug 2012, Steven Bosscher wrote: Please convince me that this : +/* Return the outermost superloop LOOP of USE_LOOP that is a superloop of + both DEF_LOOP and USE_LOOP. */ +static inline struct loop * +find_sibling_superloop (struct loop *use_loop, struct loop *def_loop) +{ +

Re: [PATCH] Set current_function_decl in {push,pop}_cfun and push_struct_function

Hi, On Thu, 16 Aug 2012, Richard Guenther wrote: > If dumping a statement needs the containing function then we need to > either pass that down, provide a way to get from statement to function, > or stop requiring the function. Making the hash global is choice three > (deallocating the hash w

Re: [PATCH,i386] fma,fma4 and xop flags

On Thu, Aug 16, 2012 at 1:43 PM, Gopalasubramanian, Ganesh wrote: >> This won't work, since we have to prefer FMA3 also in case when only "-mfma >> -mfma4" without -mtune=XX is used. >> We can add TARGET_FMA_BOTH though, but I doubt there will ever be target >> that implements both insn sets wit

Re: Commit: BFIN: Fix use of VEC_last macro in bfin.c

On 12-08-16 05:49 , Nick Clifton wrote: gcc/ChangeLog 2012-08-16 Nick Clifton * config/bfin/bfin.c (hwloop_optimize): Fix use of VEC_last macro. Thanks Nick. I made the wrong fix here, sorry about that. I will be making more changes to VEC_ shortly. What's a good way for me to

[bootstrap] Tentative fix for PR 54281

Richi, this implements your idea for fixing PR 54281. I don't have an old enough compiler. Could you please test it in your system? I debated whether to remove the GENERATOR_FILE predicate from the inclusion (some files include gmp.h unconditionally). I think it could be removed, but only a min

RE: [PATCH,i386] fma,fma4 and xop flags

> This won't work, since we have to prefer FMA3 also in case when only "-mfma > -mfma4" without -mtune=XX is used. > We can add TARGET_FMA_BOTH though, but I doubt there will ever be target that > implements both insn sets without preferences. Preferring FMA3 over FMA4 might not do good always.

Commit: Fix i386 ASM_OUTPUT_ASCII macro for C++ compilation.

Hi Richard, Hi Jan, Hi Uros, I am applying the patch below as an obvious fix for this problem when building an i386-elf targeted toolchain: gcc/dwarf2asm.c: In function 'void dw2_asm_output_nstring(const char*, size_t, const char*, ...)': gcc/dwarf2asm.c:334:7: error: invalid convers

Re: PATCH: Replace target MEMBER_TYPE_FORCES_BLK macro with a target hook

On Thu, Aug 16, 2012 at 1:50 AM, H.J. Lu wrote: > Hi, > > This patch replaces MEMBER_TYPE_FORCES_BLK with a target hook. I > also pass the type to the target hook in addition to field, which will > be used by i386 backend for > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20020 > > This patch do

Re: [patch] speed up ifcvt:cond_move_convert_if_block

On Thu, Aug 16, 2012 at 1:11 AM, Steven Bosscher wrote: > On Mon, Aug 6, 2012 at 1:27 PM, Paolo Bonzini wrote: >>> 2. sparseset has the same problem of memory clearing (for valgrind, >>> see sparseset_alloc). >> >> ... only the sparse array needs this clearing, but currently we do it >> for both.

Commit: BFIN: Fix use of VEC_last macro in bfin.c

Hi Bernd, Hi Jie, I am applying the patch below as an obvious fix for this problem whilst compiling the BFIN port of GCC: gcc/config/bfin/bfin.c: In function 'bool hwloop_optimize(hwloop_info)': gcc/config/bfin/bfin.c:3481:41: error: request for member 'flags' in 'VEC_last_1(loop->hwloop_i

Commit: Fixes for building avr-elf with g++.

Hi Denis, Hi Anatoly, Hi Eric, I am applying the patch below as an obvious fix for building the avr-elf port of gcc with a C++ compiler. There were two problems: * t-avr was using $(CC) instead of $(COMPILER) which meant the targets failed to build because they included C++ style

Re: [patch] PR54146 - rewrite rewrite_into_loop_closed_ssa

On Wed, Aug 15, 2012 at 6:26 PM, Steven Bosscher wrote: > Hello, > > This patch rewrites the rewriting part of > rewrite_into_loop_closed_ssa. This function took ~300s on the > simplified test case for PR54146, walking around the many thousands of > loops in the >400,000 basic blocks in the CFG, i

Re: [PATCH] Set current_function_decl in {push,pop}_cfun and push_struct_function

On Wed, Aug 15, 2012 at 5:21 PM, Martin Jambor wrote: > Hi, > > On Fri, Aug 10, 2012 at 04:57:41PM +0200, Eric Botcazou wrote: >> > - ada/gcc-interface/utils.c:rest_of_subprog_body_compilation calls >> > dump_function which in turns calls dump_function_to_file which calls >> > push_cfun. But

Re: Merge C++ conversion into trunk (4/6 - hash table rewrite)

On Wed, 15 Aug 2012, Lawrence Crowl wrote: > On 8/15/12, Richard Henderson wrote: > > On 2012-08-15 07:29, Richard Guenther wrote: > >> + typedef typename Element::Element_t Element_t; > > > > Can we use something less ugly than Element_t? > > Such as > > > > typedef typename Element::T T; >

Re: Interaction between first stage build with g++ and $PATH

On 08/16/12 08:44:09, Jakub Jelinek wrote: > Having . in $PATH is a serious bug (especially from security POV). > Just never do that. > Jakub Jakub, thanks. I'm aware of the potential risks and pitfalls. I probably should use better practice ... - Gary