> +/* Output a single entry in the pubnames table.  */
> +
> +static void
> +output_pubname (dw_offset die_offset, pubname_entry *entry)

For this function, I'd suggest a comment to the effect that the logic
is lifted from GDB.

> @@ -2424,6 +2424,10 @@ gpubnames
>  Common RejectNegative Var(debug_generate_pub_sections, 1)
>  Generate DWARF pubnames and pubtypes sections.
>
> +ggnu-pubnames
> +Common RejectNegative Var(debug_generate_pub_sections, 2)
> +Generate DWARF pubnames and pubtypes sections.

Instead of "RejectNegative", I think these three options should now
use "Negative(...)" flags (each one naming the next, circularly). Not
sure about that, though. (See the treatment of -gdwarf-, -gstabs,
etc.)

OK for google/gcc-4_7 branch.

-cary

Reply via email to