Re: [x32] PATCH: PR middle-end/47725: [x32] error: unable to find a register to spill in class DIREG

2011-03-17 Thread H.J. Lu
On Thu, Mar 17, 2011 at 5:30 PM, H.J. Lu wrote: > On Tue, Feb 15, 2011 at 2:55 PM, Bernd Schmidt > wrote: >> On 02/14/2011 08:46 PM, Eric Botcazou wrote: I agree with Jeff that combine would be the correct place to fix this. At least it takes class_likely_spilled_p into account, so it

Re: PATCH: PR rtl-optimization/47502: Never combine asm statement

2011-03-17 Thread H.J. Lu
On Thu, Mar 17, 2011 at 8:28 PM, Geert Bosch wrote: > > On Mar 17, 2011, at 20:35, H.J. Lu wrote: > >>> -     substitutions of likely-spilled regs, reload might die. >>> +     substitutions of likely-spilled regs, reload might die.  Never >>> +     combine asm statement. >> > This has to be "state

Re: PATCH: PR rtl-optimization/47502: Never combine asm statement

2011-03-17 Thread Geert Bosch
On Mar 17, 2011, at 20:35, H.J. Lu wrote: >> - substitutions of likely-spilled regs, reload might die. >> + substitutions of likely-spilled regs, reload might die. Never >> + combine asm statement. > This has to be "statements", a plural. -Geert

Re: PATCH: PR rtl-optimization/47502: Never combine asm statement

2011-03-17 Thread H.J. Lu
Hi Eric, Is this patch OK for trunk? Thanks. H.J. --- On Thu, Jan 27, 2011 at 6:14 PM, H.J. Lu wrote: > It is a bad idea to combine asm statement.  This patch disallows it. > Any comments? > > Thanks. > > > H.J. > --- > commit a11b95180e53d3a0bc3eabad5594859cea7c3334 > Author: H.J. Lu > Date:

Re: [x32] PATCH: PR middle-end/47725: [x32] error: unable to find a register to spill in class DIREG

2011-03-17 Thread H.J. Lu
On Tue, Feb 15, 2011 at 2:55 PM, Bernd Schmidt wrote: > On 02/14/2011 08:46 PM, Eric Botcazou wrote: >>> I agree with Jeff that combine would be the correct place to fix this. >>> At least it takes class_likely_spilled_p into account, so it will >>> restrict only those machines where extending the

Re: [PATCH] Fix hppa-* --enable-checking=release bootstrap (PR bootstrap/48161)

2011-03-17 Thread Jakub Jelinek
On Thu, Mar 17, 2011 at 09:07:43PM +0100, Jakub Jelinek wrote: > The following fixes the testcase in cross to hppa-* as well. > I'll bootstrap/regtest it momentarily, ok if it passes? Now bootstrapped/regtested on x86_64-linux and i686-linux. > 2011-03-17 Richard Henderson > Jakub Je

Can't use SImode as Pmode for x32

2011-03-17 Thread H.J. Lu
On Wed, Mar 16, 2011 at 4:28 PM, Jakub Jelinek wrote: > On Wed, Mar 16, 2011 at 03:38:25PM -0700, H.J. Lu wrote: > > IMNSHO you really should reconsider using Pmode != ptr_mode for your port. Hi Jakub, I created hjl/x32/Pmode/master branch at http://git.kernel.org/?p=devel/gcc/hjl/x86.git;a=sum

Re: [libgfortran, patch] More than 26 temporary files with weak mktemp()

2011-03-17 Thread FX
Thanks for the review! > - Use the type size_t for tempdirlen as that is the return type of > strlen() and argument type for get_mem(). > > - You can use a const size_t variable for the length of the string > "slash" rather than calling strlen() in the do-while loop. Both OK. > - Don't set errn

C++ PATCH for c++/47504 (bogus overflow error with constexpr)

2011-03-17 Thread Jason Merrill
In this testcase, the fix for PR 25125 causes us to rewrite what starts as char(int(-1) - int(1)) to char((unsigned char)(-1) - (unsigned char)1) and thus char((unsigned char)254). 254 doesn't fit in char, so the result has TREE_OVERFLOW set even though the original expression was all signed a

RFC: PATCH: PR rtl-optimization/48155: Reload doesn't handle subreg properly

2011-03-17 Thread H.J. Lu
Hi, Reload tries to handle plus operation such as: (plus (subreg (plus (reg) (const_int NNN))) (const_int NNN)) and nothing good comes out of it. I am not quite happy with this patch. Any comments? Thanks. H.J. --- commit 17ee20b

Fix problem with guality tests

2011-03-17 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The guality tests can randomly fail due to expect buffering issues. Given this output: Breakpoint 1 at 0x4004d6: file /home/gcc/virgin-gcc/gcc/testsuite/gcc.dg/guality/pr43479.c, line 18.^M ^M Breakpoint 1, foo (k=7, l=Unhandled dwarf expression opco

Reinstalled patch for 37273

2011-03-17 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I had pulled the patch for 37273 during the 4.6 cycle due to exposing several latent problems. I've just reinstalled it and will (of course) keep an eye out for any problems. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment:

Re: [PATCH] Fix hppa-* --enable-checking=release bootstrap (PR bootstrap/48161)

2011-03-17 Thread Jakub Jelinek
On Thu, Mar 17, 2011 at 12:54:44PM -0700, Richard Henderson wrote: > On 03/17/2011 11:46 AM, Jakub Jelinek wrote: > > - result = gen_rtx_PLUS (tmode, result, tmp); > > + { > > + if (swap_commutative_operands_p (result, tmp)) > > + result = gen_rtx_PLUS (tmode, tmp, result); > > +

Re: [PATCH] Fix handling of calls to constants (PR debug/48163)

2011-03-17 Thread Richard Henderson
On 03/17/2011 11:40 AM, Jakub Jelinek wrote: > PR debug/48163 > * var-tracking.c (prepare_call_arguments): If CALL target > is a non-SYMBOL_REF CONSTANT_P, just add that into the list as > pc instead of looking it up using cselib_lookup and use > Pmode for it if x has

Re: [PATCH] Adjust DECL_INCOMING_RTL for pass_by_reference parameters (PR debug/48163)

2011-03-17 Thread Richard Henderson
On 03/17/2011 11:36 AM, Jakub Jelinek wrote: > PR debug/48163 > * function.c (assign_parms): For data.passed_pointer parms > use MEM of data.entry_parm instead of data.entry_parm itself > as DECL_INCOMING_RTL. > * dwarf2out.c (rtl_for_decl_location): Use DECL_INCOMING_

Re: [PATCH] Fix hppa-* --enable-checking=release bootstrap (PR bootstrap/48161)

2011-03-17 Thread Richard Henderson
On 03/17/2011 11:46 AM, Jakub Jelinek wrote: > - result = gen_rtx_PLUS (tmode, result, tmp); > + { > + if (swap_commutative_operands_p (result, tmp)) > + result = gen_rtx_PLUS (tmode, tmp, result); > + else > + result = gen_rtx_PLUS (tmode, result, tmp); Hum. W

Re: PATCH: PR debug/48160: prepare_call_arguments failed to handle subreg

2011-03-17 Thread Richard Henderson
On 03/17/2011 11:06 AM, H.J. Lu wrote: > PR debug/48160 > * var-tracking.c (prepare_call_arguments): Check SUBREG. Ok. r~

Re: RX: 4.5 branch: Fix alignment and addressing issues.

2011-03-17 Thread Mike Stump
On Mar 17, 2011, at 5:31 AM, Nick Clifton wrote: >> You can set up the correct length even without using separate patterns. > > The problem is And why is that a problem? You get to write arbitrarily complex C code that can depend upon insn and operands. I presume that you can do that. See:

Re: Cleaning up expand optabs code

2011-03-17 Thread Richard Henderson
On 03/17/2011 09:32 AM, Richard Sandiford wrote: > This patch adds a few helper functions for dealing with optabs: > > - insn_operand_matches (ICODE, OPNO, X) > - (maybe_)legitimize_insn_target (ICODE, OPNO, TARGET, MODE) > - (maybe_)legitimize_insn_source (ICODE, OPNO, SOURCE, MODE) Cool. Why p

[PATCH] Fix hppa-* --enable-checking=release bootstrap (PR bootstrap/48161)

2011-03-17 Thread Jakub Jelinek
Hi! When expanding D.2070_29 = &MEM[(struct V *)0B].v[D.2034_30]{lb: 0 sz: 12}; expand_expr_addr_expr_1 is called with EXPAND_SUM, and result ends up being (const_int 0) (from the NULL address), while tmp (the offset) is a pseudo register. With EXPAND_SUM we want to ensure no insns are emitted, s

Re: PATCH: PR target/48171: Missing "Save" on -mavx and -mfma

2011-03-17 Thread Uros Bizjak
On Thu, Mar 17, 2011 at 6:51 PM, H.J. Lu wrote: > All i386 ISA options, except for -mavx and -mfma, have Save.  This patch > fixes it.  OK for trunk and 4.6? > > 2011-03-17  H.J. Lu   > >        PR target/48171 >        * config/i386/i386.opt: Add Save to -mavx and -mfma. OK for 4.7 and 4.6 with

[PATCH] Fix handling of calls to constants (PR debug/48163)

2011-03-17 Thread Jakub Jelinek
Hi! On calls.c testcase on cris we ICE from prepare_call_arguments on calls like typedef void (*T) (); ((T) 0x10) (); Calling cselib_lookup with VOIDmode can't do any good, but there is not reason why we should cselib_lookup constants, we can just use them as is. Bootstrapped/regtested on

[PATCH] Adjust DECL_INCOMING_RTL for pass_by_reference parameters (PR debug/48163)

2011-03-17 Thread Jakub Jelinek
Hi! If a PARM_DECL is not passed by reference because the FE decides so (then the PARM_DECL is DECL_BY_REFERENCE and has pointer type), but because pass_by_reference said so, then apparently DECL_INCOMING is the Pmode pointer to the MEM instead of the actual incoming location and the fact that exp

PATCH: PR debug/48160: prepare_call_arguments failed to handle subreg

2011-03-17 Thread H.J. Lu
Hi Jason, Richard, This patch: http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00814.html failed to handle SUBREG in prepare_call_arguments. This patch fixes it. OK for trunk? Thanks. H.J. --- 2011-03-16 H.J. Lu PR debug/48160 * var-tracking.c (prepare_call_arguments): Chec

PATCH: PR target/48171: Missing "Save" on -mavx and -mfma

2011-03-17 Thread H.J. Lu
Hi, All i386 ISA options, except for -mavx and -mfma, have Save. This patch fixes it. OK for trunk and 4.6? Thanks. H.J. --- 2011-03-17 H.J. Lu PR target/48171 * config/i386/i386.opt: Add Save to -mavx and -mfma. diff --git a/gcc/config/i386/i386.opt b/gcc/config/i386/i3

Re: C++ PATCH for c++/48089 (ICE with invalid constexpr ctor)

2011-03-17 Thread Gabriel Dos Reis
On Thu, Mar 17, 2011 at 10:41 AM, Jason Merrill wrote: > On 03/16/2011 11:44 PM, Gabriel Dos Reis wrote: >> >> I am not sure we need more infrastructure or more complexity >> in the implementation.  The (C++98) language already requires >> us to initialize subobjects in their order of declaration.

[testsuite] Remove explicit -O2 from gcc.c-torture/compile/pr44686.c

2011-03-17 Thread Martin Jambor
Hi, I'm about to check in the following as obvious. The explicit -O2 defeats the different O levels the torture mechanism tries. Tested on x86_64-linux by running make -k check RUNTESTFLAGS="compile.exp=pr44686.c" and verifying all tests passed. Thanks, Martin Index: gcc/testsuite/gcc.c-t

Re: [PATCH] Fix PR48148

2011-03-17 Thread H.J. Lu
On Thu, Mar 17, 2011 at 6:24 AM, Richard Guenther wrote: > > This fixes PR48148, we shouldn't keep abstract origin references > for external decls. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. > > Richard. > > 2011-03-17  Richard Guenther   > >        PR bootstrap/48148 >    

[Ada] Fix ICE on declaration of discriminated record type

2011-03-17 Thread Eric Botcazou
This is an internal error in self_referential_size on the code generated for the elaboration of a discriminated record type which contains an array whose upper bound depends on the discriminant and whose nominal subtype is an unconstrained array type whose index type has a component of a constan

Re: [PATCH] PR/Target 47998

2011-03-17 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/17/11 09:31, Yoshinori Sato wrote: > At Wed, 16 Mar 2011 10:22:20 -0600, > Jeff Law wrote: >> > On 03/16/11 09:32, Yoshinori Sato wrote: Hi All, This problem optimize rule missing. gen_lowpart got invalid operand. I

Re: PR debug/47510

2011-03-17 Thread Dodji Seketeli
Mark Mitchell writes: > And, in any case, if it's a regression it's OK with me. Thanks. I have committed the patch back into 4.6. -- Dodji

Re: RX: 4.5 branch: Fix alignment and addressing issues.

2011-03-17 Thread DJ Delorie
> What is length used for in the rx port? We have a local patch that uses the length to decide if/when to align labels; it goes along with the label alignment change I made a while back. However, the patch works best in 4.5 (align patch not backported) and there are other optimization problems w

Re: [AVR] Hookize LIBCALL_VALUE and FUNCTION_VALUE_REGNO_P

2011-03-17 Thread Richard Henderson
On 03/16/2011 02:46 PM, Georg-Johann Lay wrote: > Anatoly Sokolov schrieb: > >> /* Returns register number for function return value.*/ >> >> -int >> +static inline int >> avr_ret_register (void) >> { >>return 24; >> } > > I always wondered why that works. > > SI is returned in r22..r2

Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

2011-03-17 Thread Kai Tietz
2011/3/17 Jason Merrill : > On 03/17/2011 12:08 PM, Kai Tietz wrote: >> >> I thought to use here instead of on_diagnostic (which is IMHO fine too >> as it indicates for now only that attribute shall be displayed on >> diagnostics) "affects_abi". I think it makes sense to keep that name >> as short

C++ PATCH for core resolution 1212 (decltype of non-call xvalue)

2011-03-17 Thread Jason Merrill
Now that we have reasonable terminology for talking about expressions involving rvalue references, we can ditch the clumsy rule about decltype of a call in favor of just saying that decltype of an xvalue is an rvalue reference. Tested x86_64-pc-linux-gnu, applying to trunk. commit 2ac0fa349f5a

Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

2011-03-17 Thread Jason Merrill
On 03/17/2011 12:08 PM, Kai Tietz wrote: I thought to use here instead of on_diagnostic (which is IMHO fine too as it indicates for now only that attribute shall be displayed on diagnostics) "affects_abi". I think it makes sense to keep that name as short as possible. Hmm, type compatibility is

Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

2011-03-17 Thread Kai Tietz
2011/3/17 Jason Merrill : > On 03/17/2011 04:46 AM, Kai Tietz wrote: >> >> PING, ok for 4.7? > > Did you have a response to my comment below? > >> 2011/1/4 Jason Merrill: >>> >>> On 01/01/2011 01:07 PM, Kai Tietz wrote: Well, as here no further agreement was found, I post here the al

Re: PR debug/47510

2011-03-17 Thread Mark Mitchell
On 3/17/2011 4:08 AM, Dodji Seketeli wrote: > Yesterday after discussing this on IRC, Jakub expressed his personal > opinion by saying the patch could go in 4.6. I mistakenly took it as a > formal approval from the RMs and I committed it. I should have waited > for an approval by email. You don

C++ PATCH for c++/48166 (ICE with invalid function-cv-quals)

2011-03-17 Thread Jason Merrill
I missed one case where we needed to change cp_type_quals to type_memfn_quals. After that fix we gave the correct error, but still ICEd, so to avoid that I go ahead and strip the offending cv-quals. Tested x86_64-pc-linux-gnu, applying to trunk, will apply to 4.6.1 after 4.6.0 release. commit

Re: PR45273 - The compiler depends on the host double

2011-03-17 Thread Richard Henderson
On 03/17/2011 01:35 AM, Richard Guenther wrote: >> Anyone a better suggestion for PRED_PRECISION? > > It at least seems you are introducing another host dependency here with using > HOST_BITS_PER_WIDE_INT. Why not simply use a fixed value of 32? Or 64, given that's the exact precision that sreal

[Patch] Disable -fstack-limit for bfin -mfdpic

2011-03-17 Thread Henderson, Stuart
-fstack-limit- is not supported for bfin with -mfdpic and crashes if you try to use it. The attached patch warns the user that -fstack-limit is ignored with the -mfdpic switch for Blackfin and then disables it. 2011-03-17 Stuart Henderson Originally From Bernd Schmidt * config/bfin/bfin.

Re: C++ PATCH for c++/48089 (ICE with invalid constexpr ctor)

2011-03-17 Thread Jason Merrill
On 03/16/2011 11:44 PM, Gabriel Dos Reis wrote: I am not sure we need more infrastructure or more complexity in the implementation. The (C++98) language already requires us to initialize subobjects in their order of declaration. That is what we do here. All we need is to check that a member, w

Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

2011-03-17 Thread Jason Merrill
On 03/17/2011 04:46 AM, Kai Tietz wrote: PING, ok for 4.7? Did you have a response to my comment below? 2011/1/4 Jason Merrill: On 01/01/2011 01:07 PM, Kai Tietz wrote: Well, as here no further agreement was found, I post here the alternative suggested by Joseph. I am open-minded which app

Re: RX: 4.5 branch: Fix alignment and addressing issues.

2011-03-17 Thread Richard Henderson
On 03/17/2011 05:31 AM, Nick Clifton wrote: > So really I think that I should be defining the ADJUST_INSN_LENGTH macro to > handle these patterns. I'll look into that. What is length used for in the rx port? I don't see any branch shortening going on here; out of range branches are completely h

Re: [PATCH] PR/Target 47998

2011-03-17 Thread Yoshinori Sato
At Wed, 16 Mar 2011 10:22:20 -0600, Jeff Law wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/16/11 09:32, Yoshinori Sato wrote: > > Hi All, > > > > This problem optimize rule missing. > > gen_lowpart got invalid operand. > > > > I attached fix patch. > > > > diff --git a/g

[PATCH][RFC] Unify constant folding

2011-03-17 Thread Richard Guenther
This tries to move us towards a single constant-folding machinery on gimple, usable by the various value-numbering passes we have (CCP, VRP, SCCVN and eventually DOM, not yet in this patch). At least VRP and SCCVN should in theory perform the same constant propagations as CCP does but they do not

Re: [patch][4.7] Enhance XOR handling in simplify-rtx.c

2011-03-17 Thread Richard Henderson
On 03/16/2011 06:55 PM, Chung-Lin Tang wrote: > You have to use DeMorgan's Law to distribute the ~ operator: Duh. Not sure where my head was yesterday. Let's enhance the comment for someone else having an off day. Perhaps /* Given (xor (and A B) C), using P^Q == ~P&Q | ~Q&P and DeMorga

Re: [patch] Enhance conditional store sinking

2011-03-17 Thread Richard Guenther
On Thu, Mar 17, 2011 at 3:53 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/17/11 08:48, Richard Guenther wrote: >> >> The gimple_uids are not initialized here, you need to make sure to >> call renumber_gimple_stmt_uids () before starting.  Note that phiopt >> incr

[PATCH] Fix PR48134

2011-03-17 Thread Richard Guenther
This fixes PR48134, when propagating into debug-stmts we should fold them, like we do elsewhere. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-03-17 Richard Guenther PR middle-end/48134 * tree-ssa.c (insert_debug_temp_for_var_def): If w

Re: [patch] Enhance conditional store sinking

2011-03-17 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/17/11 08:48, Richard Guenther wrote: > > The gimple_uids are not initialized here, you need to make sure to > call renumber_gimple_stmt_uids () before starting. Note that phiopt > incrementally changes the IL, so I'm not sure those uids will st

Re: [PATCH] Fix prepare_call_arguments for types passed by reference (PR middle-end/48152)

2011-03-17 Thread Richard Henderson
On 03/16/2011 04:16 PM, Jakub Jelinek wrote: > PR middle-end/48152 > * var-tracking.c (prepare_call_arguments): If argument needs to be > passed by reference, adjust argtype and mode. Ok. r~

Re: [PATCH] Don't emit entry_value/call_site stuff if -gstrict-dwarf (PR bootstrap/48153)

2011-03-17 Thread Richard Henderson
On 03/16/2011 04:20 PM, Jakub Jelinek wrote: > PR bootstrap/48153 > * dwarf2out.c (mem_loc_descriptor) : Return NULL > if dwarf_strict. > (gen_subprogram_die): Don't add call_site DIEs if dwarf_strict. > Clear call_arg_locations and call_arg_loc_last always. Ok. r~

Re: [patch] Enhance conditional store sinking

2011-03-17 Thread Richard Guenther
On Wed, Mar 16, 2011 at 12:47 PM, Ira Rosen wrote: > On 16 March 2011 12:29, Richard Guenther wrote: >> On Wed, Mar 16, 2011 at 7:49 AM, Ira Rosen wrote: >>> Hi, >>> >>> This patch adds a support of conditional store sinking for cases with >>> multiple data references in then and else basic bloc

Re: [PATCH][i386] Implement ix86_emit_swdivsf more efficiently

2011-03-17 Thread Michael Matz
Hi, On Mon, 14 Mar 2011, Richard Guenther wrote: > This rewrites the iteration step of swdivsf to be more register > efficient (two registers instead of four, no load of a FP constant). > This matches how ICC emits the rcp sequence and causes no overall loss > of precision (Micha might still r

Re: [wwwdocs] gcc-4.6/porting_to.html

2011-03-17 Thread Matthias Klose
On 17.03.2011 07:51, Benjamin Kosnik wrote: > > Needs some more work, here's a rough draft. > > -benjamin + As a workaround, remove -Werror until the new warnings + are fixed, or for conversion warnings + add -Wno-unused-but-set-variable + or -Wno-unused-but-set-parameter. + what about recomme

[doc] Update install.texi for Solaris 2, IRIX, Tru64 UNIX

2011-03-17 Thread Rainer Orth
I've just reviewed install.texi for my platforms and found it mostly accurate. A few minor changes are desirable for the 4.6 release, but also apply to mainline since the file is identical there: * Update recommendations to binutils 2.21 since this is what I've been testing. * Remove download

Re: [libgfortran, 4.6] Don't use clock_gettime on Tru64 UNIX (PR fortran/47571)

2011-03-17 Thread Rainer Orth
Jakub Jelinek writes: >> Jakub, ok for the 4.6 branch once the bootstrap has finished >> successfully? > > Ok, but for 4.6.1 and 4.7 please revert it and apply the real fix. I think Janne meant to apply the real fix to 4.7, so I can keep the workaround locally for mainline. I just wanted to avo

Re: [PATCH] Fix PR48148

2011-03-17 Thread H.J. Lu
On Thu, Mar 17, 2011 at 6:24 AM, Richard Guenther wrote: > > This fixes PR48148, we shouldn't keep abstract origin references > for external decls. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. > > Richard. > > 2011-03-17  Richard Guenther   > >        PR bootstrap/48148 >    

Re: [PING][PATCH] Cleanup, use bitmap_set_range/bitmap_clear_range instead of bitmap_set_bit/bitmap_clear_bit loops.

2011-03-17 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/16/11 15:32, Anatoly Sokolov wrote: > Hello. > >> On 12/08/10 11:46, Anatoly Sokolov wrote: >>> Hi. >>> >>>This patch converts loops of bitmap_set_bit/bitmap_clear_bit in to >>> bitmap_set_range/bitmap_clear_range functions call. >>> >>>

[PATCH] Fix PR48148

2011-03-17 Thread Richard Guenther
This fixes PR48148, we shouldn't keep abstract origin references for external decls. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2011-03-17 Richard Guenther PR bootstrap/48148 * lto-cgraph.c (input_overwrite_node): Clear the abstract origin

[PATCH] Fix PR48165

2011-03-17 Thread Richard Guenther
This fixes PR48165, we need to properly return sizetype quantities from compute_object_offset. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk and the branch. Richard. 2011-03-17 Richard Guenther PR middle-end/48165 * tree-object-size.c (compute_object_

Re: [PATCH] Ensure DEBUG_INSNs don't contain MEMs with non-canonical MEM_EXPRs (PR debug/48134)

2011-03-17 Thread Richard Guenther
On Thu, Mar 17, 2011 at 9:41 AM, Richard Guenther wrote: > On Thu, Mar 17, 2011 at 12:32 AM, Jakub Jelinek wrote: >> Hi! >> >> Currently expand_debug_expr doesn't always guarantee canonical >> MEM_EXPRs, if MEM_EXPR isn't canonical, sometimes aliasing code ICEs on it >> (since recent Richard's ch

[Ada] Avoid too large read generated for complex packed array type

2011-03-17 Thread Eric Botcazou
This change prevents the compiler from generating too large reads (typically a few bytes, essentially only visible with valgrind) when it is manipulating complex packed array types. Tested on i586-suse-linux, applied on the mainline. 2011-03-17 Eric Botcazou * gcc-interface/gigi.h

Re: RX: 4.5 branch: Fix alignment and addressing issues.

2011-03-17 Thread Nick Clifton
Hi Andrew, + (set_attr "length" "5")] ;; Worst case sceanario. FIXME: If we defined separate patterns +);; rather than using iterators we could specify exact sizes. You can set up the correct length even without using separate patterns. The problem is that t

Re: [ARM] PR 47553: vld1q_lane_u8 & co. don't accept lanes >= 8

2011-03-17 Thread Nick Clifton
Hi Ramana, I am tempted to consider this one for the other release branches since this is correcting a test in the interface for an intrinsic which has been wrong for a long time but would like the opinion of the other maintainers about this. I think that I would agree with you here. Certainl

Re: [wwwdocs] gcc-4.6/porting_to.html

2011-03-17 Thread Ryan Hill
On Wed, 16 Mar 2011 23:51:30 -0700 Benjamin Kosnik wrote: > Needs some more work, here's a rough draft. The one I've seen most often other than including cstddef is due to linker options starting with -- (eg. --export-dynamic, --no-undefined) now being errors. Previously they were just silently

Re: [4.7] Avoid global state in sparc_handle_option

2011-03-17 Thread Eric Botcazou
> 2011-03-13 Joseph Myers > > * config/sparc/sparc-opts.h: New. Do you really need all the dates in there? > * config/sparc/sparc.c (sparc_handle_option, sparc_select, > sparc_cpu, fpu_option_set, TARGET_HANDLE_OPTION): Remove. > (sparc_option_override): Store processor

Re: [V850] Hookize OUTPUT_ADDR_CONST_EXTRA

2011-03-17 Thread Nick Clifton
Hi Anatoly, * config/v850/v850.h (OUTPUT_ADDR_CONST_EXTRA): Remove. * config/v850/v850-protos.h (v850_output_addr_const_extra): Remove. * config/v850/v850.c (v850_output_addr_const_extra): Mace static. Change return type to bool. (TARGET_ASM_OUTPUT_AD

Re: PR debug/47510

2011-03-17 Thread Richard Guenther
On Thu, 17 Mar 2011, Dodji Seketeli wrote: > Yesterday after discussing this on IRC, Jakub expressed his personal > opinion by saying the patch could go in 4.6. I mistakenly took it as a > formal approval from the RMs and I committed it. I should have waited > for an approval by email. So I hav

Re: PR debug/47510

2011-03-17 Thread Dodji Seketeli
Yesterday after discussing this on IRC, Jakub expressed his personal opinion by saying the patch could go in 4.6. I mistakenly took it as a formal approval from the RMs and I committed it. I should have waited for an approval by email. So I have just reverted the patch from 4.6 now. Sorry for t

Re: [Patch][AVR]: Support tail calls

2011-03-17 Thread Denis Chertykov
2011/3/16 Georg-Johann Lay > > Richard Henderson schrieb: >> >> On 03/16/2011 03:32 AM, Georg-Johann Lay wrote: >> >>> Richard Henderson schrieb: >>> On 03/11/2011 05:43 AM, Georg-Johann Lay wrote: > I did not find a way to make this work together with -mcall-prologues. > Please

RX: Adjust memory move cost

2011-03-17 Thread Nick Clifton
Hi Guys, I am applying the patch below to tweak the MEMORY_MOVE_COST macro for the RX port on the 4.5 branch. Writing to memory is actually faster than reading on the RX, so the cost can be reduced as shown. Cheers Nick gcc/ChangeLog 2011-03-17 Nick Clifton * config/rx/rx.h

Re: [libgfortran, 4.6] Don't use clock_gettime on Tru64 UNIX (PR fortran/47571)

2011-03-17 Thread Jakub Jelinek
On Thu, Mar 17, 2011 at 11:23:56AM +0100, Rainer Orth wrote: > The conditional use of clock_gettime via weakrefs completely broke > Fortran on Tru64 UNIX: while the function is available in librt, the > platform doesn't support weakrefs, so every execution test fails due to > the undefined symbol.

[libgfortran, 4.6] Don't use clock_gettime on Tru64 UNIX (PR fortran/47571)

2011-03-17 Thread Rainer Orth
The conditional use of clock_gettime via weakrefs completely broke Fortran on Tru64 UNIX: while the function is available in librt, the platform doesn't support weakrefs, so every execution test fails due to the undefined symbol. While a proper patch is being tested for mainline (to be backported

Re: [libgfortran, patch] More than 26 temporary files with weak mktemp()

2011-03-17 Thread Janne Blomqvist
On Wed, Mar 16, 2011 at 23:50, FX wrote: >> If M$ mktemp when already 26 files exist with the same prefix at least >> properly fails, then it would be better to just retry with a changed prefix >> if it fails. > > > Done exactly that. Manually tested on i586-pc-mingw32, regtested on > x86_64-linu

Re: [patch i386,c,c++]: PR/12171 - calling convention omitted in error message

2011-03-17 Thread Kai Tietz
PING, ok for 4.7? 2011/1/4 Jason Merrill : > On 01/01/2011 01:07 PM, Kai Tietz wrote: >> >> Well, as here no further agreement was found, I post here the >> alternative suggested by Joseph. I am open-minded which approach will >> be chosen. I just want to fix this long pending issue. >> I split up

Re: [PATCH] Ensure DEBUG_INSNs don't contain MEMs with non-canonical MEM_EXPRs (PR debug/48134)

2011-03-17 Thread Richard Guenther
On Thu, Mar 17, 2011 at 12:32 AM, Jakub Jelinek wrote: > Hi! > > Currently expand_debug_expr doesn't always guarantee canonical > MEM_EXPRs, if MEM_EXPR isn't canonical, sometimes aliasing code ICEs on it > (since recent Richard's change fortunately only if --enable-checking=yes). > > The followin

Re: PR45273 - The compiler depends on the host double

2011-03-17 Thread Richard Guenther
On Thu, Mar 17, 2011 at 12:24 AM, Steven Bosscher wrote: > Hi, > > The attached patch replace sreal math with mpfr math in predict.c and > host double math in mcf.c also with mpfr math. > > Bootstrapped&tested (incl. ada) on x86_64-unknown-linux-gnu. OK for trunk? > > Anyone a better suggestion fo

Re: C++ PATCH for c++/48113 (SFINAE bug causing bind regression in libstdc++)

2011-03-17 Thread Jakub Jelinek
On Thu, Mar 17, 2011 at 09:26:36AM +0100, Richard Guenther wrote: > Ok for 4.6.0. I guess we need to do a RC2 anyway. Yeah, certainly. I'll roll one during the weekend, it would be nice if all the pending fixes still desirable for 4.6.0 make it till then and after RC2 we'd try to allow only very

Re: C++ PATCH for c++/48113 (SFINAE bug causing bind regression in libstdc++)

2011-03-17 Thread Richard Guenther
On Wed, Mar 16, 2011 at 8:51 PM, Jason Merrill wrote: > convert_for_initialization is sfinae-enabled, but it was calling > ocp_convert, which is not.  This patch changes it to use the newer > perform_implicit_conversion_flags instead.  To make that work, I needed to > add support for LOOKUP_PREFER

Re: C++ PATCH for c++/48132 (ICE with constexpr and array)

2011-03-17 Thread Richard Guenther
On Wed, Mar 16, 2011 at 9:00 PM, Jason Merrill wrote: > Jakub was right that we were failing to add indices to the array CONSTRUCTOR > along this code path.  It seems appropriate to add them earlier, in > reshape_init, like we do for classes, so this patch fixes the bug that way. > > Tested x86_64

Re: [wwwdocs] gcc-4.6/porting_to.html

2011-03-17 Thread Jakub Jelinek
On Wed, Mar 16, 2011 at 11:51:30PM -0700, Benjamin Kosnik wrote: > + > + To fix, first see if the unused variable or parameter can be removed > + without changing the result or logic of the surrounding code. If not, > + annoate it with __attribute__((__unused__)) annotate Also, I think we should

Re: [wwwdocs] gcc-4.6/porting_to.html

2011-03-17 Thread Hans-Peter Nilsson
On Wed, 16 Mar 2011, Benjamin Kosnik wrote: > Needs some more work, here's a rough draft. s/Porting to the new tools/Porting to the new version/ ? brgds, H-P