https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70065
Manuel López-Ibáñez changed:
What|Removed |Added
CC||manu at gcc dot gnu.org
--- Commen
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70065
--- Comment #7 from Marc Glisse ---
Before your patch, the code uses warning(OPT_Wparentheses,...), and
-Wno-parentheses inhibits the warning just fine (this is done in diagnostic.c).
If you replace OPT_Wparentheses with OPT_Wwhatever, -Wno-whate
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70065
--- Comment #6 from Serge Roussak ---
(In reply to Serge Roussak from comment #3)
> (In reply to Marc Glisse from comment #1)
> > The test "if (warn_precedence)"
> > seems redundant with the use of OPT_Wprecedence.
>
> I see all except this ment
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70065
--- Comment #5 from Serge Roussak ---
(In reply to Marek Polacek from comment #2)
> Wait, so what is wrong with this?
> warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
> You can use -Wno-parentheses to disable that warning.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70065
--- Comment #4 from Serge Roussak ---
(In reply to Marek Polacek from comment #2)
> Wait, so what is wrong with this?
> warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
> You can use -Wno-parentheses to disable that warning.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70065
--- Comment #3 from Serge Roussak ---
(In reply to Marc Glisse from comment #1)
> The test "if (warn_precedence)"
> seems redundant with the use of OPT_Wprecedence.
I see all except this mentioned: what do you mean?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70065
--- Comment #2 from Marek Polacek ---
Wait, so what is wrong with this?
warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
You can use -Wno-parentheses to disable that warning.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70065
--- Comment #1 from Marc Glisse ---
Patches should be sent to gcc-patc...@gcc.gnu.org for review. Please avoid
unrelated whitespace changes in your patch. The test "if (warn_precedence)"
seems redundant with the use of OPT_Wprecedence.
