https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70065

--- Comment #7 from Marc Glisse <glisse at gcc dot gnu.org> ---
Before your patch, the code uses warning(OPT_Wparentheses,...), and
-Wno-parentheses inhibits the warning just fine (this is done in diagnostic.c).
If you replace OPT_Wparentheses with OPT_Wwhatever, -Wno-whatever will disable
that warning. I don't see why changing the name of the option that controls
this warning should change anything else to this part of the code (it might be
a small optimization in this case, but redundancy tends to cause trouble
eventually).

By the way, it would also be good to survey what other compilers (clang, maybe
Intel) do here. If some already split -Wparentheses into several -W flags,
picking consistent names would be helpful.

Oh, and of course you need to add a test or two in gcc/testsuite/c-c++-common.

Reply via email to