Re: tree ssa and type issues

2005-05-28 Thread Gabriel Dos Reis
Daniel Berlin <[EMAIL PROTECTED]> writes: | On Sat, 2005-05-21 at 18:55 +0200, Andreas Jaeger wrote: | > Gabriel Dos Reis <[EMAIL PROTECTED]> writes: | > | > > Hi again, | > > | > > I just hit this one from tree-ssa-into.c:rewrite_into_ssa() | > > | > > /* Initialize dominance frontier. */ | >

Re: tree ssa and type issues

2005-05-23 Thread Thomas R. Truscott
> | > dfs = (bitmap *) xmalloc (last_basic_block * sizeof (bitmap *)); > | > It would be nice if gcc gave a warning for suspicious cases like this. I did a crude warning for this, and ironically it found a bug in valgrind: http://w

Re: tree ssa and type issues

2005-05-21 Thread Andreas Schwab
Andreas Jaeger <[EMAIL PROTECTED]> writes: > Gabriel Dos Reis <[EMAIL PROTECTED]> writes: > >> Hi again, >> >> I just hit this one from tree-ssa-into.c:rewrite_into_ssa() >> >> /* Initialize dominance frontier. */ >> dfs = (bitmap *) xmalloc (last_basic_block * sizeof (bitmap *)); >>

Re: tree ssa and type issues

2005-05-21 Thread Steven Bosscher
On Saturday 21 May 2005 22:15, Daniel Berlin wrote: > > where the storage is returned/reused as soon as done, as opposed to > > waiting for the end of the compilation. > > Uh, nobody waits for the end of compilation to free their xmalloc'd > things. Except the alloc pools of et-forest :-) Gr. Ste

Re: tree ssa and type issues

2005-05-21 Thread Daniel Berlin
On Sat, 2005-05-21 at 22:59 +0200, Gabriel Dos Reis wrote: > Daniel Berlin <[EMAIL PROTECTED]> writes: > > | On Sat, 2005-05-21 at 22:00 +0200, Gabriel Dos Reis wrote: > | > Daniel Berlin <[EMAIL PROTECTED]> writes: > | > > | > [...] > | > > | > | > Parenthetically, I was wondering who is freein

Re: tree ssa and type issues

2005-05-21 Thread Gabriel Dos Reis
Daniel Berlin <[EMAIL PROTECTED]> writes: | On Sat, 2005-05-21 at 22:00 +0200, Gabriel Dos Reis wrote: | > Daniel Berlin <[EMAIL PROTECTED]> writes: | > | > [...] | > | > | > Parenthetically, I was wondering who is freeing those extensive | > | > regions of storage xmalloc/xcalloc()ed here and t

Re: tree ssa and type issues

2005-05-21 Thread Daniel Berlin
On Sat, 2005-05-21 at 22:00 +0200, Gabriel Dos Reis wrote: > Daniel Berlin <[EMAIL PROTECTED]> writes: > > [...] > > | > Parenthetically, I was wondering who is freeing those extensive > | > regions of storage xmalloc/xcalloc()ed here and there? > | > | 1. The people who write the code to do the

Re: tree ssa and type issues

2005-05-21 Thread Gabriel Dos Reis
Daniel Berlin <[EMAIL PROTECTED]> writes: [...] | > Parenthetically, I was wondering who is freeing those extensive | > regions of storage xmalloc/xcalloc()ed here and there? | | 1. The people who write the code to do the xmalloc'ing. | 2. Every couple of months, people run gcc through valgrind

Re: tree ssa and type issues

2005-05-21 Thread Gabriel Dos Reis
Daniel Berlin <[EMAIL PROTECTED]> writes: | On Sat, 2005-05-21 at 18:55 +0200, Andreas Jaeger wrote: | > Gabriel Dos Reis <[EMAIL PROTECTED]> writes: | > | > > Hi again, | > > | > > I just hit this one from tree-ssa-into.c:rewrite_into_ssa() | > > | > > /* Initialize dominance frontier. */ | >

Re: tree ssa and type issues

2005-05-21 Thread Gabriel Dos Reis
Tom Tromey <[EMAIL PROTECTED]> writes: | > "Gabriel" == Gabriel Dos Reis <[EMAIL PROTECTED]> writes: | | Gabriel> I just hit this one from tree-ssa-into.c:rewrite_into_ssa() | Gabriel> /* Initialize dominance frontier. */ | Gabriel> dfs = (bitmap *) xmalloc (last_basic_block * sizeof (bi

Re: tree ssa and type issues

2005-05-21 Thread Daniel Berlin
On Sat, 2005-05-21 at 20:33 +0200, Gabriel Dos Reis wrote: > Andreas Jaeger <[EMAIL PROTECTED]> writes: > > | Gabriel Dos Reis <[EMAIL PROTECTED]> writes: > | > | > Hi again, > | > > | > I just hit this one from tree-ssa-into.c:rewrite_into_ssa() > | > > | > /* Initialize dominance frontier. *

Re: tree ssa and type issues

2005-05-21 Thread Daniel Berlin
On Sat, 2005-05-21 at 18:55 +0200, Andreas Jaeger wrote: > Gabriel Dos Reis <[EMAIL PROTECTED]> writes: > > > Hi again, > > > > I just hit this one from tree-ssa-into.c:rewrite_into_ssa() > > > > /* Initialize dominance frontier. */ > > dfs = (bitmap *) xmalloc (last_basic_block * sizeof (bit

Re: tree ssa and type issues

2005-05-21 Thread Tom Tromey
> "Gabriel" == Gabriel Dos Reis <[EMAIL PROTECTED]> writes: Gabriel> I just hit this one from tree-ssa-into.c:rewrite_into_ssa() Gabriel> /* Initialize dominance frontier. */ Gabriel> dfs = (bitmap *) xmalloc (last_basic_block * sizeof (bitmap *)); Gabriel>

Re: tree ssa and type issues

2005-05-21 Thread Andreas Jaeger
Gabriel Dos Reis <[EMAIL PROTECTED]> writes: > Andreas Jaeger <[EMAIL PROTECTED]> writes: > > | Gabriel Dos Reis <[EMAIL PROTECTED]> writes: > | > | > Hi again, > | > > | > I just hit this one from tree-ssa-into.c:rewrite_into_ssa() Note update_ssa has the same problem. > | > > | > /* Initial

Re: tree ssa and type issues

2005-05-21 Thread Gabriel Dos Reis
Andreas Jaeger <[EMAIL PROTECTED]> writes: | Gabriel Dos Reis <[EMAIL PROTECTED]> writes: | | > Hi again, | > | > I just hit this one from tree-ssa-into.c:rewrite_into_ssa() | > | > /* Initialize dominance frontier. */ | > dfs = (bitmap *) xmalloc (last_basic_block * sizeof (bitmap *)); | >

Re: tree ssa and type issues

2005-05-21 Thread Andreas Jaeger
Gabriel Dos Reis <[EMAIL PROTECTED]> writes: > Hi again, > > I just hit this one from tree-ssa-into.c:rewrite_into_ssa() > > /* Initialize dominance frontier. */ > dfs = (bitmap *) xmalloc (last_basic_block * sizeof (bitmap *)); >^^^