Andreas Jaeger <[EMAIL PROTECTED]> writes: > Gabriel Dos Reis <[EMAIL PROTECTED]> writes: > >> Hi again, >> >> I just hit this one from tree-ssa-into.c:rewrite_into_ssa() >> >> /* Initialize dominance frontier. */ >> dfs = (bitmap *) xmalloc (last_basic_block * sizeof (bitmap *)); >> ^^^^^^^^ >> >> If the sizeof operand really supposed to be "bitmap*" and not "bitmap"? > > This indeed looks wrong - and could lead to real memory corruption > :-(.
Since bitmap is also a pointer, sizeof (bitmap) == sizeof (bitmap *). > If this is wrong, he should be changed on the 4.0 branch as well, While it's wrong, it's harmless. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
