Re: 4.3 build failure in driver-i386.c

2008-02-18 Thread Richard Guenther
On Feb 18, 2008 8:29 AM, Jakub Jelinek <[EMAIL PROTECTED]> wrote: > On Mon, Feb 18, 2008 at 03:58:26AM +0100, Rask Ingemann Lambertsen wrote: > > On Sun, Feb 17, 2008 at 11:44:18PM +0100, Jakub Jelinek wrote: > > > > > > Or we can just duplicate the 2 inline asms for __GNUC__ < 3 > > > or what is t

Re: 4.3 build failure in driver-i386.c

2008-02-17 Thread Jakub Jelinek
On Mon, Feb 18, 2008 at 03:58:26AM +0100, Rask Ingemann Lambertsen wrote: > On Sun, Feb 17, 2008 at 11:44:18PM +0100, Jakub Jelinek wrote: > > > > Or we can just duplicate the 2 inline asms for __GNUC__ < 3 > > or what is the oldest GCC that can handle the alternatives correctly. > > The __cpuid a

Re: 4.3 build failure in driver-i386.c

2008-02-17 Thread Rask Ingemann Lambertsen
On Sun, Feb 17, 2008 at 11:44:18PM +0100, Jakub Jelinek wrote: > > Or we can just duplicate the 2 inline asms for __GNUC__ < 3 > or what is the oldest GCC that can handle the alternatives correctly. > The __cpuid asm is short and the other one, while long, doesn't need > changing too often. I'

Re: 4.3 build failure in driver-i386.c

2008-02-17 Thread Jakub Jelinek
On Sun, Feb 17, 2008 at 11:07:54AM +0100, Richard Guenther wrote: > On Feb 17, 2008 10:54 AM, Andreas Schwab <[EMAIL PROTECTED]> wrote: > > "Richard Guenther" <[EMAIL PROTECTED]> writes: > > > > > I see the use of cpuid.h is wrapped inside #ifdef __GNUC__, so the issue > > > is only > > > using ol

Re: 4.3 build failure in driver-i386.c

2008-02-17 Thread Greg Schafer
Richard Guenther wrote: > On Feb 17, 2008 9:38 AM, Greg Schafer <[EMAIL PROTECTED]> wrote: >> .stabn 68,0,91,.LM210-__get_cpuid_max >> .LM210: >> #APP >> pushf{l|d} >> pushf{l|d} >> pop{l} %eax >> mov{l} {%eax, %edx|%edx, %eax} >> xor{l} {$2097152, %eax|%

Re: 4.3 build failure in driver-i386.c

2008-02-17 Thread Andreas Schwab
"Richard Guenther" <[EMAIL PROTECTED]> writes: > On Feb 17, 2008 10:54 AM, Andreas Schwab <[EMAIL PROTECTED]> wrote: >> "Richard Guenther" <[EMAIL PROTECTED]> writes: >> >> > I see the use of cpuid.h is wrapped inside #ifdef __GNUC__, so the issue >> > is only >> > using old GCC as the host compi

Re: 4.3 build failure in driver-i386.c

2008-02-17 Thread Richard Guenther
On Feb 17, 2008 10:54 AM, Andreas Schwab <[EMAIL PROTECTED]> wrote: > "Richard Guenther" <[EMAIL PROTECTED]> writes: > > > I see the use of cpuid.h is wrapped inside #ifdef __GNUC__, so the issue is > > only > > using old GCC as the host compiler (I checked 2.95 which chokes on the asm). > > Can w

Re: 4.3 build failure in driver-i386.c

2008-02-17 Thread Andreas Schwab
"Richard Guenther" <[EMAIL PROTECTED]> writes: > I see the use of cpuid.h is wrapped inside #ifdef __GNUC__, so the issue is > only > using old GCC as the host compiler (I checked 2.95 which chokes on the asm). > Can we change this guard to only allow GCC >= 3.3 which would also fix this? Won't

Re: 4.3 build failure in driver-i386.c

2008-02-17 Thread Richard Guenther
On Feb 17, 2008 10:40 AM, Richard Guenther <[EMAIL PROTECTED]> wrote: > > On Feb 17, 2008 9:38 AM, Greg Schafer <[EMAIL PROTECTED]> wrote: > > Hi, > > > > driver-i386.s: Assembler messages: > > driver-i386.s:2454: Error: invalid character '{' in mnemonic > > driver-i386.s:2455: Error: invalid chara

Re: 4.3 build failure in driver-i386.c

2008-02-17 Thread Richard Guenther
On Feb 17, 2008 9:38 AM, Greg Schafer <[EMAIL PROTECTED]> wrote: > Hi, > > driver-i386.s: Assembler messages: > driver-i386.s:2454: Error: invalid character '{' in mnemonic > driver-i386.s:2455: Error: invalid character '{' in mnemonic > driver-i386.s:2456: Error: invalid character '{' in mnemonic