Re: PATCH: TR1 unordered associative containers

2005-02-18 Thread Matt Austern
On Feb 18, 2005, at 9:58 AM, R. D. Flowers wrote: If this is supposed to be a list of SOME primes, no problem. If it is supposed to be a list of ALL primes up to that size, YES a problem. It is supposed to be a list of some primes less than 2^32. A list of all primes up to that size would be too

Re: PATCH: TR1 unordered associative containers

2005-02-18 Thread R. D. Flowers
Subject: PATCH: TR1 unordered associative containers From: Matt Austern <[EMAIL PROTECTED]> Date: Thu, 17 Feb 2005 15:47:03 -0800 To: libstdc++ <[EMAIL PROTECTED]>, gcc mailing list To: libstdc++ <[EMAIL PROTECTED]>, gcc mailing list + template + const unsigned long X::p

Re: PATCH: TR1 unordered associative containers

2005-02-18 Thread Paolo Carlini
Matt Austern wrote: By the way, it's up to you what to do exactly with libstdc++/19554... I think I agree with you: no point in fixing enhancement requests in obsolete components Fine, I closed it as WONTFIX (the audit trail explains sufficiently clearly, in my opinion, what WONTFIX means in this

Re: PATCH: TR1 unordered associative containers

2005-02-17 Thread Matt Austern
On Feb 17, 2005, at 3:57 PM, Paolo Carlini wrote: Hi Matt, I'm sure there are still lots of horrible bugs, which will only be found with a more complete test suite. But the core functionality works, and at this point I think it'll improve faster in the CVS server than sitting on my hard disk

Re: PATCH: TR1 unordered associative containers

2005-02-17 Thread Matt Austern
On Feb 17, 2005, at 4:03 PM, Paolo Carlini wrote: Matt Austern wrote: OK to commit to mainline? ... before going to sleep, two very simple, slighlty less enthusiastic comments ;) 1- Please add 2005 to the copyrights. Fixed. 2- I see that the table of primes assumes that unsigned long is 32-bit: w

Re: PATCH: TR1 unordered associative containers

2005-02-17 Thread Matt Austern
On Feb 17, 2005, at 4:18 PM, Joe Buck wrote: On Thu, Feb 17, 2005 at 03:47:03PM -0800, Matt Austern wrote: I'm sure there are still lots of horrible bugs, which will only be found with a more complete test suite. But the core functionality works, and at this point I think it'll improve faster in t

Re: PATCH: TR1 unordered associative containers

2005-02-17 Thread Gabriel Dos Reis
Joe Buck <[EMAIL PROTECTED]> writes: | On Thu, Feb 17, 2005 at 03:47:03PM -0800, Matt Austern wrote: | > I'm sure there are still lots of horrible bugs, which will only be | > found with a more complete test suite. But the core functionality | > works, and at this point I think it'll improve

Re: PATCH: TR1 unordered associative containers

2005-02-17 Thread Joe Buck
Joe Buck wrote: > >A namespace purity nitpick: > > > >You define a macro named tr1_hashtable_define_trivial_hash. Shouldn't > >that be __tr1_hashtable_define_trivial_hash or something similar? On Fri, Feb 18, 2005 at 12:23:12AM +, Chris Jefferson wrote: > Having just read through, everything

Re: PATCH: TR1 unordered associative containers

2005-02-17 Thread Chris Jefferson
Joe Buck wrote: On Thu, Feb 17, 2005 at 03:47:03PM -0800, Matt Austern wrote: I'm sure there are still lots of horrible bugs, which will only be found with a more complete test suite. But the core functionality works, and at this point I think it'll improve faster in the CVS server than s

Re: PATCH: TR1 unordered associative containers

2005-02-17 Thread Joe Buck
On Thu, Feb 17, 2005 at 03:47:03PM -0800, Matt Austern wrote: > I'm sure there are still lots of horrible bugs, which will only be > found with a more complete test suite. But the core functionality > works, and at this point I think it'll improve faster in the CVS server > than sitting on m

Re: PATCH: TR1 unordered associative containers

2005-02-17 Thread Paolo Carlini
Matt Austern wrote: OK to commit to mainline? About your rethoric question: you made the mistake of creating the CVS dirs before actually asking, thus making the nice surprise a little less effective ;) ;) Paolo.

Re: PATCH: TR1 unordered associative containers

2005-02-17 Thread Benjamin Kosnik
> I'm sure there are still lots of horrible bugs, which will only be > found with a more complete test suite. But the core functionality > works, and at this point I think it'll improve faster in the CVS server > than sitting on my hard disk. Yep. > OK to commit to mainline? Sounds like

Re: PATCH: TR1 unordered associative containers

2005-02-17 Thread Paolo Carlini
Matt Austern wrote: OK to commit to mainline? ... before going to sleep, two very simple, slighlty less enthusiastic comments ;) 1- Please add 2005 to the copyrights. 2- I see that the table of primes assumes that unsigned long is 32-bit: we should do something about this, sooner or later... Pao

Re: PATCH: TR1 unordered associative containers

2005-02-17 Thread Mike Stump
On Feb 17, 2005, at 3:47 PM, Matt Austern wrote: I'm sure there are still lots of horrible bugs OK to commit to mainline? Please, the copyright seems wrong. I think that should be fixed before it goes in.

Re: PATCH: TR1 unordered associative containers

2005-02-17 Thread Paolo Carlini
Hi Matt, I'm sure there are still lots of horrible bugs, which will only be found with a more complete test suite. But the core functionality works, and at this point I think it'll improve faster in the CVS server than sitting on my hard disk. OK to commit to mainline? As far as I'm concern