Joe Buck wrote: > >A namespace purity nitpick: > > > >You define a macro named tr1_hashtable_define_trivial_hash. Shouldn't > >that be __tr1_hashtable_define_trivial_hash or something similar?
On Fri, Feb 18, 2005 at 12:23:12AM +0000, Chris Jefferson wrote: > Having just read through, everything seems very reasonable to me, but I > think there is a general need a liberal splattering of __ here, there > and everywhere :) It would be very nice if we could stop having to > prefix everything with __ and just pop it into a namespace instead, but > fixing that is perhaps something for another day :) I only singled out the macro, because namespaces have no effect on macros.
