Re: [Fortran, Patch, PR110033, v1] Fix associate for coarrays

Hi Andre, Am 12.08.24 um 14:11 schrieb Andre Vehreschild: Hi all, the attached two patches fix ASSOCIATE for coarrays, i.e. that a coarray associated to a variable is also a coarray in the block of the ASSOCIATE command. The patch has two parts: 1. pr110033p1_1.patch: Adds a corank member to t

Re: [PATCH] Fortran: fix minor frontend GMP leaks

Hi Andre, Am 14.08.24 um 07:53 schrieb Andre Vehreschild: Hi Harald, I had a hard time to figure why this is correct, when gfc_array_size() returned false, but now I get it. Ok to commit. I know that reading code is always twice as hard as writing it... ;-) Thanks for checking. Pushed as r1

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

Thank you, Iain. I have adjusted a longer line and added an intro sentence before changelog record. On Wed, Aug 14, 2024 at 8:24 PM Iain Sandoe wrote: > > > > On 14 Aug 2024, at 13:17, Sergey Fedorov wrote: > > > > > > > > On Wed, Aug 14, 2024 at 8:03 PM FX Coudert wrote: > > > Thank you for

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

> On 14 Aug 2024, at 13:17, Sergey Fedorov wrote: > > > > On Wed, Aug 14, 2024 at 8:03 PM FX Coudert wrote: > > Thank you for responding. > > I have added a changelog (is this a correct way?). > > Content seems ok, lines are maybe too long. Check with > contrib/gcc-changelog/git_check_com

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

On Wed, Aug 14, 2024 at 8:03 PM FX Coudert wrote: > > Thank you for responding. > > I have added a changelog (is this a correct way?). > > Content seems ok, lines are maybe too long. Check with > contrib/gcc-changelog/git_check_commit.py before pushing. > Once that is fine, OK to push. > Looks l

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

> Thank you for responding. > I have added a changelog (is this a correct way?). Content seems ok, lines are maybe too long. Check with contrib/gcc-changelog/git_check_commit.py before pushing. Once that is fine, OK to push. FX

Re: [Fortran, Patch, PR110033, v1] Fix associate for coarrays

Hi Andre, >From a very rapid scan(in the style of somebody on vacation :-) ) of the two patches, it all looks good to me. Adding the corank structure to gfc_expr is long overdue. Thanks also for rolling select type into the second patch. It would be good if you would check if PRs 46371 and 56496 a

Re: [patch, fortran] First part of Fortran's unsigned implementation

Hi Thomas, > > may I ask you to run contrib/check_GNU_style.py on your patch? At least on > > my system more than lines 50 are reported. I am drawn to this style issues > > and find it hard to digest the beef of the patch. That's my personal OCD > > unfortunately. > > I did so, and fixed most of w

Re: [Fortran, Patch, PR102973, v1] Reset flag for parsing proc_ptrs in associate in error case

Hi Harald, thanks for the review. Comitted as gcc-15-2911-g54be14bfd6e. Do you have time for reviewing the pr110033 fix? See here: https://gcc.gnu.org/pipermail/fortran/2024-August/060814.html Yes, it looks lengthy, but it is always the same propagation of the corank and bit of meat in the secon

Re: [Fortran, Patch, PR116292, v1] Fix 15-regression in move_alloc

Hi Thomas, thanks for the review. Committed as gcc-15-2910-gbb2324769c5 Thanks again, Andre On Tue, 13 Aug 2024 13:34:44 +0200 Thomas Koenig wrote: > Hi Andre, > > > attached patch fixes a regression introduced by my previous patch on > > handling _vptr's more consistently. The patch g

Re: [PATCH, gfortran] libgfortran: implement fpu-macppc for Darwin, support IEEE arithmetic

Thank you for responding. I have added a changelog (is this a correct way?). Sergey On Wed, Aug 14, 2024 at 12:58 AM FX Coudert wrote: > Hi, > > > I dropped a change to the test file, since you have fixed it > appropriately, and switched to Apple libm convention for flags, as you have > suggest