Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: add avformat_query_seekable

2025-04-21 Thread Gyan Doshi
On 2025-04-21 11:59 pm, Stefano Sabatini wrote: On date Tuesday 2025-04-15 16:09:56 +0530, Gyan Doshi wrote: Utility function to report seekability features for a given input. Useful for ffprobe and to extend seek possibilities in fftools. --- v2: made constants more descriptive add

Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of stream start offsets

2025-04-21 Thread Gyan Doshi
On 2025-04-22 02:22 am, softworkz . wrote: -Original Message- From: ffmpeg-devel On Behalf Of Marton Balint Sent: Montag, 21. April 2025 22:18 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of stream start offsets

[FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-04-21 Thread softworkz .
Hi Stefano, Andreas, Nicolas and of course, anybody who's interested in the AVTextFormat APIs, let me start by saying that I have no intention to rush the publicization of those APIs. I think there's still a way to go. But it's also true that when you don't have a clear understanding of where yo

Re: [FFmpeg-devel] [PATCH] postproc/postprocess_template: Fix reading uninitialized pixels in dering_C()

2025-04-21 Thread Kieran Kunhya via ffmpeg-devel
On Tue, 22 Apr 2025, 00:44 Michael Niedermayer, wrote: > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > I thought we decided postproc work in STF wasn't going to happen? Note that the STF wiki doesn't mention anything about bugfixes to libpostproc. Kieran >

[FFmpeg-devel] [PATCH] postproc/postprocess_template: Fix reading uninitialized pixels in dering_C()

2025-04-21 Thread Michael Niedermayer
Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libpostproc/postprocess_template.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libpostproc/postprocess_template.c b/libpostproc/postprocess_template.c index f0e3c50d88c..05735433adb 10

Re: [FFmpeg-devel] [PATCH] [RFC] global/clang-format: Add .clang-format configuration for consistent formatting

2025-04-21 Thread softworkz .
> -Original Message- > From: softworkz > Sent: Dienstag, 22. April 2025 01:53 > To: [email protected] > Cc: softworkz ; softworkz > > Subject: [PATCH] [RFC] global/clang-format: Add .clang-format > configuration for consistent formatting > > From: softworkz > > This is an attem

[FFmpeg-devel] [PATCH] [RFC] global/clang-format: Add .clang-format configuration for consistent formatting

2025-04-21 Thread softworkz
From: softworkz This is an attempt to create and establish a common definition for code formatting. Besides .clang-format, there don't seem to be many good candidates for C when looking for non-proprietary open-source solutions, so there's wasn't really much choice. I have tried to configure eve

Re: [FFmpeg-devel] [PATCH 2/6] lavf: APV demuxer

2025-04-21 Thread Michael Niedermayer
On Sat, Apr 19, 2025 at 08:07:00PM +0100, Mark Thompson wrote: > Demuxes raw streams as defined in draft spec section 10.2. > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/apvdec.c | 245 +++ > 3 files changed, 247

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: update stream info when PMT ES stream_type changes

2025-04-21 Thread Michael Niedermayer
Hi Pavel On Sat, Apr 19, 2025 at 10:18:29AM -0600, Pavel Koshevoy wrote: > I have a couple of .ts captures where video and audio codec changes > even though the PMT version does not change and the PIDs stay the same. > --- > libavformat/mpegts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of stream start offsets

2025-04-21 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marton Balint > Sent: Montag, 21. April 2025 22:18 > To: FFmpeg development discussions and patches [email protected]> > Subject: Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of > stream start offsets > > > > On M

Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of stream start offsets

2025-04-21 Thread Marton Balint
On Mon, 21 Apr 2025, softworkz . wrote: -Original Message- From: ffmpeg-devel On Behalf Of Marton Balint Sent: Montag, 21. April 2025 21:32 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of stream start offsets

Re: [FFmpeg-devel] [PATCH] avutil/map: [WIP] Introduction

2025-04-21 Thread Marton Balint
On Sun, 20 Apr 2025, Michael Niedermayer wrote: Note, help is welcome. Time i spend on this, i cannot spend on other things Note2: i intend to push AVMap after the release unless the release ends up delayed alot for other reasons, theres no real reason to hurry here except that i seem to keep

Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of stream start offsets

2025-04-21 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marton Balint > Sent: Montag, 21. April 2025 21:32 > To: FFmpeg development discussions and patches [email protected]> > Subject: Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of > stream start offsets > > > > On M

Re: [FFmpeg-devel] [PATCH v2 5/6] lavc/apv: AVX2 transquant for x86-64

2025-04-21 Thread Mark Thompson
On 21/04/2025 17:53, James Almer wrote: > On 4/21/2025 12:24 PM, Mark Thompson wrote: >> Typical checkasm result on Alder Lake: >> >> decode_transquant_8_c: 461.1 ( 1.00x) >> decode_transquant_8_avx2:   97.5 ( 4.73x) >> decode_transquant_1

Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of stream start offsets

2025-04-21 Thread Marton Balint
On Mon, 21 Apr 2025, softworkz . wrote: -Original Message- From: ffmpeg-devel On Behalf Of Gyan Doshi Sent: Montag, 21. April 2025 06:51 To: [email protected] Subject: Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of stream start offsets On 2025-04-21 01:41 a

[FFmpeg-devel] [PATCH 1/5] avcodec/cri, tdsc, tiff: Use ff_mjpeg_decoder directly

2025-04-21 Thread Andreas Rheinhardt
Patches attached. - Andreas From 56445c4d007f74b4b51282184b773791f6b24641 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Mon, 21 Apr 2025 18:48:10 +0200 Subject: [PATCH 1/5] avcodec/cri,tdsc,tiff: Use ff_mjpeg_decoder directly This is simpler than calling avcodec_find_decoder(). Notice

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: add avformat_query_seekable

2025-04-21 Thread Stefano Sabatini
On date Tuesday 2025-04-15 16:09:56 +0530, Gyan Doshi wrote: > Utility function to report seekability features for a given input. > > Useful for ffprobe and to extend seek possibilities in fftools. > --- > v2: >made constants more descriptive >add exception for rtsp false negative seekabil

[FFmpeg-devel] [PATCH] avformat: Use ffio_read_size() where appropriate

2025-04-21 Thread Andreas Rheinhardt
Patch attached. - Andreas From e4ca407ca3ccbea4177ec89048e1b38833b86e36 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Mon, 21 Apr 2025 19:54:38 +0200 Subject: [PATCH] avformat: Use ffio_read_size() where appropriate Signed-off-by: Andreas Rheinhardt --- libavformat/argo_brp.c | 37 ++

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/takdec.c: Fix msan error.

2025-04-21 Thread Thierry Foucu
On Mon, Apr 21, 2025 at 10:01 AM Nicolas George wrote: > Thierry Foucu (HE12025-04-21): > > > >> -avio_read(pb, md5, 16); > > > >> +if (avio_read(pb, md5, 16) != 16) { > > > >> +return AVERROR(EIO); > > > Should be AVERROR_INVALIDDATA imo, since i means the

Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: Quality improvements

2025-04-21 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Montag, 21. April 2025 19:21 > To: FFmpeg development discussions and patches [email protected]> > Subject: Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: > Quality improvements > > Stefano Sabatin

Re: [FFmpeg-devel] [PATCH v4 03/11] fftools/textformat: Introduce common header and deduplicate code

2025-04-21 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Montag, 21. April 2025 19:29 > To: FFmpeg development discussions and patches [email protected]> > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH v4 03/11] fftools/textformat: > Introduce common header and deduplicate code > > O

Re: [FFmpeg-devel] [PATCH v4 04/11] fftools/tf_internal: Use ac_default_item_name

2025-04-21 Thread Stefano Sabatini
On date Sunday 2025-04-20 22:59:07 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/textformat/tf_internal.h | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) Typo in commit headling: ac_default... -> av_default... > > diff --git a/fftools/tex

Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: Quality improvements

2025-04-21 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Montag, 21. April 2025 19:17 > To: FFmpeg development discussions and patches [email protected]> > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: > Quality improvements > > On date Sunday 2025-04-2

Re: [FFmpeg-devel] [PATCH v4 03/11] fftools/textformat: Introduce common header and deduplicate code

2025-04-21 Thread Stefano Sabatini
On date Sunday 2025-04-20 22:59:06 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz first part should be good [...] > diff --git a/fftools/textformat/tw_avio.c b/fftools/textformat/tw_avio.c > index d1b494b7b4..48868ebf5d 100644 > --- a/fftools/textformat/tw_avio.c > ++

Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: Quality improvements

2025-04-21 Thread Nicolas George
Stefano Sabatini (HE12025-04-21): > > +if (!pwctx || !avio_ctx) > > +return AVERROR(EINVAL); > > + > maybe warning in this case as well Checking that an argument that must not be null is not null is the responsibility of the caller: crashing here is the right thing to do, same as fprin

Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: Quality improvements

2025-04-21 Thread Stefano Sabatini
On date Sunday 2025-04-20 22:59:05 +, softworkz wrote: > From: softworkz > Nazigrammar commit log nit: use verb to specify the change action, like in: apply quality improvements Also probably want to have some more details below the headline, like: Perform multiple improvements to increase

Re: [FFmpeg-devel] [PATCH 1/9] fftools/textformat: Formatting and whitespace changes

2025-04-21 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Montag, 21. April 2025 18:53 > To: FFmpeg development discussions and patches [email protected]> > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH 1/9] fftools/textformat: Formatting > and whitespace changes > > On date Monday 2

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/takdec.c: Fix msan error.

2025-04-21 Thread Nicolas George
Thierry Foucu (HE12025-04-21): > > >> -avio_read(pb, md5, 16); > > >> +if (avio_read(pb, md5, 16) != 16) { > > >> +return AVERROR(EIO); > > Should be AVERROR_INVALIDDATA imo, since i means the file is just > > truncated. It wasn't an error in the protocol rea

Re: [FFmpeg-devel] [PATCH v3 3/3] lavc/dxvenc: improve compatibility with Resolume products

2025-04-21 Thread Emma Worley
On Mon, Apr 21, 2025 at 4:19 AM Andreas Rheinhardt < [email protected]> wrote: > Emma Worley: > > Improves compatibility with Resolume products by adding an additional > hashtable > > for DXT color+LUT combinations, and padding the DXT texture to the next > largest > > 16x16 multiple.

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/takdec.c: Fix msan error.

2025-04-21 Thread Thierry Foucu
Thanks James On Thu, Apr 17, 2025 at 1:25 PM James Almer wrote: > On 4/17/2025 4:08 PM, Thierry Foucu wrote: > > On Mon, Apr 7, 2025 at 11:10 AM wrote: > > > >> From: Thierry Foucu > >> > >> Make sure we are reading 16 bytes for the MD5 > >> --- > >> libavformat/takdec.c | 5 - > >> 1 f

Re: [FFmpeg-devel] [PATCH v3] fftools/ffprobe: Print size of attachments

2025-04-21 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Montag, 21. April 2025 18:14 > To: FFmpeg development discussions and patches [email protected]> > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH v3] fftools/ffprobe: Print size of > attachments > > On date Sunday 2025-04-20 20

Re: [FFmpeg-devel] [PATCH v2 5/6] lavc/apv: AVX2 transquant for x86-64

2025-04-21 Thread James Almer
On 4/21/2025 12:24 PM, Mark Thompson wrote: Typical checkasm result on Alder Lake: decode_transquant_8_c: 461.1 ( 1.00x) decode_transquant_8_avx2: 97.5 ( 4.73x) decode_transquant_10_c:483.9 ( 1.00x) dec

Re: [FFmpeg-devel] [PATCH 1/9] fftools/textformat: Formatting and whitespace changes

2025-04-21 Thread Stefano Sabatini
On date Monday 2025-04-14 12:46:58 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/textformat/avtextformat.c | 104 +++-- > fftools/textformat/avtextformat.h | 16 ++--- > fftools/textformat/avtextwriters.h | 11 ++- > fftools/t

Re: [FFmpeg-devel] [PATCH v3] fftools/ffprobe: Print size of attachments

2025-04-21 Thread Stefano Sabatini
On date Sunday 2025-04-20 20:15:41 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/ffprobe: Print size of attachments > > > Versions > > > V2 > > Fix spurious commit message text as noted by Andreas (thanks!)

Re: [FFmpeg-devel] [REFUND-REQUEST] Ryzen 9 CPU + Mainboard + RAM

2025-04-21 Thread Stefano Sabatini
On date Wednesday 2025-04-09 17:44:29 +0200, Niklas Haas wrote: > Hi all, > > I ordered the parts as discussed and approved in the previous thread: > https://ffmpeg.org//pipermail/ffmpeg-devel/2025-April/341873.html > > The total cost was 1381.28 EUR. This is approved on my side, pending Michael

[FFmpeg-devel] [PATCH v2 5/6] lavc/apv: AVX2 transquant for x86-64

2025-04-21 Thread Mark Thompson
Typical checkasm result on Alder Lake: decode_transquant_8_c: 461.1 ( 1.00x) decode_transquant_8_avx2: 97.5 ( 4.73x) decode_transquant_10_c:483.9 ( 1.00x) decode_transquant_10_avx2:

Re: [FFmpeg-devel] [PATCH 2/6] lavf: APV demuxer

2025-04-21 Thread Andreas Rheinhardt
Mark Thompson: > On 21/04/2025 01:54, Michael Niedermayer wrote: >> On Sat, Apr 19, 2025 at 08:07:00PM +0100, Mark Thompson wrote: >>> Demuxes raw streams as defined in draft spec section 10.2. >>> --- >>> libavformat/Makefile | 1 + >>> libavformat/allformats.c | 1 + >>> libavformat/apvd

[FFmpeg-devel] [PATCH v2 6/6] lavc: APV metadata bitstream filter

2025-04-21 Thread Mark Thompson
--- libavcodec/bitstream_filters.c | 1 + libavcodec/bsf/Makefile| 1 + libavcodec/bsf/apv_metadata.c | 134 + 3 files changed, 136 insertions(+) create mode 100644 libavcodec/bsf/apv_metadata.c diff --git a/libavcodec/bitstream_filters.c b/libavcodec

[FFmpeg-devel] [PATCH v2 4/6] lavc: APV decoder

2025-04-21 Thread Mark Thompson
--- configure| 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/apv_decode.c | 331 +++ libavcodec/apv_decode.h | 80 ++ libavcodec/apv_dsp.c | 136 libavcodec/apv_dsp.h |

[FFmpeg-devel] [PATCH v2 3/6] lavf: APV demuxer

2025-04-21 Thread Mark Thompson
Demuxes raw streams as defined in draft spec section 10.2. --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/apvdec.c | 248 +++ 3 files changed, 250 insertions(+) create mode 100644 libavformat/apvdec.c diff --git a/libav

[FFmpeg-devel] [PATCH v2 1/6] lavc: APV codec ID and descriptor

2025-04-21 Thread Mark Thompson
--- libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + 2 files changed, 8 insertions(+) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 9fb190e35a..88fed478a3 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -1985,6 +1985,13 @@ static con

[FFmpeg-devel] [PATCH v2 2/6] lavc/cbs: APV support

2025-04-21 Thread Mark Thompson
--- configure| 1 + libavcodec/Makefile | 1 + libavcodec/apv.h | 86 libavcodec/cbs.c | 6 + libavcodec/cbs_apv.c | 395 ++ libavcodec/cbs_apv.h | 207 +

[FFmpeg-devel] [PATCH v2 0/6] APV support

2025-04-21 Thread Mark Thompson
v2 incorporating review comments and minor additional optimisations. Thanks, - Mark Mark Thompson (6): lavc: APV codec ID and descriptor lavc/cbs: APV support lavf: APV demuxer lavc: APV decoder lavc/apv: AVX2 transquant for x86-64 lavc: APV metadata bitstream filter configure

Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Maintain consistency of frame pointers

2025-04-21 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Right now it is possible for the pointer for the current frame to > be set in the context even when it could not be properly set up; > this does not influence various the ordinary ref frames, but only > VP8Context.prev_frame. And since this code has been ported to the > Progre

Re: [FFmpeg-devel] [PATCH] avutil/map: [WIP] Introduction

2025-04-21 Thread Nicolas George
Michael Niedermayer (HE12025-04-20): > theres no real reason > to hurry here (This is me applauding.) > except that i seem to keep workig on it when > people ask for some non trivial changes/improvments :) As long as you have fun. > so dont

Re: [FFmpeg-devel] [PATCH 2/6] lavf: APV demuxer

2025-04-21 Thread Mark Thompson
On 21/04/2025 01:54, Michael Niedermayer wrote: > On Sat, Apr 19, 2025 at 08:07:00PM +0100, Mark Thompson wrote: >> Demuxes raw streams as defined in draft spec section 10.2. >> --- >> libavformat/Makefile | 1 + >> libavformat/allformats.c | 1 + >> libavformat/apvdec.c | 245

Re: [FFmpeg-devel] [PATCH 4/6] lavc: APV decoder

2025-04-21 Thread James Almer
On 4/19/2025 4:07 PM, Mark Thompson wrote: --- configure| 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/apv_decode.c | 327 +++ libavcodec/apv_decode.h | 80 ++ libavcodec/apv_dsp.c |

Re: [FFmpeg-devel] [PATCH v12 1/8] libavcodec/decode.c: intercept `AV_PKT_DATA_METADATA_UPDATE` packet extra data, attach them to the next decoded frame.

2025-04-21 Thread Romain Beauxis
Le dim. 20 avr. 2025 à 15:08, Michael Niedermayer a écrit : > > On Tue, Apr 15, 2025 at 05:22:29PM -0500, Romain Beauxis wrote: > > --- > > libavcodec/decode.c | 19 +++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > > index f

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mb: Fix buffer stride for arm

2025-04-21 Thread Bin Peng
On 2025/4/16 8:24, Michael Niedermayer wrote: > On Tue, Apr 08, 2025 at 07:22:32PM +0800, Bin Peng wrote: >> When decoding a bitstream with weighted-bipred enabled, >> the results on ARM and x86 platforms may differ. >> >> The reason for the inconsistency is that the value of >> STRIDE_ALIGN dif

Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of stream start offsets

2025-04-21 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Gyan > Doshi > Sent: Montag, 21. April 2025 06:51 > To: [email protected] > Subject: Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of > stream start offsets > > > > On 2025-04-21 01:41 am, softworkz wrote: > >

[FFmpeg-devel] [PATCH 01/13] avcodec/huffman: Switch to ff_vlc_init_from_lengths()

2025-04-21 Thread Andreas Rheinhardt
Patches attached. - Andreas From 89a16c8e6efe441bf745ff1cf59296a2b97daf71 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Thu, 17 Apr 2025 15:43:31 +0200 Subject: [PATCH 01/13] avcodec/huffman: Switch to ff_vlc_init_from_lengths() Avoids having to create the codes ourselves. Signed-off-

[FFmpeg-devel] [PATCH v6] avcodec/dvbsubenc: add a disable_2bpp option to work around some decoders.

2025-04-21 Thread Ronan Waide
[rebasing against current HEAD since there were some conflicting changes] As noted in the code in several places, some DVB subtitle decoders don't handle 2bpp color. This patch adds a disable_2bpp option which disables the 2bpp format; subtitles which would use 2bpp will be bumped up to 4bpp. Per

Re: [FFmpeg-devel] [PATCH v3 3/3] lavc/dxvenc: improve compatibility with Resolume products

2025-04-21 Thread Andreas Rheinhardt
Emma Worley: > Improves compatibility with Resolume products by adding an additional > hashtable > for DXT color+LUT combinations, and padding the DXT texture to the next > largest > 16x16 multiple. Produces identical packets to Resolume Alley in manual tests. > Are the files that this encoder

Re: [FFmpeg-devel] [PATCH v3 2/3] lavc/dxvenc: migrate DXT1 encoder to lavu hashtable

2025-04-21 Thread Nicolas George
Emma Worley (HE12025-04-20): > Offers a modest performance gain due to the switch from naive linear > probling to robin hood. Thanks for splitting the commits. I do not know this encoder, I cannot comment on the specifics of the patch. Regards, -- Nicolas George __

Re: [FFmpeg-devel] [PATCH v3 1/3] lavu/hashtable: create generic robin hood hash table

2025-04-21 Thread Nicolas George
Emma Worley (HE12025-04-20): > Adds a general purpose hash table with the DXV encoder as an initial use case. I still think it is too specific to be called general purpose and exposed as a public API. Better move it in lavc and rename it ff_hashtable. Regards, -- Nicolas George __

Re: [FFmpeg-devel] [PATCH] avfilter/volume: optimize redundant code for af_volume

2025-04-21 Thread Zhao Zhili
> On Apr 21, 2025, at 14:04, Shiqi Zhu wrote: > > Signed-off-by: Shiqi Zhu > --- > libavfilter/af_volume.c | 18 ++ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c > index 471bffeceb..c16188524d 100644 > ---