Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: Quality improvements

Mon, 21 Apr 2025 10:40:41 -0700 


> -----Original Message-----
> From: ffmpeg-devel <[email protected]> On Behalf Of
> Nicolas George
> Sent: Montag, 21. April 2025 19:21
> To: FFmpeg development discussions and patches <ffmpeg-
> [email protected]>
> Subject: Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat:
> Quality improvements
> 
> Stefano Sabatini (HE12025-04-21):
> > > +    if (!pwctx || !avio_ctx)
> > > +        return AVERROR(EINVAL);
> > > +
> > maybe warning in this case as well
> 
> Checking that an argument that must not be null is not null is the
> responsibility of the caller: crashing here is the right thing to do,
> same as fprintf(NULL, "fmt").
> 
> Therefore, an assertion is the best choice.
> 
> Regards,
> 
> --
>   Nicolas George
> _______________________________________________

Okay, I'll do that. 

Thank you.
sw
_______________________________________________
ffmpeg-devel mailing list
[email protected]
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
[email protected] with subject "unsubscribe".

























					Reply via email to