Tomas Jelinek has abandoned this change.
Change subject: webadmin: Network builders
..
Patch Set 4: Abandoned
implemented as a part of http://gerrit.ovirt.org/#/c/15102/
--
To view, visit http://gerrit.ovirt.org/13918
To unsub
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4: I would prefer that you didn't submit this
Of course we can compromise on some solution - I have no desire to push my
Daniel Erez has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4: I would prefer that you didn't submit this
I understand the need for code re-usage in favor of instance types dialogs.
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/13918
To unsubscribe, visit http:/
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4:
I agree that util class with static methods is a very bad idea.
This is not what I suggested.
I suggested to use somet
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4:
Well, consider the following disadvantages of static utility methods:
- no way to use inheritance (like BaseInitSelec
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4:
I prefer to move the common code to one helper class (maybe something like the
vm behaviours classes) and not to a lot
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4:
This was actually the first thing I have tried to do :)
It is problematic because of the following reasons:
- Network
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4:
Thanks for the explanation:)
I understand the vm model cannot extend the vnic models.
In this case I suggest the VmMode
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4:
Because the "new VM dialog" will contain a part where you will be able to
select a NIC and assign it to a logical net
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4:
Hi Tomas,
I don't really understand why do you need builders here.
Why can't you use the current models for the instan
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/13918
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/13918
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Network builders
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/13918
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Tomas Jelinek has uploaded a new change for review.
Change subject: webadmin: Network builders
..
webadmin: Network builders
Instance types Phase 1: extract and merge common code
as builders from models.
This will be needed by
15 matches
Mail list logo
