Einav Cohen has submitted this change and it was merged.
Change subject: userportal: Optimize basic view
..
userportal: Optimize basic view
1. Fixed VmPool.equals method
2. Added UserPortalItemModel.entityStateEqualTo method
Einav Cohen has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 18: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/10509
To unsubscribe, visi
Alexander Wels has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 17: Verified
--
To view, visit http://gerrit.ovirt.org/10509
To unsubscribe, visit http://gerrit.ovirt.org/settings
Tomas Jelinek has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 17: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10509
To unsubscribe, visit http://gerrit.o
Einav Cohen has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 17:
rebased and re-pushed the entire patch-chain in an attempt to eliminate the
double "Needed By" that existed for h
Tomas Jelinek has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 13: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10509
To unsubscribe, visit http://gerrit.o
Alexander Wels has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 13: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10509
To unsubscribe,
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 7:
Let me check this, but I thought "selectedItems" handling in
UserPortalDataBoundModelProvider was meant to serve
Alexander Wels has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 7: Verified
Fixed the issue where the selected item got reset every refresh for no reason.
--
To view, visit http:
Alexander Wels has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 6: Fails
Unfortunately this won't be the last version. The optimization does not keep
the current selected VM, sel
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 6:
This is (hopefully) the final version of the patch.
--
To view, visit http://gerrit.ovirt.org/10509
To unsubscri
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 6: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10509
To unsu
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 5:
I did some changes in the meantime, will submit new patch set, rebased on top
of http://gerrit.ovirt.org/#/c/119
Alexander Wels has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 5:
Also note I purposely added the dependency on the other patch since that one
implements getId which is needed i
Alexander Wels has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 5:
Made the changes as noted in the code review of patch set 4.
--
To view, visit http://gerrit.ovirt.org/10509
To
Einav Cohen has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 4:
see my last comment in http://gerrit.ovirt.org/#/c/10579/
--
To view, visit http://gerrit.ovirt.org/10509
To unsub
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 4: (2 inline comments)
File
frontend/webadmin/modules/uicommon
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 4:
Hi Gilad, the idea behind this patch is great, I've submitted new patch set
that tries to reduce code complexity
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Optimize basic view
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modules/userporta
Gilad Chaplik has uploaded a new change for review.
Change subject: userportal: Optimize basic view
..
userportal: Optimize basic view
Currently for every refresh, the basic view
(vm boxes view/television), is getting redrawn.
I
20 matches
Mail list logo
