Vojtech Szocs has posted comments on this change. Change subject: userportal: Optimize basic view ......................................................................
Patch Set 4: Hi Gilad, the idea behind this patch is great, I've submitted new patch set that tries to reduce code complexity of this optimization. Can you please take a look and tell me what you think? Implementation notes: * UserPortalItemModel.entityStateEqualTo method has similar purpose as original UserPortalBasicListModel.shouldBeRefreshed method * Core optimization logic moved directly into MainTabBasicListPresenterWidget.onDataChange method * Using MainTabBasicListPresenterWidget.ViewDef.setCurrentItemIndex method instead of original MainTabBasicListPresenterWidget.count static field * MainTabBasicListPresenterWidget.ViewDef.clear method removed as it's no longer necessary Core optimization logic remains the same: iterating over newly received items, checking for items-to-add and items-to-update, and removing leftover items. I have verified this logic with 100 VMs, VM box UI is untouched as long as VM state doesn't change. (Previously, after each data refresh, all VM box UI was destroyed and re-created. For many VMs and short refresh rate, this was an overkill.) -- To view, visit http://gerrit.ovirt.org/10509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17b92858345de398dbc89d9141468ccea67963fe Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
