Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: engine-config bug fixes
..
tools: engine-config bug fixes
1. password file can be set via -s option
2. delete created temp file
3. add help desc
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6224
To unsubscribe, visit http://
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 1: Verified; Looks good to me, approved
This fixes a merge issue, already approved by Shahar Havivi
--
To view, vis
Hello Shahar Havivi,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/6224
to review the following change.
Change subject: tools: engine-config bug fixes
..
tools: engine-config bug fixes
1. passwor
Shahar Havivi has submitted this change and it was merged.
Change subject: tools: engine-config bug fixes
..
tools: engine-config bug fixes
1. password file can be set via -s option
2. delete created temp file
3. add help descr
Shahar Havivi has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6096
To unsubscribe, visit http://
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6096
To unsubscribe, v
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 12:
Patchset 12 - Followed Juan's comments - added out.close handling.
--
To view, visit http://gerrit.ovirt.org/60
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 11: (1 inline comment)
File
backend/manager/modules/utils/src/
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 11: (1 inline comment)
File
backend/manager/modules/utils/src/
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 11: Verified
Verified by checking that engine-manage-domains managed to add an AD domain
with composite password.
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 11:
Patchset 11 - Followed Juan's comments on patch of "chmod" command.
--
To view, visit http://gerrit.ovirt.org/6
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 10: (3 inline comments)
File
backend/manager/modules/utils/src
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 10: (3 inline comments)
See the comments in line.
In general it is advisable to avoid running external programs fro
Yair Zaslavsky has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6096
To unsubscribe, visit http://gerrit.ovi
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6096
To unsubscribe, vi
Shahar Havivi has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 8: (3 inline comments)
File
backend/manager/tools/engine-config
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 8: (3 inline comments)
I verified this with a new build. It works mostly correct, but I found an issue
with the int
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 8: Looks good to me, but someone else must approve
Shahar, thanks for taking my suggestions into consideration.
--
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 7: Looks good to me, but someone else must approve
I would like to see more File objects and less Strings, but it lo
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 6: (1 inline comment)
File
backend/manager/modules/utils/src/m
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/utils/src/m
Shahar Havivi has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/utils/src/ma
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/utils/src/m
Shahar Havivi has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/utils/src/ma
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 4: (5 inline comments)
File
backend/manager/modules/utils/src/
Doron Fediuck has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 4: (1 inline comment)
Shahar, I think you missed a mod.
See inline.
Shahar Havivi has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 3: (2 inline comments)
File
backend/manager/modules/utils/src/m
Juan Hernandez has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 3: (3 inline comments)
File
backend/manager/modules/utils/src/
Shahar Havivi has posted comments on this change.
Change subject: tools: engine-config bug fixes
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
30 matches
Mail list logo
