Juan Hernandez has posted comments on this change.

Change subject: tools: engine-config bug fixes
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ConfigurationProvider.java
Line 68:             Runtime.getRuntime().exec("/usr/bin/chmod " + filePath);
Doron, unfortunatelly in Java 6 that will help to increase the permissions, but 
not to reduce them.

In Java 7 there are a log of new file utilities in the java.nio.file package, 
which could be used to solve this without chmod, but that would mean that we 
can't compile with Java 6. Can we safely assume that?

--
To view, visit http://gerrit.ovirt.org/6096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3003f20a51bb5a62387593d914894d62b012c70b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to