[Engine-patches] Change in ovirt-engine[master]: packaging: add manual reference

2013-09-30 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: add manual reference .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19552 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: packaging: add manual reference

2013-09-30 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: add manual reference .. packaging: add manual reference empty manual to allow application to handle using single execution path. as this is

[Engine-patches] Change in ovirt-engine[master]: packaging: add manual reference

2013-09-29 Thread knesenko
Kiril Nesenko has posted comments on this change. Change subject: packaging: add manual reference .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19552 To unsubscribe, visit http://gerrit.ovirt.org/sett

[Engine-patches] Change in ovirt-engine[master]: packaging: add manual reference

2013-09-27 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: add manual reference .. Patch Set 1: > Is that ok? yes, as long as you actually do this... :) will monitor... please CC me. Thanks! -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: packaging: add manual reference

2013-09-26 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: add manual reference .. Patch Set 1: Code-Review+2 >Ok. The file doesn't currently support comments. I propose we add support for >comments, add t

[Engine-patches] Change in ovirt-engine[master]: packaging: add manual reference

2013-09-26 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: packaging: add manual reference .. Patch Set 1: Ok. The file doesn't currently support comments. I propose we add support for comments, add the template/docume

[Engine-patches] Change in ovirt-engine[master]: packaging: add manual reference

2013-09-26 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: add manual reference .. Patch Set 1: I think that having template of some sort maintained as a reference is better than empty file. -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: packaging: add manual reference

2013-09-26 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: packaging: add manual reference .. Patch Set 1: Verified+1 Code-Review+1 This can be merged as-is. It works great with empty CSV files. I personally think empt

[Engine-patches] Change in ovirt-engine[master]: packaging: add manual reference

2013-09-26 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: add manual reference .. Patch Set 1: Code-Review+1 Looks good to me on packaging side. Einav can you answer to the needinfo? -- To view, visit ht

[Engine-patches] Change in ovirt-engine[master]: packaging: add manual reference

2013-09-24 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: add manual reference .. Patch Set 1: Greg, If we need some content within the csv, just push a new version. Alon -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: packaging: add manual reference

2013-09-24 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: add manual reference .. packaging: add manual reference empty manual to allow application to handle using single execution path. as this is not reall