Greg Sheremeta has posted comments on this change.

Change subject: packaging: add manual reference
......................................................................


Patch Set 1: Verified+1 Code-Review+1

This can be merged as-is. It works great with empty CSV files. I personally 
think empty files is better than having the files contain all the window 
hashnames with empty URLs.

What do others think?

We do still need to document the csv file format, but I need Einav's help with 
that.

-- 
To view, visit http://gerrit.ovirt.org/19552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00c6a0a554bf684c38f7db21fcbf31621996a0bd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to