[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-23 Thread dfediuck
Doron Fediuck has submitted this change and it was merged. Change subject: engine: watchdog - frontend .. engine: watchdog - frontend - added watchdog to the high availability tab in the new/edit vm Change-Id: Ie3f72fabf35d32a

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-23 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 29: Verified; Looks good to me, approved Rebased. Welcoming the watchdog! -- To view, visit http://gerrit.ovirt.org/130

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-23 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 28: Looks good to me, approved No changes since last +2. -- To view, visit http://gerrit.ovirt.org/13059 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-23 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 28: Verified -- To view, visit http://gerrit.ovirt.org/13059 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-22 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 27: Verified rebased -- To view, visit http://gerrit.ovirt.org/13059 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-21 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 26: Verified -- To view, visit http://gerrit.ovirt.org/13059 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-21 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 24: Verified -- To view, visit http://gerrit.ovirt.org/13059 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-21 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 23: Verified no change -- To view, visit http://gerrit.ovirt.org/13059 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-19 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 22: Verified -- To view, visit http://gerrit.ovirt.org/13059 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-19 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 22: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13059 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-14 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 21: Verified -- To view, visit http://gerrit.ovirt.org/13059 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-13 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 19: @Laszlo, yes :) -- To view, visit http://gerrit.ovirt.org/13059 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-13 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 19: Gilad: are you referring to the watchdog model and action? Doron, Einav: do you want the watchdog model and action

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-13 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 19: please refer to my comment in patch-set 12. and localize the enums. -- To view, visit http://gerrit.ovirt.org/13059

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-13 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 19: For Gilad's request, the watchdog maintenance commands are now invoked from the Vm*command rather than as asynch o

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-05-02 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 12: (1 inline comment) File frontend/webadmin/modules/gwt-common/

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-04-30 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 12: (1 inline comment) File frontend/webadmin/modules/gwt-common/

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-04-30 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 12: (2 inline comments) File frontend/webadmin/modules/gwt-common/

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-04-30 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 12: Laszlo, add all enums (WDaction and WDtype) to both localization files (currently you are missing .java file, you u

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-04-30 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 9: Gilad, these enums should not be localized. At least I have no idea what else i6300esb could be. -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-04-30 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 9: (1 inline comment) 1) all enum values should be in LocalizedEnums .java + .properies files. 2) Does 3.1 (or below) VM

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-04-30 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 5: (3 inline comments) File frontend/webadmin/modules/uicommonweb/

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-04-29 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/13059 To unsubscribe, visit http://gerrit.ovirt.org/settings Ger

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend [wip]

2013-04-29 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: engine: watchdog - frontend [wip] .. Patch Set 6: +1 on a later patch. We need to differ the base functionality from improvements. Please add it to the feature

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-04-24 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 5: (2 inline comments) >Adding watchdog data in vm general subtab >Enabling watchdog fields according to supported >com

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-04-22 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 5: Other watchdog features that you can add: must (IMHO): * Adding watchdog data in vm general subtab * Enabling watchdo

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-04-22 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: engine: watchdog - frontend .. Patch Set 5: (7 inline comments) nice patch, some comments File frontend/we

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend [wip]

2013-04-12 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: engine: watchdog - frontend [wip] .. Patch Set 3: no change -- To view, visit http://gerrit.ovirt.org/13059 To unsubscribe, visit http://gerrit.ovirt.org/setti

[Engine-patches] Change in ovirt-engine[master]: engine: watchdog - frontend

2013-03-14 Thread lhornyak
Laszlo Hornyak has uploaded a new change for review. Change subject: engine: watchdog - frontend .. engine: watchdog - frontend - added watchdog to the high availability tab in the new/edit vm - functionality also availablt in t