[Engine-patches] Change in ovirt-engine[master]: core: findbugs cleanup

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: findbugs cleanup .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7361/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: findbugs cleanup

2013-08-28 Thread tnisan
Tal Nisan has submitted this change and it was merged. Change subject: core: findbugs cleanup .. core: findbugs cleanup Rename methods to start with lowercase, remove unused variables. Change-Id: I10c5b9bbe1aec6454e35474eae3bf

[Engine-patches] Change in ovirt-engine[master]: core: findbugs cleanup

2013-08-28 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: findbugs cleanup .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18603 To unsubscribe, visit http://gerrit.ovirt.org/settin

[Engine-patches] Change in ovirt-engine[master]: core: findbugs cleanup

2013-08-28 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: findbugs cleanup .. Patch Set 2: Verified+1 smooth rebase, jenkins build successful -- To view, visit http://gerrit.ovirt.org/18603 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: findbugs cleanup

2013-08-28 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: findbugs cleanup .. Patch Set 2: the REST changes (commented out lines) are relevant - they contain invoking the methods for which I changed the name (Conf

[Engine-patches] Change in ovirt-engine[master]: core: findbugs cleanup

2013-08-28 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: findbugs cleanup .. Patch Set 2: Code-Review+1 I'd separate the REST changes to a different patch - they're just removing commented out lines, don't real

[Engine-patches] Change in ovirt-engine[master]: core: findbugs cleanup

2013-08-27 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: findbugs cleanup .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18603 To unsubscribe, visit http://gerrit.ovirt.org/settings Ge

[Engine-patches] Change in ovirt-engine[master]: core: findbugs cleanup

2013-08-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: findbugs cleanup .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7260/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: findbugs cleanup

2013-08-27 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: core: findbugs cleanup .. Patch Set 1: Code-Review+2 Please rebase and verify so I can merge -- To view, visit http://gerrit.ovirt.org/18603 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: findbugs cleanup

2013-08-27 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: findbugs cleanup .. Patch Set 1: (1 comment) I guess +1 for OpenSslCAWrapperTest.java File backend/m

[Engine-patches] Change in ovirt-engine[master]: core: findbugs cleanup

2013-08-27 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: core: findbugs cleanup .. Patch Set 1: Verified+1 compilation and unitests -- To view, visit http://gerrit.ovirt.org/18603 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: findbugs cleanup

2013-08-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: findbugs cleanup .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7216/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: core: findbugs cleanup

2013-08-27 Thread abonas
Alissa Bonas has uploaded a new change for review. Change subject: core: findbugs cleanup .. core: findbugs cleanup Rename methods to start with lowercase, remove unused variables. Change-Id: I10c5b9bbe1aec6454e35474eae3bf4a021