Alon Bar-Lev has posted comments on this change. Change subject: core: findbugs cleanup ......................................................................
Patch Set 1: (1 comment) I guess +1 for OpenSslCAWrapperTest.java .................................................... File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapperTest.java Line 52: // // Mocking the Config class Line 53: // mockStatic(Config.class); Line 54: // when(Config.resolveSignScriptPath()).thenReturn(new String()); Line 55: // when(Config.getValue(any(ConfigValues.class))).thenReturn(new String()); Line 56: // when(Config.getValue(ConfigValues.SignCertTimeoutInSeconds)).thenReturn(defaultSignCertTimeoutInSeconds); fixing comments? this is nice! Line 57: // when(Config.resolveCABasePath()).thenReturn(new String()); Line 58: // Line 59: // // Mocking the org.ovirt.engine.core.utils FileUtil class Line 60: // mockStatic(FileUtil.class); -- To view, visit http://gerrit.ovirt.org/18603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10c5b9bbe1aec6454e35474eae3bf4a021adb95a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
