Einav Cohen has submitted this change and it was merged.
Change subject: core: broken unit test
..
core: broken unit test
Fixed a unit test that would break if a file didn't exist in a certain
environment.
Unit test now create
Einav Cohen has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 5: Verified; Looks good to me, approved
Thanks Alon.
rebased, updated commit comment, merging.
--
To view, visit http://gerrit
Alon Bar-Lev has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4:
Right. Relaying on files exists outside of project scope is not correct.
--
To view, visit http://gerrit.ovirt.org/14327
T
Einav Cohen has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4:
Alex/Alon: before I merge, just to make sure I understand what this patch is
doing (and it should be reflected in the commi
Alon Bar-Lev has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4:
So who can merge this?!?!
--
To view, visit http://gerrit.ovirt.org/14327
To unsubscribe, visit http://gerrit.ovirt.org/se
Yair Zaslavsky has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14327
To unsubscribe, visit htt
Alon Bar-Lev has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4:
Please merge
--
To view, visit http://gerrit.ovirt.org/14327
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Alexander Wels has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4:
Fixed the broken tests, and improved them from the initial patch.
--
To view, visit http://gerrit.ovirt.org/14327
To uns
Alon Bar-Lev has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/14327
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mes
Alexander Wels has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4: Verified
It helps if I fix all the broken unit tests.
--
To view, visit http://gerrit.ovirt.org/14327
To unsubscribe, vi
Alon Bar-Lev has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 4:
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ServletUtilsTest.java:19:8:
Unused import - java.i
Alon Bar-Lev has posted comments on this change.
Change subject: core: broken unit test
..
Patch Set 1:
testSendFile_PNGNoMime(org.ovirt.engine.core.utils.ServletUtilsTest) Time
elapsed: 0.009 sec <<< FAILURE!
Wanted but no
Alexander Wels has uploaded a new change for review.
Change subject: core: broken unit test
..
core: broken unit test
- Fixed a unit test that would break if a file didn't exist
in a certain environment.
Change-Id: I9d0627ea770
13 matches
Mail list logo
