Einav Cohen has posted comments on this change. Change subject: core: broken unit test ......................................................................
Patch Set 4: Alex/Alon: before I merge, just to make sure I understand what this patch is doing (and it should be reflected in the commit comment, BTW) - this unit-test was fixed by creating a temp file "on the fly" (without actually writing it to the disk) and using it for the unit test, rather than relying on a file that may or may not exist on the disk? -- To view, visit http://gerrit.ovirt.org/14327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d0627ea770a3194515b22b6d6cc5df5fe8df829 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches