automat...@ovirt.org has posted comments on this change.
Change subject: core: rename method parameters to be more clear.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit http://gerrit.ovirt.org/25
Maor Lipchuk has abandoned this change.
Change subject: core: rename method parameters to be more clear.
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/25348
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Allon Mureinik has posted comments on this change.
Change subject: core: rename method parameters to be more clear.
..
Patch Set 1:
I don't think the current state is good, I just think this patch does not
improve things. Unfo
Maor Lipchuk has posted comments on this change.
Change subject: core: rename method parameters to be more clear.
..
Patch Set 1:
The current code is not readable at all IMHO, it always takes me 5 times to
read it.
If you got
Liron Ar has posted comments on this change.
Change subject: core: rename method parameters to be more clear.
..
Patch Set 1:
I tend to agree with Allon
--
To view, visit http://gerrit.ovirt.org/25348
To unsubscribe, visit ht
Allon Mureinik has posted comments on this change.
Change subject: core: rename method parameters to be more clear.
..
Patch Set 1:
I don't feel this improves readability, frankly.
--
To view, visit http://gerrit.ovirt.org/25
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method parameters to be more clear.
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle
Maor Lipchuk has posted comments on this change.
Change subject: core: rename method parameters to be more clear.
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/25348
To unsubscribe, visit http://gerrit.o
automat...@ovirt.org has posted comments on this change.
Change subject: core: rename method parameters to be more clear.
..
Patch Set 1:
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous
Maor Lipchuk has uploaded a new change for review.
Change subject: core: rename method parameters to be more clear.
..
core: rename method parameters to be more clear.
Renaming the filterImageDisks method parameters to be more c
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in BaseHandler
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/84
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in BaseHandler
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_ge
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: rename method to lowercase in BaseHandler
..
core: rename method to lowercase in BaseHandler
Change-Id: Ia8911920fb0e183e25c4d1ccf00259feaf5d1948
Yair Zaslavsky has posted comments on this change.
Change subject: core: rename method to lowercase in BaseHandler
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21964
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: rename method to lowercase in BaseHandler
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21964
To unsubscribe, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: core: rename method to lowercase in BaseHandler
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21964
To unsubscribe, visit http://gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in BaseHandler
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/83
Tal Nisan has posted comments on this change.
Change subject: core: rename method to lowercase in BaseHandler
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21964
To unsubscribe, visit http://gerrit.ov
Alissa Bonas has uploaded a new change for review.
Change subject: core: rename method to lowercase in BaseHandler
..
core: rename method to lowercase in BaseHandler
Change-Id: Ia8911920fb0e183e25c4d1ccf00259feaf5d1948
Signed-of
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in Ticketing class
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in Ticketing class
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_maste
Oved Ourfali has posted comments on this change.
Change subject: core: rename method to lowercase in Ticketing class
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21898
To unsubscribe, visit http://gerri
Oved Ourfali has submitted this change and it was merged.
Change subject: core: rename method to lowercase in Ticketing class
..
core: rename method to lowercase in Ticketing class
Rename GenerateOTP to start with lowercase.
So
Oved Ourfali has posted comments on this change.
Change subject: core: rename method to lowercase in Ticketing class
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21898
To unsubscribe, visi
Oved Ourfali has posted comments on this change.
Change subject: core: rename method to lowercase in Ticketing class
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21898
To unsubscribe, visit http://ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method RunAdAction to lowercase in LdapBroker
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method RunAdAction to lowercase in LdapBroker
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in Ticketing class
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_maste
Yair Zaslavsky has posted comments on this change.
Change subject: core: rename method RunAdAction to lowercase in LdapBroker
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21889
To unsubscr
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: rename method RunAdAction to lowercase in LdapBroker
..
core: rename method RunAdAction to lowercase in LdapBroker
Rename method and its usages t
Alissa Bonas has posted comments on this change.
Change subject: core: rename method to lowercase in Ticketing class
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21898
To unsubscribe, visit http://gerri
Juan Hernandez has posted comments on this change.
Change subject: core: rename method RunAdAction to lowercase in LdapBroker
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21889
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: rename method RunAdAction to lowercase in LdapBroker
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21889
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: rename method RunAdAction to lowercase in LdapBroker
..
Patch Set 1:
@Juana - sorry, added you by mistake. I was aiming for Juan Hernandez and
mis-clicke
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in Ticketing class
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_maste
Alissa Bonas has uploaded a new change for review.
Change subject: core: rename method to lowercase in Ticketing class
..
core: rename method to lowercase in Ticketing class
Rename GenerateOTP to start with lowercase.
Solves a f
Alissa Bonas has posted comments on this change.
Change subject: core: rename method RunAdAction to lowercase in LdapBroker
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21889
To unsubscribe, visit http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method RunAdAction to lowercase in LdapBroker
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_t
Alissa Bonas has uploaded a new change for review.
Change subject: core: rename method RunAdAction to lowercase in LdapBroker
..
core: rename method RunAdAction to lowercase in LdapBroker
Rename method and its usages to lowercas
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in LdapBrokerCommandBase
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in LdapBrokerCommandBase
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to
Oved Ourfali has posted comments on this change.
Change subject: core: rename method to lowercase in LdapBrokerCommandBase
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21665
To unsubscribe
Oved Ourfali has submitted this change and it was merged.
Change subject: core: rename method to lowercase in LdapBrokerCommandBase
..
core: rename method to lowercase in LdapBrokerCommandBase
Solves a findbug warning.
Change-
Oved Ourfali has posted comments on this change.
Change subject: core: rename method to lowercase in LdapBrokerCommandBase
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21665
To unsubscribe, visit htt
Juan Hernandez has posted comments on this change.
Change subject: core: rename method to lowercase in LdapBrokerCommandBase
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21665
To unsubscribe, visit h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in EnumTranslator.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_maste
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in EnumTranslator.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_maste
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in EnumTranslator.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_maste
Tal Nisan has submitted this change and it was merged.
Change subject: core: rename method to lowercase in EnumTranslator.
..
core: rename method to lowercase in EnumTranslator.
Fixes a findbug warning.
Change-Id: I3cb44e65483
Tal Nisan has posted comments on this change.
Change subject: core: rename method to lowercase in EnumTranslator.
..
Patch Set 3: Verified+1 Code-Review+2
Rebased, fixed conflicts and verified by compiling + GWT and running tes
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in DbUserCacheManager
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_ma
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in DbUserCacheManager
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_ma
Tal Nisan has submitted this change and it was merged.
Change subject: core: rename method to lowercase in DbUserCacheManager
..
core: rename method to lowercase in DbUserCacheManager
Solves a findbug warning.
Change-Id: Id23a
Tal Nisan has posted comments on this change.
Change subject: core: rename method to lowercase in DbUserCacheManager
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21663
To unsubscribe, visi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in DbUserCacheManager
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_ma
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in SchedulingManager
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_mas
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in SchedulingManager
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_mas
Gilad Chaplik has posted comments on this change.
Change subject: core: rename method to lowercase in SchedulingManager
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21664
To unsubscribe, v
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: rename method to lowercase in SchedulingManager
..
core: rename method to lowercase in SchedulingManager
Change-Id: I9ac3f31b6ffd2d291be6d48342827
Allon Mureinik has posted comments on this change.
Change subject: core: rename method to lowercase in DbUserCacheManager
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21663
To unsubscribe, visit http
Allon Mureinik has posted comments on this change.
Change subject: core: rename method to lowercase in SchedulingManager
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21664
To unsubscribe, visit http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method in EventDistributionBalancePolicyUnit
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method in EventDistributionBalancePolicyUnit
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to
Doron Fediuck has posted comments on this change.
Change subject: core: rename method in EventDistributionBalancePolicyUnit
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21666
To unsubscrib
Doron Fediuck has submitted this change and it was merged.
Change subject: core: rename method in EventDistributionBalancePolicyUnit
..
core: rename method in EventDistributionBalancePolicyUnit
Change-Id: I08bcc8e20373943760090
Doron Fediuck has posted comments on this change.
Change subject: core: rename method in EventDistributionBalancePolicyUnit
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21666
To unsubscribe, visit ht
Alissa Bonas has posted comments on this change.
Change subject: core: rename method in EventDistributionBalancePolicyUnit
..
Patch Set 2: Verified+1
compilation + unitests
--
To view, visit http://gerrit.ovirt.org/21666
To u
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method in EventDistributionBalancePolicyUnit
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to
Allon Mureinik has posted comments on this change.
Change subject: core: rename method to lowercase in LdapBrokerCommandBase
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21665
To unsubscribe, visit h
Allon Mureinik has posted comments on this change.
Change subject: core: rename method in EventDistributionBalancePolicyUnit
..
Patch Set 2: Code-Review+1
@Alissa, please verify.
--
To view, visit http://gerrit.ovirt.org/2166
Gilad Chaplik has posted comments on this change.
Change subject: core: rename method in EventDistributionBalancePolicyUnit
..
Patch Set 2:
plz verify :-)
--
To view, visit http://gerrit.ovirt.org/21666
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in EnumTranslator.
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_maste
Alissa Bonas has posted comments on this change.
Change subject: core: rename method to lowercase in LdapBrokerCommandBase
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21665
To unsubscribe, visit http:/
Alissa Bonas has posted comments on this change.
Change subject: core: rename method to lowercase in SchedulingManager
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21664
To unsubscribe, visit http://ger
Alissa Bonas has posted comments on this change.
Change subject: core: rename method to lowercase in DbUserCacheManager
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21663
To unsubscribe, visit http://ge
Alissa Bonas has posted comments on this change.
Change subject: core: rename method to lowercase in EnumTranslator.
..
Patch Set 1: Verified+1
compiled including GWT webadmin, uncluding unitests.
--
To view, visit http://ger
Alissa Bonas has uploaded a new change for review.
Change subject: core: rename method to lowercase in EnumTranslator.
..
core: rename method to lowercase in EnumTranslator.
Fixes a findbug warning.
Change-Id: I3cb44e654838149c
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in LdapBrokerCommandBase
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in SchedulingManager
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_mas
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to lowercase in DbUserCacheManager
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_ma
Alissa Bonas has uploaded a new change for review.
Change subject: core: rename method to lowercase in LdapBrokerCommandBase
..
core: rename method to lowercase in LdapBrokerCommandBase
Solves a findbug warning.
Change-Id: I166
Alissa Bonas has uploaded a new change for review.
Change subject: core: rename method to lowercase in SchedulingManager
..
core: rename method to lowercase in SchedulingManager
Change-Id: I9ac3f31b6ffd2d291be6d48342827f47f7093d
Alissa Bonas has uploaded a new change for review.
Change subject: core: rename method to lowercase in DbUserCacheManager
..
core: rename method to lowercase in DbUserCacheManager
Solves a findbug warning.
Change-Id: Id23a4cd03
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to start w/lowercase in OvfWriter
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_mas
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to start w/lowercase in OvfWriter
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_mas
Omer Frenkel has submitted this change and it was merged.
Change subject: core: rename method to start w/lowercase in OvfWriter
..
core: rename method to start w/lowercase in OvfWriter
Solves a findbug warning.
Change-Id: I189
Omer Frenkel has posted comments on this change.
Change subject: core: rename method to start w/lowercase in OvfWriter
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21593
To unsubscribe, vi
Alissa Bonas has posted comments on this change.
Change subject: core: rename method to start w/lowercase in OvfWriter
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21593
To unsubscribe, visit http://ger
Omer Frenkel has posted comments on this change.
Change subject: core: rename method to start w/lowercase in OvfWriter
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21593
To unsubscribe, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to start w/lowercase in OvfWriter
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_mas
Alissa Bonas has uploaded a new change for review.
Change subject: core: rename method to start w/lowercase in OvfWriter
..
core: rename method to start w/lowercase in OvfWriter
Solves a findbug warning.
Change-Id: I18912375615
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method in class DNS
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/1285/
: S
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method in class DNS
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/1286/
: S
Tal Nisan has submitted this change and it was merged.
Change subject: core: rename method in class DNS
..
core: rename method in class DNS
Rename to start with lowercase to solve a findbug warning
Change-Id: Ib4df06aea33965a2
Tal Nisan has posted comments on this change.
Change subject: core: rename method in class DNS
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21358
To unsubscribe, visit http://gerrit.ovirt.
Tal Nisan has posted comments on this change.
Change subject: core: rename method in class DNS
..
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21358
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: rename method in class DNS
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21358
To unsubscribe, visit http://gerrit.ovirt.org/se
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method in class DNS
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/1280/
: S
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: rename method to loewrcase in AsyncTaskManager
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_mast
Alissa Bonas has uploaded a new change for review.
Change subject: core: rename method to loewrcase in AsyncTaskManager
..
core: rename method to loewrcase in AsyncTaskManager
Change-Id: Idd78086c1628422ab24f229927115c6bdf6670ba
1 - 100 of 229 matches
Mail list logo
